Re: [OS-BUILD PATCHv2] mod-denylist.sh: Change to denylist

2021-07-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1185#note_616422030 I assumed that it had to end in blacklist.conf but I see now that the code only looks *in* the file for a blacklist entry. I tested this by blacklisting the skx_edac driver,

Re: [OS-BUILD PATCHv2] mod-denylist.sh: Change to denylist

2021-06-29 Thread Herton R. Krzesinski (via Email Bridge)
From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1185#note_614689900 I think would be good to change ```$1-blacklist.conf``` to ```$1-denylist.conf``` here. ___ kernel mailing list --

Re: [OS-BUILD PATCHv2] mod-denylist.sh: Change to denylist

2021-06-29 Thread Justin M. Forbes (via Email Bridge)
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1185#note_614576989 > Yeah, but what's actually *intuitive*? I don't think calling it a `denylist` makes sense. In this case, it's an enable/disable list. Intuitive to a reader who doesn't ever deal

Re: [OS-BUILD PATCHv2] mod-denylist.sh: Change to denylist

2021-06-29 Thread Justin M. Forbes (via Email Bridge)
From: Justin M. Forbes on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1185#note_614524432 > Is this actually a `denylist` or a `disablelist`? This looks like a list for disabling modules... Or a list of modules to deny the privilege to load.

Re: [OS-BUILD PATCHv2] mod-denylist.sh: Change to denylist

2021-06-29 Thread Brian Masney (via Email Bridge)
From: Brian Masney on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1185#note_614435592 Acked-by: Brian Masney (via approve button) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

Re: [OS-BUILD PATCHv2] mod-denylist.sh: Change to denylist

2021-06-29 Thread Prarit Bhargava
On 6/29/21 9:51 AM, Prarit Bhargava (via Email Bridge) wrote: -check_blacklist() +check_denylist() { mod=$(find "$RpmDir/$ModDir" -name "$1") [ ! "$mod" ] && return 0 if modinfo "$mod" | grep -q '^alias:\s\+net-'; then mod="${1##*/}"

[OS-BUILD PATCHv2] mod-denylist.sh: Change to denylist

2021-06-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava mod-denylist.sh: Change to denylist Change blacklist references to denylist. v2: modprobe still uses blacklist Suggested-by: Brian Masney Signed-off-by: Prarit Bhargava diff --git a/redhat/mod-denylist.sh b/redhat/mod-denylist.sh index blahblah..blahblah 100755 ---