[OS-BUILD PATCHv2 18/24] redhat/Makefile: Cleanup KABI* variables.

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Cleanup KABI* variables. There is no need for both TARBALL and TARFILE variables. Cleanup the KABI* variables. Extra fix: Move KABIDW to the other KABI variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index

[OS-BUILD PATCHv2 21/24] redhat/Makfile: Deprecate BREW_FLAGS, KOJI_FLAGS, and TEST_FLAGS

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makfile: Deprecate BREW_FLAGS, KOJI_FLAGS, and TEST_FLAGS The BREW_FLAGS, KOJI_FLAGS, and TEST_FLAGS variables can be replaced with BUILD_FLAGS. Mark these three variables for later deprecation and warn users about their usage. Signed-off-by: Prarit Bhargava

Re: [OS-BUILD PATCHv2 0/24] redhat/Makefile: Cleanup variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1641#note_872576578 Fixed. Will push in a few minutes. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

Re: [OS-BUILD PATCHv2 0/24] redhat/Makefile: Cleanup variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1641#note_872578032 Fixed. Will push in a few minutes. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCHv3 22/24] redhat/Makefile: Move SNAPSHOT check

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move SNAPSHOT check Move the SNAPSHOT check to the only place where it can actually be "1". Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@

[OS-BUILD PATCHv3 23/24] redhat/Makefile: Add some descriptions

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Add some descriptions Add some descriptive text about some of the Makefile sections. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -1,4 +1,8

[OS-BUILD PATCHv3 24/24] redhat/Makefile: Reorganize variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Reorganize variables Reorganize the variables from simple variables to complex variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -35,8

[OS-BUILD PATCHv3 20/24] redhat/genspec.sh: Rework RPMVERSION variable

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec.sh: Rework RPMVERSION variable The redhat/genspec.sh file contains $RPMVERSION and $RPM_VERSION variables which don't match the Makefile variables. Create a new KVERSION variable and replace $RPMVERSION with KVERSION, and $RPM_VERSION with $RPMVERSION.

[OS-BUILD PATCHv3 19/24] redhat/Makefile: Remove dead comment

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove dead comment This comment no longer applies and can be dropped. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -96,10 +96,6 @@ ifeq

[OS-BUILD PATCHv3 21/24] redhat/Makefile: Deprecate BREW_FLAGS, KOJI_FLAGS, and TEST_FLAGS

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Deprecate BREW_FLAGS, KOJI_FLAGS, and TEST_FLAGS The BREW_FLAGS, KOJI_FLAGS, and TEST_FLAGS variables can be replaced with BUILD_FLAGS. Mark these three variables for later deprecation and warn users about their usage. Signed-off-by: Prarit Bhargava

[OS-BUILD PATCHv2 11/24] redhat/Makefile: Move RHGIT* variables to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move RHGIT* variables to Makefile.variables Mmove the RHGITURL and RHGITCOMMIT variables to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCHv2 6/24] redhat/Makefile: Move BUILD_TARGET and BUILD_SCRATCH_TARGET to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move BUILD_TARGET and BUILD_SCRATCH_TARGET to Makefile.variables Move BUILD_TARGET and BUILD_SCRATCH_TARGET to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 ---

[OS-BUILD PATCHv2 8/24] redhat/Makefile: Move BUILD_FLAGS to Makefile.variables.

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move BUILD_FLAGS to Makefile.variables. Move BUILD_FLAGS to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -229,6 +229,16

[OS-BUILD PATCHv2 13/24] redhat/Makefile: Move NO_CONFIGCHECKS to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move NO_CONFIGCHECKS to Makefile.variables Move the NO_CONFIGCHECKS variable to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile

[OS-BUILD PATCHv2 14/24] redhat/Makefile: Remove STAMP_VERSION

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove STAMP_VERSION STAMP_VERSION can be replaced with KVERSION. Remove STAMP_VERSION. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -5,10

[OS-BUILD PATCHv2 10/24] redhat/Makefile: Move PREBUILD_GIT_ONLY to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move PREBUILD_GIT_ONLY to Makefile.variables Move PREBUILD_GIT_ONLY to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@

[OS-BUILD PATCHv2 9/24] redhat/Makefile: Move BUILD to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move BUILD to Makefile.variables Move BUILD to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -101,7 +101,9 @@ endif

[OS-BUILD PATCHv2 4/24] redhat/Makefile: Cleanup DISTRO variable

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Cleanup DISTRO variable Move the DISTRO variable to Makefile.variables and clean up its usage in the Makfile. This creates separate fedora-specific, centos-specific, and 'other'-specific variable sections. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCHv2 12/24] redhat/Makefile: Move RHJOBS to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move RHJOBS to Makefile.variables Move RHJOBS to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -222,13 +222,15 @@ KABIDW

[OS-BUILD PATCHv2 16/24] redhat/scripts/create-tarball.sh: Use Makefile TARBALL variable

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts/create-tarball.sh: Use Makefile TARBALL variable Use the Makefile TARBALL variable instead of passing it as an argument. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile

[OS-BUILD PATCHv2 7/24] redhat/Makefile: Move BUILD_PROFILE to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move BUILD_PROFILE to Makefile.variables Move BUILD_PROFILE to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -140,7 +140,9

[OS-BUILD PATCHv2 5/24] redhat/Makefile: Remove RHPRODUCT variable

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove RHPRODUCT variable The only use of RHPRODUCT is to set the RHDISTGIT_BRANCH variable. Remove the RHPRODUCT variable and just use RHDISTGIT_BRANCH. This will make future change easier. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile

Re: [OS-BUILD PATCHv2 0/24] redhat/Makefile: Cleanup variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1641#note_872578273 Fixed. Will push in a few minutes. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCHv3 14/24] redhat/Makefile: Remove STAMP_VERSION

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove STAMP_VERSION STAMP_VERSION can be replaced with KVERSION. Remove STAMP_VERSION. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -5,10

[OS-BUILD PATCHv3 13/24] redhat/Makefile: Move NO_CONFIGCHECKS to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move NO_CONFIGCHECKS to Makefile.variables Move the NO_CONFIGCHECKS variable to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile

[OS-BUILD PATCHv3 17/24] redhat/Makefile.variables: Default RHGITCOMMIT to HEAD

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.variables: Default RHGITCOMMIT to HEAD RHGITCOMMIT is equal to HEAD. Rather than recalculating it, just set it to HEAD by default. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile.variables b/redhat/Makefile.variables index blahblah..blahblah

[OS-BUILD PATCHv3 15/24] redhat/Makefile: Remove extra DIST_BRANCH

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove extra DIST_BRANCH This is already declared in Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -547,7 +547,6 @@

[OS-BUILD PATCHv3 11/24] redhat/Makefile: Move RHGIT* variables to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move RHGIT* variables to Makefile.variables Mmove the RHGITURL and RHGITCOMMIT variables to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCHv3 9/24] redhat/Makefile: Move BUILD to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move BUILD to Makefile.variables Move BUILD to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -101,7 +101,9 @@ endif

[OS-BUILD PATCHv3 18/24] redhat/Makefile: Cleanup KABI* variables.

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Cleanup KABI* variables. There is no need for both TARBALL and TARFILE variables. Cleanup the KABI* variables. Extra fix: Move KABIDW to the other KABI variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index

[OS-BUILD PATCHv3 5/24] redhat/Makefile: Remove RHPRODUCT variable

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove RHPRODUCT variable The only use of RHPRODUCT is to set the RHDISTGIT_BRANCH variable. Remove the RHPRODUCT variable and just use RHDISTGIT_BRANCH. This will make future change easier. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile

[OS-BUILD PATCHv3 8/24] redhat/Makefile: Move BUILD_FLAGS to Makefile.variables.

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move BUILD_FLAGS to Makefile.variables. Move BUILD_FLAGS to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -229,6 +229,16

[OS-BUILD PATCHv3 12/24] redhat/Makefile: Move RHJOBS to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move RHJOBS to Makefile.variables Move RHJOBS to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -222,13 +222,15 @@ KABIDW

[OS-BUILD PATCHv3 10/24] redhat/Makefile: Move PREBUILD_GIT_ONLY to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move PREBUILD_GIT_ONLY to Makefile.variables Move PREBUILD_GIT_ONLY to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@

[OS-BUILD PATCHv3 16/24] redhat/scripts/create-tarball.sh: Use Makefile TARBALL variable

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts/create-tarball.sh: Use Makefile TARBALL variable Use the Makefile TARBALL variable instead of passing it as an argument. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile

[OS-BUILD PATCHv2 3/24] redhat/Makefile: Move HEAD to Makefile.variables.

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move HEAD to Makefile.variables. Move HEAD to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -9,7 +9,6 @@ RPMBUILD :=

[OS-BUILD PATCHv2 2/24] redhat: Combine Makefile and Makefile.common

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat: Combine Makefile and Makefile.common The only include of Makefile.common is the Makefile. Combine the two files in Makefile. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCHv2 1/24] redhat/koji/Makefile: Decouple koji Makefile from Makefile.common

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/koji/Makefile: Decouple koji Makefile from Makefile.common The koji Makefile uses the GIT and PACKAGE_NAME variables which are currently defined in Makefile.common. Since these are configurable by a user they should actually be defined in Makefile.variables. Move

[OS-BUILD PATCHv2 0/24] redhat/Makefile: Cleanup variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1641 For a long time we have complained about disorganization in the redhat/Makefile. This was because the code was separated into several Makefiles (Makefile.cross, Makefile.rhpkg,

Re: [OS-BUILD PATCH 0/24] redhat/Makefile: Cleanup variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1641#note_872561098 v2: DISTRO_BUILD must be evaluated after the VERSION_ON_UPSTREAM check as DISTRO_BUILD depends on PREBUILD. Move DISTRO_BUILD, KABI_TARBALL, and the KABIDW* variables after the

[OS-BUILD PATCHv3 6/24] redhat/Makefile: Move BUILD_TARGET and BUILD_SCRATCH_TARGET to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move BUILD_TARGET and BUILD_SCRATCH_TARGET to Makefile.variables Move BUILD_TARGET and BUILD_SCRATCH_TARGET to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 ---

[OS-BUILD PATCHv3 2/24] redhat: Combine Makefile and Makefile.common

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat: Combine Makefile and Makefile.common The only include of Makefile.common is the Makefile. Combine the two files in Makefile. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

Re: [OS-BUILD PATCHv2 0/24] redhat/Makefile: Cleanup variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1641#note_872579104 v3: Fixed @hertonk-rh comments ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCHv3 4/24] redhat/Makefile: Cleanup DISTRO variable

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Cleanup DISTRO variable Move the DISTRO variable to Makefile.variables and clean up its usage in the Makefile. This creates separate fedora-specific, centos-specific, and 'other'-specific variable sections. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCHv3 0/24] redhat/Makefile: Cleanup variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1641 For a long time we have complained about disorganization in the redhat/Makefile. This was because the code was separated into several Makefiles (Makefile.cross, Makefile.rhpkg,

[OS-BUILD PATCHv3 3/24] redhat/Makefile: Move HEAD to Makefile.variables.

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move HEAD to Makefile.variables. Move HEAD to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -9,7 +9,6 @@ RPMBUILD :=

[OS-BUILD PATCHv3 1/24] redhat/koji/Makefile: Decouple koji Makefile from Makefile.common

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/koji/Makefile: Decouple koji Makefile from Makefile.common The koji Makefile uses the GIT and PACKAGE_NAME variables which are currently defined in Makefile.common. Since these are configurable by a user they should actually be defined in Makefile.variables. Move

[OS-BUILD PATCHv3 7/24] redhat/Makefile: Move BUILD_PROFILE to Makefile.variables

2022-03-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move BUILD_PROFILE to Makefile.variables Move BUILD_PROFILE to Makefile.variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -140,7 +140,9

Re: [OS-BUILD PATCH] redhat: configs: disable the surface platform

2022-02-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1621#note_849976214 I know of no requirement to make a CONFIG change this way. What @darcari has done is correct AFAICT. ___ kernel mailing list --

[OS-BUILD PATCHv3] redhat/Makefile: Fix dist-dump-variables target

2022-02-24 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Fix dist-dump-variables target The existing dist-dump-variables didn't output all the variables. Fix the target so that it outputs all the Makefile variables. v2: dzickus pointed out that the self-tests use the dist-dump-variables target. Added

Re: [OS-BUILD PATCH] redhat/Makefile.common: Fix BUILD_SCRATCH_TARGET

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1628#note_857411782 Re: RHEL9, yes, this change is ONLY for ARK so that users can execute 'make dist-brew DIST=".el9"'. I still have modifications to be made to fix the 'DIST=".el9"' issue as well and

Re: [OS-BUILD PATCH] redhat/Makefile.common: Fix BUILD_SCRATCH_TARGET

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1628#note_857407907 Re SCRATCH_TARGET: Is it used by koji? ``` [prarit@prarit kernel-ark]$ git grep SCRATCH_TARGET redhat/ redhat/Makefile:32:BUILD_TARGET ?= --scratch $(BUILD_SCRATCH_TARGET)

Re: [OS-BUILD PATCH] redhat/self-test: Delete release test 3

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1636#note_857402918 The comparison in the test for the release tags doesn't seem to valid AFAICT. The last entry of the changelog doesn't match the last tag in the kernel anymore. ie) right now, git

Re: [OS-BUILD PATCH] redhat/Makefile.common: Fix BUILD_SCRATCH_TARGET

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1628#note_857432057 Ah I see now. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCHv2 8/8] redhat/configs/build_configs.sh: Parallelize execution

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Parallelize execution Parallelize the execution of each config building. The '+' adds job processing to 'non-make' commands [1]. [1] https://www.gnu.org/software/make/manual/html_node/Error-Messages.html Signed-off-by: Prarit Bhargava

[OS-BUILD PATCHv2 6/8] redhat/configs/build_configs.sh: Create unique output files

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Create unique output files Create unique output files from merge_configs(). Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/build_configs.sh b/redhat/configs/build_configs.sh index blahblah..blahblah 100755 ---

Re: [OS-BUILD PATCHv3 0/8] process_configs.sh: Add parallel processing of configs in dist-configs

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1635#note_857826318 > Also in your CONFIG_HID example, is it intended to print the messages twice but in a different order? Fixed in new push. ___ kernel

[OS-BUILD PATCHv2 0/8] process_configs.sh: Add parallel processing of configs in dist-configs

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1635 The dist-configs target takes an annoying long time. Add parallel processing of configs in dist-configs. Testing Info make dist-configs time 1m22.909s

[OS-BUILD PATCHv2 2/8] redhat/configs/process_configs.sh: Create unique output files

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Create unique output files Create unique output files from process_config(). Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/process_configs.sh b/redhat/configs/process_configs.sh index blahblah..blahblah 100755 ---

[OS-BUILD PATCHv2 3/8] redhat/configs/process_configs.sh: Provide better messages

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Provide better messages Provide better error messages. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/process_configs.sh b/redhat/configs/process_configs.sh index blahblah..blahblah 100755 ---

[OS-BUILD PATCHv2 4/8] redhat/configs/process_configs.sh: Parallelize execution

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Parallelize execution Parallelize the execution of each config processing. The '+' adds job processing to 'non-make' commands [1]. [1] https://www.gnu.org/software/make/manual/html_node/Error-Messages.html Signed-off-by: Prarit

Re: [OS-BUILD PATCH] process_configs.sh: Add parallel processing of configs in dist-configs

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1635#note_857758405 v2: Separated patch into 8 patches. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCHv2 1/8] redhat/configs/process_configs.sh: Add processing config function

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Add processing config function Move the code to process a config into its own function. This will make future changes easier. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/process_configs.sh

Re: [OS-BUILD PATCH] process_configs.sh: Add parallel processing of configs in dist-configs

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1635#note_857757928 Yep, just pushed an 8-part v2. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCHv2 7/8] redhat/configs/build_configs.sh: Provide better messages

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Provide better messages Provide better error messages. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/build_configs.sh b/redhat/configs/build_configs.sh index blahblah..blahblah 100755 --- a/redhat/configs/build_configs.sh

[OS-BUILD PATCHv2 5/8] redhat/configs/build_configs.sh: Add local variables

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Add local variables Add local variables to the merge_configs function. This will make future changes for parallel processing easier. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/build_configs.sh

[OS-BUILD PATCHv3 1/8] redhat/configs/process_configs.sh: Add processing config function

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Add processing config function Move the code to process a config into its own function. This will make future changes easier. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/process_configs.sh

Re: [OS-BUILD PATCHv3 0/8] process_configs.sh: Add parallel processing of configs in dist-configs

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1635#note_857826487 v3: Fix double output in mismatch case. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

Re: [OS-BUILD PATCHv2 0/8] process_configs.sh: Add parallel processing of configs in dist-configs

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1635#note_857821910 >@prarit - thanks for splitting it out! It mostly seems fine. Though I feel the need to run this locally to review the output. Cool. You no longer have time to make a cup of

[OS-BUILD PATCH] redhat/self-test: Delete release test 3

2022-02-26 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Delete release test 3 This test is no longer valid and should be deleted. Signed-off-by: Prarit Bhargava diff --git a/redhat/self-test/2001-dist-release.bats b/redhat/self-test/2001-dist-release.bats index blahblah..blahblah 100644 ---

[OS-BUILD PATCHv3 0/8] process_configs.sh: Add parallel processing of configs in dist-configs

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1635 The dist-configs target takes an annoying long time. Add parallel processing of configs in dist-configs. Testing Info make dist-configs time 1m22.909s

[OS-BUILD PATCHv3 2/8] redhat/configs/process_configs.sh: Create unique output files

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Create unique output files Create unique output files from process_config(). Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/process_configs.sh b/redhat/configs/process_configs.sh index blahblah..blahblah 100755 ---

[OS-BUILD PATCHv3 3/8] redhat/configs/process_configs.sh: Provide better messages

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Provide better messages Provide better error messages. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/process_configs.sh b/redhat/configs/process_configs.sh index blahblah..blahblah 100755 ---

[OS-BUILD PATCHv3 4/8] redhat/configs/process_configs.sh: Parallelize execution

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Parallelize execution Parallelize the execution of each config processing. The '+' adds job processing to 'non-make' commands [1]. [1] https://www.gnu.org/software/make/manual/html_node/Error-Messages.html Signed-off-by: Prarit

[OS-BUILD PATCHv3 7/8] redhat/configs/build_configs.sh: Provide better messages

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Provide better messages Provide better error messages. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/build_configs.sh b/redhat/configs/build_configs.sh index blahblah..blahblah 100755 --- a/redhat/configs/build_configs.sh

[OS-BUILD PATCHv3 8/8] redhat/configs/build_configs.sh: Parallelize execution

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Parallelize execution Parallelize the execution of each config building. The '+' adds job processing to 'non-make' commands [1]. [1] https://www.gnu.org/software/make/manual/html_node/Error-Messages.html Signed-off-by: Prarit Bhargava

[OS-BUILD PATCHv3 6/8] redhat/configs/build_configs.sh: Create unique output files

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Create unique output files Create unique output files from merge_configs(). Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/build_configs.sh b/redhat/configs/build_configs.sh index blahblah..blahblah 100755 ---

[OS-BUILD PATCHv3 5/8] redhat/configs/build_configs.sh: Add local variables

2022-02-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Add local variables Add local variables to the merge_configs function. This will make future changes for parallel processing easier. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/build_configs.sh

[OS-BUILD PATCH] configs/process_configs.sh: Remove orig files

2022-02-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava configs/process_configs.sh: Remove orig files When executing 'make dist-configs' there are extra redhat/configs/*.orig files left lying around. This occurs because the orig files are being created for 'EMPTY' variants and then the code immediately continues to the next

[OS-BUILD PATCH] redhat/Makefile.common: Fix BUILD_SCRATCH_TARGET

2022-02-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.common: Fix BUILD_SCRATCH_TARGET BUILD_SCRATCH_TARGET is only used by the dist-brew and distg-brew targets, and should be set to an appropriate brew target. Set BUILD_SCRATCH_TARGET to the latest RHEL brew target. Signed-off-by: Prarit Bhargava diff

Re: [OS-BUILD PATCH] redhat/configs: Disable CONFIG_MACINTOSH_DRIVERS in RHEL.

2022-02-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1612#note_851202307 >At least for the PPC this is already disabled in Fedora so some of these should go to common not ark. ___ kernel mailing list --

Re: [OS-BUILD PATCH] redhat/configs: Disable CONFIG_MACINTOSH_DRIVERS in RHEL.

2022-02-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1612#note_851205164 >What does this affect by disabling this for x86? Intel Macs are some of the most powerful Linux PCs out there today and will likely be used as more with Linux as Apple aggressively

[OS-BUILD PATCH] redhat/Makefile: Fix dist-dump-variables target

2022-02-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Fix dist-dump-variables target The existing dist-dump-variables didn't output all the variables. Fix the target so that it outputs all the Makefile variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index

Re: [OS-BUILD PATCHv2 0/0] Add Partner Supported taint flag

2022-02-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1603#note_852694138 Unblocking this :) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

Re: [OS-BUILD PATCHv2] redhat/configs: Disable CONFIG_MACINTOSH_DRIVERS in RHEL.

2022-03-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1612#note_859308209 @jmflinuxtx @dledford @dhorak1 reviews please. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

Re: [OS-BUILD PATCH] redhat/koji/Makefile: Remove Makefile.common dependency

2022-03-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1637#note_859312338 @jmflinuxtx , should the KERNEL variable actually be defined in Makefile.variables? If it is something that is being changed from project-to- project then shouldn't it be in that

Re: [OS-BUILD PATCH] redhat/koji/Makefile: Remove Makefile.common dependency

2022-03-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1637#note_858688482 I knew it wasn't going to be that easy :smile: ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

Re: [OS-BUILD PATCH] redhat/self-test: Delete release test 3

2022-03-02 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1636#note_860202807 Thanks for the feedback on this. I badly assumed there had been a model change but with the information I see that the test was actually trying to correctly report a bug. Here's

[OS-BUILD PATCH 0/2] redhat/genspec.sh: Remove options and use Makefile variables

2022-03-02 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1638 genspec.sh has _22_ parameters that must be specified on the command line which are generated by the Makefile. These parameters can be set in the script by using the output of the

[OS-BUILD PATCH 2/2] redhat: Unify genspec.sh and kernel.spec variable names

2022-03-02 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat: Unify genspec.sh and kernel.spec variable names Use common variable names between genspec.sh and kernel.spec. Signed-off-by: Prarit Bhargava diff --git a/redhat/genspec.sh b/redhat/genspec.sh index blahblah..blahblah 100755 --- a/redhat/genspec.sh +++

[OS-BUILD PATCH 1/2] redhat/genspec.sh: Remove options and use Makefile variables

2022-03-02 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec.sh: Remove options and use Makefile variables genspec.sh has _22_ parameters that must be specified on the command line which are generated by the Makefile. These parameters can be set in the script by using the output of the dist-dump-variables target

[OS-BUILD PATCH] redhat/koji/Makefile: Remove Makefile.common dependency

2022-03-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/koji/Makefile: Remove Makefile.common dependency Hardcode "kernel" and remove the Makefile.common dependency. There is no behaviour change introduced with this change and is a first step in the de-spaghettification of Makefile.common. If deemed necessary, we can

[OS-BUILD PATCHv4 1/8] redhat/configs/process_configs.sh: Add processing config function

2022-03-02 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Add processing config function Move the code to process a config into its own function. This will make future changes easier. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/process_configs.sh

[OS-BUILD PATCHv4 0/8] process_configs.sh: Add parallel processing of configs in dist-configs

2022-03-02 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1635 The dist-configs target takes an annoying long time. Add parallel processing of configs in dist-configs. Testing Info make dist-configs time 1m22.909s

[OS-BUILD PATCHv4 2/8] redhat/configs/process_configs.sh: Create unique output files

2022-03-02 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Create unique output files Create unique output files from process_config(). Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/process_configs.sh b/redhat/configs/process_configs.sh index blahblah..blahblah 100755 ---

[OS-BUILD PATCHv4 4/8] redhat/configs/process_configs.sh: Parallelize execution

2022-03-02 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Parallelize execution Parallelize the execution of each config processing. The '+' adds job processing to 'non-make' commands [1]. [1] https://www.gnu.org/software/make/manual/html_node/Error-Messages.html Signed-off-by: Prarit

[OS-BUILD PATCHv4 3/8] redhat/configs/process_configs.sh: Provide better messages

2022-03-02 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Provide better messages Provide better error messages. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/process_configs.sh b/redhat/configs/process_configs.sh index blahblah..blahblah 100755 ---

[OS-BUILD PATCHv4 8/8] redhat/configs/build_configs.sh: Parallelize execution

2022-03-02 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Parallelize execution Parallelize the execution of each config building. The '+' adds job processing to 'non-make' commands [1]. [1] https://www.gnu.org/software/make/manual/html_node/Error-Messages.html Signed-off-by: Prarit Bhargava

[OS-BUILD PATCHv4 5/8] redhat/configs/build_configs.sh: Add local variables

2022-03-02 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Add local variables Add local variables to the merge_configs function. This will make future changes for parallel processing easier. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/build_configs.sh

[OS-BUILD PATCHv4 6/8] redhat/configs/build_configs.sh: Create unique output files

2022-03-02 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Create unique output files Create unique output files from merge_configs(). Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/build_configs.sh b/redhat/configs/build_configs.sh index blahblah..blahblah 100755 ---

<    1   2   3   4   5   6   7   8   9   10   >