Re: [OS-BUILD PATCHv6 0/3] redhat: Switch KABI file compression to xz

2023-10-30 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2760#note_1626463715 With the current version of tar AFAICT, the "J" isn't necessary. Yeah, that surprised me too. ___ kernel mailing list --

[OS-BUILD PATCHv4 1/3] redhat/kernel.spec.template: Switch KABI compression to xz

2023-10-25 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/kernel.spec.template: Switch KABI compression to xz Switch KABI compression to xz. There's no reason it has to be bz2. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCHv4 2/3] redhat/scripts: Switch KABI tarballs to xz

2023-10-25 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts: Switch KABI tarballs to xz Switch the KABI tarballs to xz. Signed-off-by: Prarit Bhargava diff --git a/redhat/scripts/rh-dist-git.sh b/redhat/scripts/rh-dist-git.sh index blahblah..blahblah 100755 --- a/redhat/scripts/rh-dist-git.sh +++

[OS-BUILD PATCHv4 3/3] redhat/self-test: Update data for KABI xz change

2023-10-25 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Update data for KABI xz change The extension on the KABI files has changed from bz2 to xz. Signed-off-by: Prarit Bhargava diff --git a/redhat/self-test/data/centos-2585cf9dfaad.el7 b/redhat/self-test/data/centos-2585cf9dfaad.el7 index

[OS-BUILD PATCHv4 0/3] redhat: Switch KABI file compression to xz

2023-10-25 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2760 Switch the KABI compression from bz2 to xz to match other compression targets. Signed-off-by: Prarit Bhargava --- redhat/scripts/rh-dist-git.sh | 4 ++--

[OS-BUILD PATCHv5 3/3] redhat/self-test: Update data for KABI xz change

2023-10-25 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Update data for KABI xz change The extension on the KABI files has changed from bz2 to xz. Signed-off-by: Prarit Bhargava diff --git a/redhat/self-test/data/centos-2585cf9dfaad.el7 b/redhat/self-test/data/centos-2585cf9dfaad.el7 index

[OS-BUILD PATCHv5 1/3] redhat/kernel.spec.template: Switch KABI compression to xz

2023-10-25 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/kernel.spec.template: Switch KABI compression to xz Switch KABI compression to xz. There's no reason it has to be bz2. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCHv5 0/3] redhat: Switch KABI file compression to xz

2023-10-25 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2760 Switch the KABI compression from bz2 to xz to match other compression targets. Signed-off-by: Prarit Bhargava --- redhat/scripts/rh-dist-git.sh | 4 ++--

[OS-BUILD PATCHv5 2/3] redhat/scripts: Switch KABI tarballs to xz

2023-10-25 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts: Switch KABI tarballs to xz Switch the KABI tarballs to xz. Signed-off-by: Prarit Bhargava diff --git a/redhat/scripts/rh-dist-git.sh b/redhat/scripts/rh-dist-git.sh index blahblah..blahblah 100755 --- a/redhat/scripts/rh-dist-git.sh +++

Re: [OS-BUILD PATCHv3 1/3] redhat/kernel.spec.template: Switch KABI compression to xz

2023-10-25 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2760#note_1618227797 Thanks. Both fixed. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCHv3] kernel.spec.template: Fix --without bpftool

2023-09-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava kernel.spec.template: Fix --without bpftool The selftests turn bpftool on unconditionally. If a user has specified --without bpftool it means the user really wants to disable bpftool. In this case the selftest should be disabled. Disable selftests and output a message

[OS-BUILD PATCHv3 2/3] redhat/Makefile.cross: Add message for disabled subpackages

2023-09-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.cross: Add message for disabled subpackages Add a message for the disabled subpackages. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile.cross b/redhat/Makefile.cross index blahblah..blahblah 100644 --- a/redhat/Makefile.cross +++

[OS-BUILD PATCHv3 3/3] redhat/self-test: Update data for cross compile fields

2023-09-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Update data for cross compile fields Add CROSS_DISABLED_SUBPACKAGES and update .DEFAULT_GOAL, which now points to dist-cross-setup. Signed-off-by: Prarit Bhargava diff --git a/redhat/self-test/data/centos-2585cf9dfaad.el7

[OS-BUILD PATCHv3 0/3] redhat/Makefile.cross: Disable subpackages

2023-09-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2723 There are subpackages that won't compile due to architectural differences and cross compiling packaging issues. Disable these packages from cross compiling. This shouldn't be a

[OS-BUILD PATCHv3 1/3] redhat/Makefile.cross: Update cross targets with disabled subpackages

2023-09-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.cross: Update cross targets with disabled subpackages The bpftool, perf, and tools subpackages require architecture-specific packages and currently cannot be built with the existing cross compiler packages. Disable them for cross compiler builds.

Re: [OS-BUILD PATCHv3] kernel.spec.template: Fix --without bpftool

2023-09-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2720#note_1572279089 I've fixed this in the latest push. But the MR still seems to fail but I can't see an actual test failure? @mh21 any ideas? I just see a red x with no actual test.

Re: [OS-BUILD PATCHv2] kernel.spec.template: Fix --without bpftool

2023-09-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2720#note_1569520971 Odd .. this seems to have failed a CI check. Looking into it now. ___ kernel mailing list -- kernel@lists.fedoraproject.org To

[OS-BUILD PATCH 0/2] redhat/Makefile.cross: Disable subpackages

2023-09-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2723 There are subpackages that won't compile due to architectural differences and cross compiling packaging issues. Disable these packages from cross compiling. This shouldn't be a

[OS-BUILD PATCH 1/2] redhat/Makefile.cross: Update cross targets with disabled subpackages

2023-09-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.cross: Update cross targets with disabled subpackages The bpftool, perf, and tools subpackages require architecture-specific packages and currently cannot be built with the existing cross compiler packages. Disable them for cross compiler builds.

[OS-BUILD PATCH 2/2] redhat/Makefile.cross: Add message for disabled subpackages

2023-09-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.cross: Add message for disabled subpackages Add a message for the disabled subpackages. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile.cross b/redhat/Makefile.cross index blahblah..blahblah 100644 --- a/redhat/Makefile.cross +++

Re: [OS-BUILD PATCH 0/2] Add rpmbuild --without base option

2023-09-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2719#note_1569939433 I'm with @tales-aparecida on ths, please fixup the commit. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send

Re: [OS-BUILD PATCH] enable CONFIG_ADDRESS_MASKING for x86_64

2023-10-04 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2735#note_1589699422 Could this break crash and other debug utilities? ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email

Re: [OS-BUILD PATCHv2] kernel.spec.template: Fix --without bpftool

2023-09-20 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2720#note_1567874681 I updated the message to be a bit more generic. Instead of referencing 'without bpftool' the rpm log will output 'bpftools disabled ... disabling selftests' I've also removed

[OS-BUILD PATCHv2] kernel.spec.template: Fix --without bpftool

2023-09-20 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava kernel.spec.template: Fix --without bpftool The selftests turn bpftool on unconditionally. If a user has specified --without bpftool it means the user really wants to disable bpftool. In this case the selftest should be disabled. Disable selftests and output a message

[OS-BUILD PATCH] kernel.spec.template: Fix --without bpftool

2023-09-20 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava kernel.spec.template: Fix --without bpftool The selftests turn bpftool on unconditionally. If a user has specified --without bpftool it means the user really wants to disable bpftool. In this case the selftest should be disabled. Disable selftests and output a message

Re: [OS-BUILD PATCH] kernel.spec.template: Fix --without bpftool

2023-09-20 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2720#note_1567706714 Yeah, TBH, I was thinking this might be better? ``` # selftests require bpftool to be built %if %{with_bpftool} == 0 %{echo:Disabling selftests build: '--without bpftool'

Re: [OS-BUILD PATCHv3] kernel.spec.template: Fix --without bpftool

2023-09-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2720#note_1572901766 Ah thanks :) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCHv2 0/3] redhat/Makefile.cross: Disable subpackages

2023-09-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2723 There are subpackages that won't compile due to architectural differences and cross compiling packaging issues. Disable these packages from cross compiling. This shouldn't be a

[OS-BUILD PATCHv2 2/3] redhat/Makefile.cross: Add message for disabled subpackages

2023-09-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.cross: Add message for disabled subpackages Add a message for the disabled subpackages. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile.cross b/redhat/Makefile.cross index blahblah..blahblah 100644 --- a/redhat/Makefile.cross +++

[OS-BUILD PATCHv2 1/3] redhat/Makefile.cross: Update cross targets with disabled subpackages

2023-09-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.cross: Update cross targets with disabled subpackages The bpftool, perf, and tools subpackages require architecture-specific packages and currently cannot be built with the existing cross compiler packages. Disable them for cross compiler builds.

[OS-BUILD PATCHv2 3/3] redhat/self-test: Update data for cross compile fields

2023-09-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Update data for cross compile fields Add CROSS_DISABLED_SUBPACKAGES and update .DEFAULT_GOAL, which now points to dist-cross-setup. Signed-off-by: Prarit Bhargava diff --git a/redhat/self-test/data/centos-2585cf9dfaad.el7

[OS-BUILD PATCH] RHMAINTAINERS: Update for Oct 2 2023

2023-10-02 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava RHMAINTAINERS: Update for Oct 2 2023 Update RHMAINTAINERS to latest. Signed-off-by: Prarit Bhargava diff --git a/redhat/rhdocs/MAINTAINERS/RHMAINTAINERS b/redhat/rhdocs/MAINTAINERS/RHMAINTAINERS index blahblah..blahblah 100644 ---

[OS-BUILD PATCH] redhat: shellcheck fixes

2023-08-17 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat: shellcheck fixes shellcheck fixes for scripts in redhat/ directory. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/build_configs.sh b/redhat/configs/build_configs.sh index blahblah..blahblah 100755 --- a/redhat/configs/build_configs.sh +++

[OS-BUILD PATCH] redhat/self-test: Remove rpmlint test

2023-08-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Remove rpmlint test rpmlint reports errors and warnings on syntax and variable usage in spec files. Hundreds of errors are reported when rpmlint is run on the kernel.spec. These errors are for everything from RPM_BUILD_ROOT usage to listing unversioned

Re: [OS-BUILD PATCH] redhat: drop unneeded build-time dependency gcc-plugin-devel

2023-08-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2656#note_1532006980 @coxu , ISTR doing this same thing a while ago. IIRC, there were valid use cases for the dependency. @jmflinuxtx do you recall what they were? I'm light on details now. It

Re: [OS-BUILD PATCH] redhat: drop unneeded build-time dependency gcc-plugin-devel

2023-08-28 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2656#note_1532305939 I think you're right @jmflinuxtx , kpatch didn't need to the config but did need the tool. That's why the dependency is there. @joe.lawrence can you confirm?

Re: [OS-BUILD PATCH] Fix tarball creation logic

2023-08-29 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2658#note_1533599549 Maybe ``` # convert to short string sha ``` ? ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCH 1/16] redhat/Makefile: Use KVERSION

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Use KVERSION Use KVERSION where appropriate in the Makefile. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -144,8 +144,8 @@ else

[OS-BUILD PATCH 15/16] redhat/Makefile: Add 'duplicate' SPEC entries for user set variables

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Add 'duplicate' SPEC entries for user set variables INCLUDE_FEDORA_FILES, INCLUDE_RHEL_FILES, and RELEASED_KERNEL are specified in Makefile.variables as they can be set in userspace. Create duplicate entries for these variables that begin with SPEC. This

[OS-BUILD PATCH 14/16] redhat/Makefile: Rename TARFILE_RELEASE to SPECTARFILE_RELEASE

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Rename TARFILE_RELEASE to SPECTARFILE_RELEASE Change TARFILE_RELEASE to SPECTARFILE_RELEASE so that readers understand it is passed into the spec file. Rename TARFILE_RELEASE to SPECTARFILE_RELEASE. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCH 2/18] redhat/Makefile: Deprecate some simple targets

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Deprecate some simple targets Deprecate some simple targets. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -418,15 +418,23 @@

[OS-BUILD PATCH 16/16] redhat/self-test: Add test to verify SPEC variables

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add test to verify SPEC variables This test looks at the spec file variable replacement code in redhat/genspec.sh and confirms that each variable begins with "SPEC". Signed-off-by: Prarit Bhargava diff --git a/redhat/docs/makefile-changes.rst

[OS-BUILD PATCH 13/16] redhat/genspec: Rename PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec: Rename PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG Change PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG so that readers understand it is passed into the spec file. Rename PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG. Signed-off-by: Prarit Bhargava

[OS-BUILD PATCH 2/16] redhat/Makefile: Deprecate some simple targets

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Deprecate some simple targets Deprecate some simple targets. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -418,15 +418,23 @@

[OS-BUILD PATCH 12/18] redhat/genspec: Rename DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec: Rename DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED Change DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED so that readers understand it is passed into the spec file. Rename DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED. Signed-off-by: Prarit

[OS-BUILD PATCH 1/18] redhat/Makefile: Use KVERSION

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Use KVERSION Use KVERSION where appropriate in the Makefile. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -144,8 +144,8 @@ else

[OS-BUILD PATCH 8/18] redhat/Makefile: Rename CHANGELOG to SPECCHANGELOG

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Rename CHANGELOG to SPECCHANGELOG Change CHANGELOG to SPECCHANGELOG so that readers understand it is passed into the spec file. While the CHANGELOG does have use other than in the spec file it is useful to know that the string is used in the spec file.

[OS-BUILD PATCH 16/18] redhat/self-test: Add test to verify SPEC variables

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add test to verify SPEC variables This test looks at the spec file variable replacement code in redhat/genspec.sh and confirms that each variable begins with "SPEC". Signed-off-by: Prarit Bhargava diff --git a/redhat/docs/makefile-changes.rst

[OS-BUILD PATCH 0/18] redhat: test updates

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1728 Depends: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727 Add a test to verify Makefile declarations, and add the RHTEST variable. The latter of these changes allows

[OS-BUILD PATCH 14/18] redhat/Makefile: Rename TARFILE_RELEASE to SPECTARFILE_RELEASE

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Rename TARFILE_RELEASE to SPECTARFILE_RELEASE Change TARFILE_RELEASE to SPECTARFILE_RELEASE so that readers understand it is passed into the spec file. Rename TARFILE_RELEASE to SPECTARFILE_RELEASE. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCH 5/18] redhat/Makfile: Rename RPMKPATCHLEVEL to SPECKPATCHLEVEL

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makfile: Rename RPMKPATCHLEVEL to SPECKPATCHLEVEL Change RPMKPATCHLEVEL to SPECPATCHLEVEL so that readers understand it is passed into the spec file. Rename RPMKPATCHLEVEL to SPECKPATCHLEVEL. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile

[OS-BUILD PATCH 13/18] redhat/genspec: Rename PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec: Rename PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG Change PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG so that readers understand it is passed into the spec file. Rename PATCHLIST_CHANGELOG to SPECPATCHLIST_CHANGELOG. Signed-off-by: Prarit Bhargava

[OS-BUILD PATCH 7/18] redhat/Makfile: Rename RPMKEXTRAVERSION to SPECKEXTRAVERSION

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makfile: Rename RPMKEXTRAVERSION to SPECKEXTRAVERSION Change RPMKEXTRAVERSION to SPECEXTRAVERSION so that readers understand it is passed into the spec file. Rename RPMKEXTRAVERSION to SPECKEXTRAVERSION. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCH 11/18] redhat/Makefile: Rename DISTRO_BUILD to SPECDISTROBUILD

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Rename DISTRO_BUILD to SPECDISTROBUILD Change DISTRO_BUILD to SPECDISTROBUILD so that readers understand it is passed into the spec file. Rename DISTRO_BUILD to SPECDISTROBUILD. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile

[OS-BUILD PATCH 4/18] redhat/Makefile: Rename RPMKVERSION to SPECKVERSION

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Rename RPMKVERSION to SPECKVERSION Change RPMKVERSION to SPECVERSION so that readers understand it is passed into the spec file. Rename RPMKVERSION to SPECKVERSION. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index

[OS-BUILD PATCH 3/16] redhat/Makefile: Rename KVERSION to SPECVERSION

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Rename KVERSION to SPECVERSION KVERSION is passed into the spec file and is easy to confuse with the kernel KVERSION. Change the name to SPECVERSION so that readers understand it is the %Version field of the specfile. As a result RPMKSUBLEVEL can be

[OS-BUILD PATCH 9/16] redhat/genspec: Rename BUILDID_DEFINE to SPECBUILDID

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec: Rename BUILDID_DEFINE to SPECBUILDID Change BUILDID_DEFINE to SPECBUILDID so that readers understand it is passed into the spec file. Rename BUILDID_DEFINE to SPECBUILDID. Signed-off-by: Prarit Bhargava diff --git a/redhat/genspec.sh b/redhat/genspec.sh

[OS-BUILD PATCH 8/16] redhat/Makefile: Rename CHANGELOG to SPECCHANGELOG

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Rename CHANGELOG to SPECCHANGELOG Change CHANGELOG to SPECCHANGELOG so that readers understand it is passed into the spec file. While the CHANGELOG does have use other than in the spec file it is useful to know that the string is used in the spec file.

[OS-BUILD PATCH 12/16] redhat/genspec: Rename DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec: Rename DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED Change DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED so that readers understand it is passed into the spec file. Rename DEBUG_BUILDS_ENABLED to SPECDEBUG_BUILDS_ENABLED. Signed-off-by: Prarit

[OS-BUILD PATCH 10/16] redhat/Makefile: Rename PKGRELEASE to SPECBUILD

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Rename PKGRELEASE to SPECBUILD PKGRELEASE is a confusing variable name, and it really is the BUILD string for the specfile. Rename PKGRELEASE to SPECBUILD. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index

[OS-BUILD PATCH 6/16] redhat/Makfile: Rename RPMKSUBLEVEL to SPECKSUBLEVEL

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makfile: Rename RPMKSUBLEVEL to SPECKSUBLEVEL Change RPMKSUBLEVEL to SPECSUBLEVEL so that readers understand it is passed into the spec file. Rename RPMKSUBLEVEL to SPECKSUBLEVEL. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile

[OS-BUILD PATCH 4/16] redhat/Makefile: Rename RPMKVERSION to SPECKVERSION

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Rename RPMKVERSION to SPECKVERSION Change RPMKVERSION to SPECVERSION so that readers understand it is passed into the spec file. Rename RPMKVERSION to SPECKVERSION. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index

[OS-BUILD PATCH 7/16] redhat/Makfile: Rename RPMKEXTRAVERSION to SPECKEXTRAVERSION

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makfile: Rename RPMKEXTRAVERSION to SPECKEXTRAVERSION Change RPMKEXTRAVERSION to SPECEXTRAVERSION so that readers understand it is passed into the spec file. Rename RPMKEXTRAVERSION to SPECKEXTRAVERSION. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCH 5/16] redhat/Makfile: Rename RPMKPATCHLEVEL to SPECKPATCHLEVEL

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makfile: Rename RPMKPATCHLEVEL to SPECKPATCHLEVEL Change RPMKPATCHLEVEL to SPECPATCHLEVEL so that readers understand it is passed into the spec file. Rename RPMKPATCHLEVEL to SPECKPATCHLEVEL. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile

[OS-BUILD PATCH 11/16] redhat/Makefile: Rename DISTRO_BUILD to SPECDISTROBUILD

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Rename DISTRO_BUILD to SPECDISTROBUILD Change DISTRO_BUILD to SPECDISTROBUILD so that readers understand it is passed into the spec file. Rename DISTRO_BUILD to SPECDISTROBUILD. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile

[OS-BUILD PATCH 0/16] redhat: Use SPEC variable naming

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1727 Depends: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647 One of the common complaints about the redhat Makefiles, genspec.sh, and kernel.spec.template is that it is

[OS-BUILD PATCH 6/18] redhat/Makfile: Rename RPMKSUBLEVEL to SPECKSUBLEVEL

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makfile: Rename RPMKSUBLEVEL to SPECKSUBLEVEL Change RPMKSUBLEVEL to SPECSUBLEVEL so that readers understand it is passed into the spec file. Rename RPMKSUBLEVEL to SPECKSUBLEVEL. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile

[OS-BUILD PATCH 18/18] redhat/self-test: Add test to verify Makefile declarations.

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add test to verify Makefile declarations. The Makefiles have been organized such that only Makefile.variables contain external variables that can be set on the command line, and the Makefile only contains variables that can set within the Makefile itself.

[OS-BUILD PATCH 10/18] redhat/Makefile: Rename PKGRELEASE to SPECBUILD

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Rename PKGRELEASE to SPECBUILD PKGRELEASE is a confusing variable name, and it really is the BUILD string for the specfile. Rename PKGRELEASE to SPECBUILD. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index

[OS-BUILD PATCH 9/18] redhat/genspec: Rename BUILDID_DEFINE to SPECBUILDID

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec: Rename BUILDID_DEFINE to SPECBUILDID Change BUILDID_DEFINE to SPECBUILDID so that readers understand it is passed into the spec file. Rename BUILDID_DEFINE to SPECBUILDID. Signed-off-by: Prarit Bhargava diff --git a/redhat/genspec.sh b/redhat/genspec.sh

[OS-BUILD PATCH 15/18] redhat/Makefile: Add 'duplicate' SPEC entries for user set variables

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Add 'duplicate' SPEC entries for user set variables INCLUDE_FEDORA_FILES, INCLUDE_RHEL_FILES, and RELEASED_KERNEL are specified in Makefile.variables as they can be set in userspace. Create duplicate entries for these variables that begin with SPEC. This

[OS-BUILD PATCH 3/18] redhat/Makefile: Rename KVERSION to SPECVERSION

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Rename KVERSION to SPECVERSION KVERSION is passed into the spec file and is easy to confuse with the kernel KVERSION. Change the name to SPECVERSION so that readers understand it is the %Version field of the specfile. As a result RPMKSUBLEVEL can be

[OS-BUILD PATCH 17/18] redhat/Makefile: Add RHTEST

2022-04-22 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Add RHTEST For a long time we have wanted a mechanism by which we could do a 'test run' of Makefile targets. Make has built-in options '-n, --just-print, --dry-run, --recon' that can be added on the command line that allow users to show the output for

Re: [OS-BUILD PATCHv7 0/11] redhat: Use Makefile variables in scripts

2022-04-20 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647#note_918402722 What command are you running? Let me try it from my side and debug. ___ kernel mailing list -- kernel@lists.fedoraproject.org To

[OS-BUILD PATCHv8 0/11] redhat: Use Makefile variables in scripts

2022-04-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1647 Use Makefile variables in scripts that are called from the Makefile. Signed-off-by: Prarit Bhargava --- redhat/configs/build_configs.sh | 18 ++---

[OS-BUILD PATCHv8 11/11] redhat/self-test: Clean up data set

2022-04-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Clean up data set After running 'make dist-self-test-data' it was noticed that there have been changes made to the kernel.spec file since the self-test data was introduced and a few more variables need to be changed for testing purposes. Additional fix:

[OS-BUILD PATCHv8 6/11] redhat/Makefile: Use RPMVERSION

2022-04-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Use RPMVERSION Use RPMVERSION where appropriate in the Makefile. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -199,7 +199,7 @@

[OS-BUILD PATCHv8 3/11] redhat/configs/process_configs.sh: Use Makefile variables

2022-04-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/process_configs.sh: Use Makefile variables Cleanup up parameters and use Makefile variables in process_config.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCHv8 5/11] redhat/scripts/rh-dist-git.sh: Use Makefile variables

2022-04-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts/rh-dist-git.sh: Use Makefile variables Use Makefile variables in rh-dist-git.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -637,7 +637,7 @@

[OS-BUILD PATCHv8 1/11] redhat/configs/generate_all_configs.sh: Use Makefile variables

2022-04-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/generate_all_configs.sh: Use Makefile variables Use Makefile variables in generate_all_configs.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@

[OS-BUILD PATCHv8 10/11] redhat/Makefile.rhpkg: Remove quotes for RHDISTGIT

2022-04-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.rhpkg: Remove quotes for RHDISTGIT Remove the quotes around RHDISTGIT. This causes problems with the bash scripts in the dist-git-test target. Signed-off-by: Justin M. Forbes Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile.rhpkg

[OS-BUILD PATCHv8 7/11] redhat/Makefile: Move SINGLE_TARBALL to Makefile.variables

2022-04-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move SINGLE_TARBALL to Makefile.variables Move the SINGLE_TARBALL variable to Makefile.variables, and clean up comments. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile

[OS-BUILD PATCHv8 8/11] redhat/Makefile: Deprecate SINGLE_TARBALL

2022-04-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Deprecate SINGLE_TARBALL We don't know if there are any users of the SINGLE_TARBALL variable. Mark it for deprection. This commit can be reverted if anyone complains. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index

[OS-BUILD PATCHv8 2/11] redhat/kernel.spec.template: Use RPM_BUILD_NCPUS

2022-04-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/kernel.spec.template: Use RPM_BUILD_NCPUS RPM_BUILD_NCPUS allows users to modify the max number of cpus used by the RPM build. Use the RPM_BUILD_NCPUS variable in the spec file. Signed-off-by: Prarit Bhargava diff --git a/redhat/kernel.spec.template

[OS-BUILD PATCHv8 9/11] redhat/scripts/create-tarball.sh: Use Makefile variables

2022-04-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts/create-tarball.sh: Use Makefile variables Use Makefile variables in redhat/scripts/create-tarball.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile

[OS-BUILD PATCHv8 4/11] redhat/configs/build_configs.sh: Use Makefile variables

2022-04-21 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/build_configs.sh: Use Makefile variables Use Makefile variables in build_configs.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -363,8 +363,8

[OS-BUILD PATCH 2/2] redhat/README.Makefile: Add a Makefile README file

2022-03-18 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/README.Makefile: Add a Makefile README file Add a Makefile README file that explains the layout of the Makefiles, and the policies for modifying the Makefiles. Signed-off-by: Prarit Bhargava diff --git a/redhat/README.Makefile b/redhat/README.Makefile new file

[OS-BUILD PATCH 1/2] redhat/Makefile: Remove duplicated code

2022-03-18 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove duplicated code This code was left in place when the variables were reorganized. It can be safely removed. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCH 0/2] redhat: Add a Makefile README

2022-03-18 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1652 Add a MAkefile README that details what the redhat/Makefiles are and how they are to be modified. Signed-off-by: Prarit Bhargava --- redhat/Makefile| 22

[OS-BUILD PATCH] RHMAINTAINERS: Update for Mar 18 2022

2022-03-18 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava RHMAINTAINERS: Update for Mar 18 2022 Update RHMAINTAINERS to latest. Signed-off-by: Prarit Bhargava diff --git a/redhat/rhdocs/MAINTAINERS/RHMAINTAINERS b/redhat/rhdocs/MAINTAINERS/RHMAINTAINERS index blahblah..blahblah 100644 ---

[OS-BUILD PATCH] redhat/Makefile: Drop quotation marks around string definitions

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Drop quotation marks around string definitions dzickus reports that 'make dist-srpm-gcov' doesn't work anymore. Not only is an error reported, error: line 555: Illegal char '"' (0x22) in: Release: 0.rc7.53".gcov".fc35 error: query of specfile

Re: [OS-BUILD PATCHv3 0/17] redhat/Makefile: General improvements and fixes

2022-05-17 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757#note_949498999 Resolving thread based on above comment. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

Re: [OS-BUILD PATCHv3 0/17] redhat/Makefile: General improvements and fixes

2022-05-17 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757#note_949496617 >It definitely depends on the repo. I think I had so more garbage that it inflated things. 'git gc' removed enough junk that my 'git log --oneline' is down to 12. > >Looking into

[OS-BUILD PATCH] redhat/Makefile.variables: Change git hash length to default

2022-05-17 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile.variables: Change git hash length to default After some discussion on the Fedora Kernel Mailing List [1] we have decided to switch back to the default git hash length. [1]

Re: [OS-BUILD PATCH 3/3] [redhat] Add dist-buildreq-check for binary rpm builds

2022-05-18 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1786#note_951632878 I understand why you've named this 'do-rpmbuild-binary' but I think that will be confusing to a casual reader. At first glance I thought it implied that do-rpmbuild is for

Re: [OS-BUILD PATCH 1/3] [redhat] Explicitly set srpm requirements

2022-05-18 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1786#note_951640333 OOC what happens if the SRPM builds correctly, but something like 'dist-configs-check' fails because there are missing BuildRequires? IOW, is SPECSRPMBUILDREQS really complete?

Re: [OS-BUILD PATCH 0/3] Implement better SRPM BuildRequires check

2022-05-18 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1786#note_951641657 @hertonrk-rh @jmflinuxtx : I think we just all asked the same question of @dzickusrh, but in slightly different ways :smile: ___ kernel

[OS-BUILD PATCH 3/4] redhat/self-test: Update data

2022-05-19 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Update data Update data due to recent changes in the redhat/Makefile, kernel specfile, and redhat/self-test/data/create-data.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/self-test/data/centos-2585cf9dfaad.el7

[OS-BUILD PATCH 0/4] redhat/self-tests: Add self-tests to gitlab-ci.yaml

2022-05-19 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1741 The test directory is already out-of-date with respect to changes make to the spec file. To avoid this happening with future changes, add the execution of the self-tests to

[OS-BUILD PATCH 2/4] redhat/self-test: Unset Makefile variables

2022-05-19 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Unset Makefile variables While testing I noticed that the redhat/self-test/data had UPSTREAMBUILD_GIT_ONLY always set to "1". This occurs because the Makefile variables are passed into the create-data.sh script. They need to be unset before the data is

<    2   3   4   5   6   7   8   9   10   11   >