[OS-BUILD PATCH 1/4] redhat/self-test: Omit SHELL variable from test data

2022-05-19 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Omit SHELL variable from test data The SHELL variable reports the shell that is executed by the user. This obviously may vary from user to user, so it can be dropped. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCH 4/4] redhat: Add self-tests to .gitlab-ci.yml

2022-05-19 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat: Add self-tests to .gitlab-ci.yml Add a run of the self-tests to .gitlab-ci.yml to avoid the test data getting stale. Signed-off-by: Prarit Bhargava diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index blahblah..blahblah 100644 --- a/.gitlab-ci.yml +++

Re: [OS-BUILD PATCHv4] redhat/docs: Add a description of kernel naming

2022-05-31 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1779#note_966500459 @hertonrk-rh @jmflinuxtx -- approvals please? ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCH] redhat/configs/README: Update the README

2022-05-31 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/README: Update the README The information in this file was a bit out-of-date and needed a refresh. Update the README. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/README b/redhat/configs/README index blahblah..blahblah 100644 ---

[OS-BUILD PATCHv4] redhat/docs: Add a description of kernel naming

2022-05-25 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/docs: Add a description of kernel naming Add a file that describes how kernel NVRs are constructed. Signed-off-by: Prarit Bhargava diff --git a/redhat/docs/index.rst b/redhat/docs/index.rst index blahblah..blahblah 100644 --- a/redhat/docs/index.rst +++

[OS-BUILD PATCH] redhat/self-test/data: Update data set

2022-05-23 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test/data: Update data set Update the data set. Outdated data is causing tests to fail. Signed-off-by: Prarit Bhargava diff --git a/redhat/self-test/data/centos-2585cf9dfaad.el7 b/redhat/self-test/data/centos-2585cf9dfaad.el7 index blahblah..blahblah

[OS-BUILD PATCH] redhat/Makefile: Add SPECKABIVERSION variable

2022-06-02 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Add SPECKABIVERSION variable Empty kabi tarballs are uploaded to dist-git everytime an .eln build is completed. These empty kabi tarballs waste disk space. In addition to this, new users that recompile the kernel often attempt to update the specversion

[OS-BUILD PATCH 2/4] redhat/self-test: self-test data update

2022-06-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: self-test data update Fixup the self-test data wrt the last commit. Signed-off-by: Prarit Bhargava diff --git a/redhat/self-test/data/centos-2585cf9dfaad.el7 b/redhat/self-test/data/centos-2585cf9dfaad.el7 index blahblah..blahblah 100644 ---

[OS-BUILD PATCH 0/4] redhat: Fixup self-tests

2022-06-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1800 The merge window exposed a bug in the redhat/self-test/data/create-data.sh script where the local variables were being reported instead of the test variables. Fix the create-data.sh

[OS-BUILD PATCH 4/4] self-test: Fixup dist release test

2022-06-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava self-test: Fixup dist release test The dist release test expects *one* BUILD value. With the latest changes it is possible that two are output. Fix the dist release test to check only one BUILD value. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCH 1/4] redhat/self-test: Fix up create-data.sh to not report local variables

2022-06-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Fix up create-data.sh to not report local variables Fix the create-data.sh script by moving the reporting of the Makefile.variables into the dist-dump-variables target. This has the minor annoyance that dist-dump-variables will report Makefile.variables

[OS-BUILD PATCH 3/4] self-test: Fixup Makefile contents test

2022-06-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava self-test: Fixup Makefile contents test The redhat/Makefile contains a "?=" that is caught up in the grep of the Makefile contents test [1]. Ignore the match in the test. [1] redhat/Makefile:716 @cat Makefile.variables | grep -v "^#" | sed '/^$$/d' | tr -d " " | awk -F

Re: [OS-BUILD PATCH] redhat/configs/README: Update the README

2022-06-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1841#note_968036746 >For some reason you indented here. This was intentional to indicate that it fell under the pending-* section. I'll just move it over a few spaces. I'm neither here nor there on

Re: [OS-BUILD PATCH] redhat/configs/README: Update the README

2022-06-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1841#note_968037233 >Another indentation issue, but more importantly I think you need to specify which config file. Ditto :) ___ kernel mailing list --

Re: [OS-BUILD PATCH] redhat/configs/README: Update the README

2022-06-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1841#note_968034619 >I think a an example, such as: "For instance, ark/rhel only support x86_64; however, fedora supports x86 (32-bit)" - makes sense. Heh :) Not calling out a specific difference was

[OS-BUILD PATCHv2] redhat/configs/README: Update the README

2022-06-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs/README: Update the README The information in this file was a bit out-of-date and needed a refresh. Update the README. Signed-off-by: Prarit Bhargava diff --git a/redhat/configs/README b/redhat/configs/README index blahblah..blahblah 100644 ---

Re: [OS-BUILD PATCHv2] redhat/configs/README: Update the README

2022-06-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1841#note_968039019 New version pushed after feedback in MR. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCHv2] redhat/docs: Add a description of kernel naming

2022-05-13 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/docs: Add a description of kernel naming Add a file that describes how kernel NVRs are constructed. Signed-off-by: Prarit Bhargava diff --git a/redhat/docs/index.rst b/redhat/docs/index.rst index blahblah..blahblah 100644 --- a/redhat/docs/index.rst +++

Re: [OS-BUILD PATCH] redhat/docs: Add a description of kernel naming

2022-05-13 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1779#note_945831127 Yep. Fixed. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

Re: [OS-BUILD PATCH] redhat/docs: Add a description of kernel naming

2022-05-13 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1779#note_945877674 >> which variables directly affected the SPEC file and which were used for other reasons in the Makefile. > >But is that relevant for people that do anything with kernel-ark or only

Re: [OS-BUILD PATCH] redhat/docs: Add a description of kernel naming

2022-05-13 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1779#note_945837742 >Just out of curiosity, as it looks inconsistent (but I guess there might be a deeper reasoning behind if): why has one variable a "PACKAGE" prefix (with underscore behind it), and

Re: [OS-BUILD PATCH] redhat/docs: Add a description of kernel naming

2022-05-13 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1779#note_945846156 >Ohh, and another quick comment: with all the changes you are currently preparing for the makefiles, how hard would it be to start making things like this a bit more neutral for

[OS-BUILD PATCHv2 6/17] redhat/Makefile: Rename RPMVERSION to BASEVERSION

2022-05-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Rename RPMVERSION to BASEVERSION RPMVERSION is the rpm NVR without the dist tag. It is not the RPM version so RPMVERSION is not an accurate name for this field. Rename RPMVERSION to BASEVERSION. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCHv2 3/17] redhat/Makefile: Add kernel-NVR comment

2022-05-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Add kernel-NVR comment Add a comment explaining the variables used in constructing the kernel package's NVR, and reorganize the variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 ---

[OS-BUILD PATCHv2 2/17] redhat/Makefile: Use SPECFILE variable

2022-05-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Use SPECFILE variable Use the SPECFILE variable throughout the Makefiles. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -548,7 +548,7 @@

[OS-BUILD PATCHv2 1/17] redhat/Makefile: Remove KEXTRAVERSION

2022-05-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove KEXTRAVERSION KEXTRAVERSION isn't used for anything and can be removed. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -147,11 +147,9 @@

[OS-BUILD PATCHv2 0/17] redhat/Makefile: General improvements and fixes

2022-05-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757 Depends: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1728 This is a collection of various improvements and fixes for the redhat/Makefile variables. These fixes

[OS-BUILD PATCHv2 4/17] redhat/Makefile: Move SPECRELEASE to genspec.sh

2022-05-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move SPECRELEASE to genspec.sh Move SPECRELEASE to genspec.sh. It is the only place it is used. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@

[OS-BUILD PATCHv2 5/17] redhat/Makefile: Target whitespace cleanup

2022-05-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Target whitespace cleanup Some simple whitespace cleanups. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -442,7 +442,6 @@ $(KABIDW_TARBALL):

[OS-BUILD PATCHv2 9/17] redhat/kernel.spec.template: Move genspec variables into one section

2022-05-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/kernel.spec.template: Move genspec variables into one section Move the genspec variables into one section. This re-introduces the SPECKVERSION variable into the specfile. Additional fix: add a tarfile_release variable that maps to SPECTARFILE_RELEASE.

[OS-BUILD PATCHv2 17/17] self-test/data/create-data.sh: Avoid SINGLE_TARBALL warning

2022-05-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava self-test/data/create-data.sh: Avoid SINGLE_TARBALL warning 'make dist-self-test-data' outputs the warning "Makefile:25: WARNING: SINGLE_TARBALL will be deprecated in a later release." Unset the parameter before the make calls. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCHv2 16/17] redhat/Makefile: Rename PREBUILD to UPSTREAMBUILD

2022-05-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Rename PREBUILD to UPSTREAMBUILD PREBUILD isn't a good name for this variable. It is the portion of the string that references upstream build information. Rename it to UPSTREAMBUILD. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile

[OS-BUILD PATCHv2 14/17] redhat/Makefile: Fix dist-brew & distg-brew targets

2022-05-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Fix dist-brew & distg-brew targets The dist-brew and distg-brew targets always require some variable manipulation on the command line. Hardcode DIST, DISTRO, and SCRATCH_TARGET to always create a "RHEL9" brew build. Signed-off-by: Prarit Bhargava diff

[OS-BUILD PATCHv2 10/17] redhat/genspec.sh: Add comment about SPECBUILDID variable

2022-05-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec.sh: Add comment about SPECBUILDID variable Add a comment about the non-obvious use of SPECBUILDID in the specfile. Move the definition of SPECRELEASE to a better location. Signed-off-by: Prarit Bhargava diff --git a/redhat/genspec.sh b/redhat/genspec.sh

[OS-BUILD PATCHv2 11/17] redhat/Makefile: Rename __YSTREAM and __ZSTREAM

2022-05-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Rename __YSTREAM and __ZSTREAM The __YSTREAM and __ZSTREAM names can be replaced with YSTREAM_FLAG and ZSTREAM_FLAG. This makes future changes easier. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index

[OS-BUILD PATCHv2 7/17] redhat/Makefile: Add SPECTARFILE_RELEASE comment

2022-05-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Add SPECTARFILE_RELEASE comment Add comment about the SPECTARFILE_RELEASE variable. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -246,11

[OS-BUILD PATCHv2 15/17] redhat/Makefile: Rename BUILDID to LOCALVERSION

2022-05-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Rename BUILDID to LOCALVERSION BUILDID isn't a very descriptive name. Rename the variable to LOCALVERSION. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCHv2 12/17] redhat/scripts/new_release.sh: Use Makefile variables

2022-05-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts/new_release.sh: Use Makefile variables Use Makefile variables in new_release.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -607,7 +607,7 @@

[OS-BUILD PATCHv2 8/17] redhat/kernel.spec.template: Remove kversion

2022-05-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/kernel.spec.template: Remove kversion Remove kversion. It is unused. Signed-off-by: Prarit Bhargava diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100755 --- a/redhat/kernel.spec.template +++

[OS-BUILD PATCHv2 13/17] redhat/Makefile: Reorganize MARKER code

2022-05-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Reorganize MARKER code Reorganize the MARKER code. MARKER is always UPSTREAM_TARBALL_NAME prefixed with a 'v'. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

Re: [OS-BUILD PATCH 0/17] redhat/Makefile: General improvements and fixes

2022-05-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757#note_944835271 >- [3/17] `030f50682c27` ("redhat/Makefile: Add kernel-NVR comment") > > Is there any reason to make RELEASETAG variable a recursively expanded variable instead of simply expanded

Re: [OS-BUILD PATCH] redhat/self-test/data: Update data set

2022-05-24 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1790#note_958620059 Hmm, I'm confused. This passed for this MR yesterday. I'll have to take a closer look. Perhaps it is best to disable the selftests from running (ie, revert the latest commit to

Re: [OS-BUILD PATCH] redhat/self-test/data: Update data set

2022-05-25 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1790#note_959641472 @ptalbert , I did some digging and I think I know what is wrong. As you pointed out, the MRs are succeeding with this MR's commit reverted. Can you please do a revert on this

Re: [OS-BUILD PATCH 0/4] redhat/self-tests: Add self-tests to gitlab-ci.yaml

2022-05-19 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1741#note_953343509 Log of self-tests being run in merge phase: https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki-internal-pipelines/cki- trusted-contributors/-/jobs/2480728702#L104

[OS-BUILD PATCHv2 0/4] redhat/self-tests: Add self-tests to gitlab-ci.yaml

2022-05-19 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1741 The test directory is already out-of-date with respect to changes make to the spec file. To avoid this happening with future changes, add the execution of the self-tests to

[OS-BUILD PATCHv2 2/4] redhat/self-test: Unset Makefile variables

2022-05-19 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Unset Makefile variables While testing I noticed that the redhat/self-test/data had UPSTREAMBUILD_GIT_ONLY always set to "1". This occurs because the Makefile variables are passed into the create-data.sh script. They need to be unset before the data is

[OS-BUILD PATCHv2 1/4] redhat/self-test: Omit SHELL variable from test data

2022-05-19 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Omit SHELL variable from test data The SHELL variable reports the shell that is executed by the user. This obviously may vary from user to user, so it can be dropped. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCHv2 3/4] redhat/self-test: Update data

2022-05-19 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Update data Update data due to recent changes in the redhat/Makefile, kernel specfile, and redhat/self-test/data/create-data.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/self-test/data/centos-2585cf9dfaad.el7

[OS-BUILD PATCHv2 4/4] redhat: Add self-tests to .gitlab-ci.yml

2022-05-19 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat: Add self-tests to .gitlab-ci.yml Add a run of the self-tests to .gitlab-ci.yml to avoid the test data getting stale. Signed-off-by: Prarit Bhargava diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index blahblah..blahblah 100644 --- a/.gitlab-ci.yml +++

Re: [OS-BUILD PATCHv2 0/17] redhat/Makefile: General improvements and fixes

2022-05-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757#note_945045363 >I quickly took a look at the state of things after this patchset and noticed a few odd things I thought I mention; some or all of them are from before this patchset, but with all

[OS-BUILD PATCH] redhat/configs: Fix rm warning on error

2022-05-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/configs: Fix rm warning on error When an unset config is found, process_configs.sh cleans up and returns an error. In this case the .newconfigs file is not created and errors like rm: cannot remove '.newoptions18': No such file or directory rm: cannot remove

Re: [OS-BUILD PATCHv2 0/17] redhat/Makefile: General improvements and fixes

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757#note_948197881 Oh, I should add we're trying to get this done this week to avoid a 3-4 week slip for rebasing and -rc2/-rc3. ___ kernel mailing list --

Re: [OS-BUILD PATCHv2 0/17] redhat/Makefile: General improvements and fixes

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757#note_948196822 @knurd42 , can you open issues for these changes? That way they'll be tracked and we can resolve this thread which doesn't impact *this* MR.

[OS-BUILD PATCH] redhat/docs: Add a description of kernel naming

2022-05-12 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/docs: Add a description of kernel naming Add a file that describes how kernel NVRs are constructed. Signed-off-by: Prarit Bhargava diff --git a/redhat/docs/index.rst b/redhat/docs/index.rst index blahblah..blahblah 100644 --- a/redhat/docs/index.rst +++

Re: [OS-BUILD PATCHv3] redhat/docs: Add a description of kernel naming

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1779#note_948492571 Fixed. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org

[OS-BUILD PATCHv3] redhat/docs: Add a description of kernel naming

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/docs: Add a description of kernel naming Add a file that describes how kernel NVRs are constructed. Signed-off-by: Prarit Bhargava diff --git a/redhat/docs/index.rst b/redhat/docs/index.rst index blahblah..blahblah 100644 --- a/redhat/docs/index.rst +++

[OS-BUILD PATCHv3 2/17] redhat/Makefile: Use SPECFILE variable

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Use SPECFILE variable Use the SPECFILE variable throughout the Makefiles. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -548,7 +548,7 @@

[OS-BUILD PATCHv3 3/17] redhat/Makefile: Add kernel-NVR comment

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Add kernel-NVR comment Add a comment explaining the variables used in constructing the kernel package's NVR, and reorganize the variables. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 ---

[OS-BUILD PATCHv3 1/17] redhat/Makefile: Remove KEXTRAVERSION

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove KEXTRAVERSION KEXTRAVERSION isn't used for anything and can be removed. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -147,11 +147,9 @@

[OS-BUILD PATCHv3 0/17] redhat/Makefile: General improvements and fixes

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757 Depends: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1728 This is a collection of various improvements and fixes for the redhat/Makefile variables. These fixes

[OS-BUILD PATCHv3 5/17] redhat/Makefile: Target whitespace cleanup

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Target whitespace cleanup Some simple whitespace cleanups. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -442,7 +442,6 @@ $(KABIDW_TARBALL):

[OS-BUILD PATCHv3 9/17] redhat/kernel.spec.template: Move genspec variables into one section

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/kernel.spec.template: Move genspec variables into one section Move the genspec variables into one section. This re-introduces the SPECKVERSION variable into the specfile. Additional fix: add a tarfile_release variable that maps to SPECTARFILE_RELEASE.

[OS-BUILD PATCHv3 17/17] self-test/data/create-data.sh: Avoid SINGLE_TARBALL warning

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava self-test/data/create-data.sh: Avoid SINGLE_TARBALL warning 'make dist-self-test-data' outputs the warning "Makefile:25: WARNING: SINGLE_TARBALL will be deprecated in a later release." Unset the parameter before the make calls. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCHv3 6/17] redhat/Makefile: Rename RPMVERSION to BASEVERSION

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Rename RPMVERSION to BASEVERSION RPMVERSION is the rpm NVR without the dist tag. It is not the RPM version so RPMVERSION is not an accurate name for this field. Rename RPMVERSION to BASEVERSION. Signed-off-by: Prarit Bhargava diff --git

[OS-BUILD PATCHv3 7/17] redhat/Makefile: Add SPECTARFILE_RELEASE comment

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Add SPECTARFILE_RELEASE comment Add comment about the SPECTARFILE_RELEASE variable. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -246,11

[OS-BUILD PATCHv3 13/17] redhat/Makefile: Reorganize MARKER code

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Reorganize MARKER code Reorganize the MARKER code. MARKER is always UPSTREAM_TARBALL_NAME prefixed with a 'v'. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCHv3 14/17] redhat/Makefile: Fix dist-brew & distg-brew targets

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Fix dist-brew & distg-brew targets The dist-brew and distg-brew targets always require some variable manipulation on the command line. Hardcode DIST, DISTRO, and SCRATCH_TARGET to always create a "RHEL9" brew build. Signed-off-by: Prarit Bhargava diff

[OS-BUILD PATCHv3 15/17] redhat/Makefile: Rename BUILDID to LOCALVERSION

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Rename BUILDID to LOCALVERSION BUILDID isn't a very descriptive name. Rename the variable to LOCALVERSION. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++

[OS-BUILD PATCHv3 11/17] redhat/Makefile: Rename __YSTREAM and __ZSTREAM

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Rename __YSTREAM and __ZSTREAM The __YSTREAM and __ZSTREAM names can be replaced with YSTREAM_FLAG and ZSTREAM_FLAG. This makes future changes easier. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index

[OS-BUILD PATCHv3 4/17] redhat/Makefile: Move SPECRELEASE to genspec.sh

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Move SPECRELEASE to genspec.sh Move SPECRELEASE to genspec.sh. It is the only place it is used. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@

[OS-BUILD PATCHv3 8/17] redhat/kernel.spec.template: Remove kversion

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/kernel.spec.template: Remove kversion Remove kversion. It is unused. Signed-off-by: Prarit Bhargava diff --git a/redhat/kernel.spec.template b/redhat/kernel.spec.template index blahblah..blahblah 100755 --- a/redhat/kernel.spec.template +++

[OS-BUILD PATCHv3 12/17] redhat/scripts/new_release.sh: Use Makefile variables

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/scripts/new_release.sh: Use Makefile variables Use Makefile variables in new_release.sh. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 --- a/redhat/Makefile +++ b/redhat/Makefile @@ -607,7 +607,7 @@

[OS-BUILD PATCHv3 10/17] redhat/genspec.sh: Add comment about SPECBUILDID variable

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/genspec.sh: Add comment about SPECBUILDID variable Add a comment about the non-obvious use of SPECBUILDID in the specfile. Move the definition of SPECRELEASE to a better location. Signed-off-by: Prarit Bhargava diff --git a/redhat/genspec.sh b/redhat/genspec.sh

Re: [OS-BUILD PATCHv3 0/17] redhat/Makefile: General improvements and fixes

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1757#note_948629446 Sorry everyone, I had to re-push. I noticed a small bug in which the localversion was not being properly reflected in the spec file. ___

[OS-BUILD PATCHv3 16/17] redhat/Makefile: Rename PREBUILD to UPSTREAMBUILD

2022-05-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Rename PREBUILD to UPSTREAMBUILD PREBUILD isn't a good name for this variable. It is the portion of the string that references upstream build information. Rename it to UPSTREAMBUILD. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile

Re: [OS-BUILD PATCH 0/2] redhat/Makefile: Improve dist-buildreq-check target

2022-07-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1900#note_1013253944 >'sudo dnf builddep kernel' should install the list of required packages without much hassle. Yep, that works but there's a subtle issue here. This command will install the

Re: [OS-BUILD PATCH 0/2] redhat/Makefile: Improve dist-buildreq-check target

2022-07-01 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1900#note_1013368484 >builddep can be passed a spec file or srpm as well, unfortunately it seems to choke if passed the kernel.spec.template, so we would need a processed template into a proper spec.

[OS-BUILD PATCH 1/2] redhat/Makefile: Fix dist-brew and distg-brew targets

2022-06-27 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Fix dist-brew and distg-brew targets The dist-brew and distg-brew targets are failing because the DIST variable is defined as ".el9 DISTRO=rhel BUILD_TARGET="--scratch rhel-9.1.0-test-pesign"". This occurs because make doesn't allow the setting of

[OS-BUILD PATCH 2/2] redhat/Makefile: Remove --scratch from BUILD_TARGET

2022-06-27 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Remove --scratch from BUILD_TARGET jforbes noticed that --scratch is applied to every BUILD_TARGET variable assignment, and can be applied when the BUILD_TARGET variable is used in make commands. Remove --scratch from BUILD_TARGET. Suggested-by: Justin

[OS-BUILD PATCH 0/2] redhat/Makefile: Fix dist-brew and distg-brew targets

2022-06-27 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1894 The dist-brew and distg-brew targets are failing because of a coding error; make variables can only be specified one per line. Additional fix request: Move --scratch to command from

[OS-BUILD PATCH 2/2] redhat/Makefile: Add DIST_BUILDREQ_WARN variable

2022-06-30 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Add DIST_BUILDREQ_WARN variable dist-* targets will fail if packages required by the build are not installed. In some cases, such as dist-configs, the build packages are not required for command execution. Provide a DIST_BUILDREQ_WARN variable that

[OS-BUILD PATCH 0/2] redhat/Makefile: Improve dist-buildreq-check target

2022-06-30 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1900 The dist-buildreq-check target can be improved in a few ways by allowing users to convert the fatal error into a warning, and by indicating where the system-sb-certs package can be

[OS-BUILD PATCH 1/2] redhat/Makefile: Provide better system-sb-certs missing package message

2022-06-30 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Provide better system-sb-certs missing package message Most of the kernel build dependencies come from widely known repositories including EPEL, RHEL, and Fedora. The system-sb-certs package comes from a smaller RHEL repository called CodeReady Linux

Re: [OS-BUILD PATCH 0/2] redhat/Makefile: Improve dist-buildreq-check target

2022-06-30 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1900#note_1012523331 @dzickusrh & I had a significant discussion about this MR and what the "right" thing to do is. There are several facets to this problem including what users should do to install

[OS-BUILD PATCHv2 3/4] .gitlab-ci.yaml: Add test for dist-get-buildreqs target

2022-07-06 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava .gitlab-ci.yaml: Add test for dist-get-buildreqs target Add a test for the dist-get-buildreqs target. Signed-off-by: Prarit Bhargava diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index blahblah..blahblah 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -239,6 +239,37

[OS-BUILD PATCHv2 4/4] redhat/docs: Add information on build dependencies

2022-07-06 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/docs: Add information on build dependencies Add a section on build dependencies. Signed-off-by: Prarit Bhargava diff --git a/redhat/docs/index.rst b/redhat/docs/index.rst index blahblah..blahblah 100644 --- a/redhat/docs/index.rst +++ b/redhat/docs/index.rst @@

[OS-BUILD PATCHv2 1/4] redhat/Makefile: Change dist-buildreq-check to a non-blocking target

2022-07-06 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Change dist-buildreq-check to a non-blocking target Rename dist-buildreq-check to dist-get-buildreqs and make it non-blocking. Signed-off-by: Prarit Bhargava diff --git a/redhat/Makefile b/redhat/Makefile index blahblah..blahblah 100644 ---

[OS-BUILD PATCHv2 2/4] redhat/Makefile: Provide a better message for system-sb-certs

2022-07-06 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Provide a better message for system-sb-certs Most of the kernel build dependencies come from widely known repositories including EPEL, RHEL, and Fedora. The system-sb-certs package comes from a smaller RHEL and CS9 repository called CodeReady Linux

[OS-BUILD PATCHv2 0/4] redhat/Makefile: Improve dist-buildreq-check target

2022-07-06 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1900 The dist-buildreq-check target can be improved in a few ways by allowing users to convert the fatal error into a warning, and by indicating where the system-sb-certs package can be

[OS-BUILD PATCH] RHMAINTAINERS: Update for June 10 2022

2022-06-10 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava RHMAINTAINERS: Update for June 10 2022 Update RHMAINTAINERS to latest. Signed-off-by: Prarit Bhargava diff --git a/redhat/rhdocs/MAINTAINERS/RHMAINTAINERS b/redhat/rhdocs/MAINTAINERS/RHMAINTAINERS index blahblah..blahblah 100644 ---

Re: [OS-BUILD PATCHv2] redhat/Makefile: Add SPECKABIVERSION variable

2022-06-06 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1801#note_973081368 Updated & fixed. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCHv2] redhat/Makefile: Add SPECKABIVERSION variable

2022-06-06 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Add SPECKABIVERSION variable Empty kabi tarballs are uploaded to dist-git everytime an .eln build is completed. These empty kabi tarballs waste disk space. In addition to this, new users that recompile the kernel often attempt to update the specversion

[OS-BUILD PATCH 2/3] redhat/self-test: Reformat tests to kernel standard

2022-06-15 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Reformat tests to kernel standard Reformat the tests to kernel standard. Signed-off-by: Prarit Bhargava diff --git a/redhat/self-test/0001-shellcheck.bats b/redhat/self-test/0001-shellcheck.bats index blahblah..blahblah 100644 ---

[OS-BUILD PATCH 1/3] redhat/self-test: Add purpose and header to each test

2022-06-15 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Add purpose and header to each test Add a purpose and bats env header to each test. Signed-off-by: Prarit Bhargava diff --git a/redhat/self-test/0001-shellcheck.bats b/redhat/self-test/0001-shellcheck.bats index blahblah..blahblah 100644 ---

[OS-BUILD PATCH 0/3] redhat/self-test: Provide better failure output for tests

2022-06-15 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com Merge Request: https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1881 Currently the tests fail without any reasonable information on how to run the tests manually. We can add better messaging, for example, This redhat/self-test test has

[OS-BUILD PATCH 3/3] redhat/self-test: Provide better failure output

2022-06-15 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: Provide better failure output Currently when the tests fail there isn't a lot of information on which test failed. This has resulted in confusion by developers. Add a general bash function, check_status, that outputs some basic information on which test

Re: [OS-BUILD PATCHv2] redhat/Makefile: Add SPECKABIVERSION variable

2022-06-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1801#note_994149237 Looks like merge failed. I'm rebasing now. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCHv3] redhat/Makefile: Add SPECKABIVERSION variable

2022-06-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/Makefile: Add SPECKABIVERSION variable Empty kabi tarballs are uploaded to dist-git everytime an .eln build is completed. These empty kabi tarballs waste disk space. In addition to this, new users that recompile the kernel often attempt to update the specversion

Re: [OS-BUILD PATCHv3] redhat/Makefile: Add SPECKABIVERSION variable

2022-06-16 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1801#note_994167593 Rebased and pushed. ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to

[OS-BUILD PATCHv3 2/3] redhat/self-test: self-test data update

2022-06-13 Thread Prarit Bhargava (via Email Bridge)
From: Prarit Bhargava redhat/self-test: self-test data update Fixup the self-test data wrt the last commit. Signed-off-by: Prarit Bhargava diff --git a/redhat/self-test/data/centos-2585cf9dfaad.el7 b/redhat/self-test/data/centos-2585cf9dfaad.el7 index blahblah..blahblah 100644 ---

<    3   4   5   6   7   8   9   10   11   12   >