Re: [PATCH] netfilter: nf_log fix

2009-04-15 Thread Patrick McHardy
Eric Dumazet wrote: OK thanks everybody, I submit it more formally then, using ARRAY_SIZE() macro too :) [PATCH] netfilter: nf_log fix commit ca735b3aaa945626ba65a3e51145bfe4ecd9e222 'netfilter: use a linked list of loggers' introduced an array of list_head in struct nf_logger, but forgot to

Re: panic on rmmod of nf_conntrack_irc

2009-04-15 Thread Patrick McHardy
Eric Dumazet wrote: I should have used different fields names (from next, first, ...) to catch this kind of errors at compile time :( Something like : diff --git a/include/linux/list_nulls.h b/include/linux/list_nulls.h Eric, on second thought, could you please resubmit this to Dave? It

Re: panic on rmmod of nf_conntrack_irc

2009-04-15 Thread Patrick McHardy
Eric Dumazet wrote: Patrick McHardy a écrit : Eric, on second thought, could you please resubmit this to Dave? It touches too many files outside of netfilter to go through my tree. Sure, but its a cleanup (and was an RFC to show my point) so should wait a litle bit until David opens his -next