Re: panic on rmmod of nf_conntrack_irc

2009-04-15 Thread Patrick McHardy
Eric Dumazet wrote: I should have used different fields names (from next, first, ...) to catch this kind of errors at compile time :( Something like : diff --git a/include/linux/list_nulls.h b/include/linux/list_nulls.h Eric, on second thought, could you please resubmit this to Dave? It

Re: panic on rmmod of nf_conntrack_irc

2009-04-15 Thread Patrick McHardy
Eric Dumazet wrote: Patrick McHardy a écrit : Eric, on second thought, could you please resubmit this to Dave? It touches too many files outside of netfilter to go through my tree. Sure, but its a cleanup (and was an RFC to show my point) so should wait a litle bit until David opens his -next

Re: panic on rmmod of nf_conntrack_irc

2009-04-15 Thread David Miller
From: Eric Dumazet da...@cosmosbay.com Date: Wed, 15 Apr 2009 12:42:27 +0200 Sure, but its a cleanup (and was an RFC to show my point) so should wait a litle bit until David opens his -next tree (for 2.6.31) The net-next-2.6 tree is open for business since 2.6.30-rc1 :-) Please just submit

Re: panic on rmmod of nf_conntrack_irc

2009-04-14 Thread Mariusz Kozlowski
patches :)). Ok good. It doesn't panic now on nf_conntrack_irc rmmod but I found another bug. Now it's NULL pointer dereference I when doing rmmod of ebt_log. To reproduce simply: # modprobe ebt_log rmmod ebt_log This is from the mainline kernel + your (Erics) patch: BUG

Re: panic on rmmod of nf_conntrack_irc

2009-04-14 Thread Eric Leblond
Hi, Le mardi 14 avril 2009 à 22:14 +0200, Eric Dumazet a écrit : Mariusz Kozlowski a écrit : On Tue, 14 Apr 2009 14:16:37 +0200 Patrick McHardy ka...@trash.net wrote: Eric Dumazet wrote: Patrick McHardy a écrit : Mariusz Kozlowski wrote: netfilter: nf_conntrack: use