Re: newbies CheckpatchTips for multiline statements (Breaking function calls)

2014-12-17 Thread Bjørn Mork
Joe Perches j...@perches.com writes: This style is fine, and generally perferred. However, some driver writers prefer to have the trailing line of a function call line up with the starting '('. They use tabs, followed by spaces, to align the trailing line: pdata-urbdata =

Solving checkpatch error with lex

2014-12-17 Thread karthik nayak
Hello, was trying to fix the checkpatch error of not using c99 comments in the file drivers/staging/rtl8192u/r8192U_dm.c so I wrote a lex program to do so since there were way too many to do it manually. Could anyone have a look at my lex code and tell me if I need to change it. I have

Re: Solving checkpatch error with lex

2014-12-17 Thread Valdis . Kletnieks
On Thu, 18 Dec 2014 00:04:48 +0530, karthik nayak said: //.* {fprintf(yyout, /*%s*/, yytext + 2);} This fails to fix block comments: // this is line one // this is line two // this is line three to /* * THis is line one * This is line two * this is line three */ pgpbndK6Nz20x.pgp

Re: Solving checkpatch error with lex

2014-12-17 Thread Paul Bolle
On Thu, 2014-12-18 at 00:04 +0530, karthik nayak wrote: was trying to fix the checkpatch error of not using c99 comments in the file drivers/staging/rtl8192u/r8192U_dm.c so I wrote a lex program to do so since there were way too many to do it manually. Could anyone have a look at my lex

Re: Solving checkpatch error with lex

2014-12-17 Thread karthik nayak
On Thu, Dec 18, 2014, 12:37 AM Paul Bolle pebo...@tiscali.nl wrote: On Thu, 2014-12-18 at 00:04 +0530, karthik nayak wrote: was trying to fix the checkpatch error of not using c99 comments in the file drivers/staging/rtl8192u/r8192U_dm.c so I wrote a lex program to do so since there were way

Re: Solving checkpatch error with lex

2014-12-17 Thread Paul Bolle
On Wed, 2014-12-17 at 20:07 +0100, Paul Bolle wrote: I see no reason to review someone's lex code. I guess very few people are actually willing to do that. My statement is not incorrect just because Valdis did actually review your code! Paul Bolle

Re: Solving checkpatch error with lex

2014-12-17 Thread Greg KH
On Wed, Dec 17, 2014 at 07:10:24PM +, karthik nayak wrote: On Thu, Dec 18, 2014, 12:37 AM Paul Bolle pebo...@tiscali.nl wrote: On Thu, 2014-12-18 at 00:04 +0530, karthik nayak wrote: was trying to fix the checkpatch error of not using c99 comments in the file

Re: Solving checkpatch error with lex

2014-12-17 Thread Valdis . Kletnieks
On Wed, 17 Dec 2014 19:10:24 +, karthik nayak said: The only reason I didn't do that is cause the file is too large to manually have a look at, even the diff tends to be very huge. [/usr/src/linux-next] grep '//' drivers/staging/rtl8192u/r8192U_dm.c | wc -l 373 And why use lex when sed is

Re: kobject sample code

2014-12-17 Thread Paul Bolle
On Sat, 2014-12-13 at 13:01 -0500, John de la Garza wrote: On Tue, Dec 09, 2014 at 10:26:03AM +0100, Paul Bolle wrote: On Mon, 2014-12-08 at 21:20 -0500, John de la Garza wrote: I'm looking at samples/kobject/kobject-example.c at line 39 foo is read: sscanf(buf, %du,

Re: How to submit for eudyptula-challenge

2014-12-17 Thread sanjeev sharma
Hello All, I am using Thunderbird and also Gmail Email client for submitting the eudyptula challenge Task and after following below steps I have published on my Blog, every time I am getting problem with attachment You sent me base64 attachments, which I can not understand at all :(

Re: How to submit for eudyptula-challenge

2014-12-17 Thread Fernando Apesteguía
El 18/12/2014 07:03, sanjeev sharma sanjeevsharmae...@gmail.com escribió: Hello All, I am using Thunderbird and also Gmail Email client for submitting the eudyptula challenge Task and after following below steps I have published on my Blog, every time I am getting problem with attachment You

Re: How to submit for eudyptula-challenge

2014-12-17 Thread Manish Katiyar
On Wed, Dec 17, 2014 at 10:02 PM, sanjeev sharma sanjeevsharmae...@gmail.com wrote: Hello All, I am using Thunderbird and also Gmail Email client for submitting the eudyptula challenge Task and after following below steps I have published on my Blog, every time I am getting problem with

Re: How to submit for eudyptula-challenge

2014-12-17 Thread Sudip Mukherjee
On Thu, Dec 18, 2014 at 11:32 AM, sanjeev sharma sanjeevsharmae...@gmail.com wrote: Hello All, I am using Thunderbird and also Gmail Email client for submitting the eudyptula challenge Task and after following below steps I have published on my Blog, every time I am getting problem with