Re: Please do not generate patches purely based on checkpatch.

2015-07-25 Thread Greg KH
On Sat, Jul 25, 2015 at 04:49:32PM -0400, greg.freem...@gmail.com wrote: On the other hand if you submit a patch that addresses a real bug, then simultaneously doing a checkpatch related patch to the same area is a very good idea. No, that would be two different things. Do the bug fix first,

Re: Please do not generate patches purely based on checkpatch.

2015-07-25 Thread greg . freemyer
On July 25, 2015 3:50:30 PM EDT, Ahmed Soliman ahmedsoliman0x...@gmail.com wrote: I have sent a patch for cleaning about 40 error and 50 warning generated checkpatch to the maintainer and all what I got in responce is Nack. Please do not generate patches purely based on checkpatch. so what did

Please do not generate patches purely based on checkpatch.

2015-07-25 Thread Ahmed Soliman
I have sent a patch for cleaning about 40 error and 50 warning generated checkpatch to the maintainer and all what I got in responce is Nack. Please do not generate patches purely based on checkpatch. so what did I do wrong ?! should I follow checkpatch or not ??