kernel panic

2015-10-15 Thread jinz...@wingtech.com
Dear all: I met a problem as below, what the function of walk_page_range?? Exception Class: Kernel (KE) PC is at [] walk_page_range+0x3c/0x314 Current Executing Process: [Binder_C, 3611][main, 354] Backtrace: [] __do_kernel_fault.part.5+0x70/0x84 [] do_bad_area+0x90/0x94 []

parameter of module_init() and module_exit() must not be a macro

2015-10-15 Thread Warlich, Christof
I'd just like to get some feedback on the following issue and if the patch that I'm suggesting would be appropriate to be considered for upstream submission: While writing a driver template, I just came across an issue with the module_init() and module_exit() macros: They don't work properly

Re: parameter of module_init() and module_exit() must not be a macro

2015-10-15 Thread Greg KH
On Thu, Oct 15, 2015 at 02:26:41PM +, Warlich, Christof wrote: > > > I'll ask, why would you ever want to pass a macro to module_init()? > > > > We don't like functions to be macros in the kernel, do you have a > > real-world need for this somewhere? If so, can you show the code? > > Yes,

Re: parameter of module_init() and module_exit() must not be a macro

2015-10-15 Thread Greg KH
On Thu, Oct 15, 2015 at 09:48:53AM +, Warlich, Christof wrote: > I'd just like to get some feedback on the following issue and if the patch > that I'm suggesting would be appropriate to be considered for upstream > submission: > > While writing a driver template, I just came across an issue

AW: parameter of module_init() and module_exit() must not be a macro

2015-10-15 Thread Warlich, Christof
> I'll ask, why would you ever want to pass a macro to module_init()? > > We don't like functions to be macros in the kernel, do you have a > real-world need for this somewhere? If so, can you show the code? Yes, certainly: As I said in my first post, I'd like to provide a driver template for