Re: Compare two diiferent kernel version

2016-04-22 Thread Greg KH
On Fri, Apr 22, 2016 at 11:23:28AM +0530, vish chopra wrote: > Hi, > > i'm new to driver development. > how can i compare two different kernel version to see changes git diff v4.4..v4.5 :) > and also help me with how i can make changes to kernel and notice its > effect. What exactly do you

Re: single, comprehensive kernel data types document?

2016-04-21 Thread Greg KH
On Thu, Apr 21, 2016 at 08:51:04AM -0400, Rob Groner wrote: > On Thu, 2016-04-21 at 11:51 +0900, Greg KH wrote: > > On Wed, Apr 20, 2016 at 04:37:07PM -0400, Rob Groner wrote: > > > Sorry if this isn't related, it seemed like it was... > > > > > > I recently

Re: single, comprehensive kernel data types document?

2016-04-20 Thread Greg KH
On Wed, Apr 20, 2016 at 04:37:07PM -0400, Rob Groner wrote: > Sorry if this isn't related, it seemed like it was... > > I recently discovered one of our drivers isn't written correctly for > 64-bit. It uses a uint32_t to hold an address. Whoops. > > In previous drivers when I've needed to hold

Re: SimpleFlow: simple information-flow-based security module for Linux

2016-04-19 Thread Greg KH
On Tue, Apr 19, 2016 at 10:48:30PM -0400, W. Michael Petullo wrote: > Some colleagues and I have been working on SimpleFlow, a simple > information-flow-based security module for Linux. Our goal is to > investigate the feasibility of implementing such a security model on > top of LSM and to

Re: rmap-test

2016-04-18 Thread Greg KH
On Mon, Apr 18, 2016 at 10:45:41AM +0200, Jan-Simon Möller wrote: > does anyone know under what license > https://www.kernel.org/pub/linux/kernel/people/mbligh/tools/rmap-test.c > is released? > As it's on kernel.org one may assume its GPLv2, but it is written nowhere ... Don't make any such

Re: anyone aware of a high availability setup that relies on fully redundant install?

2016-04-17 Thread Greg KH
On Sun, Apr 17, 2016 at 01:16:10PM -0400, Robert P. J. Day wrote: > On Sun, 17 Apr 2016, Greg KH wrote: > > > On Sun, Apr 17, 2016 at 10:47:55AM -0400, Robert P. J. Day wrote: > > > > > > i figure this is as good a place as any to ask ... is anyone here >

Re: anyone aware of a high availability setup that relies on fully redundant install?

2016-04-17 Thread Greg KH
On Sun, Apr 17, 2016 at 10:47:55AM -0400, Robert P. J. Day wrote: > > i figure this is as good a place as any to ask ... is anyone here > aware of anyone using a linux config and install that, for the > purposes of reliability or high availability or whatever you want to > call it, relies on a

Re: UIO driver test

2016-04-15 Thread Greg KH
On Sat, Apr 16, 2016 at 07:03:37AM +0530, Gadre Nayan wrote: > I am trying to replicate the igb_uio for realtek card on my system. I saw the > igb_uio source and it uses no ID table. > > Struct pci_driver igb_pci_driver = { >     .id_table = NULL; > }; > > So I wanted to understand the mechanism

Re: single, comprehensive kernel data types document?

2016-04-15 Thread Greg KH
On Fri, Apr 15, 2016 at 01:07:19PM -0400, valdis.kletni...@vt.edu wrote: > On Fri, 15 Apr 2016 09:18:32 -0700, Greg KH said: > > > Within the kernel, yes, you can use lots of different types for the same > > "real" variable size, but you shouldn't, just use the well-kn

Re: single, comprehensive kernel data types document?

2016-04-15 Thread Greg KH
On Fri, Apr 15, 2016 at 03:59:09PM +, Nicholas Mc Guire wrote: > On Fri, Apr 15, 2016 at 05:27:24AM -0700, Greg KH wrote: > > On Fri, Apr 15, 2016 at 08:04:53AM -0400, Robert P. J. Day wrote: > > > > > > is there a single, decent online doc that explains the prope

Re: UIO driver test

2016-04-15 Thread Greg KH
On Fri, Apr 15, 2016 at 07:45:16PM +0530, Gadre Nayan wrote: > Sorry I am completely out of sort here, > > should I register it on a PCI bus without any ID table? What exactly will that do? You have to have a ID of a PCI device in order to properly bind to it, correct? Do you have a device you

Re: UIO driver test

2016-04-15 Thread Greg KH
On Fri, Apr 15, 2016 at 07:43:41PM +0530, Gadre Nayan wrote: > Oh offcourse, I forgot. > > So then should a char driver interface suffice. What exactly are you trying to do? What does the char interface have to do with UIO? confused, greg k-h ___

Re: single, comprehensive kernel data types document?

2016-04-15 Thread Greg KH
On Fri, Apr 15, 2016 at 10:09:35AM -0300, Daniel. wrote: > I've been using *aways* u8, u16, u32 in kernel code (driver code) and > *aways* __u8, __u16, __u32 > for code that goes to both (usualy ioctl definition headers). What is > happening here is that __u8 from > userspace is being "casted" to

Re: single, comprehensive kernel data types document?

2016-04-15 Thread Greg KH
On Fri, Apr 15, 2016 at 08:37:56AM -0400, John Chludzinski wrote: > Never use stdint.h? There is no 'stdint.h' in kernel code, sorry, we don't have that header. thanks, greg k-h ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org

Re: single, comprehensive kernel data types document?

2016-04-15 Thread Greg KH
On Fri, Apr 15, 2016 at 08:04:53AM -0400, Robert P. J. Day wrote: > > is there a single, decent online doc that explains the proper data > types (int16_t, int32_t and so on) to use in kernel code? First off, never use int16_t and friends, that's not ok :) Second, it's simple, use: u8

Re: build external module splited into several files

2016-04-04 Thread Greg KH
On Mon, Apr 04, 2016 at 08:00:09PM +0200, Colin Vidal wrote: > Hi all, > > I'm currently reading LDD the 3rd edition. Chapter 2 says that if we > need for example to build module "foo.c" which is split in two other > files "sub1.c" and "sub2.c", we just have to define the following > Kbuild

Re: Did PCI/IRQ allocation change significantly after 4.2 kernel?

2016-04-02 Thread Greg KH
On Wed, Mar 30, 2016 at 11:51:50AM -0400, Rob Groner wrote: > On Tue, 2016-03-29 at 17:57 -0700, Greg KH wrote: > > On Tue, Mar 29, 2016 at 04:11:22PM -0400, Rob Groner wrote: > > > Your first glance is probably correct. The driver handles reads and > > > writes t

Re: kernel mode termios API's

2016-03-31 Thread Greg KH
On Thu, Mar 31, 2016 at 04:43:09PM +0530, Muni Sekhar wrote: > On Wed, Mar 30, 2016 at 11:32 PM, Greg KH <g...@kroah.com> wrote: > > On Wed, Mar 30, 2016 at 09:23:00PM +0530, Muni Sekhar wrote: > >> Hi, > >> > >> We are having customized serial port dr

Re: Did PCI/IRQ allocation change significantly after 4.2 kernel?

2016-03-30 Thread Greg KH
On Wed, Mar 30, 2016 at 05:24:40PM -0400, Rob Groner wrote: > And, we have a winner! > > --- > rtd@kernel-dev:~/git/kernels/linux$ git bisect good > 991de2e59090e55c65a7f59a049142e3c480f7bd is the first bad commit > commit

Re: kernel mode termios API's

2016-03-30 Thread Greg KH
On Wed, Mar 30, 2016 at 09:23:00PM +0530, Muni Sekhar wrote: > Hi, > > We are having customized serial port driver, it always sets the baud > to 9600 (by configuring UART BAUD_RATE register) on device file open, > but not updating the termios structure. Please fix your driver. You do have the

Re: Did PCI/IRQ allocation change significantly after 4.2 kernel?

2016-03-29 Thread Greg KH
On Tue, Mar 29, 2016 at 04:11:22PM -0400, Rob Groner wrote: > Your first glance is probably correct. The driver handles reads and > writes to registers via IOCTLs from the user library, as well as > interrupts and DMA. There are probably two main reasons the driver is > structured like that: 1)

Re: Did PCI/IRQ allocation change significantly after 4.2 kernel?

2016-03-29 Thread Greg KH
On Tue, Mar 29, 2016 at 12:18:40PM -0700, Greg KH wrote: > > That is encouraging and persuasive. I will make submitting the driver > > one of my pet projects. I need to put a new coat of paint on it before > > I submit it for consideration, though. Do I post to this mailing

Re: Did PCI/IRQ allocation change significantly after 4.2 kernel?

2016-03-29 Thread Greg KH
On Tue, Mar 29, 2016 at 03:11:46PM -0400, Rob Groner wrote: > On Tue, 2016-03-29 at 11:38 -0700, Greg KH wrote: > > On Tue, Mar 29, 2016 at 02:27:01PM -0400, Rob Groner wrote: > > > On Tue, 2016-03-29 at 08:43 -0700, Greg KH wrote: > > > > On Tue, Mar 29, 2016 at 11:2

Re: Did PCI/IRQ allocation change significantly after 4.2 kernel?

2016-03-29 Thread Greg KH
On Tue, Mar 29, 2016 at 02:27:01PM -0400, Rob Groner wrote: > On Tue, 2016-03-29 at 08:43 -0700, Greg KH wrote: > > On Tue, Mar 29, 2016 at 11:27:49AM -0400, Rob Groner wrote: > > > x86 only (we don't support other platforms). An example of the code > > > (this problem

Re: Did PCI/IRQ allocation change significantly after 4.2 kernel?

2016-03-29 Thread Greg KH
On Tue, Mar 29, 2016 at 11:27:49AM -0400, Rob Groner wrote: > On Tue, 2016-03-29 at 07:43 -0700, Greg KH wrote: > > On Tue, Mar 29, 2016 at 07:42:44AM -0700, Greg KH wrote: > > > On Tue, Mar 29, 2016 at 02:15:23PM +, Rob Groner wrote: > > > > I’m investigating

Re: Did PCI/IRQ allocation change significantly after 4.2 kernel?

2016-03-29 Thread Greg KH
On Tue, Mar 29, 2016 at 07:42:44AM -0700, Greg KH wrote: > On Tue, Mar 29, 2016 at 02:15:23PM +, Rob Groner wrote: > > I’m investigating why our drivers no longer work correctly after the 4.2 > > kernel. I have verified that in the 4.4 kernel, interrupts no longer work

Re: SWSUSP for arm

2016-03-28 Thread Greg KH
On Mon, Mar 28, 2016 at 09:51:40PM +0530, Ranjith T wrote: > Hi All, > > I have to port software suspend for IMX6 Dual lite board to reduce boot time. > But I really don't know how to do that. Could somebody assist me?. That sounds like a work assignment, do we get paid to do this? :) Also,

Re: [PATCH] misc devices: HC-SRO4 ultrasonic distance driver

2016-03-24 Thread Greg KH
On Thu, Mar 24, 2016 at 04:02:03PM +0100, Johannes Thoma wrote: > From 56e8f71c990b92c28a8cb03d859880eab8d06a3d Mon Sep 17 00:00:00 2001 > From: Johannes Thoma > Date: Mon, 21 Mar 2016 22:11:01 +0100 > Subject: [PATCH] HC-SRO4 ultrasonic distance sensor driver > >

Re: HC-SRO4 ultrasonic distance driver

2016-03-24 Thread Greg KH
On Thu, Mar 24, 2016 at 11:38:45AM +0100, Johannes Thoma wrote: > Hi all, > > I wrote a driver for the popular HC-SRO4 ultrasonic distance sensor. It > is beta and has been tested > on the Raspberry PI by me and my brother: here is the stand-alone repo: > >

Re: How to load initramfs only on-demand?

2016-03-12 Thread Greg KH
On Sat, Mar 12, 2016 at 04:29:08PM +0800, Woody Wu wrote: > My question is, is there such a kernel parameter to do the job? Probably there > is a non-parameter solution like passing the initramfs address in a register > when a boot loader transfer control to the kernel, but this is not an option

Re: inline keyword

2016-03-11 Thread Greg KH
On Fri, Mar 11, 2016 at 01:39:53PM -0500, Wenda Ni wrote: > Hi all, > > For a function that is defined static but without an explicit "inline" > keyword, > is there a possibility that compiler will optimize it to be a static inline > function? Yes there is. > We observe that some of the

Re: creating initramfs in fedora

2016-03-11 Thread Greg KH
On Fri, Mar 11, 2016 at 06:32:39PM +0530, Ronit Halder wrote: > Hi, > How can I create a initramfs file without dracut from the files in an > installed system in fedora? Why would you want to do that? The init sequence in Fedora isn't expecting that to happen, so if you want to do this you

Re: Getting a functional driver for Mad Catz Fightstick TE 2 (Xbox One version)

2016-03-08 Thread Greg KH
On Tue, Mar 08, 2016 at 08:15:26PM +0100, Silvan Jegen wrote: > Heyho > > I bought a Mad Catz Fightstick TE2 for Xbox One because I wanted to play > some fighting games on Linux. I chose this stick because it has gotten good > reviews and I assumed that the Kernel driver should work because there

Re: Driver duplicate?

2016-03-07 Thread Greg KH
On Mon, Mar 07, 2016 at 04:08:01PM -0500, Kenneth Adam Miller wrote: > On Mon, Mar 7, 2016 at 3:53 PM, Greg KH <g...@kroah.com> wrote: > > Currently, my kernel driver is opened twice and mmap'd twice by each > process. > > Again, any pointers to your source cod

Re: Driver duplicate?

2016-03-07 Thread Greg KH
On Mon, Mar 07, 2016 at 03:37:24PM -0500, Kenneth Adam Miller wrote: > > > On Mon, Mar 7, 2016 at 3:29 PM, Greg KH <g...@kroah.com> wrote: > > On Mon, Mar 07, 2016 at 03:21:44PM -0500, Kenneth Adam Miller wrote: > > > > > > On Mon, Mar 7, 2

Re: Driver duplicate?

2016-03-07 Thread Greg KH
On Mon, Mar 07, 2016 at 03:21:44PM -0500, Kenneth Adam Miller wrote: > > > On Mon, Mar 7, 2016 at 3:17 PM, Greg KH <g...@kroah.com> wrote: > > On Mon, Mar 07, 2016 at 03:00:50PM -0500, Kenneth Adam Miller wrote: > > I have a driver that manages three sets o

Re: Driver duplicate?

2016-03-07 Thread Greg KH
On Mon, Mar 07, 2016 at 03:05:41PM -0500, Kenneth Adam Miller wrote: > Actually, I just realized that there is probably a way to look up the > character > device name with the file* that is passed in with the mmap call. Can anybody > say how? Why not just use the "normal" way to do this? Have

Re: Driver duplicate?

2016-03-07 Thread Greg KH
On Mon, Mar 07, 2016 at 03:00:50PM -0500, Kenneth Adam Miller wrote: > I have a driver that manages three sets of identical data structures that > differ only in address values. Currently, I pray that the device file to which > I have callbacks mapped for the driver gets called sequentially,

Re: Project Idea..

2016-02-29 Thread Greg KH
On Tue, Mar 01, 2016 at 07:00:36AM +0530, SUNITA wrote: > There are four scheduling policies.  Is it feasible if i design a scheduling > policy which will overcome the drawbacks of sched_RR.  > The purpose is to reduce the number of context switches. > I have to modify fair.c That sounds like a

Re: Is there a bug in dgnc.ko?

2016-02-24 Thread Greg KH
On Wed, Feb 24, 2016 at 07:57:01PM +0800, Navy Cheng wrote: > On Tue, Feb 23, 2016 at 09:43:56PM -0800, Greg KH wrote: > > On Wed, Feb 24, 2016 at 12:57:42PM +0800, Navy Cheng wrote: > > > Hi, > > > > > > My kernel version is v4.4, and I have built drivers/

Re: Is there a bug in dgnc.ko?

2016-02-23 Thread Greg KH
On Wed, Feb 24, 2016 at 12:57:42PM +0800, Navy Cheng wrote: > Hi, > > My kernel version is v4.4, and I have built drivers/staging/dgnc/dgnc.ko. > I change to *dir*/drivers/staging/dgnc and do like this: > > sudo insmod ./dgnc.ko Do you have the hardware that this driver controls? >

Re: Kernel Panic in FIPS mode

2016-02-23 Thread Greg KH
On Tue, Feb 23, 2016 at 02:41:37PM -0600, Tapas Sarangi wrote: > Thanks for the reply. > I am using and compiling kernel from kernel.org. I believe 3.18.27 > with patches is as new as in January of this year. The 3.18 kernel was released in December of 2014, the .y patches on the end of that

Re: Kernel Panic in FIPS mode

2016-02-23 Thread Greg KH
On Tue, Feb 23, 2016 at 01:41:50PM -0600, Tapas Sarangi wrote: > I am recompiling 3.18.27 on a platform derived from el6. FIPS mode is > enabled by checking the following configs: > > CONFIG_CRYPTO_FIPS=y > CONFIG_CRYPTO_TEST=y If you are using a RHEL system, you need to contact Red Hat for

Re: Project Idea..

2016-02-22 Thread Greg KH
On Mon, Feb 22, 2016 at 10:54:54AM +0530, SUNITA wrote: > Respected Sir/Madam, > I am trying to study the effect of Scheduler Policies on Energy > Consumption of Portable Device. There are lots of people currently working on this, and have been for many years. I know of at least 3 complete

Re: Why exist coding style issue in mm_types.h

2016-02-21 Thread Greg KH
On Mon, Feb 22, 2016 at 12:29:54AM +0800, YU Bo wrote: > Hi, > When read the source code of mm_types.h, i encounter _coding style_ code > ,such like: > http://lxr.free-electrons.com/source/include/linux/mm_types.h#L346 in > comments. > Why not try to fix it? Because it is trival? > Actually,

Re: Distributed Process Scheduling Algorithm

2016-02-18 Thread Greg KH
On Thu, Feb 18, 2016 at 10:05:40AM +0530, Nitin Varyani wrote: > @ Greg: Since I am very new to the field, with the huge task in hand > and a short time span of 3 months given for this project, 3 months? That's way too short, this is a multi-year/decade type research project. You can barely

Re: Question regarding upstreaming patches written by multiple people and checkpatch

2016-02-18 Thread Greg KH
On Thu, Feb 18, 2016 at 06:25:46AM -0500, Joseph Bisch wrote: > Hi, > > I am trying to upstream a patch set that wasn't written by me. The > original patch has a lot of warnings and errors reported by > checkpatch. Someone else corrected some of those with another patch > and I added on a third

Re: Process scheduling

2016-02-17 Thread Greg KH
On Wed, Feb 17, 2016 at 12:48:33PM +0530, Nitin Varyani wrote: > It is similar to openMosix but still quite different. Open Mosix is built on > the top of existing linux kernels. The scheduling is taken care by the > existing > linux kernels. Open Mosix is responsible for workload distribution.

Re: Distributed Process Scheduling Algorithm

2016-02-17 Thread Greg KH
On Wed, Feb 17, 2016 at 04:05:17PM +0530, Nitin Varyani wrote: > Rather than trying to go blind folded in getting practical experience > of linux programming, I want to gain experience only in relation to my > task of creating a distributed process scheduler. What all things > should I try to work

Re: Question about memory in C

2016-02-10 Thread Greg KH
On Wed, Feb 10, 2016 at 08:49:30PM -0200, Victor Detoni wrote: > Hi, > > Thank you for your tip! I really appreciate it. In my situation I will have > many profiles and for each profile I can have many ip address, for example: > > profile 1: > 192.168.0.0/24 > 192.168.1.2/32 > 192.168.14/23 >

Re: Capture packets at 10g interface

2016-01-29 Thread Greg KH
On Fri, Jan 29, 2016 at 07:37:57PM +0530, Tarun Batra wrote: > We are trying to build product and as per decisions of senior we need to > capture packets in kernel Then I suggest you ask senior how to do this :) Best of luck, greg k-h ___

Re: Capture packets at 10g interface

2016-01-29 Thread Greg KH
On Sat, Jan 30, 2016 at 12:19:28PM +1100, Daniel Ng wrote: > > >> On Fri, Jan 29, 2016 at 07:37:57PM +0530, Tarun Batra wrote: > >> We are trying to build product and as per decisions of senior we need to > >> capture packets in kernel > > > My understanding is 10G interfaces push traffic

Re: Capture packets at 10g interface

2016-01-28 Thread Greg KH
On Thu, Jan 28, 2016 at 11:47:36PM +0530, Tarun Batra wrote: > Hi All, > > I have to write a kernel module in which I have to capture packets from 10g > nic > interface and make a copy of them. Why do you want to do that? > I have two options > Either use netfilters > Either use add dev pack

Re: Capture packets at 10g interface

2016-01-28 Thread Greg KH
On Fri, Jan 29, 2016 at 12:14:20AM +0530, Tarun Batra wrote: > I want to do that because I have to write a packet inspection module sort of > idps solution. What is forcing you to do such a thing? Is this for a homework assignment, or are you trying to create a product? > We are targeting

Re: Re: PCI-Express Hotplug

2016-01-20 Thread Greg KH
On Thu, Jan 21, 2016 at 09:06:42AM +0800, lifelong0...@126.com wrote: > Hi: > Thanks for you responce. I am a new developer in linux kernel. Can you > help me recommand some detailled document about the PCIE hotplug or the > detailed linux kernel .c file. The in-kernel files should be

Re: PCI-Express Hotplug

2016-01-18 Thread Greg KH
On Tue, Jan 19, 2016 at 06:04:07AM +0800, lifelong0...@126.com wrote: > > Hi: > Does somebody knows how the linux kernel implement the PCI-Express > Hotplug. Yes. The kernel code has the details. > The process of the PCI-Express Hotplug is the same as the PCI hotplug? Yes. greg k-h

Re: Found a problem so what next?

2016-01-18 Thread Greg KH
On Mon, Jan 18, 2016 at 05:34:32PM +, John Whitmore wrote: > I built and installed v4.4 on my laptop but Suspend no longer worked so I set > about doing a git bisect to find the source of the problem. I've never had > cause to use bisect before so if nothing else I'll have learned something.

Re: pci device driver

2016-01-17 Thread Greg KH
On Mon, Jan 18, 2016 at 07:23:42AM +0530, Rabinarayan Panigrahi wrote: > Hi, > > For understanding more about pci device driver i went though below links > > http://www.tldp.org/LDP/tlk/dd/pci.html > > and  > > http://www.makelinux.net/ldd3/  chapter 12 > > but i am trying to understand a bit

Re: Drivers in staging folder

2016-01-06 Thread Greg KH
On Wed, Jan 06, 2016 at 11:07:47AM +, James Miller wrote: > Hi All, > > I've had a look at the TODO files but I'm having some difficulty with > finding out which devices each of the drivers support. My plan was to > find a driver in staging, get a device off ebay which uses the driver > and

Re: Best tests to measure Kernel Performance

2015-12-03 Thread Greg KH
On Thu, Dec 03, 2015 at 10:51:09AM -0600, Victor Rodriguez wrote: > Do we have a subset of test inside LTSI test suite just for > performance ? First off, please go look at the test suite that LTSI uses for testing before asking this type of thing, I think that will answer all of your questions

Re: Figuring out the right patch receivers

2015-12-02 Thread Greg KH
On Wed, Dec 02, 2015 at 09:27:10AM -0800, Sinclair Yeh wrote: > Hi, > > For the first time, I sent out a patch series that touched multiple > subsystems. > > I used "get_maintainer.pl" to figure out who all the maintainers are > and decided to send the entire series to x...@kernel.org" and Cc >

Re: Best tests to measure Kernel Performance

2015-12-01 Thread Greg KH
On Tue, Dec 01, 2015 at 06:45:51PM -0600, Victor Rodriguez wrote: > Hi > > Despite the fact that this is not a well formulated question. I wonder > what tests could be a good subset to measure the performance of the > kernel . I have some approaches like phoronix does here : > >

Re: How to get list of all files open in the system

2015-11-14 Thread Greg KH
On Sat, Nov 14, 2015 at 08:13:26PM +0200, Sergei Starovoi wrote: > Hi, all. > > I'm writing a kernel module. One of its tasks requires getting full paths of > all open files in the system. That's a very odd request, why would a kernel module ever care about such a thing? And in what namespace

Re: is there a reason "usbhid.quirks" parameter is not root writable?

2015-11-12 Thread Greg KH
On Thu, Nov 12, 2015 at 08:02:00PM -0500, valdis.kletni...@vt.edu wrote: > But to answer Robert's question: I suspect that it's mode 0444 so you can > read the current list, but changing the list after modprobe time is for > some reason problematic. Having said that, I admit I haven't looked at

Re: [PATCH] 8250_pci: Prevent Exar/RTD Boards from binding.

2015-11-11 Thread Greg KH
On Wed, Nov 11, 2015 at 03:46:23PM +, Rob Groner wrote: > > > -Original Message- > > From: kernelnewbies-boun...@kernelnewbies.org [mailto:kernelnewbies- > > boun...@kernelnewbies.org] On Behalf Of Rob Groner > > Sent: Monday, October 26, 2015 8:28 AM >

Re: [PATCH] 8250_pci: Prevent Exar/RTD Boards from binding.

2015-11-11 Thread Greg KH
On Wed, Nov 11, 2015 at 11:50:33PM +0530, Sudip Mukherjee wrote: > On Wed, Nov 11, 2015 at 11:02 PM, Greg KH <g...@kroah.com> wrote: > > On Wed, Nov 11, 2015 at 03:46:23PM +, Rob Groner wrote: > > > > > > > > I know you're incredibly bu

Re: [PATCH] 8250_pci: Prevent Exar/RTD Boards from binding.

2015-11-11 Thread Greg KH
On Wed, Nov 11, 2015 at 09:49:11PM +, Rob Groner wrote: > > > We all know you are busy. If you want I can try the cleanup and send > > > it to Rob for testing. > > > > Yes please, it should just require a change to the existing 8250 driver > > code for > > this platform, it should not be a

Re: How to properly write tests for kernel functions

2015-11-05 Thread Greg KH
On Thu, Nov 05, 2015 at 11:43:36AM +0300, Maxim Pugachev wrote: > >> So, I'm wondering, whether there is an example or guidelines that is > >> worth to follow. > > > > It all depends on what you want to test. There is no "general" way to > > do this as all subsystems / parts of the kernel are

Re: How to mark suspicious code?

2015-11-05 Thread Greg KH
On Fri, Nov 06, 2015 at 10:28:31AM +0700, Ivan Safonov wrote: > On 11/06/2015 08:58 AM, Greg KH wrote: > >On Fri, Nov 06, 2015 at 08:45:46AM +0700, Ivan Safonov wrote: > >>Hi all! > >> > >>How can I mark suspicious code, if I can not fix it? > >Wha

Re: How to mark suspicious code?

2015-11-05 Thread Greg KH
On Fri, Nov 06, 2015 at 08:45:46AM +0700, Ivan Safonov wrote: > Hi all! > > How can I mark suspicious code, if I can not fix it? What do you mean by "mark"? And also what do you mean by "suspicious"? And why can't you fix it? we need more details. thanks, greg k-h

Re: How to properly write tests for kernel functions

2015-11-04 Thread Greg KH
On Thu, Nov 05, 2015 at 12:26:01AM +0300, Maxim Pugachev wrote: > Hi all, > > I'm trying to understand is there any uniform way to write tests? For > example, lib/ folder has a bunch of tests, but all of them use various > technics: > > - pr_warn/pr_err (i.e. printk) or WARN for assertions > -

Re: Two questions

2015-10-28 Thread Greg KH
On Wed, Oct 28, 2015 at 04:14:19PM +, Anuz Pratap Singh Tomar wrote: > > > On Wed, Oct 28, 2015 at 4:08 PM, Albino B Neto wrote: > > 2015-10-28 13:57 GMT-02:00 Anuz Pratap Singh Tomar < > chambilketha...@gmail.com>: > > 1. Is this book still relevant? > >

Re: where struct pci_device_id is defined ?

2015-10-27 Thread Greg KH
On Tue, Oct 27, 2015 at 07:46:32AM +, Ramon Fried wrote: > Hi. > > I'm trying to find the definition of "struct pci_device_id" , but I only get > forward declarations. > > I tried grepping the entire tree, and nothing matches. Please try harder, I see it very easily, where exactly are you

Re: Query Hard Memory Addresses

2015-10-22 Thread Greg KH
On Thu, Oct 22, 2015 at 03:13:31PM -0400, Kenneth Adam Miller wrote: > So, previously it was discussed that /dev/mem could be used to mmap a specific > hardware memory into a process. Now I need to unit test some userland code > that > does exactly that, but I need to make sure that the unit test

Re: UIO Kernel Driver with Buildroot and QEMU

2015-10-20 Thread Greg KH
On Tue, Oct 20, 2015 at 11:58:21AM -0400, Kenneth Adam Miller wrote: > So I'm building a uio kernel driver with buildroot, and I've gotten the driver > to compile, installed it and can insmod it in the final buildroot target after > booting the image with QEMU. > > I'm on linux kernel version

Re: UIO Kernel Driver with Buildroot and QEMU

2015-10-20 Thread Greg KH
On Tue, Oct 20, 2015 at 08:28:20PM -0400, Kenneth Adam Miller wrote: > On Tue, Oct 20, 2015 at 8:17 PM, Greg KH <g...@kroah.com> wrote: > On Tue, Oct 20, 2015 at 07:40:37PM -0400, Kenneth Adam Miller wrote: > > I didn't know about that. How do I do that? I'm using

Re: UIO Kernel Driver with Buildroot and QEMU

2015-10-20 Thread Greg KH
On Tue, Oct 20, 2015 at 07:40:37PM -0400, Kenneth Adam Miller wrote: > > On Tue, Oct 20, 2015 at 6:54 PM, Greg KH <g...@kroah.com> wrote: > > On Tue, Oct 20, 2015 at 11:58:21AM -0400, Kenneth Adam Miller wrote: > > So I'm building a uio kernel driver with bu

Re: I have a large patch in the 2000 lines. What to do?

2015-10-16 Thread Greg KH
On Fri, Oct 16, 2015 at 06:14:01PM -0300, Julio Faracco wrote: > > What is the recommendation when I change a structure in a include file > and this change causes a lots of new changes, for example? You do the change in a way that does not cause build failures and spread the patches out over

Re: parameter of module_init() and module_exit() must not be a macro

2015-10-16 Thread Greg KH
On Fri, Oct 16, 2015 at 06:40:40AM +, Warlich, Christof wrote: > > Ick, no, don't do that, you will make life much harder for everyone > > involved in the end. Just write out the code "for real", it's trivial > > to do so, and you aren't really saving anyone anytime as nothing like > > this

Re: parameter of module_init() and module_exit() must not be a macro

2015-10-15 Thread Greg KH
On Thu, Oct 15, 2015 at 02:26:41PM +, Warlich, Christof wrote: > > > I'll ask, why would you ever want to pass a macro to module_init()? > > > > We don't like functions to be macros in the kernel, do you have a > > real-world need for this somewhere? If so, can you show the code? > > Yes,

Re: parameter of module_init() and module_exit() must not be a macro

2015-10-15 Thread Greg KH
On Thu, Oct 15, 2015 at 09:48:53AM +, Warlich, Christof wrote: > I'd just like to get some feedback on the following issue and if the patch > that I'm suggesting would be appropriate to be considered for upstream > submission: > > While writing a driver template, I just came across an issue

Re: I have a large patch in the 2000 lines. What to do?

2015-10-10 Thread Greg KH
On Sat, Oct 10, 2015 at 08:02:49AM +0700, Ivan Safonov wrote: > On 10/10/2015 02:20 AM, Greg KH wrote: > >On Fri, Oct 09, 2015 at 12:12:44PM -0700, Anish Kumar wrote: > >> > >>>On Oct 9, 2015, at 11:45 AM, Ivan Safonov <insafo...@gmail.com> wrote: > >&

Re: I have a large patch in the 2000 lines. What to do?

2015-10-09 Thread Greg KH
On Fri, Oct 09, 2015 at 12:12:44PM -0700, Anish Kumar wrote: > > > > On Oct 9, 2015, at 11:45 AM, Ivan Safonov wrote: > > > > Hi! > > > > I have a large patch in the 2000 lines, which replaces the macro BITn to > > BIT(n) in multiple files. > > I will recommend sending

Re: make headers_install for out-of-tree modules

2015-10-07 Thread Greg KH
On Wed, Oct 07, 2015 at 10:51:25AM -0300, Daniel. wrote: > Uhh, as I see from docs, this isn't supported, > > --- 2.3 Targets > > When building an external module, only a subset of the "make" > targets are available. > >From https://www.kernel.org/doc/Documentation/kbuild/modules.txt > > So,

Re: UIO Devices and user processes

2015-10-07 Thread Greg KH
On Tue, Oct 06, 2015 at 10:46:49AM -0400, Kenneth Adam Miller wrote: > Let me be more precise in general to the overall original question: > > I want a userland process that I designate to only use a specific hard coded > region physical of memory for it's heap. A UIO driver is the means by which

Re: UIO Devices and user processes

2015-10-06 Thread Greg KH
On Tue, Oct 06, 2015 at 09:26:23AM -0400, Kenneth Adam Miller wrote: > No, I didn't try it. I just wanted to ask before I got started. Thanks that > answers everything. > > Any body know about the issue of assigning a process a region of physical > memory to use for it's malloc and free? I'd like

Re: UIO Devices and user processes

2015-10-05 Thread Greg KH
On Mon, Oct 05, 2015 at 07:07:51PM -0400, Kenneth Adam Miller wrote: > So, I'm reading about UIO devices and user processes for mapping memory into > userland, and basically I have just a couple questions: > > What happens when a userland processes has allocated some resource from a > driver that

Re: Logging communication with devices

2015-10-04 Thread Greg KH
On Sun, Oct 04, 2015 at 01:18:29PM +0200, Peter Senna Tschudin wrote: > Does Linux provide an elegant and/or standard way of logging > communication with devices that manage buffers and that can help me > improve code like: > > $ cat drivers/usb/host/fotg210-hcd.c > ... > temp =

Re: Looking for easy first-timer tasks

2015-10-04 Thread Greg KH
On Sat, Oct 03, 2015 at 07:37:54PM -0700, Sean Bollin wrote: > I read the website and searched for "TODO" in driver/staging as well as ran a > few of the perl style checks - but couldn't really find something as a good > intro. What is wrong with those as valid "first timer" tasks? Did you try

Re: [PATCH] 8250_pci: Prevent Exar/RTD Boards from binding.

2015-09-28 Thread Greg KH
On Mon, Sep 28, 2015 at 08:53:49AM -0400, Rob Groner wrote: > On Fri, 2015-09-25 at 17:45 -0700, Greg KH wrote: > > On Fri, Sep 25, 2015 at 03:21:46PM -0400, Rob Groner wrote: > > > > > > On 09/25/2015 03:14 PM, Greg KH wrote: > > > > On Fri, Sep 25, 201

Re: Avoid Camelcase

2015-09-26 Thread Greg KH
On Sun, Sep 27, 2015 at 01:52:48AM +0530, Shraddha Barke wrote: > What should be done about the "Avoid Camelcase" CHECK detected by > checkpatch.pl > for patches ? Fix up the code to not use CamelCase :) See https://en.wikipedia.org/wiki/CamelCase for what this is, and read the CodingStyle

Re: [PATCH] 8250_pci: Prevent Exar/RTD Boards from binding.

2015-09-25 Thread Greg KH
On Fri, Sep 25, 2015 at 07:08:32PM +, Rob Groner wrote: > > -Original Message- > > From: Greg KH [mailto:g...@kroah.com] > > Sent: Friday, September 25, 2015 2:37 PM > > To: Rob Groner <rgro...@rtd.com> > > Cc: valdis.kletni...@vt.edu; kernelnewbi

Re: [PATCH] 8250_pci: Prevent Exar/RTD Boards from binding.

2015-09-25 Thread Greg KH
On Fri, Sep 25, 2015 at 05:37:03PM +, Rob Groner wrote: > > > -Original Message- > > From: valdis.kletni...@vt.edu [mailto:valdis.kletni...@vt.edu] > > Sent: Friday, September 25, 2015 12:48 PM > > To: Rob Groner > > Cc: kernelnewbies@kernelnewbies.org > > Subject:

Re: [PATCH] 8250_pci: Prevent Exar/RTD Boards from binding.

2015-09-25 Thread Greg KH
On Fri, Sep 25, 2015 at 03:21:46PM -0400, Rob Groner wrote: > > On 09/25/2015 03:14 PM, Greg KH wrote: > > On Fri, Sep 25, 2015 at 07:08:32PM +, Rob Groner wrote: > >>> -Original Message- > >>> From: Greg KH [mailto:g...@kroah.com] > >&

Re: Question about "Creating first patch" guide

2015-09-23 Thread Greg KH
On Wed, Sep 23, 2015 at 07:22:08PM +, Rob Groner wrote: > The OutreachyfirstpatchSetup has been very helpful in setting up my computer > to > develop a patch to submit to the kernel overlords. > > > > I’m at the point where I’ve changed the kernel code, ran and test it, and see > just my

Re: Adding GPIO/SPI/I2C functionality to FTDI driver

2015-09-22 Thread Greg KH
On Tue, Sep 22, 2015 at 06:28:47PM +0200, chrysn wrote: > Hello kernelnewbies list, > > I've run into situations where it would be practical to have the GPIO, > I2C and SPI functionality some FTDI chips provide as kernel devices. > (The chips are more often used as USB serial adapters; only that

Re: How to get the inode - no path_lookup

2015-09-16 Thread Greg KH
On Fri, Sep 04, 2015 at 04:26:06PM +, priyamn wrote: > > Hi, > > I happened to come across this discussion. I am having a similar issue. > I am using Rhel7-3.10.0-123 > kernel. I tried all the options that are mentioned above and none of the > api's > including kern_path() return valid

Re: When to use threaded interrupts?

2015-09-15 Thread Greg KH
On Tue, Sep 15, 2015 at 09:02:24PM +0300, Kosta Zertsekel wrote: > >> On 10 September 2015 at 20:49, Kosta Zertsekel > >> Also, I see that in 4.2 there are only ~76 drivers that use threaded > >> interrupt: > >> ``` > >> $ git grep -l IRQ_WAKE_THREAD | sort | grep -v "\.h" |

Re: gfp_flag

2015-09-13 Thread Greg KH
On Mon, Sep 14, 2015 at 09:03:53AM +0530, Ronit Halder wrote: > In drivers/staging/android/ion/ion.c in line 1475 and 1493 gfp_flag > is set to -1 No, that's not what the code does, please read it again. greg k-h ___ Kernelnewbies mailing list

Re: Preceding a method call with (void)

2015-09-09 Thread Greg KH
On Thu, Sep 10, 2015 at 07:52:49AM +0300, Kevin Wilson wrote: > Hi all, > > I intend to send a patch to the kernel, and my question is about > preceding a method with (void). Don't :) > My question is: > Will sending a patch to the kernel with code with (void) preceding > method calls make

<    3   4   5   6   7   8   9   10   11   12   >