Re: [OSSNA] Intro to kernel hacking tutorial

On Mon, Sep 02, 2019 at 10:08:54AM -0400, Valdis Klētnieks wrote: > On Mon, 02 Sep 2019 15:42:19 +0300, Anatoly Pugachev said: > > > is it intentionally that you use > > > > yes "" | make oldconfig > > > > instead of > > > > make olddefconfig > > They do something different. 'olddefconfig' just

Re: [OSSNA] Intro to kernel hacking tutorial

On Sun, Sep 01, 2019 at 05:30:23AM +0530, Amit Kumar wrote: > Hi, > I think now your tutorial should be ready. I do not understand what this means sorry. Is it a request for action? The tutorial was a couple of weeks ago now, here is a link to the material if that is what you were asking

Re: [OSSNA] Intro to kernel hacking tutorial

On Fri, Jul 19, 2019 at 12:36:58PM +0300, Dan Carpenter wrote: > On Fri, Jul 05, 2019 at 12:50:55PM +1000, Tobin C. Harding wrote: > > Outcome will (hopefully) be a small patch set into drivers/staging/. > > (Don't worry Greg only one group got to this stage last time, you > &

Re: [OSSNA] Intro to kernel hacking tutorial

On Fri, Jul 05, 2019 at 10:40:43AM +0530, Amit Kumar wrote: > On Fri, Jul 5, 2019 at 9:02 AM Amit Kumar wrote: > > > > On Fri, Jul 5, 2019 at 8:21 AM Tobin C. Harding wrote: > > > > > > Hi, > > > > > > I am doing a tutorial at OSSNA in San Di

[OSSNA] Intro to kernel hacking tutorial

Hi, I am doing a tutorial at OSSNA in San Diego on getting into kernel hacking. I'm only a couple of years deep into kernel hacking so I wanted to reach out to those more experienced than myself (and those less experienced). Is there any thing that you would really like to see covered in this

Re: Unable to understand a piece of code

On Mon, May 20, 2019 at 05:37:41AM +0530, Amit Kumar wrote: > HI, > > mm/slub.c: line 3973 > int __kmem_cache_shrink(struct kmem_cache *s) > { > int node; > int i; > struct kmem_cache_node *n; > struct page *page; > struct page *t; > struct list_head discard; > struct list_head

Re: Where is PageHead defined in v5.0?

On Thu, Mar 28, 2019 at 01:50:47AM -0400, Valdis Klētnieks wrote: > On Wed, 27 Mar 2019 17:23:05 -0700, Igor Pylypiv said: > > and TESTPAGEFLAG defines PageHead: > > #define TESTPAGEFLAG(uname, lname, policy) \ > > static __always_inline int Page##uname(struct page *page) > >

Re: Where is PageHead defined in v5.0?

On Wed, Mar 27, 2019 at 05:23:05PM -0700, Igor Pylypiv wrote: > On Wed, Mar 27, 2019 at 4:51 PM Tobin C. Harding wrote: > > > > On Wed, Mar 27, 2019 at 07:34:58PM -0500, Jesse Simpson wrote: > > > Hi Tobin, > > > > > > I took a look on my system

Re: Where is PageHead defined in v5.0?

On Wed, Mar 27, 2019 at 07:34:58PM -0500, Jesse Simpson wrote: > Hi Tobin, > > I took a look on my system, and I wasn't able to find where PageHead is > defined either. I used grep to search for it as well as vim with ctags. > Maybe it's hidden away in some built-in.a or binary file. Cheers

Where is PageHead defined in v5.0?

Hi, I cannot locate the definition of PageHead? It seems to have disappeared after v4.0? I can see it defined as a function here: https://elixir.bootlin.com/linux/v4.0/source/include/linux/page-flags.h#L401 But on the mainline (v5.1-rc2) I get: $ git grep ' PageHead'

Re: make modules_install install is failing

On Tue, Feb 05, 2019 at 11:30:53AM +0530, Bharath Vedartham wrote: > Hi all, > > I am unable to execute make modules_install install. > I get the following error: Could you show the complete commands you are trying please thanks, Tobin. ___

Re: Boot all yes config kernel with QEMU

On Tue, Oct 23, 2018 at 12:22:44AM -0400, valdis.kletni...@vt.edu wrote: > On Tue, 23 Oct 2018 13:56:42 +1100, "Tobin C. Harding" said: > > > I'd like to build and boot an allyesconfig kernel with QEMU. Building > > is no problem but when I try to boot it I g

Boot all yes config kernel with QEMU

Hi, I'd like to build and boot an allyesconfig kernel with QEMU. Building is no problem but when I try to boot it I get problems because the host system does not support features requested by the VM. How does one go about testing an allyesconfig kernel? Back story: I'm trying to set up some CI

Re: dev process - reduce mistakes

On Tue, Sep 18, 2018 at 10:01:19PM -0400, Cindy-Sue Causey wrote: > On 9/18/18, Tobin C. Harding wrote: > > Hi, > > > > I'm after some advice from those more experienced with [kernel] > > development please. > > > > What systems do you have in place to h

Re: dev process - reduce mistakes

On Tue, Sep 18, 2018 at 08:01:22PM -0400, valdis.kletni...@vt.edu wrote: > On Wed, 19 Sep 2018 09:35:36 +1000, "Tobin C. Harding" said: > > Hi, > > > > I'm after some advice from those more experienced with [kernel] > > development please. > > > >

dev process - reduce mistakes

Hi, I'm after some advice from those more experienced with [kernel] development please. What systems do you have in place to help catch mistakes? In other words; what processes do you use when coding and submitting patches to help eliminate simple mistakes? So far my best method is getting a

Re: Linux FS design and implementation book

On Sat, Sep 15, 2018 at 07:33:51AM +0530, inventsekar wrote: > Hi All... > Around last year I was searching for Linux Kernel FS design and > implementation, and I found out a book by someone,.. a full length book, > particularly, at the end of the book he/she included source code as well... Might

Re: regarding const variables/structures

On Wed, Sep 12, 2018 at 11:53:57PM +0530, inventsekar wrote: > Thanks a ton, Valdis. Another tip for you, read up on what 'top posting' is and don't do it :) Shamelessly stealing Greg's 'top posting' link: https://daringfireball.net/2007/07/on_top Good luck, Tobin.

Re: Build using O=path

Thanks Luca, you had the winning entry! On Mon, Sep 10, 2018 at 11:37:15AM +0200, Luca Ceresoli wrote: > Hi, > > On 10/09/2018 08:33, Tobin C. Harding wrote: > > Hi, > > > > I'm unable to build the kernel using the O=path/to/out option. Am I > > doing so

Build using O=path

Hi, I'm unable to build the kernel using the O=path/to/out option. Am I doing something brain dead? $ cd $KERNEL $ make mrproper $ cp path/to/valid/config/file .config $ make O=/abs/path/to/output ... scripts/kconfig/conf --syncconfig Kconfig *** *** Configuration file ".config" not found! ***

Re: [PATCH] vsprintf: fix build warning

CC'ing kernel newbies for anyone else trying to learn how linux-next works. On Fri, Jul 06, 2018 at 11:49:51AM -0400, Steven Rostedt wrote: > On Fri, 6 Jul 2018 23:42:13 +0900 > Sergey Senozhatsky wrote: > > > On (07/06/18 15:47), Arnd Bergmann wrote: > > [..] > > > Fixes: bfe80ed3d7c7

Re: Linux Networking Internals Question

On Sat, Jun 16, 2018 at 11:17:01PM +0530, V.Ravikumar wrote: > Understood Rami Rosen. Thank you. > > Regards > Ravi > > On Sat, Jun 16, 2018 at 11:10 PM, Rami Rosen wrote: > > > Hi Ravi, > > The path that a packet goes through, from being received by the > > network driver and up to kernel

tags

Hi, A question relating to 'Acked-by:' and tags in general please. Relates to Documentation/process/submitting-patches.rst (sections 12 through 14). For discussion, say a two patch series goes to version six and is then applied to some maintainers tree. On version three patch one of the series

Re: where to send patch

On Tue, May 08, 2018 at 02:52:40AM +0530, Sumit Kumar wrote: >     Hi, > > When I use get_maintainer.pl script it give a list of names / addresses. > > 1. Should I send to only one of them ? > > 2. Should I put the first address in "To" field and the rest all in "CC" ? Please see

Re: [PATCH] scsi: eata: drop VLA in reorder()

Adding kernel newbies to CC because I pose a few noob questions :) Adding Linus to CC because I quoted him. On Sun, Mar 11, 2018 at 10:06:58PM +0100, Salvatore Mesoraca wrote: > n_ready will always be less than or equal to MAX_MAILBOXES. > So we avoid a VLA[1] and use fixed-length arrays instead.

Re: Submitted patch, what to do next

On Wed, Mar 07, 2018 at 04:28:07PM +, Alex Arvelaez wrote: > Hello, > > I sent a small patch to the LKML. I sent it to one of the mantainers > (as per get_mantainers.pl) and I CC-ed linux-ker...@vger.kernel.org. > > I'm not entirely sure I did everything properly and I was wondering > how

Re: Invalid module format

On Sun, Feb 25, 2018 at 12:04:30AM -0500, valdis.kletni...@vt.edu wrote: > On Sun, 25 Feb 2018 13:34:41 +1100, "Tobin C. Harding" said: > > On Fri, Feb 23, 2018 at 10:06:14PM -0500, valdis.kletni...@vt.edu wrote: > > > OK, I'll bite - how can the kernel go into a

Re: Invalid module format

On Fri, Feb 23, 2018 at 10:06:14PM -0500, valdis.kletni...@vt.edu wrote: > On Sat, 24 Feb 2018 10:29:33 +1100, "Tobin C. Harding" said: > > > (For the record I happened to be trying to learn about linux-next myself > > this morning and built a kernel that just goes in

Re: Invalid module format

On Thu, Feb 22, 2018 at 02:42:23AM +0530, Srishti Sharma wrote: > Hello, > > While trying to load a module from the linux-next branch Do you mean from linux-next tree or from a branch called linux-next in some other tree? (Not that it matters that much :) >, I get the error > that the module

Re: I'd like to contribute but I don't know how...

On Thu, Feb 22, 2018 at 09:25:39PM +, Alex Arvelaez wrote: > On Thu, Feb 22, 2018 at 04:12:14AM +, Alex Arvelaez wrote: > > On Wed, Feb 21, 2018 at 10:20:07PM -0500, valdis.kletni...@vt.edu wrote: > > > On Thu, 22 Feb 2018 02:33:08 +, Alex Arvelaez said: > > > > Hello, > > > > > > > >

Re: Query on mechanisms to communicate between kernel modules in Linux

On Sat, Feb 10, 2018 at 10:30:36PM +0530, Neil Thomas wrote: > Thanks a lot. I will try out this. Please don't top post. It upsets people. Good luck, Tobin. > On 10-Feb-2018 2:08 PM, "Pintu Kumar" wrote: > > > On Fri, Feb 9, 2018 at 12:52 AM, Neil Thomas

Re: Documentation bug in kernelnewbies.org/StartKernelHacking

On Wed, Jan 24, 2018 at 09:40:30PM -0500, Christopher Díaz Riveros wrote: > Hi, I was reading the StartKernelHacking section from kernelnewbies.org > site and found that the command: > > scripts/checkpatch.pl --terse --show-types --strict path/to/source/file > > needs to add the --file option

Re: Help

On Sat, Jan 06, 2018 at 05:44:46PM +0100, Farouk Maâboudallah wrote: > Good evening everyone :) > > I'm new here with you guys. I have been using Linux for 6 months ... And > now I'm looking forward to develop and improve my skills. > I'm a student in digital mechanics which means developing,

Re: Facing problem with mutt for replying or sending mails to linux kernel mailing list

On Sat, Dec 09, 2017 at 11:37:41AM +0530, Pravin Shedage wrote: > Hi Everyone, > > Sending mail from mutt failed You can send patches using git $ git send-email path/to/my.patch You may need to install separate package (git-email on Ubuntu). Hope this helps, Tobin.

kernel development cycle

Hi, Would someone please be able to expound on the stages of the kernel development cycle. In particular I would like to learn what a hobbyist kernel developer should be focusing their attention on during different stages of the cycle. In particular, what _not_ to do during certain stages of the

Re: git pull

On Tue, Nov 14, 2017 at 12:05:00PM +0100, Greg Kroah-Hartman wrote: > Adding lkml and linux-doc mailing lists... > > On Tue, Nov 14, 2017 at 10:11:55AM +1100, Tobin C. Harding wrote: > > Hi Greg, > > > > This is totally asking a favour, feel free to ignore. How do yo

git pull

Hi Greg, This is totally asking a favour, feel free to ignore. How do you format your [GIT PULL] emails to Linus? Do you create a tag and then run a git command to get the email? I tried to do it manually and failed pretty hard (as you no doubt will notice on LKML). thanks, Tobin.

Re: Non-web based LXR

On Tue, Oct 31, 2017 at 10:53:58AM +0100, François wrote: > On Tue, Oct 31, 2017 at 01:14:30PM +1100, Tobin C. Harding wrote: > > So, thank you for your ideas. I'll consider this issue resolved by; > > > > Use git grep > > Use ctags/etags > > Use free-electrons as

Re: Mentors and Archives?

On Tue, Oct 31, 2017 at 12:25:39PM -0400, leam hall wrote: > Newly back to the list. Is there a way to see if the idea of Kernel-Mentors > has been talked about recently besides pulling the zip files and grep'ing? > > if no one recalls any discussion; up for it? :) If we are going to discuss

Re: Non-web based LXR

On Tue, Oct 31, 2017 at 08:55:10AM +1100, Tobin C. Harding wrote: > CC'd Thomas because I read online recently him commenting on web based > cross reference tools. > > Hi, > > Does any one use a terminal based source code cross referencer to search > the kernel tree?

sleep

Is there any 'non-process' context apart from interrupt context? I had a re-read of sleep sections in ldd3 and in Robert Love's book but am still not totally clear on this. The reason for the question is understanding when we cannot sleep. thanks in advance, Tobin.

Re: Updating LDD3

On Tue, Oct 24, 2017 at 02:03:59PM +0100, Liam Ryan wrote: > On Tue, Oct 24, 2017 at 10:49:34AM -0200, Daniel. wrote: > > You're welcome! > > > > On Oct 24, 2017 10:38 AM, "Ozgur" wrote: > > > > > > > > Hello, > > > > > > 24.10.2017, 15:31, "Daniel."

Re: atomic test and set

On Fri, Oct 20, 2017 at 05:33:19PM +0800, Yubin Ruan wrote: > 2017-10-20 16:55 GMT+08:00 Tobin C. Harding <m...@tobin.cc>: > > On Fri, Oct 20, 2017 at 10:22:01PM +0800, Yubin Ruan wrote: > >> On Wed, Oct 18, 2017 at 11:40:44AM +1100, Tobin C. Harding wrote: > >&g

Re: atomic test and set

On Fri, Oct 20, 2017 at 10:22:01PM +0800, Yubin Ruan wrote: > On Wed, Oct 18, 2017 at 11:40:44AM +1100, Tobin C. Harding wrote: > > Hi, > > > > Do we have an atomic test and set function in the kernel. I have tried > > > > const int KEY_FLAG_BIT = 1;

Re: architecture conditional

On Mon, Oct 16, 2017 at 06:10:53PM +0200, Greg KH wrote: > On Mon, Oct 16, 2017 at 09:37:17PM +1100, Tobin C. Harding wrote: > > What is the correct way to write code that is conditionally compiled > > depending on 32/64 bit? > > Not to write code that is dependent on such

architecture conditional

What is the correct way to write code that is conditionally compiled depending on 32/64 bit? I found CONFIG_X86_64 CONFIG_64BIT Do we still support other word sizes? thanks, Tobin. ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org

Re: boot time variable

On Tue, Oct 10, 2017 at 09:08:30AM +0200, Greg KH wrote: > On Tue, Oct 10, 2017 at 10:17:09AM +1100, Tobin C. Harding wrote: > > Hi, > > > > I would like to create a boot time variable i.e a variable that is set once > > at boot time. Variable > > does n

Re: Xilinx clock wizard driver

> Merin > > Merin Santhosh > +1 (352) 214-3796 > > On Mon, Oct 9, 2017 at 5:46 PM, Tobin C. Harding <m...@tobin.cc> wrote: > > > On Mon, Oct 09, 2017 at 01:16:41PM -0400, Merin Santhosh wrote: > > > Hi All, > > > > > > I'm Merin, I'm a ma

boot time variable

Hi, I would like to create a boot time variable i.e a variable that is set once at boot time. Variable does not need to be globally accessible. (actually I am using two variables). Could any one point me to examples of this already intree please? I have tried the following but it has a race

Re: Xilinx clock wizard driver

On Mon, Oct 09, 2017 at 01:16:41PM -0400, Merin Santhosh wrote: > Hi All, > > I'm Merin, I'm a masters student at the University of Florida. Hi Merin, welcome. > I was doing > through the Linux Kernel, hoping to contribute to something of relevance. > Since I have a background in systems, I was

Re: What all are the drivers those get compiled with the kernel?

On Mon, Sep 11, 2017 at 07:42:42PM -0700, Dipanjan Das wrote: > There are numerous drivers present in the 'drivers' directory of Linux > kernel. The kernel source for any Android mobile device [e.g. > https://android.googlesource.com/kernel/msm/+/android-msm-2.6.35] is, too, > not an exception.

Re: how to instrument/debug module loading

On Tue, Sep 12, 2017 at 10:49:27AM -0400, Cliff Brake wrote: > Hi, > > I'm trying to better understand the kernel module loading mechanism > (for example when you plug in a USB device and a kernel module > autoloads). It appears that depmod creates a module.alias map that > maps USB info to

Re: Don't know where to start linux kernel programming

On Wed, Aug 23, 2017 at 03:57:05PM -0700, Greg KH wrote: > On Wed, Aug 23, 2017 at 09:06:49PM +0530, Umair Khan wrote: > > Hi Greg, > > > > On Tue, Aug 22, 2017 at 11:09 PM, Greg KH wrote: > > > On Tue, Aug 22, 2017 at 12:59:31PM -0400, valdis.kletni...@vt.edu wrote: > > >> On

Re: Don't know where to start linux kernel programming

On Tue, Aug 22, 2017 at 04:22:34PM +0530, SUNIL KHORWAL wrote: > Hi, > I'm new to linux kernel programming, I want to be a linux kernel hacker but > i don't know where to start. > Please help me. I recently wrote some blog posts on this topic. You can check them out at

Re: Don't know where to start linux kernel programming

On Tue, Aug 22, 2017 at 04:45:29PM +0530, SUNIL KHORWAL wrote: > Thank you very much. :) Friendly lesson number 1: don't top post when replying to email on a kernel mailing list. > > On Tue, Aug 22, 2017 at 4:44 PM, Kamil Konieczny < > k.koniec...@partner.samsung.com> wrote: > > > Hi, > > > >

Re: Contribute

On Sat, Jul 22, 2017 at 11:39:45AM +0200, nunojsa wrote: > Hi all, > > Im fairly new to linux kernel and would like to start with some staging work > (seems like the best way to start). > Basically what i would like to know is which tree should i clone for this? My > understanding is that one

Re: ks7010 cfg80211 re-write

On Fri, Jun 23, 2017 at 10:19:06PM +0800, Greg KH wrote: > On Thu, Jun 22, 2017 at 11:10:47AM +1000, Tobin C. Harding wrote: > > May I please ask two questions relating to the correct kernel development > > protocol to follow for the cfg80211 re-write. > > > > Cur

Re: My network device don't work

On Tue, Jun 20, 2017 at 10:12:34PM +0800, Greg KH wrote: > On Tue, Jun 20, 2017 at 02:32:31PM +0200, wiktoria.lewicka wrote: Expanding on Greg's response, the document you want to read is Documentation/process/coding-style.rst > > Hello. > > I write simple network device, but its don't work.

network driver tx/rx path buffers

Hi, I am implementing the rx/tx paths for a network driver. My current understanding is; On the tx path the driver processes the sk_buff, producing a frame, and writes this to the tx buffer. At interrupt time (given that the device produces interrupts for rx data received and tx data

Re: tx path circular buffer

On Wed, Jun 07, 2017 at 10:48:33AM +0200, Greg KH wrote: > On Wed, Jun 07, 2017 at 04:03:33PM +1000, Tobin C. Harding wrote: > > Hi, > > > > I am attempting to implement a circular buffer for the tx path of a > > networking driver. From my understanding this is someth

tx path circular buffer

Hi, I am attempting to implement a circular buffer for the tx path of a networking driver. From my understanding this is something that is very common, yet I am struggling to find a clear way to do it. I have tried to read the source for ath6kl, brcmfmac without success. I have read

Re: ks7010 firmware upload fail

On Mon, Jun 05, 2017 at 08:07:40PM -0400, Brian Masney wrote: > On Mon, Jun 05, 2017 at 08:24:44PM +1000, Tobin C. Harding wrote: > > On Mon, Jun 05, 2017 at 09:22:12AM +0200, Wolfram Sang wrote: > > > Tobin, > > > > > > > My question is should I be diggin

Re: ks7010 firmware upload fail

On Mon, Jun 05, 2017 at 09:22:12AM +0200, Wolfram Sang wrote: > Tobin, > > > My question is should I be digging further into the MMC code or be doing > > something else with the driver code? > > So, you haven't found any branch that worked? No plain v4.9 or the > gen3-sdio branch from my tree?

ks7010 firmware upload fail

Hi, I am attempting to test the ks7010 SIDO Wi-Fi driver (drivers/staging/ks7010/). Currently probing the driver fails because of a firmware upload error. I am seeking ideas on where to continue troubleshooting this issue. Test setup: - Spectec SDW-823 WIFI card (micro SD). - Raspberry Pi B 1

Re: endian patches

On Mon, May 01, 2017 at 09:39:23AM +0200, Bjørn Mork wrote: > "Tobin C. Harding" <m...@tobin.cc> writes: > > > Should [drivers/staging/*] patches to endian code be tested on hardware > > before submission? > > All patches should

endian patches

Should [drivers/staging/*] patches to endian code be tested on hardware before submission? During recent development of ks7010 driver, and from watching patch review on de...@linuxdriverproject.org, I formed the opinion that patches fixing endian issues need to be tested on hardware before they

Re: english grammar and patches

On Wed, Apr 26, 2017 at 06:34:39AM +0200, Greg KH wrote: > On Tue, Apr 25, 2017 at 09:25:26PM -0400, valdis.kletni...@vt.edu wrote: > > On Wed, 26 Apr 2017 10:27:00 +1000, "Tobin C. Harding" said: > > > This question relates to English grammar and correct usage when &

english grammar and patches

This question relates to English grammar and correct usage when writing gitlog messages and patch series cover letters. The writing of gitlog messages is covered in submitting-patches.rst, of note is the mood to use. It is not stated but I think it is a subjunctive description of the problem

Re: What is the fastest way to build and boot a kernel

On Tue, Apr 18, 2017 at 08:59:36AM -0700, Code Soldier1 wrote: [snip] Why the moniker? ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

Re: Patch Question

On Tue, Apr 18, 2017 at 05:07:08PM -0600, Perry Hooker wrote: > Thanks for the advice, Tobin - I appreciate the reply. Please don't top post http://daringfireball.net/2007/07/on_top I'm not an endian expert so I will not comment on the technical aspects of the path, I can however, comment on the

Re: Problems with adding a sysfs file

On Mon, Apr 17, 2017 at 02:04:48PM -0700, Abhishek Bhardwaj wrote: > I used a pr_debug and printk KERN_INFO ,before my original email , to > verify they weren't being called. You will have more success on kernel mailing lists if you do not top post as you have done :) > On Apr 17, 2017 1:43 PM,

Re: Patch Question

On Mon, Apr 17, 2017 at 05:28:46PM -0600, Perry Hooker wrote: > Hi everyone, > > I recently submitted a patch to the kernel mailing list: > https://lkml.org/lkml/2017/3/21/712 Link is broken. > I received some feedback on the patch. After a bit of polite > back-and-forth, the respondent stopped

Re: generic memory addresses

On Thu, Apr 06, 2017 at 06:59:02PM +0200, Greg KH wrote: > On Thu, Apr 06, 2017 at 08:11:34PM +1000, Tobin C. Harding wrote: > > On Thu, Apr 06, 2017 at 08:08:20AM +0200, Greg KH wrote: > > > On Thu, Apr 06, 2017 at 10:31:01AM +1000, Tobin C. Harding wrote: > > >

Re: generic memory addresses

On Thu, Apr 06, 2017 at 08:08:20AM +0200, Greg KH wrote: > On Thu, Apr 06, 2017 at 10:31:01AM +1000, Tobin C. Harding wrote: > > Why is there code in-tree that declares generic memory addresses as > > unsigned int? > > > > Linux Device Drivers 3rd Edition page 289 >

generic memory addresses

Why is there code in-tree that declares generic memory addresses as unsigned int? Linux Device Drivers 3rd Edition page 289 Therefore, generic memory addresses in the kernel are usually unsigned long, exploiting the fact that pointers and long integers are always the same size, at least on all

Re: [0] vs array

On Thu, Mar 30, 2017 at 04:05:51PM +, Nicholas Mc Guire wrote: > On Thu, Mar 30, 2017 at 09:04:35AM -0400, Ruben Safir wrote: > > On 03/29/2017 08:30 PM, Tobin C. Harding wrote: > > > Does the kernel community have a preference when using the address of > > > the f

Re: patch splitting

On Wed, Mar 29, 2017 at 08:55:02PM -0400, valdis.kletni...@vt.edu wrote: > On Thu, 30 Mar 2017 11:22:40 +1100, "Tobin C. Harding" said: > > Is it easier to review this change for correctness if it is three > > patches or one? > > > > TLDR; > >

[0] vs array

Does the kernel community have a preference when using the address of the first element of an an array? 1. addr = [0] 2. addr = array; $ grep '\&.*\[0\]' | wc -l 10077 style (1) is clearly used, I was not able to grep for instances where style (2) is used. thanks, Tobin.

patch splitting

Is it easier to review this change for correctness if it is three patches or one? TLDR; + struct wpa_key_t *key = >wpa.key[index]; - memcpy(>wpa.key[index].rx_seq[0], enc->rx_seq, IW_ENCODE_SEQ_MAX_SIZE); + memcpy(key->rx_seq, enc->rx_seq, IW_ENCODE_SEQ_MAX_SIZE);

0 bit shift

What is the reason for the zero bit shift in this code please? #define SDIO_STATE_PRESENT (1<<0) /* present in sysfs */ file: include/linux/mmc/sdio_func.h thanks, Tobin. ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org

edit wiki

Hi Rik, Could you please add me to the list of names for editing the kernelnewbies wiki. thanks, Tobin. ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

edit wiki

Could someone please add me to the list of names for editing the kernelnewbies wiki. >From https://kernelnewbies.org/ To prevent wiki spam, only users on this list are allowed to edit the wiki. Any of these users can add new usernames to the list. If you need to be on the list, please ask in

Re: My kernel patch was rejected with comments

On Wed, Mar 22, 2017 at 12:24:47PM +0530, Prasant J wrote: > Hi, > > I submitted a kernel patch and it was rejected with comments from > maintainer. Is it important to reply with a new patch against > maintainers response mail? Or it it ok if I send a new email with the > updated patch? You

Re: pr_debug

On Thu, Mar 16, 2017 at 01:17:42PM +0200, Alexander Kapshuk wrote: > On Wed, Mar 15, 2017 at 11:15 PM, Tobin C. Harding <m...@tobin.cc> wrote: > > On Wed, Mar 15, 2017 at 12:12:48PM +0100, Bjørn Mork wrote: > >> Alexander Kapshuk <alexander.kaps...@gmail.com> writes

Re: pr_debug

On Wed, Mar 15, 2017 at 12:12:48PM +0100, Bjørn Mork wrote: > Alexander Kapshuk <alexander.kaps...@gmail.com> writes: > > >>> On Wed, Mar 15, 2017 at 10:31 AM, Tobin C. Harding <m...@tobin.cc> wrote: > >>> > why does calling pr_debug() with more tha

Re: pr_debug

On Wed, Mar 15, 2017 at 12:01:39PM +0200, Alexander Kapshuk wrote: > On Wed, Mar 15, 2017 at 10:31 AM, Tobin C. Harding <m...@tobin.cc> wrote: > > why does calling pr_debug() with more than one argument cause a sparse > > warning? > > > > drivers/mmc/core/sdio_io.

pr_debug

why does calling pr_debug() with more than one argument cause a sparse warning? drivers/mmc/core/sdio_io.c:70:9: error: unknown field name in initializer sdio_io.c:70: pr_debug("SDIO: Enabling device %s...\n", sdio_func_id(func)); What can we do about this? thanks, Tobin.

driver dev mailing lists

What is the difference between these two mailing lists please? 1) de...@driverdev.osuosl.org 2) de...@linuxdriverproject.org drivers/staging/ks7010/TODO asks for patches to be sent to the second but scritps/get_maintainer.pl directs patches towards the first. thanks, Tobin.

Re: coccinelle

On Tue, Mar 14, 2017 at 08:52:02AM +0100, Peter Senna Tschudin wrote: > I guess this is off topic on this list. There is an specific > Coccinelle mailing list: > > https://systeme.lip6.fr/mailman/listinfo/cocci Noted, thank you. Tobin. ___

Re: coccinelle

On Tue, Mar 14, 2017 at 08:26:08AM +, Nicholas Mc Guire wrote: > On Tue, Mar 14, 2017 at 06:21:06PM +1100, Tobin C. Harding wrote: > > Attempting to do transform using Coccinelle > > > > if (foo != 0) { > >... > > > > -> > > > > if

standard error codes

Driver code in staging/drivers/ks7010 uses the error code -E2BIG as the error returned if a string argument is larger than destination buffer. Would this not be better suited to the error code -EOVERFLOW? Does it matter? For reference; #define E2BIG7 /* Argument list too long */ #define

Re: return codes

On Tue, Mar 14, 2017 at 10:08:51AM +0800, Greg KH wrote: > On Tue, Mar 14, 2017 at 01:03:07PM +1100, Tobin C. Harding wrote: > > On investigating call sites for 'return' in drivers/staging/ks7010/ > > it can be seen that a number of functions us *custom* (positive) > > integ

return codes

On investigating call sites for 'return' in drivers/staging/ks7010/ it can be seen that a number of functions us *custom* (positive) integers to indicate error. Notwithstanding that they are positive, is this ok for code in the kernel (i.e in order to get out of staging does this need to be

Re: diff

On Mon, Mar 13, 2017 at 07:43:00AM +, Nicholas Mc Guire wrote: > On Mon, Mar 13, 2017 at 05:57:14PM +1100, Tobin C. Harding wrote: > > On occasions diff output does not render the same as it does when > > editing a file. For example, while removing checkpatch tab warning > &g

diff

On occasions diff output does not render the same as it does when editing a file. For example, while removing checkpatch tab warning the following diff was generated -#define KS_WLAN_SET_WPS_ENABLE SIOCIWFIRSTPRIV + 4 -#define KS_WLAN_GET_WPS_ENABLE SIOCIWFIRSTPRIV

Re: cannot insmod sculld in ldd3

On Fri, Mar 10, 2017 at 08:19:29PM +0330, Ali Aminian wrote: > Hello > when i try to insmod sculld insmod prints this error message: > insmod: ERROR: could not insert module ./sculld.ko: Invalid parameters What source code are you using. The is a port here

Re: patch protocol question

On Wed, Mar 08, 2017 at 12:12:50AM +0100, Peter Senna Tschudin wrote: > On Tue, Mar 7, 2017 at 10:29 PM, Tobin C. Harding <m...@tobin.cc> wrote: > > I would like to know the correct protocol in order to make the > > maintainers job as easy as possible please. > > > &g

sizeof

Question relating to the validity/usefulness of patching calls to sizeof. >From Documentation/process/coding-style.rst The preferred form for passing a size of a struct is the following: .. code-block:: c p = kmalloc(sizeof(*p), ...); The alternative form where struct name is spelled

patch protocol question

I would like to know the correct protocol in order to make the maintainers job as easy as possible please. Once a patch has been reviewed and the review makes good points that mean the patch is invalid/unnecessary what is the protocol from then? Assuming one replies to the reviewer with thanks

log file created by git send-email?

Is there a log of emails sent using `git send-email`? The man page does not mention one and web search on 'log' returns commands related (unsurprisingly) to `git log`. thanks, Tobin. ___ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org

  1   2   >