Re: [PATCH] fix error handling in drivers/staging/rtl8192u/ieee80211/ieee80211_module.c

2018-10-03 Thread Kees Cook
On Wed, Sep 26, 2018 at 10:52 AM, wrote: > John notes that if the kzalloc of ieee->pHTInfo fails, we fail to call > ieee80211_networks_free(). In addition, that function has an un-needed check > before kfree(). > > Reported-by: John Whitmore > Signed-off-by: Valdis Kletnieks Reviewed-by:

Re: [PATCH] fix error handling in drivers/staging/rtl8192u/ieee80211/ieee80211_module.c

2018-10-03 Thread Kees Cook
On Thu, Sep 27, 2018 at 7:24 AM, Dan Carpenter wrote: > On Wed, Sep 26, 2018 at 01:52:17PM -0400, valdis.kletni...@vt.edu wrote: >> John notes that if the kzalloc of ieee->pHTInfo fails, we fail to call >> ieee80211_networks_free(). In addition, that function has an un-needed check >> before

Re: [PATCH] fix error handling in drivers/staging/rtl8192u/ieee80211/ieee80211_module.c

2018-09-27 Thread Dan Carpenter
On Wed, Sep 26, 2018 at 01:52:17PM -0400, valdis.kletni...@vt.edu wrote: > John notes that if the kzalloc of ieee->pHTInfo fails, we fail to call > ieee80211_networks_free(). In addition, that function has an un-needed check > before kfree(). > > Reported-by: John Whitmore > Signed-off-by:

[PATCH] fix error handling in drivers/staging/rtl8192u/ieee80211/ieee80211_module.c

2018-09-26 Thread valdis . kletnieks
John notes that if the kzalloc of ieee->pHTInfo fails, we fail to call ieee80211_networks_free(). In addition, that function has an un-needed check before kfree(). Reported-by: John Whitmore Signed-off-by: Valdis Kletnieks --- diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c