Re: Please give advise about my first patch attempt

2020-09-03 Thread Thomas Schmitt
Hi, i'm back at work with my patch for automatic CD loading, but the target moves faster than i can follow. Meanwhile the sr part of my change plays on a fresh construction site of linux-scsi: https://lore.kernel.org/linux-scsi/730eced4-c804-a78f-3d52-2a448dbd1...@interlog.com/T/#t "rework

Re: Please give advise about my first patch attempt

2020-08-28 Thread Thomas Schmitt
Hi, i might get a community problem with the goal of my patch. While googling for hints of acceptance for cdrom on linux-s...@vger.kernel.org i came to a thread where a much more expensive fix of the problem was obviously rejected by Jens Axboe in november 2019:

Re: Please give advise about my first patch attempt

2020-08-27 Thread Pawan Gupta
On Thu, Aug 27, 2020 at 10:49:51AM +0200, Thomas Schmitt wrote: > Hi, > > i am preparing my first patch. > May i ask for review and advise how to make it acceptable ? If you are not running it already you can catch common mistakes by running checkpatch script from the kernel source top directory

Re: Please give advise about my first patch attempt

2020-08-27 Thread Lukas Bulwahn
On Thu, 27 Aug 2020, Thomas Schmitt wrote: > Hi, > > Lukas Bulwahn wrote: > > Just take all maintainers as recipients. > > ax...@kernel.dk linux-ker...@vger.kernel.org j...@linux.ibm.com > > martin.peter...@oracle.com linux-s...@vger.kernel.org > > Really that loudly ? > Ain't

Re: Please give advise about my first patch attempt

2020-08-27 Thread Thomas Schmitt
Hi, Lukas Bulwahn wrote: > Just take all maintainers as recipients. > ax...@kernel.dk linux-ker...@vger.kernel.org j...@linux.ibm.com > martin.peter...@oracle.com linux-s...@vger.kernel.org Really that loudly ? Ain't linux-ker...@vger.kernel.org too general ? > It is probably best to base it

Re: Please give advise about my first patch attempt

2020-08-27 Thread Greg KH
On Thu, Aug 27, 2020 at 10:02:21AM -0400, Leam Hall wrote: > On Thu, Aug 27, 2020 at 9:20 AM Greg KH wrote: > > > That is also documented in the ever-growing submitting patches document > > somewhere... > > This? > > https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html That's

Re: Please give advise about my first patch attempt

2020-08-27 Thread Leam Hall
On Thu, Aug 27, 2020 at 9:20 AM Greg KH wrote: > That is also documented in the ever-growing submitting patches document > somewhere... This? https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html ___ Kernelnewbies mailing list

Re: Please give advise about my first patch attempt

2020-08-27 Thread Greg KH
On Thu, Aug 27, 2020 at 11:52:56AM +0200, Garrit Franke wrote: > Hi Thomas, > > Noob here. > > On Thu, Aug 27, 2020 at 10:49 AM Thomas Schmitt wrote: > > > > Commit 210ba1d1724f5c4ed87a2ab1a21ca861a915f734 of january 2008 switched > > sr_drive_status() away from indirectly using sr_do_ioctl()

Re: Please give advise about my first patch attempt

2020-08-27 Thread Garrit Franke
Hi Thomas, Noob here. On Thu, Aug 27, 2020 at 10:49 AM Thomas Schmitt wrote: > > Commit 210ba1d1724f5c4ed87a2ab1a21ca861a915f734 of january 2008 switched > sr_drive_status() away from indirectly using sr_do_ioctl() for sending > TEST UNIT READY commands. sr_do_ioctl() has a wait-and-retry loop

Re: Please give advise about my first patch attempt

2020-08-27 Thread Lukas Bulwahn
Hi Thomas, On Thu, 27 Aug 2020, Thomas Schmitt wrote: > Hi, > > i am preparing my first patch. > May i ask for review and advise how to make it acceptable ? > > The patch shall fix an old regression of cdrom and sr drivers. > Although drivers/cdrom has no mailing list entry in MAINTAINERS, i

Please give advise about my first patch attempt

2020-08-27 Thread Thomas Schmitt
Hi, i am preparing my first patch. May i ask for review and advise how to make it acceptable ? The patch shall fix an old regression of cdrom and sr drivers. Although drivers/cdrom has no mailing list entry in MAINTAINERS, i assume that such patches should go to linux-s...@vger.kernel.org which