Re: Linux do_coredump() and SMP systems

2015-02-17 Thread Greg KH
On Tue, Feb 17, 2015 at 07:11:55PM +0530, Sudharsan Vijayaraghavan wrote: Hi All, We are running 3.8 kernel. That's pretty old and obsolete, why are you stuck with that version? I have a unique scenario, where we hit on several issues in do_coredump. We have a SMP system with thousands of

Re: Linux do_coredump() and SMP systems

2015-02-18 Thread Greg KH
On Wed, Feb 18, 2015 at 11:44:32AM +0530, Sudharsan Vijayaraghavan wrote: We are doing prototype so much change have gone into kernel , we are finding it difficult to upgrade to latest immediately What changes are you making to the kernel that you are sticking with such an old version (3.8 is 2

Re: Kernel 2.6.32.60 64bit Crash/Hung

2015-01-26 Thread Greg KH
On Tue, Jan 27, 2015 at 12:06:56AM +, Giridhara RP (grp) wrote: Hi, I am facing crash/hang with 2.6.32.60 Kernel (64bit). Note this is a _very_ old and obsolete kernel, please use a modern kernel release if you wish to get help from the community. If you are being forced to use

Re: Kernel 2.6.32.60 64bit Crash/Hung

2015-01-27 Thread Greg KH
On Tue, Jan 27, 2015 at 03:52:05AM +, Giridhara RP (grp) wrote: Hi Greg, Thanks for the quick turnaround. Which is the stable version? Kernel 2.6.32.60 was used in RHEL 6.2 and we thought this kernel version is stable. What do you mean by stable? Yes, it is stable if you have hardware

Re: Can I submit simple patches like this to the primary ML?

2015-01-28 Thread Greg KH
On Thu, Jan 29, 2015 at 01:48:43AM -0200, Vinícius Tinti wrote: This is a simple patch that initializes a function with NULL to avoid some compiler warnings. In such cases should I proceed as a normal patch or it is better to send to another ML like to one for trivial patches? Thanks,

Re: Can I submit simple patches like this to the primary ML?

2015-01-28 Thread Greg KH
On Thu, Jan 29, 2015 at 02:16:51AM -0200, Vinícius Tinti wrote: On Thu, Jan 29, 2015 at 2:08 AM, Greg KH g...@kroah.com wrote: On Thu, Jan 29, 2015 at 01:48:43AM -0200, Vinícius Tinti wrote: This is a simple patch that initializes a function with NULL to avoid some compiler warnings

Re: Can I submit simple patches like this to the primary ML?

2015-01-29 Thread Greg KH
On Thu, Jan 29, 2015 at 09:27:48AM -0200, Vinícius Tinti wrote: On Thu, Jan 29, 2015 at 3:07 AM, Greg KH g...@kroah.com wrote: In fact it causes a warning on Clang which complains that: arch/x86/tools/relocs.c:977:6: warning: variable 'do_reloc' is used uninitialized whenever

Re: Linux Kernel readlink equivalent

2015-01-29 Thread Greg KH
On Thu, Jan 29, 2015 at 01:11:13PM -0500, David Legault wrote: Hello, I'm working on some linux kernel driver stuff and I have a fake path called / dev/blah/whatever that points to /dev/block/real_device. That's a userspace path, right? Why would the kernel care about this? The issue is

Re: booting arm board

2015-01-12 Thread Greg KH
On Sun, Jan 11, 2015 at 10:38:08PM -0500, John de la Garza wrote: I am trying to boot a foxg20 board. It uses an at91sam9g20 chip an used to work in linux 3.5. I am looking for some advice on how to get mainline linux to boot on it. I first tried bisecting and found this commit:

Re: PCIe recovery mechanism

2015-01-08 Thread Greg KH
On Fri, Jan 09, 2015 at 10:19:15AM +0530, Avinash Patil wrote: Hello, I was wondering if there is any way to recover from FW crash in case of WLAN PCie cards- say we power off card and power on. This would enable hotplug to detect it again and driver's probe routine would do redownload of

Re: Query regarding a IIO consumer touchscreen driver

2015-01-09 Thread Greg KH
On Fri, Jan 09, 2015 at 05:02:14PM +0530, Sanchayan Maity wrote: Hello, I have been working on a IIO consumer touchscreen driver. On one of our Vybrid modules we use the ADC channels for the touchscreen. I ported an earlier driver in the 3.0 kernel done by my colleague to the recent

Re: Wait times for patch submission

2015-01-06 Thread Greg KH
On Tue, Jan 06, 2015 at 11:31:53AM -0800, Mandeep Sandhu wrote: Hi All, I wanted to check with ppl who frequently post patches to LKML on how long should one should wait before resending the patches in case there's no response to them. I had sent a patch on Greg KH's staging-next tree, on

Re: Difference between INIT_LIST_HEAD and LIST_HEAD_INIT

2015-01-06 Thread Greg KH
On Tue, Jan 06, 2015 at 01:26:45PM -0800, anish singh wrote: On Tue, Jan 6, 2015 at 1:37 AM, nawab nawabli...@gmail.com wrote: hi friends , i have a simple doubt when i was looking on linux/list.h I have seen that   INIT_LIST_HEAD and LIST_HEAD_INIT are performing the

Re: Wait times for patch submission

2015-01-06 Thread Greg KH
On Tue, Jan 06, 2015 at 01:24:33PM -0800, Mandeep Sandhu wrote: And normally that would have happened already, but I was on vacation for a few weeks and am still catching up on patches. Stuff like code cleanup for staging is at the bottom of my list at the moment, as it's not essencial

Re: pmbus driver for x86

2015-01-12 Thread Greg KH
On Mon, Jan 12, 2015 at 03:34:45PM +0900, J.Hwan Kim wrote: Hi, My server (S2600CP) has BMC module and power supply with pmbus function. When I try to control and monitor with pmbus driver in linux, it fails. I connected oscilloscope to pmbus connector (SCL, SDA) pins, there was no signal

Re: HID Custom Sensor driver in linux kernel

2015-02-10 Thread Greg KH
On Tue, Feb 10, 2015 at 11:12:57PM +0530, s.rawat wrote: I am reading the HID sensor hub code on lxr  and found that there is no driver code for hid custom sensor.Is this driver non existent.Hid custom sensor is a custom sensor implemented in the device firmware. I have a sensor device to

Re: ternary vs double exclamation

2015-01-04 Thread Greg KH
On Sun, Jan 04, 2015 at 06:43:22PM -0500, John de la Garza wrote: On Sat, Jan 03, 2015 at 11:20:29PM -0500, valdis.kletni...@vt.edu wrote: On Sat, 03 Jan 2015 18:54:00 -0500, John de la Garza said: It should not be assumed that true will always be 1 as defined in

Re: ternary vs double exclamation

2015-01-07 Thread Greg KH
On Wed, Jan 07, 2015 at 08:46:52PM -0800, John de la Garza wrote: On Sun, Jan 04, 2015 at 04:50:58PM -0800, Greg KH wrote: On Sun, Jan 04, 2015 at 06:43:22PM -0500, John de la Garza wrote: I assume it is a bad idea to depend on true being 1, right?  I mean, I should assume that true could

Re: Kernel Mocking

2015-02-20 Thread Greg KH
On Fri, Feb 20, 2015 at 02:51:25PM -0500, Kenneth Adam Miller wrote: So, in userland development, the idea of mocking is used to isolate context management and machine configuration into a single class or set of functions that can be reused, and also facilitate testing much easier. Google mock

Re: use of dev-dev_t

2015-03-17 Thread Greg KH
On Tue, Mar 17, 2015 at 08:43:38PM +, Malte Vesper wrote: Hi, I am trying to write a driver that uses the MINOR(dev_t) to identify cards. Since it is a PCI driver and I get pcidev-dev.dev_t anyway. I thought about not bothering to store the minor number of the device. However if I look

Re: use of dev-dev_t

2015-03-17 Thread Greg KH
On Tue, Mar 17, 2015 at 09:46:13PM +, Malte Vesper wrote: On 17/03/15 21:13, Greg KH wrote: On Tue, Mar 17, 2015 at 08:43:38PM +, Malte Vesper wrote: Hi, I am trying to write a driver that uses the MINOR(dev_t) to identify cards. Since it is a PCI driver and I get pcidev-dev.dev_t

Re: Android Binder Issue

2015-03-17 Thread Greg KH
On Tue, Mar 17, 2015 at 01:04:40PM -0400, David Legault wrote: Hello, I'm trying to debug an issue I'm encountering on kernel 3.4 in the android binder.  Basically in the function binder_update_page_range it allocates a page. If I  understand correctly the next part, it maps this page_addr

Re: CHECK: Alignment should match open parenthesis

2015-03-13 Thread Greg KH
On Fri, Mar 13, 2015 at 04:35:30PM +0200, Daniel Baluta wrote: On Fri, Mar 13, 2015 at 3:47 PM, Nicholas Mc Guire der.h...@hofr.at wrote: On Fri, 13 Mar 2015, Nicholas Mc Guire wrote: On Fri, 13 Mar 2015, palik imre wrote: On Friday, 13 March 2015, 13:43, Nicholas Mc Guire

Re: Can add new module without upgrade the kernel?

2015-03-30 Thread Greg KH
On Mon, Mar 30, 2015 at 10:58:12PM +0800, Woody Wu wrote: Unfortunately I failed in 'modprobe'. FFC3 3.1.0-ffc3mb-00050-g5874787 # pwd /lib/modules/3.1.0-ffc3mb-00050-g5874787 FFC3 3.1.0-ffc3mb-00050-g5874787 # modprobe tun modprobe: can't load module tun (net/tun.ko): invalid module format

Re: what is the precise udev event that handles miscdevices?

2015-04-01 Thread Greg KH
On Wed, Apr 01, 2015 at 07:43:05AM -0400, Robert P. J. Day wrote: i can trivially create misc character devices, and i know special device files for them will automatically show up under /dev, but what is the precise udev event/rule that comes into play for this? if i start to monitor

Re: what is the precise udev event that handles miscdevices?

2015-04-01 Thread Greg KH
On Wed, Apr 01, 2015 at 08:18:13AM -0400, Robert P. J. Day wrote: On Wed, 1 Apr 2015, Greg KH wrote: In fact, no one does this anymore, and people run systems without udev and have dynamic device nodes just fine. And have been doing so for years, udev isn't needed for device nodes anymore

Re: coming shortly: series of simple kernel questions i should know the answers to

2015-04-01 Thread Greg KH
On Wed, Apr 01, 2015 at 07:38:22AM -0400, Robert P. J. Day wrote: On Wed, 1 Apr 2015, Greg KH wrote: On Wed, Apr 01, 2015 at 07:21:38AM -0400, Robert P. J. Day wrote: a lot of the early questions will be based on clarifying details of the driver model, as the current documentation

Re: coming shortly: series of simple kernel questions i should know the answers to

2015-04-01 Thread Greg KH
On Wed, Apr 01, 2015 at 07:21:38AM -0400, Robert P. J. Day wrote: a lot of the early questions will be based on clarifying details of the driver model, as the current documentation under Documentation/driver-model/ is somewhat out of date so i desperately need to put together something far

Re: what is the precise udev event that handles miscdevices?

2015-04-01 Thread Greg KH
On Wed, Apr 01, 2015 at 07:43:05AM -0400, Robert P. J. Day wrote: i can trivially create misc character devices, and i know special device files for them will automatically show up under /dev, but what is the precise udev event/rule that comes into play for this? There isn't one. Gee,

Re: locking a device for exclusive use by userspace process (or kernel thread)

2015-03-04 Thread Greg KH
On Wed, Mar 04, 2015 at 06:59:04PM +0100, Yann Droneaud wrote: Hi, I have a device and I have to write a driver that exposes the following three operations to kernel modules AND to userspace programs: snip Why? What type of device is this? And who is asking you to do this homework

Re: Kernel Mocking

2015-02-20 Thread Greg KH
On Fri, Feb 20, 2015 at 03:26:40PM -0500, Kenneth Adam Miller wrote: Thanks for your expedient answer! So, I was discussing an alternative to mocking; function hooking. But in a benign way. Is there any way to, at runtime replace the functionality of code in order that you specify what it

Re: apparent sleep

2015-03-23 Thread Greg KH
On Mon, Mar 23, 2015 at 05:31:51AM -0700, Milton Krutt wrote: Hi. Following LDD3, I am dealing with wait queues, on a 2.6.10. Please use a modern kernel, 2.6.10 is _very_ old and no one can do anything about it, and those that could, have long forgotten what was in it. good luck, greg k-h

Re: upstream EXPORT_SYMBOL() for out of tree module?

2015-04-14 Thread Greg KH
On Thu, Apr 09, 2015 at 07:07:30PM +, dwal...@fifo99.com wrote: Hi all, I have an out of tree module which uses the xlate_dev_mem_ptr() function on x86. I wanted to know if the kernel community would accept a patch to add an EXPORT_SYMBOL() for this kernel with out the

Re: How do _you_ read the linux source?

2015-04-20 Thread Greg KH
On Sun, Apr 19, 2015 at 06:57:49PM -0700, r0...@simplecpu.com wrote: The problem a lot of newbies are having is in 'separating the trunk from the leaves.' So my question is this: Experienced kernel developers, how do _you_ read source code? How do you separate the trunk from the leaves?

Re: kbuild- sub directroy makefile

2015-04-22 Thread Greg KH
On Wed, Apr 22, 2015 at 09:11:36PM +0530, ratheesh kannoth wrote: **Start of Makfile*** ccflags += -D DEXI obj-m := hello.o End* Is there any way i can echo a string ...like Hey i am building hello.o now in this makefile ? Nope, why

Re: kbuild- sub directroy makefile

2015-04-22 Thread Greg KH
On Wed, Apr 22, 2015 at 09:42:59PM +0530, ratheesh kannoth wrote: On Wed, Apr 22, 2015 at 9:36 PM, Greg KH g...@kroah.com wrote: Nope, why do you want to do that? The kernel build will show you that hello.o is being built, when it is built. Greg, There was some problem with env variables

Re: How to get kernel header from my kernel source tree?

2015-04-27 Thread Greg KH
On Mon, Apr 27, 2015 at 05:40:11PM +0800, tianlilai wrote: Hi,Everyone: I have updated the kernel from v2.6.32 to v2.6.36 using my kernel source tree(v2.6.36). so I must provide the new kernel header to the developers of the device driver. How can I get the kernel header from my kernel

Re: Preferred userspace IPC mechanism for new drivers?

2015-05-07 Thread Greg KH
On Wed, May 06, 2015 at 09:07:46PM +, Larrew, Jesse wrote: Hello, I’m writing a driver that needs to communicate with userspace applications. What type of driver? Userspace needs to be able to send commands and associated data to the driver, so the ioctl interface seems pretty

Re: Suggested environments for kernel development

2015-05-03 Thread Greg KH
On Sun, May 03, 2015 at 06:11:35PM +0100, Lewis Clark wrote: I would really like to know how you guys do your kernel development. What distro do you use and whats the process? I’m very comfortable with debian, but i’ve heard it’s not the easiest distro to build kernels for as you need to

Re: percolating ERESTARTSYS beyond PCI subsystem

2015-04-18 Thread Greg KH
On Sat, Apr 18, 2015 at 01:40:57PM +0200, Milton Krutt wrote: Hi. The scenario is a PCI driver on a kernel 3.19.2: is it possible, in case pending_signal(current) is true, to return -ERESTARTSYS to insmod process, in order to get it restart (as expectable)? After some attempts (with

Re: Learning things

2015-04-06 Thread Greg KH
On Mon, Apr 06, 2015 at 10:43:46AM -0700, Joris Bolsens wrote: Hey list, I'm working on trying to teach myself C and was wondering if you had any kernel specific recommendations. I started the eudyptula challenge but so far it seems to be mostly learning the standards and whatnot. Are there

Re: https://lkml.org/lkml/2014/11/13/785

2015-04-02 Thread Greg KH
On Thu, Apr 02, 2015 at 02:26:40PM +, Hemanth Kumar wrote: Hi All/greg, What is the reason this particular patch is still not yet merged https://lkml.org/lkml/2014/11/13/785 This is straight patch which fixes this issue for arm64 bit. Why not ask the developers involved, and the

Re: Change proc/pid/cmdline to 8k

2015-06-04 Thread Greg KH
On Thu, Jun 04, 2015 at 09:06:10PM +0530, Navin P wrote: On Thu, Jun 4, 2015 at 1:34 PM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Jun 04, 2015 at 01:11:48PM +0530, Navin P wrote: On Thu, Jun 4, 2015 at 10:47 AM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Jun 04, 2015

Re: Guidance about minimal configurations for kernel compilation

2015-06-07 Thread Greg KH
On Sun, Jun 07, 2015 at 09:45:07PM +0530, Mayur Patil wrote: Hi All,     I am struggling to build small size with minimum time for kernel  compilation with vanilla kernels of  kernel.org.  As mentioned in the makehelp, I have used defconfig but unable to get  desirable results. I have

Re: miscdevice and default attributes

2015-06-08 Thread Greg KH
On Sun, Jun 07, 2015 at 08:13:37PM -0700, David Bakin wrote: Where do I set the default attributes for a device created with misc_register ()? In kernel 3.19 struct miscdevice looks like this: struct miscdevice  {  int minor;  const char *name;  const struct file_operations *fops;  

Re: Accessing Ram on PCI card

2015-06-04 Thread Greg KH
On Wed, Jun 03, 2015 at 08:27:20PM +0530, Robert Clove wrote: Hi I have a PCI based card which have few RAM on it. You said that before :) You didn't answer the question of what kind of PCI card is this? I have to copy the text file to RAM and read it too. Who is telling you you have to?

Re: Change proc/pid/cmdline to 8k

2015-06-03 Thread Greg KH
On Thu, Jun 04, 2015 at 09:52:08AM +0530, Navin P wrote: Hi, I want to change the cmdline of a process to support 8096 . It works well on ppc where the page size is 65k. But when i try to increase it on x86 (i686) http://lxr.free-electrons.com/source/fs/proc/base.c by doing

Re: Change proc/pid/cmdline to 8k

2015-06-04 Thread Greg KH
On Thu, Jun 04, 2015 at 01:11:48PM +0530, Navin P wrote: On Thu, Jun 4, 2015 at 10:47 AM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Jun 04, 2015 at 09:52:08AM +0530, Navin P wrote: Hi, I want to change the cmdline of a process to support 8096 . It works well on ppc where

Re: Accessing Ram on PCI card

2015-06-04 Thread Greg KH
On Thu, Jun 04, 2015 at 12:44:34PM +0530, Robert Clove wrote: Actually it is a PCI based NIC card having a NIC port and some RAM on it. A NIC card is not designed to hold a filesystem. If you wish to change this, you are going to have to write a kernel driver that talks to that card and exposes

Re: Transfer Buffer in URB

2015-06-25 Thread Greg KH
On Thu, Jun 25, 2015 at 06:16:28PM +0530, roni wrote: What is the transfer buffer in URB? What is the job of transfer buffer? The in-kernel documentation should answer these questions, which is why we wrote it :) ___ Kernelnewbies mailing list

Re: Transfer Buffer in URB

2015-06-25 Thread Greg KH
On Thu, Jun 25, 2015 at 05:41:31PM +0200, Luis de Bethencourt wrote: On Thu, Jun 25 2015 at 10:43:32AM -0400, Greg KH wrote: On Thu, Jun 25, 2015 at 06:16:28PM +0530, roni wrote: What is the transfer buffer in URB? What is the job of transfer buffer? The in-kernel documentation

Re: Kernel contributions from organisations and individual privacy

2015-06-11 Thread Greg KH
On Thu, Jun 11, 2015 at 02:58:01PM +1000, Jason Ball wrote: I had a similar situation and managed to route patches via an intermediary to protect my employers anonymity at the time.   You may (should) be able to find an appropriate sponsor depending on the nature of the customisations. You can

Re: Kernel contributions from organisations and individual privacy

2015-06-11 Thread Greg KH
On Thu, Jun 11, 2015 at 01:19:56AM -0400, Ruben Safir wrote: On 06/11/2015 01:10 AM, Chris Packham wrote: It's not a concern for the _employer If the copyright is owned by the company then ONLY the company can push it up stream and assign copyright to the Linux Foundation. No one assigns

Re: Kernel contributions from organisations and individual privacy

2015-06-11 Thread Greg KH
On Wed, Jun 10, 2015 at 09:19:00PM +1200, Chris Packham wrote: Hi, This came up at work today and I'm not sure where the best place to ask is. I almost went straight to the lkml but I figured I'd start with newbies first. We've been using the Linux kernel in our products for a number of

Re: Userpace serial port

2015-06-11 Thread Greg KH
On Thu, Jun 11, 2015 at 08:39:39AM +0200, Ricardo Ribalda Delgado wrote: Hello Greg On Thu, Jun 11, 2015 at 5:52 AM, Greg KH g...@kroah.com wrote: On Wed, Jun 10, 2015 at 02:39:35PM +0200, Ricardo Ribalda Delgado wrote: Nowadays there is a kernel land implementation of ethercat master

Re: Android Kernel

2015-06-16 Thread Greg KH
On Wed, Jun 17, 2015 at 07:50:33AM +0900, Leng Xuedong wrote: Dear All, It is a question about Android Kernel. Do you know how does Android mount devices in /dev ? I found something like  chmod 0660 /dev/pn547 in the /init.rc file. but actually, there is no /dev/pn547 . I want to

Re: Building which kernel?

2015-06-14 Thread Greg KH
On Sun, Jun 14, 2015 at 02:11:33PM +0100, John Whitmore wrote: I've a question regarding the building of the linux kernel, more specifically which kernel to build. Always the latest version, why would you want to build an old one? I've previously built the kernel for an 86 arch but this time

Re: opening a BUG in kernel bugzilla (https://bugzilla.kernel.org/)

2015-06-12 Thread Greg KH
On Fri, Jun 12, 2015 at 11:09:10AM +0300, Kevin Wilson wrote: Hi all, Can we open a BUG in kernel bugzilla (https://bugzilla.kernel.org/) against a kernel image which was found on an image which was built from most recent build of Linus tree

Re: Userpace serial port

2015-06-10 Thread Greg KH
On Wed, Jun 10, 2015 at 02:39:35PM +0200, Ricardo Ribalda Delgado wrote: Hello I have a serial port accesible via Ehtercat. http://www.beckhoff.dk/english.asp?ethercat/el6001.htm Ethercat is a fancy way of accessing i/o devices via ethernet. You can read/write registers with close to

Re: Kernel contributions from organisations and individual privacy

2015-06-11 Thread Greg KH
On Thu, Jun 11, 2015 at 07:26:23PM -0400, Ruben Safir wrote: Lets say Apple decides that are going to take the Linux Kernel and alter it extensively, in order for it to work with a new hardware platform that they created. And lets say don't return the code base to the public. Now who is

Re: Stop usbhid from claiming usb device on hotplug

2015-05-30 Thread Greg KH
On Sat, May 30, 2015 at 01:43:20AM -0400, Armin Moradi wrote: I'm writing a kernel module, but probe() is never called since usbhid claims the usb device as soon as the device is plugged in. What type of module for what type of device? And why do you want to override the hid driver from

Re: Accessing Ram on PCI card

2015-06-01 Thread Greg KH
On Mon, Jun 01, 2015 at 10:55:44PM +0530, Robert Clove wrote: Hi, I have a pci card that has some amount of ram and flash memory on it. What kind of card? I have found the bar address range for the memory. I want to transfer a file to that memory and read from that memory. PCI card memory

Re: kselftest framework runs as build time or run time tests ?

2015-06-30 Thread Greg KH
On Tue, Jun 30, 2015 at 07:34:42PM -0500, Victor Rodriguez wrote: HI team Quick question , does kselftest: https://kselftest.wiki.kernel.org/ Run on build time or run time ? I wonder because we want to implement it as part of our releases process ( which run on koji ) and honestly I

Re: Kernel contributions from organisations and individual privacy

2015-06-11 Thread Greg KH
On Thu, Jun 11, 2015 at 10:41:57AM -0400, Ruben Safir wrote: On 06/11/2015 10:28 AM, Greg KH wrote: If the copyright is owned by the company then ONLY the company can push it up stream and assign copyright to the Linux Foundation. No one assigns kernel copyright to the Linux Foundation

Re: Kernel contributions from organisations and individual privacy

2015-06-11 Thread Greg KH
On Thu, Jun 11, 2015 at 12:39:47PM -0400, Ruben Safir wrote: On 06/11/2015 11:38 AM, Greg KH wrote: On Thu, Jun 11, 2015 at 10:41:57AM -0400, Ruben Safir wrote: On 06/11/2015 10:28 AM, Greg KH wrote: If the copyright is owned by the company then ONLY the company can push it up stream

Re: Kernel contributions from organisations and individual privacy

2015-06-11 Thread Greg KH
On Thu, Jun 11, 2015 at 12:39:47PM -0400, Ruben Safir wrote: The only thing you have to agree with when contributing Linux kernel code is the DCO, which can be found in the file Documentation/SubmittingPatches, or here online: http://developercertificate.org/ I didn't know that

Re: [RFC] Implementing an additional TCP congestion control algorithm (TCP-PR) - communication and organisation.

2015-08-11 Thread Greg KH
On Wed, Aug 12, 2015 at 03:32:07AM +0200, Richard Sailer wrote: It would be a great help for me, if you could (even if just shortly) review the mailtext and tell me your opinion. Please do not answer the questions in the mail, they're somehow meant as discussion starters for the netdev

Re: [PATCH 1/3] firmware: introduce sysfs driver for QEMU's fw_cfg device

2015-08-21 Thread Greg KH
On Mon, Aug 10, 2015 at 12:31:18PM -0400, Gabriel L. Somlo wrote: From: Gabriel Somlo so...@cmu.edu Make fw_cfg entries of type file available via sysfs. Entries are listed under /sys/firmware/fw_cfg/by_select, in folders named after each entry's selector key. Filename, selector value, and

Re: [PATCH 3/3] firmware: fw_cfg: create directory hierarchy for fw_cfg file names

2015-08-21 Thread Greg KH
On Mon, Aug 10, 2015 at 12:31:20PM -0400, Gabriel L. Somlo wrote: From: Gabriel Somlo so...@cmu.edu Each fw_cfg entry of type file has an associated 56-char, nul-terminated ASCII string which represents its name. While the fw_cfg device doesn't itself impose any specific naming convention,

Re: [PATCH 2/3] kobject: export kset_find_obj() to be used from modules

2015-08-21 Thread Greg KH
On Mon, Aug 10, 2015 at 12:31:19PM -0400, Gabriel L. Somlo wrote: From: Gabriel Somlo so...@cmu.edu Signed-off-by: Gabriel Somlo so...@cmu.edu --- lib/kobject.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/kobject.c b/lib/kobject.c index 3e3a5c3..f9754a0 100644 ---

Re: [PATCH 1/3] firmware: introduce sysfs driver for QEMU's fw_cfg device

2015-08-21 Thread Greg KH
On Mon, Aug 10, 2015 at 03:02:22PM -0400, Gabriel L. Somlo wrote: Mainly, qemu's fw_cfg is a read-only device, so one wouldn't ever care to try writing anything to it. /sys/firmware/... feels like a fit because fw_cfg contains binary blobs originally meant to be used by the bios (it's how

Re: [PATCH 2/3] kobject: export kset_find_obj() to be used from modules

2015-08-21 Thread Greg KH
On Mon, Aug 10, 2015 at 02:43:10PM -0400, Gabriel L. Somlo wrote: On Mon, Aug 10, 2015 at 11:33:04AM -0700, Greg KH wrote: On Mon, Aug 10, 2015 at 12:31:19PM -0400, Gabriel L. Somlo wrote: From: Gabriel Somlo so...@cmu.edu Signed-off-by: Gabriel Somlo so...@cmu.edu --- lib

Re: Safety in Kernel Development

2015-08-18 Thread Greg KH
On Tue, Aug 18, 2015 at 09:58:15PM +0800, 慕冬亮 wrote: Since I knew that Linux kernel didn't accept the pax/grsecurity It was never submitted for acceptance, so how could we merge it? greg k-h ___ Kernelnewbies mailing list

Re: Kernel development using linux containers (LXC ) ?

2015-07-29 Thread Greg KH
On Wed, Jul 29, 2015 at 01:23:18PM -0700, Manish Katiyar wrote: On Wed, Jul 29, 2015 at 1:07 PM, Jeff Haran jeff.ha...@citrix.com wrote: -Original Message- From: kernelnewbies-boun...@kernelnewbies.org [mailto:kernelnewbies- boun...@kernelnewbies.org] On Behalf Of Manish Katiyar Sent:

Re: [PATCH 2/2] drivers: staging : media : davinci_vpfe : dma365_resizer.c drivers: staging : media : davinci_vpfe : dma365_resizer.h

2015-08-09 Thread Greg KH
On Sun, Jul 26, 2015 at 11:03:28AM +0530, Bharadwaaj wrote: From: bhaaradw...@gmail.com bhaaradw...@gmail.com That's not your name, that you use down below: Fixed some spelling mistake. Signed-off-by: Bharadwaaj Ramakrishnanbhaaradw...@gmail.com That's your name. Put that in the from:

Re: [PATCH] drivers: staging: lustre: lnet: klnds: o2iblnd: o2iblnd.c

2015-08-09 Thread Greg KH
On Sun, Jul 26, 2015 at 10:59:17AM +0530, Bharadwaaj wrote: From: bhaaradw...@gmail.com bhaaradw...@gmail.com Fixed spelling mistake. Signed-off-by: Bharadwaaj Ramakrishnan bhaaradw...@gmail.com --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c | 4 ++-- 1 file changed, 2

Re: [PATCH] drivers: staging: lustre: lnet: klnds: o2iblnd: o2iblnd.c

2015-07-26 Thread Greg KH
On Sun, Jul 26, 2015 at 10:59:17AM +0530, Bharadwaaj wrote: From: bhaaradw...@gmail.com bhaaradw...@gmail.com Again, this has to match. Your subject alsh needs to say what you are doing, not just what file you are modifying. ___ Kernelnewbies

Re: Please do not generate patches purely based on checkpatch.

2015-07-26 Thread Greg KH
On Sun, Jul 26, 2015 at 01:05:37PM +0530, Yogesh Chaudhari wrote: On 26 July 2015 at 03:42, Greg KH g...@kroah.com wrote: No, that would be two different things. Do the bug fix first, and then the cleanup on a different patch. And even then, most maintainers will not take a cleanup

Re: [PATCH 2/2] drivers: staging : media : davinci_vpfe : dma365_resizer.c drivers: staging : media : davinci_vpfe : dma365_resizer.h

2015-07-26 Thread Greg KH
On Sun, Jul 26, 2015 at 11:03:28AM +0530, Bharadwaaj wrote: From: bhaaradw...@gmail.com bhaaradw...@gmail.com This has to match the string you use in the signed-off-by: line. Fixed some spelling mistake. Signed-off-by: Bharadwaaj Ramakrishnanbhaaradw...@gmail.com Please add a ' ' before

Re: Obfuscate code GPL 2 - The source uses kernel structs and GPL2 API

2015-07-21 Thread Greg KH
On Tue, Jul 21, 2015 at 03:49:22PM -0300, Lucas Tanure wrote: Hi,  This company released a obfuscated kernel module in GPL 2.  http://www.incentivespro.com/downloads.html So, they didn't release the code at all. This is ok ?  This against the law ?  Why are you asking developers legal

Re: Do you know the bug of EXPORT_SYMBOL()

2015-07-24 Thread Greg KH
On Fri, Jul 24, 2015 at 01:49:42PM +0800, Navy wrote: Hi To my understanding, EXPORT_SYMBOL() is used to export a symbol in kernel/modules. The the address of the all sysbols is in /proc/kallsyms. Only symbols exported by EXPORT_SYMBOL() is listed its CRC information in Module.symvers. So

Re: I dont know where to start

2015-07-24 Thread Greg KH
On Fri, Jul 24, 2015 at 09:20:48PM +0200, Ahmed Soliman wrote: hi first of all I want to thank you with your real help but currently I started to get lost I can build my own kernel write patches but cannot contribute to the linux kernel because I don't know where to start learning I am

Re: Please do not generate patches purely based on checkpatch.

2015-07-25 Thread Greg KH
On Sat, Jul 25, 2015 at 04:49:32PM -0400, greg.freem...@gmail.com wrote: On the other hand if you submit a patch that addresses a real bug, then simultaneously doing a checkpatch related patch to the same area is a very good idea. No, that would be two different things. Do the bug fix first,

Re: When to resend a patchset?

2015-07-19 Thread Greg KH
On Sat, Jul 18, 2015 at 04:11:30PM +0200, Ricardo Ribalda Delgado wrote: Hello Usually I was taking the approach of pinging a patch after 21 days of inactivity. This has worked ok in the past, but the last time I have done it I was told that the merge window was open and that nothing

Re: Query Hard Memory Addresses

2015-10-22 Thread Greg KH
On Thu, Oct 22, 2015 at 03:13:31PM -0400, Kenneth Adam Miller wrote: > So, previously it was discussed that /dev/mem could be used to mmap a specific > hardware memory into a process. Now I need to unit test some userland code > that > does exactly that, but I need to make sure that the unit test

Re: where struct pci_device_id is defined ?

2015-10-27 Thread Greg KH
On Tue, Oct 27, 2015 at 07:46:32AM +, Ramon Fried wrote: > Hi. > > I'm trying to find the definition of "struct pci_device_id" , but I only get > forward declarations. > > I tried grepping the entire tree, and nothing matches. Please try harder, I see it very easily, where exactly are you

Re: Two questions

2015-10-28 Thread Greg KH
On Wed, Oct 28, 2015 at 04:14:19PM +, Anuz Pratap Singh Tomar wrote: > > > On Wed, Oct 28, 2015 at 4:08 PM, Albino B Neto wrote: > > 2015-10-28 13:57 GMT-02:00 Anuz Pratap Singh Tomar < > chambilketha...@gmail.com>: > > 1. Is this book still relevant? > >

Re: [PATCH] 8250_pci: Prevent Exar/RTD Boards from binding.

2015-11-11 Thread Greg KH
On Wed, Nov 11, 2015 at 03:46:23PM +, Rob Groner wrote: > > > -Original Message- > > From: kernelnewbies-boun...@kernelnewbies.org [mailto:kernelnewbies- > > boun...@kernelnewbies.org] On Behalf Of Rob Groner > > Sent: Monday, October 26, 2015 8:28 AM >

Re: is there a reason "usbhid.quirks" parameter is not root writable?

2015-11-12 Thread Greg KH
On Thu, Nov 12, 2015 at 08:02:00PM -0500, valdis.kletni...@vt.edu wrote: > But to answer Robert's question: I suspect that it's mode 0444 so you can > read the current list, but changing the list after modprobe time is for > some reason problematic. Having said that, I admit I haven't looked at

Re: [PATCH] 8250_pci: Prevent Exar/RTD Boards from binding.

2015-11-11 Thread Greg KH
On Wed, Nov 11, 2015 at 11:50:33PM +0530, Sudip Mukherjee wrote: > On Wed, Nov 11, 2015 at 11:02 PM, Greg KH <g...@kroah.com> wrote: > > On Wed, Nov 11, 2015 at 03:46:23PM +, Rob Groner wrote: > > > > > > > > I know you're incredibly bu

Re: [PATCH] 8250_pci: Prevent Exar/RTD Boards from binding.

2015-11-11 Thread Greg KH
On Wed, Nov 11, 2015 at 09:49:11PM +, Rob Groner wrote: > > > We all know you are busy. If you want I can try the cleanup and send > > > it to Rob for testing. > > > > Yes please, it should just require a change to the existing 8250 driver > > code for > > this platform, it should not be a

Re: How to properly write tests for kernel functions

2015-11-04 Thread Greg KH
On Thu, Nov 05, 2015 at 12:26:01AM +0300, Maxim Pugachev wrote: > Hi all, > > I'm trying to understand is there any uniform way to write tests? For > example, lib/ folder has a bunch of tests, but all of them use various > technics: > > - pr_warn/pr_err (i.e. printk) or WARN for assertions > -

Re: How to properly write tests for kernel functions

2015-11-05 Thread Greg KH
On Thu, Nov 05, 2015 at 11:43:36AM +0300, Maxim Pugachev wrote: > >> So, I'm wondering, whether there is an example or guidelines that is > >> worth to follow. > > > > It all depends on what you want to test. There is no "general" way to > > do this as all subsystems / parts of the kernel are

Re: How to mark suspicious code?

2015-11-05 Thread Greg KH
On Fri, Nov 06, 2015 at 10:28:31AM +0700, Ivan Safonov wrote: > On 11/06/2015 08:58 AM, Greg KH wrote: > >On Fri, Nov 06, 2015 at 08:45:46AM +0700, Ivan Safonov wrote: > >>Hi all! > >> > >>How can I mark suspicious code, if I can not fix it? > >Wha

Re: How to mark suspicious code?

2015-11-05 Thread Greg KH
On Fri, Nov 06, 2015 at 08:45:46AM +0700, Ivan Safonov wrote: > Hi all! > > How can I mark suspicious code, if I can not fix it? What do you mean by "mark"? And also what do you mean by "suspicious"? And why can't you fix it? we need more details. thanks, greg k-h

Re: I have a large patch in the 2000 lines. What to do?

2015-10-16 Thread Greg KH
On Fri, Oct 16, 2015 at 06:14:01PM -0300, Julio Faracco wrote: > > What is the recommendation when I change a structure in a include file > and this change causes a lots of new changes, for example? You do the change in a way that does not cause build failures and spread the patches out over

Re: parameter of module_init() and module_exit() must not be a macro

2015-10-15 Thread Greg KH
On Thu, Oct 15, 2015 at 02:26:41PM +, Warlich, Christof wrote: > > > I'll ask, why would you ever want to pass a macro to module_init()? > > > > We don't like functions to be macros in the kernel, do you have a > > real-world need for this somewhere? If so, can you show the code? > > Yes,

Re: parameter of module_init() and module_exit() must not be a macro

2015-10-15 Thread Greg KH
On Thu, Oct 15, 2015 at 09:48:53AM +, Warlich, Christof wrote: > I'd just like to get some feedback on the following issue and if the patch > that I'm suggesting would be appropriate to be considered for upstream > submission: > > While writing a driver template, I just came across an issue

Re: parameter of module_init() and module_exit() must not be a macro

2015-10-16 Thread Greg KH
On Fri, Oct 16, 2015 at 06:40:40AM +, Warlich, Christof wrote: > > Ick, no, don't do that, you will make life much harder for everyone > > involved in the end. Just write out the code "for real", it's trivial > > to do so, and you aren't really saving anyone anytime as nothing like > > this

Re: UIO Kernel Driver with Buildroot and QEMU

2015-10-20 Thread Greg KH
On Tue, Oct 20, 2015 at 11:58:21AM -0400, Kenneth Adam Miller wrote: > So I'm building a uio kernel driver with buildroot, and I've gotten the driver > to compile, installed it and can insmod it in the final buildroot target after > booting the image with QEMU. > > I'm on linux kernel version

<    1   2   3   4   5   6   7   8   9   10   >