Re: [patch 0/3] [x86] Fix crashkernel reservation on NUMA machines

2008-06-09 Thread Vivek Goyal
On Sun, Jun 08, 2008 at 03:46:28PM +0200, Bernhard Walle wrote: This patch series fixes the crashkernel reservation on NUMA machine. The regression was discovered by Dave Anderson [EMAIL PROTECTED]. The background is that on NUMA machines, reserve_bootmem_generic() is required instead of

Re: [patch 2/3] Add flags parameter to reserve_bootmem_generic()

2008-06-09 Thread Vivek Goyal
On Mon, Jun 09, 2008 at 12:01:15AM +0200, Johannes Weiner wrote: Hi, Bernhard Walle [EMAIL PROTECTED] writes: --- a/arch/x86/mm/init_64.c +++ b/arch/x86/mm/init_64.c @@ -798,12 +798,13 @@ void free_initrd_mem(unsigned long start } #endif -void __init

Re: [PATCH] Cross compile?

2008-06-09 Thread Lombard, David N
On Wed, Jun 04, 2008 at 10:42:06AM +0800, Jeremy Kerr wrote: Hi David, (sorry about the late reply, been on holidays for the last 3 weeks..) ./configure --build=`uname -m`-linux-uclibc \ --host=`uname -m` --prefix=/home/dnl/kboot-11/root \ CC=uclibc-gcc

Re: [patch 2/3] Add flags parameter to reserve_bootmem_generic()

2008-06-09 Thread Bernhard Walle
* Vivek Goyal [2008-06-09 09:22]: Kdump first kernel always tries to reserve just physical RAM and nothing else. So I am not sure what does above code do. Try to reserve a memory which is not RAM but is in the region less than highest mapped entity and in that case return silently without any

Re: [patch 2/3] Add flags parameter to reserve_bootmem_generic()

2008-06-09 Thread Bernhard Walle
* Johannes Weiner [2008-06-09 00:01]: /* @@ -811,11 +812,11 @@ void __init reserve_bootmem_generic(unsi * firmware tables: */ if (pfn max_pfn_mapped) - return; + return -EFAULT; This seemed to

Re: [patch 2/3] Add flags parameter to reserve_bootmem_generic()

2008-06-09 Thread Bernhard Walle
* Johannes Weiner [2008-06-09 00:06]: + #else reserve_bootmem(phys, len, BOOTMEM_DEFAULT); ^^^ flags? And you ignore the return value here. Thanks for catching that. Updated patch:

Re: [patch 2/3] Add flags parameter to reserve_bootmem_generic()

2008-06-09 Thread Andi Kleen
Bernhard Walle wrote: * Vivek Goyal [2008-06-09 09:22]: Kdump first kernel always tries to reserve just physical RAM and nothing else. So I am not sure what does above code do. Try to reserve a memory which is not RAM but is in the region less than highest mapped entity and in that case

Re: [patch 2/3] Add flags parameter to reserve_bootmem_generic()

2008-06-09 Thread Amul Shah
On Mon, 2008-06-09 at 18:39 +0200, Andi Kleen wrote: Bernhard Walle wrote: * Vivek Goyal [2008-06-09 09:22]: Kdump first kernel always tries to reserve just physical RAM and nothing else. So I am not sure what does above code do. Try to reserve a memory which is not RAM but is in the

Re: [patch 2/3] Add flags parameter to reserve_bootmem_generic()

2008-06-09 Thread Bernhard Walle
* Amul Shah [EMAIL PROTECTED] [2008-06-09 15:50]: Don't remember the details. Perhaps Amul does (cc'ed) -Andi The short story is that the kexec kernel was panicking when trying to reserve the MP tables. The panic occurs because the MP tables resided in a reserved memory area

Re: [patch 2/3] Add flags parameter to reserve_bootmem_generic()

2008-06-09 Thread Vivek Goyal
On Mon, Jun 09, 2008 at 10:17:32PM +0200, Bernhard Walle wrote: * Amul Shah [EMAIL PROTECTED] [2008-06-09 15:50]: Don't remember the details. Perhaps Amul does (cc'ed) -Andi The short story is that the kexec kernel was panicking when trying to reserve the MP tables. The

Re: [patch 2/3] Add flags parameter to reserve_bootmem_generic()

2008-06-09 Thread Bernhard Walle
Hi Vivek, * Vivek Goyal [EMAIL PROTECTED] [2008-06-09 16:29]: Can you please put some more explanation comment here to explain that why it is ok to return with success, despite the fact that we never reserved any memory. Do you think that's ok? When booting the kdump kernel, the MP

Re: [patch 2/3] Add flags parameter to reserve_bootmem_generic()

2008-06-09 Thread Bernhard Walle
* Vivek Goyal [EMAIL PROTECTED] [2008-06-09 16:54]: On Mon, Jun 09, 2008 at 10:42:11PM +0200, Bernhard Walle wrote: Hi Vivek, * Vivek Goyal [EMAIL PROTECTED] [2008-06-09 16:29]: Can you please put some more explanation comment here to explain that why it is ok to return with

Re: [patch 2/3] Add flags parameter to reserve_bootmem_generic()

2008-06-09 Thread Vivek Goyal
On Mon, Jun 09, 2008 at 10:57:34PM +0200, Bernhard Walle wrote: * Vivek Goyal [EMAIL PROTECTED] [2008-06-09 16:54]: On Mon, Jun 09, 2008 at 10:42:11PM +0200, Bernhard Walle wrote: Hi Vivek, * Vivek Goyal [EMAIL PROTECTED] [2008-06-09 16:29]: Can you please put some more

Re: [patch 2/3] Add flags parameter to reserve_bootmem_generic()

2008-06-09 Thread Bernhard Walle
* Vivek Goyal [EMAIL PROTECTED] [2008-06-09 17:00]: I am really not sure. :-). In the past, Andrew picked up the patches, kept in his tree for couple of days and if something is important, he will push it out to Linus. Ok, I'm a bit confused about linux-next, and the new x86 tree from

Re: [PATCH] Implement support for mem command line parameter

2008-06-09 Thread Vivek Goyal
On Mon, Jun 09, 2008 at 11:57:29PM +0200, Bernhard Walle wrote: * Vivek Goyal [EMAIL PROTECTED] [2008-06-02 23:04]: On Tue, Jun 03, 2008 at 01:29:44AM +0200, Bernhard Walle wrote: When the kernel is booted with the mem kernel command line (see Documentation/kernel-parameters.txt of