Re: [RFC 00/18] Pkernfs: Support persistence for live update

2024-02-07 Thread Gowans, James
On Mon, 2024-02-05 at 10:10 -0700, Alex Williamson wrote: > > * Needing to drive and re-hydrate the IOMMU page tables by defining > > an IOMMU file. > > Really we should move the abstraction one level up and make the > > whole VFIO > > container persistent via a pkernfs file. That way you’d "just"

Re: [RFC 00/18] Pkernfs: Support persistence for live update

2024-02-07 Thread Gowans, James
Hi Jason, Thanks for this great feedback on the approach - it's exactly the sort of thing we were looking for. On Mon, 2024-02-05 at 13:42 -0400, Jason Gunthorpe wrote: > > On Mon, Feb 05, 2024 at 12:01:45PM +, James Gowans wrote: > > > The main aspect we’re looking for feedback/opinions

Re: [PATCH] kexec: do syscore_shutdown() in kernel_kexec

2024-01-08 Thread Gowans, James
+ akpm Hi Eric and Andrew, Just checking in on this patch. Would be keen to get the fix merged if you're okay with it, or some feedback. Also still keen for input for the driver maintainers in CC if they support or have objections to their shutdown hooks being invoked on kexec. JG On Mon,

Re: [PATCH] kexec: do syscore_shutdown() in kernel_kexec

2023-12-18 Thread Gowans, James
On Tue, 2023-12-19 at 12:22 +0800, Baoquan He wrote: > Add Andrew to CC as Andrew helps to pick kexec/kdump patches. Ah, thanks, I didn't realise that Andrew pulls in the kexec patches. > > On 12/13/23 at 08:40am, James Gowans wrote: > .. > > This has been tested by doing a kexec on x86_64

Re: [PATCH] kexec: do syscore_shutdown() in kernel_kexec

2023-12-18 Thread Gowans, James
Hi Eric, On Wed, 2023-12-13 at 10:39 -0600, Eric W. Biederman wrote: > > James Gowans writes: > > > syscore_shutdown() runs driver and module callbacks to get the system > > into a state where it can be correctly shut down. In commit > > 6f389a8f1dd2 ("PM / reboot: call syscore_shutdown()

Re: [PATCH v2 1/2] KVM: Use syscore_ops instead of reboot_notifier to hook restart/shutdown

2023-12-12 Thread Gowans, James
On Tue, 2023-12-12 at 10:50 +0200, James Gowans wrote: > > > > In any event I believe the bug with respect to kexec was introduced in > > commit 6f389a8f1dd2 ("PM / reboot: call syscore_shutdown() after > > disable_nonboot_cpus()").  That is where syscore_shutdown was removed > > from

Re: [PATCH v2 1/2] KVM: Use syscore_ops instead of reboot_notifier to hook restart/shutdown

2023-12-12 Thread Gowans, James
On Mon, 2023-12-11 at 17:50 -0600, Eric W. Biederman wrote: > "Gowans, James" writes: > > > On Mon, 2023-12-11 at 09:54 +0200, James Gowans wrote: > > > > > > > > What problem are you running into with your rebase that worked wit

Re: [PATCH v2 1/2] KVM: Use syscore_ops instead of reboot_notifier to hook restart/shutdown

2023-12-11 Thread Gowans, James
On Mon, 2023-12-11 at 09:34 -0800, Sean Christopherson wrote: > On Sat, Dec 09, 2023, James Gowans wrote: > > Thoughts on possible ways to fix this: > > a) go back to reboot notifiers > > b) get kexec to call syscore_shutdown() to invoke all of these callbacks > > c) Add a KVM-specific callback to

Re: [PATCH v2 1/2] KVM: Use syscore_ops instead of reboot_notifier to hook restart/shutdown

2023-12-11 Thread Gowans, James
On Mon, 2023-12-11 at 09:54 +0200, James Gowans wrote: > > > > What problem are you running into with your rebase that worked with > > reboot notifiers that is not working with syscore_shutdown? > > Prior to this commit [1] which changed KVM from reboot notifiers to > syscore_ops, KVM's reboot

Re: [PATCH v2 1/2] KVM: Use syscore_ops instead of reboot_notifier to hook restart/shutdown

2023-12-10 Thread Gowans, James
On Sat, 2023-12-09 at 22:53 -0600, Eric W. Biederman wrote: > > On Fri, 2023-05-12 at 16:31 -0700, Sean Christopherson wrote: > > > Use syscore_ops.shutdown to disable hardware virtualization during a > > > reboot instead of using the dedicated reboot_notifier so that KVM disables > > >

Re: [PATCH v2 1/2] KVM: Use syscore_ops instead of reboot_notifier to hook restart/shutdown

2023-12-08 Thread Gowans, James
Hi Sean, Blast from the past but I've just been bitten by this patch when rebasing across v6.4. On Fri, 2023-05-12 at 16:31 -0700, Sean Christopherson wrote: > Use syscore_ops.shutdown to disable hardware virtualization during a > reboot instead of using the dedicated reboot_notifier so that KVM

Re: [RFC v3 00/21] Preserved-over-Kexec RAM

2023-05-26 Thread Gowans, James
On Wed, 2023-04-26 at 17:08 -0700, Anthony Yznaga wrote: > Sending out this RFC in part to guage community interest. > This patchset implements preserved-over-kexec memory storage or PKRAM as a > method for saving memory pages of the currently executing kernel so that > they may be restored after