Re: [PATCH 0/5] Add LoongArch port support

2022-10-10 Thread Simon Horman
On Wed, Sep 28, 2022 at 10:28:21AM +0800, Youling Tang wrote: > This patch series to support kexec/kdump (only 64bit). > > Note: Kernel kexec/kdump support patch see link [1]: > Link [1]: > https://lore.kernel.org/loongarch/711d53ae-197f-3c55-d09d-2f40e6886...@loongson.cn/T/#t Thanks, applied

Re: [PATCH 0/5] Add LoongArch port support

2022-10-10 Thread Simon Horman
On Sun, Oct 09, 2022 at 11:22:46AM +0800, Youling Tang wrote: > Hi, Simon > > On 10/05/2022 11:19 PM, Simon Horman wrote: > > On Wed, Sep 28, 2022 at 10:28:21AM +0800, Youling Tang wrote: > > > This patch series to support kexec/kdump (only 64bit). > > > >

Re: [PATCH] ppc64: remove rma_top limit

2022-10-05 Thread Simon Horman
On Thu, Sep 29, 2022 at 12:19:30PM +0530, Sourabh Jain wrote: > Hello Simon, > > On 24/09/22 17:40, Simon Horman wrote: > > Hi Sourabh, > > > > could you address this question? > > It would be good to know before applying this patch. > Apologies for the del

Re: [PATCH 0/5] Add LoongArch port support

2022-10-05 Thread Simon Horman
On Wed, Sep 28, 2022 at 10:28:21AM +0800, Youling Tang wrote: > This patch series to support kexec/kdump (only 64bit). > > Note: Kernel kexec/kdump support patch see link [1]: > Link [1]: > https://lore.kernel.org/loongarch/711d53ae-197f-3c55-d09d-2f40e6886...@loongson.cn/T/#t Thanks, in

Re: [PATCH] ppc64: remove rma_top limit

2022-09-24 Thread Simon Horman
Hi Sourabh, could you address this question? It would be good to know before applying this patch. Thanks in advance, Simon On Tue, Sep 20, 2022 at 03:14:47PM +0800, Coiby Xu wrote: > Hi, > > I'm curious to ask which bug this patch is going to fix. I tested it > yesterday and it doesn't fix >

[ANNOUNCE] kexec-tools 2.0.25

2022-07-31 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.25. This is a feature release coinciding with the release of v5.19 of the Linux Kernel. This release can be downloaded from kernel.org: http://kernel.org/pub/linux/utils/kernel/kexec/kexec-tools-2.0.25.tar.xz

[ANNOUNCE] kexec-tools 2.0.25-rc1

2022-07-19 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.25-rc1. This is an incremental feature pre-release. So long as no serious problems arise I intend to release kexec-tools 2.0.25 in a weeks time. Testing of 2.0.25-rc1 would be greatly appreciated. I do not have any outstanding

Re: [PATCH] kexec-tools: Remove duplicate ultoa() definitions and redefine it

2022-07-19 Thread Simon Horman
On Fri, Jul 15, 2022 at 06:05:14PM +0800, Tiezhu Yang wrote: > There exist duplicate ultoa() definitions in many archs, remove them, > and also redefine ultoa() in kexec/kexec.h to make it more readable. > > Signed-off-by: Tiezhu Yang Thanks, this is very much appreciated. Applied.

Re: [PATCH kexec-tools] i386: pass rng seed via setup_data

2022-07-15 Thread Simon Horman
On Mon, Jul 11, 2022 at 05:41:10PM +0200, Jason A. Donenfeld wrote: > Linux ≥5.20 expects a RNG seed via setup_data as of the upstream commit > in the link below. That commit adjusts kexec_file_load to pass > SETUP_RNG_SEED. kexec-tools should follow suite, so add more or less the > same code

[ANNOUNCE] kexec-tools v2.0.25 preparation

2022-07-14 Thread Simon Horman
Hi all, I am planning to release kexec-tools v2.0.25 in the next two weeks to roughly coincide with the release of the v5.19 kernel. I would like to ask interested parties to send any patches they would like included in v2.0.25 within one week so they can be considered for inclusion in an rc

Re: [PATCH v6] kexec-tools: mips: Pass initrd parameter via cmdline

2022-06-26 Thread Simon Horman
On Sat, Jun 25, 2022 at 10:49:49AM +0800, Hui Li wrote: > Under loongson platform, use command: > kexec -l vmlinux... --append="root=UUID=28e1..." --initrd=... > kexec -e > quick restart failed like this: > > > [3.420791]

Re: [PATCH v5] kexec-tools: mips: Pass initrd parameter via cmdline

2022-06-24 Thread Simon Horman
On Fri, Jun 24, 2022 at 05:32:19PM +0800, Hui Li wrote: > Under loongson platform, use command: > kexec -l vmlinux... --append="root=UUID=28e1..." --initrd=... > kexec -e > quick restart failed like this: > > > [3.420791]

Re: [PATCH v4] kexec-tools: mips: Pass initrd parameter via cmdline

2022-06-23 Thread Simon Horman
On Fri, Jun 10, 2022 at 04:53:52PM +0800, Hui Li wrote: > Under loongson platform, use command: > kexec -l vmlinux... --append="root=UUID=28e1..." --initrd=... > kexec -e > quick restart failed like this: > > > [3.420791]

Re: [PATCH] Add method to pass initrd through cmdline

2022-05-03 Thread Simon Horman
On Tue, May 03, 2022 at 01:50:19PM +0800, Hui Li wrote: > Hi Simon Horman, > > Thanks for your review. > > On 2022/4/29 下午5:40, Simon Horman wrote: > > Hi Hui Li, > > > > thanks for your patch. > > > > On Mon, Apr 18, 2022 at 09:36:59AM +

Re: [PATCH] arm64/crashdump-arm64: increase CRASH_MAX_MEMORY_RANGES to 32k

2022-04-29 Thread Simon Horman
On Tue, Apr 26, 2022 at 08:14:15AM +0800, Baoquan He wrote: > On 04/19/22 at 05:23pm, abuehaze14 wrote: > > On ARM64 based VMs hotplugging more than 31GB of memory will cause > > kdump to fail loading as it's hitting the CRASH_MAX_MEMORY_RANGES > > limit which is currently 32 on ARM64 given that

Re: Does Kexec have plan to support riscv64?

2022-04-29 Thread Simon Horman
+ Nick Kossifidis On Tue, Apr 26, 2022 at 04:55:56PM +0800, Bo YU wrote: > Hi, > >From here: https://projects.horms.net/projects/kexec/ > I noticed the kexec does not support riscv64 arch. Are we have plan to > support riscv64 for it? Or are there others that are not suitable for this > plan? >

Re: [PATCH] Add method to pass initrd through cmdline

2022-04-29 Thread Simon Horman
Hi Hui Li, thanks for your patch. On Mon, Apr 18, 2022 at 09:36:59AM +0800, Hui Li wrote: > Problem description: > Under loongson platform,use command: > kexec -l vmlinux... --append="root=UUID=28e1..." --initrd=... > kexec -e > quick restart failed. > > The reason of this problem: > The kernel

[ANNOUNCE] kexec-tools 2.0.24

2022-04-09 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.24. This is a feature release coinciding with the release of v5.17 of the Linux Kernel. This release can be downloaded from kernel.org: http://kernel.org/pub/linux/utils/kernel/kexec/kexec-tools-2.0.24.tar.xz

[ANNOUNCE] kexec-tools 2.0.24-rc1

2022-04-01 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.24-rc1. This is an incremental feature pre-release. So long as no serious problems arise I intend to release kexec-tools 2.0.24 in a weeks time. Testing of 2.0.24-rc1 would be greatly appreciated. I do not have any outstanding

Re: [PATCH 0/2] misc improvement of code

2022-04-01 Thread Simon Horman
On Thu, Mar 31, 2022 at 01:59:32PM +0800, Pingfan Liu wrote: > > Cc: Simon Horman > To: kexec@lists.infradead.org > > Pingfan Liu (2): > arm64/crashdump-arm64: explicit type conversion to suppress compiler > warning > kexec/elf: assign one to align if

Re: [PATCH] arm64: fix static data relocations in machine_apply_elf_rel()

2022-04-01 Thread Simon Horman
On Thu, Mar 31, 2022 at 02:03:31PM +0800, Pingfan Liu wrote: > As for 'static data relocations', instead of patching an instruction (OR > ops), it should be assigned to value directly. > > Signed-off-by: Pingfan Liu > Cc: Geoff Levand > Cc: Catalin Marinas > Cc: Simo

Re: [PATCH 0/3] arm64: add support for new reloc type in kexec-arm64.c

2022-04-01 Thread Simon Horman
c: Geoff Levand > Cc: Catalin Marinas > Cc: Simon Horman > To: kexec@lists.infradead.org > > Pingfan Liu (3): > arm64/kexec-arm64: add support for R_AARCH64_LDST128_ABS_LO12_NC rela > arm64/kexec-arm64: use enum to organize the reloc type > arm64/kexec-arm64

Re: [PATCH] kexec-tools: fix leak FILE pointer.

2022-03-30 Thread Simon Horman
On Wed, Mar 30, 2022 at 07:09:51PM +0800, Lichen Liu wrote: > Close fp if file size is smaller than 13 bytes. > > Signed-off-by: Lichen Liu Thanks, applied. ___ kexec mailing list kexec@lists.infradead.org

Re: [PATCH v2] purgatory: do not enable vectorization automatically for purgatory compiling

2022-03-30 Thread Simon Horman
On Tue, Mar 29, 2022 at 06:12:28PM +0800, Baoquan He wrote: > Redhat CKI reported kdump kernel will hang a while very early after crash > triggered, then reset to firmware to reboot. > > This failure can only be observed with kdump or kexec reboot via > kexec_load system call. With

Re: [PATCH v2] kexec-tools: Determine if the image is lzma commpressed

2022-03-30 Thread Simon Horman
On Wed, Mar 30, 2022 at 01:33:26PM +0800, Lichen Liu wrote: > Currently there are 2 functions for decompressing compressed image. The > zlib_decompress_file() will determine if the image is compressed by gzip > before read, but lzma_decompress_file() will not. This can cause misleading >

Re: [ANNOUNCE] kexec-tools v2.0.24 preparation

2022-03-30 Thread Simon Horman
On Wed, Mar 30, 2022 at 11:07:01AM +0800, Dave Young wrote: > On 03/29/22 at 06:16pm, Baoquan He wrote: > > On 03/29/22 at 11:17am, Simon Horman wrote: > > > On Sat, Mar 26, 2022 at 02:55:43PM +0800, RuiRui Yang wrote: > > > > Hi Simon, > > > > >

Re: [ANNOUNCE] kexec-tools v2.0.24 preparation

2022-03-29 Thread Simon Horman
On Sat, Mar 26, 2022 at 02:55:43PM +0800, RuiRui Yang wrote: > Hi Simon, > > Recently RH CKI detected a kexec/kdump failure with kexec_load being > used, the 2nd kernel can not boot, just reset to bios/firmware > instead. > > This only happens with gcc 12.x compiled kexec-tools, add >

Re: [PATCH] kexec-tools: Determine if the image is lzma commpressed

2022-03-29 Thread Simon Horman
On Fri, Mar 25, 2022 at 03:06:15PM +0800, Lichen Liu wrote: > Currently there are 2 functions for decompressing compressed image. The > zlib_decompress_file() will determine if the image is compressed by gzip > before read, but lzma_decompress_file() will not. This can cause misleading >

Re: [PATCH] util_lib/elf_info: harden parsing of printk buffer

2022-03-24 Thread Simon Horman
On Wed, Mar 23, 2022 at 04:35:36PM +0100, Philipp Rudo wrote: > The old printk mechanism (> v3.5.0 and < v5.10.0) had a fixed size > buffer (log_buf) that contains all messages. The location for the next > message is stored in log_next_idx. In case the log_buf runs full > log_next_idx wraps around

Re: [PATCH kexec-tools] github: run apt-get update before installing packages

2022-03-24 Thread Simon Horman
On Wed, Mar 23, 2022 at 03:02:20PM +0100, Simon Horman wrote: > Refresh package database before installing dependencies to avoid failures > due to trying to install older, no longer available, versions of packages. > > Signed-off-by: Simon Horm

[ANNOUNCE] kexec-tools v2.0.24 preparation

2022-03-23 Thread Simon Horman
Hi all, I am planning to release kexec-tools v2.0.24 in the next two weeks to roughly coincide with the release of the v5.17 kernel. I would like to ask interested parties to send any patches they would like included in v2.0.24 within one week so they can be considered for inclusion in an rc

Re: [PATCH v2] kexec-xen: Allow xen_kexec_exec() to return in case of Live Update

2022-03-23 Thread Simon Horman
On Wed, Mar 23, 2022 at 02:44:18PM +, Raphael Ning wrote: > From: Raphael Ning > > Currently, my_exec() does not expect the Xen KEXEC_CMD_kexec hypercall > to return on success, because it assumes that the hypercall always > triggers an immediate reboot. However, for Live Update, the

Re: [PATCH] kexec-tools: print error if kexec_file_load fails

2022-03-23 Thread Simon Horman
On Wed, Mar 16, 2022 at 12:56:03PM +0100, Petr Tesarik wrote: > Hi Hari, > > Dne 16. 03. 22 v 11:33 Hari Bathini napsal(a): > > Commit 4f77da634035 ("kexec-tools: Fix kexec_file_load(2) error > > handling") introduced EFALLBACK for scenarios where fallbacking back > > to kexec_load syscall is

Re: [PATCH] kexec-xen: Allow xen_kexec_exec() to return in case of Live Update

2022-03-23 Thread Simon Horman
On Mon, Mar 14, 2022 at 09:21:15AM +, Raphael Ning wrote: > From: Raphael Ning > > Currently, my_exec() does not expect the Xen KEXEC_CMD_kexec hypercall > to return on success, because it assumes that the hypercall always > triggers an immediate reboot. However, for Live Update, the

[PATCH kexec-tools] github: run apt-get update before installing packages

2022-03-23 Thread Simon Horman
Refresh package database before installing dependencies to avoid failures due to trying to install older, no longer available, versions of packages. Signed-off-by: Simon Horman --- .github/workflows/build.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Workflow run - https

Re: [PATCH 0/2] kexec-tools: mips: Modify some code

2022-02-01 Thread Simon Horman
On Wed, Jan 26, 2022 at 06:20:50PM +0800, Tiezhu Yang wrote: > Tiezhu Yang (2): > kexec-tools: mips: Add some debug info > kexec-tools: mips: Concatenate --reuse-cmdline and --append > > kexec/arch/mips/kexec-mips.c | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions(-)

Re: [PATCHv4 0/4] arm64: make phys_to_virt() correct

2022-01-24 Thread Simon Horman
he same as [1-3/3] in V2. > > v1 -> v2 > Fix broken patch [2/3] in v1 > Move arch_scan_vmcoreinfo declaration to util_lib/include/elf_info.h > Using UINT64_MAX instread of 0x > > > Cc: Kairui Song > Cc: Simon Horman

Re: [PATCHv4 1/4] arm64: make phys_offset signed

2022-01-24 Thread Simon Horman
uot;arm64: mm: use single quantity to > > > represent the PA to VA translation"), phys_offset can be negative if > > > running 52-bits kernel on 48-bits hardware. > > > > > > So changing phys_offset from unsigned to signed. > > > > > > Si

Re: [PATCH v3 0/5] s390: add support for extended cmdline length

2022-01-14 Thread Simon Horman
On Thu, Dec 16, 2021 at 12:43:51PM +0100, Sven Schnelle wrote: > Hi, > > this patchset adds support for extended command line lengths on s390. > The former limit of 896 has been too short in a some configurations. The > linux kernel now provides an additional field in the parameter area > which

Re: [PATCH 1/1] s390: handle R_390_PLT32DBL reloc entries in machine_apply_elf_rel()

2022-01-14 Thread Simon Horman
On Mon, Jan 10, 2022 at 06:26:54PM +0100, Heiko Carstens wrote: > On Mon, Jan 10, 2022 at 04:23:05PM +0100, Alexander Egorenkov wrote: > > Heiko Carstens writes: > > > Given that Alexander is currently not available, I will resend his > > > patch with an updated commit message. > > > > Many

Re: [PATCH v5] arm64: support more than one crash kernel regions

2022-01-14 Thread Simon Horman
On Mon, Jan 10, 2022 at 06:20:08PM +0800, Zhen Lei wrote: > From: Chen Zhou > > When crashkernel is reserved above 4G in memory, kernel should > reserve some amount of low memory for swiotlb and some DMA buffers. > So there may be two crash kernel regions, one is below 4G, the other > is above

Re: [PATCHv2 1/1] s390: handle R_390_PLT32DBL reloc entries in machine_apply_elf_rel()

2022-01-14 Thread Simon Horman
On Wed, Dec 15, 2021 at 06:48:53PM +0100, Heiko Carstens wrote: > From: Alexander Egorenkov > > Starting with gcc 11.3, the C compiler will generate PLT-relative function > calls even if they are local and do not require it. Later on during linking, > the linker will replace all PLT-relative

Re: [PATCHv3 0/4] arm64: make phys_to_virt() correct

2022-01-14 Thread Simon Horman
Hi Pingfan, On Tue, Dec 28, 2021 at 09:26:55PM +0800, Pingfan Liu wrote: > Currently phys_to_virt() does not work well on 52-bits VA arm64 kernel. > One issue is contributed by phys_offset not signed. > The other is contributed by wrong page_offset. > > v2 -> v3: > Discussed with Kairui

Re: [PATCHv3 2/4] arm64/crashdump: unify routine to get page_offset

2022-01-14 Thread Simon Horman
52-bits VA kernel more > easily in the coming patch. > > Signed-off-by: Pingfan Liu > Cc: Kairui Song > Cc: Simon Horman > Cc: Philipp Rudo > To: kexec@lists.infradead.org > --- > kexec/arch/arm64/crashdump-arm64.c | 23 +-- > kexec/arch/arm64/kex

Re: [PATCHv3 1/4] arm64: make phys_offset signed

2022-01-14 Thread Simon Horman
phys_offset from unsigned to signed. > > Signed-off-by: Pingfan Liu > Cc: Kairui Song > Cc: Simon Horman > Cc: Philipp Rudo > To: kexec@lists.infradead.org > --- > kexec/arch/arm64/kexec-arm64.c | 8 > kexec/arch/arm64/kexec-arm64.h | 2 +- > util_lib/elf_

Re: [PATCH 3/3] arm64: read VA_BITS from kcore for 52-bits VA kernel

2021-12-16 Thread Simon Horman
On Thu, Dec 16, 2021 at 09:59:42AM +0800, Pingfan Liu wrote: > On Wed, Dec 15, 2021 at 9:06 PM signed-off...@vergenet.net:Simon > Horman wrote: > > > > On Fri, Dec 10, 2021 at 11:07:35AM +0800, Pingfan Liu wrote: > > > phys_to_virt() calculates virtual address. As a important factor, > > >

Re: [PATCH] arm64/crashdump: deduce paddr of _text based on kernel code size

2021-12-15 Thread Simon Horman
t; > And it should be a better factor to decide which label starts the > "Kernel code" in /proc/iomem. > > Signed-off-by: Pingfan Liu > Cc: Simon Horman > To: kexec@lists.infradead.org Thanks, applied. ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH 1/1] s390: handle R_390_PLT32DBL reloc entries in machine_apply_elf_rel()

2021-12-15 Thread Simon Horman
On Mon, Dec 13, 2021 at 11:44:30AM +0100, Philipp Rudo wrote: > Hi Alexander, > > @Alexander: Thanks for taking care of this. > > On Wed, 8 Dec 2021 13:53:55 +0100 > Alexander Egorenkov wrote: > > > Starting with gcc 11.3, the C compiler will generate PLT-relative function > > calls even if

[ANNOUNCE] kexec-tools 2.0.23

2021-11-04 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.22. This is a feature release coinciding with the release of v5.12 of the Linux Kernel. This release can be downloaded from kernel.org: http://kernel.org/pub/linux/utils/kernel/kexec/kexec-tools-2.0.23.tar.xz

[ANNOUNCE] kexec-tools 2.0.23-rc1

2021-10-28 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.23-rc1. This is an incremental feature pre-release. So long as no serious problems arise I intend to release kexec-tools 2.0.23 in a weeks time. Testing of 2.0.23-rc1 would be greatly appreciated. I do not have any outstanding

[ANNOUNCE] kexec-tools v2.0.23 preparation

2021-10-20 Thread Simon Horman
Hi all, I am planning to release kexec-tools v2.0.23 in the next two weeks to roughly coincide with the release of the v5.15 kernel. I would like to ask interested parties to send any patches they would like included in v2.0.23 within one week so they can be considered for inclusion in an rc

Re: [PATCH] crash_dump: fix boolreturn.cocci warning

2021-10-20 Thread Simon Horman
uld use true/false > instead of 1/0. > > Reported-by: Zeal Robot > Signed-off-by: Changcheng Deng Reviewed-by: Simon Horman ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v2] arm: kdump: Add DT properties to crash dump kernel's DTB

2021-10-20 Thread Simon Horman
On Tue, Oct 05, 2021 at 02:40:32PM +0200, Geert Uytterhoeven wrote: > Pass the following properties to the crash dump kernel, to provide a > modern DT interface between kexec and the crash dump kernel: > > - linux,elfcorehdr: ELF core header segment, similar to the > "elfcorehdr=" kernel

Re: [PATCH] kexec-tools: multiboot2: Correct BASIC_MEMINFO memory units

2021-10-20 Thread Simon Horman
On Tue, Oct 05, 2021 at 11:13:45AM +0200, dinhngoc...@irit.fr wrote: > > Thanks, > > > > I'm curious to know how the current code could have worked. > > Do we have some testing to verify this change? > > Hi, > > The current code is not actually used very often when loading Xen (which is > one

Re: [PATCH] kexec:Add some necessary fclose() calls

2021-10-05 Thread Simon Horman
On Wed, Sep 29, 2021 at 04:08:44PM +0800, Kai Song wrote: > fclose should be called before function exits > > Signed-off-by: Kai Song Thanks, applied. ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH] kexec-tools:Add some necessary free() calls

2021-10-05 Thread Simon Horman
On Wed, Sep 29, 2021 at 04:11:57PM +0800, Kai Song wrote: > free should be called before the function exit abnormally. > > Signed-off-by: Kai Song Thanks, applied. ___ kexec mailing list kexec@lists.infradead.org

Re: [PATCH] kexec-tools: multiboot2: Correct BASIC_MEMINFO memory units

2021-10-05 Thread Simon Horman
On Fri, Sep 24, 2021 at 07:03:27PM +0200, dinhngoc...@irit.fr wrote: > From: Tu Dinh > > mem_lower and mem_upper are measured in kilobytes. Thanks, I'm curious to know how the current code could have worked. Do we have some testing to verify this change? > --- >

Re: [PATCH] kexec:Fix memory leak problem in zImage_ppc64_load()

2021-09-24 Thread Simon Horman
On Fri, Sep 24, 2021 at 09:08:04AM +0800, Kai Song wrote: > When the function exits abnormally,ph should be freed. > > Signed-off-by: Kai Song > --- > kexec/arch/ppc64/kexec-zImage-ppc64.c | 7 +++ > 1 file changed, 7 insertions(+) Thanks, applied.

Re: [PATCH] kexec:Remove unused local variable in get_kernel_page_offset()

2021-09-24 Thread Simon Horman
On Thu, Sep 23, 2021 at 01:32:43PM +0800, Kai Song wrote: > In get_kernel_page_offset(),the local variable kv is unused,remove it. > > Signed-off-by: Kai Song > --- > kexec/arch/i386/crashdump-x86.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/kexec/arch/i386/crashdump-x86.c

Re: [PATCH v2 0/5] kexec-tools: multiboot2: Accept x86-64 images

2021-09-14 Thread Simon Horman
On Mon, Sep 13, 2021 at 08:51:37PM -0700, Zhaofeng Li wrote: > Hi Simon, > > Thanks for your review! In this patchset I have addressed your comments > and included an extra fix. Thanks, much appreciated. I have applied the series. ___ kexec mailing

Re: [PATCH 3/3] multiboot2: Accept x86-64 images

2021-09-13 Thread Simon Horman
On Fri, Sep 10, 2021 at 07:49:00PM -0700, Zhaofeng Li wrote: > Signed-off-by: Zhaofeng Li > --- > kexec/arch/i386/kexec-mb2-x86.c | 34 ++-- > kexec/arch/x86_64/kexec-x86_64.c | 4 ++-- > 2 files changed, 34 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH 1/3] multiboot2: Correct MBI size calculation

2021-09-13 Thread Simon Horman
On Fri, Sep 10, 2021 at 07:48:58PM -0700, Zhaofeng Li wrote: > tag_load_base_addr is dependent on rel_tag, and tag_framebuffer was > not accounted for. > > Signed-off-by: Zhaofeng Li > --- > kexec/arch/i386/kexec-mb2-x86.c | 15 +++ > 1 file changed, 11 insertions(+), 4 deletions(-)

Re: [PATCH 2/3] multiboot2: Use rel_min and rel_max for mbi destination

2021-09-13 Thread Simon Horman
On Fri, Sep 10, 2021 at 07:48:59PM -0700, Zhaofeng Li wrote: > This would segfault if mhi.rel_tag didn't exist. > > Signed-off-by: Zhaofeng Li Does the same problem exist a little further up, around line 574, also in multiboot2_x86_load() ? /* Pick the next aligned spot

Re: [PATCH] Refer FDT tokens with symbolic names

2021-09-13 Thread Simon Horman
On Sat, Sep 11, 2021 at 10:02:00PM +0530, Sourabh Jain wrote: > Replace hardcoded FDT structure block tokens with proper names to > improve code readability. > > Signed-off-by: Sourabh Jain Thanks, applied. ___ kexec mailing list

Re: [PATCHv2] arm64/crashdump-arm64: deduce the paddr of _text

2021-06-06 Thread Simon Horman
Taking the compatibility into account, it had better deduce the paddr of > _text despite of the unavailability through /proc/iomem. It can be > achieved by utilizing the fact _text aligned on 2MB. > > Signed-off-by: Pingfan Liu > Cc: Simon Horman > To: kexec@lists.infradead.org > --

Re: [PATCH] arm64/crashdump-arm64: align 'Kernel code' with '_stext'

2021-05-23 Thread Simon Horman
On Wed, May 19, 2021 at 11:16:21AM +0800, Pingfan Liu wrote: > Since kernel commit e2a073dde921 ("arm64: omit [_text, _stext) from > permanent kernel mapping"), the physical address of 'Kernel code' in > /proc/iomem is mapped from _text, instead, from _stext. > > Change the code to cope with this

Re: [PATCH] kexec-tools: Remove duplicate definition of ramdisk

2021-05-02 Thread Simon Horman
On Mon, Apr 26, 2021 at 03:29:51PM +0200, Petr Tesarik wrote: > The ramdisk variable is defined in kexec/arch/ppc/kexec-ppc.c. This > other definition is not needed and breaks build with -fno-common. > > Signed-off-by: Petr Tesarik Thanks, applied.

[ANNOUNCE] kexec-tools 2.0.22

2021-05-02 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.22. This is a feature release coinciding with the release of v5.12 of the Linux Kernel. This release can be downloaded from kernel.org: http://kernel.org/pub/linux/utils/kernel/kexec/kexec-tools-2.0.22.tar.xz

[ANNOUNCE] kexec-tools 2.0.22-rc1

2021-04-26 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.22-rc1. This is an incremental feature pre-release. So long as no serious problems arise I intend to release kexec-tools 2.0.22 in a weeks time. Testing of 2.0.22-rc1 would be greatly appreciated. I do not have any outstanding

[ANNOUNCE] kexec-tools v2.0.22 preparation

2021-04-17 Thread Simon Horman
Hi all, I am planning to release kexec-tools v2.0.22 in the next two weeks to roughly coincide with the release of the v5.12 kernel. I would like to ask interested parties to send any patches they would like included in v2.0.22 within one week so they can be considered for inclusion in an rc

Re: [PATCH v2 1/1] arm: do not copy magic 4 bytes of appended DTB in zImage

2021-04-17 Thread Simon Horman
On Mon, Apr 12, 2021 at 01:18:05PM +0200, Alexander Egorenkov wrote: > If the passed zImage happens to have a DTB appended, then the magic 4 bytes > of the DTB are copied together with the kernel image. This leads to > failed kexec boots because the decompressor finds the aforementioned > DTB

Re: [CFT][PATCH] kexec: Remove the error prone kernel_version function

2021-04-17 Thread Simon Horman
On Mon, Apr 12, 2021 at 01:24:35PM -0400, Joe Korty wrote: > On Fri, Apr 09, 2021 at 11:22:51AM -0500, Eric W. Biederman wrote: > > > > During kexec there are two kernel versions at play. The version of > > the running kernel and the version of the kernel that will be booted. > > > > On powerpc

Re: [PATCH 1/1] arm: do not copy magic 4 bytes of appended DTB in zImage

2021-04-17 Thread Simon Horman
On Mon, Apr 12, 2021 at 01:27:27PM +0200, Alexander Egorenkov wrote: > Simon Horman writes: > > > On Thu, Apr 08, 2021 at 10:06:44PM +0200, Alexander Egorenkov wrote: > >> If the passed zImage happens to have a DTB appended, then the magic 4 bytes > >>

Re: [PATCH 1/1] arm: do not copy magic 4 bytes of appended DTB in zImage

2021-04-12 Thread Simon Horman
On Thu, Apr 08, 2021 at 10:06:44PM +0200, Alexander Egorenkov wrote: > If the passed zImage happens to have a DTB appended, then the magic 4 bytes > of the DTB are copied together with the kernel image. This leads to > failed kexec boots because the decompressor finds the aforementioned > DTB

Re: [PATCH kexec-tools 0/7] build enhancements and GitHub workflow

2021-04-07 Thread Simon Horman
On Fri, Apr 02, 2021 at 12:17:30PM +0200, Simon Horman wrote: > This series aimes to: > > 1. Allow creation of dist tarball without self-referential hard links > 2. Add a distckeck target > 3. Add a GitHub workflow which to performs basic build testing > > A sample ru

Re: [PATCH 0/2] Fix early boot OOM issues for some platforms

2021-04-07 Thread Simon Horman
On Tue, Apr 06, 2021 at 03:11:51PM +0100, Hongyan Xia wrote: > From: Hongyan Xia > > We have observed a couple of cases where after a successful kexec, the > crash kernel loaded in the 2nd kernel will run out of memory and > crash. We narrowed down to two issues: > > 1. when preparing the

[PATCH kexec-tools 3/7] build: uninstall kexec_test

2021-04-02 Thread Simon Horman
kexec_test is installed but not uninstalled. Correct this oversight. Signed-off-by: Simon Horman --- Makefile.in | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Makefile.in b/Makefile.in index dc7fb07..4fe1016 100644 --- a/Makefile.in +++ b/Makefile.in @@ -181,15

[PATCH kexec-tools 4/7] build: use DESTDIR in uninstall target

2021-04-02 Thread Simon Horman
For symmetry with the install target, also use DESTDIR in the uninstall target. Signed-off-by: Simon Horman --- Makefile.in | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/Makefile.in b/Makefile.in index 4fe1016..94e9fd8 100644

[PATCH kexec-tools 2/7] build: add dist make target

2021-04-02 Thread Simon Horman
This provides a familiar alias for the existing tarball target. The result is a tar.gz file. Signed-off-by: Simon Horman --- Makefile.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile.in b/Makefile.in index a9c779f..dc7fb07 100644 --- a/Makefile.in +++ b

[PATCH kexec-tools 1/7] build: create tarball without self-referential hard links

2021-04-02 Thread Simon Horman
to be distributed. This is then unpacked in the target directory which is finally packed into the distribution tarball, a file. Signed-off-by: Simon Horman --- Makefile.in | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/Makefile.in b/Makefile.in index fb01134..a9c779f 100644

[PATCH kexec-tools 0/7] build enhancements and GitHub workflow

2021-04-02 Thread Simon Horman
This series aimes to: 1. Allow creation of dist tarball without self-referential hard links 2. Add a distckeck target 3. Add a GitHub workflow which to performs basic build testing A sample run of the workflow can be seen here https://github.com/horms/kexec-tools/actions/runs/711376088 Simon

[PATCH kexec-tools 6/7] build: add distcheck target

2021-04-02 Thread Simon Horman
Add distcheck target which aims to exercise build, install and uninstall using distribution tarball. Signed-off-by: Simon Horman --- Makefile.in | 39 ++- configure.ac | 1 + 2 files changed, 39 insertions(+), 1 deletion(-) diff --git a/Makefile.in b

[PATCH kexec-tools 7/7] github: initial workflow

2021-04-02 Thread Simon Horman
Initial github workflow which builds kexec on a range of architectures. Signed-off-by: Simon Horman --- .github/workflows/build.yml | 72 + 1 file changed, 72 insertions(+) create mode 100644 .github/workflows/build.yml diff --git a/.github/workflows

[PATCH kexec-tools 5/7] build: simplify uninstall target

2021-04-02 Thread Simon Horman
This appears to have been copied from some generated code. Simplify it by rolling repetitive operations into a for loop. Signed-off-by: Simon Horman --- Makefile.in | 81 +++-- 1 file changed, 17 insertions(+), 64 deletions(-) diff --git

Re: [PATCH v1 0/3] crashdump/x86: dump dax/kmem and virito-mem added System RAM

2021-04-02 Thread Simon Horman
On Tue, Mar 30, 2021 at 10:58:28AM +0200, David Hildenbrand wrote: > On 23.03.21 11:01, David Hildenbrand wrote: > > Let's properly support dumping any kind of "System RAM" that is not on the > > top level of the kernel resource tree in /proc/iomem, processing any > > /proc/iomem entry that

Re: [PATCH] kexec-xen: Use correct image type for Live Update

2021-04-02 Thread Simon Horman
On Tue, Mar 23, 2021 at 05:59:23PM +, Raphael Ning wrote: > From: Raphael Ning > > Unlike xen_kexec_load(), xen_kexec_unload() and xen_kexec_status() > fail to distinguish between normal kexec and Xen Live Update image > types. > > Fix that by introducing a new helper function that maps

Re: [PATCH] kexec: Make --status work with normal kexec images

2021-04-02 Thread Simon Horman
On Tue, Mar 23, 2021 at 05:50:07PM +, Raphael Ning wrote: > From: Raphael Ning > > According to kexec(8) manpage, --status (-S) works with both > normal kexec (loaded by -l) and crash kernel (loaded by -p) image > types, and defaults to the latter. However, the implementation does > not

Re: [PATCH] kexec: Fix description of --status exit code

2021-04-02 Thread Simon Horman
On Tue, Mar 23, 2021 at 05:45:02PM +, Raphael Ning wrote: > From: Raphael Ning > > On both Linux and Xen, an exit code of 0 from `kexec --status` > indicates that the kexec image being queried is NOT loaded, which > is contrary to what the man page and usage() say. > > Signed-off-by:

Re: [PATCH 0/3] Miscellaneous 32-bit fixes

2021-04-02 Thread Simon Horman
On Wed, Mar 17, 2021 at 01:14:47PM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > This patch series fixes several compile warnings when building for a > 32-bit platform. All but the last one are real bugs, from a functional > point of view. > > Thanks for your comments! Thanks Geert,

Re: [PATCH 1/1] kexec-tools: fix build on pre 4.4 kernels

2021-04-02 Thread Simon Horman
On Tue, Feb 23, 2021 at 06:32:39PM +0800, Kairui Song wrote: > On 2/5/21 4:15 PM, Federico Pellegrin wrote: > > kexec build will fail on older kernels (pre 4.4) as the define > > VIDEO_CAPABILITY_64BIT_BASE was not present at that time. > > > > This patch adds it, as per

Re: [PATCH] kexec-tools: mips: Fix the increased mem parameter size

2021-04-02 Thread Simon Horman
On Wed, Mar 17, 2021 at 11:45:14AM +0800, Youling Tang wrote: > The added "mem=size@start" parameter actually corresponds to > "crashkernel=YM@XM", but 1 byte is missing when calculating > the size, so 1 byte should be added. > > For example, when using crashkernel=108M@64M (110592K@65536K): >

Re: [PATCH] MIPS: Add '--reuse-cmdline' optional parameter support

2021-04-02 Thread Simon Horman
On Wed, Feb 24, 2021 at 01:29:41PM +0800, Youling Tang wrote: > This patch adds an option "--reuse-cmdline" for people that are lazy > in typing --append="$(cat /proc/cmdline)", which will directly use the > command line of the currently running system. > > Signed-off-by: Youling Tang > --- >

Re: [PATCH] MIPS: Fix typo in comment

2021-04-02 Thread Simon Horman
On Wed, Feb 24, 2021 at 03:57:57PM +0800, Youling Tang wrote: > Fix typo in comment. > > Signed-off-by: Youling Tang > --- > kexec/arch/mips/kexec-mips.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied. ___ kexec mailing list

[ANNOUNCE] kexec-tools 2.0.21

2020-12-17 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.21. This is a feature release coinciding with the release of v5.10 of the Linux Kernel. This release can be downloaded from kernel.org: http://kernel.org/pub/linux/utils/kernel/kexec/kexec-tools-2.0.21.tar.xz

[ANNOUNCE] kexec-tools 2.0.21-rc1

2020-12-09 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.21-rc1. This is an incremental feature pre-release. So long as no serious problems arise I intend to release kexec-tools 2.0.21 in a weeks time. Testing of 2.0.21-rc1 would be greatly appreciated. I do not have any outstanding

Re: [PATCH] kexec: mips: Fix mem parameters

2020-12-09 Thread Simon Horman
On Fri, Dec 04, 2020 at 08:29:47AM +0800, Jinyang He wrote: > "mem=" is useful to indicate the memory region when capture kernel boot. > Otherwise, capture kernel will breakdown the memory of panic kernel. > Although it can be add by user, adding "mem" by software is a better way. > What's more,

Re: [PATCH v2] dt-ops: fix memory leak when new_node malloc fails

2020-12-09 Thread Simon Horman
On Tue, Dec 01, 2020 at 12:06:16PM +0800, qiuguorui1 wrote: > In function dtb_set_property, when malloc new_node fails, > we need to free new_dtb before return. > > Fixes: f56cbcf4c2766 ("kexec/dt-ops.c: Fix '/chosen' v/s 'chosen' node > being passed to fdt helper functions") > Signed-off-by:

[ANNOUNCE] kexec-tools v2.0.21 preparation

2020-11-30 Thread Simon Horman
Hi all, After somewhat of a hiatus between releases - sorry about that - I am planning to release kexec-tools v2.0.21 in the next two weeks to roughly coincide with the release of the v5.10 kernel. I would like to ask interested parties to send any patches they would like included in v2.0.21

Re: [PATCH] dt-ops: fix memory leak when new_node malloc fails

2020-11-30 Thread Simon Horman
On Mon, Nov 30, 2020 at 02:41:56PM +0800, qiuguorui1 wrote: > In function dtb_set_property, when malloc new_node fails, > we need to free new_dtb before return. > > Fixes: f56cbcf4c2766 ("kexec/dt-ops.c: Fix '/chosen' v/s 'chosen' node > being passed to fdt helper functions") > Signed-off-by:

Re: [PATCH] zlib: fix resource leak when gzdirect failed

2020-11-30 Thread Simon Horman
On Mon, Nov 30, 2020 at 02:41:25PM +0800, qiuguorui1 wrote: > In function zlib_decompress_file, when gzdirect(fp) fails, > we should gzclose fp before return. > > Fixes: d606837b56d46 ("Fix zlib/lzma decompression.") > Signed-off-by: qiuguorui1 Thanks, applied.

<    1   2   3   4   5   6   7   8   9   10   >