[ANNOUNCE] kexec-tools v2.0.18 preparation

2018-10-01 Thread Simon Horman
Hi all, I am planning to release kexec-tools v2.0.18 in the next two weeks to roughly coincide with the release of the v4.19 kernel. I would like to ask interested parties to send any patches they would like included in v2.0.18 within one week so that I can make an rc release. For reference the

Re: [PATCH] multiboot-x86: pass framebuffer information when requested

2018-09-11 Thread Simon Horman
options, purgatory will reset the framebuffer so pass > information for standard ega text mode. > > Signed-off-by: Friedemann Gerold This seems reasonable to me, but I would value a third-party review of this change. Reviewed-by: Simon Horman ___

Re: [PATCH] multiboot-x86: pass ACPI reserved memory information in memory map

2018-09-11 Thread Simon Horman
SD. > > Signed-off-by: Friedemann Gerold This seems reasonable to me, but I would value a third-party review of this change. Reviewed-by: Simon Horman > --- > diff --git a/kexec/arch/i386/kexec-multiboot-x86.c > b/kexec/arch/i386/kexec-multiboot-x86.c > index 69027e2..afa09

Re: [PATCH] multiboot-x86: support for non-elf kernels

2018-09-11 Thread Simon Horman
Hi, thanks for your patch and sorry for the delay in reviewing it. On Thu, Aug 02, 2018 at 04:04:01PM +0200, cinap_len...@felloff.net wrote: > Add support for non-elf multiboot kernels (such as Plan 9) > by handling the MULTIBOOT_AOUT_KLUDGE bit. > > When the bit is clear then we are dealing

Re: kexec: fix for "Unhandled rela relocation: R_X86_64_PLT32" error

2018-08-24 Thread Simon Horman
gt; Please feel free to add to this patch: > Tested-by and Acked-by: Bhupesh Sharma Thanks, and apologies for the delay - I was travelling. For some reason the patch did not apply cleanly so I did so by hand. The result is as follows: >From b9de21ef51a7ceab7122a707c188602eae22c4ee Mon Sep 17 00:00:

Re: multiboot non-elf and framebuffer support for kexec-tools

2018-08-02 Thread Simon Horman
Hi, On Sat, Jul 28, 2018 at 06:18:11PM +0200, cinap_len...@felloff.net wrote: > theres a patch that provides support for non-elf multiboot kernels > and passes framebuffer information to the kernel if requested in > the multiboot header. > > only rgb truecolor framebuffers are supported right

Re: [PATCH v4 0/2] Add capability to dump fdt blob for arm64 platforms

2018-07-24 Thread Simon Horman
On Tue, Jul 17, 2018 at 02:13:42AM +0530, Bhupesh Sharma wrote: > Hi Akashi, > > On 07/09/2018 12:41 PM, AKASHI Takahiro wrote: > > Bhupesh, Simon, > > > > #I'm afraid that I gonna rehash the old discussion. > > > > Looking into ppc's kexec-tools code, I found that ppc version of > > this tool

Re: kexec support for plan9 on x86

2018-07-24 Thread Simon Horman
On Sat, Jul 21, 2018 at 06:46:42PM +0200, cinap_len...@felloff.net wrote: > implemented support in kexec-tools to boot plan9 kernel last night > (see attachment). > > this is very basic support. it loads the kernel and provides it > a memory map (from info->memory_range) in its config area and

Re: [PATCH 1/2] arm64: increase command line size to 2048

2018-06-29 Thread Simon Horman
On Wed, Jun 27, 2018 at 08:49:47AM +0200, Simon Horman wrote: > On Tue, Jun 26, 2018 at 12:47:28PM -0700, Munehisa Kamata wrote: > > Otherwise, we can hit the current 512 chars limit before hitting the > > Linux kernel's one, where allows 2048 chars in arm64. > > > &

Re: [PATCH 2/2] arm64: error out if kernel command line is too long

2018-06-29 Thread Simon Horman
On Wed, Jun 27, 2018 at 08:51:25AM +0200, Simon Horman wrote: > On Tue, Jun 26, 2018 at 12:47:29PM -0700, Munehisa Kamata wrote: > > Currently, in arm64, kexec silently truncates kernel command line longer > > than COMMAND_LINE_SIZE - 1. Error out in that case as some other &g

Re: [PATCH v4 2/2] kexec-arm64: Add functionality to dump 2nd dtb

2018-06-27 Thread Simon Horman
On Thu, Jun 21, 2018 at 03:54:38PM +0530, Bhupesh Sharma wrote: > Since during the arm64 kexec_load()/kdump invocation, > the dtb is passed to the second kernel, it is sometimes useful > to dump the dtb contents (to verify the correctness > of the same). > > This patch adds this feature which is

Re: [PATCH v4 1/2] dt-ops: Add helper API to dump fdt blob

2018-06-27 Thread Simon Horman
On Thu, Jun 21, 2018 at 03:54:37PM +0530, Bhupesh Sharma wrote: > At several occasions it would be useful to dump the fdt > blob being passed to the second (kexec/kdump) kernel > when '-d' flag is specified while invoking kexec/kdump. > > This allows one to look at the device-tree fields that >

Re: [PATCH 2/2] arm64: error out if kernel command line is too long

2018-06-27 Thread Simon Horman
> Suggested-by: Tom Kirchner > Signed-off-by: Munehisa Kamata > --- > kexec/arch/arm64/kexec-arm64.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) Hi, This looks fine to me but I will wait to see if there are other reviews before applying. Reviewed-by: Sim

Re: [PATCH 1/2] arm64: increase command line size to 2048

2018-06-27 Thread Simon Horman
re are other reviews before applying. Reviewed-by: Simon Horman > --- > kexec/arch/arm64/kexec-arm64.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kexec/arch/arm64/kexec-arm64.h b/kexec/arch/arm64/kexec-arm64.h > index bf724ef..22e4b69 100644

Re: [PATCH v2] arm64: Add support to supply 'kaslr-seed' to secondary kernel

2018-06-19 Thread Simon Horman
On Mon, Jun 18, 2018 at 11:26:11AM +0530, Bhupesh Sharma wrote: > Hello Simon, > > On 05/15/2018 12:50 PM, Bhupesh Sharma wrote: > > Hello Akashi, > > > > On Thu, Apr 26, 2018 at 2:27 PM, Bhupesh Sharma wrote: > > > This patch adds the support to supply 'kaslr-seed' to secondary kernel, > > >

Re: [PATCH v2] Remove obsolete kdump tool

2018-05-29 Thread Simon Horman
On Mon, May 28, 2018 at 02:28:58PM +0530, Bhupesh Sharma wrote: > Hello Simon, > > On Fri, May 25, 2018 at 3:32 PM, Simon Horman wrote: > > On Fri, May 25, 2018 at 04:00:33PM +0800, Dave Young wrote: > >> On 05/24/18 at 01:08pm, Bhupesh Sharma wrote: > >> >

Re: [PATCH 0/2] Remove obsolete kdump tool and add missing uninstall rule

2018-05-25 Thread Simon Horman
On Wed, May 23, 2018 at 11:13:16AM +0530, Bhupesh Sharma wrote: > Hi Dave, > > Thanks for the review. > > On Mon, May 21, 2018 at 11:53 AM, Dave Young wrote: > > Hi Bhupesh, > > On 04/23/18 at 10:30am, Bhupesh Sharma wrote: > >> This patchset contains two patches: > >> > >>

Re: [PATCH] vmcore-dmesg: fix infinite loop if log buffer wraps around

2018-05-25 Thread Simon Horman
On Thu, May 24, 2018 at 10:07:17AM +0800, Baoquan He wrote: > On 05/23/18 at 01:59pm, Omar Sandoval wrote: > > From: Omar Sandoval > > > > We hit a bug where vmcore-dmesg would get stuck in a loop, and since we > > were redirecting the output to a file, it wouldn't stop until it

Re: [PATCH v2] Makefile.in: Add uninstall rule

2018-05-25 Thread Simon Horman
asier to remove installed > executables and man pages in case one needs to uninstall the same. > > Cc: Russell King <r...@arm.linux.org.uk> > Cc: Simon Horman <ho...@verge.net.au> > Cc: Dave Young <dyo...@redhat.com> > Cc: Vivek Goyal <vgo...@redhat.com> > C

Re: [PATCH v2] Remove obsolete kdump tool

2018-05-25 Thread Simon Horman
On Fri, May 25, 2018 at 04:00:33PM +0800, Dave Young wrote: > On 05/24/18 at 01:08pm, Bhupesh Sharma wrote: > > The kdump tool presently allows one to generate an ELF file containing > > the ELF header, PT_NOTE and PT_LOAD segments (which can be analyzed > > later by tools like 'readelf') of the

Re: [PATCH] kexec/s390: Add support for kexec_file_load

2018-05-22 Thread Simon Horman
On Mon, May 21, 2018 at 02:24:40PM +0800, Dave Young wrote: > On 05/16/18 at 02:27pm, Philipp Rudo wrote: > > Since kernel 4.17-rc2 s390 supports the kexec_file_load system call. Add > > the new system call to kexec-tools and provide the -s (--kexec-file-syscall) > > option for s390 to support

Re: [PATCH v2] kexec: Add --no-checks option

2018-04-19 Thread Simon Horman
On Wed, Apr 11, 2018 at 11:30:48AM -0700, Geoff Levand wrote: > Add a new option --no-checks to kexec that allows for a fast > reboot by avoiding the purgatory integrity checks. This option is > intended for use by kexec based bootloaders that load a new > image and then immediately transfer

Re: [PATCH 0/4] Fix ppc build warnings

2018-04-19 Thread Simon Horman
On Wed, Apr 11, 2018 at 05:03:11PM +, Geoff Levand wrote: > Hi Simon, > > Here are a few fixups for warnings generated when building for 32 bit powerpc > with gcc-7.2.0. Thanks, applied. ___ kexec mailing list kexec@lists.infradead.org

[ANNOUNCE] kexec-tools 2.0.17

2018-04-19 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.17. This is a feature release coinciding with the release of v4.16 of the Linux Kernel. This release can be downloaded from kernel.org: http://kernel.org/pub/linux/utils/kernel/kexec/kexec-tools-2.0.17.tar.xz

Re: [PATCH] arm64: Set -fno-PIC along with -mcmodel=large

2018-04-19 Thread Simon Horman
On Wed, Apr 18, 2018 at 12:45:59PM -0400, David Michael wrote: > On Wed, Apr 18, 2018 at 8:54 AM, Simon Horman <ho...@verge.net.au> wrote: > > On Thu, Apr 12, 2018 at 04:37:25PM -0700, Geoff Levand wrote: > >> Hi Simon, > >> > >> On 02/02/20

Re: kdump in upstream kexec-tools

2018-04-19 Thread Simon Horman
On Wed, Apr 18, 2018 at 07:28:54PM +0100, Russell King wrote: > On Wed, Apr 18, 2018 at 03:01:08PM +0200, Simon Horman wrote: > > On Tue, Apr 17, 2018 at 10:01:13AM +0100, Russell King wrote: > > > On Tue, Apr 17, 2018 at 10:20:08AM +0530, Bhupesh Sharma wrote: > > &g

Re: kdump in upstream kexec-tools

2018-04-18 Thread Simon Horman
On Tue, Apr 17, 2018 at 10:01:13AM +0100, Russell King wrote: > On Tue, Apr 17, 2018 at 10:20:08AM +0530, Bhupesh Sharma wrote: > > Hi, > > > > I was working on improving documentation/structure of the upstream > > kexec-tools and I was wondering what is the purpose of the 'kdump' > > directory

Re: [PATCH] arm64: Set -fno-PIC along with -mcmodel=large

2018-04-18 Thread Simon Horman
On Thu, Apr 12, 2018 at 04:37:25PM -0700, Geoff Levand wrote: > Hi Simon, > > On 02/02/2018 03:48 PM, Geoff Levand wrote: > > Hi, > > > > On 01/07/2018 08:26 AM, David Michael wrote: > >> As seen in GCC's gcc/config/aarch64/aarch64.c, -fPIC with large > >> code model is unsupported. This fixes

[ANNOUNCE] kexec-tools 2.0.17-rc1

2018-04-10 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.17-rc1. This is an incremental feature pre-release. So long as no serious problems arise I intend to release kexec-tools 2.0.17 in a weeks time. Testing of 2.0.17-rc1 would be greatly appreciated. I do not have any outstanding

Re: [RESEND PATCH] arm64: fix an issue with kaslr-enabled vmlinux

2018-04-10 Thread Simon Horman
On Fri, Apr 06, 2018 at 11:45:28AM +0900, AKASHI Takahiro wrote: > Normally vmlinux for arm64 is of ET_EXEC type, while if built with > CONFIG_RANDAMIZE_BASE (that is KASLR), it will be of ET_DYN type. > Meanwhile, physical address field of segments in vmlinux has actually > the same value as

Re: [PATCH] Fix a segmentation fault when trying to run "kexec -p"

2018-04-10 Thread Simon Horman
On Mon, Apr 09, 2018 at 02:14:09PM +0530, Bhupesh Sharma wrote: > On 04/05/2018 05:09 PM, Petr Tesarik wrote: > > Do not fall through to "--mem-min" when "-p" option is parsed. The > > break statement was apparently removed by mistake... > > > > Fixes: cb434cbe6f401037e448276bb12056d1fdc3dbfc > >

Re: [PATCH v6 1/5] kexec: Return -ENOSYS when kexec does not know how to call KEXEC_FILE_LOAD

2018-03-30 Thread Simon Horman
On Fri, Mar 30, 2018 at 04:00:58PM +0800, Dave Young wrote: > Hi Simon, > > On 03/30/18 at 08:29am, Simon Horman wrote: > > Hi again Dave, > > > > would you care to review v6? > > I have no more comments for v6. Overall l

[ANNOUNCE] kexec-tools v2.0.17 preparation

2018-03-30 Thread Simon Horman
Hi all, I am planning to release kexec-tools v2.0.17 in the next two weeks to roughly coincide with the release of the v4.16 kernel. I would like to ask interested parties to send any patches they would like included in v2.0.17 within one week so that I can make an rc release. For reference the

Re: [PATCH v6 1/5] kexec: Return -ENOSYS when kexec does not know how to call KEXEC_FILE_LOAD

2018-03-30 Thread Simon Horman
Hi again Dave, would you care to review v6? On Wed, Mar 28, 2018 at 03:15:14PM +0200, Michal Suchanek wrote: > When the kernel does not know a syscall number it returns -ENOSYS but > when kexec does not know a syscall number it returns -1. Return -ENOSYS > from kexec as well. > > Signed-off-by:

Re: [PATCH] powerpc: kexec_file: Fix error code when trying to load kdump kernel

2018-03-30 Thread Simon Horman
g <dyo...@redhat.com> > Signed-off-by: Thiago Jung Bauermann <bauer...@linux.vnet.ibm.com> Reviewed-by: Simon Horman <ho...@verge.net.au> ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v2] kexec/ppc64: leverage kexec_file_load support

2018-03-30 Thread Simon Horman
On Mon, Mar 26, 2018 at 02:16:34PM +0530, Hari Bathini wrote: > PPC64 kernel now supports kexec_file_load system call. Leverage it by > enabling that support here. Note that loading crash kernel with this > system call is not yet supported in the kernel and trying to load one > will fail with

Re: [PATCH v5 4/5] kexec: Add option to fall back to KEXEC_LOAD when KEXEC_FILE_LOAD is not supported

2018-03-28 Thread Simon Horman
On Wed, Mar 28, 2018 at 08:53:53AM +0800, Dave Young wrote: > On 03/27/18 at 01:01pm, Michal Suchánek wrote: > > On Tue, 27 Mar 2018 18:06:19 +0800 > > Dave Young wrote: > > > > > On 03/26/18 at 07:38pm, Michal Suchánek wrote: > > > > On Mon, 26 Mar 2018 17:12:10 +0800 > > > >

Re: [PATCH v5 1/5] kexec: Return -ENOSYS when kexec does not know how to call KEXEC_FILE_LOAD

2018-03-26 Thread Simon Horman
Hi Michal, thanks for the updated patches. Dave, are you planning to review this series? On Tue, Mar 20, 2018 at 04:56:16PM +0100, Michal Suchanek wrote: > When the kernel does not know a syscall number it returns -ENOSYS but > when kexec does not know a syscall number it returns -1. Return

Re: [PATCH] kexec/ppc64: leverage kexec_file_load support

2018-03-26 Thread Simon Horman
On Mon, Mar 19, 2018 at 03:57:11PM -0300, Thiago Jung Bauermann wrote: > > Hello Hari, > > Hari Bathini writes: > > > PPC64 kernel now supports kexec_file_load system call. Leverage it by > > enabling that support here. Note that loading crash kernel with this > >

Re: [PATCH v4 2/5] kexec: do not special-case the -s option

2018-03-16 Thread Simon Horman
On Fri, Mar 16, 2018 at 12:38:13PM +0100, Michal Suchánek wrote: > On Fri, 16 Mar 2018 12:20:25 +0100 > Simon Horman <ho...@verge.net.au> wrote: > > > On Thu, Mar 15, 2018 at 12:13:18PM +0100, Michal Suchánek wrote: > > > On Thu, 15 Mar 2018 11:38:30 +0100 > >

Re: [PATCH v4 2/5] kexec: do not special-case the -s option

2018-03-16 Thread Simon Horman
On Thu, Mar 15, 2018 at 12:13:18PM +0100, Michal Suchánek wrote: > On Thu, 15 Mar 2018 11:38:30 +0100 > Simon Horman <ho...@verge.net.au> wrote: > > > On Tue, Mar 06, 2018 at 02:15:53PM +0100, Michal Suchanek wrote: > > > It is parsed separately to save a

Re: [PATCH v4 2/5] kexec: do not special-case the -s option

2018-03-15 Thread Simon Horman
On Tue, Mar 06, 2018 at 02:15:53PM +0100, Michal Suchanek wrote: > It is parsed separately to save a few CPU cycles when setting up other > options but it just complicates the code. So fold it back and set up all > flags both for KEXEC_LOAD and KEXEC_FILE_LOAD > > Signed-off-by: Michal Suchanek

Re: [PATCH 2/5] kexec: do not special-case the -s option

2018-03-04 Thread Simon Horman
On Fri, Mar 02, 2018 at 02:38:22PM +0100, Michal Suchánek wrote: > On Fri, 2 Mar 2018 13:36:16 +0100 > Simon Horman <ho...@verge.net.au> wrote: > > > On Mon, Feb 26, 2018 at 01:00:35PM +0100, Michal Suchanek wrote: > > > It is parsed separately to save a few CPU cycl

Re: [PATCH 4/5] kexec: fallback to KEXEC_LOAD when KEXEC_FILE_LOAD is not supported.

2018-03-02 Thread Simon Horman
On Fri, Mar 02, 2018 at 01:32:52PM +0100, Michal Suchánek wrote: > On Fri, 2 Mar 2018 17:24:19 +0800 > Dave Young wrote: > > > On 02/26/18 at 01:00pm, Michal Suchanek wrote: > > > Not all architectures implement KEXEC_FILE_LOAD. However, on some > > > archiectures

Re: [PATCH 4/5] kexec: fallback to KEXEC_LOAD when KEXEC_FILE_LOAD is not supported.

2018-03-02 Thread Simon Horman
On Mon, Feb 26, 2018 at 01:00:37PM +0100, Michal Suchanek wrote: > Not all architectures implement KEXEC_FILE_LOAD. However, on some > archiectures KEXEC_FILE_LOAD is required when secure boot is enabled in > locked-down mode. Previously users had to select the KEXEC_FILE_LOAD > syscall with

Re: [PATCH 2/5] kexec: do not special-case the -s option

2018-03-02 Thread Simon Horman
On Mon, Feb 26, 2018 at 01:00:35PM +0100, Michal Suchanek wrote: > It is parsed separately to save a few CPU cycles when setting up other > options but it just complicates the code. So fold it back and set up all > flags both for KEXEC_LOAD and KEXEC_FILE_LOAD > > Signed-off-by: Michal Suchanek

Re: [PATCH 1/5] kexec: Return -ENOSYS when kexec does not know how to call KEXEC_FILE_LOAD

2018-03-02 Thread Simon Horman
On Mon, Feb 26, 2018 at 01:00:34PM +0100, Michal Suchanek wrote: > When the kernel does not know a syscall number it returns -ENOSYS but > when kexec does not know a syscall number it returns -1. Return -ENOSYS > from kexec as well. > > Signed-off-by: Michal Suchanek > --- >

Re: [PATCH 2/2] kexec/ppc64: add support to parse ibm, dynamic-memory-v2 property

2018-02-22 Thread Simon Horman
On Wed, Feb 21, 2018 at 02:40:47PM +0530, Mahesh Jagannath Salgaonkar wrote: > On 02/20/2018 07:48 PM, Hari Bathini wrote: > > Add support to parse the new 'ibm,dynamic-memory-v2' property in the > > 'ibm,dynamic-reconfiguration-memory' node. This replaces the old > > 'ibm,dynamic-memory' property

Re: [PATCH 1/2] kexec: add a helper function to add ranges

2018-02-22 Thread Simon Horman
On Wed, Feb 21, 2018 at 02:37:31PM +0530, Mahesh Jagannath Salgaonkar wrote: > On 02/20/2018 07:48 PM, Hari Bathini wrote: > > Add a helper function for adding ranges to avoid duplicating code. > > > > Signed-off-by: Hari Bathini > > Reviewed-by: Mahesh Salgaonkar

Re: [PATCH V2] print kdump kernel loaded status in stack dump

2018-01-31 Thread Simon Horman
Dave Young <dyo...@redhat.com> Reviewed-by: Simon Horman <horms+rene...@verge.net.au> ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH kexec-tools] x86: use old screen_info if needed

2018-01-29 Thread Simon Horman
On Mon, Jan 29, 2018 at 03:59:54PM +0800, Dave Young wrote: > On 01/29/18 at 08:21am, Simon Horman wrote: > > On Sun, Jan 28, 2018 at 01:52:31PM +0800, Dave Young wrote: > > > With modern drm/kms graphic driver kexec-tools does not setup screen_info > > > correctly

[PATCH] x86: constify fsname parameter of find_mnt_by_fsname()

2018-01-28 Thread Simon Horman
_fsname(char *fsname) ... Signed-off-by: Simon Horman <ho...@verge.net.au> --- kexec/arch/i386/x86-linux-setup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kexec/arch/i386/x86-linux-setup.c b/kexec/arch/i386/x86-linux-setup.c index 2152a2191743..181d7dba2c23 100644 --- a

Re: [PATCH kexec-tools] x86: use old screen_info if needed

2018-01-28 Thread Simon Horman
On Sun, Jan 28, 2018 at 01:52:31PM +0800, Dave Young wrote: > With modern drm/kms graphic driver kexec-tools does not setup screen_info > correctly so one will only see screen output after those drm drivers > reinitializing after rebooting. Copying the old screen info from original > boot_params

Re: [PATCH v4] kexec-tools: Make xc_dlhandle static

2018-01-25 Thread Simon Horman
On Wed, Jan 24, 2018 at 08:26:32PM +0100, Daniel Kiper wrote: > On Wed, Jan 24, 2018 at 01:20:21PM -0600, Eric DeVolder wrote: > > This patch is a follow-on to commit 894bea93 "kexec-tools: Perform > > run-time linking of libxenctrl.so". This patch addresses feedback > > from Daniel Kiper. > > > >

Re: [PATCH v4] kexec-tools: Perform run-time linking of libxenctrl.so

2018-01-24 Thread Simon Horman
On Tue, Jan 23, 2018 at 12:02:34PM -0600, Eric DeVolder wrote: > Simon, > Thank you! I've a request below. Understood. As a rule I think its better not to update the git commits. But I think the risk of fallout is low here so I've updated the changelog as best I can. Please take a look at the

Re: [PATCH v2 2/2] kexec-tools: Make xc_dlhandle static

2018-01-24 Thread Simon Horman
On Tue, Jan 23, 2018 at 09:59:14PM +0100, Daniel Kiper wrote: > On Tue, Jan 23, 2018 at 01:12:51PM -0600, Eric DeVolder wrote: > > This patch is a follow-on to commit 43d3932e "kexec-tools: Perform > > run-time linking of libxenctrl.so". This patch addresses feedback > > from Daniel Kiper. > > > >

Re: [PATCH v2 1/2] kexec-tools: Call dlclose() from within __xc_interface_close()

2018-01-24 Thread Simon Horman
On Tue, Jan 23, 2018 at 09:34:08PM +0100, Daniel Kiper wrote: > On Tue, Jan 23, 2018 at 01:12:50PM -0600, Eric DeVolder wrote: > > This patch is a follow-on to commit 43d3932e "kexec-tools: Perform > > run-time linking of libxenctrl.so". This patch addresses feedback > > from Daniel Kiper. > > > >

Re: [PATCH v4] kexec-tools: Perform run-time linking of libxenctrl.so

2018-01-17 Thread Simon Horman
On Wed, Jan 17, 2018 at 10:39:01AM -0600, Eric DeVolder wrote: > When kexec is utilized in a Xen environment, it has an explicit > run-time dependency on libxenctrl.so. This dependency occurs > during the configure stage and when building kexec-tools. ... Thanks for addressing this and thanks

[ANNOUNCE] kexec-tools 2.0.16

2017-11-20 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.16. This is a feature release coinciding with the release of v4.14 of the Linux Kernel. This release can be downloaded from kernel.org: http://kernel.org/pub/linux/utils/kernel/kexec/kexec-tools-2.0.16.tar.xz

[ANNOUNCE] kexec-tools 2.0.16-rc1

2017-11-08 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.16-rc1. This is an incremental feature pre-release. So long as no serious problems arise I intend to release kexec-tools 2.0.16 in a weeks time. Testing of 2.0.16-rc1 would be greatly appreciated. I do not have any outstanding

Re: [Patch resend] vmcore-dmesg: avoid allocating large memory chunk for log buf

2017-11-08 Thread Simon Horman
al. > > We can avoid allocating such a large memory chunk, instead just allocate > a smaller chunk inside the loop each time. > > Verify the result by comparing the vmcore-dmesg output with and without > this patch. > > Cc: Simon Horman <ho...@verge.net.au> >

Re: [PATCH 2/2] ARM: read kernel size from zImage

2017-11-01 Thread Simon Horman
On Mon, Oct 23, 2017 at 11:08:34AM +0100, Russell King wrote: > Read the new extension data which tells the boot agent about the > requirements for booting the kernel image, such as how much RAM > will be consumed by the kernel through decompression and booting. > This is necessary to control the

Re: [PATCH 1/2] ARM: cleanup initrd and dtb handing

2017-11-01 Thread Simon Horman
On Mon, Oct 23, 2017 at 11:05:48AM +0100, Russell King wrote: > There is no difference in the way the initrd is handled between an > ATAG-based kernel and a DTB-based kernel. Therefore, this should be > handled identically in both cases. > > Rearrange the code to achieve this. > >

[ANNOUNCE] kexec-tools v2.0.16 preparation

2017-11-01 Thread Simon Horman
Hi all, I am planning to release kexec-tools v2.0.16 in the next two weeks. The normal cadence would have seen it released around the time of the v4.13 kernel. I apologise that once again things have slipped and the plan is no to release around the time of the v4.14 kernel. I would like to ask

Re: [PATCH 3/4] kexec-tools: mips: Use proper page_offset for OCTEON CPUs.

2017-10-17 Thread Simon Horman
On Mon, Oct 16, 2017 at 09:05:22AM -0700, David Daney wrote: > On 10/15/2017 11:56 PM, Simon Horman wrote: > > On Thu, Oct 12, 2017 at 02:02:27PM -0700, David Daney wrote: > > > The OCTEON family of MIPS64 CPUs uses a PAGE_OFFSET of > > > 0x8000ULL, which

Re: [PATCH 1/4] kexec-tools: mips: Merge adjacent memory ranges.

2017-10-17 Thread Simon Horman
On Mon, Oct 16, 2017 at 09:13:30AM -0700, David Daney wrote: > On 10/15/2017 11:53 PM, Simon Horman wrote: > > On Thu, Oct 12, 2017 at 02:02:25PM -0700, David Daney wrote: > > > Some kernel versions running on MIPS split the System RAM memory > > > regions reported in /

Re: [PATCH 4/4] kexec-tools: mips: Try to include bss in kernel vmcore file.

2017-10-16 Thread Simon Horman
On Thu, Oct 12, 2017 at 02:02:28PM -0700, David Daney wrote: > The kernel message buffers, as well as a lot of other useful data > reside in the bss section. Without this vmcore-dmesg cannot work, and > debugging with a core dump is much more difficult. > > Try to add the /proc/iomem "Kernel

Re: [PATCH 2/4] kexec-tools: mips: Don't set lowmem_limit to 2G for 64-bit systems.

2017-10-16 Thread Simon Horman
On Thu, Oct 12, 2017 at 02:02:26PM -0700, David Daney wrote: > The 64-bit MIPS architecture doesn't have the same 2G limit the 32-bit > version has. Set MAXMEM and lowmem_limit to 0 for 64-bit MIPS so that > memory above 2G is usable in the kdump core files. > > Signed-off-by: David Daney

Re: [PATCH 1/4] kexec-tools: mips: Merge adjacent memory ranges.

2017-10-16 Thread Simon Horman
On Thu, Oct 12, 2017 at 02:02:25PM -0700, David Daney wrote: > Some kernel versions running on MIPS split the System RAM memory > regions reported in /proc/iomem. This may cause loading of the kexec > kernel to fail if it crosses one of the splits. > > Fix by merging adjacent memory ranges that

Re: [PATCH 3/4] kexec-tools: mips: Use proper page_offset for OCTEON CPUs.

2017-10-16 Thread Simon Horman
On Thu, Oct 12, 2017 at 02:02:27PM -0700, David Daney wrote: > The OCTEON family of MIPS64 CPUs uses a PAGE_OFFSET of > 0x8000ULL, which is differs from other CPUs. > > Scan /proc/cpuinfo to see if the current system is "Octeon", if so, > patch the page_offset so that usable kdump

Re: [PATCH] kexec-tools: ppc64: fix leak while checking for coherent device memory

2017-08-30 Thread Simon Horman
On Tue, Aug 29, 2017 at 11:08:02PM +0530, Hari Bathini wrote: > Signed-off-by: Hari Bathini Thanks, applied. ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH] kexec-tools: ppc64: avoid adding coherent memory regions to crash memory ranges

2017-08-28 Thread Simon Horman
On Sun, Aug 27, 2017 at 11:12:37PM -0400, Pingfan Liu wrote: > > > > > - Original Message - > > From: "Hari Bathini" <hbath...@linux.vnet.ibm.com> > > To: "Simon Horman" <ho...@verge.net.au>, "Kexec-ml" > >

Re: [PATCH] kexec-tools: powerpc: fix command line overflow error

2017-08-10 Thread Simon Horman
On Wed, Aug 09, 2017 at 11:47:42PM +0530, Hari Bathini wrote: > Since kernel commit a5980d064fe2 ("powerpc: Bump COMMAND_LINE_SIZE > to 2048"), powerpc bumped command line size to 2048 but the size > used here is still the default value of 512. Bump it to 2048 to > fix command line overflow errors

Re: [PATCH] kexec-tools: ppc64: fix how RMA top is deduced

2017-08-04 Thread Simon Horman
On Wed, Jul 26, 2017 at 10:49:41PM +0530, Hari Bathini wrote: > Hang was observed, in purgatory, on a machine configured with > single LPAR. This was because one of the segments was loaded > outside the actual Real Memory Area (RMA) due to wrongly > deduced RMA top value. > > Currently, top of

[ANNOUNCE] kexec-tools 2.0.15

2017-06-16 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.15. This is a feature release. It would have coincided with the release of the v4.11 Linux Kernel, however, due to an oversight on my part is is rather late. This release can be downloaded from kernel.org:

[ANNOUNCE] kexec-tools 2.0.15-rc1

2017-06-09 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.15-rc1. This is an incremental feature pre-release. So long as no serious problems arise I intend to release kexec-tools 2.0.15 in a weeks time. Testing of 2.0.15-rc1 would be greatly appreciated. I do not have any outstanding

Re: [PATCH v7 01/10] kexec: exntend the semantics of kexec_iomem_for_each_line

2017-05-22 Thread Simon Horman
On Mon, May 22, 2017 at 09:18:07AM +0900, AKASHI Takahiro wrote: > On Wed, May 17, 2017 at 04:37:04PM -0700, David Woodhouse wrote: > > On Wed, 2017-05-17 at 14:51 +0900, AKASHI Takahiro wrote: > > > The current kexec_iomem_for_each_line() counts up all the lines for which > > > a callback

Re: [PATCH] memmap: Parse "Reserved" together with "reserved"

2017-04-26 Thread Simon Horman
On Wed, Apr 26, 2017 at 03:31:48PM +0800, Dave Young wrote: > On 04/26/17 at 03:28pm, Dave Young wrote: > > On 04/26/17 at 08:22am, Ingo Molnar wrote: > > > > > > * Yinghai Lu wrote: > > > > > > > For x86 with recent kernel after > > > > commit 640e1b38b0 ("x86/boot/e820:

Re: [PATCH 2/2] arm64: Fix power-of-ten vs. power-of-two prefixes in comments etc.

2017-04-16 Thread Simon Horman
[Cc linux-renesas-soc] On Thu, Apr 13, 2017 at 01:18:58PM +0100, David Woodhouse wrote: > Less important than in user-visible messages, but still good practice as > there's still no excuse for ARM64 code to look like it was written before > 1996. > > Signed-off-by: David Woodhouse

Re: [PATCH v0] Fix broken Xen support in configure.ac

2017-04-08 Thread Simon Horman
On Fri, Apr 07, 2017 at 09:57:44PM +0200, Daniel Kiper wrote: > On Fri, Apr 07, 2017 at 09:13:06AM -0500, Eric DeVolder wrote: > > Commit 2cf7cb9a "kexec: implemented XEN KEXEC STATUS to determine > > if an image is loaded" added configure-time detection of the > > kexec_status() call, but in

Re: [PATCH] x86: Support large number of memory ranges

2017-03-24 Thread Simon Horman
On Thu, Mar 23, 2017 at 01:27:08PM +, Ramsay, Frank wrote: > > From: Xunlei Pang > Sent: Thursday, March 23, 2017 7:16:59 AM > To: kexec@lists.infradead.org > Cc: Dave Young; Xunlei Pang; Ramsay, Frank > Subject: [PATCH] x86: Support

Re: [PATCH] crashdump: Remove stray get_crashkernel_region() declaration

2017-03-20 Thread Simon Horman
On Thu, Mar 16, 2017 at 11:12:24AM +0100, Daniel Kiper wrote: > Signed-off-by: Daniel Kiper Thanks, applied. ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH][kexec-tools] ppc: Fix format warning with die()

2017-03-20 Thread Simon Horman
On Thu, Mar 16, 2017 at 04:11:18PM +0200, Jussi Kukkonen wrote: > Enable compiling kexec-tools for ppc with -Werror=format-security. > > Signed-off-by: Jussi Kukkonen Thanks, applied. ___ kexec mailing list

Re: [PATCH] x86/x86_64: Fix format warning with die()

2017-03-14 Thread Simon Horman
On Tue, Mar 14, 2017 at 05:59:22PM +0530, Pratyush Anand wrote: > Fedora koji uses gcc version 7.0.1-0.12.fc27, and it generates a build > warning > >kexec/arch/i386/kexec-elf-x86.c:299:3: error: format not a string >literal and no format arguments [-Werror=format-security] >

Re: [PATCH v2 1/1] Don't use %L width specifier with integer values

2017-03-14 Thread Simon Horman
On Mon, Mar 13, 2017 at 09:35:02AM -0600, Philip Prindeville wrote: > > > On Mar 13, 2017, at 2:54 AM, Simon Horman <ho...@verge.net.au> wrote: > > > > On Fri, Mar 10, 2017 at 08:12:15PM -0700, Philip Prindeville wrote: > >> From: Philip Prinde

Re: [PATCH] vmcore-dmesg: Define _GNU_SOURCE

2017-03-13 Thread Simon Horman
On Fri, Mar 10, 2017 at 10:38:35AM +0100, David Woodhouse wrote: > On Fri, 2017-03-10 at 10:12 +0100, Simon Horman wrote: > > > > For some reason it did not hit my inbox :( > > > > Shall I pick up the version you reposted as PATCH 7/7 ? > > That works. There's

Re: [PATCH 1/7] uImage: fix realloc() pointer confusion

2017-03-13 Thread Simon Horman
On Wed, Mar 08, 2017 at 10:41:08PM +, David Woodhouse wrote: > From: David Woodhouse Thanks, series applied. ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH] build_mem_phdrs(): check if p_paddr is invalid

2017-03-13 Thread Simon Horman
On Mon, Mar 13, 2017 at 02:45:29PM +0800, Dave Young wrote: > On 03/07/17 at 06:53am, Pratyush Anand wrote: > > Hi Simon, > > > > On Wednesday 01 March 2017 12:43 PM, Dave Young wrote: > > > On 03/01/17 at 11:19am, Pratyush Anand wrote: > > > > Currently, all the p_paddr of PT_LOAD headers are

Re: [PATCH v2 1/1] Don't use %L width specifier with integer values

2017-03-13 Thread Simon Horman
On Fri, Mar 10, 2017 at 08:12:15PM -0700, Philip Prindeville wrote: > From: Philip Prindeville > > MUSL doesn't support %L except for floating-point arguments; therefore, > %ll must be used instead with integer arguments. I apologise for my ignorance; what is

Re: [PATCH v3] Only print debug message when failed to serach for kernel symbol from /proc/kallsyms

2017-03-10 Thread Simon Horman
On Thu, Mar 09, 2017 at 03:29:45PM +0800, Baoquan He wrote: > On 03/08/17 at 09:13pm, Philip Prindeville wrote: > > Inline… > > > > > > > On Mar 5, 2017, at 6:46 PM, Dave Young wrote: > > > > > > On 03/03/17 at 11:52am, Baoquan He wrote: > > >> Kernel symbol page_offset_base

Re: [PATCH] vmcore-dmesg: Define _GNU_SOURCE

2017-03-10 Thread Simon Horman
On Wed, Mar 08, 2017 at 08:44:40PM +0100, David Woodhouse wrote: > On Sat, 2016-01-09 at 17:21 -0800, Khem Raj wrote: > > loff_t is guarded with _GNU_SOURCE on some C library implementations > > e.g. musl since this type is not defined by POSIX. Define _GNU_SOURCE to > > include this define, it

Re: [PATCH] gitignore: add two generated files in purgatory

2017-03-06 Thread Simon Horman
On Mon, Feb 13, 2017 at 11:46:18PM +0100, Daniel Kiper wrote: > On Fri, Feb 10, 2017 at 04:20:05PM -0600, Eric DeVolder wrote: > > This patch adds the two generated files below to .gitignore. > > Next time please add why it is needed. One sentence explanation is sufficient. > > >

Re: [PATCH v5 00/11] kexec: Add option to get crash kernel region size

2017-03-02 Thread Simon Horman
On Fri, Feb 17, 2017 at 04:47:14PM -0600, Eric DeVolder wrote: > This is the fifth version of a patch series originally posted by > Daniel Kiper on December 5. Thanks, applied. ___ kexec mailing list kexec@lists.infradead.org

Re: [PATCH 0/2] Simple cleanups

2017-01-31 Thread Simon Horman
On Mon, Jan 30, 2017 at 12:14:23PM -0600, Eric DeVolder wrote: > Trivial cleanups > > No functional changes Thanks, applied. ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v4] kexec: implemented XEN KEXEC STATUS to determine if an image is loaded

2017-01-26 Thread Simon Horman
On Thu, Jan 26, 2017 at 12:02:48AM +0100, Daniel Kiper wrote: > On Wed, Jan 25, 2017 at 09:31:15AM -0600, Eric DeVolder wrote: > > [...] > > > diff --git a/kexec/kexec.c b/kexec/kexec.c > > index 500e5a9..ec16247 100644 > > --- a/kexec/kexec.c > > +++ b/kexec/kexec.c > > @@ -51,6 +51,9 @@ > >

Re: [PATCH v3] kexec: Increase the upper limit for RAM segments

2017-01-24 Thread Simon Horman
On Wed, Jan 18, 2017 at 04:15:12PM -0700, Sameer Goel wrote: > On a newer UEFI based Qualcomm target the number of system ram regions > retrieved from /proc/iomem are ~40. So increasing the current hardcoded > values to 64 from 16. > > Signed-off-by: Sameer Goel Thanks,

Re: [PATCH] alpha: add missing __NR_kexec_load definition

2017-01-24 Thread Simon Horman
On Tue, Dec 20, 2016 at 09:29:18AM +0100, Simon Horman wrote: > Signed-off-by: Simon Horman <ho...@verge.net.au> > --- > kexec/kexec-syscall.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/kexec/kexec-syscall.h b/kexec/kexec-syscall.h > index c0d0be

Re: [PATCH v2] kexec: implemented XEN KEXEC STATUS to determine if an image is loaded

2017-01-24 Thread Simon Horman
On Fri, Jan 20, 2017 at 11:03:54AM -0600, Eric DeVolder wrote: > Instead of the scripts having to poke at various fields we can > provide that functionality via the -S parameter. > > Returns 0 if the payload is loaded. Can be used in combination > with -l or -p to get the state of the proper

Re: [PATCH] ppc64: Reduce number of ELF LOAD segments

2017-01-24 Thread Simon Horman
On Thu, Jan 19, 2017 at 06:37:09PM +0100, Petr Tesarik wrote: > The number of program header table entries (e_phnum) is an Elf64_Half, > which is a 16-bit entity, i.e. the limit is 65534 entries (one entry is > reserved for NOTE). This is a hard limit, defined by the ELF standard. > It is possible

[PATCH] alpha: add missing __NR_kexec_load definition

2016-12-20 Thread Simon Horman
Signed-off-by: Simon Horman <ho...@verge.net.au> --- kexec/kexec-syscall.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kexec/kexec-syscall.h b/kexec/kexec-syscall.h index c0d0beadf932..3b5c528d8aac 100644 --- a/kexec/kexec-syscall.h +++ b/kexec/kexec-syscall.h @@ -48,6 +48,9 @@

<    1   2   3   4   5   6   7   8   9   10   >