[ANNOUNCE] kexec-tools 2.0.14

2016-12-20 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.14. This is a feature release coinciding with the release of the v4.9 Linux Kernel. This release can be downloaded from kernel.org: http://kernel.org/pub/linux/utils/kernel/kexec/kexec-tools-2.0.14.tar.xz

[ANNOUNCE] kexec-tools 2.0.14-rc1

2016-12-12 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.14-rc1. This is an incremental feature pre-release. So long as no serious problems arise I intend to release kexec-tools 2.0.14 in a weeks time. Testing of 2.0.14-rc1 would be greatly appreciated. I do not have any outstanding

Re: [PATCH v2 kexec-tools] arm: do not build iomem.o target with no soruce

2016-12-12 Thread Simon Horman
On Fri, Dec 09, 2016 at 05:45:55PM +0530, Pratyush Anand wrote: > > > On Friday 09 December 2016 04:30 PM, Simon Horman wrote: > >Header files should be added to the distribution but not > >used to derive targets for compilation. In this an attempt was > >made to buil

[PATCH v2 kexec-tools] arm: do not build iomem.o target with no soruce

2016-12-09 Thread Simon Horman
Young <dyo...@redhat.com> Cc: Pratyush Anand <pan...@redhat.com> Signed-off-by: Simon Horman <ho...@verge.net.au> --- v2 * add headers directly to dist --- kexec/arch/arm/Makefile | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/kexec/arch/arm/Makefile b/kexec/arch/arm

Re: [PATCH kexec-tools] arm: do not build iomem.o target with no soruce

2016-12-09 Thread Simon Horman
On Fri, Dec 09, 2016 at 03:58:21PM +0530, Pratyush Anand wrote: > > > On Friday 09 December 2016 02:42 PM, Simon Horman wrote: > >Header files should be added to the distribution but not > >used to derive targets for compilation. In this an attempt was > >made to buil

Re: [PATCH kexec-tools] ia64: ehdr is not UNUSED in machine_apply_elf_rel

2016-12-09 Thread Simon Horman
On Fri, Dec 09, 2016 at 04:02:22PM +0530, Pratyush Anand wrote: > > > On Friday 09 December 2016 02:19 PM, Simon Horman wrote: > >The ehdr parameter of machine_apply_elf_rel() is used. > >This resolves a build regression. > > > >Cc: Anton Blanchard <an.

[PATCH kexec-tools] arm: do not build iomem.o target with no soruce

2016-12-09 Thread Simon Horman
Young <dyo...@redhat.com> Signed-off-by: Simon Horman <ho...@verge.net.au> --- kexec/arch/arm/Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kexec/arch/arm/Makefile b/kexec/arch/arm/Makefile index 871979e0ae26..a1b730034de8 100644 --- a/kexec/arch/arm/Makefil

[PATCH kexec-tools] ia64: ehdr is not UNUSED in machine_apply_elf_rel

2016-12-09 Thread Simon Horman
The ehdr parameter of machine_apply_elf_rel() is used. This resolves a build regression. Cc: Anton Blanchard <an...@samba.org> Cc: Dave Young <dyo...@redhat.com> Fixes: 4a2ae3a39c64 ("Pass struct mem_sym into machine_apply_elf_rel()") Signed-off-by: Simon Horman <ho...

Re: [PATCH] arm64: Fix initrd requierements

2016-12-09 Thread Simon Horman
On Wed, Dec 07, 2016 at 05:26:15PM +0100, Matthias Brugger wrote: > The initrd doesn't need to be aligend to 1 GB, which breaks kexec for system > with > RAM <= 1 GB. Instead the memory size between the kernel start rounded down to > 1 GB > and the end of the initrd rounded up to 1 GB can't be

Re: [PATCH 0/6] Kexec fixes and updates for MIPS platforms

2016-12-09 Thread Simon Horman
On Fri, Dec 02, 2016 at 10:49:05AM +0100, Marcin Nowakowski wrote: > This patch series tries to bring the support for MIPS up to date and make it > more > generic (fix little-endian support, simplify code for 32/64 bit handling), as > well > as to clean up some existing incorrect code (patches

Re: [PATCH] kexec-tools/x86: get_kernel_vaddr_and_size off-by-one fix

2016-12-08 Thread Simon Horman
On Thu, Dec 08, 2016 at 10:52:22AM +0800, Dave Young wrote: > I got below error while tesing kexec -p: > "Can't find kernel text map area from kcore" > > The case is the pt_load start addr was same as stext_sym. The checking > code should really be saddr <= stext_sym so that the right pt_load

Re: [ANNOUNCE] kexec-tools v2.0.14 preparation

2016-12-07 Thread Simon Horman
On Wed, Dec 07, 2016 at 05:47:17PM +0800, Dave Young wrote: > On 12/02/16 at 09:24am, Simon Horman wrote: > > Hi all, > > > > I am planning to release kexec-tools v2.0.14 around the time that > > the v4.9 kernel is released. > > > > I would like to ask

[ANNOUNCE] kexec-tools v2.0.14 preparation

2016-12-02 Thread Simon Horman
Hi all, I am planning to release kexec-tools v2.0.14 around the time that the v4.9 kernel is released. I would like to ask interested parties to send any patches they would like included in v2.0.14 within one week so that I can make an rc release. For reference the patches queued up since

Re: [PATCH V2] purgatory: Change default sha256 optimization to -O2

2016-12-02 Thread Simon Horman
On Thu, Dec 01, 2016 at 11:09:37AM -0800, Geoff Levand wrote: > Change the default purgatory sha256 code optimization from -O0 to -O2, and > add a > new arch specific makefile variable $(ARCH)_PURGATORY_SHA256_CFLAGS which can > over ride this default. Set ia64_PURGATORY_SHA256_CFLAGS to -O0 to

Re: [PATCH] purgatory: Change default sha256 optimization to -O2

2016-11-30 Thread Simon Horman
On Mon, Nov 28, 2016 at 11:14:38AM +0530, Pratyush Anand wrote: > On Thu, Nov 24, 2016 at 1:23 PM, Simon Horman <ho...@verge.net.au> wrote: > > On Wed, Nov 23, 2016 at 09:57:09AM -0800, Geoff Levand wrote: > >> Change the default purgatory sha256 code optimization from -

Re: [PATCH v1 2/2] kexec: Support -S paramter to return whether the kexec payload is loaded.

2016-11-16 Thread Simon Horman
On Mon, Nov 14, 2016 at 05:12:53PM -0500, Konrad Rzeszutek Wilk wrote: > Instead of the scripts having to poke at various fields we can > provide that functionality via the -S parameter. > > Returns 0 if the payload is loaded. Can be used in combination > with -l or -p to get the state of the

Re: Memory range end be inclusive or exclusive? Re: [PATCH v1 1/4] kexec: (bugfix) calc correct end address of memory ranges in device tree

2016-11-07 Thread Simon Horman
Hi Akashi-san, sorry for the long delay(s). The patch below seems reasonable to me and I'm happy to apply it. On Mon, Oct 31, 2016 at 05:50:09PM +0900, AKASHI Takahiro wrote: > Simon, > > On Tue, Sep 06, 2016 at 09:29:59AM +0900, AKASHI Takahiro wrote: > > Simon, > > > > What is your opinion

Re: [PATCH V2] arm64: Add support of R_AARCH64_PREL32 relocation in purgatory

2016-11-07 Thread Simon Horman
On Fri, Oct 28, 2016 at 11:43:48AM -0700, Geoff Levand wrote: > On 10/27/2016 09:16 PM, Pratyush Anand wrote: > > gcc version in fedora koji is 6.2.1-2.fc25. kexec-tools compiled with this > > gcc produced another relocation error: > > > > machine_apply_elf_rel: ERROR Unknown type: 261 > > > >

Re: [PATCH v2] arm64: Add support for additional relocations in the kexec purgatory code

2016-11-07 Thread Simon Horman
On Thu, Oct 20, 2016 at 09:37:03AM -0700, Geoff Levand wrote: > On 10/20/2016 03:43 AM, Catalin Marinas wrote: > > When compiling the kexec-tools with gcc6, the following additional > > reolcations are generated in the purgatory.ro file: > > > > R_AARCH64_ADR_PREL_PG_HI21 > >

Re: [PATCH 0/2] arm64 kexec-tools fixups

2016-10-13 Thread Simon Horman
On Tue, Oct 11, 2016 at 12:20:41PM +0200, Matthias Brugger wrote: > > > On 10/10/2016 11:22 PM, Geoff Levand wrote: > >Hi Simon, > > > >Fixes for 'make tarball'. Please apply. > > > >-Geoff > > > >The following changes since commit 6e8804f9ca67bee65aedd5e1cdf504737ab5c7ed: > > > > multiboot:

Re: [PATCH v3] kexec/fs2dt: Check for NULL pointer in dt_copy_old_root_param()

2016-10-06 Thread Simon Horman
On Tue, Oct 04, 2016 at 07:07:05AM +0530, Madhavan Srinivasan wrote: > In dt_copy_old_root_param(), FILE * returned > from fopen is not checked for NULL pointer > before passinig to fclose(). This could trigger > a segfault. Patch to fix the same. > > Signed-off-by: Madhavan Srinivasan

Re: [PATCH 1/3] kexec elf: Sanity check on the note header before accessing it

2016-10-06 Thread Simon Horman
On Fri, Aug 26, 2016 at 12:46:14PM +, Sylvain Munaut wrote: > The name[hdr.n_namesz -1] check below can segfault if the header > is garbage. So we check the computed header side fits within > the expected area before going further. > > Signed-off-by: Sylvain Munaut

Re: Patch merging process ?

2016-10-06 Thread Simon Horman
On Thu, Oct 06, 2016 at 01:04:43PM +0800, Baoquan He wrote: > On 10/05/16 at 04:06pm, Sylvain Munaut wrote: > > Hi, > > > > > > I sent a series of 3 patch on the mailing list back in August : > > > > http://lists.infradead.org/pipermail/kexec/2016-August/017037.html > > > > They were pretty

Re: [PATCH v3 0/8] (kexec-tools) arm64: add kdump support

2016-09-29 Thread Simon Horman
On Thu, Sep 29, 2016 at 01:18:06AM -0700, AKASHI Takahiro wrote: > On Thu, Sep 29, 2016 at 09:52:00AM +0200, Simon Horman wrote: > > On Wed, Sep 07, 2016 at 01:33:53PM +0900, AKASHI Takahiro wrote: > > > My kernel patches of kdump suport on arm64 are curre

Re: [PATCH v2] kexec/fs2dt: Check for NULL pointer in dt_copy_old_root_param()

2016-09-29 Thread Simon Horman
[CC Dave Young] On Thu, Sep 29, 2016 at 01:29:13PM +0530, Madhavan Srinivasan wrote: > In dt_copy_old_root_param(), FILE * returned > from fopen is not checked for NULL pointer > before passinig to fclose(). This could trigger > a segfault. Patch to fix the same. > > Reviewed-by: Dave Young

Re: [PATCH v1] kexec/arch/i386: Add support for KASLR memory randomization

2016-09-29 Thread Simon Horman
On Tue, Sep 13, 2016 at 03:10:05PM +0800, Baoquan He wrote: > From: Thomas Garnier > > Multiple changes were made on KASLR (right now in linux-next). One of > them is randomizing the virtual address of the physical mapping, vmalloc > and vmemmap memory sections. It breaks

Re: [PATCH] kexec: socket not released when error situation occur.

2016-09-29 Thread Simon Horman
On Thu, Aug 25, 2016 at 11:15:24AM +0900, YoungHyun Yoo wrote: > Fix resourceleek in ifdown function when error occur. > > Signed-off-by: YoungHyun Yoo Thanks, applied. ___ kexec mailing list kexec@lists.infradead.org

Re: [PATCH v3 0/8] (kexec-tools) arm64: add kdump support

2016-09-29 Thread Simon Horman
On Wed, Sep 07, 2016 at 01:33:53PM +0900, AKASHI Takahiro wrote: > My kernel patches of kdump suport on arm64 are currently under reviews. > > This patchset is synced with them (v26 [1]) and provides necessary changes > for kexec-tools. It should be applied on top of Geoff's kexec-tools patches >

Re: [PATCH] kexec: fix mem_regions_sort()

2016-09-29 Thread Simon Horman
On Fri, Jul 29, 2016 at 09:22:19AM +0530, Pratyush Anand wrote: > Hi Simon, > > Please take this fix for 2.0.13. > > ~Pratyush > On 28/07/2016:03:38:46 PM, Russell King wrote: > > On Wed, Jul 27, 2016 at 11:22:24PM +0530, Pratyush Anand wrote: > > > Missed CCing Russell because of --suppress-cc

Re: [PATCH] kexec/fs2dt: Check for NULL pointer in dt_copy_old_root_param()

2016-09-29 Thread Simon Horman
On Fri, Sep 23, 2016 at 03:20:46PM +0530, Pratyush Anand wrote: > On 23/09/2016:12:47:39 PM, Madhavan Srinivasan wrote: > > In dt_copy_old_root_param(), FILE * returned > > from fopen is not checked for NULL pointer > > before passinig to fclose(). This could trigger > > a segfault. Patch adds a

Re: [PATCH v6 0/3] arm64 kexec-tools patches

2016-09-29 Thread Simon Horman
On Wed, Sep 28, 2016 at 06:05:14PM +0200, Matthias Brugger wrote: > > > On 21/09/16 20:14, Geoff Levand wrote: > >This series adds the core support for kexec re-boot on ARM64. > > > > I also tested on seattle. > > Tested-By: Matthias Brugger On Fri, Sep 23, 2016 at

[ANNOUNCE] kexec-tools 2.0.13

2016-08-08 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.13. This is a feature release coinciding with the release of the v4.7 Linux Kernel[*]. This release can be downloaded from kernel.org: http://kernel.org/pub/linux/utils/kernel/kexec/kexec-tools-2.0.13.tar.xz

[ANNOUNCE] kexec-tools 2.0.13-rc1

2016-07-28 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.13-rc1. This is an incremental feature pre-release. So long as no serious problems arise I intend to release kexec-tools 2.0.13 in a weeks time. Testing of 2.0.13-rc1 would be greatly appreciated. I do not have any outstanding

Re: [PATCH v1 0/4] arm64 kexec-tools patches

2016-07-28 Thread Simon Horman
On Thu, Jul 28, 2016 at 11:09:14AM -0700, Geoff Levand wrote: > Hi Simon, > > On Wed, 2016-07-27 at 08:05 +0900, Simon Horman wrote: > > > There seems to have been quite a bit of discussion of this patchset. > > > > I am of a mind to release kexec-tools

Re: [PATCH v1 0/4] arm64 kexec-tools patches

2016-07-26 Thread Simon Horman
Hi Geoff. On Tue, Jul 19, 2016 at 11:28:13PM +, Geoff Levand wrote: > This series adds the core support for kexec re-boot on ARM64. > > Linux kernel support for kexec reboot [1] has been merged to the ARM64 > for-next/core branch with the expectation that it will be included in the v4.8 >

[ANNOUNCE] kexec-tools v2.0.13 preparation

2016-07-20 Thread Simon Horman
Hi all, I am planning to release kexec-tools v2.0.13 around the time that the v4.7 kernel is released. I would like to ask interested parties to send any patches they would like included in v2.0.13 within the next week so that I can make an rc release. For reference the patches queued up since

Re: [PATCH v20 00/14] arm64 kexec kernel patches

2016-07-14 Thread Simon Horman
Hi Geoff, I am wondering if you could comment on the kexec-tools patches for kexec on arm64 and if you think it would be appropriate to merge them at this time. Thanks ___ kexec mailing list kexec@lists.infradead.org

Re: [PATCH 1/2] arm: plug a zImage corner case

2016-07-14 Thread Simon Horman
On Thu, Jul 07, 2016 at 03:01:19PM +0100, Russell King wrote: > If a zImage is built with ARM_APPENDED_DTB enabled, the zImage will > look at the word following the zImage and check whether it contains > the DTB magic number. > > Generally, kexec will clear the destination pages before copying

Re: [PATCH 0/2] Simple fix to the ARM kexec tools implementation

2016-06-22 Thread Simon Horman
On Tue, Jun 21, 2016 at 09:20:33AM +0100, Russell King - ARM Linux wrote: > On Tue, Jun 21, 2016 at 11:41:28AM +0530, Pratyush Anand wrote: > > Yes, so until we have proper header for zImage, these patches looks > > fine to me. > > If you read my last email in the "kexec failures with

Re: [PATCH] Remove "max" parameter comment

2016-06-22 Thread Simon Horman
On Thu, Jun 09, 2016 at 05:18:08PM +0100, Russell King wrote: > Remove the "max" parameter in the documentation for mem_regions_add() > > Signed-off-by: Russell King Thanks, applied. ___ kexec mailing list

Re: [PATCH kexec-tools v2 10/32] kexec: add generic helper to add to memory_regions

2016-06-07 Thread Simon Horman
On Wed, Jun 08, 2016 at 09:13:44AM +0800, Baoquan He wrote: > On 06/06/16 at 05:59pm, Russell King wrote: > > diff --git a/kexec/mem_regions.c b/kexec/mem_regions.c > > new file mode 100644 > > index 000..a4952ff > > --- /dev/null > > +++ b/kexec/mem_regions.c > > @@ -0,0 +1,30 @@ > >

Re: [PATCH kexec-tools v2 00/32] Keystone II updates for kexec tools

2016-06-07 Thread Simon Horman
Hi Russell, On Mon, Jun 06, 2016 at 05:41:29PM +0100, Russell King - ARM Linux wrote: > Here's the latest set of kexec-tools patches to support Keystone II > platforms, which work in conjunction with the kernel patches which > Andrew Morton has already taken. > > Most of the patches have been

Re: [PATCH] MAINTAINERS: Kdump maintainers update

2016-05-25 Thread Simon Horman
> Proposing adding the names of Dave and Baoquan as kdump maintainers as > they have been working on it for quite some time on it upstream and > they are in a much better position to spend time on this than me. > > Signed-off-by: Vivek Goyal <vgo...@redhat.com> FWIW I am fine with

Re: your mail

2016-05-03 Thread Simon Horman
On Fri, Apr 29, 2016 at 04:22:20PM +0200, Nikolaus Schulz wrote: > Hi Simon, > > here is v2 of the patch series from Avionic Design. There are no > content changes, only the setup_dtb_prop patch has a reworked commit > message, as requested. Thanks, Applied.

Re: [PATCH 00/12] Fixing TI Keystone2 kexec

2016-04-28 Thread Simon Horman
Hi Russell, On Thu, Apr 28, 2016 at 10:26:44AM +0100, Russell King - ARM Linux wrote: > These changes are required for TI Keystone2 kexec to be functional. TI > Keystone2 has the run-time view of physical memory above 4GiB, but with > a boot time alias below 4GiB which can only be used during

Re: [PATCH 1/3] arm: properly handle a missing /chosen node in the DT

2016-04-05 Thread Simon Horman
On Thu, Mar 31, 2016 at 05:30:58PM +0200, Alban Bedel wrote: > From: Nikolaus Schulz > > When adding a new node to the DT in the setup_dtb_prop function, the > parent offset need be passed to fdt_add_subnode. Currently a bogus > error code is used. Fix that

Re: [PATCH 1/3] Pass struct mem_sym into machine_apply_elf_rel()

2016-03-23 Thread Simon Horman
On Thu, Mar 24, 2016 at 11:49:35AM +1100, Michael Ellerman wrote: > On Wed, 2016-03-23 at 15:10 +1100, Tony Breeds wrote: > > > On Fri, Feb 26, 2016 at 06:03:11PM +1100, Anton Blanchard wrote: > > > > On PowerPC64 ABIv2 we need to look at the symbol to determine > > > if it has a local entry

[ANNOUNCE] kexec-tools 2.0.12

2016-03-21 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.12. This is a feature release coinciding with the release of the v4.5 Linux Kernel. This release can be downloaded from kernel.org: http://kernel.org/pub/linux/utils/kernel/kexec/kexec-tools-2.0.12.tar.xz

Re: [ANNOUNCE] kexec-tools 2.0.12-rc1

2016-03-19 Thread Simon Horman
On Fri, Mar 18, 2016 at 03:18:48PM +0800, Freeman Zhang wrote: > On 03/14/2016 08:37 AM, Simon Horman wrote: > >Hi all, > > > >I am happy to announce the release of kexec-tools 2.0.12-rc1. > > > >This is an incremental feature pre-release. > > > >

[ANNOUNCE] kexec-tools v2.0.12 preparation

2016-03-01 Thread Simon Horman
Hi all, I am planning to release kexec-tools v2.0.12 around the time that the v4.5 kernel is released. As I estimate that the latter occur within the few weeks I would like to ask interested parties to send any patches they would like included in v2.0.12 within the next week so that I can make

Re: [PATCH update] kexec/fs2dt.c: wrong dt node fix

2016-03-01 Thread Simon Horman
s <drjo...@redhat.com> > > Date: Fri Nov 20 12:31:53 2015 -0500 > > > > kexec/fs2dt: cleanup pathname > > > > putnode() will add the trailing '/', avoid having two. Also > > pathstart is unused, get rid of it. > > > > Si

Re: [PATCH] kexec: Add --lite option

2016-01-11 Thread Simon Horman
On Mon, Jan 11, 2016 at 06:16:38PM +0530, Pratyush Anand wrote: > +Fu > > Hi James, > > > On 08/12/2015:04:00:17 PM, James Morse wrote: > > > Hi Pratyush, > > > > I haven't managed to get your kexec-tools branch to work with v10 of > > Thanks for all your feedback. It helped to stabilize the

Re: [PATCH v3] vmcore-dmesg: Collect full dmesg regardless of logged_chars

2015-12-08 Thread Simon Horman
On Wed, Dec 09, 2015 at 10:28:03AM +0800, Dave Young wrote: > On 12/08/15 at 03:04pm, Simon Horman wrote: > > On Tue, Dec 08, 2015 at 11:36:04AM +0800, Dave Young wrote: > > > On 11/18/15 at 01:24pm, Dangyi Liu wrote: > > > > Simon, > > > > &

Re: [PATCH v2 3/3] ppc64: Add a flag to tell the kernel it's booting from kexec

2015-12-07 Thread Simon Horman
On Tue, Dec 08, 2015 at 02:46:17PM +1100, Michael Ellerman wrote: > On Mon, 2015-12-07 at 14:42 -0600, Scott Wood wrote: > > On Tue, 2015-10-06 at 17:55 -0500, Scott Wood wrote: > > > It needs to know this because the SMP release mechanism for Freescale > > > book3e is different from when booting

Re: [PATCH v3] vmcore-dmesg: Collect full dmesg regardless of logged_chars

2015-12-07 Thread Simon Horman
On Tue, Dec 08, 2015 at 11:36:04AM +0800, Dave Young wrote: > On 11/18/15 at 01:24pm, Dangyi Liu wrote: > > Simon, > > > > Could you help to review this patch? > > > > Thanks, > > Dangyi Liu > > > > On Wed, 2015-10-28 at 17:15 +0800, Dangyi Liu wrote: > > > logged_chars would be set to 0 by

Re: [RFC PATCH] crashdump/x86: Add option to get crash kernel region size

2015-11-30 Thread Simon Horman
On Mon, Nov 30, 2015 at 08:39:31AM +0100, Daniel Kiper wrote: > On Mon, Nov 30, 2015 at 08:55:32AM +0900, Simon Horman wrote: > > On Sat, Nov 28, 2015 at 09:14:04PM +0100, Daniel Kiper wrote: > > > Crash kernel region size is available via sysfs on Linux running on > &g

Re: [PATCH] x86: Make sure E820_PM[AE]M are defined if needed

2015-11-29 Thread Simon Horman
On Fri, Nov 27, 2015 at 02:58:47PM +0800, Baoquan He wrote: > On 11/27/15 at 09:36am, Simon Horman wrote: > > It appears that (older?) revisions of xenctl.h define > > all of the E820_* values used in kexec-x86-common.c except > > E820_PMAM and E820_PMEM. This results in

Re: [PATCH] x86/xen: Build memory type conversion code conditionally

2015-11-29 Thread Simon Horman
On Sat, Nov 28, 2015 at 09:17:18PM +0100, Daniel Kiper wrote: > Xen is not aware of E820_PMEM and E820_PRAM memory types, so, build > simply fails. Hence, build code referencing them conditionally. > > Signed-off-by: Daniel Kiper I believe this is fixed by "x86: Make

[PATCH] x86: Make sure E820_PM[AE]M are defined if needed

2015-11-26 Thread Simon Horman
..@redhat.com> Signed-off-by: Simon Horman <ho...@verge.net.au> --- kexec/arch/i386/kexec-x86-common.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/kexec/arch/i386/kexec-x86-common.c b/kexec/arch/i386/kexec-x86-common.c index b308e4719503..3e97239c0c78 100644 --- a/kexec/arch/i

Re: [PATCH v2] kexec: fix mmap return code handling

2015-11-26 Thread Simon Horman
On Thu, Nov 26, 2015 at 08:02:35PM +0100, Michael Holzheu wrote: > On Thu, 26 Nov 2015 19:02:28 +0100 > Petr Tesarik wrote: > > > On Thu, 26 Nov 2015 18:32:31 +0100 > > Michael Holzheu wrote: > > > > > Hi Simon again, > > > > > > After a bit more

Re: [PATCH 1/1] Improve device tree directory sorting

2015-11-25 Thread Simon Horman
On Tue, Nov 24, 2015 at 06:17:10PM -0800, Curt Brune wrote: > Previously when sorting the device tree directory entries, if both > device tree entries contained the '@' character then comparison was > made based on the length of the strings. > > This did not work in all cases and could result in

Re: [PATCH 1/4] uImage: cleanup some warnings

2015-11-23 Thread Simon Horman
I don't see any value in masking warnings with casts. ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH 2/4] kexec/fs2dt: s/diabled/disabled/

2015-11-23 Thread Simon Horman
Thanks, applied. ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v2] kexex: arm: create ATAGS_MEM tag from devicetree memory node

2015-11-23 Thread Simon Horman
On Fri, Nov 20, 2015 at 10:47:47AM +0100, Andreas Fenkart wrote: > booting a non-devicetree kernel from a devicetree kernel failed, > since the memory layout wasn't passed. > > Signed-off-by: Andreas Fenkart > --- > kexec/arch/arm/kexec-zImage-arm.c | 38

Re: [PATCH] arm: use /sys/firmware/fdt in case without --atags and --dtb

2015-11-23 Thread Simon Horman
On Mon, Nov 23, 2015 at 03:04:23PM +0800, Dave Young wrote: > Latest linux kernel will create /sys/firmware/fdt file. It will be convenient > to use it in case one does not specify --atags and --dtb options. > > Signed-off-by: Dave Young Thanks, applied.

Re: [PATCH 4/4] kexec/fs2dt: check for /chosen/stdout-path first

2015-11-23 Thread Simon Horman
On Fri, Nov 20, 2015 at 12:31:54PM -0500, Andrew Jones wrote: > Check /chosen/stdout-path first, as linux,stdout-path is deprecated. > I don't know how the ppc64:my_debug thing works, but on arm the warning > "Unable to find /proc/device-tree//chosen/linux,stdout-path, printing > from purgatory is

Re: [PATCH 2/2] uImage: fix pointer-sign warning

2015-11-17 Thread Simon Horman
On Mon, Nov 16, 2015 at 01:56:55PM +0100, Andreas Fenkart wrote: > Signed-off-by: Andreas Fenkart Thanks, applied. ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH 1/2] kexex: arm: create ATAGS_MEM tag from devicetree memory node

2015-11-17 Thread Simon Horman
On Mon, Nov 16, 2015 at 01:56:54PM +0100, Andreas Fenkart wrote: > From: Andreas Fenkart > > booting a non-devicetree kernel from a devicetree kernel failed, > since the memory layout wasn't passed. Nice catch. > Signed-off-by: Andreas Fenkart

Re: [PATCH v3] kexec/s390x: use mmap instead of read for slurp_file()

2015-11-08 Thread Simon Horman
On Fri, Oct 30, 2015 at 04:02:04PM +0100, Michael Holzheu wrote: > The slurp_fd() function allocates memory and uses the read() system call. > This results in double memory consumption for image and initrd: > > 1) Memory allocated in user space by the kexec tool > 2) Memory allocated in kernel

Re: [PATCH v2 2/3] ppc64: Avoid rfid if no need to clear MSR_LE

2015-11-01 Thread Simon Horman
On Mon, Nov 02, 2015 at 11:21:43AM +1100, Sam Mendoza-Jonas wrote: > On Mon, Nov 02, 2015 at 09:55:53AM +1100, Sam Mendoza-Jonas wrote: > > On Tue, Oct 06, 2015 at 05:55:49PM -0500, Scott Wood wrote: > > > Commit a304e2d82a8c3 ("ppc64: purgatory: Reset primary cpu endian to > > > big-endian)

Re: [ANNOUNCE] kexec-tools 2.0.11-rc1

2015-10-30 Thread Simon Horman
On Thu, Oct 29, 2015 at 07:23:24PM -0500, Scott Wood wrote: > On Fri, 2015-10-30 at 08:48 +0900, Simon Horman wrote: > > Hi all, > > > > I am happy to announce the release of kexec-tools 2.0.11-rc1. > > > > This is an incremental feature pre-release. > > &

[ANNOUNCE] kexec-tools 2.0.11-rc1

2015-10-29 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.11-rc1. This is an incremental feature pre-release. So long as no serious problems arise I intend to release kexec-tools 2.0.11 shortly after the release of the v4.3 kernel, which I expect to occur in the next week or so. As such

Re: [kexec-tools PATCH 0/3] New option to avoid copying old root param from 1st kernel cmdline

2015-10-29 Thread Simon Horman
On Wed, Oct 28, 2015 at 01:41:34PM +0800, dyo...@redhat.com wrote: > Hi, > > Here is the update patches for adding a new option --dt-no-old-root. > Per previously discussion with Simon, we should consider the compatibility > issue for changing the old behavior. Thus a new option is necessary >

Re: [PATCH] kexec-tools: do not copy 1st kernel root= param in fs2dt.c

2015-10-25 Thread Simon Horman
On Mon, Oct 19, 2015 at 04:22:46PM +0800, Dave Young wrote: > Hi, Simon > > On 10/16/15 at 10:33am, Simon Horman wrote: > > Hi Dave, > > > > On Fri, Oct 09, 2015 at 01:57:22PM +0800, Dave Young wrote: > > > Jan Stodola <jstod...@redhat.com> reported p

Re: [PATCH] kexec-tools: do not copy 1st kernel root= param in fs2dt.c

2015-10-25 Thread Simon Horman
On Fri, Oct 23, 2015 at 05:23:19PM +0800, Dave Young wrote: > On 10/23/15 at 11:19am, Dave Young wrote: > > Hi, Simon > > > > > > > > > > > > > Also, won't this affect other architectures that use DT. > > > > I'm thinking about ARM. If so it might be good to tweak the changelog. > > > > > >

Re: [PATCH] Revert "kexec: use mmap instead of read for slurp_file()"

2015-10-25 Thread Simon Horman
On Fri, Oct 23, 2015 at 11:10:00AM +0800, Dave Young wrote: > This reverts commit 7ab842d8a004f6cd75a9d7b3528e4a70819ce4ef. > > using mmap by default in slurp_file cause segment fault while later > reallocing dtb_buf during my arm kexec test. > > Signed-off-by: Dave Young

Re: [PATCH 2/2] util_lib: Silence ar informational message

2015-10-19 Thread Simon Horman
On Mon, Oct 19, 2015 at 12:30:36PM -0700, Geoff Levand wrote: > Hi Simon, > > On Fri, 2015-10-16 at 10:38 +0900, Simon Horman wrote: > > On Thu, Oct 08, 2015 at 04:21:24PM -0700, Geoff Levand wrote: > > > Add the -c option to ar to silence the informational > > &g

Re: [PATCH] kexec: determine size of block device

2015-10-19 Thread Simon Horman
On Mon, Oct 19, 2015 at 11:32:58AM +0200, Andreas Fenkart wrote: > Hi Simon, > > 2015-10-16 3:30 GMT+02:00 Simon Horman <ho...@verge.net.au>: > > On Fri, Oct 09, 2015 at 03:27:18PM +0200, Andreas Fenkart wrote: > >> starting 'kexec -l /dev/mmcblk0p1' fails since t

Re: [PATCH] kexec-tools: do not copy 1st kernel root= param in fs2dt.c

2015-10-15 Thread Simon Horman
Hi Dave, On Fri, Oct 09, 2015 at 01:57:22PM +0800, Dave Young wrote: > Jan Stodola reported ppc64 root= is always added in > kexec > kernel cmdline. But sometimes we need boot without root= for example we use > kexec to boot into installation initramfs image like below: >

[ANNOUNCE] kexec-tools v2.0.10 preparation

2015-10-15 Thread Simon Horman
Hi all, I am planning to release kexec-tools v2.0.11 around the time that the v4.3 kernel is released. As I estimate that the latter occur within the few weeks I would like to ask interested parties to send any patches they would like included in v2.0.10 within the next week so that I can make

Re: [PATCH v2 1/3] ppc64: Fix warnings

2015-10-15 Thread Simon Horman
On Tue, Oct 06, 2015 at 05:55:48PM -0500, Scott Wood wrote: > Produce a warning-free build on ppc64 (at least, when built as 64-bit > userspace -- if a 64-bit binary for ppc64 is a requirement, why is -m64 > set only on purgatory?). Mostly unused (or write-only) variable > warnings, but also one

Re: [PATCH] kexec: determine size of block device

2015-10-15 Thread Simon Horman
Hi Andreas, On Fri, Oct 09, 2015 at 03:27:18PM +0200, Andreas Fenkart wrote: > starting 'kexec -l /dev/mmcblk0p1' fails since the size of > a block device can not be determined with stat Could you provide some motivation for kexec reading a kernel image from a block device as per the example

Re: [PATCH 2/2] util_lib: Silence ar informational message

2015-10-15 Thread Simon Horman
Hi Geoff, On Thu, Oct 08, 2015 at 04:21:24PM -0700, Geoff Levand wrote: > Add the -c option to ar to silence the informational > message 'ar creating libutil.a'. ar outputs this > message to stderr, and some tools interpret this as > a build warning. I am wondering about the portability of -c.

Re: [PATCH v2 3/3] ppc64: Add a flag to tell the kernel it's booting from kexec

2015-10-15 Thread Simon Horman
On Tue, Oct 06, 2015 at 05:55:50PM -0500, Scott Wood wrote: > It needs to know this because the SMP release mechanism for Freescale > book3e is different from when booting with normal hardware. In theory > we could simulate the normal spin table mechanism, but not (easily) at > the addresses

Re: [PATCH v2 2/3] ppc64: Avoid rfid if no need to clear MSR_LE

2015-10-15 Thread Simon Horman
On Tue, Oct 06, 2015 at 05:55:49PM -0500, Scott Wood wrote: > Commit a304e2d82a8c3 ("ppc64: purgatory: Reset primary cpu endian to > big-endian) changed bctr to rfid. rfid is book3s-only and will cause a > fatal exception on book3e. > > Purgatory is an isolated environment which makes importing

Re: [PATCH v3] Load crash kernel high on x86

2015-10-06 Thread Simon Horman
On Thu, Oct 01, 2015 at 09:26:05AM +0200, Petr Tesarik wrote: > Hello Simon, > > what's up with this patch? Do you plan to apply it, or is there still > an issue? Thanks for the reminder, I have applied the patch now. ___ kexec mailing list

Re: kexec-tools: fix build error with glibc 2.19 and earlier version

2015-10-06 Thread Simon Horman
On Sat, Oct 03, 2015 at 02:38:22PM +0800, Dave Young wrote: > kexec-tools build fails on my laptop with RHEL7.1 installed: > gcc -g -O2 -fno-strict-aliasing -Wall -Wstrict-prototypes -I./include > -I./util_lib/include -Iinclude/ -I./kexec/arch/x86_64/include -c -MD -o >

Re: [PATCH] fix kexec load hang in case crash notes addr read failure

2015-09-24 Thread Simon Horman
On Fri, Sep 25, 2015 at 10:37:51AM +0800, Dave Young wrote: > While readng crash note, count_cpu variable will be never decreased in case > any failure to read the sysfs file. > > The issue was found during I test CONFIG_KEXEC_FILE only kernel option. > crash_notes are exported to sysfs only for

Re: [PATCH] purgatory/arch/ppc64: Reset primary cpu endian to big-endian

2015-09-04 Thread Simon Horman
On Thu, Sep 03, 2015 at 03:18:02PM +1000, Michael Ellerman wrote: > On Wed, 2015-09-02 at 10:02 +0900, Simon Horman wrote: > > [CC linuxppc-dev] > > > > On Fri, Aug 21, 2015 at 12:51:16PM +1000, Samuel Mendoza-Jonas wrote: > > > Older big-endian ppc64 kernels don't

Re: [PATCH] purgatory/arch/ppc64: Reset primary cpu endian to big-endian

2015-09-01 Thread Simon Horman
[CC linuxppc-dev] On Fri, Aug 21, 2015 at 12:51:16PM +1000, Samuel Mendoza-Jonas wrote: > Older big-endian ppc64 kernels don't include the FIXUP_ENDIAN check, > meaning if we kexec from a little-endian kernel the target kernel will > fail to boot. > Returning to big-endian before we enter the

Re: [Patch v3] Add persistent memory support

2015-09-01 Thread Simon Horman
On Tue, Aug 25, 2015 at 03:37:19PM +0800, Dave Young wrote: [snip] > Hmm, after looking into old discussion, I found that the options is there for > the known issue for calgary iommu. I really doubt there's someone is using it > but who knows. > > calgary code uses saved_max_pfn which is only

Re: [PATCH] Drop release date from kexec-tools version output

2015-09-01 Thread Simon Horman
On Wed, Sep 02, 2015 at 09:24:12AM +0800, Dave Young wrote: > kexec --version reports like below: > kexec-tools 2.0.7 released 05 February 2015 > > The date string is generated when one run bootstrap script, thus > it is more like a build date instead of release date. > Even for distribution like

Re: [REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic

2015-08-13 Thread Simon Horman
On Thu, Aug 13, 2015 at 01:53:45PM +0800, Baoquan He wrote: On 08/13/15 at 09:55am, Simon Horman wrote: On Tue, Jul 28, 2015 at 12:46:42PM +0800, Minfei Huang wrote: Transforming PFN(Page Frame Number) to struct page is never failure, so we can simplify the code logic to do the image

Re: [REPOST PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic

2015-08-12 Thread Simon Horman
On Tue, Jul 28, 2015 at 12:46:42PM +0800, Minfei Huang wrote: Transforming PFN(Page Frame Number) to struct page is never failure, so we can simplify the code logic to do the image-control_page assignment directly in the loop, and remove the unnecessary conditional judgement. Signed-off-by:

Re: [PATCH] kexec: use _DEFAULT_SOURCE instead to remove compiling warning

2015-08-12 Thread Simon Horman
On Thu, Aug 06, 2015 at 07:10:55PM +0800, Baoquan He wrote: Now compiling will print warning like below. Change code as it suggested. # warning _BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE ^ Signed-off-by: Baoquan He b...@redhat.com Thanks, applied.

Re: [PATCH] kexec: Remove the unnecessary conditional judgement to simplify the code logic

2015-07-27 Thread Simon Horman
On Mon, Jul 27, 2015 at 09:44:53AM -0400, Vivek Goyal wrote: On Sat, Jun 06, 2015 at 02:14:12PM +0800, Minfei Huang wrote: From: Minfei Huang mnfhu...@gmail.com Transforming PFN(Page Frame Number) to struct page is never failure, so we can simplify the code logic to do the

[ANNOUNCE] kexec-tools 2.0.10

2015-06-25 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.10. This is a feature release coinciding with the release of the v4.1 Linux Kernel. This release can be downloaded from kernel.org: http://kernel.org/pub/linux/utils/kernel/kexec/kexec-tools-2.0.10.tar.xz

[ANNOUNCE] kexec-tools 2.0.10-rc1

2015-06-10 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.10-rc1. This is a bug-fix pre-release. So long as no serious problems arise I intend to release 2.0.10 around the same time as the v4.1 kernel release, which I expect to occur in the next week or so. As such testing of 2.0.10-rc1

[ANNOUNCE] kexec-tools v2.0.10 preparation

2015-05-24 Thread Simon Horman
Hi all, I am planning to release kexec-tools v2.0.10 around the time that the v4.1 kernel is released. As I estimate that the latter occur within the next three or four weeks I would like to ask interested parties to send any patches they would like included in v2.0.10 within the next two weeks

Re: commit 5edcbfd1368e break kexec on x86-64

2015-04-30 Thread Simon Horman
On Thu, Apr 30, 2015 at 02:09:44PM +0900, Simon Horman wrote: On Wed, Apr 29, 2015 at 03:36:17PM -0700, Yinghai Lu wrote: with commit 5edcbfd1368e84fce913ceeeca7b712c524dc20d Author: Aníbal Limón anibal.li...@linux.intel.com Date: Thu Mar 26 16:19:58 2015 + x86_64: Add

<    1   2   3   4   5   6   7   8   9   10   >