Re: [PATCH v2] purgatory: force PIC/PIE/SSP off

2015-04-29 Thread Simon Horman
On Thu, Apr 16, 2015 at 03:39:26AM -0400, Mike Frysinger wrote: From: Mike Frysinger vap...@chromium.org If the toolchain has these things turned on automatically, then the purgatory code might be miscompiled leading to runtime errors like: Unhandled rela relocation: R_X86_64_GOTPC64 It

Re: [PATCH] purgatory: Disabling GCC's stack protection

2015-04-29 Thread Simon Horman
On Thu, Apr 30, 2015 at 01:39:50PM +0900, Simon Horman wrote: Hi Kevin, On Tue, Apr 28, 2015 at 08:50:19PM +0800, Kevin Hao wrote: If the GCC's stack protection is enabled by default, the purgatory will also be built with this option. But it makes no sense to enable

Re: commit 5edcbfd1368e break kexec on x86-64

2015-04-29 Thread Simon Horman
On Wed, Apr 29, 2015 at 03:36:17PM -0700, Yinghai Lu wrote: with commit 5edcbfd1368e84fce913ceeeca7b712c524dc20d Author: Aníbal Limón anibal.li...@linux.intel.com Date: Thu Mar 26 16:19:58 2015 + x86_64: Add support to build kexec-tools with x32 ABI after built kexec on

Re: [PATCH] purgatory: Disabling GCC's stack protection

2015-04-29 Thread Simon Horman
Hi Kevin, On Tue, Apr 28, 2015 at 08:50:19PM +0800, Kevin Hao wrote: If the GCC's stack protection is enabled by default, the purgatory will also be built with this option. But it makes no sense to enable this for the purgatory code, and would cause error when we are trying to relocate the

Re: [PATCH RFC 1/6] purgatory: Fix memcmp for src address increment

2015-04-22 Thread Simon Horman
On Wed, Apr 22, 2015 at 04:49:30PM +0530, Pratyush Anand wrote: On Monday 20 April 2015 05:55 AM, Simon Horman wrote: On Fri, Apr 17, 2015 at 09:55:44AM -0700, Geoff Levand wrote: On Thu, 2015-04-16 at 22:17 +0530, Pratyush Anand wrote: src addresses are not being incremented, so only

Re: [PATCH] purgatory: Fix memcmp for src address increment

2015-04-22 Thread Simon Horman
On Thu, Apr 23, 2015 at 08:34:17AM +0530, Pratyush Anand wrote: src addresses are not being incremented, so only first byte is compared instead of first len bytes. Signed-off-by: Pratyush Anand pan...@redhat.com Acked-by: Geoff Levand ge...@infradead.org Thanks, applied. ---

Re: [PATCH RFC 1/6] purgatory: Fix memcmp for src address increment

2015-04-19 Thread Simon Horman
On Fri, Apr 17, 2015 at 09:55:44AM -0700, Geoff Levand wrote: On Thu, 2015-04-16 at 22:17 +0530, Pratyush Anand wrote: src addresses are not being incremented, so only first byte is compared instead of first len bytes. So I guess this means we never really had proper error checking in

Re: [PATCH RFC 0/6] Various fixes for purgatory and ARM64

2015-04-16 Thread Simon Horman
Hi, On Thu, Apr 16, 2015 at 10:17:23PM +0530, Pratyush Anand wrote: These patches can be applied on top of Geoff's Kexec [1] and Takahiro's Kdump [2] patches and are available in my tree [3]. First two patches are for purgatory. 1st patch is a very important fix for sha verification. 2nd

Re: [PATCH] configure.ac: Fix failure caused by x32 ABI test

2015-04-08 Thread Simon Horman
On Wed, Apr 08, 2015 at 12:48:58PM -0500, Aníbal Limón wrote: When try to compile with zlib fails due to configure.ac bad expansion caused by x32 ABI test that needs AC_PROG_CC for use AC_EGREP_CPP. Signed-off-by: Aníbal Limón anibal.li...@linux.intel.com Thanks for following up on this,

Re: [PATCH] x86_64: Add support to build kexec-tools with x32 ABI

2015-04-08 Thread Simon Horman
On Wed, Apr 08, 2015 at 12:53:46PM -0500, Aníbal Limón wrote: Hi Simon, I did more testing and found that the patch causes a fail when try to compile with zlib and other arch not x86_64, it's related to AC_EGREP_CPP needs previous AC_PROG_CC. I sent a patch for that,

Re: [PATCH] x86_64: Add support to build kexec-tools with x32 ABI

2015-04-06 Thread Simon Horman
On Mon, Apr 06, 2015 at 10:55:47AM -0500, Aníbal Limón wrote: On 05/04/15 20:04, Simon Horman wrote: On Fri, Apr 03, 2015 at 10:05:06AM -0600, Aníbal Limón wrote: Any comment or feedback? I feel like I am missing something obvious, but could you explain the use case a little more clearly

Re: [PATCH] x86_64: Add support to build kexec-tools with x32 ABI

2015-04-05 Thread Simon Horman
On Fri, Apr 03, 2015 at 10:05:06AM -0600, Aníbal Limón wrote: Any comment or feedback? I feel like I am missing something obvious, but could you explain the use case a little more clearly? alimon On 26/03/15 10:19, Aníbal Limón wrote: Summary of changes, configure.ac: Add test for

Re: [PATCH 0/4] Minor purgatory updates

2015-03-18 Thread Simon Horman
On Wed, Mar 18, 2015 at 11:04:03PM +, Geoff Levand wrote: Hi Simon, Here are a few minor updates for purgatory. I think the no-zero-initialized-in-bss flag and the printf type checking should be considered seriously. The symbol and map files less important, but I found them useful in

Re: [PATCH 1/1] kexec: iomem: fix callbacks params for sh and x86 archs

2015-02-24 Thread Simon Horman
On Tue, Feb 24, 2015 at 09:18:47PM +0900, Roman Pen wrote: Commit 4362bfac changes params for kexec_iomem_for_each_line from 'unsigned long' to 'unsigned long long'. This patch fixes forgotten changes for sh and x86 archs. Bug causes incorrect parsing of memory ranges. Signed-off-by:

Re: [PATCH] i386: bzImage: Fix -Wunused-but-set-variable compilation warning

2015-02-24 Thread Simon Horman
On Thu, Feb 12, 2015 at 12:40:18AM -0800, Ameya Palande wrote: kexec/arch/i386/kexec-bzImage.c:111:8: warning: variable ‘kernel_version’ set but not used [-Wunused-but-set-variable] Signed-off-by: Ameya Palande 2am...@gmail.com Thanks, applied ___

Re: [PATCH] i386: elf: Fix -Wunused-but-set-variable compilation warning

2015-02-24 Thread Simon Horman
On Thu, Feb 12, 2015 at 12:34:26AM -0800, Ameya Palande wrote: kexec/arch/i386/kexec-elf-x86.c:97:6: warning: variable ‘modified_cmdline_len’ set but not used [-Wunused-but-set-variable] int modified_cmdline_len; Signed-off-by: Ameya Palande 2am...@gmail.com Thanks, applied.

Re: [PATCH 0/2] kexec-tools minor fixes

2015-02-18 Thread Simon Horman
On Wed, Feb 18, 2015 at 01:00:07AM +, Geoff Levand wrote: Hi Simon, Here are a two minor fixes for compiler warnings. Please consider. -Geoff The following changes since commit 8e762175d295aad08a1cc62d6394e8285f225a40: kexec-tools 2.0.9 (2015-02-09 14:47:41 +0900) are

Re: [PATCH 1/4] configure.ac: apply necessary quotes to result of macro expansion.

2015-02-12 Thread Simon Horman
On Tue, Feb 10, 2015 at 08:46:11PM +0800, Yousong Zhou wrote: This can fix the following error when searching for lzma support and while at it also apply the practice to other uses of the same pattern. checking for lzma_code in -llzma... ./configure: line 4756: ac_fn_c_try_link:

Re: [PATCH] multiboot: fix crash on NULL kernel command line

2015-02-11 Thread Simon Horman
On Thu, Feb 05, 2015 at 01:36:24PM -0800, Ameya Palande wrote: If --command-line option is not specified, then kexec segfaults while dereferencing NULL command line string pointer. While we are at it, also fix indentation and use '{' and '}' consistently. Signed-off-by: Ameya Palande

Re: [PATCH 3/3] Fix a few compilation warnings.

2015-02-09 Thread Simon Horman
On Mon, Feb 09, 2015 at 08:56:25PM +0800, Yousong Zhou wrote: On 9 February 2015 at 13:58, Simon Horman ho...@verge.net.au wrote: These changes do not seem to be related to each other. Please split this into 4 separate patches each with a changelog that briefly describes what the problem

Re: [PATCH] ppc64: erase unnecessary segment info printing

2015-02-08 Thread Simon Horman
On Wed, Oct 29, 2014 at 04:19:55PM +0800, Baoquan He wrote: In ppc64 loading, it will print the segment information. This is not wanted since other Archs don't have this. People even think there's something wrong. So erase it to make it be consistent with other Archs. And if people really

[ANNOUNCE] kexec-tools 2.0.9

2015-02-08 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.9. This is a bug-fix release coinciding with the release of the v3.19 Linux Kernel. This release can be downloaded from kernel.org: http://kernel.org/pub/linux/utils/kernel/kexec/kexec-tools-2.0.9.tar.xz

Re: [PATCH 2/3] Fix zlib/lzma decompression.

2015-02-08 Thread Simon Horman
On Sun, Feb 01, 2015 at 12:10:07AM +0800, Yousong Zhou wrote: Let {zlib,lzma}_decompress_file() return NULL if anything wrong happened to allow the other method to have a chance to run. Signed-off-by: Yousong Zhou yszhou4t...@gmail.com Thanks, applied.

Re: [PATCH 3/3] Fix a few compilation warnings.

2015-02-08 Thread Simon Horman
These changes do not seem to be related to each other. Please split this into 4 separate patches each with a changelog that briefly describes what the problem is. On Sun, Feb 01, 2015 at 12:10:08AM +0800, Yousong Zhou wrote: Signed-off-by: Yousong Zhou yszhou4t...@gmail.com ---

Re: [PATCH 1/3] configure.ac: quote result of AC_CHECK_LIB()

2015-02-08 Thread Simon Horman
On Sun, Feb 01, 2015 at 12:10:06AM +0800, Yousong Zhou wrote: Fix the following error when searching for lzma support. checking for lzma_code in -llzma... ./configure: line 4756: ac_fn_c_try_link: command not found This change does more than the changelog suggests. Please either

[ANNOUNCE] kexec-tools 2.0.9-rc1

2015-01-26 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.9-rc1. This is a bug-fix pre-release. So long as no serious problems arise I intend to release 2.0.9 around the same time as the v3.19 kernel release, which I expect to occur in the next week or so. As such testing of 2.0.9-rc1

[ANNOUNCE] kexec-tools v2.0.9 preparation

2015-01-18 Thread Simon Horman
Hi all, I am planning to release kexec-tools v2.0.9 around the time that the v3.19 kernel is released. As I estimate that the latter occur within the next three or four weeks I would like to ask interested parties to send any patches they would like included in v2.0.9 within the next two weeks

Re: [PATCH] kexec, remove panic_on_warn kernel parameter from kdump situations

2015-01-04 Thread Simon Horman
On Fri, Jan 02, 2015 at 08:17:09AM -0500, Vivek Goyal wrote: On Fri, Jan 02, 2015 at 08:07:20AM -0500, Prarit Bhargava wrote: On 01/02/2015 07:54 AM, Vivek Goyal wrote: On Tue, Dec 30, 2014 at 09:57:51AM -0500, Prarit Bhargava wrote: panic_on_warn kernel parameter will cause the

Re: [PATCH] kexec: remove some re zero-assignment

2014-12-01 Thread Simon Horman
On Sat, Nov 29, 2014 at 08:45:32AM +0800, HuKeping wrote: since we have already cleared kexec_info with memset, there is no need to do that again to the struct members. Signed-off-by: Hu Keping hukep...@huawei.com Thanks, applied. --- kexec/kexec.c | 4 1 file changed, 4

Re: [PATCH] kexec/fs2dt: Use slurp_file_len to avoid partial read of files

2014-12-01 Thread Simon Horman
On Tue, Dec 02, 2014 at 10:59:40AM +1100, Anton Blanchard wrote: The OPAL firmware is going to embed its symbol map in the device tree. The size is large enough to be more than a page, and it takes multiple reads to get the whole file. This is because sysfs uses the seq_file helpers which do a

Re: [PATCH] kexec/fs2dt: Fix sorting of device tree

2014-11-12 Thread Simon Horman
On Thu, Nov 13, 2014 at 11:34:18AM +1100, Anton Blanchard wrote: Commit b02d735bf252 ('ppc64 kdump device_tree sort') added code to sort device tree properties, but it had a few issues. A compare routine needs to return -1 and 1. The special case for sorting properties with unit addresses

Re: [PATCH] kexec: distribute kexec/arch/m68k/bootinfo.h

2014-10-13 Thread Simon Horman
Thanks, applied. Sorry for missing this earlier. On Sun, Oct 12, 2014 at 09:37:17PM +0200, Andreas Schwab wrote: Signed-off-by: Andreas Schwab sch...@linux-m68k.org --- kexec/arch/m68k/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/kexec/arch/m68k/Makefile

[ANNOUNCE] kexec-tools 2.0.8

2014-10-07 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.8. This is a feature release coinciding with the release of the v3.17 Linux Kernel. This release can be downloaded from kernel.org: http://kernel.org/pub/linux/utils/kernel/kexec/kexec-tools-2.0.8.tar.xz

[ANNOUNCE] kexec-tools 2.0.8-rc1

2014-09-30 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.8-rc1. This is a feature pre-release. So long as no serious problems arise I intend to release 2.0.8 around the same time as the v3.17 kernel release, which I expect to occur in the next week or so. As such testing of 2.0.8-rc1

Re: [PATCH] Return error code in case of invalid command line option

2014-09-03 Thread Simon Horman
On Wed, Sep 03, 2014 at 11:29:17AM -0400, Vivek Goyal wrote: Currently kexec returns success even if an invalid command line option is encountered. Kexec currently prints usage message and then returns 0. That's not right. It is an error and error code 1 should be returned. Due to this

Re: [PATCH] ppc64/kdump: Fix ELF header endianess

2014-08-31 Thread Simon Horman
On Thu, Aug 28, 2014 at 03:03:11PM +0200, Laurent Dufour wrote: On 25/07/2014 17:07, Laurent Dufour wrote: The ELF header created among the loading of the kdump kernel should be flagged using the current endianess and not always as big endian. Without this patch the data exposed in

Re: [PATCH V2] kexec: Provide an option to use new kexec system call

2014-08-27 Thread Simon Horman
On Tue, Aug 26, 2014 at 10:30:34AM -0400, Vivek Goyal wrote: On Mon, Aug 18, 2014 at 11:22:32AM -0400, Vivek Goyal wrote: Hi, This is v2 of the patch. Since v1, I moved syscall implemented check littler earlier in the function as per the feedback. Now a new kexec syscall

Re: [PATCH V2] kexec: Provide an option to use new kexec system call

2014-08-27 Thread Simon Horman
On Wed, Aug 27, 2014 at 09:04:39AM -0400, Vivek Goyal wrote: On Wed, Aug 27, 2014 at 04:59:37PM +0900, Simon Horman wrote: On Tue, Aug 26, 2014 at 10:30:34AM -0400, Vivek Goyal wrote: On Mon, Aug 18, 2014 at 11:22:32AM -0400, Vivek Goyal wrote: Hi, This is v2 of the patch. Since

Re: [PATCH] kexec: align the extended size of dtb

2014-07-24 Thread Simon Horman
On Wed, Jul 23, 2014 at 07:20:34PM +0800, Liu Hua wrote: When loading dtb on arm platform, we may need change strings in dtb in function setup_dtb_prop. If length of new string is larger than that of the old one. We should extend the dtb by FDT_TAGALIGNed size. If not, kexec may fail to load

Re: [PATCH] kexec/ppc64: move to device tree version 17

2014-06-16 Thread Simon Horman
On Mon, Jun 16, 2014 at 02:42:43PM +0200, Laurent Dufour wrote: Kernel commit e6a6928c3ea1d0195ed75a091e345696b916c09b changed the way the device tree is processed in the kernel. Now version 2 is no more supported. This patch move the version of the device tree generated in ppc64 environment

Re: [PATCH] vmcore-dmesg: don't enforce largefile handling

2014-06-10 Thread Simon Horman
On Tue, Jun 10, 2014 at 09:29:29PM +0200, Yegor Yefremov wrote: Breaks build on !largefile toolchains. Instead simply use whatever mode is selected by toolchain / CFLAGS. Perhaps the use of configure or something similar is in order to select these options if they are available. It seems to

Re: [ANNOUNCE] kexec-tools 2.0.7

2014-06-09 Thread Simon Horman
On Mon, Jun 09, 2014 at 10:41:19PM +0200, Yegor Yefremov wrote: On Mon, Jun 9, 2014 at 11:54 AM, WANG Chao chaow...@redhat.com wrote: On 06/09/14 at 10:01am, Simon Horman wrote: Hi all, I am happy to announce the release of kexec-tools 2.0.7. Hi, Simon Thanks for the new release

Re: [PATCH 0/2] kexec: add LPAE support for ARM32 platform

2014-06-06 Thread Simon Horman
On Thu, Jun 05, 2014 at 07:20:06PM +0800, Liu Hua wrote: This patch series introduces LPAE support for 32-bit ARM platform. I have test them on LPAE enabled kernel(command: kexec ... -d): With this patch series: crashkernel: [0x2000 - 0x280f] (129M) memory range: [0 -

Re: [PATCH 0/2] kexec command fails after cpu hot-removing

2014-06-05 Thread Simon Horman
On Thu, Jun 05, 2014 at 02:04:41PM +0800, Zhang Yanfei wrote: I think maybe no one had tested kexec-tools after cpu hot-remove. So the bug remains until today. For both two patches: Reviewed-by: Zhang Yanfei zhangyan...@cn.fujitsu.com On Thu, Jun 05, 2014 at 03:32:15PM +0800, WANG Chao

Re: [RESEND PATCH] kexec : add sparse memory related values to vmcore

2014-06-01 Thread Simon Horman
On Fri, May 30, 2014 at 04:14:33PM +0800, Liu hua wrote: On 2014/5/29 8:13, Simon Horman wrote: On Wed, May 28, 2014 at 09:49:56PM +0800, Liu Hua wrote: This patch deales with sparse memory model. For ARM32 platforms, different vendors may define different SECTION_SIZE_BITS, which we

Re: [PATCH 2/2] kexec-tools: add --page-offset option for ARM

2014-05-29 Thread Simon Horman
On Thu, May 29, 2014 at 05:20:03PM +0800, Wang Nan wrote: When KALLSYMS is disabled or /proc is not mounted, this patch allows --page-offset cmdline option for user to setup correct page_offset. Signed-off-by: Wang Nan wangn...@huawei.com Thanks, applied

Re: [PATCH kexec-tools] kdump: pass acpi_rsdp to 2nd kernel if kernel does not export efi runtime maps

2014-05-29 Thread Simon Horman
On Fri, May 30, 2014 at 11:24:52AM +0800, Dave Young wrote: If kernel does not export efi runtime maps it means 1:1 mapping does not work or user explictly boot with efi=old_map. In this case efi setup code will failback to noefi boot, but for kdump case we still need pass extra acpi_rsdp

Re: [PATCH 1/2] kexec-tools: detect page_offset dynamically

2014-05-29 Thread Simon Horman
On Thu, May 29, 2014 at 05:20:02PM +0800, Wang Nan wrote: ARM kernel can be compiled with CONFIG_VMSPLIT_1G, CONFIG_VMSPLIT_2G or CONFIG_VMSPLIT_3G. This patch dynamically detects PAGE_OFFSET according to _stext symbol from /proc/kallsyms. Signed-off-by: Wang Nan wangn...@huawei.com Thanks,

Re: [ANNOUNCE] kexec-tools 2.0.7-rc1

2014-05-28 Thread Simon Horman
On Wed, May 28, 2014 at 08:31:29AM -0400, Vivek Goyal wrote: On Wed, May 28, 2014 at 09:08:36AM +0900, Simon Horman wrote: Hi all, I am happy to announce the release of kexec-tools 2.0.7-rc1. Thanks Simon. Glad to see release of -rc1. I will give it a try on my machine. So 2.0.7

Re: [RESEND PATCH] kexec : add sparse memory related values to vmcore

2014-05-28 Thread Simon Horman
On Wed, May 28, 2014 at 09:49:56PM +0800, Liu Hua wrote: This patch deales with sparse memory model. For ARM32 platforms, different vendors may define different SECTION_SIZE_BITS, which we did not write to vmcore. For example: 1 arch/arm/mach-clps711x/include/mach/memory.h

Re: [PATCH 1/2 resend] kexec-tools: add noefi arch cmdline option

2014-05-27 Thread Simon Horman
On Tue, May 27, 2014 at 01:52:08PM +0800, Dave Young wrote: For kernel boot with efi=old_map or some quirked machines like SGI UV they use old ioremap instead of 1:1 mapping. But kexec efi support depends on the 1:1 mapping thus we need to switch to use the old way There's a kernel patch for

Re: [PATCH] vmcore-dmesg: Handle struct log to struct printk_log renaming

2014-05-27 Thread Simon Horman
On Tue, May 27, 2014 at 09:13:42AM -0400, Vivek Goyal wrote: On Mon, May 26, 2014 at 03:54:22PM +0900, Simon Horman wrote: On Thu, May 22, 2014 at 10:43:14AM -0400, Vivek Goyal wrote: vmcore-dmesg has been failing for me for quite some time as struct log was renamed to struct printk_log

[ANNOUNCE] kexec-tools 2.0.7-rc1

2014-05-27 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.7-rc1. This is a feature pre-release. I intend to release 2.0.7 next week as long as no serious problems arise. As such testing of 2.0.7-rc1 would be greatly appreciated. I do not have any outstanding changes for 2.0.7 at this time.

Re: [PATCH] vmcore-dmesg: Handle struct log to struct printk_log renaming

2014-05-26 Thread Simon Horman
On Thu, May 22, 2014 at 10:43:14AM -0400, Vivek Goyal wrote: vmcore-dmesg has been failing for me for quite some time as struct log was renamed to struct printk_log. 62e32ac printk: rename struct log to struct printk_log This patch has been sitting in mailing list for quite some time. It

Re: [PATCH] kexec/ppc64: Handle reserved memory ranges exported by OPAL firmware.

2014-05-14 Thread Simon Horman
On Mon, May 12, 2014 at 10:04:16AM +0530, Mahesh Jagannath Salgaonkar wrote: On 05/11/2014 05:21 AM, Simon Horman wrote: On Sun, Feb 09, 2014 at 10:25:45PM +0530, Mahesh J Salgaonkar wrote: From: Mahesh Salgaonkar mah...@linux.vnet.ibm.com OPAL based system exports reserved memory ranges

Re: [PATCH] kexec/ppc64: Fix up ELF header and dt for PowerNV platform.

2014-05-14 Thread Simon Horman
On Mon, May 12, 2014 at 09:54:04AM +0530, Mahesh Jagannath Salgaonkar wrote: On 05/11/2014 05:21 AM, Simon Horman wrote: On Sun, Feb 09, 2014 at 10:24:59PM +0530, Mahesh J Salgaonkar wrote: From: Mahesh Salgaonkar mah...@linux.vnet.ibm.com On PowerNV platform, OPAL region is overlapped

Re: [PATCH] cleanup duplicate code

2014-05-11 Thread Simon Horman
On Thu, May 08, 2014 at 10:36:15AM -0400, Vivek Goyal wrote: On Thu, May 08, 2014 at 10:33:15PM +0800, WANG Chao wrote: I accidentally add one duplicate line. Now remove it. Signed-off-by: WANG Chao chaow...@redhat.com --- Acked-by: Vivek Goyal vgo...@redhat.com Thanks, applied.

Re: [PATCH] zImage-arm: init modified_cmdline with zero

2014-05-11 Thread Simon Horman
On Sun, May 04, 2014 at 09:03:53PM +0800, Wang Nan wrote: This patch memset modified_cmdline after it alloced. Without this patch, the header of command line always contains random value like following example: kernel: 0x765fd008 kernel_size: 0x23b610 memory range: [0x6000 -

Re: [PATCH] kexec/ppc64: Handle reserved memory ranges exported by OPAL firmware.

2014-05-11 Thread Simon Horman
On Sun, Feb 09, 2014 at 10:25:45PM +0530, Mahesh J Salgaonkar wrote: From: Mahesh Salgaonkar mah...@linux.vnet.ibm.com OPAL based system exports reserved memory ranges through /proc/device-tree for the regions that are reserved by OPAL firmware. Traverse /proc/device-tree/reserved-ranges and

Re: [PATCH RESEND] condition check fix

2014-05-11 Thread Simon Horman
On Thu, May 08, 2014 at 10:14:29AM -0400, Vivek Goyal wrote: On Thu, May 08, 2014 at 07:26:17PM +0800, WANG Chao wrote: In commit 91f5b9c (kdump: pass e820 reserved region to 2nd kernel via e820 table or setup_data), I made a wrong condition check. We should only add cmdline for a memory

Re: [PATCH RESEND] condition check fix

2014-05-11 Thread Simon Horman
On Sun, May 11, 2014 at 08:43:54AM +0900, Simon Horman wrote: On Thu, May 08, 2014 at 10:14:29AM -0400, Vivek Goyal wrote: On Thu, May 08, 2014 at 07:26:17PM +0800, WANG Chao wrote: In commit 91f5b9c (kdump: pass e820 reserved region to 2nd kernel via e820 table or setup_data), I made

Re: [kexec-tools][PATCH v2] zImage-arm: bugfix: kernel offset must be 0x8000

2014-05-11 Thread Simon Horman
On Tue, May 06, 2014 at 11:53:36AM +0200, Daniel Mack wrote: On 05/06/2014 02:38 AM, Wang Nan wrote: This patch fixs a problem introduced by commit e5d6a55 which make ARM kexec fails. Due to that commit, kernel is loaded at a dynamically offset: it computes extra_size using size of

Re: [PATCH] kexec/ppc64: Fix up ELF header and dt for PowerNV platform.

2014-05-11 Thread Simon Horman
On Sun, Feb 09, 2014 at 10:24:59PM +0530, Mahesh J Salgaonkar wrote: From: Mahesh Salgaonkar mah...@linux.vnet.ibm.com On PowerNV platform, OPAL region is overlapped with crashkernel, need to create ELF Program header for the overlapped memory. The changes are similar to the way RTAS region

Re: [PATCH v2] zImage-arm: get rid of static offset

2014-05-01 Thread Simon Horman
On Thu, May 01, 2014 at 12:42:05PM +0200, Daniel Mack wrote: The code in arch/arm/kexec-zImage-arm.c currently enforces a hard limit on the maximum size a dtb blob can occupy. This limit is set to 32k, which is quite low for device tree blobs nowadays. Get rid of this assumption, and

Re: [PATCH] ppc64/purgatory: Device tree values should be read/stored in Big Endian

2014-04-28 Thread Simon Horman
On Mon, Apr 28, 2014 at 12:26:50PM +0200, Laurent Dufour wrote: The purgatory code reads the device tree's version and stores if needed the currently running CPU number. These 2 values are stored in Big Endian format in the device tree and should be byte swapped when running in Little Endian

Re: [PATCH RESEND] kdump: pass e820 reserved region to 2nd kernel via e820 table or setup_data

2014-04-28 Thread Simon Horman
On Mon, Apr 28, 2014 at 09:26:11PM +0800, WANG Chao wrote: e820 reserved region could be useful in 2nd kernel. For example, PCI mmconf (extended mode) requires reserved region otherwise it falls back to legacy mode. The following log is from Cliff Wickman c...@sgi.com: PCI: MMCONFIG for

Re: [kexec-tools] [PATCH 1/2] Fix rebuilding the purgatory.c file.

2014-04-23 Thread Simon Horman
Thanks, this looks good to me as does the follow up patch. Could you flesh out the changelog and add signed-off-by line to each patch? On Thu, Apr 24, 2014 at 12:04:31PM +0800, Paul Wise wrote: --- kexec/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [kexec-tools] [PATCH] Do not distribute generated files in the release tarball

2014-04-23 Thread Simon Horman
While I'm not opposed to this off-hand I am curious to know what the motivation for it is. On Thu, Apr 24, 2014 at 12:20:56PM +0800, Paul Wise wrote: --- kexec/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kexec/Makefile b/kexec/Makefile index

Re: [kexec-tools] [PATCH] Do not distribute generated files in the release tarball

2014-04-23 Thread Simon Horman
On Thu, Apr 24, 2014 at 12:46:08PM +0800, Paul Wise wrote: On Thu, 2014-04-24 at 13:32 +0900, Simon Horman wrote: While I'm not opposed to this off-hand I am curious to know what the motivation for it is. Within Debian there has been a renewed focus on finding and removing sourceless

Re: [PATCH v7 0/9] kexec-tools, x86: E820 memmap pass for kdump

2014-04-22 Thread Simon Horman
On Tue, Apr 22, 2014 at 12:37:51PM +0800, WANG Chao wrote: On 04/22/14 at 10:56am, WANG Chao wrote: Hi, All This patchset enables passing memory map via E820 map on x86 platform instead of memmap=exactmap. It's a better design and will solve the following problem so far: -

Re: [PATCH v6 9/9] x86: Pass memory range via E820 for kdump

2014-04-20 Thread Simon Horman
On Thu, Apr 17, 2014 at 01:58:17PM +0800, Dave Young wrote: On 04/17/14 at 01:48pm, WANG Chao wrote: On 04/17/14 at 01:29pm, Dave Young wrote: On 04/14/14 at 10:55pm, WANG Chao wrote: command line size is restricted by kernel, sometimes memmap=exactmap has too many memory ranges to

Re: [PATCH RESEND v5 01/10] x86, cleanup: fix indent

2014-04-13 Thread Simon Horman
On Fri, Apr 11, 2014 at 10:23:22AM +0800, WANG Chao wrote: Signed-off-by: WANG Chao chaow...@redhat.com Thanks, Applied. --- kexec/arch/i386/crashdump-x86.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kexec/arch/i386/crashdump-x86.c

Re: [PATCH RESEND v5 02/10] x86, cleanup: add extra arguments to add_memmap() and delete_memmap()

2014-04-13 Thread Simon Horman
On Fri, Apr 11, 2014 at 10:23:23AM +0800, WANG Chao wrote: This change will be used later: add_memmap(.., int *nr_memmap, .., int type); delete_memmap(.., int *nr_memmap, ..); Could you please include an explanation of the motivation for this change in the change log (i.e. here).

Re: [PATCH RESEND v5 03/10] x86, cleanup: add other types of memory range for 2nd kernel boot to memmap_p

2014-04-13 Thread Simon Horman
On Fri, Apr 11, 2014 at 10:23:24AM +0800, WANG Chao wrote: Now memmap_p contains all the memory range for 2nd kernel boot. Could you please include a fuller explanation of what this patch achieves and the motivation for it. Signed-off-by: WANG Chao chaow...@redhat.com ---

Re: [PATCH RESEND v5 04/10] x86, cleanup: add_memmap() only do alignment check on RANGE_RAM

2014-04-13 Thread Simon Horman
Could you please explain why this is necessary. Also, it seems to me that it would make sense to move this patch so that is is immediately after patch 2 in the series. On Fri, Apr 11, 2014 at 10:23:25AM +0800, WANG Chao wrote: Signed-off-by: WANG Chao chaow...@redhat.com ---

Re: [PATCH RESEND v5 08/10] x86, cleanup: Add a funtion add_setup_data()

2014-04-13 Thread Simon Horman
On Fri, Apr 11, 2014 at 10:23:29AM +0800, WANG Chao wrote: add_setup_data() is used to add an instance to the single linked list of setup_data structure. Signed-off-by: WANG Chao chaow...@redhat.com Thanks, applied. --- kexec/arch/i386/x86-linux-setup.c | 26 --

Re: [PATCH] kexec/fs2dt : Fix endianess issue with initrd base and size

2014-04-13 Thread Simon Horman
On Fri, Apr 11, 2014 at 12:10:30PM +0200, Laurent Dufour wrote: The initrd values exposed in the device tree of the kexeced kernel must be encoded in Big Endian format. Without this patch, kexeced LE kernel are expected to panic when dealing with the initrd image. Signed-off-by: Laurent

Re: [RESEND PATCH] ppc64/purgatory: Disabling GCC's stack protection

2014-04-09 Thread Simon Horman
On Tue, Apr 08, 2014 at 04:44:45PM +0200, Laurent Dufour wrote: Some Linux distributions, like Suse, are turning on the GCC's stack protection mechanism by default (-fstack-protector). When building the purgatory with this option, this leads to link issues that are revealed at runtime when the

Re: [PATCH] kexec/ppc: cleanup crash regions creation

2014-04-09 Thread Simon Horman
On Fri, Mar 21, 2014 at 02:58:57PM +0400, Nikita Yushchenko wrote: Move filling crash_memory_range table entries into a separate routine, which saves quite a few lines of code. In this routine, if range spawns over lowmem-highmem border, split range into two. This is needed to get

Re: PATCH: kexec/i386: fix erroneous memory descriptor message

2014-03-28 Thread Simon Horman
On Thu, Mar 27, 2014 at 01:47:15PM +0800, Dave Young wrote: On 03/26/14 at 09:54pm, Tony Jones wrote: On non-EFI systems, efi_info section of boot_params is zero filled resulting in an erroneous message from kexec regarding efi memory descriptor version. Caused by commit:

Re: [kexec-tools PATCH v2] x86, kaslr: add alternative way to locate kernel text mapping area

2014-03-28 Thread Simon Horman
On Fri, Mar 28, 2014 at 10:05:22AM -0400, Vivek Goyal wrote: On Fri, Mar 28, 2014 at 03:05:00PM +0800, WANG Chao wrote: When kASLR is enabled (CONFIG_RANDOMIZED_BASE=y), kernel text mapping base is randomized. The max base offset of such randomization is configured at compile time through

Re: [PATCH 0/3] kexec: pass initrd position in dtb

2014-03-28 Thread Simon Horman
On Thu, Mar 27, 2014 at 09:14:34AM +0800, Dave Young wrote: On 03/25/14 at 12:09pm, Wang Nan wrote: The main goal of this patch series is to pass initrd position to secondary kernel. To makes code clear, patch 2/3 introduce a new function to handle fdt related operations. Without these

Re: [PATCH] kexec-tools: handle 64bit efi memmap address correctly

2014-03-25 Thread Simon Horman
On Mon, Mar 24, 2014 at 09:47:20AM +0800, Dave Young wrote: On 03/20/14 at 09:58am, Dave Young wrote: In case using crashkernel=xM,high crashkernel memory will be allocated from top to down Thus the usable memory for kdump kernel could be bigger than 4G. The efi memmap value is two 32

Re: [kexec-tools PATCH] x86: extend kernel text size up to 1GB

2014-03-19 Thread Simon Horman
On Fri, Mar 14, 2014 at 03:29:29PM +0800, WANG Chao wrote: On 03/14/14 at 03:08pm, Dave Young wrote: On 03/14/14 at 03:03pm, WANG Chao wrote: On 03/14/14 at 02:47pm, Dave Young wrote: On 03/14/14 at 02:12pm, Dave Young wrote: On 03/12/14 at 11:13am, WANG Chao wrote: Currently

Re: [PATCH v4 0/4] kexec-tools, x86: E820 memmap pass for kdump

2014-03-19 Thread Simon Horman
On Wed, Mar 19, 2014 at 11:57:57AM -0600, Linn Crosetto wrote: On Wed, Mar 19, 2014 at 04:03:57PM +0800, WANG Chao wrote: Hi, All When kaslr comes in and kdump is broken, it seems about the right time to use E820 instead of memmap=exactmap to pass memmap for kdump for the default

Re: [PATCH v4 1/4] cleanup: add dbgprint_mem_range function

2014-03-19 Thread Simon Horman
On Wed, Mar 19, 2014 at 04:03:58PM +0800, WANG Chao wrote: dbgprint_mem_range is used for printing the given memory range under debugging mode. Signed-off-by: WANG Chao chaow...@redhat.com Tested-by: Linn Crosetto l...@hp.com Thanks, I have applied this patch. ---

Re: [PATCH 1/2] kexec: align initrd when no --image-size passed

2014-03-19 Thread Simon Horman
(pagesize -1)) { die(Base address: 0x%lx is not page aligned\n, base); } This patch also uses getpagesize() instead of hard encoded 4096. Signed-off-by: Wang Nan wangn...@huawei.com Cc: Simon Horman ho...@verge.net.au Cc: Dave Young dyo...@redhat.com Cc: Geng Hui

Re: [kexec-tools PATCH] x86: extend kernel text size up to 1GB

2014-03-19 Thread Simon Horman
On Thu, Mar 20, 2014 at 12:53:35PM +0800, WANG Chao wrote: On 03/20/14 at 12:44pm, Simon Horman wrote: On Fri, Mar 14, 2014 at 03:29:29PM +0800, WANG Chao wrote: On 03/14/14 at 03:08pm, Dave Young wrote: On 03/14/14 at 03:03pm, WANG Chao wrote: On 03/14/14 at 02:47pm, Dave Young

Re: [PATCH v2] vmcore-dmesg stack smashing happend in extreme case

2014-03-11 Thread Simon Horman
On Tue, Mar 11, 2014 at 09:42:15PM -0400, Vivek Goyal wrote: On Wed, Mar 12, 2014 at 09:27:02AM +0800, arthur wrote: Description in dump_dmesg_structured() the out_buf size is 4096, and if the length is less than 4080( 4096-16 ) it won't really write out. Normally, after writing one or

Re: [PATCH v3] vmcore-dmesg stack smashing happend in extreme case

2014-03-11 Thread Simon Horman
On Wed, Mar 12, 2014 at 01:05:18PM +0800, Arthur Zou wrote: Description in dump_dmesg_structured() the out_buf size is 4096, and if the length is less than 4080( 4096-16 ) it won't really write out. Normally, after writing one or four chars to the out_buf, it will check the length of out_buf.

[ANNOUNCE] kexec-tools 2.0.6

2014-03-06 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.6. This is a bugfix release to address a number of problems discovered in 2.0.5. The release can be downloaded from kernel.org: http://kernel.org/pub/linux/utils/kernel/kexec/kexec-tools-2.0.6.tar.xz

Re: PATCH: bug in locate_hole()

2014-03-05 Thread Simon Horman
ranges, since the 0x10 bytes at 0xbeff000 overlaps 0x1000 bytes at 0xbffe000. Signed-off-by: Matthew Fleming mdf...@gmail.com Signed-off-by: Simon Horman ho...@verge.net.au --- kexec/kexec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kexec/kexec.c b/kexec/kexec.c index

Re: PATCH: bug in locate_hole()

2014-03-03 Thread Simon Horman
Thanks Matthew. Could you provide a signed-off-by line? On Mon, Mar 03, 2014 at 04:34:35PM -0800, Matthew Fleming wrote: In upgrading to kexec-tools 2.0.5 I first got the error Overlapping memory segments at 0xbeff000 Adding some debugging I found locate_hole was returning incorrect

Re: More frequent kexec-tools releases

2014-02-11 Thread Simon Horman
On Fri, Feb 07, 2014 at 09:34:09AM -0500, Vivek Goyal wrote: On Fri, Feb 07, 2014 at 08:58:52AM +0900, Simon Horman wrote: On Thu, Feb 06, 2014 at 09:23:32AM -0500, Vivek Goyal wrote: On Thu, Feb 06, 2014 at 10:55:13AM +0900, Simon Horman wrote: [..] Thanks Simon. I did git pull

Re: [PATCH] kexec: fix uImage probe false positive

2014-02-06 Thread Simon Horman
On Thu, Feb 06, 2014 at 09:50:23AM +0200, Baruch Siach wrote: Since bf06cf2095 (kexec/uImage: probe to identify a corrupted image) uImage_probe_kernel() returns 1 for non uImage files. Don't treat this value as positive probe indication. Cc: Suzuki K. Poulose suz...@in.ibm.com

Re: More frequent kexec-tools releases

2014-02-06 Thread Simon Horman
On Thu, Feb 06, 2014 at 09:23:32AM -0500, Vivek Goyal wrote: On Thu, Feb 06, 2014 at 10:55:13AM +0900, Simon Horman wrote: [..] Thanks Simon. I did git pull but I don't see new tag in my tree. Not sure why. Could you try again? I messed up the push. It works now. Thanks

Re: [ANNOUNCE] kexec-tools 2.0.5

2014-02-05 Thread Simon Horman
On Wed, Feb 05, 2014 at 09:46:23AM -0800, Tony Jones wrote: On 02/04/2014 06:03 PM, Simon Horman wrote: I have also tagged it in git: git://git.kernel.org/pub/scm/utils/kernel/kexec/kexec-tools.git I think you forgot to push the tag. Sorry about that, it should be there now

Re: More frequent kexec-tools releases

2014-02-05 Thread Simon Horman
On Wed, Feb 05, 2014 at 08:20:15AM -0500, Vivek Goyal wrote: On Wed, Feb 05, 2014 at 03:49:06PM +0900, Simon Horman wrote: On Wed, Feb 05, 2014 at 09:12:26AM +0800, Zhang Yanfei wrote: On 02/04/2014 08:41 PM, Simon Horman wrote: On Tue, Feb 04, 2014 at 05:31:51PM +0900, Simon Horman

Re: PATCH: kexec/i386 fix build failure (bzImage_support_efi_boot)

2014-02-05 Thread Simon Horman
On Wed, Feb 05, 2014 at 02:32:18PM -0800, Tony Jones wrote: Commit 9c200a85de2245a850546fded96a1977b84ad24d referenced 'bzImage_support_efi_boot' without matching 32-bit definition. Signed-off-by: Tony Jones to...@suse.de Thanks, applied. --- kexec/arch/i386/kexec-bzImage.c |1 + 1

Re: [PATCH 1/2] zImage_ppc64_probe: return 0 instead of 1 in case of success

2014-02-05 Thread Simon Horman
On Thu, Feb 06, 2014 at 02:30:43PM +0800, Dave Young wrote: All other _probe functions return 0 for probing the kernel image successfully, so there's no reason to return 1 here. Fix it to return 0 instead. Signed-off-by: Dave Young dyo...@redhat.com Thanks, applied. ---

<    1   2   3   4   5   6   7   8   9   10   >