Re: Implementing .shutdown method for efa module

2024-04-24 Thread Tao Liu
Hi Jason & Michael, Kindly ping... Any progress for the efa .shutdown implementing? Thanks in advance! Thanks, Tao Liu On Wed, Apr 3, 2024 at 11:44 PM Jason Gunthorpe wrote: > > On Mon, Apr 01, 2024 at 04:23:32PM +0300, Margolin, Michael wrote: > > Jason > > > &

Re: Implementing .shutdown method for efa module

2024-03-29 Thread Tao Liu
fa_main.c, the issue doesn't get reproduced. It looks to me the issue can be solved by this code change, however according to Jason, there might be problems. I'm not familiar with this, could you please try to fix this issue? Thanks in advance! Thanks, Tao Liu > > Michael > > On 3/26/202

Re: Implementing .shutdown method for efa module

2024-03-25 Thread Tao Liu
Hi Gal, On Mon, Mar 25, 2024 at 4:06 PM Gal Pressman wrote: > > On 25/03/2024 4:10, Tao Liu wrote: > > Hi, > > > > Recently I experienced a kernel panic which is related to efa module > > when testing kexec -l && kexec -e to switch to a new kernel on AWS &

Implementing .shutdown method for efa module

2024-03-24 Thread Tao Liu
emented either. Since I'm not very familiar with the efa driver, could you please implement the .shutdown method in drivers/infiniband/hw/efa/efa_main.c? Thanks in advance! [1]: https://github.com/torvalds/linux/blob/master/drivers/infiniband/hw/efa/efa_main.c#

Re: [PATCHv8 00/17, CORRECTED] x86/tdx: Add kexec support

2024-03-06 Thread Tao Liu
view. I would be glad for any feedback. > > Thomas, Ingo, Borislav, Dave, > > Any feedback? > > Is there anything else I can do to get the patchset moving? > I tested the patchset with Linux 6.8-rc6, no problem found. With the patchset, a vmcore can be generated successfully in

Re: [PATCH 0/4] kdump: crashkernel reservation from CMA

2023-11-27 Thread Tao Liu
Hi Jiri, On Sun, Nov 26, 2023 at 5:22 AM Jiri Bohac wrote: > > Hi Tao, > > On Sat, Nov 25, 2023 at 09:51:54AM +0800, Tao Liu wrote: > > Thanks for the idea of using CMA as part of memory for the 2nd kernel. > > However I have a question: > > > > What

Re: [PATCH 0/4] kdump: crashkernel reservation from CMA

2023-11-24 Thread Tao Liu
> reservation cannot be used. > Thanks for the idea of using CMA as part of memory for the 2nd kernel. However I have a question: What if there is on-going DMA/RDMA access on the CMA range when 1st kernel crash? There might be data corruption when 2nd kernel and DMA/RDMA write to the same

Re: [PATCHv3 00/14] x86/tdx: Add kexec support

2023-11-21 Thread Tao Liu
u support for kexec reboot? > > You would need a patched BIOS image. I've hacked one[1] for my testing. > But it only works if kernel runs in 4-level paging mode (specify no5lvl in > kernel command line). > > BIOS folks work on proper patch, but it is not ready yet. > > [1

Re: [RFC][PATCH] iwlwifi: Add pci .shutdown() hook for iwlwifi driver

2023-08-03 Thread Tao Liu
Add kexec to the CC list so kexec people can know this. On Thu, Aug 3, 2023 at 10:55 AM Tao Liu wrote: > > Previously no .shutdown() hook is implemented for iwlwifi driver, a > ETIMEDOUT error will occur during the kexec kernel bootup. As a > consequence, wifi is unusable

Re: [PATCH v2] x86/kexec: Add EFI config table identity mapping for kexec kernel

2023-08-02 Thread Tao Liu
Hi Borislav, On Sat, Jul 29, 2023 at 12:56 AM Borislav Petkov wrote: > > On Thu, Jul 27, 2023 at 07:03:26PM +0800, Tao Liu wrote: > > Hi Borislav, > > > > Sorry for the late response. I spent some time retesting your patch > > against 6.5.0-rc1 and 6.5.0-rc3, and

Re: [PATCH v2] x86/kexec: Add EFI config table identity mapping for kexec kernel

2023-07-27 Thread Tao Liu
Hi Ard, On Mon, Jul 17, 2023 at 11:11 PM Tao Liu wrote: > > On Mon, Jul 17, 2023 at 10:57 PM Ard Biesheuvel wrote: > > > > On Mon, 17 Jul 2023 at 15:53, Tao Liu wrote: > > > > > > Hi Borislav, > > > > > > On Thu, Jul 13, 2023 at 6:05 PM

Re: [PATCH v2] x86/kexec: Add EFI config table identity mapping for kexec kernel

2023-07-27 Thread Tao Liu
Hi Borislav, Sorry for the late response. I spent some time retesting your patch against 6.5.0-rc1 and 6.5.0-rc3, and it is OK. So Reported-and-tested-by: Tao Liu And will we use this patch as a workaround or will we wait for a better solution as proposed by Michael? On Mon, Jul 17, 2023

Re: [PATCH v2] x86/kexec: Add EFI config table identity mapping for kexec kernel

2023-07-17 Thread Tao Liu
On Mon, Jul 17, 2023 at 10:57 PM Ard Biesheuvel wrote: > > On Mon, 17 Jul 2023 at 15:53, Tao Liu wrote: > > > > Hi Borislav, > > > > On Thu, Jul 13, 2023 at 6:05 PM Borislav Petkov wrote: > > > > > > On Thu, Jun 01, 2023 at 03:20:44P

Re: [PATCH v2] x86/kexec: Add EFI config table identity mapping for kexec kernel

2023-07-17 Thread Tao Liu
g code is up. Yes, if we can defer the cc blob access, the issue can be resolved. I don't know if it is doable from AMD's view... > > If this is problematic, we might instead disable SEV for kexec, and > rely on the fact that SEV firmware enters with a complete 1:1 map (as We still need

Re: [PATCH v2] x86/kexec: Add EFI config table identity mapping for kexec kernel

2023-07-17 Thread Tao Liu
On Mon, Jul 17, 2023 at 10:14 PM Borislav Petkov wrote: > > On Mon, Jul 17, 2023 at 09:53:06PM +0800, Tao Liu wrote: > > ...snip... > > [ 21.360763] nvme0n1: p1 p2 p3 > > [ 21.364207] igc :03:00.0: PTM enabled, 4ns granularity > > [ 21.421097]

Re: [PATCH v2] x86/kexec: Add EFI config table identity mapping for kexec kernel

2023-07-17 Thread Tao Liu
Hi Borislav, On Thu, Jul 13, 2023 at 6:05 PM Borislav Petkov wrote: > > On Thu, Jun 01, 2023 at 03:20:44PM +0800, Tao Liu wrote: > > arch/x86/kernel/machine_kexec_64.c | 35 ++ > > 1 file changed, 31 insertions(+), 4 deletions(-) > > Ok, pls t

Re: [PATCH v2] x86/kexec: Add EFI config table identity mapping for kexec kernel

2023-07-06 Thread Tao Liu
Hi Borislav, Thanks for the patch review! On Thu, Jul 6, 2023 at 1:34 AM Borislav Petkov wrote: > > On Thu, Jun 01, 2023 at 03:20:44PM +0800, Tao Liu wrote: > > A kexec kernel bootup hang is observed on Intel Atom cpu due to unmapped > > s/cpu/CPU/g > > > EFI config t

Re: [PATCH v2] x86/kexec: Add EFI config table identity mapping for kexec kernel

2023-06-08 Thread Tao Liu
, Tao Liu On Thu, Jun 1, 2023 at 4:25 PM Tao Liu wrote: > > Hi Baoquan, > > On Thu, Jun 1, 2023 at 4:13 PM Baoquan He wrote: > > > > On 06/01/23 at 03:20pm, Tao Liu wrote: > > > A kexec kernel bootup hang is observed on Intel Atom cpu due to unmapped > > &g

Re: [PATCH v2] x86/kexec: Add EFI config table identity mapping for kexec kernel

2023-06-01 Thread Tao Liu
Hi Baoquan, On Thu, Jun 1, 2023 at 4:13 PM Baoquan He wrote: > > On 06/01/23 at 03:20pm, Tao Liu wrote: > > A kexec kernel bootup hang is observed on Intel Atom cpu due to unmapped > > EFI config table. > > > > Currently EFI system table is identity-mapped

[PATCH v2] x86/kexec: Add EFI config table identity mapping for kexec kernel

2023-06-01 Thread Tao Liu
not be mapped into due to 2 MB page size, thus a page fault hang is more likely to happen. This patch will make sure the EFI config table is always mapped. Signed-off-by: Tao Liu --- Changes in v2: - Rephrase the change log based on Baoquan's suggestion. - Rename map_efi_sys_cfg_tab() to map_efi_

Re: [PATCH] x86/kexec: Add EFI config table identity mapping for kexec kernel

2023-05-26 Thread Tao Liu
Hi Baoquan, On Fri, May 26, 2023 at 12:08 PM Baoquan He wrote: > > Hi Tao, > > On 05/25/23 at 05:49pm, Tao Liu wrote: > > A kexec kernel bootup hang is observed on Intel Atom cpu due to unmapped > > EFI config table. > > > > Currently EFI system table is

[PATCH] x86/kexec: Add EFI config table identity mapping for kexec kernel

2023-05-25 Thread Tao Liu
not be mapped into due to 2 MB page size, thus a page fault hang is more likely to happen. In this patch, we will make sure the EFI config table is always mapped. Signed-off-by: Tao Liu --- arch/x86/kernel/machine_kexec_64.c | 35 ++ 1 file changed, 31 insertions(+), 4 d

Re: [PATCH v3 00/10] x86/sev: KEXEC/KDUMP support for SEV-ES guests

2022-07-29 Thread Tao Liu
Hi Tom, On Fri, Apr 29, 2022 at 08:08:28AM -0500, Tom Lendacky wrote: > On 4/29/22 04:06, Tao Liu wrote: > > On Thu, Jan 27, 2022 at 11:10:34AM +0100, Joerg Roedel wrote: > > > > > Hi Joerg, > > > > I tried the patch set with 5.17.0-rc1 kernel, an

[PATCH v2] kdump: round up the total memory size to 128M for crashkernel reservation

2022-06-27 Thread Tao Liu
Young . [1]: http://lists.infradead.org/pipermail/kexec/2018-April/020568.html Signed-off-by: Tao Liu --- v1 -> v2: Modified commit log based on Baoquan's advice. --- kernel/crash_core.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/kernel/crash_core.

[PATCH] kdump: round up the total memory size to 128M for crashkernel reservation

2022-06-15 Thread Tao Liu
. This patch is a resend of [1] and rebased onto v5.19-rc2, and the original credit goes to Dave Young . [1]: http://lists.infradead.org/pipermail/kexec/2018-April/020568.html Signed-off-by: Tao Liu --- kernel/crash_core.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v3 00/10] x86/sev: KEXEC/KDUMP support for SEV-ES guests

2022-04-29 Thread Tao Liu
to /sysroot/var/crash/127.0.0.1-2022-04-18-05:58:50/ [2.804355] kdump[555]: saving vmcore-dmesg.txt complete [2.806915] kdump[557]: saving vmcore ^ vmcore can still be generated ... [7.068981] reboot: Restarting system [7.069340] reboot: machine

Re: [PATCH 01/12] kexec: Allow architecture code to opt-out at runtime

2022-04-21 Thread Tao Liu
___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: Qemu does not like kexec initrd

2022-03-17 Thread Tao Liu
, Loading zstd initrd will cause an error(what error? who prints the error?) ZSTD-data is corrupt error on qemu(how do you know the data is corrupt? what attempts did you make?). Please note upstream is not responsible for the distribution specific issues. Thanks, Tao Liu On Wed, Mar 16, 2022 at 10:33

Re: Qemu does not like kexec initrd

2022-03-16 Thread Tao Liu
produce it. Thanks, Tao Liu > Am Mi., 16. März 2022 um 14:58 Uhr schrieb Tao Liu : > > > > Hi Baoquan, > > > > On Wed, Mar 16, 2022 at 7:38 PM Baoquan He wrote: > > > > > > Cc Tao, > > > > > > On 03/16/22 at 11:57am, Tobias Powalows

Re: Qemu does not like kexec initrd

2022-03-16 Thread Tao Liu
my project: > > Loading zstd initrd will cause an error: > > ZSTD-data is corrupt error on qemu. > > Is there a fix or workaround for this issue? > > Hi Tao, > > Did you ever met this when you introduce zstd to kexec/kdump? > No, I haven't encountered this issue

Re: [PATCH 00/11] makedumpfile: Add zstd support for makedumpfile

2021-09-21 Thread Tao Liu
4534 5327454123 > > > > > > zstd-1 459.066807 5748037931 > > > > > > zstd0 561.687525 4680009013 > > > > > > zstd1 547.248917 4706358547 > > > > > >

Re: [PATCH 00/11] makedumpfile: Add zstd support for makedumpfile

2021-09-14 Thread Tao Liu
Hi Kazu, Thanks for reviewing the patchset! On Tue, Sep 14, 2021 at 07:04:24AM +, HAGIO KAZUHITO(萩尾 一仁) wrote: > Hi Tao Liu, > > Thanks for the patchset! > > -Original Message- > > This patch set adds ZSTD compression support to makedumpfile. With ZSTD > &

[PATCH 10/11] makedumpfile: Add zstd manual description

2021-09-10 Thread Tao Liu
Signed-off-by: Tao Liu Signed-off-by: Coiby Xu --- makedumpfile.8 | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/makedumpfile.8 b/makedumpfile.8 index f782e5f..3022d9c 100644 --- a/makedumpfile.8 +++ b/makedumpfile.8 @@ -132,10 +132,11 @@ configuration, you need

[PATCH 11/11] makedumpfile: Add zstd README description

2021-09-10 Thread Tao Liu
Signed-off-by: Tao Liu Signed-off-by: Coiby Xu --- README | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/README b/README index 6629440..0b17cf1 100644 --- a/README +++ b/README @@ -49,7 +49,10 @@ 7.Build with snappy support: # make USESNAPPY=on ; make install

[PATCH 09/11] makedumpfile: Add zstd help message

2021-09-10 Thread Tao Liu
Signed-off-by: Tao Liu Signed-off-by: Coiby Xu --- print_info.c | 30 +- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/print_info.c b/print_info.c index 8b28554..e4bfefc 100644 --- a/print_info.c +++ b/print_info.c @@ -38,6 +38,11 @@ show_version

[PATCH 08/11] makedumpfile: Add parallel threads zstd uncompression processing

2021-09-10 Thread Tao Liu
Signed-off-by: Tao Liu --- makedumpfile.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/makedumpfile.c b/makedumpfile.c index e70d882..2514eb6 100644 --- a/makedumpfile.c +++ b/makedumpfile.c @@ -919,7 +919,7 @@ readpage_kdump_compressed_parallel(int fd_memory

[PATCH 07/11] makedumpfile: Add single thread zstd uncompression processing

2021-09-10 Thread Tao Liu
Signed-off-by: Tao Liu Signed-off-by: Coiby Xu --- makedumpfile.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/makedumpfile.c b/makedumpfile.c index af21a84..e70d882 100644 --- a/makedumpfile.c +++ b/makedumpfile.c @@ -832,7 +832,7 @@ readpage_kdump_compressed

[PATCH 04/11] makedumpfile: Notify zstd unsupporting when disabled

2021-09-10 Thread Tao Liu
Signed-off-by: Tao Liu Signed-off-by: Coiby Xu --- makedumpfile.c | 9 + 1 file changed, 9 insertions(+) diff --git a/makedumpfile.c b/makedumpfile.c index 100b407..f3bf297 100644 --- a/makedumpfile.c +++ b/makedumpfile.c @@ -4171,6 +4171,15 @@ initial(void) } #endif

[PATCH 05/11] makedumpfile: Add single thread zstd compression processing

2021-09-10 Thread Tao Liu
Signed-off-by: Tao Liu Signed-off-by: Coiby Xu --- makedumpfile.c | 41 - makedumpfile.h | 3 +++ 2 files changed, 39 insertions(+), 5 deletions(-) diff --git a/makedumpfile.c b/makedumpfile.c index f3bf297..76a7a77 100644 --- a/makedumpfile.c +++ b

[PATCH 02/11] makedumpfile: Add command-line processing for zstd

2021-09-10 Thread Tao Liu
Signed-off-by: Tao Liu Signed-off-by: Coiby Xu --- makedumpfile.c | 5 - makedumpfile.h | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/makedumpfile.c b/makedumpfile.c index 157..100b407 100644 --- a/makedumpfile.c +++ b/makedumpfile.c @@ -11656,7 +11656,7 @@ main

[PATCH 01/11] makedumpfile: Add dump header for zstd.

2021-09-10 Thread Tao Liu
Signed-off-by: Tao Liu Signed-off-by: Coiby Xu --- diskdump_mod.h | 1 + 1 file changed, 1 insertion(+) diff --git a/diskdump_mod.h b/diskdump_mod.h index 3733953..e4bce5c 100644 --- a/diskdump_mod.h +++ b/diskdump_mod.h @@ -98,6 +98,7 @@ struct kdump_sub_header { #define

[PATCH 06/11] makedumpfile: Add parallel threads zstd compression processing

2021-09-10 Thread Tao Liu
Signed-off-by: Tao Liu --- makedumpfile.c | 26 ++ makedumpfile.h | 6 ++ 2 files changed, 32 insertions(+) diff --git a/makedumpfile.c b/makedumpfile.c index 76a7a77..af21a84 100644 --- a/makedumpfile.c +++ b/makedumpfile.c @@ -3892,6 +3892,12

[PATCH 03/11] makedumpfile: Add zstd build support

2021-09-10 Thread Tao Liu
Signed-off-by: Tao Liu Signed-off-by: Coiby Xu --- Makefile | 5 + 1 file changed, 5 insertions(+) diff --git a/Makefile b/Makefile index 5d61a69..725c186 100644 --- a/Makefile +++ b/Makefile @@ -68,6 +68,11 @@ endif CFLAGS += -DUSESNAPPY endif +ifeq ($(USEZSTD), on) +LIBS := -lzstd

[PATCH 00/11] makedumpfile: Add zstd support for makedumpfile

2021-09-10 Thread Tao Liu
For zstd2/zlib/lzo/snappy, zstd2 has the smallest vmcore size, also the best time consumption and vmcore dump size balance. Tao Liu (11): Add dump header for zstd. Add command-line processing for zstd Add zstd build support Notify zstd unsupporting when disabled Add single thr

[makedumpfile PATCH] check for invalid physical address of /proc/kcore when make ELF format dumpfile

2021-06-18 Thread Tao Liu
contains PT_LOAD program headers which have physaddr(). With -E option, makedumpfile will try to convert the physaddr to an offset and fails. In this patch, let's skip the PT_LOAD program headers which have such physaddr. Signed-off-by: Tao Liu --- makedumpfile.c | 3 +++ 1 file

Re: [CFT][PATCH] kexec: Remove the error prone kernel_version function

2021-04-14 Thread Tao Liu
Hello Eric, I have the patch tested in the following cases: x86_64, kernel 5.11.11, KASLR off; x86_64, kernel 5.11.11, KASLR on; x86_64, kernel 5.12.0-rc7, KASLR off; x86_64, kernel 5.12.0-rc7, KASLR on; All cases are good to me, I can dump the vmcores and get them analyzed in cras