Re: [PATCH] x86: Find offset for crashkernel reservation automatically

2008-07-14 Thread Yinghai Lu
On Fri, Jun 27, 2008 at 6:32 AM, Vivek Goyal [EMAIL PROTECTED] wrote: On Thu, Jun 26, 2008 at 09:54:08PM +0200, Bernhard Walle wrote: This patch removes the need of the [EMAIL PROTECTED] parameter to define a fixed offset for crashkernel reservation. That feature can be used together with a

Re: [PATCH] x86: Find offset for crashkernel reservation automatically

2008-07-14 Thread Eric W. Biederman
Bernhard Walle [EMAIL PROTECTED] writes: * Yinghai Lu [2008-07-14 00:11]: should use min_t(u64, 1ULL32, max_low_pfnPAGE_SHIFT) replace ULONG_MAX Shouldn't we use min_t(u64, ULLONG_MAX, max_low_pfnPAGE_SHIFT), i.e. should we really limit the crashkernel to a 32 bit address on a 64 bit

Re: [PATCH -mm 1/2] kexec jump -v12: kexec jump

2008-07-14 Thread huang ying
On Sat, Jul 12, 2008 at 3:21 AM, Andrew Morton [EMAIL PROTECTED] wrote: On Tue, 8 Jul 2008 10:50:51 -0400 Vivek Goyal [EMAIL PROTECTED] wrote: On Mon, Jul 07, 2008 at 11:25:22AM +0800, Huang Ying wrote: This patch provides an enhancement to kexec/kdump. It implements the following features:

Re: [PATCH] x86: Move crashkernel reservation before dma32_reserve_bootmem()

2008-07-14 Thread Vivek Goyal
On Sun, Jul 13, 2008 at 08:49:44PM +0200, Bernhard Walle wrote: From: Bernhard Walle [EMAIL PROTECTED] On a x86-64 machine (nothing special I could encounter) I had the problem that crashkernel reservation with the usual [EMAIL PROTECTED] failed. While debugging that, I encountered that

Re: [PATCH] x86: Move crashkernel reservation before dma32_reserve_bootmem()

2008-07-14 Thread Bernhard Walle
* Vivek Goyal [2008-07-14 09:30]: On Sun, Jul 13, 2008 at 08:49:44PM +0200, Bernhard Walle wrote: From: Bernhard Walle [EMAIL PROTECTED] On a x86-64 machine (nothing special I could encounter) I had the problem that crashkernel reservation with the usual [EMAIL PROTECTED] failed.

Re: [PATCH -mm 1/2] kexec jump -v12: kexec jump

2008-07-14 Thread Vivek Goyal
On Sat, Jul 12, 2008 at 11:02:17AM +1000, Nigel Cunningham wrote: Hi. On Fri, 2008-07-11 at 16:11 -0400, Vivek Goyal wrote: Hi Andrew, We can use this patchset for hibernation, but can it be a better way of doing things than what we already have, I don't know. Last time I had

Re: [PATCH -mm 2/2] kexec jump -v12: save/restore device state

2008-07-14 Thread Vivek Goyal
On Mon, Jul 07, 2008 at 11:25:24AM +0800, Huang Ying wrote: This patch implements devices state save/restore before after kexec. This patch together with features in kexec_jump patch can be used for following: - A simple hibernation implementation without ACPI support. You can kexec a

[PATCH] Use CFLAGS for compiling bin2hex

2008-07-14 Thread Bernhard Walle
This is a minor correction in the Makefile to use the CFLAGS (from configure) also for bin2hex. Signed-off-by: Bernhard Walle [EMAIL PROTECTED] --- util/Makefile |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/util/Makefile b/util/Makefile index 11d82fd..a1a78ac

Re: [ANNOUNCE] kexec-tools 2.0.0-rc1

2008-07-14 Thread Bernhard Walle
* Simon Horman [2008-07-14 21:27]: I'm happy to announce the release of kexec-tools 2.0.0-rc1. This marks the changing of the name of the tree that I maintain from kexec-tools-testing to kexec-tools. Please test this code so we can move towards releasing 2.0.0. The first impression is

Re: [PATCH] x86: Find offset for crashkernel reservation automatically

2008-07-14 Thread Yinghai Lu
On Mon, Jul 14, 2008 at 2:44 AM, Eric W. Biederman [EMAIL PROTECTED] wrote: Bernhard Walle [EMAIL PROTECTED] writes: * Yinghai Lu [2008-07-14 00:11]: should use min_t(u64, 1ULL32, max_low_pfnPAGE_SHIFT) replace ULONG_MAX Shouldn't we use min_t(u64, ULLONG_MAX, max_low_pfnPAGE_SHIFT), i.e.

Re: [PATCH] x86: Find offset for crashkernel reservation automatically

2008-07-14 Thread Eric W. Biederman
Yinghai Lu [EMAIL PROTECTED] writes: for 64bit, kdump can start from address above 4g with bzImage? I think the boot protocol was properly updated for that, it was in the original drafts. A relocatable kernel with a 64bit entry point. I do know that the 64bit code is ready to do that. Eric

Re: [PATCH] x86: Find offset for crashkernel reservation automatically

2008-07-14 Thread Eric W. Biederman
Yinghai Lu [EMAIL PROTECTED] writes: On Mon, Jul 14, 2008 at 10:30 AM, Eric W. Biederman [EMAIL PROTECTED] wrote: Yinghai Lu [EMAIL PROTECTED] writes: for 64bit, kdump can start from address above 4g with bzImage? I think the boot protocol was properly updated for that, it was in the

Re: [PATCH] x86: Find offset for crashkernel reservation automatically

2008-07-14 Thread Bernhard Walle
* Eric W. Biederman [2008-07-14 11:41]: Yinghai Lu [EMAIL PROTECTED] writes: On Mon, Jul 14, 2008 at 10:30 AM, Eric W. Biederman [EMAIL PROTECTED] wrote: Yinghai Lu [EMAIL PROTECTED] writes: for 64bit, kdump can start from address above 4g with bzImage? I think the boot protocol

Re: [PATCH] x86: Find offset for crashkernel reservation automatically

2008-07-14 Thread Eric W. Biederman
Bernhard Walle [EMAIL PROTECTED] writes: But such checks belong into kexec itself, not into the kernel. Exactly. All we should do in the kernel is bias the search for a low address. As that is more usable. Eric ___ kexec mailing list

Re: [PATCH] Use CFLAGS for compiling bin2hex

2008-07-14 Thread Simon Horman
On Mon, Jul 14, 2008 at 04:33:32PM +0200, Bernhard Walle wrote: This is a minor correction in the Makefile to use the CFLAGS (from configure) also for bin2hex. Thanks, applied. -- Horms ___ kexec mailing list kexec@lists.infradead.org

Re: [PATCH] Use CFLAGS for compiling bin2hex

2008-07-14 Thread Jeremy Kerr
$(BIN_TO_HEX): CC=$(BUILD_CC) -$(BIN_TO_HEX): CFLAGS=$(BUILD_CFLAGS) +$(BIN_TO_HEX): CFLAGS+=$(BUILD_CFLAGS) $(BIN_TO_HEX): LDFLAGS= Are you sure? CFLAGS will include stuff for $host (eg, -m64 for a 64-bit host machine). Cheers, Jeremy ___

Re: [PATCH -mm 2/2] kexec jump -v12: save/restore device state

2008-07-14 Thread Huang Ying
Hi, Vivek, On Mon, 2008-07-14 at 09:48 -0400, Vivek Goyal wrote: [...] You have cited various possible use cases of this patchset. Which is the specific feature you are planning to use? I think two features are useful: 1. Kexec based hibernation 2. Do kdump then continue Thinking more about