Re: [PATCH 10/13] x86/tdx: Convert shared memory back to private on kexec

2023-10-06 Thread Kalra, Ashish
On 10/5/2023 5:28 PM, Kirill A. Shutemov wrote: On Thu, Oct 05, 2023 at 05:01:23PM -0500, Kalra, Ashish wrote: On 10/5/2023 4:28 PM, Kirill A. Shutemov wrote: On Thu, Oct 05, 2023 at 01:41:38PM -0500, Kalra, Ashish wrote: +static void unshare_all_memory(bool unmap) +{ + unsigned long

Re: [PATCH 10/13] x86/tdx: Convert shared memory back to private on kexec

2023-10-05 Thread Kalra, Ashish
Hello Kirill, On 10/5/2023 8:13 AM, Kirill A. Shutemov wrote: TDX guests allocate shared buffers to perform I/O. It is done by allocating pages normally from the buddy allocator and converting them to shared with set_memory_decrypted(). The target kernel has no idea what memory is converted

Re: [PATCH 10/13] x86/tdx: Convert shared memory back to private on kexec

2023-10-06 Thread Kalra, Ashish
On 10/6/2023 10:11 AM, Kirill A. Shutemov wrote: On Fri, Oct 06, 2023 at 07:58:03AM -0700, Sean Christopherson wrote: On Thu, Oct 05, 2023, Kirill A. Shutemov wrote: diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 7368d254d01f..b5acf9fb4c70 100644 --- a/arch/x86/Kconfig +++

Re: [PATCH 10/13] x86/tdx: Convert shared memory back to private on kexec

2023-10-05 Thread Kalra, Ashish
On 10/5/2023 4:28 PM, Kirill A. Shutemov wrote: On Thu, Oct 05, 2023 at 01:41:38PM -0500, Kalra, Ashish wrote: +static void unshare_all_memory(bool unmap) +{ + unsigned long addr, end; + long found = 0, shared; + + /* +* Walk direct mapping and convert all shared

Re: [PATCH 1/2] x86/mm: Do not zap PMD entry mapping unaccepted memory table during kdump.

2024-02-20 Thread Kalra, Ashish
Hi Kirill, On 2/20/2024 6:42 AM, Kirill A. Shutemov wrote: On Tue, Feb 20, 2024 at 01:18:29AM +, Ashish Kalra wrote: From: Ashish Kalra During crashkernel boot only pre-allocated crash memory is presented as E820_TYPE_RAM. This can cause PMD entry mapping unaccepted memory table to be

Re: [PATCHv6 10/16] x86/tdx: Convert shared memory back to private on kexec

2024-01-29 Thread Kalra, Ashish
Hello Kirill, On 1/29/2024 4:36 AM, Kirill A. Shutemov wrote: On Mon, Jan 29, 2024 at 04:24:09AM -0600, Kalra, Ashish wrote: In case of SNP and crash/kdump case, we need to prevent the boot_ghcb being converted to shared (in snp_kexec_unshare_mem()) as the boot_ghcb is required to handle all I

Re: [PATCHv6 10/16] x86/tdx: Convert shared memory back to private on kexec

2024-01-29 Thread Kalra, Ashish
Hello Kirill, On 1/24/2024 6:55 AM, Kirill A. Shutemov wrote: TDX guests allocate shared buffers to perform I/O. It is done by allocating pages normally from the buddy allocator and converting them to shared with set_memory_decrypted(). The second kernel has no idea what memory is converted

Re: [PATCH v2 1/3] efi/x86: skip efi_arch_mem_reserve() in case of kexec.

2024-03-24 Thread Kalra, Ashish
Hello, On 3/18/2024 11:00 PM, Dave Young wrote: Hi, Added Ard in cc. On 03/18/24 at 07:02am, Ashish Kalra wrote: From: Ashish Kalra For kexec use case, need to use and stick to the EFI memmap passed from the first kernel via boot-params/setup data, hence, skip efi_arch_mem_reserve() during

Re: [PATCHv9 00/17] x86/tdx: Add kexec support

2024-04-04 Thread Kalra, Ashish
Hi Kirill, On 3/25/2024 5:38 AM, Kirill A. Shutemov wrote: The patchset adds bits and pieces to get kexec (and crashkernel) work on TDX guest. The last patch implements CPU offlining according to the approved ACPI spec change poposal[1]. It unlocks kexec with all CPUs visible in the target

Re: [PATCH v5 1/3] efi/x86: skip efi_arch_mem_reserve() in case of kexec.

2024-04-26 Thread Kalra, Ashish
On 4/26/2024 10:34 AM, Borislav Petkov wrote: On Fri, Apr 26, 2024 at 10:28:41AM -0500, Kalra, Ashish wrote: "Chained guest kexec" is when we are in a guest and kexec-ing into a new kernel and then this kernel kexecs into another and so on ... Make sure to explain your terminolo

Re: [PATCH v5 1/3] efi/x86: skip efi_arch_mem_reserve() in case of kexec.

2024-04-26 Thread Kalra, Ashish
On 4/26/2024 9:21 AM, Borislav Petkov wrote: On Wed, Apr 24, 2024 at 04:17:09PM -0500, Kalra, Ashish wrote: With SNP guest kexec and during nested guest kexec, observe the following efi memmap corruption : Before we delve any deeper here, lemme make sure I understand this correctly: * You're

Re: [PATCH v5 1/3] efi/x86: skip efi_arch_mem_reserve() in case of kexec.

2024-04-26 Thread Kalra, Ashish
On 4/26/2024 10:22 AM, Borislav Petkov wrote: On Fri, Apr 26, 2024 at 09:47:02AM -0500, Kalra, Ashish wrote: I should have mentioned *chained* guest kexec above instead of nested guest kexec. What is a "chained guest kexec" now? "Chained guest kexec" is when we are in a

Re: [PATCH v5 1/3] efi/x86: skip efi_arch_mem_reserve() in case of kexec.

2024-04-24 Thread Kalra, Ashish
Hello Boris, On 4/24/2024 9:48 AM, Borislav Petkov wrote: On Mon, Apr 15, 2024 at 11:22:58PM +, Ashish Kalra wrote: From: Ashish Kalra For kexec use case, need to use and stick to the EFI memmap passed from the first kernel via boot-params/setup data, hence, skip efi_arch_mem_reserve()

Re: [PATCH v5 1/3] efi/x86: skip efi_arch_mem_reserve() in case of kexec.

2024-04-25 Thread Kalra, Ashish
>It sounds to me like you need to go back up, to the 1ft view and explain how exactly this efi_mem_reserve() causes trouble for the kexec-ed kernel so that we can think of a proper solution, not some random hackery. The above details explain why and how efi_arch_mem_reserve() causes

Re: [PATCH v6 1/3] efi/x86: Fix EFI memory map corruption with kexec

2024-05-10 Thread Kalra, Ashish
On 5/9/2024 4:56 AM, Ruirui Yang wrote: On Fri, Apr 26, 2024 at 04:33:48PM +, Ashish Kalra wrote: From: Ashish Kalra With SNP guest kexec observe the following efi memmap corruption : [0.00] efi: EFI v2.7 by EDK II [0.00] efi: SMBIOS=0x7e33f000 SMBIOS 3.0=0x7e33d000

Re: [PATCH v4 0/4] x86/snp: Add kexec support

2024-05-02 Thread Kalra, Ashish
Hello Alexander, On 5/2/2024 7:01 AM, Alexander Graf wrote: Hey Ashish, On 09.04.24 22:42, Ashish Kalra wrote: From: Ashish Kalra The patchset adds bits and pieces to get kexec (and crashkernel) work on SNP guest. With this patch set (and similar for the TDX one), you enable the typical