Re: [kexec-tools][PATCH] ARM: Fix add_buffer_phys_virt() align issue

2024-04-26 Thread Simon Horman
On Wed, Apr 24, 2024 at 02:17:27PM +0200, Alexander Kanavin wrote: > From: Haiqing Bai > > When "CONFIG_ARM_LPAE" is enabled,3 level page table > is used by MMU, the "SECTION_SIZE" is defined with > (1 << 21), but 'add_buffer_phys_virt()' hardcode this > to (1 << 20). > > Suggested-By:

Re: [PATCH] Fix incorrect Free Software Foundation address in the license

2024-04-23 Thread Simon Horman
On Mon, Apr 08, 2024 at 02:37:55PM +0800, Coiby Xu wrote: > As detected by rpmlint, > kexec-tools.x86_64: E: incorrect-fsf-address > /usr/share/licenses/kexec-tools/COPYING > The Free Software Foundation address in this file seems to be outdated or > misspelled. Ask upstream to update

Re: [PATCH] crashdump-x86.c:Add a check for the crash kernel range in exclude_region()

2024-04-23 Thread Simon Horman
On Thu, Mar 21, 2024 at 07:33:17PM +0800, chenhaixiang wrote: > In some cases, such as start < mstart < mend < end when exclude_region(), > this results in crash_memory_range[i].end becoming less than > crash_memory_range[i].start, leading to incorrect address ranges. > Adding a range check should

Re: [PATCH] crash: Fix spelling mistake: "crahskernel" -> "crashkernel"

2024-04-23 Thread Simon Horman
On Fri, Apr 19, 2024 at 09:52:06AM +0100, Colin Ian King wrote: > There is a spelling mistake in a pr_warn message. Fix it. > > Signed-off-by: Colin Ian King Reviewed-by: Simon Horman ___ kexec mailing list kexec@lists.infradead

Re: [PATCH] util_lib/elf_info.c: fix a warning

2024-03-22 Thread Simon Horman
On Thu, Mar 21, 2024 at 03:30:37PM +0800, Baoquan He wrote: > There's a incorrect array operation in function scan_vmcoreinfo(), it > will cause below warning message. > > --- > util_lib/elf_info.c: In function ‘scan_vmcoreinfo’: > util_lib/elf_info.c:360:43: warning: writing

Re: [PATCH] kexec_file: add kexec_file flag to support debug printing

2024-03-15 Thread Simon Horman
On Fri, Mar 15, 2024 at 04:11:50PM +0800, Baoquan He wrote: > On 11/27/23 at 01:32pm, Simon Horman wrote: > > On Tue, Nov 14, 2023 at 11:20:30PM +0800, Baoquan He wrote: > > > This add KEXEC_FILE_DEBUG to kexec_file_flags so that it can be passed > > > t

Re: [PATCH kexec-tools] workflow: update to use checkout@v4

2024-02-07 Thread Simon Horman
On Fri, Feb 02, 2024 at 09:55:41AM +0100, Simon Horman wrote: > Update to use checkout@v4. > > This addresses the following warning that appears in GitHub runs: > > "Node.js 16 actions are deprecated. Please update the following actions > to use Node.js 20: action

Re: [PATCH] kexec-tools: purgatory: fix build on `binutils-2.42`

2024-02-02 Thread Simon Horman
On Fri, Feb 02, 2024 at 12:16:38PM +0800, Baoquan He wrote: > On 02/02/24 at 11:01am, Coiby Xu wrote: > > Hi, > > > > FYI, before this patch, Michel already sent "[PATCH] Fix building on x86_64 > > with binutils 2.41" to address the same issue. Currently I almost know > > nothing about > >

[PATCH kexec-tools] workflow: update to use checkout@v4

2024-02-02 Thread Simon Horman
tions-transitioning-from-node-16-to-node-20/. Link: https://github.com/horms/kexec-tools/actions/runs/7753454923 Signed-off-by: Simon Horman --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml

Re: [PATCH] Fix building on x86_64 with binutils 2.41

2024-02-02 Thread Simon Horman
On Tue, Jan 30, 2024 at 04:14:31AM -0600, Michel Lind via B4 Relay wrote: > From: Michel Lind > > Newer versions of the GNU assembler (observed with binutils 2.41) will > complain about the ".arch i386" in files assembled with "as --64", > with the message "Error: 64bit mode not supported on

Re: [PATCH -next] kexec: Remove duplicated include in crash_reserve.c

2024-01-26 Thread Simon Horman
On Fri, Jan 26, 2024 at 08:44:49AM +0800, Yang Li wrote: > The header files kexec.h is included twice in crash_reserve.c, > so one inclusion can be removed. > > Signed-off-by: Yang Li Reviewed-by: Simon Horman ___ kexec mailin

Re: [PATCH] kexec: don't use kexec_file_load on XEN

2024-01-25 Thread Simon Horman
On Tue, Jan 16, 2024 at 06:14:31PM +0100, Jiri Bohac wrote: > Since commit 29fe5067ed07 ("kexec: make -a the default") > kexec tries the kexec_file_load syscall first and only falls back to > kexec_load on > selected error codes. > > This effectively breaks kexec on XEN, unless -c is pecified to

[ANNOUNCE] kexec-tools 2.0.28

2024-01-11 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.28. This is a feature release coinciding with the release of v6.7 of the Linux Kernel. This release can be downloaded from kernel.org: http://kernel.org/pub/linux/utils/kernel/kexec/kexec-tools-2.0.28.tar.xz

[ANNOUNCE] kexec-tools 2.0.28-rc1

2024-01-03 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.28-rc1. This is an incremental feature pre-release. So long as no serious problems arise I intend to release kexec-tools 2.0.28 in a weeks time. Testing of 2.0.28-rc1 would be greatly appreciated. I do not have any outstanding

[ANNOUNCE] kexec-tools v2.0.28 preparation

2023-12-18 Thread Simon Horman
Hi all, I am planning to release kexec-tools v2.0.28 in the next two weeks to roughly coincide with the release of the v6.7 kernel. I would like to ask interested parties to send any patches they would like included in v2.0.28 within one week so they can be considered for inclusion in an rc

Re: [PATCH] LoongArch: Load vmlinux.efi to the link address

2023-12-02 Thread Simon Horman
On Sat, Dec 02, 2023 at 10:03:29PM +0800, Huacai Chen wrote: > On Sat, Dec 2, 2023 at 8:46 PM Simon Horman wrote: > > > > On Sat, Dec 02, 2023 at 08:30:27PM +0800, Huacai Chen wrote: > > > On Sat, Dec 2, 2023 at 6:11 PM WANG Rui wrote: > > > > > > >

Re: [PATCH] LoongArch: Load vmlinux.efi to the link address

2023-12-02 Thread Simon Horman
On Sat, Dec 02, 2023 at 08:30:27PM +0800, Huacai Chen wrote: > On Sat, Dec 2, 2023 at 6:11 PM WANG Rui wrote: > > > > > On Fri, Nov 24, 2023 at 11:46:58PM +0800, WANG Rui wrote: > > > > Currently, kexec loads vmlinux.efi to address 0 instead of the link > > > > address. This causes kexec to fail

Re: [PATCH v2] LoongArch: Load vmlinux.efi to the link address

2023-12-01 Thread Simon Horman
On Fri, Dec 01, 2023 at 10:54:49PM +0800, Huacai Chen wrote: > Hi, Simon, > > On Fri, Dec 1, 2023 at 10:06 PM Simon Horman wrote: > > > > On Wed, Nov 29, 2023 at 12:15:17PM +0800, Huacai Chen wrote: > > > Hi, all, > > > > > > On Tue, Nov 28, 202

Re: [PATCH v2] LoongArch: Load vmlinux.efi to the link address

2023-12-01 Thread Simon Horman
On Wed, Nov 29, 2023 at 12:15:17PM +0800, Huacai Chen wrote: > Hi, all, > > On Tue, Nov 28, 2023 at 2:27 PM WANG Rui wrote: > > > > Hi, > > > > On Mon, Nov 27, 2023 at 10:36 AM RuiRui Yang wrote: > > > > > > On Mon, 27 Nov 2023 at 09:53, RuiRui Yang wrote: > > > > > > > > On Sat, 25 Nov 2023

Re: [PATCH] LoongArch: Fix an issue with relocatable vmlinux

2023-11-27 Thread Simon Horman
On Fri, Nov 24, 2023 at 04:54:10PM +0800, WANG Rui wrote: > Normally vmlinux for LoongArch is of ET_EXEC type, while if built with > CONFIG_RELOCATABLE (this is PIE) and Clang, it will be of ET_DYN type. > Meanwhile, physical address field of segments in vmlinux has actually > the same value as

Re: [PATCH] m68k: fix getrandom() use with uclibc

2023-11-27 Thread Simon Horman
On Sat, Apr 22, 2023 at 11:59:04AM +0200, Laurent Vivier wrote: > With uclibc, getrandom() is only defined with _GNU_SOURCE, fix that: > > kexec/arch/m68k/bootinfo.c: In function 'bootinfo_add_rng_seed': > kexec/arch/m68k/bootinfo.c:231:13: warning: implicit declaration of function >

Re: [PATCH] lzma: Relax memory limit for lzma decompressor

2023-11-27 Thread Simon Horman
On Sat, Nov 25, 2023 at 03:26:43PM +0800, WANG Rui wrote: > The kexec cannot load LZMA compressed vmlinuz.efi on LoongArch. > > Try LZMA decompression. > lzma_decompress_file: read on /tmp/Image4yyfhM of 65536 bytes failed > pez_prepare: decompressed size 8563960 > pez_prepare: done >

Re: [PATCH] LoongArch: Load vmlinux.efi to the link address

2023-11-27 Thread Simon Horman
On Fri, Nov 24, 2023 at 11:46:58PM +0800, WANG Rui wrote: > Currently, kexec loads vmlinux.efi to address 0 instead of the link > address. This causes kexec to fail to boot the new vmlinux.efi on qemu. > > pei_loongarch_load: kernel_segment: > pei_loongarch_load:

Re: [PATCH] kexec_file: add kexec_file flag to support debug printing

2023-11-27 Thread Simon Horman
On Tue, Nov 14, 2023 at 11:20:30PM +0800, Baoquan He wrote: > This add KEXEC_FILE_DEBUG to kexec_file_flags so that it can be passed > to kernel when '-d' is added with kexec_file_load interface. With that > flag enabled, kernel can enable the debugging message printing. > > Signed-off-by:

Re: [PATCH] kexec: ppc64: print help to stdout instead of stderr

2023-11-16 Thread Simon Horman
On Thu, Nov 16, 2023 at 02:11:37PM +0530, Aditya Gupta wrote: > Currently 'kexec --help' on powerpc64 prints the generic help/usage to > stdout, and the powerpc64 specific options to stderr > > That is, if the stdout of 'kexec --help' is redirected to some file, > some of the help options will

Re: [PATCH kexec-tools] workflow: update to Ubuntu 22.04

2023-10-18 Thread Simon Horman
On Wed, Oct 11, 2023 at 10:59:33AM +0200, Simon Horman wrote: > Bump workflow to use latest LTS release. > > Signed-off-by: Simon Horman FTR, this has been applied. ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.or

[PATCH kexec-tools] workflow: update to Ubuntu 22.04

2023-10-11 Thread Simon Horman
Bump workflow to use latest LTS release. Signed-off-by: Simon Horman --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 4c6e9d730488..d0007f14b274 100644 --- a/.github/workflows

Re: [PATCH] kexec/loongarch64: fix 'make dist' file loss issue

2023-10-11 Thread Simon Horman
On Wed, Oct 11, 2023 at 11:56:21AM +0800, Ming Wang wrote: > The Makefile omits the iomem.h file, causing the archive file > generated by 'make dist' to lose iomem.h. This patch is used to > fix this problem. > > Signed-off-by: Ming Wang Thanks, applied.

Re: [kexec-tools] Archive file is missed iomem.h file under loongarch architecture.

2023-10-10 Thread Simon Horman
On Mon, Oct 09, 2023 at 05:47:43PM +0800, Ming Wang wrote: > Hi,  maintainers, > > > I get the kexec-tools 2.0.27 from > http://kernel.org/pub/linux/utils/kernel/kexec/kexec-tools-2.0.27.tar.gz,  > > But I noticed that the kexec-tools-2.0.27/kexec/arch/loongarch/iomem.h file > was missing

Re: [PATCH 1/1] kexec: provide a memfd_create() wrapper if not present in libc

2023-10-04 Thread Simon Horman
On Sat, Sep 23, 2023 at 06:46:06PM +0200, Julien Olivain wrote: > Commit 714fa115 "kexec/arm64: Simplify the code for zImage" introduced > a use of the memfd_create() system call, included in version > kexec-tools v2.0.27. > > This system call was introduced in kernel commit [1], first included >

Re: [PATCH v3 0/6] crashdump: Kernel handling of CPU and memory hot un/plug

2023-10-04 Thread Simon Horman
On Wed, Sep 27, 2023 at 02:11:30PM -0400, Eric DeVolder wrote: > When the kdump service is loaded, if a CPU or memory is hot > un/plugged, the crash elfcorehdr, which describes the CPUs and memory > in the system, must also be updated, else the resulting vmcore is > inaccurate (eg. missing either

Re: [PATCH v2] kexec: update manpage with explicit mention of clean kexec

2023-10-04 Thread Simon Horman
On Wed, Sep 20, 2023 at 05:29:27PM +0530, Hari Bathini wrote: > While the manpage does mention about kexec boot with a clean shutdown, > it is not explicit about it. Make it explicit. > > Signed-off-by: Hari Bathini Thanks, applied. ___ kexec mailing

Re: [PATCH 0/7] Kexec-tools: Improve RISC-V port

2023-09-20 Thread Simon Horman
On Fri, Sep 15, 2023 at 11:50:06AM +0800, Song Shuai wrote: > Hi, > > This series is created to improve RISC-V port of kexec-tools, > and is based on the horms/kexec-tools:build-test-riscv-v2 branch. In my mind the big question is how to move RISC-V support from that branch, to being merged into

Re: [PATCH -next] crash_core: Remove duplicated include in crash_core.c

2023-09-20 Thread Simon Horman
On Fri, Sep 15, 2023 at 01:58:44PM +0800, Yang Li wrote: > ./kernel/crash_core.c: linux/kexec.h is included more than once. > > Signed-off-by: Yang Li FWIIW, this seems to have been added recently, by 926f75c8a5ab ("Add linux-next specific files for 20230920") Review

Re: [PATCH v1 0/2] zboot: enable kexec_load for zboot kernel images

2023-09-20 Thread Simon Horman
On Thu, Sep 14, 2023 at 04:49:58PM +0800, Dave Young wrote: > The current kexec-tools only support kexec_file_load for zboot kernel > images on arm64. > > This series tweak a bit of the code so kexec_load can also load zboot > images on both arm64 and loongarch. Thanks, applied.

Re: [PATCH] kexec: update manpage with explicit mention of clean kexec

2023-09-20 Thread Simon Horman
On Mon, Sep 11, 2023 at 12:04:08PM +0530, Hari Bathini wrote: > > > On 28/08/23 3:12 pm, Baoquan He wrote: > > On 08/28/23 at 09:48am, Simon Horman wrote: > > > On Mon, Aug 28, 2023 at 11:46:14AM +0530, Hari Bathini wrote: > > > > Any comments on

Re: [kexec-tools PATCH] build: fix tarball creation

2023-09-01 Thread Simon Horman
On Mon, Aug 28, 2023 at 11:58:15AM +0200, Leah Neukirchen wrote: > The fix in 41b77edac did not work, bsdtar still complains about > "hardlink pointing to itself". > > Simplify the code instead: since the staging directory contains > exactly the files we want, just package it as a whole. > >

[ANNOUNCE] kexec-tools 2.0.27

2023-08-28 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.27. This is a feature release coinciding with the release of v6.5 of the Linux Kernel. This release can be downloaded from kernel.org: http://kernel.org/pub/linux/utils/kernel/kexec/kexec-tools-2.0.27.tar.xz

Re: [PATCH] kexec: update manpage with explicit mention of clean kexec

2023-08-28 Thread Simon Horman
On Mon, Aug 28, 2023 at 11:46:14AM +0530, Hari Bathini wrote: > Any comments on this, please.. Hi Hari, Sorry, I had missed this. > On 07/07/23 10:59 am, Hari Bathini wrote: > > While the manpage does mention about kexec boot with a clean shutdown, > > it is not explicit about it. Make it

[ANNOUNCE] kexec-tools 2.0.27-rc1

2023-08-18 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.27-rc1. This is an incremental feature pre-release. So long as no serious problems arise I intend to release kexec-tools 2.0.27 in a weeks time. Testing of 2.0.27-rc1 would be greatly appreciated. I do not have any outstanding

Re: [ANNOUNCE] kexec-tools v2.0.27 preparation

2023-08-15 Thread Simon Horman
On Mon, Aug 14, 2023 at 11:19:07AM +0800, Coiby Xu wrote: > Hi Sourabh, > > On Mon, Aug 14, 2023 at 08:17:34AM +0530, Sourabh Jain wrote: > > Hello Simon, > > > > Can we include below fix? > >

[ANNOUNCE] kexec-tools v2.0.27 preparation

2023-08-11 Thread Simon Horman
Hi all, I am planning to release kexec-tools v2.0.27 in the next two weeks to roughly coincide with the release of the v6.5 kernel. I would like to ask interested parties to send any patches they would like included in v2.0.27 within one week so they can be considered for inclusion in an rc

Re: [PATCHv7 0/5] arm64: zboot support

2023-08-11 Thread Simon Horman
On Thu, Aug 03, 2023 at 10:41:47AM +0800, Pingfan Liu wrote: > From: root > > As more complicated capsule kernel format occurs like zboot, where the > compressed kernel is stored as a payload. The straight forward > decompression can not meet the demand. > > As the first step, on aarch64,

Re: [PATCHv7 1/5] kexec/arm64: Simplify the code for zImage

2023-08-10 Thread Simon Horman
On Mon, Aug 07, 2023 at 09:26:49PM +0800, Dave Young wrote: > On Mon, 7 Aug 2023 at 21:23, Simon Horman wrote: > > > > On Thu, Aug 03, 2023 at 10:41:48AM +0800, Pingfan Liu wrote: > > > Inside zimage_probe(), it uncompresses the kernel and performs some > > &

Re: [PATCHv7 3/5] kexec/zboot: Add arch independent zboot support

2023-08-07 Thread Simon Horman
On Thu, Aug 03, 2023 at 10:41:50AM +0800, Pingfan Liu wrote: > From: Jeremy Linton > > The linux kernel CONFIG_ZBOOT option creates > self decompressing PE kernel images. So this means > that kexec should have a generic understanding of > the format which may be used by multiple arches. > > So

Re: [PATCHv7 1/5] kexec/arm64: Simplify the code for zImage

2023-08-07 Thread Simon Horman
On Thu, Aug 03, 2023 at 10:41:48AM +0800, Pingfan Liu wrote: > Inside zimage_probe(), it uncompresses the kernel and performs some > check, similar to image_probe(). Taking a close look, the uncompressing > has already executed before the image probe is called. What is missing > here is to provide

Re: [PATCHv6 3/5] kexec/zboot: Add arch independent zboot support

2023-08-03 Thread Simon Horman
On Thu, Aug 03, 2023 at 10:37:10AM +0800, Pingfan Liu wrote: > On Wed, Aug 2, 2023 at 8:33 PM Simon Horman wrote: > > > > On Wed, Aug 02, 2023 at 02:17:57PM +0200, Simon Horman wrote: > > > On Wed, Aug 02, 2023 at 02:16:33PM +0200, Simon Horman wrote: > > > >

Re: [PATCHv6 3/5] kexec/zboot: Add arch independent zboot support

2023-08-02 Thread Simon Horman
On Wed, Aug 02, 2023 at 02:17:57PM +0200, Simon Horman wrote: > On Wed, Aug 02, 2023 at 02:16:33PM +0200, Simon Horman wrote: > > On Wed, Aug 02, 2023 at 05:53:59PM +0800, Pingfan Liu wrote: > > > Hi Simon, > > > > > > Thanks for the try. Please see the comme

Re: [PATCHv6 3/5] kexec/zboot: Add arch independent zboot support

2023-08-02 Thread Simon Horman
On Wed, Aug 02, 2023 at 02:16:33PM +0200, Simon Horman wrote: > On Wed, Aug 02, 2023 at 05:53:59PM +0800, Pingfan Liu wrote: > > Hi Simon, > > > > Thanks for the try. Please see the comment below. > > > > On Tue, Aug 1, 2023 at 3:00 PM Simon Horman wrote: >

Re: [PATCHv6 3/5] kexec/zboot: Add arch independent zboot support

2023-08-02 Thread Simon Horman
On Wed, Aug 02, 2023 at 05:53:59PM +0800, Pingfan Liu wrote: > Hi Simon, > > Thanks for the try. Please see the comment below. > > On Tue, Aug 1, 2023 at 3:00 PM Simon Horman wrote: > > > > On Mon, Jul 24, 2023 at 10:21:40AM +0800, Pingfan Liu wrote

Re: [PATCHv6 3/5] kexec/zboot: Add arch independent zboot support

2023-08-01 Thread Simon Horman
On Mon, Jul 24, 2023 at 10:21:40AM +0800, Pingfan Liu wrote: > From: Jeremy Linton > > The linux kernel CONFIG_ZBOOT option creates > self decompressing PE kernel images. So this means > that kexec should have a generic understanding of > the format which may be used by multiple arches. > > So

[PATCH] kexec: Avoid calculating array size twice

2023-05-25 Thread Simon Horman
. Signed-off-by: Simon Horman --- kernel/kexec_file.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c index f989f5f1933b..3f5677679744 100644 --- a/kernel/kexec_file.c +++ b/kernel/kexec_file.c @@ -867,6 +867,7 @@ static int

Re: [PATCHv2 1/6] kexec: Change the image probe's prototype

2023-05-24 Thread Simon Horman
On Tue, May 16, 2023 at 03:31:19PM +0800, Pingfan Liu wrote: > As more complicated kernel format occurs such as zboot, where the > compressed kernel is stored as a payload. The straight forward > decompression can not meet the demand. > > A new image probe method is expected to read in the kernel

Re: [PATCH] parisc: kexec: include reboot.h

2023-05-09 Thread Simon Horman
On Tue, May 09, 2023 at 05:01:42PM +0800, Baoquan He wrote: > On 05/09/23 at 09:01am, Simon Horman wrote: > > Include reboot.h in machine_kexec.c for declaration of > > machine_crash_shutdown and machine_shutdown. > > > > gcc-12 with W=1 reports: > > > > a

[PATCH] parisc: kexec: include reboot.h

2023-05-09 Thread Simon Horman
*regs) | ^~ arch/parisc/kernel/kexec.c:61:6: warning: no previous prototype for 'machine_shutdown' [-Wmissing-prototypes] 61 | void machine_shutdown(void) | ^~~~ No functional changes intended. Compile tested only. Signed-off-by: Simon

Re: [PATCH v6 07/14] x86: Secure Launch kernel early boot stub

2023-05-05 Thread Simon Horman
On Fri, May 05, 2023 at 02:58:28PM -0400, Ross Philipson wrote: > On 5/5/23 13:47, Simon Horman wrote: > > On Thu, May 04, 2023 at 02:50:16PM +, Ross Philipson wrote: ... > > > +asmlinkage __visible void sl_check_region(void *base, u32 size) > > > +{ > > >

Re: [PATCH v6 12/14] x86: Secure Launch late initcall platform module

2023-05-05 Thread Simon Horman
On Thu, May 04, 2023 at 02:50:21PM +, Ross Philipson wrote: > From: "Daniel P. Smith" > > The Secure Launch platform module is a late init module. During the > init call, the TPM event log is read and measurements taken in the > early boot stub code are located. These measurements are

Re: [PATCH v6 09/14] x86: Secure Launch SMP bringup support

2023-05-05 Thread Simon Horman
On Thu, May 04, 2023 at 02:50:18PM +, Ross Philipson wrote: > On Intel, the APs are left in a well documented state after TXT performs > the late launch. Specifically they cannot have #INIT asserted on them so > a standard startup via INIT/SIPI/SIPI cannot be performed. Instead the > early SL

Re: [PATCH v6 08/14] x86: Secure Launch kernel late boot stub

2023-05-05 Thread Simon Horman
On Thu, May 04, 2023 at 02:50:17PM +, Ross Philipson wrote: > The routine slaunch_setup is called out of the x86 specific setup_arch > routine during early kernel boot. After determining what platform is > present, various operations specific to that platform occur. This > includes finalizing

Re: [PATCH v6 07/14] x86: Secure Launch kernel early boot stub

2023-05-05 Thread Simon Horman
On Thu, May 04, 2023 at 02:50:16PM +, Ross Philipson wrote: > The Secure Launch (SL) stub provides the entry point for Intel TXT (and > later AMD SKINIT) to vector to during the late launch. The symbol > sl_stub_entry is that entry point and its offset into the kernel is > conveyed to the

Re: [PATCH v6 06/14] x86: Add early SHA support for Secure Launch early measurements

2023-05-05 Thread Simon Horman
On Thu, May 04, 2023 at 02:50:15PM +, Ross Philipson wrote: > From: "Daniel P. Smith" > > The SHA algorithms are necessary to measure configuration information into > the TPM as early as possible before using the values. This implementation > uses the established approach of #including the

Re: [PATCH v6 05/14] x86: Secure Launch main header file

2023-05-05 Thread Simon Horman
On Thu, May 04, 2023 at 02:50:14PM +, Ross Philipson wrote: > Introduce the main Secure Launch header file used in the early SL stub > and the early setup code. > > Signed-off-by: Ross Philipson > --- > include/linux/slaunch.h | 513 > > 1

Re: [PATCH v6 04/14] x86: Secure Launch Resource Table header file

2023-05-05 Thread Simon Horman
On Thu, May 04, 2023 at 02:50:13PM +, Ross Philipson wrote: > Introduce the Secure Launch Resource Table which forms the formal > interface between the pre and post launch code. > > Signed-off-by: Ross Philipson > --- > include/linux/slr_table.h | 270 >

Re: [PATCH v6 02/14] Documentation/x86: Secure Launch kernel documentation

2023-05-05 Thread Simon Horman
On Thu, May 04, 2023 at 02:50:11PM +, Ross Philipson wrote: > Introduce background, overview and configuration/ABI information > for the Secure Launch kernel feature. > > Signed-off-by: Daniel P. Smith > Signed-off-by: Ross Philipson Hi Ross and Daniel, some minor nits from my side. >

Re: [PATCH 3/5] arm64: change the prototype of image probe function

2023-05-05 Thread Simon Horman
On Fri, May 05, 2023 at 10:54:35AM +0800, Pingfan Liu wrote: > Changing the aarch64 probe's prototype from > typedef int (probe_t)(const char *kernel_buf, off_t kernel_size); > to > typedef int (probe_t)(const char *kernel_buf, off_t kernel_size, struct > kexec_info *info); > >

Re: [PATCH 1/5] kexec: Adding missing free for kernel_buf

2023-05-05 Thread Simon Horman
On Fri, May 05, 2023 at 10:54:33AM +0800, Pingfan Liu wrote: > slurp_decompress_file() allocates memory but nowhere to free it. > Adding that missing free. Hi Pingfan, There seem to be: a) other places where slurp_decompress_file() is called and; b) other places where do_kexec_file_load()

[PATCH] m68k: kexec: include reboot.h

2023-04-21 Thread Simon Horman
-by: Simon Horman --- arch/m68k/kernel/machine_kexec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/m68k/kernel/machine_kexec.c b/arch/m68k/kernel/machine_kexec.c index 206f84983120..739875540e89 100644 --- a/arch/m68k/kernel/machine_kexec.c +++ b/arch/m68k/kernel/machine_kexec.c

Re: [PATCH v9 4/4] tpm/kexec: Duplicate TPM measurement log in of-tree for kexec

2023-04-18 Thread Simon Horman
On Tue, Apr 18, 2023 at 09:44:09AM -0400, Stefan Berger wrote: > The memory area of the TPM measurement log is currently not properly > duplicated for carrying it across kexec when an Open Firmware > Devicetree is used. Therefore, the contents of the log get corrupted. > Fix this for the

[PATCH] arm64: kexec: include reboot.h

2023-04-18 Thread Simon Horman
) No functional changes intended. Compile tested only. Signed-off-by: Simon Horman --- arch/arm64/kernel/machine_kexec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c index 54f8e2d081c4..078910db77a4 100644 --- a/arch/arm64

Re: [PATCH -next v4 1/2] riscv: kdump: Implement crashkernel=X,[high,low]

2023-04-11 Thread Simon Horman
gh memory above DMA zone range > by explicitly passing "crashkernel=X,high"; or reserve a memory range > below 4G with "crashkernel=X,low". > > Signed-off-by: Chen Jiahao > Acked-by: Guo Ren > Reviewed-by: Zhen Lei Reviewed-by: Simon Horman

Re: [PATCH -next v3 0/2] support allocating crashkernel above 4G explicitly on riscv

2023-04-07 Thread Simon Horman
On Fri, Apr 07, 2023 at 06:02:04AM +0800, Chen Jiahao wrote: > On riscv, the current crash kernel allocation logic is trying to > allocate within 32bit addressible memory region by default, if > failed, try to allocate without 4G restriction. > > In need of saving DMA zone memory while allocating

Re: [PATCH -next v3 2/2] docs: kdump: Update the crashkernel description for riscv

2023-04-07 Thread Simon Horman
r description accordingly. > > Signed-off-by: Chen Jiahao Reviewed-by: Simon Horman ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH -next v3 1/2] riscv: kdump: Implement crashkernel=X,[high,low]

2023-04-07 Thread Simon Horman
On Fri, Apr 07, 2023 at 06:02:05AM +0800, Chen Jiahao wrote: > On riscv, the current crash kernel allocation logic is trying to > allocate within 32bit addressible memory region by default, if > failed, try to allocate without 4G restriction. > > In need of saving DMA zone memory while allocating

Re: [PATCH -next v3 1/2] riscv: kdump: Implement crashkernel=X,[high,low]

2023-04-07 Thread Simon Horman
On Fri, Apr 07, 2023 at 05:06:24PM +0800, Guo Ren wrote: > On Thu, Apr 6, 2023 at 10:06 PM Chen Jiahao wrote: > > > > On riscv, the current crash kernel allocation logic is trying to > > allocate within 32bit addressible memory region by default, if > > failed, try to allocate without 4G

Re: [PATCH v4 1/2] kexec: Support purgatories with .text.hot sections

2023-03-30 Thread Simon Horman
On Mon, Mar 27, 2023 at 05:06:53PM +0200, Ricardo Ribalda wrote: > Clang16 links the purgatory text in two sections: > > [ 1] .text PROGBITS 0040 >11a1 AX 0 0 16 > [ 2] .rela.textRELA

Re: [PATCH -next 1/2] riscv: kdump: Implement crashkernel=X,[high,low]

2023-03-20 Thread Simon Horman
gh memory above DMA zone range > by explicitly passing "crashkernel=X,high"; or reserve a memory range > below 4G with "crashkernel=X,low". > > Signed-off-by: Chen Jiahao Some minor nits, but I don't think there is any need to respin for them. Reviewed-by: Simon Hor

Re: [PATCH -next 2/2] docs: kdump: Update the crashkernel description for riscv

2023-03-20 Thread Simon Horman
r description accordingly. > > Signed-off-by: Chen Jiahao Reviewed-by: Simon Horman ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v2 2/2] LoongArch: kdump: Set up kernel image segment

2023-03-08 Thread Simon Horman
On Sat, Mar 04, 2023 at 11:09:11AM +0800, Youling Tang wrote: > On LoongArch, we can use the same kernel image as 1st kernel when > 3f89765d622 ("LoongArch: kdump: Add single kernel image implementation") > is merged, but we have to modify the entry point as well as segments > addresses in the

Re: [PATCH v2 1/2] kexec: __NR_kexec_file_load is set to undefined on LoongArch

2023-03-08 Thread Simon Horman
On Sat, Mar 04, 2023 at 11:09:10AM +0800, Youling Tang wrote: > The initial reason is that after the merger of 29fe5067ed07 ("kexec: make > -a the default"), kexec cannot be used on LoongArch architectures. We need > to add "-c" for normal use. The current kexec_file_load system call is not >

Re: [PATCH v4] arm64: kdump: simplify the reservation behaviour of crashkernel=,high

2023-03-08 Thread Simon Horman
s clearer and > simpler. > > Note: On arm64, the high and low memory boudary could be 1G if it's RPi4 > system, or 4G if other normal systems. > > Signed-off-by: Baoquan He Reviewed-by: Simon Horman ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v2 2/2] kexec: Remove unnecessary arch_kexec_kernel_image_load()

2023-03-08 Thread Simon Horman
ge_load() and make > kexec_image_load_default() static. > > No functional change intended. > > Signed-off-by: Bjorn Helgaas Reviewed-by: Simon Horman ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v2 1/2] x86/kexec: Remove unnecessary arch_kexec_kernel_image_load()

2023-03-08 Thread Simon Horman
;fops || !image->fops->load) > return ERR_PTR(-ENOEXEC); > return image->fops->load(image, image->kernel_buf, ...) > > Remove the x86-specific version and use the generic > arch_kexec_kernel_image_load(). No

Re: [PATCH] ppc64: Add elf-ppc64 file types/options and an arch specific flag to man page

2023-03-03 Thread Simon Horman
On Wed, Mar 01, 2023 at 03:58:19AM -0500, Gautam Menghani wrote: > Document the elf-ppc64 file options and the "--dt-no-old-root" arch > specific flag in the man page. > > Signed-off-by: Gautam Menghani Thanks, applied. ___ kexec mailing list

Re: [PATCH v2] x86: add devicetree support

2023-02-23 Thread Simon Horman
On Thu, Feb 23, 2023 at 07:01:07AM +0100, Julian Winkler wrote: > Since linux kernel has dropped support for simple firmware interface > (SFI), the only way of boot newer versions on intel MID platform is > using devicetree > > Signed-off-by: Julian Winkler > --- > V2: added Signed-off-by to

Re: [PATCH] x86: add devicetree support

2023-02-20 Thread Simon Horman
On Sun, Feb 19, 2023 at 11:18:13AM +0100, Julian Winkler wrote: > Since linux kernel has dropped support for simple firmware interface > (SFI), the only way of boot newer versions on intel MID platform is > using devicetree Thanks Julian, in general this patch looks fine to me. Could I ask you

Re: [PATCH] kexec: make -a the default

2023-02-07 Thread Simon Horman
On Fri, Feb 03, 2023 at 12:10:18AM +0100, Ahelenia Ziemiańska wrote: > AFAICT, there's no downside to this, and running into this each time > I want to kexec (and, presumably, a significant chunk of the population, > since lockdown is quite popular) on some machines, > then going to the manual,

Re: [PATCH] ppc64: add --reuse-cmdline parameter support

2023-02-07 Thread Simon Horman
On Wed, Feb 01, 2023 at 02:23:31PM +0530, Sourabh Jain wrote: > An option to copy the command line arguments from running kernel > to kexec'd kernel. This option works for both kexec and kdump. > > In case --append= or --command-line= is provided along > with --reuse-cmdline parameter then args

Re: [PATCH 1/2] arm64: kdump: simplify the reservation behaviour of crashkernel=,high

2023-01-20 Thread Simon Horman
On Tue, Jan 17, 2023 at 11:49:20AM +0800, Baoquan He wrote: > On arm64, reservation for 'crashkernel=xM,high' is taken by searching for > suitable memory region up down. If the 'xM' of crashkernel high memory > is reserved from high memory successfully, it will try to reserve > crashkernel low

Re: [PATCH 2/2] arm64/kdump: add code comments for crashkernel reservation cases

2023-01-20 Thread Simon Horman
On Tue, Jan 17, 2023 at 11:49:21AM +0800, Baoquan He wrote: > This will help understand codes on crashkernel reservations on arm64. FWIIW, I think you can fold this into the first patch. And, although I have no good idea at this moment, I do wonder if the logic can be simplified - I for one

[ANNOUNCE] kexec-tools 2.0.26

2022-12-21 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.26. This is a feature release coinciding with the release of v6.1 of the Linux Kernel. This release can be downloaded from kernel.org: http://kernel.org/pub/linux/utils/kernel/kexec/kexec-tools-2.0.26.tar.xz

[ANNOUNCE] kexec-tools 2.0.26-rc1

2022-12-07 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.26-rc1. This is an incremental feature pre-release. So long as no serious problems arise I intend to release kexec-tools 2.0.26 in a weeks time. Testing of 2.0.26-rc1 would be greatly appreciated. I do not have any outstanding

[ANNOUNCE] kexec-tools v2.0.26 preparation

2022-11-30 Thread Simon Horman
Hi all, I am planning to release kexec-tools v2.0.26 in the next two weeks to roughly coincide with the release of the v6.1 kernel. I would like to ask interested parties to send any patches they would like included in v2.0.26 within one week so they can be considered for inclusion in an rc

Re: [PATCH kexec-tools v3] m68k: pass rng seed via BI_RNG_SEED

2022-11-18 Thread Simon Horman
On Mon, Nov 14, 2022 at 04:43:03PM +0100, Jason A. Donenfeld wrote: > In order to pass fresh entropy to kexec'd kernels, use BI_RNG_SEED > for passing a seed, with the same semantics that kexec-tools currently > uses for i386's setup_data. > > Link:

Re: [PATCH v2 RESEND kexec-tools] m68k: pass rng seed via BI_RNG_SEED

2022-11-14 Thread Simon Horman
On Fri, Nov 11, 2022 at 02:35:33AM +0100, Jason A. Donenfeld wrote: > In order to pass fresh entropy to kexec'd kernels, use BI_RNG_SEED > for passing a seed, with the same semantics that kexec-tools currently > uses for i386's setup_data. > > Link:

Re: [PATCH V2] RISC-V: Add support for riscv kexec/kdump on kexec-tools

2022-10-28 Thread Simon Horman
On Wed, Oct 26, 2022 at 10:13:48AM +0800, Xianting Tian wrote: > Hi Simon > > thanks for the comments > > 在 2022/10/21 下午11:27, Simon Horman 写道: > > On Thu, Oct 20, 2022 at 11:15:48AM +0800, Xianting Tian wrote: > > > From: Nick Kossifidis > > > &g

Re: [PATCH] workflow: update to checkout@v3

2022-10-28 Thread Simon Horman
On Fri, Oct 21, 2022 at 05:27:57PM +0200, Simon Horman wrote: > Use to checkout@v3 instead of checkout@v2 > as the latter uses Node.js 12 actions which are deprecated. > > https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-inste

[PATCH kexec-tools] github: add RISC-V to workflow

2022-10-21 Thread Simon Horman
Add RISC-V builds to workflow Signed-off-by: Simon Horman --- .github/workflows/build.yml | 3 +++ 1 file changed, 3 insertions(+) Hi Xianting Tian, Please consider including this a v3 patch-set to add RISC-V to kexec-tools. diff --git a/.github/workflows/build.yml b/.github/workflows

[PATCH] workflow: update to checkout@v3

2022-10-21 Thread Simon Horman
Use to checkout@v3 instead of checkout@v2 as the latter uses Node.js 12 actions which are deprecated. https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/ Signed-off-by: Simon Horman --- .github/workflows/build.yml | 2 +- 1 file

Re: [PATCH V2] RISC-V: Add support for riscv kexec/kdump on kexec-tools

2022-10-21 Thread Simon Horman
On Thu, Oct 20, 2022 at 11:15:48AM +0800, Xianting Tian wrote: > From: Nick Kossifidis > > This patch adds support for loading the ELF kernel image. It parses > the current/provided device tree to determine the system's memory > layout, and /proc/iomem for the various kernel segments. > > This

Re: [PATCH 0/5] Add LoongArch port support

2022-10-10 Thread Simon Horman
On Wed, Sep 28, 2022 at 10:28:21AM +0800, Youling Tang wrote: > This patch series to support kexec/kdump (only 64bit). > > Note: Kernel kexec/kdump support patch see link [1]: > Link [1]: > https://lore.kernel.org/loongarch/711d53ae-197f-3c55-d09d-2f40e6886...@loongson.cn/T/#t Thanks, applied

  1   2   3   4   5   6   7   8   9   10   >