Re: [Kgdb-bugreport] [PATCH] kdb: Fix handling of kallsyms_symbol_next() return value

2015-03-02 Thread Jason Wessel
On 03/02/2015 08:13 AM, Daniel Thompson wrote: > kallsyms_symbol_next() returns a boolean (true on success). Currently > kdb_read() tests the return value with an inequality that > unconditionally evaluates to true. > > This is fixed in the obvious way and, since the conditional branch is > suppos

Re: [Kgdb-bugreport] kdb: core for kgdb back end (1 of 2)

2015-03-02 Thread Dan Carpenter
On Mon, Mar 02, 2015 at 10:02:27AM +, Daniel Thompson wrote: > On Thu, 2015-02-26 at 14:16 +0300, Dan Carpenter wrote: > >353 break; > >354 kdb_printf("%s ", p_tmp); > > > > Presumably we print the same thing ove

Re: [Kgdb-bugreport] kdb: core for kgdb back end (1 of 2)

2015-03-02 Thread Daniel Thompson
On Thu, 2015-02-26 at 14:16 +0300, Dan Carpenter wrote: > Hello Jason Wessel, > > The patch 5d5314d6795f: "kdb: core for kgdb back end (1 of 2)" from > May 20, 2010, leads to the following static checker warning: > > kernel/debug/kdb/kdb_io.c:352 kdb_read() > warn: bool is not less th