Jason,
This check
atomic_read(cpu_doing_single_step) != -1
may result in a loss of debug events on other cpus
Changing it to
atomic_read(cpu_doing_single_step) == raw_smp_processor_id()
corrects that problem
I see that you've checked in this change. Would you mind waiting for 24 hours
after
-Original Message-
From: Amit S. Kale [mailto:[EMAIL PROTECTED]
Sent: Wednesday, May 16, 2007 4:19 AM
To: Wessel, Jason
Cc: kgdb-bugreport@lists.sourceforge.net; Sergei Shtylyov; Tom Rini
Subject: Re: [PATCH] Fix singlestep exception kernel-user
x86_64 and ia32
Jason,
If there are no objections, I'd like to apply this patch as it fixes a
critical gap when using source stepping that calls a low level
singlestep that steps the boundary from the kernel to the user space.
It is particularly bad when this corner case kills init as you get an
unexpected reboot.
Jason Wessel wrote:
This patch is to fix another corner case where kgdb can pass a single
step trap to user space which was intended for the kernel. Now a
source level next which single steps over an iret instruction will
cause KGDB to continue and print an error to the console, vs the