[Kgdb-bugreport] [PATCH 2/3] kgdb, i386: use address that SP register points to in the exception frame

2009-05-15 Thread Jason Wessel
The treatment of the SP register is different on x86_64 and i386. This is a regression fix that lived outside the mainline kernel from 2.6.27 to now. The regression was a result of the original merge consolidation of the i386 and x86_64 archs to x86. The incorrectly reported SP on i386 prevented

Re: [Kgdb-bugreport] [PATCH 2/3] kgdb, i386: use address that SP register points to in the exception frame

2009-05-15 Thread Linus Torvalds
On Fri, 15 May 2009, Jason Wessel wrote: The treatment of the SP register is different on x86_64 and i386. This is a regression fix that lived outside the mainline kernel from 2.6.27 to now. The regression was a result of the original merge consolidation of the i386 and x86_64 archs to

Re: [Kgdb-bugreport] [PATCH 2/3] kgdb, i386: use address that SP register points to in the exception frame

2009-05-15 Thread Jason Wessel
Linus Torvalds wrote: Is this only ever used for kernel register state? Because in the _general_ case, the code should likely be something like if (user_mode_vm(regs)) { gdb_regs[GDB_SS] = regs-ss; gdb_regs[GDB_SP] = regs-sp; } else {