Re: [Kgdb-bugreport] [PATCH v12 0/7] arm64: Add IPI for backtraces / kgdb; try to use NMI for some IPIs

2023-08-31 Thread Chen-Yu Tsai
On Thu, Aug 31, 2023 at 3:14 AM Douglas Anderson wrote: > > This is an attempt to resurrect Sumit's old patch series [1] that > allowed us to use the arm64 pseudo-NMI to get backtraces of CPUs and > also to round up CPUs in kdb/kgdb. The last post from Sumit that I > could find was v7, so I

Re: [Kgdb-bugreport] [PATCH v12 1/7] irqchip/gic-v3: Enable support for SGIs to act as NMIs

2023-08-31 Thread Mark Rutland
On Wed, Aug 30, 2023 at 12:11:22PM -0700, Douglas Anderson wrote: > As of commit 6abbd6988971 ("irqchip/gic, gic-v3: Make SGIs use > handle_percpu_devid_irq()") SGIs are treated the same as PPIs/EPPIs > and use handle_percpu_devid_irq() by default. Unfortunately, > handle_percpu_devid_irq() isn't

Re: [Kgdb-bugreport] [PATCH v12 5/7] arm64: smp: IPI_CPU_STOP and IPI_CPU_CRASH_STOP should try for NMI

2023-08-31 Thread Mark Rutland
On Wed, Aug 30, 2023 at 12:11:26PM -0700, Douglas Anderson wrote: > There's no reason why IPI_CPU_STOP and IPI_CPU_CRASH_STOP can't be > handled as NMI. They are very simple and everything in them is > NMI-safe. Mark them as things to use NMI for if NMI is available. > > Suggested-by: Mark

Re: [Kgdb-bugreport] [PATCH v12 6/7] arm64: kgdb: Implement kgdb_roundup_cpus() to enable pseudo-NMI roundup

2023-08-31 Thread Mark Rutland
On Wed, Aug 30, 2023 at 12:11:27PM -0700, Douglas Anderson wrote: > Up until now we've been using the generic (weak) implementation for > kgdb_roundup_cpus() when using kgdb on arm64. Let's move to a custom > one. The advantage here is that, when pseudo-NMI is enabled on a > device, we'll be able

Re: [Kgdb-bugreport] [PATCH v12 7/7] arm64: smp: Mark IPI globals as __ro_after_init

2023-08-31 Thread Mark Rutland
On Wed, Aug 30, 2023 at 12:11:28PM -0700, Douglas Anderson wrote: > Mark the three IPI-related globals in smp.c as "__ro_after_init" since > they are only ever set in set_smp_ipi_range(), which is marked > "__init". This is a better and more secure marking than the old > "__read_mostly". > >

Re: [Kgdb-bugreport] [PATCH v12 1/7] irqchip/gic-v3: Enable support for SGIs to act as NMIs

2023-08-31 Thread Doug Anderson
Hi, On Thu, Aug 31, 2023 at 1:53 AM Mark Rutland wrote: > > On Wed, Aug 30, 2023 at 12:11:22PM -0700, Douglas Anderson wrote: > > As of commit 6abbd6988971 ("irqchip/gic, gic-v3: Make SGIs use > > handle_percpu_devid_irq()") SGIs are treated the same as PPIs/EPPIs > > and use

Re: [Kgdb-bugreport] [PATCH v12 1/7] irqchip/gic-v3: Enable support for SGIs to act as NMIs

2023-08-31 Thread Mark Rutland
On Thu, Aug 31, 2023 at 08:31:37AM -0700, Doug Anderson wrote: > Hi, > > On Thu, Aug 31, 2023 at 1:53 AM Mark Rutland wrote: > > > > On Wed, Aug 30, 2023 at 12:11:22PM -0700, Douglas Anderson wrote: > > > As of commit 6abbd6988971 ("irqchip/gic, gic-v3: Make SGIs use > > >