Re: [Kicad-developers] Odp: Re: SPICE_VALUE behavior

2021-05-19 Thread Wayne Stambaugh
Hi Sylwester, Got it. I would avoid rejecting all extra characters after the multiplier suffix and parse SI units (if they are defined).  If the SI units are not valid, then the value should be rejected as invalid. Wayne On 5/19/21 12:45 PM, Sylwester Kocjan wrote: Hi Wayne, Dnia 19 maja

Re: [Kicad-developers] Odp: Re: SPICE_VALUE behavior

2021-05-19 Thread Jonatan Liljedahl
I'm not sure this applies also for symbol Spice_Model fields (or Value field of Spice_Model is empty), but if it does then please make sure that one can still pass extra parameters there, such as "pot k=0.5 r=100k". On Wed, May 19, 2021 at 6:45 PM Sylwester Kocjan wrote: > Hi Wayne, > > Dnia 19

[Kicad-developers] Odp: Re: SPICE_VALUE behavior

2021-05-19 Thread Sylwester Kocjan
Hi Wayne, Dnia 19 maja 2021 00:32 Wayne Stambaugh stambau...@gmail.com napisał(a): The test cases look correct so I dont see any issues here. Could you please check again with better formatting below? Hertz is a valid SI unit, so strings: 10m and 10mHz are valid, but values ending