Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-02-09 Thread Marco Mattila
On Wed, Feb 9, 2011 at 5:35 PM, Wayne Stambaugh stambau...@verizon.net wrote: It looks good.  It certainly is a huge improvement over the old dialog.  Aside from some minor alignment issues the only comment I have is what does the Apply Settings button do?  If it just copies the dialog settings

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-02-03 Thread Jerry Jacobs
For me the dialog is very very good, and works as expected. Still the issue remains that the dialog can't be closed with the window button and the cancel button. I hacked a class function DIALOG_PLOT_BASE::OnQuit with EndModal(0); and it worked. Maybe the virtual functions need be implemented?

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-02-03 Thread Marco Mattila
On Thu, Feb 3, 2011 at 6:32 PM, Jerry Jacobs xor.gate.engineer...@gmail.com wrote: For me the dialog is very very good, and works as expected. Still the issue remains that the dialog can't be closed with the window button and the cancel button. I hacked a class function DIALOG_PLOT_BASE::OnQuit

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-02-01 Thread Jerry Jacobs
Hello Marco, I like it but it has still some issues with wxWidgets on Mac with version 2.9.2 from svn (rev 66766). I put a screenshot on my server over here: http://kicad.xor-gate.org/screenshots/new-plot-screen-issues.png The issues are the format frame, and the gerber options entries

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-02-01 Thread Dick Hollenbeck
Marco, Now please realize that you have to make EVERYONE happy, even if they disagree among themselves. :) And no good deed goes unpunished. And the pay is low. And coder decides. Because the pay is low. Dick ___ Mailing list:

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-02-01 Thread Wayne Stambaugh
On 2/1/2011 6:15 PM, Marco Mattila wrote: Now there should be a little something for everyone in the latest revision. It was possible to make the plot dialog a little smaller by getting rid of the radio buttons and moving the output directory field (although I'm not sure it's in the right

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-31 Thread jean-pierre charras
Le 31/01/2011 21:55, Marco Mattila a écrit : Jean-Pierre, I have yet another suggestion for the layout of the plot dialog (see attachment). The width would be the same as in your recent patch, but the height would be smaller. What do you think? marco I like it! -- Jean-Pierre CHARRAS

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-30 Thread jean-pierre charras
Le 29/01/2011 22:01, Marco Mattila a écrit : On Sat, Jan 29, 2011 at 10:24 PM, Marco Mattilamarco...@gmail.com wrote: I've been rearranging the plot dialog. The current status is shown in the attachment. There should be enough room to add a checkbox for marking the path relative. On second

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-30 Thread Dick Hollenbeck
On 01/30/2011 07:20 AM, jean-pierre charras wrote: Le 29/01/2011 22:01, Marco Mattila a écrit : On Sat, Jan 29, 2011 at 10:24 PM, Marco Mattilamarco...@gmail.com wrote: I've been rearranging the plot dialog. The current status is shown in the attachment. There should be enough room to add a

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-30 Thread Marco Mattila
On Sun, Jan 30, 2011 at 3:20 PM, jean-pierre charras jp.char...@wanadoo.fr wrote: Most of time plot subdirectory is a subdirectory of the current working directory. Mainly in this case (easy to detect), the stored path must be relative to the CWD. Do not forget the CWD can easily change for a

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-30 Thread Dick Hollenbeck
I will fix number 1. It is my problem anyway. Dick The null string output directory is fixed. You might still get the exception reading the board file, but only until you save the board file again. The desired content of the board file with the null string output directory is now with

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-29 Thread Dick Hollenbeck
Marco, I went back and took a look at your commit one last time, and I again want to complement on your excellence. It is *extremely* good, nice looking work. It is clear that your experience with C++ is substantial, and I appreciate the degree to which you have been willing to conform to

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-29 Thread jean-pierre charras
Le 29/01/2011 15:33, Dick Hollenbeck a écrit : Marco, I went back and took a look at your commit one last time, and I again want to complement on your excellence. It is *extremely* good, nice looking work. It is clear that your experience with C++ is substantial, and I appreciate the degree

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-29 Thread Marco Mattila
On Sat, Jan 29, 2011 at 10:24 PM, Marco Mattila marco...@gmail.com wrote: I've been rearranging the plot dialog. The current status is shown in the attachment. There should be enough room to add a checkbox for marking the path relative. On second thought, it should be possible to infer from

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-28 Thread Dick Hollenbeck
I might even use a macro, not a function, and have it be a single character macro name, like N(), TN(), GTN(). I also offer: n() which seems to get out of the way even less. ___ Mailing list: https://launchpad.net/~kicad-developers Post to

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-28 Thread Marco Mattila
On Fri, Jan 28, 2011 at 12:21 AM, Dick Hollenbeck d...@softplc.com wrote: Any complex string that is capable of having either whitespace or quotes in it should be wrapped using aFormatter-Quoted( CONV_TO_UTF8(blah) ).c_str(), I'm working on this now. Should there be something like if(

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-28 Thread Dick Hollenbeck
On 01/28/2011 11:18 AM, Marco Mattila wrote: On Fri, Jan 28, 2011 at 12:21 AM, Dick Hollenbeck d...@softplc.com wrote: Any complex string that is capable of having either whitespace or quotes in it should be wrapped using aFormatter-Quoted( CONV_TO_UTF8(blah) ).c_str(), I'm working on this

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-28 Thread Dick Hollenbeck
On 01/28/2011 01:18 PM, Marco Mattila wrote: On Fri, Jan 28, 2011 at 8:11 PM, Dick Hollenbeck d...@softplc.com wrote: Having said that, then are you saying a string like this: ABCD On the way out, *before* quoting will be a problem? Will not come back in via DSNLEXER? Have you verified

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-28 Thread Dick Hollenbeck
On 01/28/2011 11:18 AM, Marco Mattila wrote: On Fri, Jan 28, 2011 at 12:21 AM, Dick Hollenbeck d...@softplc.com wrote: Any complex string that is capable of having either whitespace or quotes in it should be wrapped using aFormatter-Quoted( CONV_TO_UTF8(blah) ).c_str(), I'm working on this

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-27 Thread Dick Hollenbeck
Very nice work. What you have for saving and loading seems future proof now, i.e. context free. Just some comments below, but I think you are already at 99% perfection. === modified file 'CMakeLists.txt' -add_subdirectory(gerbview) add_subdirectory(kicad) add_subdirectory(pcbnew)

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-05 Thread Wayne Stambaugh
On 1/4/2011 10:31 PM, Dick Hollenbeck wrote: The previous patch has a bug. It incorrectly complains about no layers being selected. This patch works better. marco On Sun, Jan 2, 2011 at 11:40 PM, Marco Mattila marco...@gmail.com wrote: Hi, During previous discussions about subtracting

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-05 Thread Marco Mattila
Damn. I always struggle the most with the comments for Doxygen... I think that we may be able to get rid of the global variable. I'll take a look. I'll fix the comments in the next patch, too. marco On Wed, Jan 5, 2011 at 3:24 PM, Wayne Stambaugh stambau...@verizon.net wrote: This is a nice

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-05 Thread Dick Hollenbeck
On 01/05/2011 07:47 AM, Marco Mattila wrote: Damn. I always struggle the most with the comments for Doxygen... I think that we may be able to get rid of the global variable. I'll take a look. I'll fix the comments in the next patch, too. marco From a usability standpoint, i.e. user

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-05 Thread Dick Hollenbeck
From a usability standpoint, i.e. user experience, I have a concern about saving the desired layers, as if I was only ever going to work on one board. Now that you have a compact bitmap, would it make sense to prefix the Config key for layers, with the boardname? Although this might

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-05 Thread Dick Hollenbeck
On 01/05/2011 09:10 AM, Dick Hollenbeck wrote: From a usability standpoint, i.e. user experience, I have a concern about saving the desired layers, as if I was only ever going to work on one board. Now that you have a compact bitmap, would it make sense to prefix the Config key for layers,

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-05 Thread Marco Mattila
If you think that the plotting requirements vary from one project to another (the number of needed technical layers maybe?), saving them outside the config system makes sense. Since there can be multiple boards in a project, maybe the SETUP section of a board file is the correct place for this. I

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-05 Thread Dick Hollenbeck
On 01/05/2011 11:23 AM, Marco Mattila wrote: If you think that the plotting requirements vary from one project to another (the number of needed technical layers maybe?), saving them outside the config system makes sense. Since there can be multiple boards in a project, maybe the SETUP section

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-04 Thread Dick Hollenbeck
The previous patch has a bug. It incorrectly complains about no layers being selected. This patch works better. marco On Sun, Jan 2, 2011 at 11:40 PM, Marco Mattila marco...@gmail.com wrote: Hi, During previous discussions about subtracting masks from silkscreen layers when plotting

Re: [Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-03 Thread Marco Mattila
The previous patch has a bug. It incorrectly complains about no layers being selected. This patch works better. marco On Sun, Jan 2, 2011 at 11:40 PM, Marco Mattila marco...@gmail.com wrote: Hi, During previous discussions about subtracting masks from silkscreen layers when plotting gerbers,

[Kicad-developers] [PATCH] Saving plot dialog settings

2011-01-02 Thread Marco Mattila
Hi, During previous discussions about subtracting masks from silkscreen layers when plotting gerbers, Dick mentioned that saving plot settings is not quite up to date. Currently some plot settings to be saved/loaded are defined in pcbnew_config.cpp. However, that requires that corresponding