[Koha-patches] [PATCH] bug_7520 Added Meta handler to API v1 for metadata lists

Useful for building drop-downs etc. Kick off with /meta/advanced-search-types --- Koha/REST/V1/Meta.pm | 52 api/v1/swagger.json | 49 ++ t/db_dependent/api/v1/meta.t | 82 3 files

[Koha-patches] [PATCH] bug_7520 Added helper "syspref" to Mojolicious handlers

--- Koha/REST/V1.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Koha/REST/V1.pm b/Koha/REST/V1.pm index b692a38..b8f2bd6 100644 --- a/Koha/REST/V1.pm +++ b/Koha/REST/V1.pm @@ -25,6 +25,8 @@ use Koha::Patrons; sub startup { my $self = shift; +$self->helper(syspref => sub {

[Koha-patches] [PATCH] Bug 16034 follow-up: added WebService::ILS to PerlDependencies

--- C4/Installer/PerlDependencies.pm | 5 + 1 file changed, 5 insertions(+) diff --git a/C4/Installer/PerlDependencies.pm b/C4/Installer/PerlDependencies.pm index db9cd7c..2bc7515 100644 --- a/C4/Installer/PerlDependencies.pm +++ b/C4/Installer/PerlDependencies.pm @@ -812,6 +812,11 @@ our

[Koha-patches] [PATCH] Bug 16986: Added 035 $a tag to search index as OCLC-Number

--- C4/Search.pm| 2 ++ etc/searchengine/queryparser.yaml | 9 + etc/zebradb/ccl.properties | 5 + etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml | 5

[Koha-patches] [PATCH] bug 14803: KOHA.Checkouts js object

* Use javascript to: - update fines/checkouts info - show/hide checkouts form and messages * Created svc/patron/fines --- circ/circulation.pl| 14 - .../prog/en/includes/blocked-fines.inc | 18 +++--- .../prog/en/includes/checkouts-table.inc

[Koha-patches] [PATCH] Bug 16870 - Update Koha::Patron use of the class

From: Kyle M Hall <k...@bywatersolutions.com> Test Plan: 1) Apply this patch 2) prove t/db_dependent/Patron/Borrower_PrevCheckout.t 3) prove t/db_dependent/Koha/Checkouts.t Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- Koha/Patron.pm | 16 1 file changed,

[Koha-patches] [PATCH] Bug 16870 - Move and rename class files and unit tests

From: Kyle M Hall <k...@bywatersolutions.com> Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- Koha/Issue.pm | 28 --- Koha/Issues.pm | 33 --- t/db_dependent/Koha/Checkouts.t | 29 +--- t/db_de

[Koha-patches] [PATCH] bug 14803: KOHA.Checkouts js object

* Use javascript to: - update fines/checkouts info - show/hide checkouts form and messages * Created svc/patron/fines --- circ/circulation.pl| 14 - .../prog/en/includes/blocked-fines.inc | 16 ++--- .../prog/en/includes/checkouts-table.inc

[Koha-patches] [PATCH] Bug 15006: [QA Follow-up] Satisfy qa tools with one tab less

From: Marcel de Rooy <m.de.r...@rijksmuseum.nl> Signed-off-by: Marcel de Rooy <m.de.r...@rijksmuseum.nl> Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- C4/SIP/SIPServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/SIP/SIPServer.pm b/C4/SIP/

[Koha-patches] [PATCH] Bug 15006 Correct indentation of EXPORTs in Sip.pm

From: Colin Campbell <colin.campb...@ptfs-europe.com> Removed tabs and used spaces consistently Used 'use base' to remove unnecessary BEGIN sub and explicit setting of ISA at application level Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- C4/SIP

[Koha-patches] [PATCH] Bug 15006: Centralize timeout logic and allow zero client timeout

Remove service timeout too. Test fallback to 30 at login. Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- C4/SIP/SIPServer.pm | 12 --- C4/SIP/Sip.pm | 46 +- C4/SIP/Sip/MsgType.pm | 7 +--- t/SIP_Sip.t

[Koha-patches] [PATCH] Bug 15006: Introduce client_timeout in SIPconfig.xml

(no timeout) in a later proposal. Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- etc/SIPconfig.xml | 8 1 file changed, 8 insertions(+) diff --git a/etc/SIPconfig.xml b/etc/SIPconfig.xml index fc7635e..c61a6c7 100644 --- a/etc/SIPconfig.xml +++ b/etc/SIPconfig.xml @@ -32,7 +32

[Koha-patches] [PATCH] Bug 15006 Remove tabs from sip_protocol_loop

From: Colin Campbell <colin.campb...@ptfs-europe.com> Remove the tabs causing inconsistent indentation of sip_protocol_loop and replace with spaces Reimplements the renaining parts of Marcel de Rooy's original QA patch No logic changes in this patch - layout only Signed-off-by: Srdja

[Koha-patches] [PATCH] Bug 16890: Make TestBuilder generate date for date columns (and not datetime)

d fail. After this patch applied, they both should pass. Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- t/db_dependent/TestBuilder.t | 13 - t/lib/TestBuilder.pm | 9 +++-- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/t/db_dependent/TestB

[Koha-patches] [PATCH] Bug 16877: Redo GetBorrowercategoryList() to use Koha::Patron::Categories->search()

--- C4/Members.pm| 27 +-- t/db_dependent/Members.t | 6 +- tools/modborrowers.pl| 2 +- 3 files changed, 19 insertions(+), 16 deletions(-) diff --git a/C4/Members.pm b/C4/Members.pm index 383799d..68f5f77 100644 --- a/C4/Members.pm +++

[Koha-patches] [PATCH] Bug 16823 - Comment out koha-rebuild-zebra in koha-common.cron.d

tivate the cronjob again after de-activating the indexer daemon. To test: Just read the diff and check that it makes sense. Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- debian/koha-common.cron.d | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/debian/koha-com

[Koha-patches] [PATCH] Bug 15636 - DataTables Warning: Requested unknown parameter from opac-detail.tt

From: Bouzid Fergani <bouzid.ferg...@inlibro.com> Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detai

[Koha-patches] [PATCH] Bug 16859: Fix wrong item field name in export.pl

Select biblio range N,N and no itemcallnumber range. The biblio should be exported. [3] Select biblio range N,N and itemcallnumber range A,B. No output. [4] Select biblio range N,N and itemcallnumber range A,. Output. [5] Select biblio range N,N and itemcallnumber range ,X. Output. Signed-off-by:

[Koha-patches] [PATCH] Bug 16855 - Poor performance due to high overhead of SQL call in export.pl

lts match results before patch Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- tools/export.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/export.pl b/tools/export.pl index 4794d05..373ebfa 100755 --- a/tools/export.pl +++ b/tools/export.pl @@ -148,7 +148,7

[Koha-patches] [PATCH] Bug 16848: Prevent invalid warning to be carped from output_pref

233. t/DateUtils.t .. ok All tests successful. Files=1, Tests=60, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.40 cusr 0.00 csys = 1.42 CPU) Result: PASS Test plan: Without this patch, you should not see the carp Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- Koha/DateUtils.pm | 7 +

[Koha-patches] [PATCH] Bug 16664: fix loaded SQL for strictness

From: Robin Sheat <ro...@kallisti.net.nz> There were some errors in the SQL structure that MySQL got upset at in strict mode. This lets the file load. Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- installer/data/mysql/kohastructure.sql | 4 ++-- 1 file changed, 2 insertions(+),

[Koha-patches] [PATCH] Bug 15419 SIP: call auth() subs with timeout, and refresh dbh if need be

--- C4/SIP/ILS/Patron.pm | 11 +-- C4/SIP/Sip/MsgType.pm | 11 ++- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/C4/SIP/ILS/Patron.pm b/C4/SIP/ILS/Patron.pm index 93b6c54..c3d348d 100644 --- a/C4/SIP/ILS/Patron.pm +++ b/C4/SIP/ILS/Patron.pm @@ -14,6 +14,7 @@ use

[Koha-patches] [PATCH] Bug 14803: Reload checkouts table on renewal

svc/checkouts: get real rental charges for patron, rather than itemtype indication --- koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 2 ++ svc/checkouts| 16 +++- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git

[Koha-patches] [PATCH] bug 14803: KOHA.Checkouts js object

* Use javascript to: - update fines/checkouts info - show/hide checkouts form and messages * Created svc/patron/fines --- circ/circulation.pl| 14 - .../prog/en/includes/blocked-fines.inc | 16 ++--- .../prog/en/modules/circ/circulation.tt

[Koha-patches] [PATCH] Bug 16693: Remove reserve/renewscript.pl

From: Julian Maurice <julian.maur...@biblibre.com> It is not used since bug 11703 Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- reserve/renewscript.pl | 142 - 1 file changed, 142 deletions(-) delete mode 100755 reserve/renewscr

[Koha-patches] [PATCH] Bug 16720: Remove DBIx ActionLogs.pm

Sign off Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- Koha/Schema/Result/ActionLogs.pm | 90 1 file changed, 90 deletions(-) delete mode 100644 Koha/Schema/Result/ActionLogs.pm diff --git a/Koha/Schema/Result/ActionLogs.pm b/Koha/Schema/Result/Acti

[Koha-patches] [PATCH] Bug 7703 - QA Followup 2

From: Kyle M Hall <k...@bywatersolutions.com> Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 7 --- reserve/request.pl | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-)

[Koha-patches] [PATCH] Bug 7703 - QA Followup

From: Kyle M Hall <k...@bywatersolutions.com> Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- C4/Biblio.pm | 2 ++ C4/Items.pm | 2 ++ 2 files changed, 4 insertions(+) diff --git a/C4/Biblio.pm b/C4/Biblio.pm index ae1f2f3..3b18064 100644 --- a/C4/Biblio.pm +++ b/C4/Biblio.p

[Koha-patches] [PATCH] Bug 14803: Reload checkouts table on renewal

svc/checkouts: get real rental charges for patron, rather than itemtype indication --- koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 2 ++ svc/checkouts| 14 ++ 2 files changed, 12 insertions(+), 4 deletions(-) diff --git

[Koha-patches] [PATCH] Test rental charges properly

* AddIssuingCharge() test was always returning pass - removed and replaced with: * Test rental charges properly for both checkout and renewal https://bugs.koha-community.org/show_bug.cgi?id=14803 --- t/db_dependent/Circulation/issue.t | 49 ++ 1 file

[Koha-patches] [PATCH] Fix test data in issue.t and defaults for stats

'' and 'Null' are not really NULL values https://bugs.koha-community.org/show_bug.cgi?id=14803 --- C4/Stats.pm| 14 +++--- t/db_dependent/Circulation/issue.t | 28 2 files changed, 23 insertions(+), 19 deletions(-) diff --git

[Koha-patches] [PATCH] Bug 13807 Rework main input loop in SIPServer

place for this Removed no longer iused SIP_read_packet from Sip.pm Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- C4/SIP/SIPServer.pm | 107 +++- C4/SIP/Sip.pm | 56 +-- 2 files changed, 74 insertions(+), 89 deletions(-)

[Koha-patches] [PATCH] Bug 16635: t/00-load.t warning from C4/Barcodes/hbyymmincr.pm

) run koha qa test tools Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- C4/Barcodes/hbyymmincr.pm | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/C4/Barcodes/hbyymmincr.pm b/C4/Barcodes/hbyymmincr.pm index f963e9a..4e76012 100644 --- a/C4/Barcodes/hbyymmincr.pm

[Koha-patches] [PATCH] Bug 16636: t/00-load.t warning from C4/External/BakerTaylor.pm

p [.]t$` -- should all run okay 3) apply patch 4) repeat steps 1 and 2 -- warning should be gone, and everything else run okay 5) run koha qa test tools Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- C4/External/BakerTaylor.pm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) dif

[Koha-patches] [PATCH] Bug 16649: Make OpenLibrarySearch test pass even if launches offline

From: Jonathan Druart <jonathan.dru...@bugs.koha-community.org> Test plan: prove t/OpenLibrarySearch.t should return green even if you are offline Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- t/OpenLibrarySearch.t | 10 +++--- 1 file changed, 7 insertions(+), 3 deleti

[Koha-patches] [PATCH] Bug 16667: Unused variable and function call in circulation.pl

git grep '$branches' circ/circulation.pl => SUCCESS: The variable has been removed - Sign off :-D Regards Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- circ/circulation.pl | 2 -- 1 file changed, 2 deletions(-) diff --git a/circ/circulation.pl b/circ/circulation.pl index b2bcd

[Koha-patches] [PATCH] Bug 16618: 00-load.t prematurely stops all testing

do apt-get update cd ~ wget http://debian.koha-community.org/koha/otherthings/elasticsearch_deps.tar.gz tar xvf elasticsearch_deps.tar.gz cd es_deps sudo dpkg i lib* sudo apt-get install -f Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- t/00-load.t | 43 ++

[Koha-patches] [PATCH] Bug 16668 - Move t/Ris.t to t/db_dependent/Ris.t

From: Mirko Tietgen <mi...@abunchofthings.net> Move test to db_dependent Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- t/{ => db_dependent}/Ris.t | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename t/{ => db_dependent}/Ris.t (100%) diff --git a/t/Ris.t b/t/

[Koha-patches] [PATCH] Bug 16620: Translatability: Fix problem with isolated word "please" in auth.tt

84). Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt index 8887812..411

[Koha-patches] [PATCH] bug_15562: Removed Koha::Cache->get_instance()

There should be no cache singleton, full stop. If Koha is to move away from .pl scripts that is. As an interim measure Koha::Cache->get_instance() is replaced with C4::Context->cache, in the vein of C4::Context->memcached. In that respect it will continue to work in the singleton-ish way if

[Koha-patches] [PATCH] Bug 16436 - Allow action logs to be logged to the koha log file

= INFO, INTRANET 4) Change a system preference setting 5) Note the new line in your log file! Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- C4/Log.pm | 39 +++ 1 file changed, 31 insertions(+), 8 deletions(-) diff --git a/C4/Log.pm b/C4/Log.pm i

[Koha-patches] [PATCH] Bug 16540: Translatability in opac-auth.tt (tag-splitted sentences)

ng a different Google account" UPDATE: Amended to fix a tiny typo Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opa

[Koha-patches] [PATCH] Bug 16582 t/Price.t test should pass if Test::DBIx::Class is not available

From: Mark Tompsett <mtomp...@hotmail.com> This patch makes it so 00-load.t doesn't cause 'prove t' to prematurely die before reaching other tests. TEST PLAN - 1) prove t -- dies on 00-load.t 2) apply patch 3) prove t -- now t/Prices.t should be the failure. Signed-off-by:

[Koha-patches] [PATCH] Bug 16575 - Irregular behaviour using window.print() followed by window.location.href=

ter printing is complete, you should still be on the OPAC basket pop-up Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/mod

[Koha-patches] [PATCH] Bug 16502: Replace a few other ok-calls by is-calls

From: Marcel de Rooy <m.de.r...@rijksmuseum.nl> Trivial changes that speak for themselves.. Signed-off-by: Marcel de Rooy <m.de.r...@rijksmuseum.nl> Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- t/db_dependent/Plugins.t | 8 1 file changed, 4 insertions(+), 4

[Koha-patches] [PATCH] Bug 16502: Adjust test for GetPlugins

ed-off-by: Srdjan <srd...@catalyst.net.nz> --- t/db_dependent/Plugins.t | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Plugins.t b/t/db_dependent/Plugins.t index 308e215..73ce65b 100755 --- a/t/db_dependent/Plugins.t +++ b/t/db_dependent/Plugins.t @@ -43,7

[Koha-patches] [PATCH] Bug 16465: Fix typo issues vs checkouts

From: Jonathan Druart <jonathan.dru...@bugs.koha-community.org> Test plan: Confirm the wording is correct Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- koha-tmpl/intranet-tmpl/prog/en/modules/members/discharge.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-discha

[Koha-patches] [PATCH] Bug 16459: Add patron to a patron card requires catalogue permission

s the one used almost everywhere in this module Test plan: Confirm that catalogue is enough to search for patrons to add to a patron card. Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- patroncards/add_user_search.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[Koha-patches] [PATCH] Bug 16441: Do not use a package variable to cache C4::Letters::getletter

valid letter when needed. No test plan here, just confirm that the changes make sense. Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- C4/Letters.pm | 11 --- 1 file changed, 11 deletions(-) diff --git a/C4/Letters.pm b/C4/Letters.pm index f327890..1d0c3c0 100644 --- a/C4/Lett

[Koha-patches] [PATCH] Bug 16518: Fix Plack variable scoping problem in opac-addbybiblionumber.pl

ever stop growing, the previous items added are still listed when adding new ones. => With this patch, the behavior is the one expected. Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- opac/opac-addbybiblionumber.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Koha-patches] [PATCH] Bug 16504: (follow-up for bug 15163) Do not remove attributes of other patrons

patron attribute limited to a library Set the the attribute for a patron Set the the attribute for another patron => Without this patch applied, the attribute's value for the first patron is deleted => With this patch applied, the 2 values exist in the DB after the second edition Signed-off-by:

[Koha-patches] [PATCH] Bug 16504: Add regression tests

From: Jonathan Druart <jonathan.dru...@bugs.koha-community.org> Signed-off-by: Srdjan <srd...@catalyst.net.nz> --- t/db_dependent/Members/Attributes.t | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Members/Attri

[Koha-patches] [PATCH] bug_15562: Removed Koha::Cache->get_instance()

There should be no cache singleton, full stop. If Koha is to move away from .pl scripts that is. As an interim measure Koha::Cache->get_instance() is replaced with C4::Context->cache, in the vein of C4::Context->memcached. In that respect it will continue to work in the singleton-ish way if

[Koha-patches] [PATCH] bug_15562: Removed Koha::Cache->get_instance()

There should be no cache singleton, full stop. If Koha is to move away from .pl scripts that is. As an interim measure Koha::Cache->get_instance() is replaced with C4::Context->cache, in the vein of C4::Context->memcached. In that respect it will continue to work in the singleton-ish way if

[Koha-patches] [PATCH] bug_15562: Multi-host helper for plack installations

Sort of an apocalypse * C4::Context->new() must be called with at least config file param. If you want current context, call C4::Context->current(). C4::Context->some_method() will still work as is. * Koha::Database->new_schema() now takes optional context param. * C4::Context->set_context()

[Koha-patches] [PATCH] bug_11213: Added XSLTParse4Display() to Items test

--- t/db_dependent/Items.t | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t index 9bbb9d2..c6ed605 100755 --- a/t/db_dependent/Items.t +++ b/t/db_dependent/Items.t @@ -20,6 +20,7 @@ use Modern::Perl; use

[Koha-patches] [PATCH] bug_11213: GetItemsInfo() test

--- t/db_dependent/Items.t | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t index 5df6eb5..9bbb9d2 100755 --- a/t/db_dependent/Items.t +++ b/t/db_dependent/Items.t @@ -40,7 +40,7 @@ my $location = 'My Location'; subtest

[Koha-patches] [PATCH] bug_11213: Include XSLT processing for searchResults() test

* Added template paths to temp test dir, so XSLT templates can be picked up --- C4/XSLT.pm | 1 + t/db_dependent/Search.t | 11 +++ 2 files changed, 12 insertions(+) diff --git a/C4/XSLT.pm b/C4/XSLT.pm index 874deee..9a6a38f 100644 --- a/C4/XSLT.pm +++ b/C4/XSLT.pm @@

[Koha-patches] [PATCH] bug_11213: whitespace correction

--- C4/Search.pm | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/C4/Search.pm b/C4/Search.pm index a1e6b4c..7b88a59 100644 --- a/C4/Search.pm +++ b/C4/Search.pm @@ -2055,7 +2055,7 @@ sub searchResults { $onloan_items->{$key} = { %$item };

[Koha-patches] [PATCH] bug_11213: Check for $item->{itype} presence to avoid warning

--- C4/XSLT.pm | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/C4/XSLT.pm b/C4/XSLT.pm index 9a6a38f..adf5e97 100644 --- a/C4/XSLT.pm +++ b/C4/XSLT.pm @@ -269,8 +269,16 @@ sub buildKohaItemsNamespace { my $reservestatus =

[Koha-patches] [PATCH] bug_11213: Added XSLTParse4Display() to Items test

--- t/db_dependent/Items.t | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t index 9bbb9d2..c6ed605 100755 --- a/t/db_dependent/Items.t +++ b/t/db_dependent/Items.t @@ -20,6 +20,7 @@ use Modern::Perl; use

[Koha-patches] [PATCH] bug_11213: Include XSLT processing for searchResults() test

* Added template paths to temp test dir, so XSLT templates can be picked up --- C4/XSLT.pm | 1 + t/db_dependent/Search.t | 11 +++ 2 files changed, 12 insertions(+) diff --git a/C4/XSLT.pm b/C4/XSLT.pm index 874deee..9a6a38f 100644 --- a/C4/XSLT.pm +++ b/C4/XSLT.pm @@

[Koha-patches] [PATCH] bug_11213: GetItemsInfo() test

--- t/db_dependent/Items.t | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t index 5df6eb5..9bbb9d2 100755 --- a/t/db_dependent/Items.t +++ b/t/db_dependent/Items.t @@ -40,7 +40,7 @@ my $location = 'My Location'; subtest

[Koha-patches] [PATCH] bug_11213: whitespace correction

--- C4/Search.pm | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/C4/Search.pm b/C4/Search.pm index a1e6b4c..7b88a59 100644 --- a/C4/Search.pm +++ b/C4/Search.pm @@ -2055,7 +2055,7 @@ sub searchResults { $onloan_items->{$key} = { %$item };

[Koha-patches] [PATCH] bug_11213: Changed XSLTParse4Display() interface

The list of biblio items is passed on now, instead of GetItemsInfo() being called. This is because the callers already have the list ready, so the GetItemsInfo() call is being duplicated unnecessarily. Search::searchResults() builds items list from XML, and that one is passed instead. *

[Koha-patches] [PATCH] bug_15562: Removed Koha::Cache->get_instance()

There should be no cache singleton, full stop. If Koha is to move away from .pl scripts that is. As an interim measure Koha::Cache->get_instance() is replaced with C4::Context->cache, in the vein of C4::Context->memcached. In that respect it will continue to work in the singleton-ish way if

[Koha-patches] [PATCH] bug_15562: Removed Koha::Cache->get_instance()

There should be no cache singleton, full stop. If Koha is to move away from .pl scripts that is. As an interim measure Koha::Cache->get_instance() is replaced with C4::Context->cache, in the vein of C4::Context->memcached. In that respect it will continue to work in the singleton-ish way if

[Koha-patches] [PATCH] bug_15562: Multi-host helper for plack installations

Sort of an apocalypse * C4::Context->new() must be called with at least config file param. If you want current context, call C4::Context->current(). C4::Context->some_method() will still work as is. * Koha::Database->new_schema() now takes optional context param. * C4::Context->set_context()

[Koha-patches] [PATCH] bug_15562: Use do() rather than system() to execute updatedatabase.pl from installer.pl

That way: * no external process is spawned * code executes in the same perl process, which is required for plack multi-site I have a dream. A dream that one day all code from .pl's will be in some .pm's. --- C4/Installer/PerlDependencies.pm | 5 + installer/install.pl | 44

[Koha-patches] [PATCH] bug_15562: Revert "Bug 13690: use Koha::Schema only when it's needed"

This reverts commit c52bc9756a5fa1e4f6bba7ce5c58124f150c5efc. I don't see any place where we would use KOha::Database without wanting Koha::Schema. require Koha::Schema interferes with some plack setups - for some reason it calls C4::Context->import() even when C4::Context is already used. ---

[Koha-patches] [PATCH] bug_15562: Removed Koha::Cache->get_instance()

There should be no cache singleton, full stop. If Koha is to move away from .pl scripts that is. As an interim measure Koha::Cache->get_instance() is replaced with C4::Context->cache, in the vein of C4::Context->memcached. In that respect it will continue to work in the singleton-ish way if

[Koha-patches] [PATCH] bug_15562: Multi-host helper for plack installations

Sort of an apocalypse * C4::Context->new() must be called with at least config file param. If you want current context, call C4::Context->current(). C4::Context->some_method() will still work as is. * Koha::Database->new_schema() now takes optional context param. * C4::Context->set_context()

[Koha-patches] [PATCH] bug_15562: Sysprefs cache is object property now

https://bugs.koha-community.org/show_bug.cgi?id=15562 --- C4/Context.pm | 36 +++- t/db_dependent/sysprefs.t | 12 +++- 2 files changed, 30 insertions(+), 18 deletions(-) diff --git a/C4/Context.pm b/C4/Context.pm index bae5f12..3f94baf 100644

[Koha-patches] [PATCH] bug_16039 Added -q flag to share_usage_with_koha_community.pl

--- misc/cronjobs/share_usage_with_koha_community.pl | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/misc/cronjobs/share_usage_with_koha_community.pl b/misc/cronjobs/share_usage_with_koha_community.pl index c4353d8..affa043 100755 ---

[Koha-patches] [PATCH] bug_16039 Added -q flag to share_usage_with_koha_community.pl

--- misc/cronjobs/share_usage_with_koha_community.pl | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/misc/cronjobs/share_usage_with_koha_community.pl b/misc/cronjobs/share_usage_with_koha_community.pl index c4353d8..bb61a4d 100755 ---

[Koha-patches] [PATCH] bug_16034 Add overdrive info to the users page in the public interface

--- .../bootstrap/en/includes/overdrive-checkout.inc | 19 ++ .../bootstrap/en/modules/opac-overdrive-search.tt | 17 +- .../opac-tmpl/bootstrap/en/modules/opac-user.tt| 23 ++ koha-tmpl/opac-tmpl/bootstrap/js/overdrive.js | 359 + opac/opac-overdrive-search.pl

[Koha-patches] [PATCH] bug_16034 Koha::ExternalContent::OverDrive - a wrapper around WebService::ILS::Overdrive::Patron

* Using the upstream module for all the heavy lifting * opac/external/overdrive/auth.pl - 3-legged authentication handler --- Koha/ExternalContent.pm | 88 ++ Koha/ExternalContent/OverDrive.pm | 206

[Koha-patches] [PATCH] bug_16034 Adding a new syspref - OverDriveCirculation

From: Chris Cormack If set to true, Opac will integrate OverDrive patron services --- installer/data/mysql/atomicupdate/overdrive.sql | 3 +++ installer/data/mysql/sysprefs.sql| 1 +

[Koha-patches] [PATCH] bug_15562: Multi-host helper for plack installations

Sort of an apocalypse * C4::Context->new() must be called with at least config file param. If you want current context, call C4::Context->current(). C4::Context->some_method() will still work as is. * Koha::Database->new_schema() now takes optional context param. * C4::Context->set_context()

[Koha-patches] [PATCH] bug_15562: Use do() rather than system() to execute updatedatabase.pl from installer.pl

That way: * no external process is spawned * code executes in the same perl process, which is required for plack multi-site I have a dream. A dream that one day all code from .pl's will be in some .pm's. --- C4/Installer/PerlDependencies.pm | 5 + installer/install.pl | 44

[Koha-patches] [PATCH] bug_15562: Removed Koha::Cache->get_instance()

There should be no cache singleton, full stop. If Koha is to move away from .pl scripts that is. As an interim measure Koha::Cache->get_instance() is replaced with C4::Context->cache, in the vein of C4::Context->memcached. In that respect it will continue to work in the singleton-ish way if

[Koha-patches] [PATCH] Sysprefs cache is object property now

https://bugs.koha-community.org/show_bug.cgi?id=15562 --- C4/Context.pm | 29 - t/db_dependent/sysprefs.t | 14 +- 2 files changed, 29 insertions(+), 14 deletions(-) diff --git a/C4/Context.pm b/C4/Context.pm index 341438a..1dcdce4 100644 ---

[Koha-patches] [PATCH] Multi-host helper for plack installations

Sort of an apocalypse * C4::Context->new() must be called with at least config file param. If you want current context, call C4::Context->current(). C4::Context->some_method() will still work as is. * Koha::Database->new_schema() now takes optional context param. * C4::Context->set_context()

[Koha-patches] [PATCH] Removed Koha::Cache->get_instance()

There should be no cache singleton, full stop. If Koha is to move away from .pl scripts that is. As an interim measure Koha::Cache->get_instance() is replaced with C4::Context->cache, in the vein of C4::Context->memcached. In that respect it will continue to work in the singleton-ish way if

[Koha-patches] [PATCH] Bug 15434: Search criteria definition table

Collected search criteria and limit labels in opac-bottom.inc, so it can be used for both making search criteria selects and displaying back selections on the result screen. *-opac-bootstrap.po translation files need to be changed: - references to opac-advanced-search.tt need to be updated to

[Koha-patches] [PATCH] bug_15538: Koha::Logger in longoverdue.pl

* Removed --verbose option and replaved verbose prints with $logger->debug() --- misc/cronjobs/longoverdue.pl | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/misc/cronjobs/longoverdue.pl b/misc/cronjobs/longoverdue.pl index b73d31f..985edb5 100755

[Koha-patches] [PATCH] bug_8034: Restored network printer maintenance and selection

This patch is just for restoring printer maintenance and selection, not for priting itself. It is just a preparation step. * Added UsePrintQueues syspref. If set to No, no printer info will be displayed/used * Database changes: - printers table PRIMARY KEY is now printqueue. It is more natural.

[Koha-patches] [PATCH] bug_6624: OpenLibrarySearch syspref for OPAC

If set to Yes, OPAC search results and details will include buton from Open Library Raed API. In addition, Number of titles held in Open Library and the results link will be reported on the search results screen. --- .../data/mysql/atomicupdate/bug_6624-OpenLibrarySearch_syspref.sql | 2 ++

[Koha-patches] [PATCH] bug_6624: Added Open Library Search and Read API to openlibrary.js

--- koha-tmpl/opac-tmpl/bootstrap/js/openlibrary.js | 180 +++- 1 file changed, 175 insertions(+), 5 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/openlibrary.js b/koha-tmpl/opac-tmpl/bootstrap/js/openlibrary.js index 995cb6b..318576a 100644 ---

[Koha-patches] [PATCH] bug_11213: Check for $item-{itype} presence to avoid warning

--- C4/XSLT.pm | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/C4/XSLT.pm b/C4/XSLT.pm index 62b38f7..a793524 100644 --- a/C4/XSLT.pm +++ b/C4/XSLT.pm @@ -263,8 +263,16 @@ sub buildKohaItemsNamespace { my $reservestatus =

[Koha-patches] [PATCH] bug_11213: C4::VirtualShelves::Page::shelf_contents()

* Extracted shelf items processing from shelfpage() into a separate sub shelf_contents() in order to be able to test it * Added tests for shelf_contents() with XSLT --- C4/VirtualShelves/Page.pm| 113 +-- t/db_dependent/VirtualShelves_Page.t | 43

[Koha-patches] [PATCH] bug_11213: Changed XSLTParse4Display() interface

The list of biblio items is passed on now, instead of GetItemsInfo() being called. This is because the callers already have the list ready, so the GetItemsInfo() call is being duplicated unnecessarily. Search::searchResults() builds items list from XML, and that one is passed instead. *

[Koha-patches] [PATCH] bug_11213: whitespace correction

--- C4/Search.pm | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/C4/Search.pm b/C4/Search.pm index b5ab049..29506b7 100644 --- a/C4/Search.pm +++ b/C4/Search.pm @@ -2105,7 +2105,7 @@ sub searchResults { $onloan_items-{$key} = { %$item };

[Koha-patches] [PATCH] bug_11213: Added XSLTParse4Display() to Items test

--- t/db_dependent/Items.t | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t index 6cfb862..ce5342e 100755 --- a/t/db_dependent/Items.t +++ b/t/db_dependent/Items.t @@ -21,6 +21,7 @@ use Modern::Perl; use

[Koha-patches] [PATCH] bug_11213: Include XSLT processing for searchResults() test

* Added template paths to temp test dir, so XSLT templates can be picked up --- C4/XSLT.pm | 1 + t/db_dependent/Search.t | 11 +++ 2 files changed, 12 insertions(+) diff --git a/C4/XSLT.pm b/C4/XSLT.pm index db32d6f..62b38f7 100644 --- a/C4/XSLT.pm +++ b/C4/XSLT.pm @@

[Koha-patches] [PATCH] bug_11213: GetItemsInfo() test

--- t/db_dependent/Items.t | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t index b41b483..6cfb862 100755 --- a/t/db_dependent/Items.t +++ b/t/db_dependent/Items.t @@ -35,7 +35,7 @@ my ($branch1, $branch2) = keys %$branches;

[Koha-patches] [PATCH] bug_11213: Changed XSLTParse4Display() interface

The list of biblio items is passed on now, instead of GetItemsInfo() being called. This is because the callers already have the list ready, so the GetItemsInfo() call is being duplicated unnecessarily. Search::searchResults() builds items list from XML, and that one is passed instead. *

[Koha-patches] [PATCH] bug_11213: Include XSLT processing for searchResults() test

* Added template paths to temp test dir, so XSLT templates can be picked up --- C4/XSLT.pm | 1 + t/db_dependent/Search.t | 11 +++ 2 files changed, 12 insertions(+) diff --git a/C4/XSLT.pm b/C4/XSLT.pm index f8d228a..90caed3 100644 --- a/C4/XSLT.pm +++ b/C4/XSLT.pm @@

[Koha-patches] [PATCH] bug_11213: C4::VirtualShelves::Page::shelf_contents()

* Extracted shelf items processing from shelfpage() into a separate sub shelf_contents() in order to be able to test it * Added tests for shelf_contents() with XSLT --- C4/VirtualShelves/Page.pm| 113 +-- t/db_dependent/VirtualShelves_Page.t | 43

[Koha-patches] [PATCH] bug_11213: whitespace correction

--- C4/Search.pm | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/C4/Search.pm b/C4/Search.pm index 0eef1ac..50a5644 100644 --- a/C4/Search.pm +++ b/C4/Search.pm @@ -2099,12 +2099,13 @@ sub searchResults { my $userenv =

  1   2   3   4   >