[Koha-patches] [PATCH] [SIGNED-OFF] Bug 7598 - Acquisitions JavaScript contains untranslatable English strings

2013-07-16 Thread Srdjan
From: Owen Leonard oleon...@myacpl.org English strings in acq.js cannot be processed by the translation script. This patch moves the strings to the templates to be set as JS variables for use by the script. To test: - On the uncertain prices page, enter an invalid price and click save. You

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 10557: GetBooksellersWithLateOrders has an unused branch parameter

2013-07-16 Thread Srdjan
From: Jonathan Druart jonathan.dru...@biblibre.com C4::Booksellers::GetBooksellersWithLateOrders has an unused parameter. The $branch variable is never used in the routine. Test plan: Check that no behavior changes on the late orders page. Signed-off-by: Srdjan srd...@catalyst.net.nz ---

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 2394: Use syspref canreservefromotherbranches in CanItemBeReserved

2013-07-16 Thread Srdjan
From: Julian Maurice julian.maur...@biblibre.com Signed-off-by: Srdjan srd...@catalyst.net.nz --- C4/Reserves.pm | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/C4/Reserves.pm b/C4/Reserves.pm index 5ff12e4..182af1a 100644 --- a/C4/Reserves.pm +++

[Koha-patches] [PATCH] Bug 2394: Use syspref canreservefromotherbranches in CanItemBeReserved

2013-07-16 Thread Srdjan
From: Julian Maurice julian.maur...@biblibre.com Signed-off-by: Srdjan srd...@catalyst.net.nz --- C4/Reserves.pm | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/C4/Reserves.pm b/C4/Reserves.pm index c8b0cdd..87ffaff 100644 --- a/C4/Reserves.pm +++

[Koha-patches] [PATCH] Bug 10597 - Search to hold button broken on record details

2013-07-16 Thread Srdjan
From: Kyle M Hall k...@bywatersolutions.com The holds button in cat-toolbar is broken for search to hold. It is a split button rather than a dropdown button. Clicking the caret works fine, but clicked the button sends you to the marc editor! Test Plan: 1) View a patron's details page 2) Click

[Koha-patches] [PATCH] Bug 10595 - OpacTopissue page still accessible when system preference is turned off

2013-07-16 Thread Srdjan
From: Mirko Tietgen mi...@abunchofthings.net When the syspref is turned off, the link is hidden but the page is still accessible. This patch checks the syspref and redirects to 404 if it is disabled. Test plan: Before applying the patch Enable OpacTopissue Observe there is a link to

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 10543 - false mandatory warning in additem

2013-07-16 Thread Srdjan
From: Fridolyn SOMERS fridolyn.som...@biblibre.com When editing a item, you get a popup warning : 1 mandatory fields empty (highlighted). But all mandatory fields are filled. This is because there is a field with a huge content (more than 100 characters), it it displayed in a textarea instead

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 10543 - Unify item mandatory subfields check

2013-07-16 Thread Srdjan
From: Fridolyn SOMERS fridolyn.som...@biblibre.com Use of CheckMandatorySubfields from cataloging.js everywhere an item cataloging form is checked for mandatories Signed-off-by: Srdjan srd...@catalyst.net.nz --- .../intranet-tmpl/prog/en/modules/acqui/neworderempty.tt | 9 ++---

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 10543 - add mandatory subfield check to addorderiso2709.pl

2013-07-16 Thread Srdjan
From: Fridolyn SOMERS fridolyn.som...@biblibre.com When adding orders from staged file, you can create one order per record using item form in the bottom of addorderiso2709.pl. This form was missing check. Signed-off-by: Srdjan srd...@catalyst.net.nz ---

[Koha-patches] [PATCH] Bug 7019: Circulation History Sort Order Wrong (in datatable)

2013-07-16 Thread Srdjan
From: Fridolyn SOMERS fridolyn.som...@biblibre.com The return date column sort is not using the date sort algorithm because it is confused by the combination of date data and text data (Checked out). This patch adds the use of datatable title-string sort type. With that, the date in ISO format

[Koha-patches] [PATCH] bug 10559: remove spurious statement handle still active warnings

2013-07-16 Thread Srdjan
From: Galen Charlton g...@esilibrary.com Generating (e.g.) overdue notices can result in spurious warnings in the cronjob logs: $ ./misc/cronjobs/overdue_notices.pl -t -library CPL prepare_cached(SELECT * FROM issues WHERE itemnumber = ?) statement handle DBI::st=HASH(0x54a7828) still

[Koha-patches] [PATCH] Bug 10463 - Quote of the day feature not selecting random quotes

2013-07-16 Thread Srdjan
From: Kyle M Hall k...@bywatersolutions.com When the Quote of the Day tool selects a new new quote, it updates the timestamp and does not take the timezone into account. Thus the time is set to +4 hours (e.g. 2013-06-11 13:33:48 when the time is 2013-06-11 09:33:48). It then repeats the