[Koha-patches] [PATCH] [SIGNED-OFF] Partial fix for Bug 4870, Damaged status does not prevent items from being selected for reserves

2011-04-06 Thread Christophe Croullebois
be included in the holds queue report. Signed-off-by: Christophe Croullebois christophe.croulleb...@biblibre.com --- misc/cronjobs/holds/build_holds_queue.pl |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/misc/cronjobs/holds/build_holds_queue.pl b/misc/cronjobs/holds

[Koha-patches] [PATCH] [SIGNED-OFF] Bug #6119 - Add biblioitems.itemtype in columns for items.content

2011-04-07 Thread Christophe Croullebois
From: Alex Arnaud alex.arn...@biblibre.com Signed-off-by: Christophe Croullebois christophe.croulleb...@biblibre.com --- misc/cronjobs/overdue_notices.pl |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs

[Koha-patches] [PATCH] [SIGNED-OFF] Bug #6052 - BranchTransfer Limit :Adds a default value

2011-04-08 Thread Christophe Croullebois
From: Alex Arnaud alex.arn...@biblibre.com Signed-off-by: Christophe Croullebois christophe.croulleb...@biblibre.com --- admin/branch_transfer_limits.pl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/admin/branch_transfer_limits.pl b/admin/branch_transfer_limits.pl

[Koha-patches] (no subject)

2011-05-12 Thread Christophe Croullebois
In the UNIMARslim2OAID.xsl the link to biblio was hardcoded, with this patch it takes the value of OPACBaseURL. --- .../prog/en/xslt/UNIMARCslim2OAIDC.xsl |2 +- opac/oai.pl|3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff

[Koha-patches] bug 6334 [PATCH 1/1] In the UNIMARslim2OAID.xsl the link to biblio was hardcoded, with this patch it takes the value of OPACBaseURL.

2011-05-12 Thread Christophe Croullebois
--- .../prog/en/xslt/UNIMARCslim2OAIDC.xsl |2 +- opac/oai.pl| 21 +++ 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslim2OAIDC.xsl

[Koha-patches] [PATCH 1/1] Bug 6268: (MT #6408) Bad Total in basket.pl

2011-05-16 Thread Christophe Croullebois
The total_est_gste or gsti is computed on the total_rrp_gste or gsti. But in the budget this amount is the summ of discounts computed for each line. Due to the rounding to 2 decimal places this produces a difference in Funds view with Total sublevels spent. --- acqui/basket.pl | 38

[Koha-patches] [PATCH 1/1] [PATCH] Bug 5860: Order cancelling improvement : delete attached items biblio if avalaible

2011-05-24 Thread Christophe Croullebois
- all items attached to the order are deleted - if there is no more items, and if the biblio is not in other orders then the biblio is proposed to deletion Now whe have 2 links : delete order and delete order and biblio, the second one appears only if the deletion is possible. ---

[Koha-patches] [PATCH 1/1] [PATCH] Bug 5680: Order cancelling improvement : delete attached items biblio if avalaible

2011-05-25 Thread Christophe Croullebois
- all items attached to the order are deleted - if there is no more items, and if the biblio is not in other orders then the biblio is proposed to deletion Now whe have 2 links : delete order and delete order and biblio, the second one appears only if the deletion is possible. ---

[Koha-patches] [PATCH 1/1] Bug 6566 Checking if DB's records are properly indexed

2011-07-08 Thread Christophe Croullebois
Small script that checks that each biblio in the DB is properly indexed (MT #6389) --- misc/migration_tools/checkNonIndexedBiblios.pl | 69 1 files changed, 69 insertions(+), 0 deletions(-) create mode 100755 misc/migration_tools/checkNonIndexedBiblios.pl diff --git

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 6080: total is wrong in acqui-home.pl

2011-07-08 Thread Christophe Croullebois
the total BibLibre MT5446 Signed-off-by: Christophe Croullebois christophe.croulleb...@biblibre.com --- acqui/acqui-home.pl| 16 .../prog/en/modules/acqui/acqui-home.tt| 11 --- 2 files changed, 0 insertions(+), 27 deletions

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 6562: Silence runtime error in reserve/request.pl

2011-08-05 Thread Christophe Croullebois
From: Colin Campbell colin.campb...@ptfs-europe.com Not defining action just causes logging of noisy runtime warnings. Signed-off-by: Christophe Croullebois christophe.croulleb...@biblibre.com --- reserve/request.pl |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

[Koha-patches] [PATCH 1/1] Bug 5680: Order cancelling improvement : delete attached items biblio if avalaible

2011-10-09 Thread Christophe Croullebois
- all items attached to the order are deleted - if there is no more items, and if the biblio is not in other orders and no subscriptions and no holds then the biblio is proposed to deletion Now whe have 2 links : delete order and delete order and catalog record, the second one appears only if

[Koha-patches] [PATCH 1/1] Bug 7105: Bad request in GetSubscriptions

2011-10-27 Thread Christophe Croullebois
If $string or $issn is passed to GetSubscriptions, the request is false. See Bug 5864, especially the last comment from Frédérick Capovilla. --- C4/Serials.pm |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/C4/Serials.pm b/C4/Serials.pm index 8aa6ebc..aebc783 100644

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 7117: Bug 7117 - Small display problems when organising suggestion tabs by name

2011-11-04 Thread Christophe Croullebois
is correct. After patch: all names should be consistent and correct. Signed-off-by: Christophe Croullebois christophe.croulleb...@biblibre.com --- suggestion/suggestion.pl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl index

[Koha-patches] [PATCH 1/1] Bug 6663: Features for holidays.pl

2011-12-02 Thread Christophe Croullebois
Allow to select a range between 2 dates and in one submit creates holidays only on these days. I add also Holidays repeated yearly on a range. --- .../intranet-tmpl/prog/en/css/staff-global.css |2 + .../prog/en/modules/tools/holidays.tt | 28 +++- tools/newHolidays.pl

[Koha-patches] [PATCH 1/1] Bug 7329: Items onloan are deleted when undoing import into catalog

2011-12-07 Thread Christophe Croullebois
this patch checks the on loan and reserved status before deleting item, and do noting in this case, so the record can't be deleted due to existing item. --- C4/ImportBatch.pm | 19 --- 1 files changed, 12 insertions(+), 7 deletions(-) diff --git a/C4/ImportBatch.pm

[Koha-patches] [PATCH 1/1] Bug 7350: In neworderempty.pl duplicating an item does not preserve select box selections

2011-12-13 Thread Christophe Croullebois
cloneNode() does not preserve select box selections, I have created a function to duplicate them : clone_with_selected. It is included in cloneItemBlock, that's all. Now the values selected in ddl are duplicated as the imput-texts are. --- koha-tmpl/intranet-tmpl/prog/en/js/additem.js | 15

[Koha-patches] [PATCH 1/1] Bug 8136 Changes the expected lenght of 100$a in rebuild_zebra.pl

2012-05-22 Thread christophe croullebois
In rebuild_zebra.pl, if we are in unimarc (marcflavour syspref), the sub fix_unimarc_100 is called and checks if 100$a lenght is equal to 35. If it is not the case, the sub inserts the localtime and more, so we loose the datas in reindexing. The standart lenght is 36. I have just changed 35 to

[Koha-patches] [PATCH 1/1] Bug 7351 : Patch for minor visual changes

2012-06-01 Thread Christophe Croullebois
I have just put a space between the radio button and the text for the new lines.. And I have replaced tabulations by space. You must have applied before : [SIGN OFF]Bug 7351 : feature that allows to delete a range of dates Patch for minor textual changes --- .../prog/en/modules/tools/holidays.tt

[Koha-patches] [PATCH 1/1] Bug 8197 : Software error when you have cleaned cookies and try to past the url to opac-topissues.pl

2012-06-06 Thread christophe croullebois
Try to delete cookies and paste the url to opac-topissues.pl. Without the patch we have a Software error. --- opac/opac-topissues.pl |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/opac/opac-topissues.pl b/opac/opac-topissues.pl index 6ecc6ad..7fb902e 100755 ---

[Koha-patches] [PATCH 1/1] Bug 6566 Checking if DB's records are properly indexed

2012-06-21 Thread christophe croullebois
From: Christophe Croullebois christophe.croulleb...@biblibre.com Small script that checks if each bibliorecord in the DB is properly indexed use -h to learn more (MT #6389) --- misc/migration_tools/checkNonIndexedBiblios.pl | 108 1 file changed, 108 insertions

[Koha-patches] [PATCH 1/1] [PATCH] [SIGN OFF]Bug 7351 : feature that allows to delete a range of dates

2012-07-15 Thread Christophe Croullebois
From: christophe croullebois christophe.croulleb...@biblibre.com Four new options, one for single holidays, one for the repeatable holidays. One to create exceptions on a range of dates, one to delete exceptions in a range of dates. Note that the exceptions are not deleted if you delete a range

[Koha-patches] [PATCH 1/1] Bug 8537 : In moremember.pl the call of 'output_pref' is without check

2012-07-31 Thread Christophe Croullebois
the argument passed to output_pref, could be undefined, in this case koha is not happy. I just put a condition, the same logic than for the line below. --- members/moremember.pl |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/members/moremember.pl b/members/moremember.pl

[Koha-patches] [PATCH 1/1] Bug 8637: Lack of control on mandatory in orderreveive.tt

2012-08-14 Thread Christophe Croullebois
Just add a check in Jscript when the form is submited, the same as in additem.tt --- .../prog/en/modules/acqui/orderreceive.tt | 22 1 file changed, 22 insertions(+) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt

[Koha-patches] [PATCH 1/1] Bug 8637: Lack of control on mandatory in orderreveive.tt

2012-08-22 Thread Christophe Croullebois
Just add a check in Jscript when the form is submited, the same as in additem.tt On Owen's suggestion I have added the red color and 'Required', the same as in additem. On Jonathan's suggestion I have used the CSS class for red and italic and I have changed a variable's name (alertString2).

[Koha-patches] [PATCH 1/1] Bug 8637: Lack of control on mandatory in orderreveive.tt

2012-08-22 Thread Christophe Croullebois
Just add a check in Jscript when the form is submited, the same as in additem.tt On Owen's suggestion I have added the red color and 'Required', the same as in additem. On Jonathan's suggestion I have used the CSS class for red and italic and I have changed a variable's name (alertString2).

[Koha-patches] [PATCH 1/1] Bug 8795: Adding the login branch as default in orderreceive.tt

2012-09-20 Thread Christophe Croullebois
The homebranch and holdingbranch ddl in item block are not default selected. I just put the default choice as the login branch. --- C4/Items.pm |1 + 1 file changed, 1 insertion(+) diff --git a/C4/Items.pm b/C4/Items.pm index e9af3dd..40751e7 100644 --- a/C4/Items.pm +++ b/C4/Items.pm @@

[Koha-patches] [PATCH 1/1] Bug 8218 : A script for maintenance to clean any amp;

2012-09-28 Thread Christophe Croullebois
Two subs written by Alex Arnaud in C4/Charset.pm, SanitizeEntity and entity_clean I had created two scripts for Biblibre, one to be used in cron, it reindexes all transformed records. Sophie Meynieux brought together the two scripts, she has created a batch mode, usefull but without the

[Koha-patches] [PATCH 1/1] Bug 9087: In Search.pl if there is parenthesis in itemcallnumber the link is broken

2012-11-15 Thread Christophe Croullebois
The search with parenthesis in 'q=x(x)xx' raises an error message: Can't call method sort on an undefined value at /home/koha/src/C4/Search.pm line 404. The easier way to solve this problem is to put quotes for the query, q=(x)xx --- .../prog/en/modules/catalogue/results.tt |

[Koha-patches] [PATCH 1/1] Bug 8218 : A script for maintenance to clean any amp;

2012-11-26 Thread Christophe Croullebois
Two subs written by Alex Arnaud in C4/Charset.pm, SanitizeEntity and entity_clean I had created two scripts for Biblibre, one to be used in cron, it reindexes all transformed records. Sophie Meynieux brought together the two scripts, she has created a batch mode, usefull but without the

[Koha-patches] [PATCH 1/1] Bug 9243: Bad delete order in sub index-records

2012-12-07 Thread Christophe Croullebois
If we have in the zebraqueue table for the same record, one line update and another delete, the index_records sub in rebuild_zebra.pl treats the delete line first. The result is that the record still exists in zebra. --- misc/migration_tools/rebuild_zebra.pl | 10 +- 1 file changed, 5

[Koha-patches] [PATCH 1/1] bug 9835: Lack of brackets in patron-attr-types.pl line 300

2013-03-18 Thread Christophe Croullebois
produces a warning 'Can't call method branches on an undefined value'... --- admin/patron-attr-types.pl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/admin/patron-attr-types.pl b/admin/patron-attr-types.pl index 3935f40..76c98df 100755 --- a/admin/patron-attr-types.pl

[Koha-patches] [PATCH 1/1] bug 7228 : can't add items in an order with Modify

2013-04-18 Thread Christophe Croullebois
We have a message if we want to add items and we can't add, substract only. It's ok if we choose to create items on ordering, in this case koha can't add items, just substract and in this case we have to delete manually the items(s) in the catalog. But if via the syspref AcqCreateItem we choose

[Koha-patches] [PATCH] Bug 13697 : Option to do not add a fee, if the patron changes to a category with enrolment fee

2015-02-11 Thread Christophe Croullebois
--- C4/Members.pm |2 ++ installer/data/mysql/updatedatabase.pl |7 +++ 2 files changed, 9 insertions(+) diff --git a/C4/Members.pm b/C4/Members.pm index 6f95b94..1cec21f 100644 --- a/C4/Members.pm +++ b/C4/Members.pm @@ -811,7 +811,9 @@ sub ModMember {

[Koha-patches] [PATCH 1/1] Bug 13768: Correction of double quotes escaped into double quotes

2015-03-10 Thread Christophe Croullebois
Without the patch the translated pages for quotes.tt may have the problematic line broken. So the js is broken too. The line with bad usage of double quotes escaped : var sEmptyTable = _(No quotes available. Please use the \Add quote\ button to add a quote.); ---