This requires us to specify all LDAP mappings in koha-conf.xml in lowercase,
instead of original case used withing LDAP.
Compare readability of
userid is=hrEduPersonUniqueID /userid
(which doesn't work) with required (and non-intuitive)
userid is=hredupersonuniqueid /userid
---
When using RFID readers which emulate keystrokes browser sometimes picks
numbers for barcodes or borrowers from history which generates wrong
transactions.
---
.../intranet-tmpl/prog/en/includes/cat-search.inc |4 ++--
.../intranet-tmpl/prog/en/includes/circ-search.inc |2 +-
devices support UTF-8.
I added similar comment on bug:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4828
with idea to make it configuration option.
--
Dobrica Pavlinusic 2share!2flamedpav...@rot13.org
Unix addict. Internet consultant. http://www.rot13
---
C4/Biblio.pm | 25 +
1 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/C4/Biblio.pm b/C4/Biblio.pm
index 1b378df..f9a19dd 100644
--- a/C4/Biblio.pm
+++ b/C4/Biblio.pm
@@ -2376,6 +2376,31 @@ sub PrepareItemrecordDisplay {
When importing users from LDAP, Auth_with_ldap.pm doesn't check if value for
categorycode is present in categories table in Koha resulting in referential
integrity error instead of using default value from koha-conf.xml
---
C4/Auth_with_ldap.pm | 13 +
1 files changed, 13
When importing users from LDAP, Auth_with_ldap.pm doesn't check if value for
categorycode is present in categories table in Koha resulting in referential
integrity error instead of using default value from koha-conf.xml
---
C4/Auth_with_ldap.pm | 11 +++
1 files changed, 11
Partial re-indexing is mostly useful when experimenting with Zebra
configuration and your test database is too large to be re-indexed for each
trial.
I'm submitting it after I added this twice to source code of rebuild_zebra.pl
and I hope it might prove useful to others also.
Test scenario:
1.
of each file prior to deleting it, so that short of an actual problem
with removing the file, the script can continue. Note that the fix for bug 6929
is also needed to prevent any problems with stopping Zebra from killing
koha-remove.
Signed-off-by: Dobrica Pavlinusic dpav...@rot13.org
---
debian
Currently, -v option resets Zebra log output to default system values.
This produce amount of log specified in system defaults which is usually
too low for debugging.
This change explicitly forces all Zebra log output which create much more
chatter so it triggers with verbosity level 2
Test
to debug the search query.
my two cents.
all is very verbose, but does provide additional information about Zebra
progress (I must admit I'm leaning towards too much information as
opposed to too little).
Should I move all to verbose level 3 (-v -v -v) or just remove it all
together?
--
Dobrica
On Tue, Dec 20, 2011 at 04:54:17PM +0100, LAURENT Henri-Damien wrote:
Le 20/12/2011 15:52, Dobrica Pavlinusic a écrit :
On Tue, Dec 20, 2011 at 02:06:24PM +0100, LAURENT Henri-Damien wrote:
-if ($verbose_logging) {
-$zebraidx_log_opt = '';
+if ($verbose_logging = 2
In current version of code, it gets initialized too late, so it produces
unitialized warnings for hidden fields (which is non-fatal) and breaks
generated JavaScript for AJAX value_builders (which is fatal)
This bug was introduced in ticket 6106 which is modification of 5955
which didn't have this
On Tue, Jan 17, 2012 at 03:25:46PM +0100, Dobrica Pavlinusic wrote:
In current version of code, it gets initialized too late, so it produces
unitialized warnings for hidden fields (which is non-fatal) and breaks
generated JavaScript for AJAX value_builders (which is fatal)
This bug
---
labels/label-edit-layout.pl |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/labels/label-edit-layout.pl b/labels/label-edit-layout.pl
index 5a45d5c..db3d32c 100755
--- a/labels/label-edit-layout.pl
+++ b/labels/label-edit-layout.pl
@@ -44,7 +44,7 @@ my ( $template,
---
acqui/basketgroup.pl |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/acqui/basketgroup.pl b/acqui/basketgroup.pl
index d2e1856..3300cea 100755
--- a/acqui/basketgroup.pl
+++ b/acqui/basketgroup.pl
@@ -60,7 +60,7 @@ use C4::Members qw/GetMember/;
my $input=new CGI;
---
acqui/z3950_search.pl | 42 +-
1 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/acqui/z3950_search.pl b/acqui/z3950_search.pl
index 80503e0..4d4545e 100755
--- a/acqui/z3950_search.pl
+++ b/acqui/z3950_search.pl
@@ -64,7 +64,6 @@ my
---
members/pay.pl |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/members/pay.pl b/members/pay.pl
index e3377bf..f1a9fca 100755
--- a/members/pay.pl
+++ b/members/pay.pl
@@ -43,7 +43,7 @@ use C4::Members::Attributes qw(GetBorrowerAttributes);
my $input = CGI-new;
---
reports/bor_issues_top.pl |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/reports/bor_issues_top.pl b/reports/bor_issues_top.pl
index 95fc287..126cdef 100755
--- a/reports/bor_issues_top.pl
+++ b/reports/bor_issues_top.pl
@@ -102,7 +102,7 @@ if ($do_it) {
---
serials/subscription-add.pl |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/serials/subscription-add.pl b/serials/subscription-add.pl
index 9acee7b..7fbe16b 100755
--- a/serials/subscription-add.pl
+++ b/serials/subscription-add.pl
@@ -34,7 +34,7 @@ use Carp;
#use
---
tools/upload-file.pl |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/upload-file.pl b/tools/upload-file.pl
index d520b4d..a27e719 100755
--- a/tools/upload-file.pl
+++ b/tools/upload-file.pl
@@ -46,7 +46,7 @@ if ($auth_status ne ok) {
exit 0;
}
-my
---
tools/letter.pl |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/letter.pl b/tools/letter.pl
index eb9d6a6..44f21ab 100755
--- a/tools/letter.pl
+++ b/tools/letter.pl
@@ -85,17 +85,17 @@ sub protected_letters {
return { map { $_-[0] = 1 } @{$codes} };
Simple command-line client which can authorize itself to Koha,
get MARC XML record based on biblio number and update record
---
misc/migration_tools/koha-svc.pl | 126 ++
1 files changed, 126 insertions(+), 0 deletions(-)
create mode 100755
Simple command-line client which can authorize itself to Koha,
get MARC XML record based on biblio number and update record
This script can also be used as module using require koha-svc.pl
from other scripts which can implement MARC XML creation or parsing.
---
misc/migration_tools/koha-svc.pl |
In current version of code, it gets initialized too late, so it produces
unitialized warnings for hidden fields (which is non-fatal) and breaks
generated JavaScript for AJAX value_builders (which is fatal)
This bug was introduced in ticket 6106 which is modification of 5955
which didn't have this
transfer $template to add_matcher_list for correct scoping
---
tools/manage-marc-import.pl |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/manage-marc-import.pl b/tools/manage-marc-import.pl
index 34d2639..587d520 100755
--- a/tools/manage-marc-import.pl
+++
scoping fixes for Variable * is not available errors
---
admin/authorised_values.pl | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/admin/authorised_values.pl b/admin/authorised_values.pl
index 5282022..1545f0e 100755
--- a/admin/authorised_values.pl
+++
otherwise, we get a lot of MySQL server has gone away error messages
---
C4/VirtualShelves.pm |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/C4/VirtualShelves.pm b/C4/VirtualShelves.pm
index 85dbc9f..a37db41 100644
--- a/C4/VirtualShelves.pm
+++ b/C4/VirtualShelves.pm
---
admin/currency.pl | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/admin/currency.pl b/admin/currency.pl
index 1e3f160..e24f6b6 100755
--- a/admin/currency.pl
+++ b/admin/currency.pl
@@ -46,14 +46,14 @@ use C4::Dates qw(format_date);
use C4::Output;
use
---
admin/item_circulation_alerts.pl |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/admin/item_circulation_alerts.pl b/admin/item_circulation_alerts.pl
index bba5d60..ee77ae8 100755
--- a/admin/item_circulation_alerts.pl
+++ b/admin/item_circulation_alerts.pl
@@ -33,7
---
admin/marctagstructure.pl |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/admin/marctagstructure.pl b/admin/marctagstructure.pl
index 92e0d99..d7c2fe0 100755
--- a/admin/marctagstructure.pl
+++ b/admin/marctagstructure.pl
@@ -44,7 +44,7 @@ my $pagesize = 20;
my
---
admin/patron-attr-types.pl |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/admin/patron-attr-types.pl b/admin/patron-attr-types.pl
index 29a0d90..da5b6c1 100755
--- a/admin/patron-attr-types.pl
+++ b/admin/patron-attr-types.pl
@@ -30,11 +30,11 @@ use
---
admin/systempreferences.pl |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/admin/systempreferences.pl b/admin/systempreferences.pl
index f4069ae..96a9957 100755
--- a/admin/systempreferences.pl
+++ b/admin/systempreferences.pl
@@ -67,7 +67,7 @@ use YAML::Syck qw(
we get a lot of MySQL server has gone away error messages and
defining global $dbh isn't the best solution. Existing code
gets $dbh from context in some subs, so this change makes it always
use $dbh from context.
---
C4/VirtualShelves.pm | 15 +--
1 files changed, 13 insertions(+),
So we shouldn't try to delete it. This produces application error
instead of redirection to login page.
I had similar problems with CGI, especially when session in browser
is still active, and one on filesystem or database is already expired.
---
C4/Auth.pm |2 +-
1 files changed, 1
This fixes scope of $query and $nextexpected
---
serials/subscription-add.pl |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/serials/subscription-add.pl b/serials/subscription-add.pl
index 9acee7b..4038e1a 100755
--- a/serials/subscription-add.pl
+++
transfer $template to add_matcher_list for correct scoping
and score $dbh and $runinbackground with our
---
tools/manage-marc-import.pl |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/manage-marc-import.pl b/tools/manage-marc-import.pl
index 34d2639..cc22aeb
duplicate_framework needs $dbh so we get it from C4::Context
---
admin/marctagstructure.pl |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/admin/marctagstructure.pl b/admin/marctagstructure.pl
index 92e0d99..a86d788 100755
--- a/admin/marctagstructure.pl
+++
$uploaded_file is now scoped with our, and we set correct filename
---
tools/upload-file.pl |7 ++-
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/tools/upload-file.pl b/tools/upload-file.pl
index d520b4d..b705f5c 100755
--- a/tools/upload-file.pl
+++
From: Stéphane Delaune stephane.dela...@biblibre.com
Signed-off-by: Marijana Glavica mglav...@ffzg.hr
I am signing it off because it doesn't break anything and I will report
another bug for language issues described in my previous comment.
---
C4/Search.pm
schrieb Dobrica Pavlinusic dpav...@rot13.org:
From: Stéphane Delaune stephane.dela...@biblibre.com
Signed-off-by: Marijana Glavica mglav...@ffzg.hr
I am signing it off because it doesn't break anything and I will report
another bug for language issues described in my previous comment
From: Stéphane Delaune stephane.dela...@biblibre.com
Signed-off-by: Marijana Glavica mglav...@ffzg.hr
I am signing it off because it doesn't break anything and I will report
another bug for language issues described in my previous comment.
Removed MySQLism backquotes
---
C4/Search.pm
In Bug 7772 Ian correctly noted that reports have exit(1) all over the place.
This is left over from old code, and this patch changes them to exit(0).
I decided to use plain exit as opposed to explicit exit(0) since it produces
cleaner code, but I'm welcoming suggestion on this.
---
Implement auto-incrementing EAN-13 barcodes
To make this work, C4::Barcodes::next was modified to call process_tail with
new incremented value so that process_tail can generate correct checksum.
Since process_tail is currenlty not used by any barcodes, this change is safe.
C4::Barcodes is used
Current implementation doesn't scale barcodes because low-price
CCD barcode readers are very sensitive about size
Test scenario:
1. in Tools Labels create or edit Layout and select EAN13 as barcode
type
2. export one of existing batches using EAN13 layout and verify that
generated pdf
koha.psgi example and script to run any Koha site intranet or opac under plack
It also defines new enviroment variables:
PLACK_DEBUG=1 - turn Plack debug panels on
PLACK_MINIFY=1 - minify JavaScript and CSS which saves us ~10k on each page load
Test scenario:
1. install plack and dependencies,
Bareword C4::Templates::_current_language not allowed while strict subs in
use at /home/oleonard/kohaclone/C4/XSLT.pm line 175.
---
C4/XSLT.pm |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/C4/XSLT.pm b/C4/XSLT.pm
index a22f2e5..56ba544 100644
--- a/C4/XSLT.pm
+++
Updating database structure
Update errors :
Can't locate C4/Context.pm in @INC (@INC contains: /etc/perl
/usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1 /usr/lib/perl5
/usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10
/usr/local/lib/site_perl /usr/local/lib/perl/5.10.0
Variable $borrowernumber is not available at /srv/koha/members/pay.pl line
112.
Variable $borrower is not available at /srv/koha/members/pay.pl line 129.
Variable $input is not available at /srv/koha/members/pay.pl line 142.
Variable $borrowernumber is not available at /srv/koha/members/pay.pl
Variable $query is not available at
/srv/koha/virtualshelves/addbybiblionumber.pl line 115.
Variable $loggedinuser is not available at
/srv/koha/virtualshelves/addbybiblionumber.pl line 129.
Variable $shelfnumber is not available at
/srv/koha/virtualshelves/addbybiblionumber.pl line 134.
koha.psgi example and script to run any Koha site intranet or opac under plack
This means that it will use sudo to switch to correct site-koha user for
configuration and plack process
It also defines new enviroment variables:
PLACK_DEBUG=1 - turn Plack debug panels on
PLACK_MINIFY=1 - minify
From: Chris Cormack chr...@catalyst.net.nz
This bug was uncovered by @mglavica during HackFest in Marseille
It also showed it's ugly head during my plack presentation there.
It's introduced by commit b65efdaacaf77fb53fee479da7f2e990ba0adeed
which is Bug 6027
Signed-off-by: Dobrica Pavlinusic
Test scenario:
1. issue search query
2. select 1 result
3. add to: new list, list-1, private
4. select 2 results
5. add to (exiting) list-1
4. select 3 results
6. add to: new list, list-2, public
7. using lists drop-down, view and delete list-1 and list-2
---
opac/opac-addbybiblionumber.pl |
SQL queries fetch all results and use first row. Adding frameworkcode
to SQL queries will help returning just one (correct) row,
improve performance and allow caching of values in future.
---
C4/Items.pm |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/C4/Items.pm
This bug was uncovered by @mglavica during HackFest in Marseille
It also showed it's ugly head during my plack presentation there.
Following chang removes circural dependecy introduced by commit
b65efdaacaf77fb53fee479da7f2e990ba0adeed which is part of Bug 6027
---
C4/Items.pm |1 -
1 files
koha.psgi example and plackup.sh script to run any Koha site
intranet or opac interface under plack with optional multi-process
Starman server
plackup.sh site-name [intranet]
site-name is used to find config /etc/koha/sites/site-name/koha-conf.xml
All configuration is specified in koha.psgi,
ShelfBrowser uses two SQL queries with syntax
WHERE ((cn_sort = ? AND itemnumber ?) OR cn_sort ?)
AND homebranch = ? AND location = ? AND ccode = ?
homebranch already has index, and adding indexes on ccode and location
improves performance by 30% for each query since MySQL is able to use
This simplifies code, and has nice side-effect that memoize of
C4::Koha functions will be more effective.
---
C4/Items.pm | 68 ++
1 files changed, 7 insertions(+), 61 deletions(-)
diff --git a/C4/Items.pm b/C4/Items.pm
index
ShelfBrowser uses two SQL queries with syntax
WHERE ((cn_sort = ? AND itemnumber ?) OR cn_sort ?)
AND homebranch = ? AND location = ? AND ccode = ?
homebranch already has index, and adding indexes on ccode and location
improves performance by 30% for each query since MySQL is able to use
On Fri, Apr 06, 2012 at 10:04:26PM +0200, Marc Balmer wrote:
Am 06.04.12 19:10, schrieb Dobrica Pavlinusic:
ShelfBrowser uses two SQL queries with syntax
WHERE ((cn_sort = ? AND itemnumber ?) OR cn_sort ?)
AND homebranch = ? AND location = ? AND ccode = ?
homebranch already has
koha.psgi example and plackup.sh script to run any Koha site
intranet or opac interface under plack with optional multi-process
Starman server
plackup.sh site-name [intranet]
site-name is used to find config /etc/koha/sites/site-name/koha-conf.xml
All configuration is specified in koha.psgi,
current code is using DISTINCT and another SQL query which can be replaced with
GROUP BY
for massive speedup. In our case, generating Manage Batches screen DBI time
decreased
from 24.762 s to 0.147 s
Aside from correct usage of relational database, this change also cleans up
code nicely.
Test
current code is using DISTINCT and another SQL query which can be replaced with
GROUP BY
for massive speedup. In our case, generating Manage Batches screen DBI time
decreased
from 24.762 s to 0.147 s
Aside from correct usage of relational database, this change also cleans up
code nicely.
This
On Fri, Apr 13, 2012 at 12:49:34PM +0200, Dobrica Pavlinusic wrote:
+use Carp;
+use Data::Dump qw(dump);
+
sub html_table {
+Carp::cluck(# html_table ,dump(@_));
my $headers = shift;
my $data = shift;
return undef if scalar(@$data) == 0; # no need to generate a table
Corrent code doesn't have support for filenames which contain spaces
or commans which breaks CSV files saved from spreadsheet similar to:
12345, conver image, with spaces.jpg
This patch tweaks file parsing a bit. We are always splitting line to
only two values (to support commas as part of
I don't
think can be done using this technique).
A follow-up patch should remove the individual images
which have been replaced by the sprite.
Signed-off-by: Dobrica Pavlinusic dpav...@rot13.org
---
koha-tmpl/opac-tmpl/prog/en/css/opac.css | 273 +++-
.../opac-tmpl
Simple command-line client which can authorize itself to Koha,
get MARC XML record based on biblio number and update record
This script can also be used as module using require koha-svc.pl
from other scripts which can implement MARC XML creation or parsing.
This is follow up version which now
Simple command-line client which can authorize itself to Koha,
get MARC XML record based on biblio number and update record
This script can also be used as module using require koha-svc.pl
from other scripts which can implement MARC XML creation or parsing.
This is follow up version which now
On Thu, Apr 19, 2012 at 04:48:42PM +0200, Dobrica Pavlinusic wrote:
Simple command-line client which can authorize itself to Koha,
get MARC XML record based on biblio number and update record
This script can also be used as module using require koha-svc.pl
from other scripts which can
Bug 7851 introduced our scoping for vairables, unfortunatly it has
side-effect that checkout rows accumulate on page reloads instead
of being initialized to empty array (which this patch fixes)
Test scenario:
1. start intranet under plack
2. open /cgi-bin/koha/circ/circulation.pl and reload page
koha.psgi example and plackup.sh script to run any Koha site
intranet or opac interface under plack with optional multi-process
Starman server
plackup.sh site-name [intranet]
site-name is used to find config /etc/koha/sites/site-name/koha-conf.xml
All configuration is specified in koha.psgi,
$dbh needs our scoping when using Add item to prevent error
Can't call method prepare on an undefined value at
/srv/koha/cataloguing/additem.pl line 88.
Test scenario:
1. start intranet with plack
2. select one Edit items on one record
3. fill in new item and click on Add item
---
Bug 7851 introduced our scoping for vairables, unfortunatly it has
side-effect that checkout rows accumulate on page reloads instead
of being initialized to empty array (which this patch fixes)
This also fixes %renew_failed initialization on each request.
Test scenario:
1. start intranet under
Scope our $template for plack to prevent following error:
Can't call method param on an undefined value at
/srv/koha_ffzg/acqui/parcels.pl line 177.
Test scenario:
1. Home Acquisitions Search for vendor
2. click on Receive shipment
---
acqui/parcels.pl |2 +-
1 files changed, 1
Without name option to prFile, PDF::Reuse opens '-' file which is real
console STDOUT on plack so pdf file gets emited to terminal instead of
sending it to browser.
This change creates temporary file using File::Temp, pass it to PDF::Reuse
and then reads it back and prints it out for plack (or
Corrent code doesn't have support for filenames which contain spaces
or commans which breaks CSV files saved from spreadsheet similar to:
12345, conver image, with spaces.jpg
This patch tweaks file parsing a bit. We are always splitting line to
only two values (to support commas as part of
koha.psgi example and plackup.sh script to run any Koha site
intranet or opac interface under plack with optional multi-process
Starman server
plackup.sh site-name [intranet]
site-name is used to find config /etc/koha/sites/site-name/koha-conf.xml
All configuration is specified in koha.psgi,
Without name option to prFile, PDF::Reuse opens '-' file which is real
console STDOUT on plack so pdf file gets emited to terminal instead of
sending it to browser.
This change creates temporary file using File::Temp, pass it to PDF::Reuse
and then reads it back and prints it out for plack (or
Corrent code doesn't have support for filenames which contain spaces
or commans which breaks CSV files saved from spreadsheet similar to:
12345, conver image, with spaces.jpg
This patch tweaks file parsing a bit. We are always splitting line to
only two values (to support commas as part of
koha.psgi example and plackup.sh script to run any Koha site
intranet or opac interface under plack with optional multi-process
Starman server
plackup.sh site-name [intranet]
site-name is used to find config /etc/koha/sites/site-name/koha-conf.xml
All configuration is specified in koha.psgi,
Since we are now using temporary file, we are creating test.pdf
at end of test and checking if it exists and have non-zero size.
---
t/Creators.t | 12 +---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/t/Creators.t b/t/Creators.t
index 720aa2c..85701c2 100755
---
URL: /cgi-bin/koha/acqui/basketheader.pl?booksellerid=32op=add_form
I'm also getting mysql referential integrity error:
DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha_srvgit`.`aqbasket`, CONSTRAINT `aqbasket_ibfk_1`
FOREIGN KEY
This is simple fix since day_month_closed_days hash has wrong arguments order.
---
Koha/Calendar.pm |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Koha/Calendar.pm b/Koha/Calendar.pm
index dc132cd..ab01e53 100644
--- a/Koha/Calendar.pm
+++ b/Koha/Calendar.pm
@@ -150,7
This is simple fix since day_month_closed_days hash has wrong arguments order.
---
Koha/Calendar.pm |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Koha/Calendar.pm b/Koha/Calendar.pm
index dc132cd..ab01e53 100644
--- a/Koha/Calendar.pm
+++ b/Koha/Calendar.pm
@@ -150,7
---
Koha/Calendar.pm |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Koha/Calendar.pm b/Koha/Calendar.pm
index ab01e53..2c372f2 100644
--- a/Koha/Calendar.pm
+++ b/Koha/Calendar.pm
@@ -147,7 +147,7 @@ sub is_holiday {
if ( $self-{weekly_closed_days}-[$dow] == 1
scope $input CGI object with our for plack
---
acqui/basketgroup.pl |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/acqui/basketgroup.pl b/acqui/basketgroup.pl
index 3300cea..fd49c30 100755
--- a/acqui/basketgroup.pl
+++ b/acqui/basketgroup.pl
@@ -58,7 +58,7 @@ use
scope $input CGI object with our for plack
---
acqui/basketgroup.pl |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/acqui/basketgroup.pl b/acqui/basketgroup.pl
index 3300cea..fd49c30 100755
--- a/acqui/basketgroup.pl
+++ b/acqui/basketgroup.pl
@@ -58,7 +58,7 @@ use
- remove all exit(1) and replace them with __END__ which benefits CGI
- insert correct =cut markers at end of POD (required for CGI::Compile
under plack to correctly parse source code and exeute it)
- scope variables with our which are used inside sub for plack
---
labels/label-create-csv.pl |
- remove all exit(1) and replace them with __END__ which benefits CGI
- insert correct =cut markers at end of POD (required for CGI::Compile
under plack to correctly parse source code and exeute it)
- scope variables with our which are used inside sub for plack
---
labels/label-create-csv.pl |
- remove all exit(1) and replace them with __END__ which benefits CGI
- insert correct =cut markers at end of POD (required for CGI::Compile
under plack to correctly parse source code and exeute it)
- scope variables with our which are used inside sub for plack
---
labels/label-create-csv.pl |
Sorry for confusion, this patch was surposed to be attached to Bug 8442,
but it seems it's too hot it Croatia for me to do it correctly :-)
--
Dobrica Pavlinusic 2share!2flamedpav...@rot13.org
Unix addict. Internet consultant. http://www.rot13.org/~dpavlin
Current code is overly complex and assumes that
C4::Members::AttributeTypes::GetAttributeTypes
returns array of attribute codes which is not true.
Instead it return array of hashes so none of extended attributes
will be replicated from LDAP.
This code correctly extracts extended attributes from
Current code is overly complex and assumes that
C4::Members::AttributeTypes::GetAttributeTypes
returns array of attribute codes which is not true.
Instead it return array of hashes so none of extended attributes
will be replicated from LDAP.
This code correctly extracts extended attributes from
This script has various encoding problems:
1. parametars from CGI are not encoded in utf-8, so when they are
compared with utf-8 strings from database every field with
utf-8 characters will be reported in e-mail as changed
2. when sending e-mail, wide characters are passed to Mail::Sendmail
This restores behaviour of new order form before Bug 5335 merge
Test scenario:
1. load Receipt summary for existing customer
2. take note of Unit cost and Order cost
3. open existing order line and verify that Replacement cost,
Budgeted cost and Total are not re-calculated on page load
4.
Seems like simple omission when passing $pars hash to
Z3950Search function.
Test scenario:
1. select any Z39.50 search form and enter valid ISSN
2. verify that you don't get any results from remote servers
3. apply this patch and re-check that results are now availble
---
name at
Koha/SearchEngine/Solr/Index.pm line 43.
Koha/SearchEngine/Solr/Index.pm had compilation errors.
after
Koha/SearchEngine/Solr/Index.pm syntax OK
Signed-off-by: Dobrica Pavlinusic dpav...@rot13.org
---
Koha/SearchEngine/Solr/Index.pm |2 +-
1 files changed, 1 insertions(+), 1
According to Firefox bug tracker, versions up to 21 doesn't print
tables correctly when using shrink to fit option. See:
https://bugzilla.mozilla.org/show_bug.cgi?id=684622
However, even with v21 or newer, we still need to add css to
print media which instruct it not to break table tag to print
If koha-common is started when zebra log files are owned by root
it will fail to start without any useful message (since zebra can't
write errors in log files because it lacks permissions to do so).
This patch creates empty log files and ensure they have correct
permissions.
I can't pin-point
According to Firefox bug tracker, versions up to 21 doesn't print
tables correctly when using shrink to fit option. See:
https://bugzilla.mozilla.org/show_bug.cgi?id=684622
However, even with v21 or newer, we still need to add css to
print media which instruct it not to break table tag to print
This allows users to select any columns from items and adds new
items.fine field introduced by previous patch to user interface.
---
tools/letter.pl |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/tools/letter.pl b/tools/letter.pl
index a462aba..68c6701 100755
---
1 - 100 of 124 matches
Mail list logo
