[Koha-patches] (BUG #4903) oai.pl: OAI doesn't work out of the box - XSL path

2010-06-24 Thread Tomas Cohen Arazi
diff --git a/opac/oai.pl b/opac/oai.pl index 546623e..1d189c1 100755 --- a/opac/oai.pl +++ b/opac/oai.pl @@ -463,7 +463,7 @@ sub oai_dc_stylesheet { unless ( $self-{ oai_dc_stylesheet } ) { my $xslt_file = C4::Context-config('intranetdir') . -

[Koha-patches] [PATCH] [Bug 3404] update INSTALL* to acknowledge the use of mod_deflate

2010-12-28 Thread Tomas Cohen Arazi
From: Tomás Cohen Arazi tomasco...@gmail.com --- INSTALL |2 +- INSTALL.debian |2 +- INSTALL.opensuse |8 INSTALL.ubuntu |2 +- INSTALL.ubuntu.lucid |2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/INSTALL b/INSTALL

Re: [Koha-patches] [PATCH] [Bug 5546] javascript version - cookies handling missing yet

2010-12-30 Thread Tomas Cohen Arazi
BTW, I've tested only on Firefox 3.6.13 and Google Chrome 9.0.557 (beta) (both on Ubuntu Maverick). To+ ___ Koha-patches mailing list Koha-patches@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-patches website :

[Koha-patches] [PATCH] [Bug 5783] Authorities edit logging

2011-02-21 Thread Tomas Cohen Arazi
--- C4/AuthoritiesMarc.pm |4 installer/data/mysql/en/mandatory/sysprefs.sql |1 + installer/data/mysql/updatedatabase.pl |7 +++ .../prog/en/modules/admin/preferences/logs.pref|6 ++

[Koha-patches] [PATCH] [Bug 5791] Robust handling of deleted biblios/authorities

2011-02-22 Thread Tomas Cohen Arazi
--- authorities/detail.pl | 110 +++- catalogue/detail.pl| 21 +++-- .../prog/en/modules/authorities/detail.tmpl| 98 +- .../prog/en/modules/catalogue/detail.tmpl | 11 ++- 4 files

[Koha-patches] [PATCH] [Bug 5546] Javascript driven ability to hide MARC documentation links

2011-03-01 Thread Tomas Cohen Arazi
--- cataloguing/addbiblio.pl |3 + .../prog/en/includes/doc-head-close.inc|1 + .../en/lib/jquery/plugins/jquery.cookie.min.js |1 + .../prog/en/modules/cataloguing/addbiblio.tmpl | 59 ++- 4 files changed, 60

[Koha-patches] [PATCH 3/3] [Bug 5791] (2/2) Error handling for ISBDdetail, MARCdetail and labeledMARCdetail

2011-03-09 Thread Tomas Cohen Arazi
This follow-up completes what Owen requested on bugzilla for the bug to be closed. If anything remains let me know. To+ --- C4/Biblio.pm |1 + catalogue/ISBDdetail.pl|9 + catalogue/MARCdetail.pl

[Koha-patches] [PATCH] [Bug 4389] Trigger quick slip print on empty checkout submit

2011-03-09 Thread Tomas Cohen Arazi
This old bug didn't have a patch attached. I don't know if it should be syspref controled for librarians convenience. Just let me know. To+ --- .../prog/en/modules/circ/circulation.tmpl |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[Koha-patches] [PATCH 2/2] [Bug 5166] Sysprefs

2011-03-21 Thread Tomas Cohen Arazi
--- installer/data/mysql/de-DE/mandatory/sysprefs.sql |5 +++ installer/data/mysql/en/mandatory/sysprefs.sql |5 +++ .../1-Obligatoire/unimarc_standard_systemprefs.sql |5 +++ installer/data/mysql/it-IT/necessari/sysprefs.sql |5 +++

[Koha-patches] [PATCH 3/3] [Bug 5166] zebraqueue daemon scripts

2011-03-21 Thread Tomas Cohen Arazi
+ +# Writen 02/03/2011 by Tomas Cohen Arazi (tomasco...@gmail.com) +# Universidad Nacional de Cordoba / Argentina + +# Daemon to watch the zebraqueue table and update zebra indexes as needed use strict; -#use warnings; FIXME - Bug 2505 BEGIN { # find Koha's Perl modules

[Koha-patches] [PATCH] [Bug 5667] Add entries so Z39.50 public server works

2011-03-30 Thread Tomas Cohen Arazi
I added a comment on the file so the user uncomments the appropriate koha-conf.xml sections. To+ --- etc/koha-conf.xml | 83 +++- 1 files changed, 81 insertions(+), 2 deletions(-) diff --git a/etc/koha-conf.xml b/etc/koha-conf.xml index

[Koha-patches] [PATCH] [Bug 4189] Searching z39.50 without selecting any servers results in error message

2011-03-30 Thread Tomas Cohen Arazi
This patch makes z3950_search.pl handle the situation properly, and z3950_search.tmpl show a proper message instead of a program error. All this, in case the javascript checks that alert the user (that at least one target has to be chosen) are by-passed. Regards To+ ---

[Koha-patches] [PATCH 4/4] [Bug 5166] New sysprefs submission

2011-04-04 Thread Tomas Cohen Arazi
Old patch needed to be updated as Chris C. asked, but the original patch didn't apply anymore. --- installer/data/mysql/de-DE/mandatory/sysprefs.sql |5 +++ installer/data/mysql/en/mandatory/sysprefs.sql |6 +++- .../1-Obligatoire/unimarc_standard_systemprefs.sql |5 +++

[Koha-patches] [PATCH 5/5] [Bug 5166] Sysprefs make 'experimental' nature explicit - again

2011-04-05 Thread Tomas Cohen Arazi
Created against new/enh/bug_5166 so it actually applies To+ --- installer/data/mysql/de-DE/mandatory/sysprefs.sql | 10 +- installer/data/mysql/en/mandatory/sysprefs.sql | 10 +- .../1-Obligatoire/unimarc_standard_systemprefs.sql | 10 +-

[Koha-patches] [PATCH 2/2] [Bug 4389] Missing semicolon breaks functionality

2011-04-06 Thread Tomas Cohen Arazi
There was a missing semicolon. --- .../prog/en/modules/circ/circulation.tmpl |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tmpl index

[Koha-patches] [PATCH] Bug 6193 - Use memcached cache koha-conf.xml configuration variables

2011-04-14 Thread Tomas Cohen Arazi
Basically I add some code to Context.pm so it stores koha-conf.xml config vars in memcached server. It is arguable whether this is an improvement or not, tests are needed to conclude something about this. Error handling was an issue with Cache::Memcached, I tried to do it the simplest I could.

[Koha-patches] [PATCH] Bug 5791 - Robust handling of deleted/non-existent biblios and authority records

2011-04-18 Thread Tomas Cohen Arazi
Patch reworked for master using Template::Toolkit. To+ --- C4/Biblio.pm |1 + authorities/detail.pl | 48 ++- catalogue/ISBDdetail.pl| 20 +--- catalogue/MARCdetail.pl

[Koha-patches] [PATCH] Bug 6319 - Provide language filter selection in adv an id inside a div

2011-05-06 Thread Tomas Cohen Arazi
Basically, put the language filter selection fieldset inside a div with its own id so it can be hidden through OPACUserCSS variable. --- .../opac-tmpl/prog/en/modules/opac-advsearch.tt|2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

[Koha-patches] [PATCH] Bug 6683 - (es-ES) translate SQL scripts description

2011-08-12 Thread Tomas Cohen Arazi
Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com --- .../data/mysql/es-ES/mandatory/auth_values.txt |2 +- .../data/mysql/es-ES/mandatory/class_sources.txt |2 +- .../es-ES/mandatory/message_transport_types.txt|3 +- .../data/mysql/es-ES/mandatory/sample_notices.txt

[Koha-patches] [PATCH] Bug 6193 - Use memcached cache koha-conf.xml configuration variables

2011-08-17 Thread Tomas Cohen Arazi
Basically I add some code to Context.pm so it stores koha-conf.xml config vars in memcached server. It is arguable whether this is an improvement or not, tests are needed to conclude something about this. Error handling was an issue with Cache::Memcached, I tried to do it the simplest I could.

[Koha-patches] [PATCH] Bug 6744 - Acknowledge the actual es-ES translators

2011-08-17 Thread Tomas Cohen Arazi
es-ES translator credits are way outdated as of http://translate.koha-community.org/es/34 Regards To+ --- koha-tmpl/intranet-tmpl/prog/en/modules/about.tt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt

[Koha-patches] [PATCH] Add my name to .mailmap

2011-12-12 Thread Tomas Cohen Arazi
Robin Sheat ro...@catalyst.net.nz Srdjan Jankovic srd...@catalyst.net.nz +Tomas Cohen Arazi tomasco...@gmail.com # Name to name mapping: the name in the right column will be mapped to the name in the left @@ -44,4 +45,5 @@ Chris Nighswonger

[Koha-patches] [PATCH] Bug 6193 - Follow up: use SetEnv and remove memcached from koha-conf.xml

2011-12-30 Thread Tomas Cohen Arazi
--- C4/Auth.pm| 17 - C4/Biblio.pm | 11 --- C4/Context.pm | 25 + C4/Languages.pm | 14 -- etc/koha-conf.xml |2 -- 5 files changed, 37 insertions(+), 32 deletions(-) diff --git a/C4/Auth.pm b/C4/Auth.pm

[Koha-patches] [PATCH] Bug 6000 : Performance enhancing

2012-01-04 Thread Tomas Cohen Arazi
From: Henri-Damien LAURENT henridamien.laur...@biblibre.com C4::Context.pm Loads all systempreferences at once And uses Memcached to cache them C4::Languages Using List::MoreUtils Memcaching get_langage_description Bug 6000 : Follow up Performance enhancing : C4/Languages.pm removing a call

[Koha-patches] [PATCH] Bug 8251 - Patrons get incorrectly debarred

2012-06-15 Thread Tomas Cohen Arazi
Patrons get incorrectly debarred because of the use of Datetime-delta_days wich happens to always return a positive number. Also changed the use of Datetime-truncate function so it follows the docs, using 'day' instead of 'days' (which is used in DateTime::Duration). This patch has been tested

[Koha-patches] [PATCH] Bug 8251 - Follow up, use 'day' instead of 'day' for Datetime::truncate

2012-06-21 Thread Tomas Cohen Arazi
As noted in comment #4 by Jonathan Druart, this should be fixed in every call to DateTie::truncate function. This patch does exactly that. julian_m tested that truncate( to = 'days' ) didn't actually do anything, so it is understandable that this 'fix' might introduce new bugs as we might have

[Koha-patches] [PATCH] Bug 8478 - Create an INSTALL file for 12.04

2012-07-23 Thread Tomas Cohen Arazi
parts copyright 2010 Chris Nighswonger + +Original author: Joshua Ferraro +Modified for Ubuntu by: Chris Nighswonger (cnighswonger AT foundations DOT edu) +Tomas Cohen Arazi (tomasco...@gmail.com) + +Feedback/bug reports: Koha Developer's List: +http://lists.koha

[Koha-patches] [PATCH] Bug 8520: fix authority display in staff client

2012-08-01 Thread Tomas Cohen Arazi
From: Jared Camins-Esakov jcam...@cpbibliography.com Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com --- .../en/includes/authorities-search-results.inc |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search

[Koha-patches] [PATCH] Bug 8519 - Make koha-index-daemon run on startup

2012-08-11 Thread Tomas Cohen Arazi
Added a new koha-index-daemon-ctl.sh script that uses the 'koha-index-daemon' provided by Koha::Contrib::Tamil (install via CPAN) to process the indexing queue ('zebraqueue' for now, 'indexqueue' in the future I guess :-P). This script could be easily modified in the future for using another

[Koha-patches] [PATCH] Bug 8750 - Chronological terms authorities not correctly indexed

2012-09-10 Thread Tomas Cohen Arazi
There was no entry in authority's record.abs for indexing chronological terms. They ccouldn't be searched and (obviously) linked. I've added those entries using the index names defined in authorities/etc/bib1.att Regards To+ Sponsored-by: Universidad Nacional de Córdoba ---

[Koha-patches] [PATCH] Bug 8800 - useDaysMode=Datedue wrong behaviour

2012-09-21 Thread Tomas Cohen Arazi
useDaysMode=Datedue wasn't used as advertised in the docs. Added a next_open_day sub to Koha::Calendar and some tests for it. - AddIssue was fixed for the case $datedue was defined in circ/circulation.pl - CalcDateDue was modified to be consistent with the intended behaviour Regards To+

[Koha-patches] [PATCH] Bug 8750 - Chronological terms authorities not correctly indexed (trivial fix)

2012-10-25 Thread Tomas Cohen Arazi
Patch re-done so it applies, had that double-utf8 problem There was no entry in authority's record.abs for indexing chronological terms. They ccouldn't be searched and (obviously) linked. I've added those entries using the index names defined in authorities/etc/bib1.att Regards To+

[Koha-patches] [PATCH] Bug 9209 - Mocked Koha::Calendar tests

2012-12-04 Thread Tomas Cohen Arazi
Using specific method for populating the internal data structures from Koha::Calendar has yielded to the non-detection of several bugs. There are also several tests that where db_dependent which is not always desirable. I propose the use of DBD::Mock (::Session) for using the actual code used

[Koha-patches] [PATCH] Bug 9211 - days_between wrong behaviour

2012-12-04 Thread Tomas Cohen Arazi
As noted in comments #15, #16 and #17 of bug 8486, and its API, Koha::Calendar-days_between should always returns a positive number irrespective of the relative order of the parameters. This is still an open bug, which arised when rewriting the Calendar.t file (Bug 9209). Regards To+

[Koha-patches] [PATCH] Bug 9659 - Better handling of non-existent authorised value categories used in SQL reports

2013-02-21 Thread Tomas Cohen Arazi
A user might create a SQL report that relies on non-existent authorised value categories. Because of a typo, or just because they copypasted the report from the Wiki. Use cases are: - The user creates a report from SQL a) Uses bad authorised values b) Clicks 'Save Report' c) Koha lists

[Koha-patches] [PATCH] Bug 9659 - Better handling of non-existent authorised value categories used in SQL reports

2013-02-22 Thread Tomas Cohen Arazi
A user might create a SQL report that relies on non-existent authorised value categories. Because of a typo, or just because they copypasted the report from the Wiki. Use cases are: - The user creates a report from SQL a) Uses bad authorised values b) Clicks 'Save Report' c) Koha lists

[Koha-patches] [PATCH] Bug 9731 - Remove changelanguage.pl in favor of (already present) opac-changelanguage.pl

2013-03-02 Thread Tomas Cohen Arazi
Remove that file that duplicates the behaviour of the correct opac-changelanguage.pl file and fix references to it in the templates. To+ Sponsored-by: Universidad Nacional de Córdoba --- .../opac-tmpl/ccsr/en/includes/opac-bottom.inc |4 +--

[Koha-patches] [PATCH] Bug 9735 - Let the language be selected through URL parameters

2013-03-02 Thread Tomas Cohen Arazi
Passing language=valid_language_code as a parameter in any Koha's URL can be used to set the desired language. This patch touches - C4::Templates - C4::Auth Adds a new method getlanguagecookie that does exactly that, for use in get_template_and_user. Also modifies getlanguage so it checks (a)

[Koha-patches] [PATCH] Bug 906 - ISBN Check

2013-03-15 Thread Tomas Cohen Arazi
In the MARC editor, have the ISBN checked. This feature is syspref-driven [1]. The patch adds the following javascript functions to cataloguing/addbiblio.tt: - _NormalizeISBN (for sanitizing the ISBN before algorithm checking) - _CheckISBNChecksum10 (for validating the checksum digit) -

[Koha-patches] [PATCH] Bug 9894 - (3.12) de-serialize the 'hidden' value for subfields in frameworks

2013-03-25 Thread Tomas Cohen Arazi
This patch aims to provide a non-intrusive way (with respect to Koha's code, so it could have got into 3.12) for the users to easily choose the visibility settings for each subfield. This patch is also known to have arrived late for 3.12. I've been struggling with other stuff at work, but I

[Koha-patches] [PATCH] Bug 10041 - Provide a koha-translate script to aid package users on installing translations

2013-04-13 Thread Tomas Cohen Arazi
Until we have solved the packaging of koha template translations, provide a command that manages the installed translations in a proper way. To test, build a Debian package of current master+the patches from this bug :-D and try the many options running koha-translate --help provide. The

[Koha-patches] [PATCH] Bug 10041 - Provide a koha-translate script to aid package users on installing translations

2013-04-15 Thread Tomas Cohen Arazi
Until we have solved the packaging of koha template translations, provide a command that manages the installed translations in a proper way. To test, build a Debian package of current master+the patches from this bug :-D and try the many options running koha-translate --help provide. The

[Koha-patches] [PATCH] Bug 10094 - koha-list should have a --disabled option switch

2013-04-23 Thread Tomas Cohen Arazi
This patch adds that (--disabled) option switch, Also revisits some of the code and docs. To test: - Apply the patch and create new packages (you might just drop the koha-list command somewhere) - Create several instances (koha-create) - Randomly set some as disabled, others enabled and enable

[Koha-patches] [PATCH] Bug 10101 - make koha-enable more robust

2013-04-23 Thread Tomas Cohen Arazi
koha-enable now: - checks for the existence of the instance before any other action on it. - checks if the instance is already enabled before changing stuff in the config files. - only reloads apache if it is needed! - handles more than one instance name as parameter (the code was there, a check

[Koha-patches] [PATCH] Bug 10104 - make koha-disable more robust

2013-04-23 Thread Tomas Cohen Arazi
koha-disable now: - checks for the existence of the instance before any actions on it. - checks if the instance is already disabled before touching anything (warns otherwise) - only reloads apache if needed - handles more than one instance name. - changed the docs to acknowledge the previous

[Koha-patches] [PATCH] Bug 10144 - koha-start-zebra error handling

2013-04-29 Thread Tomas Cohen Arazi
koha-start-zebra now - Checks the instance exists. - Checks the instance is enabled. - Checks if the zebra daemon is already running. Regards To+ Sponsored-by: Universidad Nacional de Córdoba --- debian/scripts/koha-start-zebra | 115 ++- 1 file changed, 100

[Koha-patches] [PATCH] Bug 10146 - koha-stop-zebra error handling

2013-04-29 Thread Tomas Cohen Arazi
koha-stop-zebra now - Checks the instance exists. - Checks the instance is enabled. - Checks if the zebra daemon is already running. Regards To+ Sponsored-by: Universidad Nacional de Córdoba --- debian/scripts/koha-stop-zebra | 116 ++-- 1 file changed, 101

[Koha-patches] [PATCH] Bug 10149 - koha-restart-zebra error handling (rewording)

2013-04-29 Thread Tomas Cohen Arazi
koha-restart-zebra now - Checks the instance exists. - Checks the instance is enabled. - Checks if the zebra daemon is already running. Regards To+ Edit: changed some wording problems. Sponsored-by: Universidad Nacional de Córdoba --- debian/scripts/koha-restart-zebra | 147

[Koha-patches] [PATCH] Bug 10157 - koha-email-enable error handling

2013-04-30 Thread Tomas Cohen Arazi
koha-email-enable now - Checks the instance exists. - Checks if email is already enabled. Regards To+ Sponsored-by: Universidad Nacional de Córdoba --- debian/docs/koha-email-enable.xml |4 +- debian/scripts/koha-email-enable | 81 +++-- 2 files changed,

[Koha-patches] [PATCH] Bug 10159 - koha-rebuild-zebra error handling

2013-04-30 Thread Tomas Cohen Arazi
This patch makes koha-rebuild-zebra: - Check for the existence of the instance - Handle arbitrary amount of instance parameters - Capture -a and -b (which made the script rebuild twice the chosen DB). It adds the extended version (--authorities and --biblios respectively) of the option switch.

[Koha-patches] [PATCH] Bug 9890 - Fix koha-create and koha-create-dirs

2013-05-27 Thread Tomas Cohen Arazi
As noted in the bug, there were three things to do: 1) koha-create: fill in __PLUGINS_DIR__ 2) leave the enable_plugins as off (at least for now) 3) koha-create-dirs: create the directory, set permissions (writeable by the koha user) - Fixed generate_config_file from koha-create so it correctly

[Koha-patches] [PATCH] Bug 9890 - Fix koha-create and koha-create-dirs

2013-05-31 Thread Tomas Cohen Arazi
As noted in the bug, there were three things to do: 1) koha-create: fill in __PLUGINS_DIR__ 2) leave the enable_plugins as off (at least for now) 3) koha-create-dirs: create the directory, set permissions (writeable by the koha user) - Fixed generate_config_file from koha-create so it correctly

[Koha-patches] [PATCH] Bug 10398 - Provide xml_valid.t for checking XML validity

2013-06-03 Thread Tomas Cohen Arazi
This patch adds a script that checks every XML file in Koha's source tree using xmllint. To test: - Run find . -name '*.xml' - Apply the patch, and run prove -v xt/xml_valid.t - Verify every xml file was tested. Regards To+ Sponsored-by: Universidad Nacional de Córdoba --- xt/xml_valid.t |

[Koha-patches] [PATCH] Bug 10399 - rebuild_zebra.pl should reset the indexes with -r even if zebraqueue empty

2013-06-04 Thread Tomas Cohen Arazi
This patch add the reset_indexes sub to the rebuild_zebra.pl script. And changes the scripts' logic to run it in case -r was passed and there are no records pending on the zebraqueue table. Regards To+ --- misc/migration_tools/rebuild_zebra.pl | 20 ++-- 1 file changed, 18

[Koha-patches] [PATCH 2/2] Bug 10447 - Language definitions for 'ru' and 'uk' are not available during install

2013-06-11 Thread Tomas Cohen Arazi
This patch add the option to choose 'ru' and 'uk' during install for zebra. Should work for a tarball install, and make 'ru' and 'uk' available for using with koha-create too. Regards To+ Sponsored-by: Universidad Nacional de Córdoba --- Makefile.PL |2 +-

[Koha-patches] [PATCH 1/2] Bug 10431 - Spanish Zebra character sorting file

2013-06-11 Thread Tomas Cohen Arazi
This patch provides a definition file for spanish (es) character sorting in Zebra. It is based on the ideas from Hugo Agud ha...@orex.es and Pablo Bianchi pablo.bian...@gmail.com. Makefile.PL is fixed to notice the existence of the 'es' language. The docs for koha-create are touched too. To

[Koha-patches] [PATCH 2/2] Bug 10444 - (CCSR followup) In advanced search(more), [+] and [-] should behave like links on hover

2013-06-11 Thread Tomas Cohen Arazi
Same fix for CCSR. Regards To+ Sponsored-by: Universidad Nacional de Córdoba --- koha-tmpl/opac-tmpl/ccsr/en/css/opac.css |4 1 file changed, 4 insertions(+) diff --git a/koha-tmpl/opac-tmpl/ccsr/en/css/opac.css b/koha-tmpl/opac-tmpl/ccsr/en/css/opac.css index ec12042..9f9979c 100644

[Koha-patches] [PATCH 1/2] Bug 10444 - In advanced search(more), [+] and [-] should behave like links on hover

2013-06-11 Thread Tomas Cohen Arazi
This patch add href=# to the [+] and [-] links for adding and removing search terms. It also defines its style so it doesn't show underlined. To test: - Browse your OPAC to Advanced Search and then More options. - The [+] and [-] don't change the cursor on hover - Apply the patch, reload and see

[Koha-patches] [PATCH] Bug 10464 - Patron search on placing a hold should provide autocomplete

2013-06-13 Thread Tomas Cohen Arazi
We should provide the autocomplete feature, already present for the circulation search box, if CircAutocompl is properly set; and leave as it currently works otherwise of course. This patch grabs the autocomplete handling javascript stuff from patron-search-box.inc and puts an adjusted version

[Koha-patches] [PATCH] Bug 10678 - Allow framework selection when creating from Z39.50

2013-08-02 Thread Tomas Cohen Arazi
If we are creating a new record, we are forced to use the default framework and then change it after we have the cataloguing form filled. This patch adds the option to choose (from a splitted button dropdown) which framework to use. To test: - Apply the patch. - Go to More Cataloguing - Check

[Koha-patches] [PATCH] Bug 8507: koha-create should be updated to use DOM indexing for bib

2013-08-09 Thread Tomas Cohen Arazi
This patch makes the koha-create script install the file zebra-biblios-dom.cfg with the proper string substitutions inside on the new instance koha-conf.xml file. It also adds two option switches that control the indexing mode for the instance: --biblio-idx {dom|grs1} --auth-idx {dom|grs1}

[Koha-patches] [PATCH 1/2] Bug 10733: Memcached on package installs

2013-08-14 Thread Tomas Cohen Arazi
This patch makes the koha-create script adjust the koha-conf.xml file with the proper string substitutions to enable the use of memcached for the created Koha instance. It adds three option switches that control this: --use-memcached (defaults to no) --memcached-servers host1:port1,...

[Koha-patches] [PATCH 2/2] Bug 10733: add 'memcached' as suggested dependency

2013-08-14 Thread Tomas Cohen Arazi
Adds 'memcached' to the control.in file so the user is suggested by apt to install it. Sponsored-by: Universidad Nacional de Cordoba --- debian/control.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/debian/control.in b/debian/control.in index e2b8882..c3d463f 100644 ---

[Koha-patches] [PATCH] Bug 10733: Follow-up - use koha-sites.conf

2013-08-15 Thread Tomas Cohen Arazi
In order to respect the current schema, where configuration values are pondered like this: hardcoded koha-sites.conf koha-create option switches I changed the patch a bit. I even changed MEMCACHED_NAMESPACE for MEMCACHED_PREFIX that seems to fit better in the current schema. Any feedback is

[Koha-patches] [PATCH] Bug 10802: Packages should install history.txt

2013-08-29 Thread Tomas Cohen Arazi
While bug 8911 fixed a problem regarding history.txt, a proper fix for packages was missing. This patch does three things: - Adds docs/history.txt to debian/koha-common.docs so it gets installed. - Moves the line installing the release notes from debian/koha-common.install to

[Koha-patches] [PATCH] Bug 10003: bash-completion for koha-list and some other script

2013-08-30 Thread Tomas Cohen Arazi
Nacional de Cordoba +#Tomas Cohen Arazi +# +# Koha is free software; you can redistribute it and/or modify it under the +# terms of the GNU General Public License as published by the Free Software +# Foundation; either version 3 of the License, or (at your option) any later +# version

[Koha-patches] [PATCH] Bug 10624: 'status' option switch for the packages init script

2013-08-30 Thread Tomas Cohen Arazi
This patch makes the init script return the status of the relevant processes. It relies on the koha-list switches added by 10622, and is written on top of the patch from 10617 that cleaned the init script. To test: - Apply the patch (+ 10622 so the SIP part works), build package and install -

[Koha-patches] [PATCH] Bug 7813: Ability to delete local cover images

2013-09-02 Thread Tomas Cohen Arazi
@@ +#!/usr/bin/perl + +# Copyright 2013 Universidad Nacional de Cordoba +#Tomas Cohen Arazi +# +# This file is part of Koha. +# +# Koha is free software; you can redistribute it and/or modify it under the +# terms of the GNU General Public License as published by the Free Software

[Koha-patches] [PATCH] Bug 10733: Memcached on package installs

2013-09-12 Thread Tomas Cohen Arazi
This patch makes the koha-create script adjust the koha-conf.xml file with the proper string substitutions to enable the use of memcached for the created Koha instance. It adds three option switches that control this: --use-memcached (defaults to no) --memcached-servers host1:port1,...

[Koha-patches] [PATCH 1/2] Bug 10691: 5xx not properly linked by authid in authority search result list

2013-09-18 Thread Tomas Cohen Arazi
This patch changes the URL and data used to show the 'see from' and 'see also' links on the OPAC's authority search results page. Bonus points: makes some strings translatable. To test: - On your dev setup (master) create some authority records (i created personal name authorities). - Pick one

[Koha-patches] [PATCH 2/2] Bug 10691: 5xx not properly linked by authid in authority search result list [Staff]

2013-09-18 Thread Tomas Cohen Arazi
This patch changes the URL and data used to show the 'see from' and 'see also' links on the Staff's authority search results page. Bonus points: makes some strings translatable. To test: - On your dev setup (master) create some authority records (i created personal name authorities). - Pick

[Koha-patches] [PATCH] Bug 10624: 'status' option switch for the packages init script

2013-09-27 Thread Tomas Cohen Arazi
This patch makes the init script return the status of the relevant processes. It relies on the koha-list switches added by 10622, and is written on top of the patch from 10617 that cleaned the init script. To test: - Apply the patch (+ 10622 so the SIP part works), build package and install -

[Koha-patches] [PATCH 3/3] Bug 10691: Small glitch fixed

2013-10-02 Thread Tomas Cohen Arazi
A small glitch prevented 'see from' headings to show. Sponsored-by: Universidad Nacional de Córdoba --- .../en/includes/authorities-search-results.inc |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Koha-patches] [PATCH] Bug 10987: Too many 'see also' and 'see from' labels occurences

2013-10-02 Thread Tomas Cohen Arazi
If an authority record has more than one 4xx$a (or 5xx$a) entries the corresponding labels 'see also' and 'used for/see from' are repeated. To test: - Have authority records with more than one entry on the 4xx (or 5xx) fields. - Do a search, check see also: (or 'used for/see from') appear more

[Koha-patches] [PATCH 1/2] Bug 8018: maxlenght should default to 9999 for subfields

2013-12-12 Thread Tomas Cohen Arazi
. Another approach could be changing the default and/or treating 0 as 'no-limit'. PabloAB Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com Works by defaulting 0 or to . --- admin/marc_subfields_structure.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/admin

[Koha-patches] [PATCH 2/2] Bug 8018: (followup) make the default more explicit

2013-12-12 Thread Tomas Cohen Arazi
This patch: - Makes the new subfield tab show maxlength= as default (instead of empty-then-zero). - Updates the help to make exlpicit that 0 or empty defaults to . - Assumes all the subfields created with maxlength=0 inadvertedly are meant to mean no limit and hence update the database

[Koha-patches] [PATCH 1/3] Bug 10691: 5xx not properly linked by authid in authority search result list [Staff]

2013-12-13 Thread Tomas Cohen Arazi
This patch changes the URL and data used to show the 'see also' links on the Staff's authority search results page. Bonus points: makes some strings translatable. To test: - On your dev setup (master) create some authority records (i created personal name authorities). - Pick one of them and

[Koha-patches] [PATCH 2/3] Bug 10691: 5xx not properly linked by authid in authority search result list

2013-12-13 Thread Tomas Cohen Arazi
This patch changes the URL and data used to show the 'see also' links on the OPAC's authority search results page. Bonus points: makes some strings translatable. To test: - On your dev setup (master) create some authority records (i created personal name authorities). - Pick one of them and

[Koha-patches] [PATCH] Bug 11400: Show Login as a different user instead of Logout if not enough premissions

2013-12-16 Thread Tomas Cohen Arazi
Bug 11146 introduced a way to go back, and have a logout link for the Not enough permissions message page. I belive this string change is worth. Simple and disputable string change. Regards To+ Sponsored-by: Universidad Nacional de Cordoba --- koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt | 2

[Koha-patches] [PATCH] Bug 11404: Apache 2.4 expects the sites definition files use the sufix '.conf'

2013-12-16 Thread Tomas Cohen Arazi
To reproduce: - Install the 'koha-common' package on Debian 7 or Ubuntu 13.10 (both known to include Apache 2.4). - Create an instance (for example testlibrary) using the supplied commands: $ koha-create --create-db testlibrary FAIL: apache reports an error like this: ERROR: Site testlibrary

[Koha-patches] [PATCH] Bug 11510: koha-translate usage message fixes

2014-01-09 Thread Tomas Cohen Arazi
The koha-translate's usage message has a couple of inconsistencies: '--all' should be '--available' and '--help' is missing from the usage examples. Regards To+ Sponsored-by: Universidad Nacional de Cordoba --- debian/docs/koha-translate.xml | 7 +++ debian/scripts/koha-translate | 4 ++--

[Koha-patches] [PATCH] Bug 11509: koha-create should print better usage information

2014-01-09 Thread Tomas Cohen Arazi
This patch makes koha-create print better and more descriptive usage information. Also adds the --help and -h switches. Regards To+ Sponsored-by: Universidad Nacional de Cordoba --- debian/docs/koha-create.xml | 10 +++ debian/scripts/koha-create | 67

[Koha-patches] [PATCH] Bug 10942: Provide a way for package upgrades to update template translations

2014-01-09 Thread Tomas Cohen Arazi
This patch adds a new config variable AUTOMATIC_TRANSLATIONS_UPDATE at /etc/default/koha-common that is used to control whether the upgrade process should trigger a $ koha-translate --update lang_code command for each installed template translation language. To test: - Have a koha-common setup

[Koha-patches] [PATCH] Bug 11439: (follow up) add missing rollback call

2014-01-09 Thread Tomas Cohen Arazi
This UT got wrapped inside a transaction with autocommit=0 but the rollback call was inadvertedly ommited. Adding it. Regards To+ Sponsored-by: Universidad Nacional de Cordoba --- t/db_dependent/XISBN.t | 2 ++ 1 file changed, 2 insertions(+) diff --git a/t/db_dependent/XISBN.t

[Koha-patches] [PATCH] Bug 10896: Add a --verbose option to koha-translate

2014-01-09 Thread Tomas Cohen Arazi
The -v and --verbose option switches add the --verbose switch to the misc/translator/translate script call in the packages' 'koha-translate' command. The docs are updated accordingly. Regards To+ Sponsored-by: Universidad Nacional de Cordoba --- debian/docs/koha-translate.xml | 10 +-

[Koha-patches] [PATCH] Bug 11533: (regression test) QP breaks authority search

2014-01-13 Thread Tomas Cohen Arazi
This patch duplicates the SearchAuthority tests, with QP enabled. Searching shouldn't be affected by QP. Instructions for manually reproducing this can be read in the first comment for the bug entry. Regards To+ Sponsored-by: Universidad Nacional de Cordoba --- t/db_dependent/Search.t | 16

[Koha-patches] [PATCH] Bug 11540: (folowup) add a couple of tests more

2014-01-14 Thread Tomas Cohen Arazi
This patch makes sure all scenarios are covered for SetUTF8Flag. Regards To+ --- t/Charset.t | 44 1 file changed, 40 insertions(+), 4 deletions(-) diff --git a/t/Charset.t b/t/Charset.t index 8debbd7..27b2a32 100755 --- a/t/Charset.t +++

[Koha-patches] [PATCH 1/2] Bug 9579: use String::Multibyte to correctly truncate facets

2014-01-15 Thread Tomas Cohen Arazi
As Bernardo pointed on comment #17, the incorrect display of multibyte strings in facets is related to the way they are currently truncated. C4::Search::getRecords relies on CORE::substr for the task, which only counts bytes, and thus doesn't check it is breaking multi-byte characters. This

[Koha-patches] [PATCH 2/2] Bug 9579: (followup) add dependency for String::Multibyte

2014-01-15 Thread Tomas Cohen Arazi
Just that. Regards To+ Sponsored-by: Universidad Nacional de Cordoba --- C4/Installer/PerlDependencies.pm | 5 + 1 file changed, 5 insertions(+) diff --git a/C4/Installer/PerlDependencies.pm b/C4/Installer/PerlDependencies.pm index 9b4b3b6..a539359 100644 ---

[Koha-patches] [PATCH] Bug 11596: Missing indexing options in koha-conf.xml should be reported

2014-01-22 Thread Tomas Cohen Arazi
To test: - Have a clean master install - Verify that koha-conf.xml contains valid entries for: zebra_bib_index_mode and zebra_auth_index_mode - Go to More About Koha System information = No Warnings regarding the system configuration - Apply the patch - Go to More About Koha System

[Koha-patches] [PATCH] Bug 11096: fallback to the correct defaults if config entries missing

2014-01-22 Thread Tomas Cohen Arazi
As of bug 7818 misc/migration_tools/rebuild_zebra.pl behaves like: - bib_index_mode (defaults to 'grs1' if not specified) - auth_index_mode (defaults to 'dom') we should do the same in C4::Context. So people having old config files have a seamless behaviour. Regards To+ Sponsored-by:

[Koha-patches] [PATCH] Bug 9114: Make frameworks import/export routines correctly use UTF-8

2014-01-22 Thread Tomas Cohen Arazi
Currently both the import_export_framework.pl script outputs data with Perl's default encoding, ISO-8859. This patch properly sets the binmode to UTF-8 when exporting SQL and CSV files using the PerlIO layer (:encoding(UTF-8)) for STDOUT. To test: Export step test - Use some ASCII character(s)

[Koha-patches] [PATCH] Bug 10580: Zebra no more optional in Koha setup

2014-01-24 Thread Tomas Cohen Arazi
Running Makefile.PL asks the user whether to install the Zebra configuration files and different texts relate to the user having chosen to use Zebra. This patch removes references to choosing to use Zebra and removes the related variables from the code. To test: - Apply the patch - Go through

[Koha-patches] [PATCH] Bug 11096: Koha-Zebra should use the XML syntax with DOM

2014-01-30 Thread Tomas Cohen Arazi
This patch makes Koha - Zebra use MARCXML for the serialization when using DOM, and USMARC for GRS-1. * The following functions are modified to set the Zebra record syntax according to the current sysprefs and configuration: - C4::Context-Zconn - C4::Context-_new_Zconn * A new function

[Koha-patches] [PATCH] Bug 11704: Make */svc/report print the correct headers

2014-02-06 Thread Tomas Cohen Arazi
To test: 1 - Go through the first comments instructions to reproduce and verify the bug is present (OPAC and STAFF) 2 - Apply the patch 3 - Repeat step 1 and notice * characters are not broken anymore * the header is correct 4 - Sign off Regards To+ --- opac/svc/report | 5 -

[Koha-patches] [PATCH] Bug 4397: Scan index search results broken for non-latin characters

2014-02-28 Thread Tomas Cohen Arazi
The Zoom specification defines that a ScanSet should provide a way to retrieve terms suitable for displaying and another one for using on further searches [1]. The Net::Z3950::ZOOM implementation actually provides both [2] but we where using the wrong one. Using $scanset-display_term(...)

[Koha-patches] [PATCH 1/2] Bug 11912: (regression tests) GetMarcISBN wrongly prepends a space to ISBNs

2014-03-09 Thread Tomas Cohen Arazi
This patch makes the tests run in both MARC21 and UNIMARC contexts. It previously run only for MARC21. It mocks what needs to be mocked. To test, run - prove t/db_dependent/Biblio.t = Notice the first ISBN has a space in front of it and those tests fails. Thanks for any feedback To+ ---

[Koha-patches] [PATCH] Bug 11912: (refactoring followup) GetMarcISBN should implement its advertised API

2014-03-10 Thread Tomas Cohen Arazi
The current implementation of GetMarcISBN contradicts the documented API. It currently returns an array of hashes with only one key (marcisbn) which doesn't add any value to it. I chose to fix GetMarcISBN to honour the API instead of changing the docs, because it seems a really silly change. To

[Koha-patches] [PATCH 2/3] Bug 11404: koha-functions.sh introduced for reuse

2014-05-09 Thread Tomas Cohen Arazi
-* scripts +# Copyright 2014 - Tomas Cohen Arazi +# Universidad Nacional de Cordoba +# +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 3

[Koha-patches] [PATCH 1/3] Bug 11404: Apache 2.4 expects the sites definition files use the sufix '.conf'

2014-05-09 Thread Tomas Cohen Arazi
To reproduce: - Install the 'koha-common' package on Debian 7 or Ubuntu 13.10+ (both known to include Apache 2.4). - Create an instance (for example testlibrary) using the supplied commands: $ koha-create --create-db testlibrary FAIL: apache reports an error like this: ERROR: Site testlibrary

  1   2   >