Re: [Koha-patches] [PATCH] wr77490 (bug 5929): use branch email in preference for due notices

2011-03-28 Thread Srdjan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Uh, definitely not, sorry. Removing immediately. On 29/03/11 03:00, Mike Hafen wrote: I think that you probably don't want that 'die ...' in there. On Tue, Mar 22, 2011 at 12:08 AM, Srdjan Jankovic srd...@catalyst.net.nz mailto:srd

[Koha-patches] Patch 5668

2012-02-12 Thread Srdjan
From c2be198a21d9a64a5d0207dfd3c55b5cb45cb9cb Mon Sep 17 00:00:00 2001 From: Srdjan Jankovic srd...@catalyst.net.nz Date: Mon, 13 Feb 2012 17:30:20 +1300 Subject: [PATCH] Bug 5668 - star ratings in the OPAC Created ratings table. RatingsEnabled syspref. --- C4/Auth.pm

[Koha-patches] Patch 5668

2012-02-12 Thread Srdjan
___ Koha-patches mailing list Koha-patches@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-patches website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs :

[Koha-patches] Patch 5668

2012-02-12 Thread Srdjan
From 4e282d78e6dac9f09ca7a0e19d170c4c30773f45 Mon Sep 17 00:00:00 2001 From: Srdjan Jankovic srd...@catalyst.net.nz Date: Mon, 13 Feb 2012 17:47:54 +1300 Subject: [PATCH] Bug 5668 - star ratings in the OPAC Created ratings table. RatingsEnabled syspref. --- C4/Auth.pm

[Koha-patches] Patch 5668

2012-02-21 Thread Srdjan
From 66a3e1bd841ac820a6df6fec82a063d4057dac86 Mon Sep 17 00:00:00 2001 From: Srdjan Jankovic srd...@catalyst.net.nz Date: Wed, 22 Feb 2012 19:26:49 +1300 Subject: [PATCH] Bug 5668 - star ratings in the OPAC --- C4/Auth.pm |5 +- C4/Output.pm

[Koha-patches] [PATCH] Bug 5668 - star ratings in the OPAC

2012-03-05 Thread Srdjan
From 8ecd83773c68fc8bee7a41a917c594b5c873ac7b Mon Sep 17 00:00:00 2001 From: Srdjan Jankovic srd...@catalyst.net.nz Date: Tue, 6 Mar 2012 18:52:25 +1300 Subject: [PATCH] Bug 5668 - star ratings in the OPAC --- C4/Auth.pm |5 +- C4/Output.pm

[Koha-patches] [PATCH] bug_7613: OCLC Connexion gateway

2012-03-22 Thread Srdjan
svc/import_bib: * takes POST request with parameters in url and MARC XML as DATA * pushes MARC XML to an impoort bach queue of type 'webservice' * returns status and imported record XML * is a drop-in replacement for svc/new_bib misc/cronjobs/import_webservice_batch.pl: * a cron job for

[Koha-patches] [PATCH] bug_5788: Added reservesmaxpickupdelay to circ matrix

2012-03-22 Thread Srdjan
--- admin/smart-rules.pl |9 + installer/data/mysql/kohastructure.sql |1 + installer/data/mysql/updatedatabase.pl |9 - .../prog/en/modules/admin/smart-rules.tt |5 - 4 files changed, 18

[Koha-patches] [PATCH] bug_7825: Changed OPACItemHolds syspref to be no|tes|force choice

2012-03-26 Thread Srdjan
Amended opac-reserve.tt accordingly --- installer/data/mysql/sysprefs.sql |2 +- installer/data/mysql/updatedatabase.pl |7 +++ .../prog/en/modules/admin/preferences/opac.pref|5 +- .../opac-tmpl/prog/en/modules/opac-reserve.tt | 42

[Koha-patches] [PATCH] bug_7613: OCLC Connexion gateway

2012-03-28 Thread Srdjan
svc/import_bib: * takes POST request with parameters in url and MARC XML as DATA * pushes MARC XML to an impoort bach queue of type 'webservice' * returns status and imported record XML * is a drop-in replacement for svc/new_bib misc/cronjobs/import_webservice_batch.pl: * a cron job for

[Koha-patches] [PATCH] bug_7420: Added overduefinescap to issuingrules

2012-04-01 Thread Srdjan
Replaced existing MaxFine syspref logic with overduefinescap. Repurposed MaxFine to be the overall overdue limit for all items overdue. Implemented new MaxFine logic in UpdateFine(). --- C4/Overdues.pm | 48 +++- admin/smart-rules.pl

[Koha-patches] [PATCH] bug_3966: Update items on receive

2012-04-02 Thread Srdjan
Use sane interface for items as when creating order. Changed AddItem() and ModItem() interface so now they return item record. AddItemFromMarc() looks for itemnumber, and calls ModItem() if one is found. --- C4/Acquisition.pm | 51 ++- C4/Biblio.pm

Re: [Koha-patches] [PATCH] bug_7398: Replaced OPACDisplayRequestPriority syspref with OPACShowHoldQueueDetails

2012-04-02 Thread Srdjan
did not introduced them. If the policy is to remove backticks from the code we change I'm happy to resubmit the patch. Srdjan -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk96flEACgkQX6p

[Koha-patches] [PATCH] bug_8034: Restored network printer maintenance and selection

2012-05-01 Thread Srdjan
This patch is just for restoring printer maintenance and selection, not for priting itself. It is just a preparation step. * Added UsePrintQueues syspref. If set to No, no printer info will be displayed/used * Database changes: - printers table PRIMARY KEY is now printqueue. It is more natural.

[Koha-patches] [PATCH] bug_8056: sorted out slip print calls

2012-05-08 Thread Srdjan
--- C4/Members.pm |1 - C4/Print.pm | 16 +++- circ/circulation.pl |8 ++-- 3 files changed, 13 insertions(+), 12 deletions(-) diff --git a/C4/Members.pm b/C4/Members.pm index 6161ac9..693e0ba 100644 --- a/C4/Members.pm +++ b/C4/Members.pm @@ -997,7 +997,6

[Koha-patches] [PATCH] bug_7420: Added overduefinescap to issuingrules

2012-05-08 Thread Srdjan
Replaced existing MaxFine syspref logic with overduefinescap. Repurposed MaxFine to be the overall overdue limit for all items overdue. Implemented new MaxFine logic in UpdateFine(). --- C4/Overdues.pm | 48 +++- admin/smart-rules.pl

[Koha-patches] [PATCH] bug_8056: sorted out slip print calls

2012-05-10 Thread Srdjan
--- C4/Members.pm |1 - C4/Print.pm | 16 +++- circ/circulation.pl |6 +- 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/C4/Members.pm b/C4/Members.pm index 6161ac9..693e0ba 100644 --- a/C4/Members.pm +++ b/C4/Members.pm @@ -997,7 +997,6

[Koha-patches] [PATCH] bug_8034: Restored network printer maintenance and selection

2012-05-13 Thread Srdjan
This patch is just for restoring printer maintenance and selection, not for priting itself. It is just a preparation step. * Added UsePrintQueues syspref. If set to No, no printer info will be displayed/used * Database changes: - printers table PRIMARY KEY is now printqueue. It is more natural.

[Koha-patches] [PATCH] bug_8056: sorted out slip print calls

2012-05-13 Thread Srdjan
--- C4/Members.pm|1 - C4/Print.pm | 43 ++ circ/circulation.pl |6 - t/db_dependent/lib/KohaTest/Print.pm |2 +- 4 files changed, 13 insertions(+), 39 deletions(-) diff --git

[Koha-patches] [PATCH] bug_8083: parameters subpermissions: manage_circ_rules and parameters_remaining_permissions

2012-05-14 Thread Srdjan
--- admin/admin-home.pl|2 +- admin/auth_subfields_structure.pl |2 +- admin/auth_tag_structure.pl|2 +- admin/authorised_values.pl |2 +- admin/authtypes.pl

[Koha-patches] [PATCH] bug_8083: parameters subpermissions: manage_circ_rules and parameters_remaining_permissions

2012-05-21 Thread Srdjan
--- admin/admin-home.pl|2 +- admin/auth_subfields_structure.pl |2 +- admin/auth_tag_structure.pl|2 +- admin/authorised_values.pl |2 +- admin/authtypes.pl

[Koha-patches] [PATCH] bug_7398: Replaced OPACDisplayRequestPriority syspref with OPACShowHoldQueueDetails

2012-05-22 Thread Srdjan
New syspref is Choice, options being: - None - Priority only - Holds number only - Holds number and priority Show holds count on OPAC detail --- admin/systempreferences.pl |2 +- installer/data/mysql/sysprefs.sql |2 +-

[Koha-patches] [PATCH] bug_8039: Try userid if cardnumber borrower search fails in SIP

2012-05-24 Thread Srdjan
--- C4/SIP/ILS/Patron.pm |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/SIP/ILS/Patron.pm b/C4/SIP/ILS/Patron.pm index 99fd6e7..ccb08d8 100644 --- a/C4/SIP/ILS/Patron.pm +++ b/C4/SIP/ILS/Patron.pm @@ -37,7 +37,7 @@ sub new { my ($class, $patron_id) = @_; my

[Koha-patches] [PATCH] bug_8138: added 773$t field to search results

2012-05-27 Thread Srdjan
--- .../prog/en/xslt/MARC21slim2intranetResults.xsl| 11 +++ .../prog/en/xslt/MARC21slim2OPACResults.xsl| 11 +++ 2 files changed, 22 insertions(+) diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl

[Koha-patches] [PATCH] bug_8039: Try userid if cardnumber borrower search fails in SIP

2012-05-29 Thread Srdjan
--- C4/SIP/ILS/Patron.pm |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/C4/SIP/ILS/Patron.pm b/C4/SIP/ILS/Patron.pm index 99fd6e7..8017ed3 100644 --- a/C4/SIP/ILS/Patron.pm +++ b/C4/SIP/ILS/Patron.pm @@ -37,13 +37,13 @@ sub new { my ($class, $patron_id) = @_;

[Koha-patches] [PATCH] bug_7420: Added overduefinescap to issuingrules

2012-05-30 Thread Srdjan
Replaced existing MaxFine syspref logic with overduefinescap. Repurposed MaxFine to be the overall overdue limit for all items overdue. Implemented new MaxFine logic in UpdateFine(). --- C4/Circulation.pm |2 +- C4/Overdues.pm

[Koha-patches] [PATCH] bug_5911: make perlcdritic happy, shut up warnings

2012-06-11 Thread Srdjan
--- C4/HoldsQueue.pm | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/C4/HoldsQueue.pm b/C4/HoldsQueue.pm index fcb3c14..05095d8 100755 --- a/C4/HoldsQueue.pm +++ b/C4/HoldsQueue.pm @@ -564,11 +564,18 @@ sub debug { # warn @_; } +sub _trim { +return $_[0]

[Koha-patches] [PATCH] bug_5911: removed duplicate _flush_preferences(), and replaced with clear_syspref_cache()

2012-07-09 Thread Srdjan
--- C4/Context.pm |3 --- t/db_dependent/HoldsQueue.t |2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/C4/Context.pm b/C4/Context.pm index 251299d..9ce6c74 100644 --- a/C4/Context.pm +++ b/C4/Context.pm @@ -523,9 +523,6 @@ with this method. # flushing

[Koha-patches] [PATCH] bug_8034: Restored network printer maintenance and selection

2012-07-10 Thread Srdjan
This patch is just for restoring printer maintenance and selection, not for priting itself. It is just a preparation step. * Added UsePrintQueues syspref. If set to No, no printer info will be displayed/used * Database changes: - printers table PRIMARY KEY is now printqueue. It is more natural.

[Koha-patches] [PATCH] bug_5911: Make tt_valid.t happy

2012-07-18 Thread Srdjan
--- .../prog/en/modules/admin/transport-cost-matrix.tt |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transport-cost-matrix.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transport-cost-matrix.tt index

[Koha-patches] [PATCH] bug_7243: Be selective when summing up charges for blocking issues

2012-09-02 Thread Srdjan
Added RentalsInNoissueCharges and ManInvlsInNoissueCharges sys prefs Created C4::Members::cwGetMemberAccountBallance() * A wrapper for GetMemberAccountRecords that gives info on non-issue and other charges * Other charges are: 'Res' 'Rent' if RentalsInNoissueCharges is Mo

[Koha-patches] [PATCH] bug_8034: Restored network printer maintenance and selection

2012-09-09 Thread Srdjan
This patch is just for restoring printer maintenance and selection, not for priting itself. It is just a preparation step. * Added UsePrintQueues syspref. If set to No, no printer info will be displayed/used * Database changes: - printers table PRIMARY KEY is now printqueue. It is more natural.

[Koha-patches] [PATCH] bug_8034: Restored network printer maintenance and selection

2012-09-11 Thread Srdjan
This patch is just for restoring printer maintenance and selection, not for priting itself. It is just a preparation step. * Added UsePrintQueues syspref. If set to No, no printer info will be displayed/used * Database changes: - printers table PRIMARY KEY is now printqueue. It is more natural.

[Koha-patches] [PATCH] bug_7243: Rewording and renaming

2012-11-05 Thread Srdjan
--- C4/Circulation.pm | 26 ++-- C4/Members.pm |8 +++--- installer/data/mysql/sysprefs.sql |4 +-- installer/data/mysql/updatedatabase.pl |6 ++---

[Koha-patches] [PATCH] bug_7243: spelling correction

2012-11-25 Thread Srdjan
--- C4/Circulation.pm |4 ++-- C4/Members.pm | 10 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index e23fb9e..b1831fd 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -771,7 +771,7 @@ sub CanBookBeIssued {

[Koha-patches] [PATCH] bug_7243: Rewording and renaming

2012-11-26 Thread Srdjan
--- C4/Circulation.pm | 30 ++-- C4/Members.pm | 22 +++--- installer/data/mysql/sysprefs.sql |4 +-- installer/data/mysql/updatedatabase.pl |6 ++--

[Koha-patches] [PATCH] bug_8034: Restored network printer maintenance and selection

2012-11-29 Thread Srdjan
This patch is just for restoring printer maintenance and selection, not for priting itself. It is just a preparation step. * Added UsePrintQueues syspref. If set to No, no printer info will be displayed/used * Database changes: - printers table PRIMARY KEY is now printqueue. It is more natural.

[Koha-patches] [PATCH] bug_8034: Disable delete printer for printers asigned to branches

2013-02-12 Thread Srdjan
* C4::Printer - added branch count to printer queries * admin/printers.tt - show or not delete link --- C4/Printer.pm | 24 ++-- admin/printers.pl |8 ++- .../prog/en/modules/admin/printers.tt

[Koha-patches] [PATCH] bug_8034: Restored network printer maintenance and selection

2013-04-21 Thread Srdjan
This patch is just for restoring printer maintenance and selection, not for priting itself. It is just a preparation step. * Added UsePrintQueues syspref. If set to No, no printer info will be displayed/used * Database changes: - printers table PRIMARY KEY is now printqueue. It is more natural.

[Koha-patches] [PATCH] Bug 10258: Remove erroneous call to haspermission in basket.pl

2013-06-02 Thread Srdjan
a closed basket in Acquisition. Check if you see all available basketgroups in the combo at the right side. Signed-off-by: Srdjan srd...@catalyst.net.nz --- acqui/basket.pl | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/acqui/basket.pl b/acqui/basket.pl index 7eff6e4

[Koha-patches] [PATCH] [Signed-Off] Bug 10354 - Don't show optgroup Libraries when no search groups are defined

2013-06-02 Thread Srdjan
and groups should be separated into optgroups. - Disable your library search group and refresh the OPAC page. The pulldown of libraries should now display libraries with no optgroup. Signed-off-by: Srdjan srd...@catalyst.net.nz --- koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc | 4 ++-- 1 file

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 10390: Add ability to delete empty invoices

2013-06-02 Thread Srdjan
-by: Srdjan srd...@catalyst.net.nz --- C4/Acquisition.pm | 34 ++ acqui/invoice.pl | 8 + .../intranet-tmpl/prog/en/modules/acqui/invoice.tt | 3 ++ .../prog/en/modules/acqui/invoices.tt | 3 ++ t

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 10090: Add itemtype description instead of code

2013-06-02 Thread Srdjan
From: Jonathan Druart jonathan.dru...@biblibre.com On ordered.pl and spent.pl, the itemtype codes are displayed, instead of descriptions. Links for the ordernumber should be changed. In ordered.pl, we are redirected to the receive page. In spent.pl, the links are deleted. Signed-off-by: Srdjan

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 10291: Clarify misleading variable name

2013-06-03 Thread Srdjan
From: Colin Campbell colin.campb...@ptfs-europe.com Remove the unrequired extra processing and pass the array of itemnumbers as itemnumbers_array Signed-off-by: Srdjan srd...@catalyst.net.nz --- koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt | 4 ++-- koha-tmpl/intranet-tmpl

[Koha-patches] [PATCH] Bug 10366: Alert librarian if an invoice number is duplicated

2013-06-03 Thread Srdjan
, rather than creating an invoice with a duplicate number. Signed-off-by: Srdjan srd...@catalyst.net.nz --- acqui/parcels.pl | 34 +- installer/data/mysql/sysprefs.sql | 1 + installer/data/mysql/updatedatabase.pl

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 9779 - Remove global include of YUI assets from the staff client

2013-06-03 Thread Srdjan
From: Owen Leonard oleon...@myacpl.org There are no pages in the staff client which use YUI JS assets other than basketgroups.tt. The links to YUI assets can therefore be removed from the global include and put directly into the basket groups template. Signed-off-by: Srdjan srd

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 9558 - Customize CSS for mobile

2013-06-04 Thread Srdjan
in this patch are courtesy Zachary Spalding as described in Bug 9558. Patch and test plan created by Owen Leonard. Signed-off-by: Srdjan srd...@catalyst.net.nz --- C4/Auth.pm | 1 + koha-tmpl/opac-tmpl/ccsr/en/includes/doc-head-close.inc | 3 +++ 2

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 10320 - Integrate OverDrive search into OPAC

2013-06-05 Thread Srdjan
From: Jesse Weaver pianohac...@gmail.com This show results from the OverDrive ebook/audiobook service in the OPAC. Added the sysprefs and copied the relevant JS to CCSR. Signed-off-by: Srdjan srd...@catalyst.net.nz --- C4/External/OverDrive.pm | 141

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 10406 - Remove obsolete CSS related to YUI autocomplete

2013-06-05 Thread Srdjan
From: Owen Leonard oleon...@myacpl.org staff-global.css contains CSS which related to the old YUI autocomplete widget. Since this has been replaced with jQueryUI the CSS is now unused and can be removed. Signed-off-by: Srdjan srd...@catalyst.net.nz --- koha-tmpl/intranet-tmpl/prog/en/css/staff

[Koha-patches] [PATCH] Bug 10328 - Rename opaccolorstylesheet to OpacColorStyleSheet

2013-06-06 Thread Srdjan
From: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Srdjan srd...@catalyst.net.nz --- C4/Auth.pm| 4 ++-- C4/Templates.pm | 4 ++-- installer/data/mysql/sysprefs.sql

[Koha-patches] [PATCH] [SIGNED-OFF] Bug-10370-Adding barcode on circulation print page.

2013-06-06 Thread Srdjan
From: Amit Gupta amit.gu...@osslabs.biz Signed-off-by: Srdjan srd...@catalyst.net.nz --- koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 10368 - Added price in overdue report

2013-06-07 Thread Srdjan
From: Amit Gupta amit.gu...@osslabs.biz Signed-off-by: Srdjan srd...@catalyst.net.nz --- koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt b/koha-tmpl/intranet-tmpl/prog/en

[Koha-patches] [PATCH] Bug 9576 - Enable or disable issue limit confirmation

2013-06-07 Thread Srdjan
item to a patron than the max issues 4) You should be allowed to override by default ( current behavior ) 5) Set AllowTooManyOverride to Don't allow 6) Repeat step 3 7) You should be blocked from being able to issue the item Signed-off-by: Srdjan srd...@catalyst.net.nz --- C4/Circulation.pm

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 10247 - Too many reserves due to syspref does not show warning

2013-06-10 Thread Srdjan
it cause the same bug as for maxreserves. Signed-off-by: Srdjan srd...@catalyst.net.nz --- .../prog/en/modules/reserve/request.tt | 8 +++ reserve/request.pl | 27 ++ 2 files changed, 11 insertions(+), 24 deletions(-) diff

[Koha-patches] [PATCH] Bug 10439: FIX modify the library for a notice.

2013-06-10 Thread Srdjan
From: Jonathan Druart jonathan.dru...@biblibre.com 2 javascript functions should be apply only in a specific case, not for all views. Test plan: - switch on the IndependentBranches pref - try to change the library for a notice. Before the patch, no change is applied. Signed-off-by: Srdjan srd

[Koha-patches] [PATCH] Bug 10405: add IDs for custom regions

2013-06-10 Thread Srdjan
(); $('#preview-loading').hide(); }); } }); Signed-off-by: Srdjan srd...@catalyst.net.nz --- koha-tmpl/opac-tmpl/ccsr/en/includes/doc-head-close.inc | 4 ++-- koha-tmpl/opac-tmpl/ccsr/en/includes/masthead.inc | 2 -- koha-tmpl/opac-tmpl/ccsr/en/includes/navigation.inc | 6

[Koha-patches] [PATCH] Bug 10396 : Itemcallnumber and year of publication does not need datepicker fields in catalog stats form

2013-06-10 Thread Srdjan
From: Sophie Meynieux sophie.meyni...@biblibre.com Signed-off-by: Srdjan srd...@catalyst.net.nz --- koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports

[Koha-patches] [PATCH] Bug 9487 - Allow items fields to be used in the HOLDPLACED notice

2013-06-10 Thread Srdjan
fields are new populated Signed-off-by: Srdjan srd...@catalyst.net.nz --- C4/Reserves.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/C4/Reserves.pm b/C4/Reserves.pm index 5ff12e4..96aa9b3 100644 --- a/C4/Reserves.pm +++ b/C4/Reserves.pm @@ -212,6 +212,7 @@ sub AddReserve

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 10527: C4::Branch::get_branch_code_from_name is useless

2013-07-09 Thread Srdjan
From: Jonathan Druart jonathan.dru...@biblibre.com This routine is not in used and does not make sense. It should not be used later. Signed-off-by: Srdjan srd...@catalyst.net.nz --- C4/Branch.pm| 11 +-- labels/label-edit-batch.pl | 1 - labels/label-manage.pl

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 10515: The prototype for GetBranchCategory and GetBranchCategories is not consistent

2013-07-10 Thread Srdjan
these groups to a library Signed-off-by: Srdjan srd...@catalyst.net.nz --- C4/Branch.pm | 63 -- admin/branches.pl | 47 +++- catalogue/search.pl| 2 +- .../prog/en

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 10504: Remove the unused C4::Acq::ModOrderItem routine

2013-07-10 Thread Srdjan
From: Jonathan Druart jonathan.dru...@biblibre.com This routine has been introduced by commit 2d90fb22d43db986547bbaa945873d6dd78aab71. The only call has been removed by commit 9eba7dc594fc0d4698da5e791d5f6f8682b2712a. So now, this routine is useless. Signed-off-by: Srdjan srd

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 10556: The delivery time is not inserted on adding a supplier.

2013-07-15 Thread Srdjan
From: Jonathan Druart jonathan.dru...@biblibre.com Test plan: Add/edit a supplier and check that the delivery time is set in DB. Note: This patch cleans the code (sql query) in order to see easily if a problem occurred. Signed-off-by: Srdjan srd...@catalyst.net.nz --- C4/Bookseller.pm | 92

[Koha-patches] [PATCH] Bug 10197: Add classes to patron info list

2013-07-15 Thread Srdjan
on the list to the left to see the styles * View a checkout screen and view the source on the list to the left with patron info to see the styles * You could also try to style things by customizing your CSS Signed-off-by: Srdjan srd...@catalyst.net.nz --- koha-tmpl/intranet-tmpl/prog/en/includes/circ

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 7598 - Acquisitions JavaScript contains untranslatable English strings

2013-07-16 Thread Srdjan
know how to trigger it for testing. The closebasketgroup function has been updated but as far as I can tell it's not actually in use. Signed-off-by: Srdjan srd...@catalyst.net.nz --- koha-tmpl/intranet-tmpl/prog/en/js/acq.js| 20 ++-- .../prog/en/modules/acqui

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 10557: GetBooksellersWithLateOrders has an unused branch parameter

2013-07-16 Thread Srdjan
From: Jonathan Druart jonathan.dru...@biblibre.com C4::Booksellers::GetBooksellersWithLateOrders has an unused parameter. The $branch variable is never used in the routine. Test plan: Check that no behavior changes on the late orders page. Signed-off-by: Srdjan srd...@catalyst.net.nz --- C4

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 2394: Use syspref canreservefromotherbranches in CanItemBeReserved

2013-07-16 Thread Srdjan
From: Julian Maurice julian.maur...@biblibre.com Signed-off-by: Srdjan srd...@catalyst.net.nz --- C4/Reserves.pm | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/C4/Reserves.pm b/C4/Reserves.pm index 5ff12e4..182af1a 100644 --- a/C4/Reserves.pm +++ b/C4

[Koha-patches] [PATCH] Bug 2394: Use syspref canreservefromotherbranches in CanItemBeReserved

2013-07-16 Thread Srdjan
From: Julian Maurice julian.maur...@biblibre.com Signed-off-by: Srdjan srd...@catalyst.net.nz --- C4/Reserves.pm | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/C4/Reserves.pm b/C4/Reserves.pm index c8b0cdd..87ffaff 100644 --- a/C4/Reserves.pm +++ b/C4

[Koha-patches] [PATCH] Bug 10597 - Search to hold button broken on record details

2013-07-16 Thread Srdjan
-by: Srdjan srd...@catalyst.net.nz --- .../intranet-tmpl/prog/en/includes/cat-toolbar.inc | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc

[Koha-patches] [PATCH] Bug 10595 - OpacTopissue page still accessible when system preference is turned off

2013-07-16 Thread Srdjan
) Manually open /koha/opac-topissues.pl and observe that you are being redirected to the 404 page. Enable OpacTopissue Follow the link or manuall open opac-topissues.pl and check that it is working Signoff the patch. Signed-off-by: Srdjan srd...@catalyst.net.nz --- opac/opac-topissues.pl | 7

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 10543 - false mandatory warning in additem

2013-07-16 Thread Srdjan
a textarea for $i - Empty $s and Save = Without patch, you get a warning and form is not saved and you see that $s is yellow while it should be $r = With patch, form is saved - Re-edit this item - Empty $r and save = You get a warning and form is not saved Signed-off-by: Srdjan srd...@catalyst.net.nz

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 10543 - Unify item mandatory subfields check

2013-07-16 Thread Srdjan
From: Fridolyn SOMERS fridolyn.som...@biblibre.com Use of CheckMandatorySubfields from cataloging.js everywhere an item cataloging form is checked for mandatories Signed-off-by: Srdjan srd...@catalyst.net.nz --- .../intranet-tmpl/prog/en/modules/acqui/neworderempty.tt | 9

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 10543 - add mandatory subfield check to addorderiso2709.pl

2013-07-16 Thread Srdjan
From: Fridolyn SOMERS fridolyn.som...@biblibre.com When adding orders from staged file, you can create one order per record using item form in the bottom of addorderiso2709.pl. This form was missing check. Signed-off-by: Srdjan srd...@catalyst.net.nz --- .../intranet-tmpl/prog/en/modules/acqui

[Koha-patches] [PATCH] Bug 7019: Circulation History Sort Order Wrong (in datatable)

2013-07-16 Thread Srdjan
. For example : With patch : 20/01/2011 06/03/2011 20/03/2011 Checked Out Without patch : 06/03/2011 20/01/2011 20/03/2011 Checked Out - Test also with dateformat syspref mm/dd/ Signed-off-by: Srdjan srd...@catalyst.net.nz --- .../intranet-tmpl/prog/en/modules/members/readingrec.tt

[Koha-patches] [PATCH] bug 10559: remove spurious statement handle still active warnings

2013-07-16 Thread Srdjan
-by: Galen Charlton g...@esilibrary.com Signed-off-by: Srdjan srd...@catalyst.net.nz --- C4/Letters.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/C4/Letters.pm b/C4/Letters.pm index d36c29f..37883c6 100644 --- a/C4/Letters.pm +++ b/C4/Letters.pm @@ -550,6 +550,7 @@ sub _substitute_tables

[Koha-patches] [PATCH] Bug 10463 - Quote of the day feature not selecting random quotes

2013-07-16 Thread Srdjan
) Enable the quote of the day and view the opac 3) Look at your quotes table and note the timestamp is incorrect 4) Repeat steps 1 and 2 5) Look at your quotes table and note the timestamp is now correct Signed-off-by: Srdjan srd...@catalyst.net.nz --- C4/Koha.pm | 7 +-- 1 file changed, 5

[Koha-patches] [PATCH] [SIGNED-OFF] bug 10503: fix various issues with use of Memoize::Memcached

2013-07-17 Thread Srdjan
] Set the SessionStorage system preference to memcached. After logging in again, verify that your staff interface and OPAC sessions work without requiring that you log in for each and every page load. Signed-off-by: Galen Charlton g...@esilibrary.com Signed-off-by: Srdjan srd

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 10441: Testing AddShare in VirtualShelves.t

2013-07-17 Thread Srdjan
From: Marcel de Rooy m.de.r...@rijksmuseum.nl Builds upon 10386 and 9032. Adds a unit test for routine AddShare. This patch also restores the inadvertently deleted DelShelf tests in bug 10499. Test plan: Run the test. All passed? Signed-off-by: Srdjan srd...@catalyst.net.nz --- t/db_dependent

[Koha-patches] [PATCH] Bug 10584 - Hide OPAC biblio details if all items are hidden

2013-07-17 Thread Srdjan
. Signed-off-by: Srdjan srd...@catalyst.net.nz --- opac/opac-detail.pl | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl index 9d0851f..612831a 100755 --- a/opac/opac-detail.pl +++ b/opac/opac-detail.pl @@ -70,9 +70,20 @@ my

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 10578 - Escaping CGI breaks results sort feature (librarian's interface)

2013-07-17 Thread Srdjan
. You should get no results with a message like: No results match your search for 'au%2Cphr: etc. 5. Apply the patch 6. Repeat steps 2. 3. 7. You should get the list sorted according to your choice. Signed-off-by: Srdjan srd...@catalyst.net.nz --- catalogue/search.pl | 10 +- 1 file

[Koha-patches] [PATCH] Bug 10511 - Odd behavior for messaging preferences with Talking Tech enabled

2013-07-18 Thread Srdjan
checkbox remains checked 7) Apply this patch 8) Repeat steps 3-6, noting the odd behavior is no longer present Signed-off-by: Srdjan srd...@catalyst.net.nz --- .../intranet-tmpl/prog/en/includes/messaging-preference-form.inc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[Koha-patches] [PATCH] Bug 10337: Unit tests is based on an existing database

2013-07-19 Thread Srdjan
From: Jonathan Druart jonathan.dru...@biblibre.com This patchs adds a new unit tests file which will launched before all others db_dependent tests. It will drop and recreate the database with sample data. Prerequisite: The database 'koha_ut' have to be created with CREATE DATABASE $dbname

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 10481: Unit tests for C4::Members::AddEnrolmentFeeIfNeeded

2013-07-19 Thread Srdjan
-off-by: Srdjan srd...@catalyst.net.nz --- t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t | 56 1 file changed, 56 insertions(+) create mode 100644 t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t diff --git a/t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t b/t

[Koha-patches] [PATCH] Bug 10446 - System preference maxoutstanding is poorly named

2013-07-23 Thread Srdjan
to place an OPAC hold for a patron owing more than $10 This attempt should fail Signed-off-by: Srdjan srd...@catalyst.net.nz --- C4/SIP/ILS/Patron.pm | 2 +- installer/data/mysql/sysprefs.sql | 2 +- installer/data

[Koha-patches] [PATCH] C4::Bookseller.pm need unit tests

2013-07-25 Thread Srdjan
warnings about uninitialised values] t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=53, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.46 cusr 0.03 csys = 0.51 CPU) Result: PASS http://bugs.koha-community.org/show_bug.cgi?id=10528 Signed-off-by: Srdjan srd...@catalyst.net.nz

[Koha-patches] [PATCH] Bug 10589 - Override OpacHiddenItems based on Patron Category

2013-07-25 Thread Srdjan
-off-by: Srdjan srd...@catalyst.net.nz --- C4/Items.pm| 25 -- installer/data/mysql/sysprefs.sql | 2 ++ installer/data/mysql/updatedatabase.pl | 16 ++ .../prog/en/modules/admin/preferences

[Koha-patches] [PATCH] Bug 10424 - Search received orders

2013-07-25 Thread Srdjan
, vendor and date received. 7) Users will be able to see details of received orders. Sponsored-by: Staffordshire University/Halton Borough Council/PTFS Europe Signed-off-by: Srdjan srd...@catalyst.net.nz --- C4/Acquisition.pm | 139 + acqui

[Koha-patches] [PATCH] Bug 10393 - Receive shipment link in acquisitions main page

2013-07-25 Thread Srdjan
) For creating new basket click on New Basket link. Sponsored-by: Staffordshire University/Halton Borough Council/PTFS Europe Signed-off-by: Srdjan srd...@catalyst.net.nz --- acqui/receiveshipment.pl | 57 + .../prog/en/includes/acquisitions-menu.inc | 1

[Koha-patches] [PATCH] Bug 10644: ClassSource.pm needs unit tests

2013-07-28 Thread Srdjan
successful. Files=1, Tests=24, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.12 cusr 0.01 csys = 0.15 CPU) Result: PASS Signed-off-by: Srdjan srd...@catalyst.net.nz --- t/db_dependent/ClassSource.t | 198 +++ 1 file changed, 198 insertions(+) create mode

[Koha-patches] [PATCH] Bug 10638 - Show alert when receiving an order with holds/reserves

2013-07-29 Thread Srdjan
-off-by: Srdjan srd...@catalyst.net.nz --- acqui/finishreceive.pl | 6 ++- acqui/parcel.pl| 45 ++ .../intranet-tmpl/prog/en/modules/acqui/parcel.tt | 14 +++ 3 files changed, 64 insertions(+), 1 deletion

[Koha-patches] [PATCH] [SIGNED-OFF] ModBookseller needs more explicit return values in C4::Bookseller.pm

2013-07-30 Thread Srdjan
: PASS http://bugs.koha-community.org/show_bug.cgi?id=10640 Signed-off-by: Srdjan srd...@catalyst.net.nz --- C4/Bookseller.pm| 4 ++-- t/db_dependent/Bookseller.t | 6 ++ 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/C4/Bookseller.pm b/C4/Bookseller.pm index

[Koha-patches] [PATCH] [SIGNED-OFF] C4::Branch.pm needs unit tests

2013-07-31 Thread Srdjan
=36, 1 wallclock secs ( 0.02 usr 0.02 sys + 0.13 cusr 0.01 csys = 0.18 CPU) Result: PASS http://bugs.koha-community.org/show_bug.cgi?id=10508 Signed-off-by: Srdjan srd...@catalyst.net.nz --- t/db_dependent/Branch.t | 297 ++-- 1 file changed, 290

[Koha-patches] [PATCH] Bug 10672 - Add subtitle to display of checkouts, overdues, and holds on the patron summary

2013-08-01 Thread Srdjan
titles with subtitles. Titles should appear correctly with and without subtitles. Signed-off-by: Srdjan srd...@catalyst.net.nz --- koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt | 6 +++--- opac/opac-user.pl| 4 ++-- 2 files changed, 5 insertions(+), 5 deletions

[Koha-patches] [PATCH] Bug 10619 - sco.css missing for CCSR OPAC templates

2013-08-01 Thread Srdjan
to that patron to see more examples. Signed-off-by: Srdjan srd...@catalyst.net.nz --- koha-tmpl/opac-tmpl/ccsr/en/css/sco.css | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/koha-tmpl/opac-tmpl/ccsr/en/css/sco.css b/koha-tmpl/opac-tmpl/ccsr/en/css/sco.css index

[Koha-patches] [PATCH] [SIGNED-OFF] Bug 10668 - Improve suggestion detail page - QA Followup

2013-08-04 Thread Srdjan
From: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Srdjan srd...@catalyst.net.nz --- koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt

[Koha-patches] [PATCH] Bug 10588 - opac-topissues first branch always selected in filters

2013-08-05 Thread Srdjan
and perform a search that does not have results (for example an item type never issued) = You get to page without results, All libraries is selected [testing opac-topissues.tt form] Signed-off-by: Srdjan srd...@catalyst.net.nz --- koha-tmpl/opac-tmpl/prog/en/includes/opac-topissues.inc | 2 +- opac

[Koha-patches] [PATCH] Bug 10426 Remove unused sub GetCcodes from Koha.pm

2013-08-20 Thread Srdjan
From: Colin Campbell colin.campb...@ptfs-europe.com Remove uncalled sub GetCcodes Also remove comment in opac-search.pl which is remaining reference to it and serves no useful purpose Signed-off-by: Srdjan srd...@catalyst.net.nz --- C4/Koha.pm | 22 -- opac/opac

[Koha-patches] [PATCH] Bug 9611: Change the password hashing algorithm from MD5 to Bcrypt

2013-08-22 Thread Srdjan
From: Srikanth Dhondi srika...@catalyst.net.nz What this patch aims to accomplish? * All new passwords are stored as Bcrypt-hashes * For password verification: - If the user was created before this patch was applied then use MD5 to hash the entered password -- backwards

[Koha-patches] [PATCH] bug 9611: removing external dependency for password salt generator

2013-08-22 Thread Srdjan
From: Chris Hall chr...@catalyst.net.nz To address packaging issues with Crypt::Random::Source, this patch replaces the salt generation with a wrapper for /dev/urandom and /dev/random. The test plan for this patch is the same as that for the base patch for bug 9611. Signed-off-by: Galen

[Koha-patches] [PATCH] Bug 9611: Change the password hashing algorithm from MD5 to Bcrypt

2013-08-22 Thread Srdjan
From: Srikanth Dhondi srika...@catalyst.net.nz What this patch aims to accomplish? * All new passwords are stored as Bcrypt-hashes * For password verification: - If the user was created before this patch was applied then use MD5 to hash the entered password -- backwards

[Koha-patches] [PATCH] bug_10781: Removed ILSDI::Utility

2013-08-25 Thread Srdjan
Test: This should be a noop. Regression testing required: /cgi-bin/koha/ilsdi.pl functioanality, in particuler: GetAvailability - ?service=Describeverb=GetAvailability AuthenticatePatron - ?service=Describeverb=AuthenticatePatron ILS-DI syspref must be turned on --- C4/ILSDI/Services.pm | 40

  1   2   3   4   >