jpalecek added a reviewer: Kopete.
jpalecek added inline comments.
INLINE COMMENTS
> bonjouraccount.cpp:241
> +
> +const auto ptrValue = &*pointer;
> +QObject::connect(ptrValue, ::RemoteService::resolved, this,
> [this, ptrValue](bool r) {
>
jpalecek edited the summary of this revision.
REPOSITORY
R434 Kopete
REVISION DETAIL
https://phabricator.kde.org/D18445
To: jpalecek, #kopete
Cc: kopete-devel, himanshuvishwakarma, cochise
jpalecek added a reviewer: Kopete.
REPOSITORY
R434 Kopete
REVISION DETAIL
https://phabricator.kde.org/D18445
To: jpalecek, #kopete
Cc: kopete-devel, himanshuvishwakarma, cochise
jpalecek created this revision.
Herald added a project: Kopete.
Herald added a subscriber: kopete-devel.
jpalecek requested review of this revision.
REVISION SUMMARY
Defining macro isRunning by
#define isRunning() something == something_else
has its problems. Elsewhere in the code,
