---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/701/
---
Review request for Kopete.
Summary
---
The attached patch includes a
2009/4/26 Dmitry Kolosov ivakr...@gmail.com:
Hello kopete-team!
I am a user of FreeBSD and kde4.2.2 and want to help in development of
kopete. I have few ideas i can realize. But i can't choose an IDE for working
locally with kopete. If it possible, i wish to open some kind of project or
2009/5/15 Raphael Kubo da Costa kub...@gmail.com:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/701/
---
Review request for Kopete
Hello,
Commit 970289 seems to break compilation on non-Linux platforms -- I'm
not sure about Windows, but at least FreeBSD (most certainly OpenBSD
and NetBSD too) doesn't compile anymore because tcp_info seems to be
Linux-only and is being experimentally and partially added to FreeBSD.
I'm no
2009/5/21 Roman Jarosz kedge...@gmail.com:
On Thu, 21 May 2009 16:46:17 +0200, Raphael Kubo da Costa
kub...@gmail.com wrote:
2009/5/20 Raphael Kubo da Costa kub...@gmail.com:
2009/5/20 Roman Jarosz kedge...@gmail.com:
Will it compile if you change the two Q_WS_X11 to Q_OS_LINUX (without
2009/6/11 Dhaval Patel dha...@patel.sh:
I am running KDE 4.2.90 under Jaunty which I believe is KDE 4.3 Beta 2. There
are a couple of changes that I had some questions on.
1. The names in the contact list are all bold. I went in the configuration and
specified a font in Regular but it is
2009/6/12 Nick Shaforostoff shaforost...@gmail.com:
On Пятница 12 июня 2009 00:12:18 Dhaval Patel wrote:
Awesome. I did not think about right clicking on the Display name thing.
I don't think it is. There should be a label stating that some options are
available via context menu.
There are
2009/6/22 Pali Rohár pali.ro...@gmail.com:
SVN commit 985395 by pali:
Added option to merge all messages from all jabber contact's resources
(default enabled)
BUG: 111537
BUG: 142650
BUG: 175078
BUG: 194808
M +10 -0 jabberaccount.cpp
M +10 -0 jabberaccount.h
M +12 -3
2009/6/30 Serhiy Kachaniuk serzhol...@gmail.com:
Hi!
I use kopete trunk with KDE 4.3 beta 2, and kopete here doesn't show
notifications to events contact online, contact offline and contact
changes status. Can someone confirm this?
Please see bug 190658 -
2009/7/5 Jay Dresser j...@jaydresser.us:
Is this where I send feature requests? Pardon me if it's not, I couldn't find
another place for it.
Hi there. The most appropriate place for feature requests is
https://bugs.kde.org - you just need to create a wishlist.
I use Kopete at home and a
2009/7/5 Roman Jarosz kedge...@gmail.com:
SVN commit 991636 by rjarosz:
Bring back online/offline notifications were lost during model/view
merge.
BUG: 190658
M +105 -2 kopetemetacontact.cpp
M +2 -0 kopetemetacontact.h
M +1 -0 kopetemetacontact_p.h
Shouldn't
2009/7/9 Lamarque Vieira Souza lamar...@gmail.com:
Em Thursday 09 July 2009, Matt Rogers escreveu:
On Wed, Jul 8, 2009 at 6:29 PM, Lamarque Vieira Souzalamar...@gmail.com
wrote:
Em Wednesday 08 July 2009, Olivier Goffart escreveu:
Le Wednesday 08 July 2009, Lamarque Vieira Souza a écrit :
2009/6/29 Musa Musa sendtom...@gmail.com:
Hello,
I am sure you are aware of the connection issues users of kopete are
having because of yahoo's so called upgrade. As a user of kopete on a
linux box that doesn't have kde, I'd just like to know when and if some
sort of patch/fix is going to
2009/7/23 Markus kamika...@web.de:
It isn't even sure that KDE will switch to gitorious.org.
Why don't you just wait and see?
Hasn't Amarok just started the migration to gitorious?
___
kopete-devel mailing list
kopete-devel@kde.org
2009/7/23 Markus kamika...@web.de:
Am Donnerstag, 23. Juli 2009 18:21:36 schrieb Raphael Kubo da Costa:
2009/7/23 Markus kamika...@web.de:
It isn't even sure that KDE will switch to gitorious.org.
Why don't you just wait and see?
Hasn't Amarok just started the migration to gitorious
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1403/#review2145
---
Ship it!
Running svn log tells us that the icon was renamed in
2009/8/26 Grace Navarro grace...@hotmail.com:
no quiero recibir estos correos
Te has inscripto en esta lista de correo tú solo. Ve a
https://mail.kde.org/mailman/listinfo/kopete-devel y elige
unsubscribe.
Didn't you ask for the same thing a year ago?
On 2009-08-25 18:20:01, Raphael Kubo da Costa wrote:
Running svn log tells us that the icon was renamed in 2007... The patch
looks fine, even though the Testing done field was blank. I suppose
you've tested it, right?
Markus Slopianka wrote:
Still not marked as submitted
2009/9/4 Markus kamika...@web.de:
After
that, if it does work, you need to commit it and mark as Submitted. Do you
have commit access?
No, I don't.
Committed and backported. Please close the review request as Submitted.
Thanks!
___
kopete-devel
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1568/#review2310
---
Ship it!
The patch looks fine. I'll commit and backport. If you have
On 2009-09-12 01:23:49, Raphael Kubo da Costa wrote:
The patch looks fine. I'll commit and backport. If you have plans to
contribute with more patches, please consider requesting a commit account.
Done. Please close this review request.
- Raphael
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1574/
---
Review request for Kopete.
Summary
---
Currently, using Firefox 3.5 with
---
On 2009-09-12 01:42:55, Raphael Kubo da Costa wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1574
On 2009-09-12 02:21:26, Matt Rogers wrote:
Commit!
Raphael Kubo da Costa wrote:
Done. Should this be backported?
Matt Rogers wrote:
if skypebuttons is present in the 4.3 branch, then yes.
Done.
- Raphael
Hi there,
After the KNotificationIcon commits, I get that ? icon instead of
Kopete's when I'm online. That prompted me to look at what was wrong
and, while doing that, I found some old icons (the ones with the ox
prefix) in the kopete/ directory that don't seem to be used for quite
some time.
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1661/#review2408
---
/trunk/KDE/kdenetwork/kopete/protocols/groupwise/gwaccount.cpp
2009/9/20 Sverre Froyen sve...@viewmark.com:
Hi,
Ever since KDE4 I have been unable to connect to my Yahoo IM account with
kopete. I always get a There was an error while connecting user name to
the Yahoo server. Error message: 17 remote host closed connection error
message. Because there
2009/9/20 Raphael Kubo da Costa kub...@gmail.com:
Hi there,
After the KNotificationIcon commits, I get that ? icon instead of
Kopete's when I'm online. That prompted me to look at what was wrong
and, while doing that, I found some old icons (the ones with the ox
prefix) in the kopete
On Mon, Sep 28, 2009 at 09:57:52PM -0500, Matt Rogers wrote:
On Sunday 20 September 2009 16:19:08 Raphael Kubo da Costa wrote:
Hi there,
After the KNotificationIcon commits, I get that ? icon instead of
Kopete's when I'm online. That prompted me to look at what was wrong
and, while
On Tuesday 06 October 2009 18:04:55 Mohammed El-Afifi wrote:
Hello,
I've checked out the kopete code from the trunk(as illustrated on its SVN
Access page), with the intention to add the ability to run behind a
proxy(as I've been thinking about that for some period).
I may be completely
On Wednesday 18 November 2009 11:03:03 Pali Rohár wrote:
On Wednesday 18 November 2009 09:50:18 Pali Rohár wrote:
Hello,
finally I have libjingle Google Talk voice call support for Kopete.
Patch for Kopete jabber protocol is on
http://reviewboard.kde.org/r/753/
For work this
On Monday 23 November 2009 10:15:36 Jussi Kekkonen wrote:
2009/11/23 Pali Rohár pali.ro...@gmail.com:
Hello,
I have cmake version 2.6-patch 4 (standard version in Kubuntu Karmic
9.10) and I can compile kopete with google libjingle support without any
problems.
Good to hear, I'm on
On Monday 23 November 2009 09:53:29 Mohammed El-Afifi wrote:
Can you please explain how we might use the List-Id header to filter the
list mails? I'm using the filters supported by yahoo web mail. Thanks in
advance.
I think that falls into the get better software category ;)
Cheers,
Raphael
On Monday 14 December 2009 10:21:09 Michael Cole wrote:
I will volunteer to help you guys with the yahoo protocol and others when I
get that one fully working.
I have been going through the code and noticed some easy bugs to fix.
I have not been involved in this type of work before working
On Wednesday 16 December 2009 04:04:26 Zubin Mithra wrote:
i just tried building the current development version of kopete and i
got the following error
http://paste.pocoo.org/show/157323/
please help
You need the CMake files for kdelibs at least - I believe Kopete depends on
stuff
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2542/#review3659
---
/trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistmodel.cpp
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2542/#review3661
---
/trunk/KDE/kdenetwork/kopete/kopete/contactlist/contactlistmodel.cpp
On 2010-01-11 16:32:57, Raphael Kubo da Costa wrote:
/trunk/KDE/kdenetwork/kopete/kopete/contactlist/kopeteitemdelegate.cpp,
line 548
http://reviewboard.kde.org/r/2542/diff/3/?file=16883#file16883line548
const'ify here too?
Oops, nevermind. Didn't see you called convert
On Friday 22 January 2010 00:11:41 Michael Cole wrote:
On Friday 22 January 2010 12:49:49 am Roman Jarosz wrote:
Hi,
could you also backport Yahoo fixes to 4.4 branch?
Btw. in 4.4 branch you cannot add/change string so be careful.
Regards
Roman Jarosz
Cannot add/change
On Sunday 24 January 2010 14:14:28 Frank Schaefer wrote:
Hi,
most distros still compile their packages without libv4l, but it is in
fact indispensable.
Too many video-device are using custom-decoders and we can't provide
them all (it's also hard to follow kernel-development).
We have many
On Wednesday 27 January 2010 10:46:49 Frank Schaefer wrote:
The attached patch makes libv4l mandatory on Linux (only).
Should be reviewed by someone with more CMake-experience ;).
Thanks,
Frank
It'd be better if you pasted the contents of the patch here or used
ReviewBoard.
I'll paste the
On Saturday 30 January 2010 17:57:01 Manuel Luitz wrote:
Hi!
I just implemented a small feature for the IdentityStatusWidget. Double
clicking on a single account effects now a connect/disconnect toggle.
Thought it would be useful.
Thanks,
Manu
I don't know the code in question, so I
On Sunday 31 January 2010 11:28:54 Frank Schaefer wrote:
Raphael Kubo da Costa schrieb:
+IF (LIBV4L2_FOUND)
+ IF (NOT LIBV4L2_FIND_QUIETLY)
+MESSAGE (STATUS Found LIBV4L2: ${LIBV4L2_LIBRARY})
+ ENDIF (NOT LIBV4L2_FIND_QUIETLY)
+ELSE (LIBV4L2_FOUND)
+ IF (LibV4L2_FIND_REQUIRED
On Sunday 07 February 2010 09:56:59 Frank Schaefer wrote:
Matt Rogers schrieb:
On Sunday 24 January 2010 10:14:28 am Frank Schaefer wrote:
Hi,
most distros still compile their packages without libv4l, but it is in
fact indispensable.
Too many video-device are using custom-decoders
On Sunday 07 February 2010 11:27:17 Raphael Kubo da Costa wrote:
On Sunday 07 February 2010 09:56:59 Frank Schaefer wrote:
Matt Rogers schrieb:
On Sunday 24 January 2010 10:14:28 am Frank Schaefer wrote:
Hi,
most distros still compile their packages without libv4l
On Thursday 18 February 2010 16:36:24 Panagiotis Papadopoulos wrote:
Hi,
When I try to register a new ICQ account through the Account Options in
Kopete, the following URL is opened: http://go.icq.com/register/ This
leaves me with an 404 Not Found Error.
I searched for a working URL
On Friday 26 February 2010 15:45:08 Pali Rohár wrote:
On 2010-02-26 17:49:15, Matt Rogers wrote:
looks fine to me. Please commit.
commited.
Can I backport it to 4.4?
Strictly speaking this is a wishlist item which wasn't on the 4.4 Feature
Plan; however it's almost a one-liner that
On Friday 26 February 2010 15:47:08 Pali Rohár wrote:
Hello,
can somebody close this bug? I dont have permitions for this.
Done. Since you are a committer yourself, you should ask for bigger Bugzilla
privileges either in #kde-bugs or by filing a sysadmin request in Bugzilla
itself.
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3074/#review4314
---
/trunk/KDE/kdenetwork/kopete/CMakeLists.txt
On Wednesday 03 March 2010 10:24:30 kaushik wrote:
On Wed, Mar 3, 2010 at 4:49 PM, Frank Schaefer
fschaefer@googlemail.com
wrote:
kaushik schrieb:
Is it a good idea to make it compulsory?
No it is not, we are stupid idiots, not knowing what we are doing...
And we're having
On Wednesday 03 March 2010 13:49:17 David wrote:
Hi there.
I am using a one click open in all KDE wide apps, but I have a little
problem with kopete's contact list.
When I want to select a contact, (only select), I have to click on it, but
then, it opens a chat window when I only wanted to
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3074/#review4349
---
/trunk/KDE/kdenetwork/kopete/CMakeLists.txt
On Sunday 07 March 2010 15:38:14 Pali Rohár wrote:
Hello,
Kopete doesnt set status message after start or after solid networking
reconnect.
It is because, setting online status from kopeteapplication or
kopeteaccountmanager doesnt contains status message (only empty string).
This patch
On Sunday 07 March 2010 11:32:42 Timo Schlüßler wrote:
Helo,
isn't there anybody who can submit the patch?
Timo
I've just committed and backported it, thanks.
Is there any bug report on bugs.kde.org about this that could be closed?
___
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3260/#review4495
---
From a person who also isn't familiar with the code base, I'd say
On Monday 15 March 2010 21:30:50 Crístian Viana wrote:
is there a TODO list or something like that with items to be implemented?
is there anything for a beginner? where do I start from?
Hey there,
There's a TODO list and a list of junior jobs over TechBase [1][2], but I'm
pretty sure they're
On Fri, Mar 26, 2010 at 12:52 AM, Gary Triplett garystripl...@gmail.com wrote:
http://kubuntuforums.net/forums/index.php?topic=3110702.0
No one responds to this issue on the forums, but I feel that the developers
would appreciate assistance with a debug report.
I see that this Kopete package
On Friday 09 April 2010 12:36:23 Markus wrote:
Am Freitag 09 April 2010 17:24:15 schrieb miniBill:
2010/4/9 Markus kamika...@web.de:
Am Freitag 09 April 2010 16:11:05 schrieb miniBill:
What's the purpose of Kopete's Export Contacts feature?
Batch-migrating contacts who don't have
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3632/#review5087
---
Ship it!
I don't know the code, so to an external reviewer the patch
On Sunday 18 April 2010 06:03:33 Pavel Heimlich, a.k.a. hajma wrote:
Hi,
building kdepim from current svn on OpenSolaris with the Sun Studio,
I'm encountering the below issue:
[ 20%] Building CXX object
kopete/libkopete/CMakeFiles/kopete.dir/ui/kopeteinfodialog.o
On Wednesday 05 May 2010 22:16:23 Matt Rogers wrote:
Hi,
The kopete-devel and kopete-bugs list could use a few more additional
moderators/admins to handle the list admin stuff.
Any volunteers?
How heavy is the traffic for them?
___
kopete-devel
On Thursday 06 May 2010 09:58:07 Matt Rogers wrote:
On Wed, May 5, 2010 at 9:10 PM, Raphael Kubo da Costa kub...@gmail.com
wrote:
On Wednesday 05 May 2010 22:16:23 Matt Rogers wrote:
Hi,
The kopete-devel and kopete-bugs list could use a few more additional
moderators/admins to handle
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3955/#review5613
---
I think you've forgotten to add nlaudacious.{cpp,h} to the patch,
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3955/#review5635
---
/trunk/KDE/kdenetwork/kopete/plugins/nowlistening/CMakeLists.txt
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3989/#review5686
---
I don't really know this code, but judging from your screenshots it
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4151/#review5869
---
Some comments after a first glance:
* The MPD support seems to have
On 2010-05-25 22:06:39, Raphael Kubo da Costa wrote:
Some comments after a first glance:
* The MPD support seems to have nothing to do with the MPRIS changes. If
so, this should go in a separate patch.
* Some new files are being added with old copyrights.
* I thought the MPRIS
On Saturday 29 May 2010 15:01:16 Frank Schaefer wrote:
Hi,
AFAIK, we don't provide webcam support for the MSN protocol anymore.
That's why I would like to remove the following sentences from the MSN
protocol description in the Kopete handbook to avoid webcam bug reports
from people using
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4274/#review6080
---
The patch looks quite cluttered because of the automatic changes to
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4357/#review6288
---
Ship it!
As I always say, I don't really know this code, but the
On Thursday 01 July 2010 07:22:50 Frank Schaefer wrote:
SVN commit 1144923 by fschaefer:
videodevicepool: remove unneeded device locking mechanism
Qt's signals-/slots-mechanism already protects us from slots
deviceAdded()/deviceRemoved() beeing called simultanuously (as long as
we don't
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4357/#review6356
---
Hi Igor.
I'm trying to apply your patch here but it fails to
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4274/#review6357
---
Ralf, can you please close the review request as submitted now?
-
On 2010-05-25 22:06:39, Raphael Kubo da Costa wrote:
Some comments after a first glance:
* The MPD support seems to have nothing to do with the MPRIS changes. If
so, this should go in a separate patch.
* Some new files are being added with old copyrights.
* I thought the MPRIS
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1815/#review6359
---
Can you close this request as submitted?
- Raphael
On 2009-12-31
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4039/#review6360
---
I've just applied the patch. Can you please close this request as
On 2010-04-17 18:12:22, Raphael Kubo da Costa wrote:
I don't know the code, so to an external reviewer the patch looks OK. Do
you have an SVN account?
Teemu Rytilahti wrote:
Yup, I do have an account, but of course it'd be nice if someone with
insight of the code could check
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2179/#review6362
---
Well, nobody has given a NACK yet, so I presume this is a tacit ACK
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2542/#review6363
---
Do you know if there's any bug report related to this regression?
On Wednesday 21 July 2010 16:55:23 dantti85-...@yahoo.com.br wrote:
De: Raphael Kubo da Costa kub...@gmail.com
Committing directly to trunk probably means you'll already have a
completely functional new UI for everything for the SC 4.6 release.
It'd be nice if you could post some screenshots
On Wednesday 21 July 2010 17:22:10 dantti85-...@yahoo.com.br wrote:
In the mean time ( i think trunk is frozen now)
Nope, trunk is currently open for feature commits.
Have you talked to the usability folks about
this? Moving the application menu to the bottom left is probably quite
On 2010-07-28 14:50:14, Will Stephenson wrote:
Patch seems trivial, even I can still ok it.
Please also remember to backport it.
- Raphael
---
This is an automatically generated e-mail. To reply, visit:
On 2010-07-28 14:50:14, Will Stephenson wrote:
Patch seems trivial, even I can still ok it.
Raphael Kubo da Costa wrote:
Please also remember to backport it.
Teemu Rytilahti wrote:
Commited to trunk, but will backport to 4.5 after the freeze is over.
Should I also backport
On Thursday 19 August 2010 21:15:31 Warren Dumortier wrote:
Sorry but i forgot to attach the actual patch, so this mail got it! ;)
Well, as I always say: looks fine from an outsider's point of view. Do you
have any bug reports which would be fixed by this patch?
(Please don't forget to CC kopete-devel, or even only send the mail to the list)
On Mon, Aug 23, 2010 at 10:48 AM, Warren Dumortier nwarre...@gmail.com wrote:
Thanks for the response.
Well i do not think there are any bugs caused by this, but i can have a
look.
In fact this causes a problem
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5175/#review7272
---
Looks OK at first sight; have you tried contacting someone else about
On 2010-08-29 19:23:59, Raphael Kubo da Costa wrote:
Looks OK at first sight; have you tried contacting someone else about the
KNotify behaviour you think is a bug?
Igor Poboiko wrote:
I didn't try, but I have just filled a bugreport. See bug 249468.
Igor Poboiko wrote:
I
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5175/#review7300
---
Ship it!
Well, since nobody else has said anything on this patch, I
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5159/#review7301
---
Ship it!
- Raphael
On 2010-08-26 16:11:54, Aurélien Gâteau wrote:
At Mon, 06 Sep 2010 11:37:12 +0100,
Alex Merry wrote:
On Monday 06 September 2010 03:16:33 Jeffery MacEachern wrote:
I don't have commit access. Should I send patches to the mailing
list, or elsewhere?
Send them to the list, and someone will commit them - if no-one else does, I
will.
At Thu, 9 Sep 2010 06:09:11 -0500,
Felix Guzman wrote:
Hello, I would like to help with development in Kopete. In particular, I'm
interested in audio and video support via Jingle. I am relatively new to
programming, and I was wondering if anyone would be willing to work with me
and answer
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5364/#review7630
---
Do you know if there are open bug reports about this one? I
At Thu, 14 Oct 2010 15:30:16 +0200,
Luca Tettamanti wrote:
On Mon, Oct 11, 2010 at 9:55 PM, Matt Rogers ma...@kde.org wrote:
We don't know unless you post a patch to reviewboard.
Hum, I've looked at the web application but I don't see a way to
upload an entire patch serie since it insists
At Thu, 14 Oct 2010 16:14:50 +0200,
Luca Tettamanti wrote:
On Thu, Oct 14, 2010 at 3:47 PM, Raphael Kubo da Costa kub...@gmail.com
wrote:
At Thu, 14 Oct 2010 15:30:16 +0200,
Luca Tettamanti wrote:
On Mon, Oct 11, 2010 at 9:55 PM, Matt Rogers ma...@kde.org wrote:
We don't know
On 2010-10-19 18:03:02, Martin Blumenstingl wrote:
/trunk/KDE/kdenetwork/kopete/libkopete/kopeteaccountmanager.h, line 114
http://svn.reviewboard.kde.org/r/3260/diff/1/?file=20645#file20645line114
I don't think you're allowed to make this one public.
See
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6085/#review9228
---
I see that you've committed your patch. Can you please close the
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6169/#review9335
---
/trunk/KDE/kdenetwork/kopete/protocols/skype/skypecalldialog.cpp
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6169/#review9368
---
Ship it!
The two issues I've mentioned below are minor, so r+
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/3260/#review9385
---
Ship it!
Assuming Kopete doesn't keep binary compatibility
On 2010-12-23 11:19:49, Raphael Kubo da Costa wrote:
Assuming Kopete doesn't keep binary compatibility between releases, this
can go in (remember to backport to the 4.5 and 4.6 branches). If you prefer
to go on the safe side, do as suggested and keep BC.
Oh, and please check
1 - 100 of 168 matches
Mail list logo
