Re: [PATCH] virtio_net: add link status handling

2008-12-12 Thread Rusty Russell
On Thursday 11 December 2008 05:04:44 Mark McLoughlin wrote: On Tue, 2008-12-09 at 21:11 -0600, Anthony Liguori wrote: Rusty Russell wrote: On Wednesday 10 December 2008 08:02:14 Anthony Liguori wrote: It would be nice if the virtio-net card wrote some acknowledgement that it has

Failed to use PCI device assignment

2008-12-12 Thread Courtay Olivier
Hi, I try to use PCI device assignment on a 2.6.28-rc8 with kvm-80 on a Intel that support VT-D. I have a error: # qemu-system-x86_64 -pcidevice host=00:19.0 -hda WinXP.img -cdrom /dev/scd0 -m 1024 Warning: No DNS servers found create_userspace_phys_mem: Invalid argument

Re: [Qemu-devel] [RFC] Replace posix-aio with custom thread pool

2008-12-12 Thread Andrea Arcangeli
On Fri, Dec 12, 2008 at 12:54:21PM +0100, Jens Axboe wrote: I agree completely. The buffered aio patches got pretty involved though, it wasn't real pretty in the end. So it never got merged. Looks like the most realistic way forward is some variant of syslet (or the acall stuff that Zach has

Re: [Qemu-devel] [RFC] Replace posix-aio with custom thread pool

2008-12-12 Thread Andrea Arcangeli
On Fri, Dec 12, 2008 at 08:35:57AM -0600, Anthony Liguori wrote: I've been thinking about this, the problems I see are: 1) It's impossible to accept a file descriptor for a block device (possibly not a problem) What do you mean with accept? You mean to accept a tcp connection? How would a

[ kvm-Bugs-2421626 ] missing break in 'case KVM_EXIT_S390_RESET'

2008-12-12 Thread SourceForge.net
Bugs item #2421626, was opened at 2008-12-12 08:59 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2421626group_id=180599 Please note that this message will contain a full copy of

[ kvm-Bugs-2386363 ] virtio-net doesn't set vc-info_str

2008-12-12 Thread SourceForge.net
Bugs item #2386363, was opened at 2008-12-03 21:43 Message generated for change (Comment added) made by hollis You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2386363group_id=180599 Please note that this message will contain a full copy of the comment

Re: [Qemu-devel] [RFC] Replace posix-aio with custom thread pool

2008-12-12 Thread Chris Wright
* Anthony Liguori (anth...@codemonkey.ws) wrote: Chris Wright wrote: * Anthony Liguori (anth...@codemonkey.ws) wrote: It's available in recent kernels I see! so the fix is easy. Only problem is how to pass CLONE_IO to pthread_create... We'll have to make a linux-only change and call clone

Re: [Qemu-devel] [RFC] Replace posix-aio with custom thread pool

2008-12-12 Thread Anthony Liguori
Andrea Arcangeli wrote: On Fri, Dec 12, 2008 at 11:25:55AM -0600, Anthony Liguori wrote: Hrm, that's more complex than I was expecting. I was thinking the bdrv aio infrastructure would always take an iovec. Any details about the underlying host's ability to handle the iovec would be

Re: [Qemu-devel] [RFC] Replace posix-aio with custom thread pool

2008-12-12 Thread Andrea Arcangeli
On Fri, Dec 12, 2008 at 12:17:58PM -0600, Anthony Liguori wrote: You assume that anything using bdrv_aio_readv/writev will be going through a DMA API. This isn't a safe assumption. Well it's obviously a safe assumption right now... ;) I've an hard time seeing any 'metadata' (because _data_

Re: [Qemu-devel] [PATCH 2 of 5] add can_dma/post_dma for direct IO

2008-12-12 Thread Anthony Liguori
Blue Swirl wrote: On 12/12/08, Andrea Arcangeli aarca...@redhat.com wrote: From: Andrea Arcangeli aarca...@redhat.com Add can_dma and post_dma methods needed before/after direct IO to guest physical memory. Signed-off-by: Andrea Arcangeli aarca...@redhat.com +/*

Re: [PATCH 1 of 5] fix cpu_physical_memory len

2008-12-12 Thread Andrea Arcangeli
On Fri, Dec 12, 2008 at 01:06:56PM -0600, Anthony Liguori wrote: Andrea Arcangeli wrote: From: Andrea Arcangeli aarca...@redhat.com Be consistent and have length be size_t for all methods. ram_addr_t would be better than size_t here. Yes, that is feasible even if the dma api output

Re: [PATCH 2 of 5] add can_dma/post_dma for direct IO

2008-12-12 Thread Andrea Arcangeli
On Fri, Dec 12, 2008 at 01:15:13PM -0600, Anthony Liguori wrote: 1) You attempt to map a physical address. This effectively is a lock or pin operation. lock or pin for what? There's nothing to pin or lock here. Perhaps one day we'll have to lock or pin against something, dunno, then we'll add

Re: [PATCH 2 of 5] add can_dma/post_dma for direct IO

2008-12-12 Thread Anthony Liguori
Anthony Liguori wrote: Andrea Arcangeli wrote: From: Andrea Arcangeli aarca...@redhat.com Add can_dma and post_dma methods needed before/after direct IO to guest physical memory. I think any API based on a can_dma abstraction is wrong. The write_post_dma thing is equally wrong. The

Re: [Qemu-devel] [PATCH 2 of 5] add can_dma/post_dma for direct IO

2008-12-12 Thread Anthony Liguori
Blue Swirl wrote: On 12/12/08, Anthony Liguori anth...@codemonkey.ws wrote: I think we should go back to Fabrice's earliest suggestion here. We should just have a simple map/unmap lock/unlock API for physical memory. That should be the base API IMHO. Beautiful! As long the

Re: [Qemu-devel] [RFC] Replace posix-aio with custom thread pool

2008-12-12 Thread Gerd Hoffmann
Anthony Liguori wrote: I don't know about grant table references b/c that's really foreign memory. But this is a good argument against the DMA as it stands, b/c you may be handing foreign memory to bdrv_aio_readv/writev. A big reason for the map/unmap lock/unlock abstraction though would be

RE: [PATCH 03/11] Use arch.pid as shadow pid for E500

2008-12-12 Thread Liu Yu
-Original Message- From: kvm-ppc-ow...@vger.kernel.org [mailto:kvm-ppc-ow...@vger.kernel.org] On Behalf Of Liu Yu-B13201 Sent: Friday, December 12, 2008 10:21 AM To: Hollis Blanchard Cc: kvm-ppc@vger.kernel.org Subject: RE: [PATCH 03/11] Use arch.pid as shadow pid for E500

Re: [PATCH] [PATCH] qemu: ppc: kvm-userspace: KVM PowerPC support for qemu gdbstub

2008-12-12 Thread Christian Ehrhardt
Hollis Blanchard wrote: On Thu, 2008-12-11 at 17:05 +0100, Jan Kiszka wrote: Hollis Blanchard wrote: On Thu, 2008-12-11 at 13:53 +0100, Christian Ehrhardt wrote: This is v2 as version one had a type in it occured when splitting patches. Mercurial somehow lost my changes to the

Re: [Qemu-devel] [PATCH 2/6] kvm: sync vcpu state during initialization

2008-12-12 Thread Hollis Blanchard
On Thu, 2008-12-11 at 15:24 -0600, Anthony Liguori wrote: Hollis Blanchard wrote: Currently on x86, qemu initializes CPUState but KVM ignores it and does its own vcpu initialization. However, PowerPC KVM needs to be able to set the initial register state to support the -kernel and -append