[COMMIT] [WIN-GUEST-DRIVERS] Clean up prefast (MS static code analyzer tool) errors.

2009-10-27 Thread Yan Vugenfirer
repository: C:/dev/kvm-guest-drivers-windows branch: master commit 2a08ca42e31cb525a7179c71fbb7f9e19edc7bb3 Author: Yan Vugenfirer yvuge...@redhat.com Date: Tue Oct 27 18:28:43 2009 +0200 [WIN-GUEST-DRIVERS] Clean up prefast (MS static code analyzer tool) errors. Signed-off-by:

Re: vhost-net patches

2009-10-27 Thread Michael S. Tsirkin
On Mon, Oct 26, 2009 at 02:34:49PM -0700, Shirley Ma wrote: Hello Miachel, On Mon, 2009-10-26 at 22:05 +0200, Michael S. Tsirkin wrote: Shirley, could you please test the following patch? With this patch, the performance has gained from 1xxx to 2xxx Mb/s, still has some performance gap

Re: [KVM PATCH v3 1/3] KVM: fix race in irq_routing logic

2009-10-27 Thread Gleb Natapov
On Mon, Oct 26, 2009 at 12:21:57PM -0400, Gregory Haskins wrote: The current code suffers from the following race condition: thread-1thread-2 --- kvm_set_irq() { rcu_read_lock() irq_rt =

[ kvm-Bugs-2886941 ] Extreme slow down using -cpu host

2009-10-27 Thread SourceForge.net
Bugs item #2886941, was opened at 2009-10-27 08:26 Message generated for change (Tracker Item Submitted) made by nwxi You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2886941group_id=180599 Please note that this message will contain a full copy of the

Re: [ANNOUNCE] kvm-kmod-2.6.31.5

2009-10-27 Thread Jan Kiszka
Alexander Graf wrote: On 26.10.2009, at 18:26, Jan Kiszka wrote: This package contains the kvm external modules, using the sources from latest stable Linux release 2.6.31.5. It can be used to update the kernel-side support of kvm without upgrading the host kernel. This release has been

Re: [PATCH 00/27] Add KVM support for Book3s_64 (PPC64) hosts v5

2009-10-27 Thread Avi Kivity
On 10/27/2009 01:21 AM, Olof Johansson wrote: On Oct 26, 2009, at 6:20 PM, Hollis Blanchard wrote: For some reason, I'm not seeing this build break, but the patch is obviously correct. Acked-by: Hollis Blanchard holl...@us.ibm.com I saw it when building with pasemi_defconfig + manually

Re: KVM: VMX: move CR3/PDPTR update to vmx_set_cr3

2009-10-27 Thread Avi Kivity
On 10/26/2009 08:48 PM, Marcelo Tosatti wrote: GUEST_CR3 is updated via kvm_set_cr3 whenever CR3 is modified from outside guest context. Similarly pdptrs are updated via load_pdptrs. Let kvm_set_cr3 perform the update, removing it from the vcpu_run fast path. Applied, thanks. -- error

Re: [Autotest] [KVM-AUTOTEST PATCH 3/7] KVM test: new test timedrift_with_migration

2009-10-27 Thread Dor Laor
On 10/12/2009 05:28 PM, Lucas Meneghel Rodrigues wrote: Hi Michael, I am reviewing your patchset and have just a minor remark to make here: On Wed, Oct 7, 2009 at 2:54 PM, Michael Goldishmgold...@redhat.com wrote: This patch adds a new test that checks the timedrift introduced by migrations.

Re: xp guest, blue screen c0000221 on boot

2009-10-27 Thread Avi Kivity
On 10/26/2009 11:09 PM, Andrew Olney wrote: Hangs on boot, xp guest: STOP: c221 Unknown Hard Error \SystemRoot\System32\ntdll.dll Will boot into safe mode, but _not_ into safe mode with networking. According to http://support.microsoft.com/kb/314474, this file is corrupted. If you

Re: Virtio block module slower than IDE

2009-10-27 Thread Avi Kivity
On 10/27/2009 02:13 AM, Floris Bos wrote: Hi, I am running Proxmox 1.4 (which uses the 2.6.30.1 kvm modules) and am experiencing performance problems with Linux guests using the virtio_blk module. Especially with random IO it is a lot slower than IDE. Try switching the host I/O

Re: -cpu host AMD Host

2009-10-27 Thread Avi Kivity
On 10/26/2009 09:55 PM, Martin Gallant wrote: Is “–cpu host” supported on AMD hosts? Yes. Whenever I try to use this option on a Windows Vista/7 client, I get blue screen. Removing the option, the client works fine. Host kernel 2.6.31.4. Userspace is qemu-kvm-0.11.0. (Previous

Re: performance regression in virtio-net in 2.6.32-rc4

2009-10-27 Thread Avi Kivity
On 10/26/2009 08:48 PM, Michael S. Tsirkin wrote: Hi! I noticed a performance regression in virtio net: going from 2.6.31 to 2.6.32-rc4 I see this, for guest to host communication: Any tips on debugging this? Lacking better advice, a bisect can help as a last resort. 'git bisect start

Re: kvm problems on new hardware

2009-10-27 Thread Avi Kivity
On 10/26/2009 12:06 PM, Danny ter Haar wrote: Hello, I have a KVM virtualization problem. I've put together new hardware (supermicro) server with 2 E5530 cpu's and memory disk to start experimenting with virtualization. I intend to use the www.proxmox.com system/setup. I installed proxmox and

[ kvm-Bugs-2886941 ] Extreme slow down using -cpu host

2009-10-27 Thread SourceForge.net
Bugs item #2886941, was opened at 2009-10-27 09:26 Message generated for change (Comment added) made by avik You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2886941group_id=180599 Please note that this message will contain a full copy of the comment

[ kvm-Bugs-2886941 ] Extreme slow down using -cpu host

2009-10-27 Thread SourceForge.net
Bugs item #2886941, was opened at 2009-10-27 09:26 Message generated for change (Settings changed) made by avik You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2886941group_id=180599 Please note that this message will contain a full copy of the comment

Re: -cpu host AMD Host

2009-10-27 Thread Avi Kivity
On 10/27/2009 11:39 AM, Avi Kivity wrote: On 10/26/2009 09:55 PM, Martin Gallant wrote: Is “–cpu host” supported on AMD hosts? Yes. Whenever I try to use this option on a Windows Vista/7 client, I get blue screen. Removing the option, the client works fine. Host kernel 2.6.31.4.

Re: kvm problems on new hardware

2009-10-27 Thread Danny ter Haar
On Tue, 2009-10-27 at 11:45 +0200, Avi Kivity wrote: Does this happen for all guests (different OSes), or just this one? I tried an iso of both X86_64 and i386 of debian. I even burned the iso image to a real cd to try if it would boot (it did) Then i tried a rescuecd image: same behaviour.

Re: kvm problems on new hardware

2009-10-27 Thread Danny ter Haar
On Tue, 2009-10-27 at 11:45 +0200, Avi Kivity wrote: Does this happen for all guests (different OSes), or just this one? I just tried a windows7 cd image Same error: vmbr0: port 2(vmtab105i0) entering learning state vmbr0: topology change detected, propagating vmbr0: port 2(vmtab105i0)

Re: kvm problems on new hardware

2009-10-27 Thread Avi Kivity
On 10/27/2009 12:27 PM, Danny ter Haar wrote: On Tue, 2009-10-27 at 11:45 +0200, Avi Kivity wrote: Does this happen for all guests (different OSes), or just this one? I just tried a windows7 cd image Same error: vmbr0: port 2(vmtab105i0) entering learning state vmbr0: topology

Re: [ANNOUNCE] kvm-kmod-2.6.31.5

2009-10-27 Thread Avi Kivity
On 10/27/2009 10:25 AM, Jan Kiszka wrote: Wanted to attach this information to the tarball as well, but sourceforge's FRS is still in a almost completely broken state. Sigh. It can be done - upload the changelog file, make it as a changelog, and then go to the tarball and link the newly

Re: Jan Kiszka to maintain kvm-kmod

2009-10-27 Thread Avi Kivity
On 10/26/2009 07:51 PM, Jan Kiszka wrote: That forecast already promises the next rain That would be me. I think it's easily fixable, either by emulating user return notifiers using preempt notifiers (sched_out - on_user_return), or by noping out user return notifiers completely and hooking

Re: kvm problems on new hardware

2009-10-27 Thread Danny ter Haar
On Tue, 2009-10-27 at 12:34 +0200, Avi Kivity wrote: I'm not able to reproduce this on a similar processor. Can you post your qemu command line? vhost1:/var/tmp# ps axuw |grep kvm root 5843 42.7 0.0 621048 13560 ?Sl 11:35 0:06 /usr/bin/kvm -monitor

Re: [ANNOUNCE] kvm-kmod-2.6.31.5

2009-10-27 Thread Jan Kiszka
Avi Kivity wrote: On 10/27/2009 10:25 AM, Jan Kiszka wrote: Wanted to attach this information to the tarball as well, but sourceforge's FRS is still in a almost completely broken state. Sigh. It can be done - upload the changelog file, make it as a changelog, and then go to the

Re: Jan Kiszka to maintain kvm-kmod

2009-10-27 Thread Jan Kiszka
Avi Kivity wrote: On 10/26/2009 07:51 PM, Jan Kiszka wrote: That forecast already promises the next rain That would be me. I think it's easily fixable, either by emulating user return notifiers using preempt notifiers (sched_out - on_user_return), or by noping out user return notifiers

Re: [Autotest] [PATCH 1/2] KVM-test: Add execute permission to qemu-ifup script

2009-10-27 Thread Lucas Meneghel Rodrigues
Ooops fixed, thanks! On Tue, Oct 27, 2009 at 2:07 AM, Amos Kong ak...@redhat.com wrote: qemu-ifup is a script for setting network bridge. If no execute permission, always face this problem: autotest/client/tests/kvm/scripts/qemu-ifup: could not launch network script Could not initialize

BUG with Win7 and user-return-notifier

2009-10-27 Thread Jan Kiszka
Hi Avi, just booted kvm.git master (974ae8d7ff) as host and re-ran my boot test of Windows 7. Already during Starting Windows I get this: ... general protection fault: [#1] PREEMPT SMP last sysfs file: /sys/devices/LNXSYSTM:00/LNXSYBUS:00/PNP0C0A:01/power_supply/CMB2/charge_full CPU 0

Re: BUG with Win7 and user-return-notifier

2009-10-27 Thread Avi Kivity
On 10/27/2009 02:52 PM, Jan Kiszka wrote: Hi Avi, just booted kvm.git master (974ae8d7ff) as host and re-ran my boot test of Windows 7. Already during Starting Windows I get this: x86 or x64 7? RAX: RBX: 0003 RCX: c080 RDX: RSI:

Re: BUG with Win7 and user-return-notifier

2009-10-27 Thread Jan Kiszka
Avi Kivity wrote: On 10/27/2009 02:52 PM, Jan Kiszka wrote: Hi Avi, just booted kvm.git master (974ae8d7ff) as host and re-ran my boot test of Windows 7. Already during Starting Windows I get this: x86 or x64 7? x64. RAX: RBX: 0003 RCX:

Re: BUG with Win7 and user-return-notifier

2009-10-27 Thread Avi Kivity
On 10/27/2009 03:13 PM, Jan Kiszka wrote: Avi Kivity wrote: On 10/27/2009 02:52 PM, Jan Kiszka wrote: Hi Avi, just booted kvm.git master (974ae8d7ff) as host and re-ran my boot test of Windows 7. Already during Starting Windows I get this: x86 or x64 7? x64.

Re: BUG with Win7 and user-return-notifier

2009-10-27 Thread Avi Kivity
On 10/27/2009 03:24 PM, Avi Kivity wrote: Worked for me - getting to the initial prompt. Do you have CONFIG_USER_RETURN_NOTIFIER=y in your .config? If you do, send your own .config, will try to reproduce. -- error compiling committee.c: too many arguments to function -- To

Re: [KVM PATCH v3 1/3] KVM: fix race in irq_routing logic

2009-10-27 Thread Gregory Haskins
Hi Paul, Paul E. McKenney wrote: On Mon, Oct 26, 2009 at 12:21:57PM -0400, Gregory Haskins wrote: The current code suffers from the following race condition: thread-1thread-2 --- kvm_set_irq() {

Re: [KVM PATCH v3 1/3] KVM: fix race in irq_routing logic

2009-10-27 Thread Gregory Haskins
Gleb Natapov wrote: On Mon, Oct 26, 2009 at 12:21:57PM -0400, Gregory Haskins wrote: The current code suffers from the following race condition: thread-1thread-2 --- kvm_set_irq() {

Re: [PATCH 00/27] Add KVM support for Book3s_64 (PPC64) hosts v5

2009-10-27 Thread Alexander Graf
On 27.10.2009, at 09:56, Avi Kivity wrote: On 10/27/2009 01:21 AM, Olof Johansson wrote: On Oct 26, 2009, at 6:20 PM, Hollis Blanchard wrote: For some reason, I'm not seeing this build break, but the patch is obviously correct. Acked-by: Hollis Blanchard holl...@us.ibm.com I saw it when

RE: -cpu host AMD Host

2009-10-27 Thread Martin Gallant
I still see the problem with the kernel patch applied. /proc/cpuinfo attached Will post a formal bug report with all dumps in a few minutes. Thanks for the quick response. -- Marty -Original Message- From: Avi Kivity [mailto:a...@redhat.com] Sent: Tuesday, October 27, 2009 4:58 AM

Re: [KVM PATCH v3 1/3] KVM: fix race in irq_routing logic

2009-10-27 Thread Gregory Haskins
Gregory Haskins wrote: Gleb Natapov wrote: On Mon, Oct 26, 2009 at 12:21:57PM -0400, Gregory Haskins wrote: The current code suffers from the following race condition: thread-1thread-2 ---

Re: [KVM PATCH v3 1/3] KVM: fix race in irq_routing logic

2009-10-27 Thread Gleb Natapov
On Tue, Oct 27, 2009 at 09:39:03AM -0400, Gregory Haskins wrote: Gleb Natapov wrote: On Mon, Oct 26, 2009 at 12:21:57PM -0400, Gregory Haskins wrote: The current code suffers from the following race condition: thread-1thread-2

[ kvm-Bugs-2887189 ] -cpu host Blue-Screens M$ Guests

2009-10-27 Thread SourceForge.net
Bugs item #2887189, was opened at 2009-10-27 09:04 Message generated for change (Tracker Item Submitted) made by martyg7 You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=893831aid=2887189group_id=180599 Please note that this message will contain a full copy of the

Re: [KVM PATCH v3 1/3] KVM: fix race in irq_routing logic

2009-10-27 Thread Gleb Natapov
On Tue, Oct 27, 2009 at 10:00:15AM -0400, Gregory Haskins wrote: Gregory Haskins wrote: Gleb Natapov wrote: On Mon, Oct 26, 2009 at 12:21:57PM -0400, Gregory Haskins wrote: The current code suffers from the following race condition: thread-1thread-2

Re: vhost-net patches

2009-10-27 Thread Shirley Ma
Hello Michael, On Tue, 2009-10-27 at 08:43 +0200, Michael S. Tsirkin wrote: At some point my guest had a runaway nash-hotplug process consuming 100% CPU. Could you please verify this does not happen to you? What I have found that the start_xmit stopped and restarted too often. There is no

Re: [KVM PATCH v3 1/3] KVM: fix race in irq_routing logic

2009-10-27 Thread Gregory Haskins
Gleb Natapov wrote: On Tue, Oct 27, 2009 at 09:39:03AM -0400, Gregory Haskins wrote: Gleb Natapov wrote: On Mon, Oct 26, 2009 at 12:21:57PM -0400, Gregory Haskins wrote: The current code suffers from the following race condition: thread-1thread-2

Re: vhost-net patches

2009-10-27 Thread Shirley Ma
On Tue, 2009-10-27 at 08:38 +0200, Michael S. Tsirkin wrote: Yes but you need to make host send packets out to tap as well, somehow. One way to do this is to assign IP address in a separate subnet to tap in host and to eth device in guest. Thanks for the hint, I will make a try. Shirley --

Re: [KVM PATCH v3 1/3] KVM: fix race in irq_routing logic

2009-10-27 Thread Paul E. McKenney
On Tue, Oct 27, 2009 at 04:02:37PM +0200, Gleb Natapov wrote: On Tue, Oct 27, 2009 at 09:39:03AM -0400, Gregory Haskins wrote: [ . . . ] standard RCU RSCS, which is what SRCU is designed for. So rather than inventing an awkward two-phased stack based solution, it's better to reuse the

Re: [KVM PATCH v3 1/3] KVM: fix race in irq_routing logic

2009-10-27 Thread Gregory Haskins
Gleb Natapov wrote: On Tue, Oct 27, 2009 at 10:00:15AM -0400, Gregory Haskins wrote: Gregory Haskins wrote: Gleb Natapov wrote: On Mon, Oct 26, 2009 at 12:21:57PM -0400, Gregory Haskins wrote: The current code suffers from the following race condition: thread-1

Re: [KVM PATCH v3 1/3] KVM: fix race in irq_routing logic

2009-10-27 Thread Gregory Haskins
Thanks for this, Paul. Some questions and statements below. Paul E. McKenney wrote: On Tue, Oct 27, 2009 at 04:02:37PM +0200, Gleb Natapov wrote: On Tue, Oct 27, 2009 at 09:39:03AM -0400, Gregory Haskins wrote: [ . . . ] standard RCU RSCS, which is what SRCU is designed for. So rather

Re: Virtio block module slower than IDE

2009-10-27 Thread Floris Bos
Hi, On Tue, 27 Oct 2009 11:34:57 +0200, Avi Kivity a...@redhat.com wrote: On 10/27/2009 02:13 AM, Floris Bos wrote: I am running Proxmox 1.4 (which uses the 2.6.30.1 kvm modules) and am experiencing performance problems with Linux guests using the virtio_blk module. Especially with

Re: [KVM PATCH v3 1/3] KVM: fix race in irq_routing logic

2009-10-27 Thread Gleb Natapov
On Tue, Oct 27, 2009 at 10:50:45AM -0400, Gregory Haskins wrote: Gleb Natapov wrote: On Tue, Oct 27, 2009 at 10:00:15AM -0400, Gregory Haskins wrote: Gregory Haskins wrote: Gleb Natapov wrote: On Mon, Oct 26, 2009 at 12:21:57PM -0400, Gregory Haskins wrote: The current code suffers from

[patch 0/3] ioctl fixes

2009-10-27 Thread Marcelo Tosatti
See individual patches for details. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[patch 1/3] KVM: x86: disallow multiple KVM_CREATE_IRQCHIP

2009-10-27 Thread Marcelo Tosatti
Otherwise kvm will leak memory on multiple KVM_CREATE_IRQCHIP. CC: sta...@kernel.org Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/arch/x86/kvm/x86.c === --- kvm.orig/arch/x86/kvm/x86.c +++ kvm/arch/x86/kvm/x86.c @@

[patch 2/3] KVM: x86: disallow KVM_{SET,GET}_LAPIC without in kernel irqchip

2009-10-27 Thread Marcelo Tosatti
Otherwise kvm might attempt to dereference a NULL pointer. CC: sta...@kernel.org Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/arch/x86/kvm/x86.c === --- kvm.orig/arch/x86/kvm/x86.c +++ kvm/arch/x86/kvm/x86.c @@

[patch 3/3] KVM: only clear irq_source_id if irqchip is present

2009-10-27 Thread Marcelo Tosatti
Otherwise kvm might attempt to dereference a NULL pointer. CC: sta...@kernel.org Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/virt/kvm/irq_comm.c === --- kvm.orig/virt/kvm/irq_comm.c +++ kvm/virt/kvm/irq_comm.c @@

[PATCH 0/4] megaraid_sas HBA emulation

2009-10-27 Thread Hannes Reinecke
Hi all, this patchset implements an emulation for the megaraid_sas HBA. It provides emulates an LSI MegaRAID SAS 8708EM2 HBA, ie presenting to the guest a virtual SCSI adapter. Internally it is using aio for read/write requests and either SG_IO or SCSI command emulation for everything else. The

[PATCH 1/4] Add 'raid' interface class

2009-10-27 Thread Hannes Reinecke
This patch adds a 'raid' interface class. It is basically a clone of the existing 'scsi' interface, only allowing up to 128 disks. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/pc.c |5 + hw/pci-hotplug.c |1 + hw/scsi-disk.c | 17 + hw/scsi-disk.h

[PATCH 2/4] megasas: LSI MegaRAID SAS HBA emulation

2009-10-27 Thread Hannes Reinecke
This patch add an emulation for the LSI MegaRAID SAS HBA. It is using SG_IO to forward / pass through SCSI commands to the underlying block driver, so no emulation is done currently. Signed-off-by: Hannes Reinecke h...@suse.de --- Makefile.hw |2 +- hw/megasas.c | 1134

[PATCH 3/4] scsi-disk: Factor out SCSI command emulation

2009-10-27 Thread Hannes Reinecke
Other drives might want to use SCSI command emulation without going through the SCSI disk abstraction, as this imposes too many limits on the emulation. Signed-off-by: Hannes Reinecke h...@suse.de --- block.c| 15 ++ block.h|3 + block_int.h|1 + hw/scsi-disk.c |

[PATCH 4/4] megasas: Add SCSI command emulation

2009-10-27 Thread Hannes Reinecke
Now that we can use SCSI command emulation without using the SCSI disk abstraction we can easily add it to the megasas HBA. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/megasas.c | 88 +++--- 1 files changed, 53 insertions(+), 35

Re: vhost-net patches

2009-10-27 Thread Michael S. Tsirkin
On Tue, Oct 27, 2009 at 07:46:59AM -0700, Shirley Ma wrote: Hello Michael, On Tue, 2009-10-27 at 08:43 +0200, Michael S. Tsirkin wrote: At some point my guest had a runaway nash-hotplug process consuming 100% CPU. Could you please verify this does not happen to you? What I have found

Re: [KVM PATCH v3 1/3] KVM: fix race in irq_routing logic

2009-10-27 Thread Gleb Natapov
On Tue, Oct 27, 2009 at 10:47:49AM -0400, Gregory Haskins wrote: Gleb Natapov wrote: On Tue, Oct 27, 2009 at 09:39:03AM -0400, Gregory Haskins wrote: Gleb Natapov wrote: On Mon, Oct 26, 2009 at 12:21:57PM -0400, Gregory Haskins wrote: The current code suffers from the following race

[PATCH v2] fix qemu-kvm sigsegv at exit

2009-10-27 Thread Marcelo Tosatti
Michael reported a qemu-kvm SIGSEGV at shutdown: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x411d0940 (LWP 14446)] 0x0040afb4 in qemu_mod_timer (ts=0x19f0fd0, expire_time=62275467335) at /home/mst/scm/qemu-kvm/vl.c:1009 1009if

Re: [KVM PATCH v3 1/3] KVM: fix race in irq_routing logic

2009-10-27 Thread Gregory Haskins
Gleb Natapov wrote: On Tue, Oct 27, 2009 at 10:50:45AM -0400, Gregory Haskins wrote: Gleb Natapov wrote: On Tue, Oct 27, 2009 at 10:00:15AM -0400, Gregory Haskins wrote: Gregory Haskins wrote: Gleb Natapov wrote: On Mon, Oct 26, 2009 at 12:21:57PM -0400, Gregory Haskins wrote: The current

Re: [PATCH 00/27] Add KVM support for Book3s_64 (PPC64) hosts v5

2009-10-27 Thread Avi Kivity
On 10/27/2009 03:42 PM, Alexander Graf wrote: I can, but it's only partly related. My patches don't even touch timing.c. The only thing I can imagine resulting in a breakage is that my patches allow for an =M setting. So IMHO this patch should be applied before my series. Should I stick it

[PATCH 0/5]: Fix kdump under KVM

2009-10-27 Thread Chris Lalancette
This patch series aims to get kdump working inside a KVM guest. The current problem with using kdump is that KVM always delivers PIT interrupts to the BSP, and the BSP only. While this is technically allowed by the MPS spec, most motherboards actually deliver timer interrupts to *any* LAPIC in

[PATCH 1/5] Fix up some comments around the source tree.

2009-10-27 Thread Chris Lalancette
Signed-off-by: Chris Lalancette clala...@redhat.com --- :100644 100644 34b700f... ba61f27... M arch/x86/kvm/svm.c :100644 100644 38a2d20... cd6f92b... M virt/kvm/ioapic.c :100644 100644 bd44fb4... c22bc17... M virt/kvm/kvm_main.c arch/x86/kvm/svm.c |2 +- virt/kvm/ioapic.c |2 +-

[PATCH 3/5] Remove references to VCPU in i8254

2009-10-27 Thread Chris Lalancette
Conceptually, the i8254 is hooked to a PIC or IOAPIC. Therefore, this patch removes most references to vcpu in i8254.c. There are two exceptions to this: 1) In pit_timer_fn, we still have to kick the BSP to wake it out of idle. This will be changed in a later patch. 2) In

[PATCH 5/5] Fix kdump under KVM.

2009-10-27 Thread Chris Lalancette
This patch is the main point of the series. In order for kdump to properly work inside a KVM guest, we need to make sure that all VCPUs in virtual wire APIC mode get kicked to try and pick up the timer interrupts. To do this, we iterate over the CPUs and deliver interrupts to the proper VCPUs.

[PATCH 4/5] Remove timer.c

2009-10-27 Thread Chris Lalancette
The code in arch/x86/kvm/timer.c is not similar enough between the various implementations to really share it. Move the implementation into the LAPIC code, and then remove timer.c Signed-off-by: Chris Lalancette clala...@redhat.com --- :100644 100644 31a7035... 8d9adf6... M

[PATCH 2/5] Remove KVM_REQ_PENDING_TIMER.

2009-10-27 Thread Chris Lalancette
KVM_REQ_PENDING_TIMER is set and cleared in a couple of places, but it never seems to be actually checked. Remove it. Signed-off-by: Chris Lalancette clala...@redhat.com --- :100644 100644 eea4043... 72b5144... M arch/x86/kvm/timer.c :100644 100644 2ef39062.. 93a65b4... M arch/x86/kvm/x86.c

Re: [Qemu-devel] [PATCH 0/4] megaraid_sas HBA emulation

2009-10-27 Thread Gerd Hoffmann
Hi, The device can be accessed by -drive if=raid,file=XXX Don't extend that qemu automagic please. The new way to handle this is: -drive if=none,id=mydisk,file=/path/to/some/disk.img -device megasas,id=raid -device scsi-disk,bus=raid.0,scsi-id=1,drive=mydisk In order to support

Re: [KVM PATCH v3 1/3] KVM: fix race in irq_routing logic

2009-10-27 Thread Gregory Haskins
Gleb Natapov wrote: 1) rcu_read_lock is something like 4x faster than srcu_read_lock(), but we are talking about nanoseconds on modern hardware (I think Paul quoted me 10ns vs 45ns on his rig). I don't think either overhead is something to be concerned about in this case. If we can avoid

Re: [KVM PATCH v3 1/3] KVM: fix race in irq_routing logic

2009-10-27 Thread Paul E. McKenney
On Tue, Oct 27, 2009 at 09:34:41AM -0400, Gregory Haskins wrote: Hi Paul, Paul E. McKenney wrote: On Mon, Oct 26, 2009 at 12:21:57PM -0400, Gregory Haskins wrote: The current code suffers from the following race condition: thread-1thread-2

Re: [KVM PATCH v3 1/3] KVM: fix race in irq_routing logic

2009-10-27 Thread Paul E. McKenney
On Tue, Oct 27, 2009 at 11:02:23AM -0400, Gregory Haskins wrote: Thanks for this, Paul. Some questions and statements below. Paul E. McKenney wrote: On Tue, Oct 27, 2009 at 04:02:37PM +0200, Gleb Natapov wrote: On Tue, Oct 27, 2009 at 09:39:03AM -0400, Gregory Haskins wrote: [ . .

Re: [PATCH 5/5] Fix kdump under KVM.

2009-10-27 Thread Marcelo Tosatti
On Tue, Oct 27, 2009 at 05:41:07PM +0100, Chris Lalancette wrote: This patch is the main point of the series. In order for kdump to properly work inside a KVM guest, we need to make sure that all VCPUs in virtual wire APIC mode get kicked to try and pick up the timer interrupts. To do this,

Re: [KVM PATCH v3 3/3] KVM: Directly inject interrupts if they support lockless operation

2009-10-27 Thread Michael S. Tsirkin
On Mon, Oct 26, 2009 at 12:22:08PM -0400, Gregory Haskins wrote: IRQFD currently uses a deferred workqueue item to execute the injection operation. It was originally designed this way because kvm_set_irq() required the caller to hold the irq_lock mutex, and the eventfd callback is invoked

Re: [PATCH 1/3] introduce VMSTATE_U64

2009-10-27 Thread Andrew Theurer
On Tue, Oct 20, 2009 at 08:40:26AM +0900, Avi Kivity wrote: On 10/17/2009 04:27 AM, Glauber Costa wrote: This is a patch actually written by Juan, which, according to him, he plans on posting to qemu.git. Problem is that linux defines u64 in a way that is type-uncompatible with uint64_t.

Re: [patch 1/3] KVM: x86: disallow multiple KVM_CREATE_IRQCHIP

2009-10-27 Thread Michael S. Tsirkin
On Tue, Oct 27, 2009 at 01:10:43PM -0200, Marcelo Tosatti wrote: Otherwise kvm will leak memory on multiple KVM_CREATE_IRQCHIP. CC: sta...@kernel.org Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/arch/x86/kvm/x86.c

Re: [patch 2/3] KVM: x86: disallow KVM_{SET,GET}_LAPIC without in kernel irqchip

2009-10-27 Thread Michael S. Tsirkin
On Tue, Oct 27, 2009 at 01:10:44PM -0200, Marcelo Tosatti wrote: Otherwise kvm might attempt to dereference a NULL pointer. CC: sta...@kernel.org Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: kvm/arch/x86/kvm/x86.c

Re: [KVM PATCH v3 3/3] KVM: Directly inject interrupts if they support lockless operation

2009-10-27 Thread Gregory Haskins
Michael S. Tsirkin wrote: On Mon, Oct 26, 2009 at 12:22:08PM -0400, Gregory Haskins wrote: IRQFD currently uses a deferred workqueue item to execute the injection operation. It was originally designed this way because kvm_set_irq() required the caller to hold the irq_lock mutex, and the

[PATCH] [RFC] KVM test: Major control file cleanup

2009-10-27 Thread Lucas Meneghel Rodrigues
As pointed out before, the KVM reference control files could use a little clean up. This patch implements severe cleanup of the main control file by: * Refactoring the code present there, moving it to the kvm_utils.py library * Treat the build test exactly the same way as other tests, moving the

Re: vhost-net patches

2009-10-27 Thread Michael S. Tsirkin
On Tue, Oct 27, 2009 at 09:36:18AM -0700, Shirley Ma wrote: Hello Michael, On Tue, 2009-10-27 at 17:27 +0200, Michael S. Tsirkin wrote: Possibly GFP_ATOMIC allocations in vring_add_indirect are failing? Is there a chance you are tight on guest memory for some reason? with vhost, virtio

Re: performance regression in virtio-net in 2.6.32-rc4

2009-10-27 Thread Rusty Russell
On Tue, 27 Oct 2009 05:18:35 am Michael S. Tsirkin wrote: Hi! I noticed a performance regression in virtio net: going from 2.6.31 to 2.6.32-rc4 I see this, for guest to host communication: ... Size SizeSize Time Throughput bytes bytes bytessecs.10^6bits/sec 87380

Re: [ANNOUNCE] Sheepdog: Distributed Storage System for KVM

2009-10-27 Thread MORITA Kazutaka
On 2009/10/21 14:13, MORITA Kazutaka wrote: Hi everyone, Sheepdog is a distributed storage system for KVM/QEMU. It provides highly available block level storage volumes to VMs like Amazon EBS. Sheepdog supports advanced volume management features such as snapshot, cloning, and thin

Re: [PATCH 00/27] Add KVM support for Book3s_64 (PPC64) hosts v5

2009-10-27 Thread Avi Kivity
On 10/27/2009 01:21 AM, Olof Johansson wrote: On Oct 26, 2009, at 6:20 PM, Hollis Blanchard wrote: For some reason, I'm not seeing this build break, but the patch is obviously correct. Acked-by: Hollis Blanchard holl...@us.ibm.com I saw it when building with pasemi_defconfig + manually

Re: [PATCH 00/27] Add KVM support for Book3s_64 (PPC64) hosts v5

2009-10-27 Thread Alexander Graf
On 27.10.2009, at 09:56, Avi Kivity wrote: On 10/27/2009 01:21 AM, Olof Johansson wrote: On Oct 26, 2009, at 6:20 PM, Hollis Blanchard wrote: For some reason, I'm not seeing this build break, but the patch is obviously correct. Acked-by: Hollis Blanchard holl...@us.ibm.com I saw it when

Re: [PATCH 00/27] Add KVM support for Book3s_64 (PPC64) hosts v5

2009-10-27 Thread Avi Kivity
On 10/27/2009 03:42 PM, Alexander Graf wrote: I can, but it's only partly related. My patches don't even touch timing.c. The only thing I can imagine resulting in a breakage is that my patches allow for an =M setting. So IMHO this patch should be applied before my series. Should I stick it