[PATCH v2] KVM test: Enable timedrift for Linux guests

2010-03-24 Thread Jason Wang
We should also test timedrift for Linux guests especially for guest with pvclock. So this patch enable the timedrift for linux guests. Changes from v1: - Correct the wrong name for guest load cleaning - Use -no-kvm-pit-reinjection for linux guests and -rtc-td-hack for windows guests.

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Avi Kivity
On 03/24/2010 07:09 AM, Andi Kleen wrote: Joerg Roedelj...@8bytes.org writes: Sidenote: I really think we should come to a conclusion about the concept. KVM integration into perf is very useful feature to analyze virtualization workloads. Agreed. I especially

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Andi Kleen
If you're profiling a single guest it makes more sense to do this from inside the guest - you can profile userspace as well as the kernel. I'm interested in debugging the guest without guest cooperation. In many cases qemu's new gdb stub works for that, but in some cases I would prefer

[KVM-AUTOTEST PATCH] KVM test: timedrift: open load sessions before taking initial time

2010-03-24 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests/timedrift.py | 18 ++ 1 files changed, 10 insertions(+), 8 deletions(-) diff --git a/client/tests/kvm/tests/timedrift.py b/client/tests/kvm/tests/timedrift.py index 194f09c..9cb7489 100644 ---

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Avi Kivity
On 03/24/2010 09:38 AM, Andi Kleen wrote: If you're profiling a single guest it makes more sense to do this from inside the guest - you can profile userspace as well as the kernel. I'm interested in debugging the guest without guest cooperation. In many cases qemu's new gdb stub works

Re: KVM: x86: document KVM_REQ_PENDING_TIMER usage

2010-03-24 Thread Avi Kivity
On 03/23/2010 07:15 PM, Marcelo Tosatti wrote: Document that KVM_REQ_PENDING_TIMER is implicitly used during guest entry. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a

Re: [PATCH v3] KVM MMU: check reserved bits only if CR4.PSE=1 or CR4.PAE=1

2010-03-24 Thread Avi Kivity
On 03/19/2010 11:58 AM, Xiao Guangrong wrote: - Check reserved bits only if CR4.PAE=1 or CR4.PSE=1 when guest #PF occurs - Fix a typo in reset_rsvds_bits_mask() Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Andi Kleen
Avi Kivity a...@redhat.com writes: On 03/24/2010 09:38 AM, Andi Kleen wrote: If you're profiling a single guest it makes more sense to do this from inside the guest - you can profile userspace as well as the kernel. I'm interested in debugging the guest without guest cooperation. In

Re: [PATCH] Bail out when VCPU_CREATE fails

2010-03-24 Thread Avi Kivity
On 03/22/2010 12:49 PM, Alexander Graf wrote: When we fail to create a VCPU we have no way to tell our callers that something failed. So the caller happily uses a completely broken state. This code should become deprecated in the process of converting qemu-kvm to qemu anyways, so let's not care

Re: [PATCH] Bail out when VCPU_CREATE fails

2010-03-24 Thread Alexander Graf
On 24.03.2010, at 10:32, Avi Kivity wrote: On 03/22/2010 12:49 PM, Alexander Graf wrote: When we fail to create a VCPU we have no way to tell our callers that something failed. So the caller happily uses a completely broken state. This code should become deprecated in the process of

Re: [patch 0/6] misc qemu-kvm cleanups

2010-03-24 Thread Avi Kivity
On 03/23/2010 06:53 PM, Marcelo Tosatti wrote: See individual patches for details. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More

Re: [patch 0/6] misc uq/master updates (v2)

2010-03-24 Thread Avi Kivity
On 03/23/2010 06:37 PM, Marcelo Tosatti wrote: See individual patches for details. Applied, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More

[PATCH] qemu-kvm: jaso-parser: Output the content of invalid keyword

2010-03-24 Thread Amos Kong
When input some invialid words in QMP port, qemu outputs this error message: parse error: invalid keyword `%s' This patch makes qemu output the content. Signed-off-by: Amos Kong ak...@redhat.com --- json-parser.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git

Re: Completing big real mode emulation

2010-03-24 Thread Sheng Yang
On Saturday 20 March 2010 23:00:49 Alexander Graf wrote: Am 20.03.2010 um 15:02 schrieb Mohammed Gamal m.gamal...@gmail.com: On Sat, Mar 20, 2010 at 3:18 PM, Avi Kivity a...@redhat.com wrote: On 03/20/2010 10:55 AM, Alexander Graf wrote: I'd say that a GSoC project would rather focus on

Re: [PATCH] qemu-kvm: jaso-parser: Output the content of invalid keyword

2010-03-24 Thread Aurelien Jarno
Hi, On Wed, Mar 24, 2010 at 06:00:53PM +0800, Amos Kong wrote: When input some invialid words in QMP port, qemu outputs this error message: parse error: invalid keyword `%s' This patch makes qemu output the content. Is this patch for QEMU or KVM? If it is for QEMU, you should put the QEMU

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Joerg Roedel
On Wed, Mar 24, 2010 at 06:57:47AM +0200, Avi Kivity wrote: On 03/23/2010 08:21 PM, Joerg Roedel wrote: This enumeration is a very small and non-intrusive feature. Making it aware of namespaces is easy too. It's easier (and safer and all the other boring bits) not to do it at all in

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Paolo Bonzini
On 03/22/2010 08:13 AM, Avi Kivity wrote: (btw, why are you interested in desktop-on-desktop? one use case is developers, which don't really need fancy GUIs; a second is people who test out distributions, but that doesn't seem to be a huge population; and a third is people running Windows for

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Avi Kivity
On 03/24/2010 01:59 PM, Joerg Roedel wrote: On Wed, Mar 24, 2010 at 06:57:47AM +0200, Avi Kivity wrote: On 03/23/2010 08:21 PM, Joerg Roedel wrote: This enumeration is a very small and non-intrusive feature. Making it aware of namespaces is easy too. It's easier (and safer

Re: SIGSEGV with -smp 17+, and error handling around...

2010-03-24 Thread Avi Kivity
On 03/17/2010 10:12 PM, Michael Tokarev wrote: When run with -smp 17 or greather, kvm fails like this: $ kvm -smp 17 kvm_create_vcpu: Invalid argument kvm_setup_mce FAILED: Invalid argument KVM_SET_LAPIC failed Segmentation fault $ _ In qemu-kvm.c, the kvm_create_vcpu() routine (which is used

Re: qemu-kvm crashes with Assertion ... failed.

2010-03-24 Thread Avi Kivity
On 03/17/2010 11:14 PM, André Weidemann wrote: qemu-system-x86_64 -cpu core2duo -vga cirrus -boot order=ndc -vnc 192.168.3.42:2 -k de -smp 4,cores=4 -drive file=/vmware/Windows7Test_600G.img,if=ide,index=0,cache=writeback -m 1024 -net nic,model=e1000,macaddr=DE:AD:BE:EF:12:3A -net

Re: PCI device passthrough / memory mapping issue

2010-03-24 Thread Avi Kivity
On 03/19/2010 12:46 AM, Fede wrote: I'm currently working to enable vga passthrough in kvm. assigned_dev_iomem_map: e_phys=1000 r_virt=0x7fa64af0e000 type=0 len=0200 region_num=3 kvm_register_phys_mem:580 memory: gpa: 1000, size: 200, uaddr: 7fa64af0e000, slot: 7,flags: 0

Re: [PATCHv6 0/4] qemu-kvm: vhost net port

2010-03-24 Thread Avi Kivity
On 03/17/2010 03:04 PM, Michael S. Tsirkin wrote: This is port of vhost v6 patch set I posted previously to qemu-kvm, for those that want to get good performance out of it :) This patchset needs to be applied when qemu.git one gets merged, this includes irqchip support. Ping me when this

[KVM-AUTOTEST PATCH] KVM test: increase default timeout for autotest.sleeptest

2010-03-24 Thread Michael Goldish
Signed-off-by: Michael Goldish mgold...@redhat.com --- client/tests/kvm/tests_base.cfg.sample |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm/tests_base.cfg.sample b/client/tests/kvm/tests_base.cfg.sample index 249f1b4..b8288fc 100644 ---

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Avi Kivity
On 03/24/2010 02:50 PM, Joerg Roedel wrote: You can always provide the kernel and module paths as command line parameters. It just won't be transparently usable, but if you're using qemu from the command line, presumably you can live with that. I don't want the tool for myself only. A

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Joerg Roedel
On Wed, Mar 24, 2010 at 03:05:02PM +0200, Avi Kivity wrote: On 03/24/2010 02:50 PM, Joerg Roedel wrote: I don't want the tool for myself only. A typical perf user expects that it works transparent. A typical kvm user uses libvirt, so we can integrate it with that. Someone who uses libvirt

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Alexander Graf
Avi Kivity wrote: On 03/24/2010 02:50 PM, Joerg Roedel wrote: You can always provide the kernel and module paths as command line parameters. It just won't be transparently usable, but if you're using qemu from the command line, presumably you can live with that. I don't want the tool

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Avi Kivity
On 03/24/2010 03:46 PM, Joerg Roedel wrote: On Wed, Mar 24, 2010 at 03:05:02PM +0200, Avi Kivity wrote: On 03/24/2010 02:50 PM, Joerg Roedel wrote: I don't want the tool for myself only. A typical perf user expects that it works transparent. A typical kvm user uses

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Avi Kivity
On 03/24/2010 03:53 PM, Alexander Graf wrote: Someone needs to know about the new guest to fetch its symbols. Or do you want that part in the kernel too? How about we add a virtio guest file system access device? The guest would then expose its own file system using that device. On

Re: [PATCH] qemu-kvm: jaso-parser: Output the content of invalid keyword

2010-03-24 Thread Luiz Capitulino
On Wed, 24 Mar 2010 11:29:40 +0100 Aurelien Jarno aurel...@aurel32.net wrote: Hi, On Wed, Mar 24, 2010 at 06:00:53PM +0800, Amos Kong wrote: When input some invialid words in QMP port, qemu outputs this error message: parse error: invalid keyword `%s' This patch makes qemu output the

Re: [KVM PATCH] pci passthrough: zap option rom scanning.

2010-03-24 Thread Alexander Graf
Marcelo Tosatti wrote: On Wed, Jan 20, 2010 at 11:58:48AM +0100, Gerd Hoffmann wrote: Nowdays (qemu 0.12) seabios loads option roms from pci rom bars. So there is no need any more to scan for option roms and have qemu load them. Zap the code. Signed-off-by: Gerd Hoffmann

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Alexander Graf
Avi Kivity wrote: On 03/24/2010 03:53 PM, Alexander Graf wrote: Someone needs to know about the new guest to fetch its symbols. Or do you want that part in the kernel too? How about we add a virtio guest file system access device? The guest would then expose its own file system

Re: [Autotest] [PATCH 2/4] KVM test: Add TSC into guest test

2010-03-24 Thread Lucas Meneghel Rodrigues
On Wed, Mar 24, 2010 at 2:59 AM, Jason Wang jasow...@redhat.com wrote: Lucas Meneghel Rodrigues wrote: On Mon, Mar 22, 2010 at 4:45 AM, Jason Wang jasow...@redhat.com wrote: TSC is used to check the whether the TSC of processors are synchronized which is useful for testing virtual TSC. The

Re: [PATCH v2] KVM test: Enable timedrift for Linux guests

2010-03-24 Thread Lucas Meneghel Rodrigues
On Wed, Mar 24, 2010 at 3:25 AM, Jason Wang jasow...@redhat.com wrote: We should also test timedrift for Linux guests especially for guest with pvclock. So this patch enable the timedrift for linux guests. Changes from v1: - Correct the wrong name for guest load cleaning - Use

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Joerg Roedel
On Wed, Mar 24, 2010 at 03:57:39PM +0200, Avi Kivity wrote: On 03/24/2010 03:46 PM, Joerg Roedel wrote: Someone who uses libvirt and virt-manager by default is probably not interested in this feature at the same level a kvm developer is. And developers tend not to use libvirt for low-level

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Avi Kivity
On 03/24/2010 04:24 PM, Alexander Graf wrote: Avi Kivity wrote: On 03/24/2010 03:53 PM, Alexander Graf wrote: Someone needs to know about the new guest to fetch its symbols. Or do you want that part in the kernel too? How about we add a virtio guest file system

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Avi Kivity
On 03/24/2010 05:01 PM, Joerg Roedel wrote: But when I weigh the benefit of truly transparent system-wide perf integration for users who don't use libvirt but do use perf, versus the cost of transforming kvm from a single-process API to a system-wide API with all the complications that I've

Re: KVM Test report, kernel 647e9e... qemu 7811d4...

2010-03-24 Thread Avi Kivity
On 03/08/2010 08:40 AM, Hao, Xudong wrote: Hi, all, This is KVM biweekly test result against kvm.git: 647e9ec3b543ea04d49a7323dfe0070682ed8465 and qemu-kvm.git: 7811d4e8ec057d25db68f900be1f09a142faca49. In the last month, KVM testing was blocked by one qemu-img issue and two qemu build

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Daniel P. Berrange
On Wed, Mar 24, 2010 at 04:01:37PM +0100, Joerg Roedel wrote: An approach like: The files are owned and only readable by the same user that started the vm. might be a good start. So a user can measure its own guests and root can measure all of them. That's not how sVirt works. sVirt

OEM version of Windows in kvm (SLIC Co)

2010-03-24 Thread Michael Tokarev
After a series of tries, I finally made my OEM copy of Windows 7 to work in KVM using the original registration key. In short, one need SCIC table from the BIOS on the original hardware, -- it should be in the BIOS in the virtual machine too. And second part is that other tables in our virtual

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Joerg Roedel
On Wed, Mar 24, 2010 at 03:26:53PM +, Daniel P. Berrange wrote: On Wed, Mar 24, 2010 at 04:01:37PM +0100, Joerg Roedel wrote: An approach like: The files are owned and only readable by the same user that started the vm. might be a good start. So a user can measure its own guests and

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Avi Kivity
On 03/24/2010 05:37 PM, Joerg Roedel wrote: No it can't. With sVirt every single VM has a custom security label and the policy only allows it access to disks / files with a matching label, and prevents it attacking any other VMs or processes on the host. THis confines the scope of any exploit

Re: KVM: x86: document KVM_REQ_PENDING_TIMER usage

2010-03-24 Thread Marcelo Tosatti
On Wed, Mar 24, 2010 at 09:10:54AM +0800, 王箫 wrote: Thanks for pointing that, but is it possible that explicitly check the pending timer with kvm_cpu_has_pending_timer() in vcpu_enter_guest()? There seems some function duplication between KVM_REQ_PENDING_TIMER and ktimer-pending. Right.

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Joerg Roedel
On Wed, Mar 24, 2010 at 05:12:55PM +0200, Avi Kivity wrote: On 03/24/2010 05:01 PM, Joerg Roedel wrote: $ cd /sys/kvm/guest0 $ ls -l -r 1 root root 0 2009-08-17 12:05 name dr-x-- 1 root root 0 2009-08-17 12:05 fs $ cat name guest0 $ # ... The fs/ directory is used as the

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Avi Kivity
On 03/24/2010 05:46 PM, Joerg Roedel wrote: On Wed, Mar 24, 2010 at 05:12:55PM +0200, Avi Kivity wrote: On 03/24/2010 05:01 PM, Joerg Roedel wrote: $ cd /sys/kvm/guest0 $ ls -l -r 1 root root 0 2009-08-17 12:05 name dr-x-- 1 root root 0 2009-08-17 12:05 fs $ cat name

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Joerg Roedel
On Wed, Mar 24, 2010 at 05:43:31PM +0200, Avi Kivity wrote: On 03/24/2010 05:37 PM, Joerg Roedel wrote: Even better. So a guest which breaks out can't even access its own /sys/kvm/ directory. Perfect, it doesn't need that access anyway. But what security label does that directory have? How

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Avi Kivity
On 03/24/2010 05:50 PM, Joerg Roedel wrote: On Wed, Mar 24, 2010 at 05:43:31PM +0200, Avi Kivity wrote: On 03/24/2010 05:37 PM, Joerg Roedel wrote: Even better. So a guest which breaks out can't even access its own /sys/kvm/ directory. Perfect, it doesn't need that access anyway.

MSI-X not enabled for ixgbe device-passthrough

2010-03-24 Thread Hannes Reinecke
Hi all, I'm trying to setup a system with device-passthrough for an ixgbe NIC. The device itself seems to work, but it isn't using MSI-X. So some more advanced features like DCB offloading etc won't work. lspci output of the device: 07:00.0 Ethernet controller: Intel Corporation 82599EB

Re: [Qemu-devel] [PATCH] qemu: jaso-parser: Output the content of invalid keyword

2010-03-24 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: When input some invialid word 'unknowcmd' through QMP port, qemu outputs this error message: parse error: invalid keyword `%s' This patch makes qemu output the content of invalid keyword, like: parse error: invalid keyword `unknowcmd' Signed-off-by: Amos

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Peter Zijlstra
On Wed, 2010-03-24 at 16:01 +0100, Joerg Roedel wrote: What I meant was: perf-kernel puts the guest-name into every sample and perf-userspace accesses /sys/kvm/guest_name/fs/ later to resolve the symbols. I leave the question of how the guest-fs is exposed to the host out of this discussion.

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Avi Kivity
On 03/24/2010 05:59 PM, Joerg Roedel wrote: I am not tied to /sys/kvm. We could also use /proc/pid/kvm/ for example. This would keep anything in the process space (except for the global list of VMs which we should have anyway). How about ~/.qemu/guests/$pid? That makes it

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Avi Kivity
On 03/24/2010 06:03 PM, Peter Zijlstra wrote: On Wed, 2010-03-24 at 16:01 +0100, Joerg Roedel wrote: What I meant was: perf-kernel puts the guest-name into every sample and perf-userspace accesses /sys/kvm/guest_name/fs/ later to resolve the symbols. I leave the question of how the

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Joerg Roedel
On Wed, Mar 24, 2010 at 05:52:54PM +0200, Avi Kivity wrote: On 03/24/2010 05:50 PM, Joerg Roedel wrote: If we go the /proc/pid/kvm way then the directory should probably inherit the label from /proc/pid/? That's a security policy. The security people like their policies outside the

Re: qemu-kvm crashes with Assertion ... failed.

2010-03-24 Thread André Weidemann
Hi, On 24.03.2010 13:17, Avi Kivity wrote: On 03/17/2010 11:14 PM, André Weidemann wrote: qemu-system-x86_64 -cpu core2duo -vga cirrus -boot order=ndc -vnc 192.168.3.42:2 -k de -smp 4,cores=4 -drive file=/vmware/Windows7Test_600G.img,if=ide,index=0,cache=writeback -m 1024 -net

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Avi Kivity
On 03/24/2010 06:17 PM, Joerg Roedel wrote: On Wed, Mar 24, 2010 at 05:52:54PM +0200, Avi Kivity wrote: On 03/24/2010 05:50 PM, Joerg Roedel wrote: If we go the /proc/pid/kvm way then the directory should probably inherit the label from /proc/pid/? That's a security policy.

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Joerg Roedel
On Wed, Mar 24, 2010 at 05:03:42PM +0100, Peter Zijlstra wrote: On Wed, 2010-03-24 at 16:01 +0100, Joerg Roedel wrote: What I meant was: perf-kernel puts the guest-name into every sample and perf-userspace accesses /sys/kvm/guest_name/fs/ later to resolve the symbols. I leave the question

Re: qemu-kvm crashes with Assertion ... failed.

2010-03-24 Thread Avi Kivity
On 03/24/2010 06:20 PM, André Weidemann wrote: Does this happen with a guest installed on kvm, or just with the guest that (guessing from the name) was imported from vmware? I booted the VM via PXE into an Ubuntu Live CD image. I only added the Windows disk image, so I could copy the

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Joerg Roedel
On Wed, Mar 24, 2010 at 06:20:38PM +0200, Avi Kivity wrote: On 03/24/2010 06:17 PM, Joerg Roedel wrote: But is this not only one entity more for sVirt to handle? I would leave that decision to the sVirt developers. Does attaching the same label as for the VM resources mean that root could not

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Avi Kivity
On 03/24/2010 06:31 PM, Joerg Roedel wrote: On Wed, Mar 24, 2010 at 06:20:38PM +0200, Avi Kivity wrote: On 03/24/2010 06:17 PM, Joerg Roedel wrote: But is this not only one entity more for sVirt to handle? I would leave that decision to the sVirt developers. Does attaching the same

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Joerg Roedel
On Wed, Mar 24, 2010 at 06:09:30PM +0200, Avi Kivity wrote: On 03/24/2010 05:59 PM, Joerg Roedel wrote: I am not tied to /sys/kvm. We could also use /proc/pid/kvm/ for example. This would keep anything in the process space (except for the global list of VMs which we should have anyway).

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Joerg Roedel
On Wed, Mar 24, 2010 at 06:32:51PM +0200, Avi Kivity wrote: On 03/24/2010 06:31 PM, Joerg Roedel wrote: That's just what I want to do. Leave it in userspace and then they can deal with it without telling us about it. They can't do that with a directory in /proc? -- To unsubscribe from

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Peter Zijlstra
On Wed, 2010-03-24 at 17:23 +0100, Joerg Roedel wrote: On Wed, Mar 24, 2010 at 05:03:42PM +0100, Peter Zijlstra wrote: On Wed, 2010-03-24 at 16:01 +0100, Joerg Roedel wrote: What I meant was: perf-kernel puts the guest-name into every sample and perf-userspace accesses

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Avi Kivity
On 03/24/2010 06:40 PM, Joerg Roedel wrote: Looks trivial to find a guest, less so with enumerating (still doable). Not so trival and even more likely to break. Even it perf has the pid of the process and wants to find the directory it has to do: 1. Get the uid of the process 2. Find

[PATCH] KVM: allow bit 10 to be cleared in MSR_IA32_MC4_CTL

2010-03-24 Thread Andre Przywara
There is a quirk for AMD K8 CPUs in many Linux kernels (see arch/x86/kernel/cpu/mcheck/mce.c:__mcheck_cpu_apply_quirks()) that clears bit 10 in that MCE related MSR. KVM can only cope with all zeros or all ones, so it will inject a #GP into the guest, which will let it panic. So lets add a quirk

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Avi Kivity
On 03/24/2010 06:45 PM, Joerg Roedel wrote: That's just what I want to do. Leave it in userspace and then they can deal with it without telling us about it. They can't do that with a directory in /proc? I don't know. -- error compiling committee.c: too many arguments to

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Avi Kivity
On 03/24/2010 06:47 PM, Avi Kivity wrote: It's true. If the kernel provides something, there are fewer things that can break. But if your system is so broken that you can't resolve uids, fix that before running perf. Must we design perf for that case? After all, 'ls -l' will break under

Re: [PATCH] qemu: jaso-parser: Output the content of invalid keyword

2010-03-24 Thread Richard Henderson
On 03/24/2010 08:12 AM, Amos Kong wrote: When input some invialid word 'unknowcmd' through QMP port, qemu outputs this error message: parse error: invalid keyword `%s' This patch makes qemu output the content of invalid keyword, like: parse error: invalid keyword `unknowcmd'

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Arnaldo Carvalho de Melo
Em Wed, Mar 24, 2010 at 06:09:30PM +0200, Avi Kivity escreveu: Doesn't perf already has a dependency on naming conventions for finding debug information? It looks at several places, from most symbol rich (/usr/lib/debug/, aka -debuginfo packages, where we have full symtabs) to poorest (the

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Avi Kivity
On 03/24/2010 07:47 PM, Arnaldo Carvalho de Melo wrote: Em Wed, Mar 24, 2010 at 06:09:30PM +0200, Avi Kivity escreveu: Doesn't perf already has a dependency on naming conventions for finding debug information? It looks at several places, from most symbol rich (/usr/lib/debug/, aka

Re: [RFC] Unify KVM kernel-space and user-space code into a single project

2010-03-24 Thread Arnaldo Carvalho de Melo
Em Wed, Mar 24, 2010 at 08:20:10PM +0200, Avi Kivity escreveu: On 03/24/2010 07:47 PM, Arnaldo Carvalho de Melo wrote: Em Wed, Mar 24, 2010 at 06:09:30PM +0200, Avi Kivity escreveu: Doesn't perf already has a dependency on naming conventions for finding debug information? It looks

Re: [RFC] vhost-blk implementation

2010-03-24 Thread Christoph Hellwig
Inspired by vhost-net implementation, I did initial prototype of vhost-blk to see if it provides any benefits over QEMU virtio-blk. I haven't handled all the error cases, fixed naming conventions etc., but the implementation is stable to play with. I tried not to deviate from vhost-net

Re: [RFC] vhost-blk implementation

2010-03-24 Thread Christoph Hellwig
On Tue, Mar 23, 2010 at 12:03:14PM +0200, Avi Kivity wrote: I also think it should be done at the bio layer. File I/O is going to be slower, if we do vhost-blk we should concentrate on maximum performance. The block layer also exposes more functionality we can use (asynchronous

Re: [RFC] vhost-blk implementation

2010-03-24 Thread Badari Pulavarty
Christoph Hellwig wrote: Inspired by vhost-net implementation, I did initial prototype of vhost-blk to see if it provides any benefits over QEMU virtio-blk. I haven't handled all the error cases, fixed naming conventions etc., but the implementation is stable to play with. I tried not to

Re: [RFC] vhost-blk implementation

2010-03-24 Thread Badari Pulavarty
Christoph Hellwig wrote: Inspired by vhost-net implementation, I did initial prototype of vhost-blk to see if it provides any benefits over QEMU virtio-blk. I haven't handled all the error cases, fixed naming conventions etc., but the implementation is stable to play with. I tried not to

Re: [Qemu-devel] [PATCH] qemu: jaso-parser: Output the content of invalid keyword

2010-03-24 Thread Luiz Capitulino
On Wed, 24 Mar 2010 17:00:14 +0100 Markus Armbruster arm...@redhat.com wrote: Amos Kong ak...@redhat.com writes: When input some invialid word 'unknowcmd' through QMP port, qemu outputs this error message: parse error: invalid keyword `%s' This patch makes qemu output the content of

[PATCH 03/21] KVM: PPC: Make DSISR 32 bits wide

2010-03-24 Thread Alexander Graf
DSISR is only defined as 32 bits wide. So let's reflect that in the structs too. Signed-off-by: Alexander Graf ag...@suse.de --- arch/powerpc/include/asm/kvm_book3s.h |2 +- arch/powerpc/include/asm/kvm_host.h |2 +- arch/powerpc/kvm/book3s_64_interrupts.S |2 +- 3 files

[PATCH 05/21] KVM: PPC: Split instruction reading out

2010-03-24 Thread Alexander Graf
The current check_ext function reads the instruction and then does the checking. Let's split the reading out so we can reuse it for different functions. Signed-off-by: Alexander Graf ag...@suse.de --- arch/powerpc/kvm/book3s.c | 24 1 files changed, 16 insertions(+), 8

[PATCH 15/21] KVM: PPC: Make build work without CONFIG_VSX/ALTIVEC

2010-03-24 Thread Alexander Graf
The FPU/Altivec/VSX enablement also brought access to some structure elements that are only defined when the respective config options are enabled. Unfortuately I forgot to check for the config options at some places, so let's do that now. Unbreaks the build when CONFIG_VSX is not set.

[PATCH 16/21] KVM: PPC: Fix dcbz emulation

2010-03-24 Thread Alexander Graf
On most systems we need to emulate dcbz when running 32 bit guests. So far we've been rather slack, not giving correct DSISR values to the guest. This patch makes the emulation more accurate, introducing a difference between page not mapped and write protection fault. While at it, it also speeds

[PATCH 20/21] KVM: PPC: Make bools bitfields

2010-03-24 Thread Alexander Graf
Bool defaults to at least byte width. We usually only want to waste a single bit on this. So let's move all the bool values to bitfields, potentially saving memory. Signed-off-by: Alexander Graf ag...@suse.de --- arch/powerpc/include/asm/kvm_book3s.h | 28 ++--

[PATCH 18/21] KVM: PPC: Add check if pte was mapped secondary

2010-03-24 Thread Alexander Graf
Some HTAB providers (namely the PS3) ignore the SECONDARY flag. They just put an entry in the htab as secondary when they see fit. So we need to check the return value of htab_insert to remember the correct slot id so we can actually invalidate the entry again. Fixes KVM on the PS3.

[PATCH 21/21] KVM: PPC: Disable MSR_FEx for Cell hosts

2010-03-24 Thread Alexander Graf
Cell can't handle MSR_FE0 and MSR_FE1 too well. It gets dog slow. So let's just override the guest whenever we see one of the two and mask them out. See commit ddf5f75a16b3e7460ffee881795aa168dffcd0cf for reference. Signed-off-by: Alexander Graf ag...@suse.de --- arch/powerpc/kvm/book3s.c |4

[PATCH 17/21] KVM: PPC: Add emulation for dcba

2010-03-24 Thread Alexander Graf
Mac OS X uses the dcba instruction. According to the specification it doesn't guarantee any functionality, so let's just emulate it as nop. Signed-off-by: Alexander Graf ag...@suse.de --- arch/powerpc/kvm/book3s_64_emulate.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff

[PATCH 14/21] KVM: PPC: Add OSI hypercall interface

2010-03-24 Thread Alexander Graf
MOL uses its own hypercall interface to call back into userspace when the guest wants to do something. So let's implement that as an exit reason, specify it with a CAP and only really use it when userspace wants us to. The only user of it so far is MOL. Signed-off-by: Alexander Graf

[PATCH 13/21] KVM: Add support for enabling capabilities per-vcpu

2010-03-24 Thread Alexander Graf
Some times we don't want all capabilities to be available to all our vcpus. One example for that is the OSI interface, implemented in the next patch. In order to have a generic mechanism in how to enable capabilities individually, this patch introduces a new ioctl that can be used for this

[PATCH 09/21] KVM: PPC: Implement BAT reads

2010-03-24 Thread Alexander Graf
BATs can't only be written to, you can also read them out! So let's implement emulation for reading BAT values again. While at it, I also made BAT setting flush the segment cache, so we're absolutely sure there's no MMU state left when writing BATs. Signed-off-by: Alexander Graf ag...@suse.de

[PATCH 10/21] KVM: PPC: Make XER load 32 bit

2010-03-24 Thread Alexander Graf
We have a 32 bit value in the PACA to store XER in. We also do an stw when storing XER in there. But then we load it with ld, completely screwing it up on every entry. Welcome to the Big Endian world. Signed-off-by: Alexander Graf ag...@suse.de --- arch/powerpc/kvm/book3s_64_slb.S |2 +- 1

[PATCH 04/21] KVM: PPC: Book3S_32 guest MMU fixes

2010-03-24 Thread Alexander Graf
This patch makes the VSID of mapped pages always reflecting all special cases we have, like split mode. It also changes the tlbie mask to 0x0000 according to the spec. The mask we used before was incorrect. Signed-off-by: Alexander Graf ag...@suse.de ---

[PATCH 19/21] KVM: PPC: Use ULL for big numbers

2010-03-24 Thread Alexander Graf
Some constants were bigger than ints. Let's mark them as such so we don't accidently truncate them. Signed-off-by: Alexander Graf ag...@suse.de --- arch/powerpc/include/asm/kvm_book3s.h | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 07/21] KVM: PPC: Load VCPU for register fetching

2010-03-24 Thread Alexander Graf
When trying to read or store vcpu register data, we should also make sure the vcpu is actually loaded, so we're 100% sure we get the correct values. Signed-off-by: Alexander Graf ag...@suse.de --- arch/powerpc/kvm/book3s.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff

[PATCH 12/21] KVM: PPC: Implement alignment interrupt

2010-03-24 Thread Alexander Graf
Mac OS X has some applications - namely the Finder - that require alignment interrupts to work properly. So we need to implement them. But the spec for 970 and 750 also looks different. While 750 requires the DSISR and DAR fields to reflect some instruction bits (DSISR) and the fault address

[PATCH 00/21] KVM: PPC: MOL bringup patches v3

2010-03-24 Thread Alexander Graf
Mac-on-Linux has always lacked PPC64 host support. This is going to change now! This patchset contains minor patches to enable MOL, but is mostly about bug fixes that came out of running Mac OS X. With this set and the current svn version of MOL I have 10.4.11 running as a guest on a 970MP as

[PATCH 02/21] KVM: PPC: Allow userspace to unset the IRQ line

2010-03-24 Thread Alexander Graf
Userspace can tell us that it wants to trigger an interrupt. But so far it can't tell us that it wants to stop triggering one. So let's interpret the parameter to the ioctl that we have anyways to tell us if we want to raise or lower the interrupt line. Signed-off-by: Alexander Graf

[PATCH 01/21] KVM: PPC: Ensure split mode works

2010-03-24 Thread Alexander Graf
On PowerPC we can go into MMU Split Mode. That means that either data relocation is on but instruction relocation is off or vice versa. That mode didn't work properly, as we weren't always flushing entries when going into a new split mode, potentially mapping different code or data that we're

[PATCH 08/21] KVM: PPC: Implement mfsr emulation

2010-03-24 Thread Alexander Graf
We emulate the mfsrin instruction already, that passes the SR number in a register value. But we lacked support for mfsr that encoded the SR number in the opcode. So let's implement it. Signed-off-by: Alexander Graf ag...@suse.de --- arch/powerpc/kvm/book3s_64_emulate.c | 13 + 1

[PATCH 11/21] KVM: PPC: Implement emulation for lbzux and lhax

2010-03-24 Thread Alexander Graf
We get MMIOs with the weirdest instructions. But every time we do, we need to improve our emulator to implement them. So let's do that - this time it's lbzux and lhax's round. Signed-off-by: Alexander Graf ag...@suse.de --- arch/powerpc/kvm/emulate.c | 20 1 files

[PATCH 06/21] KVM: PPC: Don't reload FPU with invalid values

2010-03-24 Thread Alexander Graf
When the guest activates the FPU, we load it up. That's fine when it wasn't activated before on the host, but if it was we end up reloading FPU values from last time the FPU was deactivated on the host without writing the proper values back to the vcpu struct. This patch checks if the FPU is

[patch 8/8] test: long rmap chains

2010-03-24 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: qemu-kvm/kvm/user/config-x86-common.mak === --- qemu-kvm.orig/kvm/user/config-x86-common.mak +++ qemu-kvm/kvm/user/config-x86-common.mak @@ -45,6 +45,9 @@

[patch 4/8] test: export vm helpers

2010-03-24 Thread Marcelo Tosatti
To be used by next patches. Also make install_pte take an argument indicating physical location of pagetable. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: qemu-kvm/kvm/user/test/x86/vm.c === ---

[patch 7/8] test: bump max vcpus to 64

2010-03-24 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: qemu-kvm/kvm/user/test/x86/cstart64.S === --- qemu-kvm.orig/kvm/user/test/x86/cstart64.S +++ qemu-kvm/kvm/user/test/x86/cstart64.S @@ -6,7 +6,7 @@ boot_idt = 0 ipi_vector =

[patch 6/8] test: parallel faults vs slot deletion

2010-03-24 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Index: qemu-kvm/kvm/user/config-x86-common.mak === --- qemu-kvm.orig/kvm/user/config-x86-common.mak +++ qemu-kvm/kvm/user/config-x86-common.mak @@ -42,6 +42,9 @@

  1   2   >