Re: [RFC][PATCH 9/9] make kvm mmu shrinker more aggressive

2010-06-20 Thread Avi Kivity
On 06/18/2010 06:49 PM, Dave Hansen wrote: On Wed, 2010-06-16 at 08:25 -0700, Dave Hansen wrote: On Wed, 2010-06-16 at 12:24 +0300, Avi Kivity wrote: On 06/15/2010 04:55 PM, Dave Hansen wrote: In a previous patch, we removed the 'nr_to_scan' tracking. It was not being used

Re: [PATCH] KVM: PPC: fix uninitialized variable warning

2010-06-20 Thread Avi Kivity
On 06/19/2010 11:52 AM, Asias He wrote: Fixes: arch/powerpc/kvm/booke.c: In function 'kvmppc_core_deliver_interrupts': arch/powerpc/kvm/booke.c:147: warning: 'msr_mask' may be used uninitialized in this function Applied, thanks. -- error compiling committee.c: too many arguments to

Re: Regarding NAT configuration with KVM

2010-06-20 Thread Avi Kivity
On 06/18/2010 04:33 PM, Rajiv Rajaian wrote: [r...@kvmcluster ~]# ping 144.68.100.1 PING 144.68.100.1 (144.68.100.1) 56(84) bytes of data. 64 bytes from 144.68.100.1: icmp_seq=1 ttl=64 time=2.59 ms Heres the IP configuration Details: Host machine 10.2.0.20 (Kvmcluster) Virtual machine :

Re: [PATCH] KVM: x86 emulator: fix group3 instruction decoding

2010-06-20 Thread Avi Kivity
On 06/18/2010 03:51 AM, Wei Yongjun wrote: On 06/17/2010 12:33 PM, Wei Yongjun wrote: Group 3 instruction with ModRM reg field as 001 is defined as test instruction under AMD arch, and emulate_grp3() is ready for emulate it, so fix the decoding. Strange but true. Did you

Re: [PATCH] test: add test for pusha and popa instructions

2010-06-20 Thread Avi Kivity
On 06/15/2010 05:10 AM, Wei Yongjun wrote: This patch add test for pusha and popa instructions. Did you test the test? These tests require 'emulate_invalid_guest_state=1' and to run on Intel to actually test anything. You can check with ftrace whether kvm actually emulated pusha/popa. --

problems with kvm-kmod

2010-06-20 Thread Gleb Natapov
commit f69f5bf2cba0e broke kvm-kmod with non-split build. The problem is that $kernelsourcedir is empty so KERNELSOURCEDIR=$(cd $kernelsourcedir; pwd) sets KERNELSOURCEDIR to be user's home dir. -- Gleb. -- To unsubscribe from this list: send the line unsubscribe kvm in

Re: [RFC PATCH v7 01/19] Add a new structure for skb buffer from external.

2010-06-20 Thread Herbert Xu
On Sun, Jun 20, 2010 at 01:06:32PM +0300, Michael S. Tsirkin wrote: Changing the guest virtio to match the backend is a problem, this breaks migration etc. As long as it's done in a backwards compatible way it should be fine. It's just like migrating from a backend that supports TSO to one

Re: [RFC PATCH v7 01/19] Add a new structure for skb buffer from external.

2010-06-20 Thread Michael S. Tsirkin
On Sun, Jun 20, 2010 at 08:32:35PM +1000, Herbert Xu wrote: On Sun, Jun 20, 2010 at 01:06:32PM +0300, Michael S. Tsirkin wrote: Changing the guest virtio to match the backend is a problem, this breaks migration etc. As long as it's done in a backwards compatible way it should be fine.

Re: [RFC PATCH v7 01/19] Add a new structure for skb buffer from external.

2010-06-20 Thread Herbert Xu
On Sun, Jun 20, 2010 at 01:39:09PM +0300, Michael S. Tsirkin wrote: It's just like migrating from a backend that supports TSO to one that doesn't. Exactly. We don't support such migration. Well that's something that has to be addressed in the virtio_net. Cheers, -- Visit Openswan at

Re: [RFC PATCH v7 01/19] Add a new structure for skb buffer from external.

2010-06-20 Thread Michael S. Tsirkin
On Sun, Jun 20, 2010 at 09:02:54PM +1000, Herbert Xu wrote: On Sun, Jun 20, 2010 at 01:39:09PM +0300, Michael S. Tsirkin wrote: It's just like migrating from a backend that supports TSO to one that doesn't. Exactly. We don't support such migration. Well that's something that has

Re: [RFC PATCH v7 01/19] Add a new structure for skb buffer from external.

2010-06-20 Thread Herbert Xu
On Sun, Jun 20, 2010 at 02:11:24PM +0300, Michael S. Tsirkin wrote: Rather than modifying all guests, it seems much easier not to assume specific buffer layout in host. Copying network header around seems a small cost. Well sure we can debate the specifics of this implementation detail.

Re: [RFC PATCH v7 01/19] Add a new structure for skb buffer from external.

2010-06-20 Thread Herbert Xu
On Sun, Jun 20, 2010 at 02:47:19PM +0300, Michael S. Tsirkin wrote: Let's do this then. So far the virtio spec avoided making layout assumptions, leaving guests lay out data as they see fit. Isn't it possible to keep supporting this with zero copy for hardware that can issue DMA at arbitrary

Re: problems with kvm-kmod

2010-06-20 Thread Jan Kiszka
Gleb Natapov wrote: commit f69f5bf2cba0e broke kvm-kmod with non-split build. The problem is that $kernelsourcedir is empty so KERNELSOURCEDIR=$(cd $kernelsourcedir; pwd) sets KERNELSOURCEDIR to be user's home dir. Indeed, should be fixed now. Thanks, Jan signature.asc Description:

Re: [RFC PATCH v7 01/19] Add a new structure for skb buffer from external.

2010-06-20 Thread Michael S. Tsirkin
On Sun, Jun 20, 2010 at 09:59:26PM +1000, Herbert Xu wrote: On Sun, Jun 20, 2010 at 02:47:19PM +0300, Michael S. Tsirkin wrote: Let's do this then. So far the virtio spec avoided making layout assumptions, leaving guests lay out data as they see fit. Isn't it possible to keep supporting

[PATCH 1/2] KVM: Fix xsave and xcr save/restore memory leak

2010-06-20 Thread Avi Kivity
We allocate temporary kernel buffers for these structures, but never free them. Signed-off-by: Avi Kivity a...@redhat.com --- arch/x86/kvm/x86.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index d3d008e..d513e57

[PATCH 2/2] KVM: Consolidate load/save temporary buffer allocation and freeing

2010-06-20 Thread Avi Kivity
Instead of three temporary variables and three free calls, have one temporary variable (with four names) and one free call. Signed-off-by: Avi Kivity a...@redhat.com --- arch/x86/kvm/x86.c | 64 ++- 1 files changed, 33 insertions(+), 31

[PATCH 0/2] Fix xsave/xcr save/restore memory leak

2010-06-20 Thread Avi Kivity
There's a small leak in xsave/xcr save/restore that rapidly drains all memory during Windows XP install without FlexPriority, since that triggers qemu register reload frequently. Avi Kivity (2): KVM: Fix xsave and xcr save/restore memory leak KVM: Consolidate load/save temporary buffer

Re: [RFC PATCH v7 01/19] Add a new structure for skb buffer from external.

2010-06-20 Thread Ben Hutchings
On Sun, 2010-06-20 at 21:59 +1000, Herbert Xu wrote: On Sun, Jun 20, 2010 at 02:47:19PM +0300, Michael S. Tsirkin wrote: Let's do this then. So far the virtio spec avoided making layout assumptions, leaving guests lay out data as they see fit. Isn't it possible to keep supporting this

[PATCH 0/4] Preparation for PIC-APIC rewiring

2010-06-20 Thread Avi Kivity
These four patches were part of an optimization patchset I've been neglecting, but are equally useful as preparation for fixing the PIC-APIC wiring issues. Avi Kivity (4): KVM: i8259: reduce excessive abstraction for pic_irq_request() KVM: i8259: simplify pic_irq_request() calling sequence

[PATCH 4/4] KVM: Reduce atomic operations on vcpu-requests

2010-06-20 Thread Avi Kivity
Usually the vcpu-requests bitmap is sparse, so a test_and_clear_bit() for each request generates a large number of unneeded atomics if a bit is set. Replace with a separate test/clear sequence. This is safe since there is no clear_bit() outside the vcpu thread. Signed-off-by: Avi Kivity

[PATCH 2/4] KVM: i8259: simplify pic_irq_request() calling sequence

2010-06-20 Thread Avi Kivity
Signed-off-by: Avi Kivity a...@redhat.com --- arch/x86/kvm/i8259.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/arch/x86/kvm/i8259.c b/arch/x86/kvm/i8259.c index caf6e1b..bc10f0b 100644 --- a/arch/x86/kvm/i8259.c +++ b/arch/x86/kvm/i8259.c @@ -176,10 +176,7 @@

[PATCH 1/4] KVM: i8259: reduce excessive abstraction for pic_irq_request()

2010-06-20 Thread Avi Kivity
Part of the i8259 code pretends it isn't part of kvm, but we know better. Reduce excessive abstraction, eliminating callbacks and void pointers. Signed-off-by: Avi Kivity a...@redhat.com --- arch/x86/kvm/i8259.c | 17 +++-- arch/x86/kvm/irq.h |4 2 files changed, 7

[PATCH 3/4] KVM: Add mini-API for vcpu-requests

2010-06-20 Thread Avi Kivity
Makes it a little more readable and hackable. Signed-off-by: Avi Kivity a...@redhat.com --- arch/x86/kvm/lapic.c |2 +- arch/x86/kvm/mmu.c |6 +++--- arch/x86/kvm/svm.c |2 +- arch/x86/kvm/timer.c |2 +- arch/x86/kvm/vmx.c |2 +- arch/x86/kvm/x86.c

Re: [PATCH 0/2] Fix xsave/xcr save/restore memory leak

2010-06-20 Thread Sheng Yang
On Sunday 20 June 2010 21:14:11 Avi Kivity wrote: There's a small leak in xsave/xcr save/restore that rapidly drains all memory during Windows XP install without FlexPriority, since that triggers qemu register reload frequently. Oops... Would be more careful next time... -- regards Yang,

Re: [PATCH 2/2] Remove virtio_blk VBID ioctl

2010-06-20 Thread Rusty Russell
On Sat, 19 Jun 2010 04:08:03 am Ryan Harper wrote: With the availablility of a sysfs device attribute for examining disk serial numbers the ioctl is no longer needed. The user-space changes for this aren't upstream yet so we don't have any users to worry about. If John Cooper acks this, I'll

Re: [PATCH 1/2] Add 'serial' attribute to virtio-blk devices

2010-06-20 Thread Rusty Russell
On Sat, 19 Jun 2010 04:08:02 am Ryan Harper wrote: Create a new attribute for virtio-blk devices that will fetch the serial number of the block device. This attribute can be used by udev to create disk/by-id symlinks for devices that don't have a UUID (filesystem) associated with them.

Re: [PATCH 2/2] Remove virtio_blk VBID ioctl

2010-06-20 Thread Ryan Harper
* Rusty Russell ru...@rustcorp.com.au [2010-06-20 20:31]: On Sat, 19 Jun 2010 04:08:03 am Ryan Harper wrote: With the availablility of a sysfs device attribute for examining disk serial numbers the ioctl is no longer needed. The user-space changes for this aren't upstream yet so we

Re: [PATCH] test: add test for pusha and popa instructions

2010-06-20 Thread Wei Yongjun
On 06/15/2010 05:10 AM, Wei Yongjun wrote: This patch add test for pusha and popa instructions. Did you test the test? These tests require 'emulate_invalid_guest_state=1' and to run on Intel to actually test anything. You can check with ftrace whether kvm actually emulated

[PATCH] Update .gitignore

2010-06-20 Thread Hidetoshi Seto
I think some people have noticed that: $ ./configure $ make $ git status # On branch master # Untracked files: # (use git add file... to include in what will be committed) # # QMP/qmp-commands.txt # libdis-user/ # libdis/ # pc-bios/optionrom/vapic.bin nothing

Re: [PATCH 2/2] Remove virtio_blk VBID ioctl

2010-06-20 Thread john cooper
Rusty Russell wrote: On Sat, 19 Jun 2010 04:08:03 am Ryan Harper wrote: With the availablility of a sysfs device attribute for examining disk serial numbers the ioctl is no longer needed. The user-space changes for this aren't upstream yet so we don't have any users to worry about. If