Re: [PATCH] kvm tool: add QCOW verions 1 read/write support

2011-04-15 Thread Pekka Enberg
Hi Christoph, On Wed, Apr 13, 2011 at 08:01:58PM +0100, Prasad Joshi wrote: The patch only implements the basic read write support for QCOW version 1 images. Many of the QCOW features are not implmented, for example On Fri, Apr 15, 2011 at 6:24 AM, Christoph Hellwig h...@infradead.org wrote:

Why QCOW1? (was: [PATCH v2] kvm tool: add QCOW verions 1 read/write support)

2011-04-15 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 13.04.2011 21:26, schrieb Prasad Joshi: The patch only implements the basic read write support for QCOW version 1 images. Many of the QCOW features are not implmented, for example - image creation - snapshot - copy-on-write - encryption Yay,

Re: Why QCOW1? (was: [PATCH v2] kvm tool: add QCOW verions 1 read/write support)

2011-04-15 Thread Pekka Enberg
On Fri, Apr 15, 2011 at 9:41 AM, Markus Armbruster arm...@redhat.com wrote: What hasn't been discussed much is the other half of Kevin's remark: why QCOW1? QCOW1 was simpler to implement as the first non-raw image format. Pekka -- To unsubscribe from this list: send the

Re: [PATCH] kvm tool: add QCOW verions 1 read/write support

2011-04-15 Thread Kevin Wolf
Am 15.04.2011 08:24, schrieb Pekka Enberg: Hi Christoph, On Wed, Apr 13, 2011 at 08:01:58PM +0100, Prasad Joshi wrote: The patch only implements the basic read write support for QCOW version 1 images. Many of the QCOW features are not implmented, for example On Fri, Apr 15, 2011 at 6:24

Re: Why QCOW1? (was: [PATCH v2] kvm tool: add QCOW verions 1 read/write support)

2011-04-15 Thread Stefan Hajnoczi
On Fri, Apr 15, 2011 at 7:45 AM, Pekka Enberg penb...@kernel.org wrote: On Fri, Apr 15, 2011 at 9:41 AM, Markus Armbruster arm...@redhat.com wrote: What hasn't been discussed much is the other half of Kevin's remark: why QCOW1? QCOW1 was simpler to implement as the first non-raw image format.

[PATCH 3/3 v2] kvm tools: Setup bridged network by a script

2011-04-15 Thread Amos Kong
Use original hardcode network by default. #./kvm run ... -n virtio --tapscript=./util/kvm-ifup-vbr0 # brctl show bridge name bridge id STP enabled interfaces vbr08000.e272c7c391f4 no tap0 guest)# ifconfig eth6 eth6 Link encap:Ethernet

Re: [RFT/PATCH v2] kvm tools: Add read-only support for block devices

2011-04-15 Thread Ingo Molnar
* Pekka Enberg penb...@kernel.org wrote: Add support for booting guests to host block devices in read-only mode. Cc: Asias He asias.he...@gmail.com Cc: Cyrill Gorcunov gorcu...@gmail.com Cc: Prasad Joshi prasadjoshi...@gmail.com Cc: Sasha Levin levinsasha...@gmail.com Cc: Ingo Molnar

Re: Why QCOW1? (was: [PATCH v2] kvm tool: add QCOW verions 1 read/write support)

2011-04-15 Thread Pekka Enberg
On Fri, Apr 15, 2011 at 1:14 PM, Stefan Hajnoczi stefa...@gmail.com wrote: Why even use a non-raw image format?  The current implementation only does sparse files, but POSIX sparse raw files gives you the same feature. Because people have existing images they want to boot to? -- To unsubscribe

Re: Why QCOW1? (was: [PATCH v2] kvm tool: add QCOW verions 1 read/write support)

2011-04-15 Thread Stefan Hajnoczi
On Fri, Apr 15, 2011 at 12:17 PM, Pekka Enberg penb...@kernel.org wrote: On Fri, Apr 15, 2011 at 1:14 PM, Stefan Hajnoczi stefa...@gmail.com wrote: Why even use a non-raw image format?  The current implementation only does sparse files, but POSIX sparse raw files gives you the same feature.

Re: Why QCOW1? (was: [PATCH v2] kvm tool: add QCOW verions 1 read/write support)

2011-04-15 Thread Pekka Enberg
On Fri, Apr 15, 2011 at 3:05 PM, Stefan Hajnoczi stefa...@gmail.com wrote: People don't have existing QCOW1 images they want to boot from :). They have vmdk, vhd, vdi, or qcow2.  You can use qemu-img to convert them to raw.  You can use qemu-nbd if you are desperate to boot from or inspect

Re: Why QCOW1?

2011-04-15 Thread Anthony Liguori
On 04/15/2011 06:17 AM, Pekka Enberg wrote: On Fri, Apr 15, 2011 at 1:14 PM, Stefan Hajnoczistefa...@gmail.com wrote: Why even use a non-raw image format? The current implementation only does sparse files, but POSIX sparse raw files gives you the same feature. Because people have existing

Re: Why QCOW1?

2011-04-15 Thread Kevin Wolf
Am 15.04.2011 14:05, schrieb Stefan Hajnoczi: On Fri, Apr 15, 2011 at 12:17 PM, Pekka Enberg penb...@kernel.org wrote: On Fri, Apr 15, 2011 at 1:14 PM, Stefan Hajnoczi stefa...@gmail.com wrote: Why even use a non-raw image format? The current implementation only does sparse files, but POSIX

[PATCH 1/4] kvm tool: use correct function names

2011-04-15 Thread Prasad Joshi
The function name sect_to_l1_offset() is changed to get_l1_index() as it returns the l1 table index rather than offset. Also change - sect_to_l2_offset to get_l2_index - sect_to_cluster_offset to get_cluster_offset Signed-off-by: Prasad Joshi prasadjoshi...@gmail.com --- tools/kvm/qcow.c

[PATCH 3/4] kvm tool: deallocate the cached l1_table in qcow1_disk_close() and in error path of qcow1_probe()

2011-04-15 Thread Prasad Joshi
Signed-off-by: Prasad Joshi prasadjoshi...@gmail.com --- tools/kvm/qcow.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/tools/kvm/qcow.c b/tools/kvm/qcow.c index 243bfa8..9b9af86 100644 --- a/tools/kvm/qcow.c +++ b/tools/kvm/qcow.c @@ -115,6 +115,7 @@ static void

[PATCH 4/4] kvm tool: check the cluster boundary in the qcow read code.

2011-04-15 Thread Prasad Joshi
Add a new function qcow1_read_cluster() to read a qcow cluster size data at a time. The function qcow1_read_sector() is modified to use the function qcow1_read_cluster(). Signed-off-by: Prasad Joshi prasadjoshi...@gmail.com --- tools/kvm/qcow.c | 123

[PATCH 2/4] kvm tool: avoid byte-order conversion during each read operation

2011-04-15 Thread Prasad Joshi
Signed-off-by: Prasad Joshi prasadjoshi...@gmail.com --- tools/kvm/qcow.c | 17 - 1 files changed, 12 insertions(+), 5 deletions(-) diff --git a/tools/kvm/qcow.c b/tools/kvm/qcow.c index 219fd6b..243bfa8 100644 --- a/tools/kvm/qcow.c +++ b/tools/kvm/qcow.c @@ -58,7 +58,7 @@

[PATCH] kvm tools: Fix virtio console input problem

2011-04-15 Thread Asias He
Signed-off-by: Asias He asias.he...@gmail.com --- tools/kvm/term.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/kvm/term.c b/tools/kvm/term.c index 2245c8d..2bd038d 100644 --- a/tools/kvm/term.c +++ b/tools/kvm/term.c @@ -71,9 +71,9 @@ int term_getc_iov(int

Re: [Qemu-devel] [PATCH 2/2 V7] qemu,qmp: add inject-nmi qmp command

2011-04-15 Thread Blue Swirl
On Thu, Apr 14, 2011 at 12:55 PM, Daniel P. Berrange berra...@redhat.com wrote: On Wed, Apr 13, 2011 at 10:56:21PM +0300, Blue Swirl wrote: On Wed, Apr 13, 2011 at 4:08 PM, Luiz Capitulino lcapitul...@redhat.com wrote: On Tue, 12 Apr 2011 21:31:18 +0300 Blue Swirl blauwir...@gmail.com

[PATCH] kvm tool: QCOW version 1 write support.

2011-04-15 Thread Prasad Joshi
The code is based on the following QCOW 1 image format specification: http://people.gnome.org/~markmc/qcow-image-format-version-1.html Signed-off-by: Prasad Joshi prasadjoshi...@gmail.com --- tools/kvm/qcow.c | 148 +- 1 files changed, 147

Re: [PATCH] kvm tools: Fix virtio console input problem

2011-04-15 Thread Ingo Molnar
* Asias He asias.he...@gmail.com wrote: Signed-off-by: Asias He asias.he...@gmail.com --- tools/kvm/term.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Mind explaining in the changelog what input problem this is about? Thanks, Ingo -- To unsubscribe from this

[PATCH] kvm tool: Remove the __stringify* defination from the util.h

2011-04-15 Thread Prasad Joshi
Include the Linux kernel header file linux/stringify.h file instead of redefining the __stringify* macros Signed-off-by: Prasad Joshi prasadjoshi...@gmail.com --- tools/kvm/include/kvm/util.h |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 0/2] Store and load PCI device saved state across function resets

2011-04-15 Thread Alex Williamson
Bug https://bugs.launchpad.net/qemu/+bug/754591 is caused because the KVM module attempts to do a pci_save_state() before assigning the device to a VM, expecting that the saved state will remain valid until we release the device. This is in conflict with our need to reset devices using PCI sysfs

[PATCH 1/2] PCI: Add interfaces to store and load the device saved state

2011-04-15 Thread Alex Williamson
For KVM device assignment, we'd like to save off the state of a device prior to passing it to the guest and restore it later. We also want to allow pci_reset_funciton() to be called while the device is owned by the guest. This however overwrites and invalidates the struct pci_dev buffers, so we

[PATCH 2/2] KVM: Use pci_store/load_saved_state() around VM device usage

2011-04-15 Thread Alex Williamson
Store the device saved state so that we can reload the device back to the original state when it's unassigned. This has the benefit that the state survives across pci_reset_function() calls via the PCI sysfs reset interface while the VM is using the device. Signed-off-by: Alex Williamson

Re: [PATCH 2/2] KVM: Use pci_store/load_saved_state() around VM device usage

2011-04-15 Thread Jan Kiszka
On 2011-04-15 21:54, Alex Williamson wrote: Store the device saved state so that we can reload the device back to the original state when it's unassigned. This has the benefit that the state survives across pci_reset_function() calls via the PCI sysfs reset interface while the VM is using the

Re: [PATCH 2/2] KVM: Use pci_store/load_saved_state() around VM device usage

2011-04-15 Thread Alex Williamson
On Fri, 2011-04-15 at 22:03 +0200, Jan Kiszka wrote: On 2011-04-15 21:54, Alex Williamson wrote: Store the device saved state so that we can reload the device back to the original state when it's unassigned. This has the benefit that the state survives across pci_reset_function() calls via

Re: [PATCH 2/2] KVM: Use pci_store/load_saved_state() around VM device usage

2011-04-15 Thread Jan Kiszka
On 2011-04-15 22:13, Alex Williamson wrote: On Fri, 2011-04-15 at 22:03 +0200, Jan Kiszka wrote: On 2011-04-15 21:54, Alex Williamson wrote: Store the device saved state so that we can reload the device back to the original state when it's unassigned. This has the benefit that the state

Re: [PATCH] kvm tools: Fix virtio console input problem

2011-04-15 Thread Asias He
On 04/16/2011 02:23 AM, Ingo Molnar wrote: * Asias He asias.he...@gmail.com wrote: Signed-off-by: Asias He asias.he...@gmail.com --- tools/kvm/term.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Mind explaining in the changelog what input problem this is about? Sure.