Re: [RFC PATCH] kvm-unit-tests : Basic architecture of VMX nested test case

2013-07-24 Thread Arthur Chunqi Li
Hi Gleb and Paolo, What about organizing vmx_run() as follows: static int vmx_run() { u32 eax; bool ret; vmcs_write(HOST_RSP, get_rsp()); ret = vmlaunch(); while (!ret) { asm volatile( vmx_return:\n\t SAVE_GPR ); eax =

Re: [RFC PATCH] kvm-unit-tests : Basic architecture of VMX nested test case

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 08:11, Arthur Chunqi Li ha scritto: static int vmx_run() { u32 eax; bool ret; vmcs_write(HOST_RSP, get_rsp()); ret = vmlaunch(); The compiler can still change rsp between here... while (!ret) { asm volatile( vmx_return:\n\t ...

Re: [RFC PATCH] kvm-unit-tests : Basic architecture of VMX nested test case

2013-07-24 Thread Arthur Chunqi Li
On Wed, Jul 24, 2013 at 2:40 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 24/07/2013 08:11, Arthur Chunqi Li ha scritto: static int vmx_run() { u32 eax; bool ret; vmcs_write(HOST_RSP, get_rsp()); ret = vmlaunch(); The compiler can still change rsp between here...

Re: [RFC PATCH] kvm-unit-tests : Basic architecture of VMX nested test case

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 08:46, Arthur Chunqi Li ha scritto: On Wed, Jul 24, 2013 at 2:40 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 24/07/2013 08:11, Arthur Chunqi Li ha scritto: static int vmx_run() { u32 eax; bool ret; vmcs_write(HOST_RSP, get_rsp()); ret = vmlaunch(); The

Re: [PATCH 4/4] x86: properly handle kvm emulation of hyperv

2013-07-24 Thread Jason Wang
On 07/24/2013 12:48 PM, H. Peter Anvin wrote: On 07/23/2013 09:37 PM, Jason Wang wrote: On 07/23/2013 10:48 PM, H. Peter Anvin wrote: On 07/23/2013 06:55 AM, KY Srinivasan wrote: This strategy of hypervisor detection based on some detection order IMHO is not a robust detection strategy. The

Re: [PATCH 4/4] x86: properly handle kvm emulation of hyperv

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 08:54, Jason Wang ha scritto: On 07/24/2013 12:48 PM, H. Peter Anvin wrote: On 07/23/2013 09:37 PM, Jason Wang wrote: On 07/23/2013 10:48 PM, H. Peter Anvin wrote: On 07/23/2013 06:55 AM, KY Srinivasan wrote: This strategy of hypervisor detection based on some detection order

Re: VU#976534 - How to submit security bugs?

2013-07-24 Thread Stefan Hajnoczi
On Mon, Jul 22, 2013 at 02:49:50PM -0400, CERT(R) Coordination Center wrote: My name is Adam Rauf and I work for the CERT Coordination Center. We have a report that may affect KVM/QEMU. How can we securely send it over to you? Thanks so much! Paolo, Gleb, Anthony: Is this already

Re: Cannot load kvm_amd module - (says disabled by bios)

2013-07-24 Thread Massimiliano Adamo
On Tue, 2013-07-23 at 15:31 -0600, Alex Williamson wrote: On Tue, 2013-07-23 at 23:11 +0200, Massimiliano Adamo wrote: All, this is a bug with KVM, impacting (at least) all mainstream kernels that I tried so far: 3.2, 3.3, 3.4, 3.5, 3.8, 3.10 and 3.11 This is the link of the

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Alexander Graf
On 24.07.2013, at 04:26, “tiejun.chen” wrote: On 07/18/2013 06:27 PM, Alexander Graf wrote: On 18.07.2013, at 12:19, “tiejun.chen” wrote: On 07/18/2013 06:12 PM, Alexander Graf wrote: On 18.07.2013, at 12:08, “tiejun.chen” wrote: On 07/18/2013 05:48 PM, Alexander Graf wrote: On

Re: [RFC PATCH] kvm-unit-tests : Basic architecture of VMX nested test case

2013-07-24 Thread Arthur Chunqi Li
So as what Gleb said, what about the following codes: static int vmx_run2() { u32 eax; bool ret; asm volatile( mov %%rsp, %%rsi\n\t mov %2, %%edi\n\t call vmcs_write\n\t vmlaunch\n\t setbe %0\n\t jne 4f\n\t vmx_return:\n\t

Re: [RFC PATCH] kvm-unit-tests : Basic architecture of VMX nested test case

2013-07-24 Thread Jan Kiszka
On 2013-07-24 10:48, Arthur Chunqi Li wrote: So as what Gleb said, what about the following codes: static int vmx_run2() { u32 eax; bool ret; asm volatile( mov %%rsp, %%rsi\n\t mov %2, %%edi\n\t call vmcs_write\n\t vmlaunch\n\t Just like

Re: Cannot load kvm_amd module - (says disabled by bios)

2013-07-24 Thread Massimiliano Adamo
On Wed, 2013-07-24 at 10:04 +0200, Massimiliano Adamo wrote: On Tue, 2013-07-23 at 15:31 -0600, Alex Williamson wrote: On Tue, 2013-07-23 at 23:11 +0200, Massimiliano Adamo wrote: All, this is a bug with KVM, impacting (at least) all mainstream kernels that I tried so far:

RE: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Bhushan Bharat-R65777
-Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Wednesday, July 24, 2013 1:55 PM To: “tiejun.chen” Cc: Bhushan Bharat-R65777; kvm-...@vger.kernel.org; kvm@vger.kernel.org list; Wood Scott-B07421; Gleb Natapov; Paolo Bonzini Subject: Re: [PATCH 2/2] kvm:

Re: [RFC PATCH] kvm-unit-tests : Basic architecture of VMX nested test case

2013-07-24 Thread Paolo Bonzini
Il 24/07/2013 10:48, Arthur Chunqi Li ha scritto: So as what Gleb said, what about the following codes: static int vmx_run2() { u32 eax; bool ret; asm volatile( mov %%rsp, %%rsi\n\t mov %2, %%edi\n\t call vmcs_write\n\t vmlaunch\n\t

Re: [PATCH RESEND RFC V11 15/18] kvm : Paravirtual ticketlocks support for linux guests running on KVM hypervisor

2013-07-24 Thread Raghavendra K T
* Gleb Natapov g...@redhat.com [2013-07-23 18:07:48]: On Mon, Jul 22, 2013 at 11:50:16AM +0530, Raghavendra K T wrote: +static void kvm_lock_spinning(struct arch_spinlock *lock, __ticket_t want) +{ + struct kvm_lock_waiting *w; + int cpu; + u64 start; + unsigned long flags;

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Alexander Graf
On 24.07.2013, at 11:11, Bhushan Bharat-R65777 wrote: -Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Wednesday, July 24, 2013 1:55 PM To: “tiejun.chen” Cc: Bhushan Bharat-R65777; kvm-...@vger.kernel.org; kvm@vger.kernel.org list; Wood Scott-B07421; Gleb

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Gleb Natapov
On Wed, Jul 24, 2013 at 11:21:11AM +0200, Alexander Graf wrote: Are not we going to use page_is_ram() from e500_shadow_mas2_attrib() as Scott commented? rWhy aren't we using page_is_ram() in kvm_is_mmio_pfn()? Because it is much slower and, IIRC, actually used to build pfn map that

Re: [PATCH RFC V11 15/18] kvm : Paravirtual ticketlocks support for linux guests running on KVM hypervisor

2013-07-24 Thread Raghavendra K T
On 07/23/2013 08:37 PM, Gleb Natapov wrote: On Mon, Jul 22, 2013 at 11:50:16AM +0530, Raghavendra K T wrote: +static void kvm_lock_spinning(struct arch_spinlock *lock, __ticket_t want) [...] + + /* +* halt until it's our turn and kicked. Note that we do safe halt +* for

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Alexander Graf
On 24.07.2013, at 11:35, Gleb Natapov wrote: On Wed, Jul 24, 2013 at 11:21:11AM +0200, Alexander Graf wrote: Are not we going to use page_is_ram() from e500_shadow_mas2_attrib() as Scott commented? rWhy aren't we using page_is_ram() in kvm_is_mmio_pfn()? Because it is much slower

Re: [RFC PATCH] kvm-unit-tests : Basic architecture of VMX nested test case

2013-07-24 Thread Arthur Chunqi Li
So what about this one. I merged all the exit reason to ret and remove the flag detection after vmlaunch/vmresume (because I think this detection is useless). Currently we support only one guest, so variant launched is located in vmx_run(). If we want to support multiple guest, we could move it to

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Gleb Natapov
Copying Andrea for him to verify that I am not talking nonsense :) On Wed, Jul 24, 2013 at 10:25:20AM +0200, Alexander Graf wrote: diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 1580dd4..5e8635b 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -102,6 +102,10

Re: [RFC PATCH] kvm-unit-tests : Basic architecture of VMX nested test case

2013-07-24 Thread Jan Kiszka
On 2013-07-24 11:56, Arthur Chunqi Li wrote: So what about this one. I merged all the exit reason to ret and remove the flag detection after vmlaunch/vmresume (because I think this detection is useless). Currently we support only one guest, so variant launched is located in vmx_run(). If we

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Alexander Graf
On 24.07.2013, at 12:01, Gleb Natapov wrote: Copying Andrea for him to verify that I am not talking nonsense :) On Wed, Jul 24, 2013 at 10:25:20AM +0200, Alexander Graf wrote: diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 1580dd4..5e8635b 100644 --- a/virt/kvm/kvm_main.c

Re: [RFC PATCH] kvm-unit-tests : Basic architecture of VMX nested test case

2013-07-24 Thread Arthur Chunqi Li
On Wed, Jul 24, 2013 at 6:03 PM, Jan Kiszka jan.kis...@web.de wrote: On 2013-07-24 11:56, Arthur Chunqi Li wrote: So what about this one. I merged all the exit reason to ret and remove the flag detection after vmlaunch/vmresume (because I think this detection is useless). Currently we support

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Gleb Natapov
On Wed, Jul 24, 2013 at 12:09:42PM +0200, Alexander Graf wrote: On 24.07.2013, at 12:01, Gleb Natapov wrote: Copying Andrea for him to verify that I am not talking nonsense :) On Wed, Jul 24, 2013 at 10:25:20AM +0200, Alexander Graf wrote: diff --git a/virt/kvm/kvm_main.c

Re: [RFC PATCH] kvm-unit-tests : Basic architecture of VMX nested test case

2013-07-24 Thread Jan Kiszka
On 2013-07-24 12:16, Arthur Chunqi Li wrote: On Wed, Jul 24, 2013 at 6:03 PM, Jan Kiszka jan.kis...@web.de wrote: On 2013-07-24 11:56, Arthur Chunqi Li wrote: So what about this one. I merged all the exit reason to ret and remove the flag detection after vmlaunch/vmresume (because I think

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Alexander Graf
On 24.07.2013, at 12:19, Gleb Natapov wrote: On Wed, Jul 24, 2013 at 12:09:42PM +0200, Alexander Graf wrote: On 24.07.2013, at 12:01, Gleb Natapov wrote: Copying Andrea for him to verify that I am not talking nonsense :) On Wed, Jul 24, 2013 at 10:25:20AM +0200, Alexander Graf wrote:

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Gleb Natapov
On Wed, Jul 24, 2013 at 12:25:18PM +0200, Alexander Graf wrote: On 24.07.2013, at 12:19, Gleb Natapov wrote: On Wed, Jul 24, 2013 at 12:09:42PM +0200, Alexander Graf wrote: On 24.07.2013, at 12:01, Gleb Natapov wrote: Copying Andrea for him to verify that I am not talking nonsense

Re: [PATCH RFC V11 15/18] kvm : Paravirtual ticketlocks support for linux guests running on KVM hypervisor

2013-07-24 Thread Gleb Natapov
On Wed, Jul 24, 2013 at 03:15:50PM +0530, Raghavendra K T wrote: On 07/23/2013 08:37 PM, Gleb Natapov wrote: On Mon, Jul 22, 2013 at 11:50:16AM +0530, Raghavendra K T wrote: +static void kvm_lock_spinning(struct arch_spinlock *lock, __ticket_t want) [...] + + /* +* halt until it's our

Re: [RFC PATCH] kvm-unit-tests : Basic architecture of VMX nested test case

2013-07-24 Thread Arthur Chunqi Li
And what about this version: static int vmx_run() { u32 ret = 0; asm volatile( mov %%rsp, %%rsi\n\t mov %2, %%edi\n\t call vmcs_write\n\t 0: LOAD_GPR_C cmpl $0, %1\n\t jne 1f\n\t vmlaunch;seta %1\n\t /* vmlaunch

Re: [RFC PATCH] kvm-unit-tests : Basic architecture of VMX nested test case

2013-07-24 Thread Jan Kiszka
On 2013-07-24 13:20, Arthur Chunqi Li wrote: And what about this version: static int vmx_run() { u32 ret = 0; asm volatile( mov %%rsp, %%rsi\n\t mov %2, %%edi\n\t call vmcs_write\n\t 0: LOAD_GPR_C cmpl $0, %1\n\t

Re: [PATCH RFC V11 15/18] kvm : Paravirtual ticketlocks support for linux guests running on KVM hypervisor

2013-07-24 Thread Raghavendra K T
On 07/24/2013 04:09 PM, Gleb Natapov wrote: On Wed, Jul 24, 2013 at 03:15:50PM +0530, Raghavendra K T wrote: On 07/23/2013 08:37 PM, Gleb Natapov wrote: On Mon, Jul 22, 2013 at 11:50:16AM +0530, Raghavendra K T wrote: +static void kvm_lock_spinning(struct arch_spinlock *lock, __ticket_t want)

Re: [PATCH RFC V11 15/18] kvm : Paravirtual ticketlocks support for linux guests running on KVM hypervisor

2013-07-24 Thread Gleb Natapov
On Wed, Jul 24, 2013 at 05:30:20PM +0530, Raghavendra K T wrote: On 07/24/2013 04:09 PM, Gleb Natapov wrote: On Wed, Jul 24, 2013 at 03:15:50PM +0530, Raghavendra K T wrote: On 07/23/2013 08:37 PM, Gleb Natapov wrote: On Mon, Jul 22, 2013 at 11:50:16AM +0530, Raghavendra K T wrote: +static

Re: VU#976534 - How to submit security bugs?

2013-07-24 Thread Anthony Liguori
CERT(R) Coordination Center c...@cert.org writes: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Greetings, My name is Adam Rauf and I work for the CERT Coordination Center. We have a report that may affect KVM/QEMU. How can we securely send it over to you? Thanks so much! For

Re: [PATCH RFC V11 15/18] kvm : Paravirtual ticketlocks support for linux guests running on KVM hypervisor

2013-07-24 Thread Raghavendra K T
On 07/24/2013 05:36 PM, Gleb Natapov wrote: On Wed, Jul 24, 2013 at 05:30:20PM +0530, Raghavendra K T wrote: On 07/24/2013 04:09 PM, Gleb Natapov wrote: On Wed, Jul 24, 2013 at 03:15:50PM +0530, Raghavendra K T wrote: On 07/23/2013 08:37 PM, Gleb Natapov wrote: On Mon, Jul 22, 2013 at

[ANNOUNCE] Key Signing Party at KVM Forum 2013

2013-07-24 Thread Anthony Liguori
I will be hosting a key signing party at this year's KVM Forum. http://wiki.qemu.org/KeySigningParty2013 Starting for the 1.7 release (begins in December), I will only accepted signed pull requests so please try to attend this event or make alternative arrangements to have someone sign your key

Re: Cannot load kvm_amd module - (says disabled by bios)

2013-07-24 Thread Alex Williamson
On Wed, 2013-07-24 at 11:09 +0200, Massimiliano Adamo wrote: On Wed, 2013-07-24 at 10:04 +0200, Massimiliano Adamo wrote: On Tue, 2013-07-23 at 15:31 -0600, Alex Williamson wrote: On Tue, 2013-07-23 at 23:11 +0200, Massimiliano Adamo wrote: All, this is a bug with KVM,

RE: [PATCH 4/4] x86: properly handle kvm emulation of hyperv

2013-07-24 Thread KY Srinivasan
-Original Message- From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Sent: Wednesday, July 24, 2013 3:07 AM To: Jason Wang Cc: H. Peter Anvin; KY Srinivasan; t...@linutronix.de; mi...@redhat.com; x...@kernel.org; g...@redhat.com; kvm@vger.kernel.org;

Re: [PATCH] intel-iommu: Fix leaks in pagetable freeing

2013-07-24 Thread Alex Williamson
This is a pretty massive memory leak, anyone @Intel care? Thanks, Alex On Sat, 2013-06-15 at 10:27 -0600, Alex Williamson wrote: At best the current code only seems to free the leaf pagetables and the root. If you're unlucky enough to have a large gap (like any QEMU guest with more than 3G

Re: Linux Plumbers ACPI/PM, PCI Microconference

2013-07-24 Thread Shuah Khan
On Tue, Jul 23, 2013 at 10:06 AM, Bjorn Helgaas bhelg...@google.com wrote: On Tue, Jul 16, 2013 at 8:21 PM, Myron Stowe myron.st...@gmail.com wrote: Linux Plumbers has approved an ACPI/PM, PCI microconference. The overview page is here: http://wiki.linuxplumbersconf.org/2013:pci_subsystem

RE: [PATCH 4/4] x86: properly handle kvm emulation of hyperv

2013-07-24 Thread H. Peter Anvin
I don't see how this solves the A emulates B, B emulates A problem? KY Srinivasan k...@microsoft.com wrote: -Original Message- From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo Bonzini Sent: Wednesday, July 24, 2013 3:07 AM To: Jason Wang Cc: H. Peter Anvin;

RE: [PATCH 4/4] x86: properly handle kvm emulation of hyperv

2013-07-24 Thread KY Srinivasan
-Original Message- From: H. Peter Anvin [mailto:h...@zytor.com] Sent: Wednesday, July 24, 2013 11:14 AM To: KY Srinivasan; Paolo Bonzini; Jason Wang Cc: t...@linutronix.de; mi...@redhat.com; x...@kernel.org; g...@redhat.com; kvm@vger.kernel.org; linux-ker...@vger.kernel.org

[Bug 60620] New: guest loses frequently (multiple times per day!) connectivity to network device

2013-07-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60620 Bug ID: 60620 Summary: guest loses frequently (multiple times per day!) connectivity to network device Product: Virtualization Version: unspecified Kernel Version: 3.8, 3.9, 3.10

[Bug 60620] guest loses frequently (multiple times per day!) connectivity to network device

2013-07-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=60620 Folkert van Heusden folk...@vanheusden.com changed: What|Removed |Added Severity|high|normal --

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Scott Wood
On 07/24/2013 04:39:59 AM, Alexander Graf wrote: On 24.07.2013, at 11:35, Gleb Natapov wrote: On Wed, Jul 24, 2013 at 11:21:11AM +0200, Alexander Graf wrote: Are not we going to use page_is_ram() from e500_shadow_mas2_attrib() as Scott commented? rWhy aren't we using page_is_ram() in

RE: [PATCH 4/4] x86: properly handle kvm emulation of hyperv

2013-07-24 Thread H. Peter Anvin
What I'm suggesting is exactly that except that the native hypervisor is later in CPUID space. KY Srinivasan k...@microsoft.com wrote: -Original Message- From: H. Peter Anvin [mailto:h...@zytor.com] Sent: Wednesday, July 24, 2013 11:14 AM To: KY Srinivasan; Paolo Bonzini; Jason

Re: [PATCH 04/10] powerpc: Prepare to support kernel handling of IOMMU map/unmap

2013-07-24 Thread Andrew Morton
On Tue, 23 Jul 2013 12:22:59 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: Ping, anyone, please? ew, you top-posted. Ben needs ack from any of MM people before proceeding with this patch. Thanks! For what? The three lines of comment in page-flags.h? ack :) Manipulating page-_count

Re: [PATCH 04/10] powerpc: Prepare to support kernel handling of IOMMU map/unmap

2013-07-24 Thread Benjamin Herrenschmidt
On Wed, 2013-07-24 at 15:43 -0700, Andrew Morton wrote: For what? The three lines of comment in page-flags.h? ack :) Manipulating page-_count directly is considered poor form. Don't blame us if we break your code ;) Actually, the manipulation in realmode_get_page() duplicates the

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Andrea Arcangeli
Hi! On Wed, Jul 24, 2013 at 01:30:12PM +0300, Gleb Natapov wrote: On Wed, Jul 24, 2013 at 12:25:18PM +0200, Alexander Graf wrote: On 24.07.2013, at 12:19, Gleb Natapov wrote: On Wed, Jul 24, 2013 at 12:09:42PM +0200, Alexander Graf wrote: On 24.07.2013, at 12:01, Gleb Natapov

Re: Call for Proposals: 2013 Linux Plumbers Virtualization Microconference

2013-07-24 Thread Alex Williamson
Reminder, there's one week left to submit proposals for the virtualization micro-conference at LPC. Please see below for details and note the update to submit proposals through the Linux Plumbers website: http://www.linuxplumbersconf.org/2013/ocw/events/LPC2013/proposals/new Thanks, Alex On

[PATCH] kvm-unit-tests : Basic architecture of VMX nested test case

2013-07-24 Thread Arthur Chunqi Li
This is the first version of VMX nested environment. It contains the basic VMX instructions test cases, including VMXON/VMXOFF/VMXPTRLD/ VMXPTRST/VMCLEAR/VMLAUNCH/VMRESUME/VMCALL. This patchalso tests the basic execution routine in VMX nested environment andlet the VM print Hello World to inform

RE: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Bhushan Bharat-R65777
-Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Wednesday, July 24, 2013 1:55 PM To: “tiejun.chen” Cc: Bhushan Bharat-R65777; kvm-ppc@vger.kernel.org; k...@vger.kernel.org list; Wood Scott-B07421; Gleb Natapov; Paolo Bonzini Subject: Re: [PATCH 2/2] kvm:

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Alexander Graf
On 24.07.2013, at 11:11, Bhushan Bharat-R65777 wrote: -Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Wednesday, July 24, 2013 1:55 PM To: “tiejun.chen” Cc: Bhushan Bharat-R65777; kvm-ppc@vger.kernel.org; k...@vger.kernel.org list; Wood Scott-B07421; Gleb

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Alexander Graf
On 24.07.2013, at 11:35, Gleb Natapov wrote: On Wed, Jul 24, 2013 at 11:21:11AM +0200, Alexander Graf wrote: Are not we going to use page_is_ram() from e500_shadow_mas2_attrib() as Scott commented? rWhy aren't we using page_is_ram() in kvm_is_mmio_pfn()? Because it is much slower

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Gleb Natapov
Copying Andrea for him to verify that I am not talking nonsense :) On Wed, Jul 24, 2013 at 10:25:20AM +0200, Alexander Graf wrote: diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 1580dd4..5e8635b 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -102,6 +102,10

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Alexander Graf
On 24.07.2013, at 12:01, Gleb Natapov wrote: Copying Andrea for him to verify that I am not talking nonsense :) On Wed, Jul 24, 2013 at 10:25:20AM +0200, Alexander Graf wrote: diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 1580dd4..5e8635b 100644 --- a/virt/kvm/kvm_main.c

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Gleb Natapov
On Wed, Jul 24, 2013 at 12:09:42PM +0200, Alexander Graf wrote: On 24.07.2013, at 12:01, Gleb Natapov wrote: Copying Andrea for him to verify that I am not talking nonsense :) On Wed, Jul 24, 2013 at 10:25:20AM +0200, Alexander Graf wrote: diff --git a/virt/kvm/kvm_main.c

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Alexander Graf
On 24.07.2013, at 12:19, Gleb Natapov wrote: On Wed, Jul 24, 2013 at 12:09:42PM +0200, Alexander Graf wrote: On 24.07.2013, at 12:01, Gleb Natapov wrote: Copying Andrea for him to verify that I am not talking nonsense :) On Wed, Jul 24, 2013 at 10:25:20AM +0200, Alexander Graf wrote:

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Gleb Natapov
On Wed, Jul 24, 2013 at 12:25:18PM +0200, Alexander Graf wrote: On 24.07.2013, at 12:19, Gleb Natapov wrote: On Wed, Jul 24, 2013 at 12:09:42PM +0200, Alexander Graf wrote: On 24.07.2013, at 12:01, Gleb Natapov wrote: Copying Andrea for him to verify that I am not talking nonsense

Re: [PATCH 2/2] kvm: powerpc: set cache coherency only for kernel managed pages

2013-07-24 Thread Scott Wood
On 07/24/2013 04:39:59 AM, Alexander Graf wrote: On 24.07.2013, at 11:35, Gleb Natapov wrote: On Wed, Jul 24, 2013 at 11:21:11AM +0200, Alexander Graf wrote: Are not we going to use page_is_ram() from e500_shadow_mas2_attrib() as Scott commented? rWhy aren't we using page_is_ram() in

Re: [PATCH 04/10] powerpc: Prepare to support kernel handling of IOMMU map/unmap

2013-07-24 Thread Andrew Morton
On Tue, 23 Jul 2013 12:22:59 +1000 Alexey Kardashevskiy a...@ozlabs.ru wrote: Ping, anyone, please? ew, you top-posted. Ben needs ack from any of MM people before proceeding with this patch. Thanks! For what? The three lines of comment in page-flags.h? ack :) Manipulating page-_count

Re: [PATCH 04/10] powerpc: Prepare to support kernel handling of IOMMU map/unmap

2013-07-24 Thread Benjamin Herrenschmidt
On Wed, 2013-07-24 at 15:43 -0700, Andrew Morton wrote: For what? The three lines of comment in page-flags.h? ack :) Manipulating page-_count directly is considered poor form. Don't blame us if we break your code ;) Actually, the manipulation in realmode_get_page() duplicates the