Recent iterator-related changes in vhost made it
harder to follow the logic fixing up the header.
In fact, the fixup always happens at the same
offset: sizeof(virtio_net_hdr): sometimes the
fixup iterator is updated by copy_to_iter,
sometimes-by iov_iter_advance.
Rearrange code to make this
On Wed, Feb 25, 2015 at 03:32:08PM +0100, Cornelia Huck wrote:
On Wed, 25 Feb 2015 15:14:36 +0100
Michael S. Tsirkin m...@redhat.com wrote:
virtio balloon has this code:
wait_event_interruptible(vb-config_change,
(diff = towards_target(vb)) != 0
On Wed, 25 Feb 2015 15:14:36 +0100
Michael S. Tsirkin m...@redhat.com wrote:
virtio balloon has this code:
wait_event_interruptible(vb-config_change,
(diff = towards_target(vb)) != 0
|| vb-need_stats_update
On Mon, Feb 23, 2015 at 05:23:58PM +, Pekka Enberg wrote:
Hi,
Hi Pekka,
Sorry for the delay, I've been away from email for a few days.
On 2/18/15 5:50 PM, Will Deacon wrote:
Thanks for doing this. Since it looks unlikely that kvmtool will ever be
merged back into the kernel tree, it
virtio balloon has this code:
wait_event_interruptible(vb-config_change,
(diff = towards_target(vb)) != 0
|| vb-need_stats_update
|| kthread_should_stop()
||
virtio balloon has this code:
wait_event_interruptible(vb-config_change,
(diff = towards_target(vb)) != 0
|| vb-need_stats_update
|| kthread_should_stop()
||
On Wed, Feb 25, 2015 at 11:13:18AM +0100, Thomas Huth wrote:
Hi all,
with the recent kernel 3.19, I get a kernel warning when I start my
KVM guest on s390 with virtio balloon enabled:
[0.839687] do not call blocking ops when !TASK_RUNNING; state=1 set at
The 2 that we use for copy_to_iter comes from sizeof(u16),
it used to be that way before the iov iter update.
Fix it up, making it obvious the size of stack access
is right.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
drivers/vhost/net.c | 3 ++-
1 file changed, 2 insertions(+), 1
I was getting very confused about the duplication of state. Perhaps we
should just get rid of env-spsr and use helpers that understand the
banking?
Signed-off-by: Alex Bennée alex.ben...@linaro.org
diff --git a/target-arm/cpu.h b/target-arm/cpu.h
index 11845a6..d7fd13f 100644
---
In conjunction with the kernel patch series I've just sent:
http://thread.gmane.org/gmane.comp.emulators.kvm.arm.devel/101/focus=100
These patches have been fairly heavily tested on the xgene systems
I've got access to and I'm pretty confident we've caught all the
corner cases.
From QEMU's
From: Christoffer Dall christoffer.d...@linaro.org
The current code was negatively indexing the cpu state array and not
synchronizing banked spsr register state with the current mode's spsr
state, causing occasional failures with migration.
Some munging is done to take care of the aarch64
From: Christoffer Dall christoffer.d...@linaro.org
Migrating active interrupts causes the active state to be lost
completely. This implements some additional bitmaps to track the active
state on the distributor and export this to user space.
Signed-off-by: Christoffer Dall
On Tue, Feb 24, 2015 at 05:30:06PM +0100, Radim Krčmář wrote:
2015-02-23 19:05+0100, Kashyap Chamarthy:
Tested with the _correct_ Kernel[1] (that has Radim's patch) now --
applied it on both L0 and L1.
Result: Same as before -- Booting L2 causes L1 to reboot. However, the
stack
To cleanly restore an SMP VM we need to ensure that the current pause
state of each vcpu is correctly recorded. Things could get confused if
the CPU starts running after migration restore completes when it was
paused before it state was captured.
We use the existing KVM_GET/SET_MP_STATE ioctl to
From: Christoffer Dall christoffer.d...@linaro.org
When a VCPU is no longer running, we currently check to see if it has a
timer scheduled in the future, and if it does, we schedule a host
hrtimer to notify is in case the timer expires while the VCPU is still
not running. When the hrtimer fires,
The following patches fix a number of bugs that were being exposed
when attempting migration with arm64 KVM. Together with some fixes to
QEMU (github.com/stsquad/qemu/tree/migration/fixes-v2) I have
successfully run 500 migrations each on:
* aarch64 kernel, aarch64 user-space
* aarch64
From: Christoffer Dall christoffer.d...@linaro.org
There is an interesting bug in the vgic code, which manifests itself
when the KVM run loop has a signal pending or needs a vmid generation
rollover after having disabled interrupts but before actually switching
to the guest.
In this case, we
While observing KVM traces I can see additional IRQ calls on pretty much
every MMIO access which is just plain inefficient. Only update the QEMU
IRQ level if something has actually changed from last time. Otherwise we
may be papering over other failure modes.
Signed-off-by: Alex Bennée
From: Christoffer Dall christoffer.d...@linaro.org
The current code was negatively indexing the cpu state array and not
synchronizing banked spsr register state with the current mode's spsr
state, causing occasional failures with migration.
Some munging is done to take care of the aarch64
As there is logic to deal with the difference between edge and level
triggered interrupts in the kernel we must ensure it knows the
configuration of the IRQs before we restore the pending state.
Signed-off-by: Alex Bennée alex.ben...@linaro.org
diff --git a/hw/intc/arm_gic_kvm.c
From: Alex Bennée a...@bennee.com
For migration to work we need to sync all of the register state. This is
especially noticeable when GCC starts using FP registers as spill
registers even with integer programs.
Signed-off-by: Alex Bennée alex.ben...@linaro.org
diff --git a/target-arm/kvm64.c
On 2015-02-10 23:32, Paul Bolle wrote:
On Tue, 2015-02-10 at 14:21 -0800, David Rientjes wrote:
We need an update to the MAINTAINERS file if Yann E. MORIN
yann.morin.1...@free.fr isn't the active Kconfig maintainer anymore.
Yes, we do. Michal, what update would you suggest?
I'll revert the
On Wed, 25 Feb 2015 16:11:27 +0100
Cornelia Huck cornelia.h...@de.ibm.com wrote:
On Wed, 25 Feb 2015 15:36:02 +0100
Michael S. Tsirkin m...@redhat.com wrote:
virtio balloon has this code:
wait_event_interruptible(vb-config_change,
(diff =
Hi,
commit in $Subject breaks my kvm guest on AMD host, causing it to do the
following below. Mouse doesn't work anymore in the guest, network is
gone too.
Reverting it fixes the issue.
---
...
[4.849095] Freeing unused kernel memory: 2972K (81aee000 -
81dd5000)
[
On Wed, 25 Feb 2015 15:36:02 +0100
Michael S. Tsirkin m...@redhat.com wrote:
virtio balloon has this code:
wait_event_interruptible(vb-config_change,
(diff = towards_target(vb)) != 0
|| vb-need_stats_update
This adds the saving and restore of the current Multi-Processing state
of the machine. While the KVM_GET/SET_MP_STATE API exposes a number of
potential states for x86 we only use two for ARM. Either the process is
running or not.
Signed-off-by: Alex Bennée alex.ben...@linaro.org
diff --git
2015-02-25 17:00+0100, Borislav Petkov:
Hi,
commit in $Subject breaks my kvm guest on AMD host, causing it to do the
following below. Mouse doesn't work anymore in the guest, network is
gone too.
Reverting it fixes the issue.
Thanks,
this patch should fix it.
---8---
In commit
2015-02-24 15:25-0600, Joel Schopp:
- clr_cr_intercept(svm, INTERCEPT_CR0_WRITE);
} else {
set_cr_intercept(svm, INTERCEPT_CR0_READ);
(There is no point in checking fpu_active if cr0s are equal.)
- set_cr_intercept(svm, INTERCEPT_CR0_WRITE);
KVM uses
On Wed, 25 Feb 2015, Michal Marek wrote:
On Tue, 2015-02-10 at 14:21 -0800, David Rientjes wrote:
We need an update to the MAINTAINERS file if Yann E. MORIN
yann.morin.1...@free.fr isn't the active Kconfig maintainer anymore.
Yes, we do. Michal, what update would you suggest?
I'll
* Peter Zijlstra | 2015-02-18 15:03:20 [+0100]:
On Tue, Feb 17, 2015 at 06:44:19PM +0100, Sebastian Andrzej Siewior wrote:
* Peter Zijlstra | 2015-01-21 16:07:16 [+0100]:
On Tue, Jan 20, 2015 at 01:16:13PM -0500, Steven Rostedt wrote:
I'm actually wondering if we should just nuke the
On Wed, Feb 25, 2015 at 12:49 PM, David Rientjes rient...@google.com wrote:
Woohoo, so does this mean that Luis's series will finally be merged into a
tree somewhere? It's been a lengthy wait to try to get this merged.
David Rientjes (as I'm also Cc'ing David Vrabel),
I am reworking Xen's
On Wed, 25 Feb 2015, Luis R. Rodriguez wrote:
I am reworking Xen's kconfig stuff right now, so perhaps what is best
is for this series to be folded under those changes and I'd submit
them as the last series in the changes. That would avoid collateral
changes as I revamp tons of Xen kconfig
On Wed, Feb 25, 2015 at 1:19 PM, Konrad Rzeszutek Wilk
konrad.w...@oracle.com wrote:
On Wed, Feb 25, 2015 at 01:11:04PM -0800, David Rientjes wrote:
On Wed, 25 Feb 2015, Luis R. Rodriguez wrote:
I am reworking Xen's kconfig stuff right now, so perhaps what is best
is for this series to be
On Wed, Feb 25, 2015 at 01:11:04PM -0800, David Rientjes wrote:
On Wed, 25 Feb 2015, Luis R. Rodriguez wrote:
I am reworking Xen's kconfig stuff right now, so perhaps what is best
is for this series to be folded under those changes and I'd submit
them as the last series in the changes.
On Wed, Feb 25, 2015 at 01:25:59PM -0800, Luis R. Rodriguez wrote:
On Wed, Feb 25, 2015 at 1:19 PM, Konrad Rzeszutek Wilk
konrad.w...@oracle.com wrote:
On Wed, Feb 25, 2015 at 01:11:04PM -0800, David Rientjes wrote:
On Wed, 25 Feb 2015, Luis R. Rodriguez wrote:
I am reworking Xen's
On Fri, Dec 12, 2014 at 11:14:58PM +0800, Feng Wu wrote:
This patch updates the Posted-Interrupts Descriptor when vCPU
is blocked.
pre-block:
- Add the vCPU to the blocked per-CPU list
- Clear 'SN'
- Set 'NV' to POSTED_INTR_WAKEUP_VECTOR
post-block:
- Remove the vCPU from the per-CPU
From: Michael S. Tsirkin m...@redhat.com
Date: Tue, 24 Feb 2015 17:31:10 +0100
The 2 that we use for copy_to_iter comes from sizeof(u16),
it used to be that way before the iov iter update.
Fix it up, making it obvious the size of stack access
is right.
Signed-off-by: Michael S. Tsirkin
On Sat, Feb 21, 2015 at 12:21:16AM +0100, Borislav Petkov wrote:
On Fri, Feb 20, 2015 at 04:02:10PM -0600, Joel Schopp wrote:
From: David Kaplan david.kap...@amd.com
KVM has nice wrappers to access the register values, clean up a few places
that should use them but currently do not.
On Fri, Feb 20, 2015 at 08:21:36AM -0500, Kevin Mulvey wrote:
Better alignment of loop using tabs rather than spaces, this
makes checkpatch.pl happier.
Signed-off-by: Kevin Mulvey kmul...@linux.com
---
virt/kvm/kvm_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Applied
https://bugzilla.kernel.org/show_bug.cgi?id=93251
Marcelo Tosatti mtosa...@redhat.com changed:
What|Removed |Added
CC||mtosa...@redhat.com
On 25/02/2015 00:44, Marcelo Tosatti wrote:
On Thu, Feb 12, 2015 at 12:58:21PM +0800, Xiubo Li wrote:
It forgets to free coalesced_mmio_ring page after the anon_inode_getfd
fails.
Signed-off-by: Xiubo Li lixi...@cmss.chinamobile.com
---
virt/kvm/kvm_main.c | 16 +++-
1 file
Radim,
On Thu, Feb 12, 2015 at 07:41:30PM +0100, Radim Krčmář wrote:
Each patch has a diff from v1, here is only a prologue on the mythical
mixed xAPIC and x2APIC mode:
There is one interesting alias in xAPIC and x2APIC ICR destination, the
0xff00, which is a broadcast in xAPIC and
Thomas Huth th...@linux.vnet.ibm.com writes:
Hi all,
with the recent kernel 3.19, I get a kernel warning when I start my
KVM guest on s390 with virtio balloon enabled:
The deeper problem is that virtio_ccw_get_config just silently fails on
OOM.
Neither get_config nor set_config are expected
On 02/25/2015 02:26 PM, Radim Krčmář wrote:
2015-02-24 15:25-0600, Joel Schopp:
- clr_cr_intercept(svm, INTERCEPT_CR0_WRITE);
} else {
set_cr_intercept(svm, INTERCEPT_CR0_READ);
(There is no point in checking fpu_active if cr0s are equal.)
-
On 26 February 2015 at 01:02, Alex Bennée alex.ben...@linaro.org wrote:
This adds the saving and restore of the current Multi-Processing state
of the machine. While the KVM_GET/SET_MP_STATE API exposes a number of
potential states for x86 we only use two for ARM. Either the process is
running
There are many WARNINGs like this:
WARNING: sizeof tr should be sizeof(tr)
+ if (copy_from_user(tr, argp, sizeof tr))
In kvm_main.c many places are using 'sizeof(X)', and the other places
are using 'sizeof X', while the kernel recommands to use 'sizeof(X)',
so this patch will replace all
There are many Warnings like this:
WARNING: Missing a blank line after declarations
+ struct kvm_coalesced_mmio_zone zone;
+ r = -EFAULT;
This patch fixes these warnings to reduce noise when checking new
patches in kvm_main.c.
Signed-off-by: Xiubo Li lixi...@cmss.chinamobile.com
---
ERROR: code indent should use tabs where possible
+ const struct kvm_io_range *r2)$
WARNING: please, no spaces at the start of a line
+ const struct kvm_io_range *r2)$
This patch fixes this ERROR WARNING to reduce noise when
WARNING: EXPORT_SYMBOL(foo); should immediately follow its
function/variable
+EXPORT_SYMBOL_GPL(gfn_to_page);
This patch fixes these warnings to reduce noise when checking new
patches in kvm_main.c.
Signed-off-by: Xiubo Li lixi...@cmss.chinamobile.com
---
virt/kvm/kvm_main.c | 1 -
1 file
ERROR: do not initialise statics to 0 or NULL
+static int kvm_usage_count = 0;
The kvm_usage_count will be placed to .bss segment when linking, so
not need to set it to 0 here obviously.
This patch fixes this ERROR to reduce noise when checking new patches
in kvm_main.c.
Signed-off-by: Xiubo Li
WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
+ printk(KERN_INFO kvm: exiting hardware virtualization\n);
WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then
dev_err(dev, ... then pr_err(... to
WARNING: quoted string split across lines
+ printk(KERN_INFO kvm: enabling virtualization on
+CPU%d failed\n, cpu);
When fails to enable virtualization on CPUx for kvm, this log will
be output in only one line, and it will be a little confusing for us
to grep this log in
There are to many warnings and errors noise in kvm_main.c when we are
gernerating and checking new patches.
This patch series fix these warnings and errors to reduce possible noise.
Xiubo Li (9):
Fix WARNING: quoted string split across lines in kvm_main.c
Fix WARNINGs for 'sizeof(X)'
WARNING: please, no space before tabs
+ * ^I^Ikvm-lock -- kvm-slots_lock -- kvm-irq_lock$
WARNING: please, no space before tabs
+^I^I * ^I- gfn_to_hva (kvm_read_guest, gfn_to_pfn)$
WARNING: please, no space before tabs
+^I^I * ^I- kvm_is_visible_gfn (mmu_check_roots)$
This patch fixes these
WARNING: labels should not be indented
+ out_free_irq_routing:
This patch fixes this WARNING to reduce noise when checking new patches
in kvm_main.c.
Signed-off-by: Xiubo Li lixi...@cmss.chinamobile.com
---
virt/kvm/kvm_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Thu, 26 Feb 2015 14:58:18 +0800
Xiubo Li lixi...@cmss.chinamobile.com wrote:
WARNING: quoted string split across lines
+ printk(KERN_INFO kvm: enabling virtualization on
+ CPU%d failed\n, cpu);
When fails to enable virtualization on CPUx for kvm, this log will
be
On Thu, 26 Feb 2015 11:50:42 +1030
Rusty Russell ru...@rustcorp.com.au wrote:
Thomas Huth th...@linux.vnet.ibm.com writes:
Hi all,
with the recent kernel 3.19, I get a kernel warning when I start my
KVM guest on s390 with virtio balloon enabled:
The deeper problem is that
* Christian Borntraeger borntrae...@de.ibm.com wrote:
By all means!
You'll first need to cherry-pick these commits:
927609d622a3 kernel: tighten rules for ACCESS ONCE
c5b19946eb76 kernel: Fix sparse warning for ACCESS_ONCE
dd36929720f4 kernel: make READ_ONCE() valid on const
* Greg KH gre...@linuxfoundation.org wrote:
It's:
d6abfdb20223 x86/spinlocks/paravirt: Fix memory corruption on unlock
Yes, This is the original patch. Please note I have taken out the
READ_ONCE changes from the original patch to avoid build warnings
mentioned below.
(Those
Hi all,
with the recent kernel 3.19, I get a kernel warning when I start my
KVM guest on s390 with virtio balloon enabled:
[0.839687] do not call blocking ops when !TASK_RUNNING; state=1 set at
[00174a1e] prepare_to_wait_event+0x7e/0x108
[0.839694] [
Am 25.02.2015 um 11:08 schrieb Ingo Molnar:
* Greg KH gre...@linuxfoundation.org wrote:
It's:
d6abfdb20223 x86/spinlocks/paravirt: Fix memory corruption on unlock
Yes, This is the original patch. Please note I have taken out the
READ_ONCE changes from the original patch to avoid build
On Wed, 25 Feb 2015 11:13:18 +0100
Thomas Huth th...@linux.vnet.ibm.com wrote:
Hi all,
with the recent kernel 3.19, I get a kernel warning when I start my
KVM guest on s390 with virtio balloon enabled:
[0.839687] do not call blocking ops when !TASK_RUNNING; state=1 set at
On Wed, 25 Feb 2015 14:50:22 +1030
Rusty Russell ru...@rustcorp.com.au wrote:
OK, I am trying to experiment with virtio 1.0 support using the
latest kernel and MST's qemu tree:
https://git.kernel.org/cgit/virt/kvm/mst/qemu.git/?h=virtio-1.0
The first issue is that the device
63 matches
Mail list logo
