Re: [PATCH v2 6/6] target-arm: cpu.h document why env-spsr exists

2015-03-04 Thread Alex Bennée
Peter Maydell peter.mayd...@linaro.org writes: On 4 March 2015 at 23:35, Alex Bennée alex.ben...@linaro.org wrote: I was getting very confused about the duplication of state. Perhaps we should just get rid of env-spsr and use helpers that understand the banking? Doesn't seem worth changing

[PATCH v5 4/4] vfio: type1: implement the VFIO_DMA_MAP_FLAG_NOEXEC flag

2015-03-04 Thread Baptiste Reynal
From: Antonios Motakis a.mota...@virtualopensystems.com Some IOMMU drivers, such as the ARM SMMU driver, make available the IOMMU_NOEXEC flag to set the page tables for a device as XN (execute never). This affects devices such as the ARM PL330 DMA Controller, which respects this flag and will

[PATCH v5 1/4] vfio: implement iommu driver capabilities with an enum

2015-03-04 Thread Baptiste Reynal
From: Antonios Motakis a.mota...@virtualopensystems.com Currently a VFIO driver's IOMMU capabilities are encoded as a series of numerical defines. Replace this with an enum for future maintainability. Signed-off-by: Antonios Motakis a.mota...@virtualopensystems.com Signed-off-by: Baptiste Reynal

Re: [PATCH v2] KVM: vmx: Set msr bitmap correctly if vcpu is in guest mode

2015-03-04 Thread Bandan Das
Hi Wincy, Wincy Van fanwenyi0...@gmail.com writes: In commit 3af18d9c5fe9 (KVM: nVMX: Prepare for using hardware MSR bitmap), we are setting MSR_BITMAP in prepare_vmcs02 if we should use hardware. This is not enough since the field will be modified by following vmx_set_efer. Fix this by

QEMU, libvirt, and KVM are participating in Outreachy May-August 2015

2015-03-04 Thread Stefan Hajnoczi
QEMU, libvirt, and KVM are participating in the Outreachy (formerly known as Outreach Program for Women) May-August 2015 round. Outreachy is a 12-week full-time paid internship for working on open source projects. We are able to participate thanks to sponsors who will be listed on the Outreachy

[PATCH v5 3/4] vfio: type1: replace vfio_domains_have_iommu_cache with generic function

2015-03-04 Thread Baptiste Reynal
From: Antonios Motakis a.mota...@virtualopensystems.com Replace the function vfio_domains_have_iommu_cache() with a more generic function vfio_domains_have_iommu_cap() which allows to check all domains of an vfio_iommu structure for a given cached capability. Signed-off-by: Antonios Motakis

[PATCH v5 2/4] vfio: introduce the VFIO_DMA_MAP_FLAG_NOEXEC flag

2015-03-04 Thread Baptiste Reynal
From: Antonios Motakis a.mota...@virtualopensystems.com We introduce the VFIO_DMA_MAP_FLAG_NOEXEC flag to the VFIO dma map call, and expose its availability via the capability VFIO_DMA_NOEXEC_IOMMU. This way the user can control whether the XN flag will be set on the requested mappings. The

Re: [RFC/RFT PATCH 0/3] arm64: KVM: work around incoherency with uncached guest mappings

2015-03-04 Thread Catalin Marinas
On Wed, Mar 04, 2015 at 06:03:11PM +0100, Paolo Bonzini wrote: On 04/03/2015 15:29, Catalin Marinas wrote: I disagree it is 100% a host-side issue. It is a host-side issue _if_ the host tells the guest that the (virtual) device is non-coherent (or, more precisely, it does not explicitly

Re: [RFC/RFT PATCH 0/3] arm64: KVM: work around incoherency with uncached guest mappings

2015-03-04 Thread Paolo Bonzini
On 04/03/2015 15:29, Catalin Marinas wrote: I disagree it is 100% a host-side issue. It is a host-side issue _if_ the host tells the guest that the (virtual) device is non-coherent (or, more precisely, it does not explicitly tell the guest that the device is coherent). If the guest thinks

Re: [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine type none

2015-03-04 Thread Eduardo Habkost
On Tue, Mar 03, 2015 at 11:55:24AM +0100, Michael Mueller wrote: On Mon, 02 Mar 2015 17:57:01 +0100 Andreas Färber afaer...@suse.de wrote: Am 02.03.2015 um 17:43 schrieb Michael Mueller: On Mon, 02 Mar 2015 14:57:21 +0100 Andreas Färber afaer...@suse.de wrote: int

Re: [PATCH 3.14 58/73] KVM: MIPS: Dont leak FPU/DSP to guest

2015-03-04 Thread Greg Kroah-Hartman
On Wed, Mar 04, 2015 at 08:10:40AM +, James Hogan wrote: Hi Greg, On Tue, Mar 03, 2015 at 10:13:26PM -0800, Greg Kroah-Hartman wrote: 3.14-stable review patch. If anyone has any objections, please let me know. -- From: James Hogan james.ho...@imgtec.com

Multicast, macvtap, bridge

2015-03-04 Thread Hoggins!
Hello list, I'm trying to have guests communicate with each other on multicast. I don't know where to look to enable this, and if its possible. My guests communicate normally with each other on their bridged (macvtap) interface on unicast, but I cannot seem to be able to do it with multicast.

[PATCH 4/5] vfio-pci: Move idle devices to D3hot power state

2015-03-04 Thread Alex Williamson
We can save some power by putting devices that are bound to vfio-pci but not in use by the user in the D3hot power state. Devices get woken into D0 when opened by the user. Resets return the device to D0, so we need to re-apply the low power state after a bus reset. It's tempting to try to use

[PATCH 1/5] vfio-pci: Allow PCI IDs to be specified as module options

2015-03-04 Thread Alex Williamson
This copies the same support from pci-stub for exactly the same purpose, enabling a set of PCI IDs to be automatically added to the driver's dynamic ID table at module load time. The code here is pretty simple and both vfio-pci and pci-stub are fairly unique in being meta drivers, capable of

[PATCH 3/5] vfio-pci: Remove warning if try-reset fails

2015-03-04 Thread Alex Williamson
As indicated in the comment, this is not entirely uncommon and causes user concern for no reason. Signed-off-by: Alex Williamson alex.william...@redhat.com --- drivers/vfio/pci/vfio_pci.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/vfio/pci/vfio_pci.c

[PATCH 5/5] vfio-pci: Add VGA arbiter client

2015-03-04 Thread Alex Williamson
If VFIO VGA access is disabled for the user, either by CONFIG option or module parameter, we can often opt-out of VGA arbitration. We can do this when PCI bridge control of VGA routing is possible. This means that we must have a parent bridge and there must only be a single VGA device below that

[PATCH 0/5] vfio-pci: Misc enhancements

2015-03-04 Thread Alex Williamson
Each of these patches stands on it's own, but they all touch the same file and therefore build on each other to some extent. The first patch allows vfio-pci to accept a list of IDs as a module parameter, exactly like pci-stub. This is really useful to get vfio-pci bound to devices that are

[PATCH 2/5] vfio-pci: Add module option to disable VGA region access

2015-03-04 Thread Alex Williamson
Add a module option so that we don't require a CONFIG change and kernel rebuild to disable VGA support. Not only can VGA support be troublesome in itself, but by disabling it we can reduce the impact to host devices by doing a VGA arbitration opt-out. Signed-off-by: Alex Williamson

Re: [PATCH 1/5] vfio-pci: Allow PCI IDs to be specified as module options

2015-03-04 Thread Bandan Das
Hi Alex, Alex Williamson alex.william...@redhat.com writes: ... + if (fields 2) { + pr_warn(vfio-pci: invalid id string \%s\\n, id); + continue; + } + + pr_info(vfio-pci: add %04X:%04X sub=%04X:%04X

Re: [PATCH 1/5] vfio-pci: Allow PCI IDs to be specified as module options

2015-03-04 Thread Alex Williamson
On Wed, 2015-03-04 at 15:49 -0500, Bandan Das wrote: Hi Alex, Alex Williamson alex.william...@redhat.com writes: ... + if (fields 2) { + pr_warn(vfio-pci: invalid id string \%s\\n, id); + continue; + } + +

Re: [PATCH 1/5] vfio-pci: Allow PCI IDs to be specified as module options

2015-03-04 Thread Bandan Das
Alex Williamson alex.william...@redhat.com writes: On Wed, 2015-03-04 at 15:49 -0500, Bandan Das wrote: Hi Alex, Alex Williamson alex.william...@redhat.com writes: ... + if (fields 2) { + pr_warn(vfio-pci: invalid id string \%s\\n, id); +

Re: [patch -rt 1/2] KVM: use simple waitqueue for vcpu-wq

2015-03-04 Thread Marcelo Tosatti
On Thu, Feb 26, 2015 at 09:23:57PM -0300, Marcelo Tosatti wrote: On Tue, Feb 17, 2015 at 06:44:19PM +0100, Sebastian Andrzej Siewior wrote: * Peter Zijlstra | 2015-01-21 16:07:16 [+0100]: On Tue, Jan 20, 2015 at 01:16:13PM -0500, Steven Rostedt wrote: I'm actually wondering if we should

Re: [PATCH v2] KVM: vmx: Set msr bitmap correctly if vcpu is in guest mode

2015-03-04 Thread Wincy Van
On Wed, Mar 4, 2015 at 11:58 PM, Bandan Das b...@redhat.com wrote: Hi Wincy, Wincy Van fanwenyi0...@gmail.com writes: In commit 3af18d9c5fe9 (KVM: nVMX: Prepare for using hardware MSR bitmap), we are setting MSR_BITMAP in prepare_vmcs02 if we should use hardware. This is not enough since

Re: [GIT PULL 0/5] KVM: s390: Fixups for changes in merge window for 4.0

2015-03-04 Thread Marcelo Tosatti
On Wed, Mar 04, 2015 at 12:41:49PM +0100, Christian Borntraeger wrote: Paolo, Marcelo, here is a pull request for kvm/master targetting 4.0. It is based on 4.0-rc1 as I want all patches in an upcoming pull request against kvm/next as well to avoid nasty merge conflicts with other changes

Re: [PATCH] Revert target-ppc: Create versionless CPU class per family if KVM

2015-03-04 Thread Alexey Kardashevskiy
On 03/05/2015 01:55 AM, Andreas Färber wrote: Am 03.03.2015 um 23:14 schrieb Alexey Kardashevskiy: On 03/04/2015 07:43 AM, Alexander Graf wrote: On 03.03.15 01:42, Alexey Kardashevskiy wrote: On 03/03/2015 12:51 AM, Alexander Graf wrote: On 02.03.15 14:42, Andreas Färber wrote: Am

Re: [patch -rt 1/2] KVM: use simple waitqueue for vcpu-wq

2015-03-04 Thread Sebastian Andrzej Siewior
On 03/05/2015 02:09 AM, Marcelo Tosatti wrote: Can you please include the series? Thanks Sebastian? I will pick it up, don't worry. I think I do my -RT day tomorrow. Sebastian -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [PATCH 1/5] vfio-pci: Allow PCI IDs to be specified as module options

2015-03-04 Thread Alex Williamson
On Wed, 2015-03-04 at 17:32 -0500, Bandan Das wrote: Alex Williamson alex.william...@redhat.com writes: On Wed, 2015-03-04 at 15:49 -0500, Bandan Das wrote: Hi Alex, Alex Williamson alex.william...@redhat.com writes: ... +if (fields 2) { +

Re: virtio balloon: do not call blocking ops when !TASK_RUNNING

2015-03-04 Thread Rusty Russell
Michael S. Tsirkin m...@redhat.com writes: On Mon, Mar 02, 2015 at 10:37:26AM +1030, Rusty Russell wrote: Thomas Huth th...@linux.vnet.ibm.com writes: On Thu, 26 Feb 2015 11:50:42 +1030 Rusty Russell ru...@rustcorp.com.au wrote: Thomas Huth th...@linux.vnet.ibm.com writes: Hi all,

[PATCH 3.14 28/73] MIPS: KVM: Deliver guest interrupts after local_irq_disable()

2015-03-04 Thread Greg Kroah-Hartman
3.14-stable review patch. If anyone has any objections, please let me know. -- From: James Hogan james.ho...@imgtec.com commit 044f0f03eca0110e1835b2ea038a484b93950328 upstream. When about to run the guest, deliver guest interrupts after disabling host interrupts. This should

Re: [PATCH 3.14 58/73] KVM: MIPS: Dont leak FPU/DSP to guest

2015-03-04 Thread James Hogan
Hi Greg, On Tue, Mar 03, 2015 at 10:13:26PM -0800, Greg Kroah-Hartman wrote: 3.14-stable review patch. If anyone has any objections, please let me know. -- From: James Hogan james.ho...@imgtec.com commit f798217dfd038af981a18bbe4bc57027a08bb182 upstream. The FPU and

[PATCH 3.10 43/53] KVM: MIPS: Dont leak FPU/DSP to guest

2015-03-04 Thread Greg Kroah-Hartman
3.10-stable review patch. If anyone has any objections, please let me know. -- From: James Hogan james.ho...@imgtec.com commit f798217dfd038af981a18bbe4bc57027a08bb182 upstream. The FPU and DSP are enabled via the CP0 Status CU1 and MX bits by kvm_mips_set_c0_status() on a

Re: virtio balloon: do not call blocking ops when !TASK_RUNNING

2015-03-04 Thread Michael S. Tsirkin
On Wed, Mar 04, 2015 at 04:44:54PM +1030, Rusty Russell wrote: Michael S. Tsirkin m...@redhat.com writes: On Mon, Mar 02, 2015 at 10:37:26AM +1030, Rusty Russell wrote: Thomas Huth th...@linux.vnet.ibm.com writes: On Thu, 26 Feb 2015 11:50:42 +1030 Rusty Russell ru...@rustcorp.com.au

Re: [Qemu-devel] [PATCH v3 14/16] target-s390x: Extend QMP command query-cpu-definitions

2015-03-04 Thread Michael Mueller
On Mon, 2 Mar 2015 16:11:00 -0300 Eduardo Habkost ehabk...@redhat.com wrote: On Mon, Mar 02, 2015 at 01:44:06PM +0100, Michael Mueller wrote: This patch implements the QMP command 'query-cpu-definitions' in the S390 context. The command returns a list of cpu model names in the current host

[PATCH v9 5/5] KVM: arm/arm64: add irqfd support

2015-03-04 Thread Eric Auger
This patch enables irqfd on arm/arm64. Both irqfd and resamplefd are supported. Injection is implemented in vgic.c without routing. This patch enables CONFIG_HAVE_KVM_EVENTFD and CONFIG_HAVE_KVM_IRQFD. KVM_CAP_IRQFD is now advertised. KVM_CAP_IRQFD_RESAMPLE capability automatically is

[PATCH v9 3/5] KVM: arm/arm64: implement kvm_arch_intc_initialized

2015-03-04 Thread Eric Auger
On arm/arm64 the VGIC is dynamically instantiated and it is useful to expose its state, especially for irqfd setup. This patch defines __KVM_HAVE_ARCH_INTC_INITIALIZED and implements kvm_arch_intc_initialized. Signed-off-by: Eric Auger eric.au...@linaro.org Acked-by: Christoffer Dall

[PATCH 3.10 20/53] MIPS: KVM: Deliver guest interrupts after local_irq_disable()

2015-03-04 Thread Greg Kroah-Hartman
3.10-stable review patch. If anyone has any objections, please let me know. -- From: James Hogan james.ho...@imgtec.com commit 044f0f03eca0110e1835b2ea038a484b93950328 upstream. When about to run the guest, deliver guest interrupts after disabling host interrupts. This should

[PATCH v9 0/5] irqfd support for arm/arm64

2015-03-04 Thread Eric Auger
This patch series enables irqfd on arm and arm64. Irqfd framework enables to inject a virtual IRQ into a guest upon an eventfd trigger. User-side uses KVM_IRQFD VM ioctl to provide KVM with a kvm_irqfd struct that associates a VM, an eventfd, a virtual IRQ number (aka. the gsi). When an actor

[PATCH v9 1/5] KVM: arm/arm64: unset CONFIG_HAVE_KVM_IRQCHIP

2015-03-04 Thread Eric Auger
CONFIG_HAVE_KVM_IRQCHIP is needed to support IRQ routing (along with irq_comm.c and irqchip.c usage). This is not the case for arm/arm64 currently. This patch unsets the flag for both arm and arm64. Signed-off-by: Eric Auger eric.au...@linaro.org Reviewed-by: Andre Przywara

[PATCH v9 2/5] KVM: introduce kvm_arch_intc_initialized and use it in irqfd

2015-03-04 Thread Eric Auger
Introduce __KVM_HAVE_ARCH_INTC_INITIALIZED define and associated kvm_arch_intc_initialized function. This latter allows to test whether the virtual interrupt controller is initialized and ready to accept virtual IRQ injection. On some architectures, the virtual interrupt controller is dynamically

[PATCH v9 4/5] KVM: arm/arm64: remove coarse grain dist locking at kvm_vgic_sync_hwstate

2015-03-04 Thread Eric Auger
To prepare for irqfd addition, coarse grain locking is removed at kvm_vgic_sync_hwstate level and finer grain locking is introduced in vgic_process_maintenance only. Signed-off-by: Eric Auger eric.au...@linaro.org Acked-by: Christoffer Dall christoffer.d...@linaro.org --- virt/kvm/arm/vgic.c |

[GIT PULL 2/5] KVM: s390/cpacf: Fix kernel bug under z/VM

2015-03-04 Thread Christian Borntraeger
Under z/VM PQAP might trigger an operation exception if no crypto cards are defined via APVIRTUAL or APDEDICATED. [ 386.098666] Kernel BUG at 00135c56 [verbose debug info unavailable] [ 386.098693] illegal operation: 0001 ilc:2 [#1] SMP [...] [ 386.098751] Krnl PSW : 0704c0018000

[GIT PULL 4/5] KVM: s390: include guest facilities in kvm facility test

2015-03-04 Thread Christian Borntraeger
From: Michael Mueller m...@linux.vnet.ibm.com Most facility related decisions in KVM have to take into account: - the facilities offered by the underlying run container (LPAR/VM) - the facilities supported by the KVM code itself - the facilities requested by a guest VM This patch adds the KVM

[GIT PULL 3/5] KVM: s390: fix in memory copy of facility lists

2015-03-04 Thread Christian Borntraeger
From: Michael Mueller m...@linux.vnet.ibm.com The facility lists were not fully copied. Signed-off-by: Michael Mueller m...@linux.vnet.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/kvm/kvm-s390.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[GIT PULL 5/5] KVM: s390: non-LPAR case obsolete during facilities mask init

2015-03-04 Thread Christian Borntraeger
From: Michael Mueller m...@linux.vnet.ibm.com With patch include guest facilities in kvm facility test it is no longer necessary to have special handling for the non-LPAR case. Signed-off-by: Michael Mueller m...@linux.vnet.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com ---

[GIT PULL 0/5] KVM: s390: Fixups for changes in merge window for 4.0

2015-03-04 Thread Christian Borntraeger
Paolo, Marcelo, here is a pull request for kvm/master targetting 4.0. It is based on 4.0-rc1 as I want all patches in an upcoming pull request against kvm/next as well to avoid nasty merge conflicts with other changes that we have pending. So my next pull request for kvm/next will be based on

[GIT PULL 1/5] KVM: s390/cpacf: Enable key wrapping by default

2015-03-04 Thread Christian Borntraeger
From: Tony Krowiak akrow...@linux.vnet.ibm.com z/VM and LPAR enable key wrapping by default, lets do the same on KVM. Signed-off-by: Tony Krowiak akrow...@linux.vnet.ibm.com Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com --- arch/s390/kvm/kvm-s390.c | 10 +++--- 1 file changed,

Re: [RFC/RFT PATCH 0/3] arm64: KVM: work around incoherency with uncached guest mappings

2015-03-04 Thread Catalin Marinas
(please try to avoid top-posting) On Mon, Mar 02, 2015 at 06:20:19PM -0800, Mario Smarduch wrote: On 03/02/2015 08:31 AM, Christoffer Dall wrote: However, my concern with these patches are on two points: 1. It's not a fix-all. We still have the case where the guest expects the behavior

[GIT PULL] KVM fixes for 4.0-rc2

2015-03-04 Thread Marcelo Tosatti
Linus, Please pull from git://git.kernel.org/pub/scm/virt/kvm/kvm.git master To receive the following KVM bug fixes, including a SVM interrupt injection regression fix, MIPS and ARM bug fixes. James Hogan (1): KVM: MIPS: Fix trace event to save PC directly Jan Kiszka (1): ARM:

Re: [GIT PULL 0/5] KVM: s390: Fixups for changes in merge window for 4.0

2015-03-04 Thread Christian Borntraeger
Am 04.03.2015 um 12:41 schrieb Christian Borntraeger: Paolo, Marcelo, here is a pull request for kvm/master targetting 4.0. It is based on 4.0-rc1 as I want all patches in an upcoming pull request against kvm/next as well to avoid nasty merge conflicts with other changes that we have

Re: [RFC/RFT PATCH 0/3] arm64: KVM: work around incoherency with uncached guest mappings

2015-03-04 Thread Ard Biesheuvel
On 4 March 2015 at 12:35, Catalin Marinas catalin.mari...@arm.com wrote: (please try to avoid top-posting) On Mon, Mar 02, 2015 at 06:20:19PM -0800, Mario Smarduch wrote: On 03/02/2015 08:31 AM, Christoffer Dall wrote: However, my concern with these patches are on two points: 1. It's not

Re: [v3 24/26] KVM: Update Posted-Interrupts Descriptor when vCPU is blocked

2015-03-04 Thread Marcelo Tosatti
On Mon, Mar 02, 2015 at 01:36:51PM +, Wu, Feng wrote: -Original Message- From: Marcelo Tosatti [mailto:mtosa...@redhat.com] Sent: Friday, February 27, 2015 7:41 AM To: Wu, Feng Cc: t...@linutronix.de; mi...@redhat.com; h...@zytor.com; x...@kernel.org; g...@kernel.org;

Re: [RFC/RFT PATCH 0/3] arm64: KVM: work around incoherency with uncached guest mappings

2015-03-04 Thread Catalin Marinas
On Wed, Mar 04, 2015 at 12:50:57PM +0100, Ard Biesheuvel wrote: On 4 March 2015 at 12:35, Catalin Marinas catalin.mari...@arm.com wrote: On Mon, Mar 02, 2015 at 06:20:19PM -0800, Mario Smarduch wrote: On 03/02/2015 08:31 AM, Christoffer Dall wrote: However, my concern with these patches

[PATCH v2 1/6] target-arm: kvm: save/restore mp state

2015-03-04 Thread Alex Bennée
This adds the saving and restore of the current Multi-Processing state of the machine. While the KVM_GET/SET_MP_STATE API exposes a number of potential states for x86 we only use two for ARM. Either the process is running or not. We then save this state into the cpu_powered TCG state to avoid

[PATCH v2 0/6] QEMU ARM64 Migration Fixes

2015-03-04 Thread Alex Bennée
This is an update to the series I posted last week addressing some of the comments so far. The main changes to this series are: v2 - Save/Restore MP STATE - no longer needs CAP_MP_STATE at start - re-uses cpu-powered_off for storing state (no stream ABI change) - kvm_enabled()

Re: [RFC/RFT PATCH 0/3] arm64: KVM: work around incoherency with uncached guest mappings

2015-03-04 Thread Peter Maydell
On 4 March 2015 at 23:29, Catalin Marinas catalin.mari...@arm.com wrote: I disagree it is 100% a host-side issue. It is a host-side issue _if_ the host tells the guest that the (virtual) device is non-coherent (or, more precisely, it does not explicitly tell the guest that the device is

[PATCH v2 3/6] hw/char: pl011 don't keep setting the IRQ if nothing changed

2015-03-04 Thread Alex Bennée
While observing KVM traces I can see additional IRQ calls on pretty much every MMIO access which is just plain inefficient. Only update the QEMU IRQ level if something has actually changed from last time. Otherwise we may be papering over other failure modes. Signed-off-by: Alex Bennée

Re: [RFC/RFT PATCH 0/3] arm64: KVM: work around incoherency with uncached guest mappings

2015-03-04 Thread Catalin Marinas
On Wed, Mar 04, 2015 at 03:12:12PM +0100, Andrew Jones wrote: On Wed, Mar 04, 2015 at 01:43:02PM +0100, Ard Biesheuvel wrote: On 4 March 2015 at 13:29, Catalin Marinas catalin.mari...@arm.com wrote: On Wed, Mar 04, 2015 at 12:50:57PM +0100, Ard Biesheuvel wrote: I think we have

[PATCH v2 5/6] target-arm: kvm64 fix save/restore of SPSR regs

2015-03-04 Thread Alex Bennée
From: Christoffer Dall christoffer.d...@linaro.org The current code was negatively indexing the cpu state array and not synchronizing banked spsr register state with the current mode's spsr state, causing occasional failures with migration. Some munging is done to take care of the aarch64

[PATCH v2 2/6] hw/intc: arm_gic_kvm.c restore config first

2015-03-04 Thread Alex Bennée
As there is logic to deal with the difference between edge and level triggered interrupts in the kernel we must ensure it knows the configuration of the IRQs before we restore the pending state. Signed-off-by: Alex Bennée alex.ben...@linaro.org Acked-by: Christoffer Dall

[PATCH v2 6/6] target-arm: cpu.h document why env-spsr exists

2015-03-04 Thread Alex Bennée
I was getting very confused about the duplication of state. Perhaps we should just get rid of env-spsr and use helpers that understand the banking? Signed-off-by: Alex Bennée alex.ben...@linaro.org diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 11845a6..d7fd13f 100644 ---

[PATCH v2 4/6] target-arm: kvm64 sync FP register state

2015-03-04 Thread Alex Bennée
For migration to work we need to sync all of the register state. This is especially noticeable when GCC starts using FP registers as spill registers even with integer programs. Signed-off-by: Alex Bennée alex.ben...@linaro.org diff --git a/target-arm/kvm64.c b/target-arm/kvm64.c index

Re: [PATCH v2 6/6] target-arm: cpu.h document why env-spsr exists

2015-03-04 Thread Peter Maydell
On 4 March 2015 at 23:35, Alex Bennée alex.ben...@linaro.org wrote: I was getting very confused about the duplication of state. Perhaps we should just get rid of env-spsr and use helpers that understand the banking? Doesn't seem worth changing the current working code to something else that's

Re: [RFC/RFT PATCH 0/3] arm64: KVM: work around incoherency with uncached guest mappings

2015-03-04 Thread Ard Biesheuvel
On 4 March 2015 at 13:29, Catalin Marinas catalin.mari...@arm.com wrote: On Wed, Mar 04, 2015 at 12:50:57PM +0100, Ard Biesheuvel wrote: On 4 March 2015 at 12:35, Catalin Marinas catalin.mari...@arm.com wrote: On Mon, Mar 02, 2015 at 06:20:19PM -0800, Mario Smarduch wrote: On 03/02/2015

Re: [RFC/RFT PATCH 0/3] arm64: KVM: work around incoherency with uncached guest mappings

2015-03-04 Thread Andrew Jones
On Wed, Mar 04, 2015 at 01:43:02PM +0100, Ard Biesheuvel wrote: On 4 March 2015 at 13:29, Catalin Marinas catalin.mari...@arm.com wrote: On Wed, Mar 04, 2015 at 12:50:57PM +0100, Ard Biesheuvel wrote: On 4 March 2015 at 12:35, Catalin Marinas catalin.mari...@arm.com wrote: On Mon, Mar 02,

Re: [PATCH] Revert target-ppc: Create versionless CPU class per family if KVM

2015-03-04 Thread Andreas Färber
Am 03.03.2015 um 23:14 schrieb Alexey Kardashevskiy: On 03/04/2015 07:43 AM, Alexander Graf wrote: On 03.03.15 01:42, Alexey Kardashevskiy wrote: On 03/03/2015 12:51 AM, Alexander Graf wrote: On 02.03.15 14:42, Andreas Färber wrote: Am 02.03.2015 um 14:37 schrieb Alexander Graf: On 01.03.15