;
> > Cc: sta...@vger.kernel.org
> > Fixes: e6fab5442345 ("ARM/arm64: KVM: test properly for a PTE's
> > uncachedness")
> >
>
> That commit is not in a release yet, so no need for cc stable
[...]
But it is cc'd to stable, so unless it is going to be nac
info 0 8b08
> qemu-system-x86-3221 [000] 1090.730041: kvm_inj_exception: #DF (0x0)
> qemu-system-x86-3221 [000] d... 1090.730043: kvm_entry: vcpu 0
> ...
[...]
> I am rather surprised that there is no bug report about this yet, so I
> guess it only happens on some ha
vhost_virtqueue *vq, int bit)
{
- return vq-acked_features (1 bit);
+ return vq-acked_features (1ULL bit);
Erm, wouldn't the high word be just dropped when returning *int*? I think
you need !!(vq-acked_features (1ULL bit)).
Or change the return type to bool.
Ben.
--
Ben Hutchings
guests - seems like a
critical issue.
You can work around this by making macvtap and tun still claim to
support UFO. They continue to support it even if it's not advertised
because the tap features don't reliably get propagated to virtio
devices.
Ben.
--
Ben Hutchings
Experience is directly
they are running with virtio net
devices.
Fixes: 88e0e0e5aa7a (drivers/net: Disable UFO through virtio)
Signed-off-by: Ben Hutchings b...@decadent.org.uk
---
Compile-tested only.
Ben.
drivers/net/macvtap.c | 13 -
drivers/net/tun.c | 19 ---
2 files changed, 16 insertions
On Tue, 2014-11-11 at 17:57 +0200, Michael S. Tsirkin wrote:
On Tue, Nov 11, 2014 at 12:17:26PM +, Ben Hutchings wrote:
On Tue, 2014-11-11 at 10:58 +, Stefan Hajnoczi wrote:
Commit 3d0ad09412ffe00c9afa201d01effdb6023d09b4 (drivers/net: Disable
UFO through virtio) breaks live
| PGSTE_GC_BIT |
--
Ben Hutchings
No political challenge can be met by shopping. - George Monbiot
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
.
--
Ben Hutchings
Beware of programmers who carry screwdrivers. - Leonard Brandwein
signature.asc
Description: This is a digitally signed message part
a
static function in nfnetlink_queue. We need to patch that and its caller, but
not openvswitch.]
Signed-off-by: Ben Hutchings b...@decadent.org.uk
---
On Tue, 2014-04-22 at 19:02 +0100, Zoltan Kiss wrote:
On 22/04/14 16:38, Ben Hutchings wrote:
On Mon, 2014-04-21 at 12:26 +0100, Luis Henriques
wireless network this year.
Ben.
I think disable_ipv4 is absolutely a non-starter.
--
Ben Hutchings
Beware of bugs in the above code;
I have only proved it correct, not tried it. - Donald Knuth
signature.asc
Description: This is a digitally signed message part
On Mon, 2014-02-24 at 19:12 -0500, David Miller wrote:
From: Ben Hutchings b...@decadent.org.uk
Date: Tue, 25 Feb 2014 00:02:00 +
You can run an internal network, or access network, as v6-only with
NAT64 and DNS64 at the border. I believe some mobile networks are doing
flag. I don't know how that flag should be named or described,
though.
Ben.
--
Ben Hutchings
Any sufficiently advanced bug is indistinguishable from a feature.
signature.asc
Description: This is a digitally signed message part
].len = success ?
- VHOST_DMA_DONE_LEN : VHOST_DMA_FAILED_LEN;
- vhost_net_ubuf_put(ubufs);
}
/* Expects to be always run from workqueue - which acts as
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job
On Wed, May 29, 2013 at 05:05:55PM +0200, Stefan Pietsch wrote:
On 19.05.2013 14:32, Gleb Natapov wrote:
On Sun, May 19, 2013 at 02:00:31AM +0100, Ben Hutchings wrote:
Dear KVM maintainers, it appears that there is a gap in x86 emulation,
at least on a 32-bit host. Stefan found this when
.
On Thu, 2013-05-16 at 13:26 +0200, Stefan Pietsch wrote:
On 09.05.2013 20:56, Stefan Pietsch wrote:
On 09.05.2013 03:08, Ben Hutchings wrote:
Please could you test some of the intermediate versions at
http://snapshot.debian.org/package/linux/ to find the first upstream
version where
an implementation for
the ethtool side and they don't look too awful in older versions of ethtool.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe
maintenance scripts still match the old address, anyway. Not
sure about Greg's.)
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list
On Thu, 2013-03-21 at 18:28 +0200, Michael S. Tsirkin wrote:
On Thu, Mar 21, 2013 at 04:23:48PM +, Ben Hutchings wrote:
On Thu, 2013-03-21 at 08:02 +0200, Michael S. Tsirkin wrote:
On Sun, Mar 17, 2013 at 02:29:55PM -0400, David Miller wrote:
From: Michael S. Tsirkin m...@redhat.com
me know.
Ben.
--
Ben Hutchings
Never attribute to conspiracy what can adequately be explained by stupidity.
signature.asc
Description: This is a digitally signed message part
On Thu, 2012-12-06 at 10:13 +0200, Michael S. Tsirkin wrote:
On Wed, Dec 05, 2012 at 08:39:26PM +, Ben Hutchings wrote:
On Mon, 2012-12-03 at 12:58 +0200, Michael S. Tsirkin wrote:
Add RFS support to virtio network device.
Add a new feature flag VIRTIO_NET_F_RFS for this feature
On Thu, 2012-12-06 at 22:29 +0200, Michael S. Tsirkin wrote:
On Thu, Dec 06, 2012 at 08:03:14PM +, Ben Hutchings wrote:
[...]
Since this doesn't seem to be intended to have *any* connection with the
existing core networking feature called RFS, perhaps you could find a
different name
On Thu, 2012-12-06 at 23:01 +0200, Michael S. Tsirkin wrote:
On Thu, Dec 06, 2012 at 08:53:59PM +, Ben Hutchings wrote:
On Thu, 2012-12-06 at 22:29 +0200, Michael S. Tsirkin wrote:
On Thu, Dec 06, 2012 at 08:03:14PM +, Ben Hutchings wrote:
[...]
Since this doesn't seem
vhost_net to do the equivalent of sock_rps_record_flow() -
only without a socket? But in any case, that requires an rxhash, so I
don't see how this is supposed to work.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us
will correspond to one queue-pair
and not one virtio channel.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line
On Sun, 2012-11-18 at 11:13 +0200, Michael S. Tsirkin wrote:
On Sat, Nov 17, 2012 at 12:35:29AM +, Ben Hutchings wrote:
On Tue, 2012-11-13 at 08:40 +0200, Michael S. Tsirkin wrote:
On Mon, Nov 05, 2012 at 11:38:39AM +1030, Rusty Russell wrote:
@@ -924,11 +1032,10 @@ static void
at probe time.
Looks like we can easily support different queues too.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send
= virtnet_get_drvinfo,
.get_link = ethtool_op_get_link,
.get_ringparam = virtnet_get_ringparam,
+ .set_channels = virtnet_set_channels,
+ .get_channels = virtnet_get_channels,
};
static int __init init(void)
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking
is not that likely in practice, but I
don't have the evidence to back that up.
If the filter update latency is high enough that a response can overtake
the filter update, there may be more of a problem.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's
-initialise
structures for 'get' operations.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line unsubscribe kvm
(__hash_table, 16 * 32);
u16 *hash_table = (u16 *)__hash_table;
?
[...]
Could this driver perhaps use:
union hash_table {
DECLARE_BITMAP(bits, 16 * 32);
__le16 words[32];
};
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my
There are now standard functions for dealing with little-endian bit
arrays, so use them instead of our own implementations.
Signed-off-by: Ben Hutchings bhutchi...@solarflare.com
---
Please use this version instead.
Ben.
drivers/net/ethernet/sfc/efx.c|4 ++--
drivers/net/ethernet
On Fri, 2012-05-18 at 17:58 -0300, Marcelo Tosatti wrote:
See individual patches for details.
[...]
These came a little too late for 3.2.18, but I've queued them up now.
Ben.
--
Ben Hutchings
You can't have everything. Where would you put it?
signature.asc
Description: This is a digitally
On Sun, 2012-05-13 at 12:23 +0300, Avi Kivity wrote:
On 05/12/2012 03:35 AM, Ben Hutchings wrote:
On Wed, 2012-05-09 at 16:10 +0300, Avi Kivity wrote:
After a long hiatus, here are a bunch of very delayed fixes for 3.3.5.
Are any of these also applicable to 3.2.y?
Yes, and more
/x86/kvm/x86.c| 19 +--
include/linux/kvm_host.h |7 +++
virt/kvm/iommu.c | 23 +++
virt/kvm/kvm_main.c | 23 ++-
9 files changed, 77 insertions(+), 34 deletions(-)
--
Ben Hutchings
Experience
is dependent on a
VF that's connected to a hardware bridge, it becomes impossible or at
least very disruptive to migrate it to another host that doesn't have a
compatible VF available.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing
the additional 'local' MAC addresses
to a driver-specific sysfs file, but that is obviously not likely to be
acceptable in-tree! So I was interested in this proposal to extend MAC
filtering, but wanted to get the semantics clear.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my
Autofs control device
236 = /dev/mapper/control Device-Mapper control device
+ 237 = /dev/vhost-netHost kernel accelerator for virtio net
[...]
238 != 237. It looks like someone forgot to add loopctrl here.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
On Fri, 2011-12-09 at 16:01 +1030, Rusty Russell wrote:
On Wed, 7 Dec 2011 17:02:04 +, Ben Hutchings bhutchi...@solarflare.com
wrote:
Solarflare controllers (sfc driver) have 8192 perfect filters for
TCP/IPv4 and UDP/IPv4 which can be used for flow steering. (The filters
accelerated RFS can work well without the use of perfect
filtering or hash-based filtering with a very low rate of collisions.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names
On Tue, 2011-12-06 at 15:21 +0800, Jason Wang wrote:
On 12/06/2011 04:09 AM, Ben Hutchings wrote:
On Mon, 2011-12-05 at 16:58 +0800, Jason Wang wrote:
This patch adds a simple flow director to tun/tap device. It is just a
page that contains the hash to queue mapping which could be changed
On Tue, 2011-12-06 at 15:25 +0800, Jason Wang wrote:
On 12/06/2011 04:42 AM, Ben Hutchings wrote:
[...]
This is not a proper implementation of ndo_rx_flow_steer. If you steer
a flow by changing the RSS table this can easily cause packet reordering
in other flows. The filtering should
.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord
Similarly, macvtap chould implement the ethtool {get,set}_rxfh_indir
operations.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from
?
+ */
+ while (unlikely(txq = dev-real_num_tx_queues))
+ txq -= dev-real_num_tx_queues;
+ return txq;
+}
[...]
Don't do this, let XPS handle it.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked
On Wed, 2011-11-30 at 09:34 -0800, Greg Rose wrote:
On 11/29/2011 9:19 AM, Ben Hutchings wrote:
On Tue, 2011-11-29 at 16:35 +, Ben Hutchings wrote:
Maybe I missed something!
[...]
If not, please explain what the new model *is*.
The new model is to incorporate a VEB into the NIC
On Wed, 2011-11-30 at 13:04 -0800, Chris Wright wrote:
* Ben Hutchings (bhutchi...@solarflare.com) wrote:
On Wed, 2011-11-30 at 09:34 -0800, Greg Rose wrote:
On 11/29/2011 9:19 AM, Ben Hutchings wrote:
On Tue, 2011-11-29 at 16:35 +, Ben Hutchings wrote:
Maybe I missed
On Tue, 2011-11-29 at 16:35 +, Ben Hutchings wrote:
On Mon, 2011-11-21 at 09:41 -0800, Greg Rose wrote:
On 11/18/2011 9:40 AM, Ben Hutchings wrote:
[...]
What concerns me is that this seems to be a workaround rather than a fix
for over-use of promiscuous mode, and it changes
On Fri, 2011-11-18 at 08:24 +0200, Sasha Levin wrote:
On Fri, 2011-11-18 at 01:08 +, Ben Hutchings wrote:
On Fri, 2011-11-11 at 18:34 +0530, Krishna Kumar wrote:
Changes for multiqueue virtio_net driver.
[...]
@@ -677,25 +730,35 @@ static struct rtnl_link_stats64 *virtnet
On Fri, 2011-11-18 at 18:18 +0200, Sasha Levin wrote:
On Fri, 2011-11-18 at 15:40 +, Ben Hutchings wrote:
On Fri, 2011-11-18 at 08:24 +0200, Sasha Levin wrote:
On Fri, 2011-11-18 at 01:08 +, Ben Hutchings wrote:
On Fri, 2011-11-11 at 18:34 +0530, Krishna Kumar wrote:
Changes
On Fri, 2011-11-18 at 08:58 -0800, Greg Rose wrote:
On 11/17/2011 4:44 PM, Ben Hutchings wrote:
On Thu, 2011-11-17 at 16:32 -0800, Greg Rose wrote:
On 11/17/2011 4:15 PM, Ben Hutchings wrote:
Sorry to come to this rather late.
On Tue, 2011-11-08 at 23:55 -0800, Roopa Prabhu wrote
those extra addresses.
(No, none of that is upstream - I'm preparing for that now.)
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from
.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord
about an interface in a single message may not be
sustainable.
Also, I'm unclear on why this interface is to be used to set filtering
for the (PF) net device as well as for related VFs. Doesn't that
duplicate the functionality of ndo_set_rx_mode and
ndo_vlan_rx_{add,kill}_vid?
Ben.
--
Ben
] = {
[IFLA_RX_FILTER_VLAN_BITMAP]
}
}
...
}
[...]
Please put the details of both syntax *and semantics* in if_link.h.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note
On Thu, 2011-11-17 at 16:32 -0800, Greg Rose wrote:
On 11/17/2011 4:15 PM, Ben Hutchings wrote:
Sorry to come to this rather late.
On Tue, 2011-11-08 at 23:55 -0800, Roopa Prabhu wrote:
[...]
v2 - v3
- Moved set and get filter ops from rtnl_link_ops to netdev_ops
- Support
and device-tx-index.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message
action is.
Ben.
--
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message
suggested doing this as a general rule. However, I
now think we can do much better with accelerated RFS and automatic XPS
(but the latter is not yet implemented). For virtio_net, accelerated
RFS would effectively push the guest's RFS socket map out to the host.
Ben.
--
Ben Hutchings, Staff
.
+ */
+#define NETIF_F_ZEROCOPY (1 31)
Sorry, bit 31 is taken. You get the job of turning features into a
wider bitmap.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names
On Mon, 2011-05-16 at 12:38 -0700, Shirley Ma wrote:
On Mon, 2011-05-16 at 20:35 +0100, Ben Hutchings wrote:
Sorry, bit 31 is taken. You get the job of turning features into a
wider bitmap.
:) will do it.
Bear in mind that feature masks are manipulated in many different
places
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's
garp_port*garp_port;
-
+ /* mpassthru */
+ struct mpassthru_port *mp_port;
/* class/net/name entry */
struct device dev;
/* space for optional device, statistics, and wireless sysfs groups */
--
Ben Hutchings, Senior Software Engineer, Solarflare
utilize this.
[...]
This information needs to be included in the comment above struct
net_device_ops, not just in the commit message.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note
have you considered an API for changing the header/data split?
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe
@@
+#ifndef __MPASSTHRU_H
+#define __MPASSTHRU_H
+
+#include linux/types.h
+#include linux/if_ether.h
+
+/* ioctl defines */
+#define MPASSTHRU_BINDDEV _IOW('M', 213, int)
+#define MPASSTHRU_UNBINDDEV_IO('M', 214)
[...]
You need to include linux/ioctl.h first!
Ben.
--
Ben Hutchings
This patch is in the wrong position in the sequence. It needs to be
applied after mpassthru.c is created, not before.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note
they are
acquired in the opposite order.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send
MPASSTHRU_UNBINDDEV_IO('M', 214)
+#define MPASSTHRU_SET_MEM_LOCKED _IOW('M', 215, unsigned long)
+#define MPASSTHRU_GET_MEM_LOCKED_NEED_IOR('M', 216, unsigned long)
[...]
These will need compat handling. You can avoid that by defining them to
use a parameter type of u32 or u64.
Ben.
--
Ben
the
documentation for it), it is a feature that Microsoft requested from
hardware vendors for use in Hyper-V. As a result, the SFC9000 family
and presumably other controllers also implement something similar.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking
correspond to drivers and
interfaces correspond to device classes in the LDM. To avoid
confusion, I think the vbus terminology should be made consistent with
LDM. And certainly these should not both be called simply type in the
configfs/sysfs interface.
Ben.
--
Ben Hutchings, Senior Software
70 matches
Mail list logo
