Re: [PATCH v3 -next 1/9] DMA, CMA: fix possible memory leak

the decision to him and will learn a lesson from him and will follow the decision from now on. Thanks. Acked-by: Minchan Kim minc...@kernel.org Acked-by: Zhang Yanfei zhangyan...@cn.fujitsu.com Reviewed-by: Michal Nazarewicz min...@mina86.com Reviewed-by: Aneesh Kumar K.V aneesh.ku

Re: [PATCH v3 -next 1/9] DMA, CMA: fix possible memory leak

the decision to him and will learn a lesson from him and will follow the decision from now on. Thanks. Acked-by: Minchan Kim minc...@kernel.org Acked-by: Zhang Yanfei zhangyan...@cn.fujitsu.com Reviewed-by: Michal Nazarewicz min...@mina86.com Reviewed-by: Aneesh Kumar K.V aneesh.ku

Re: [PATCH v2 05/10] DMA, CMA: support arbitrary bitmap granularity

+ 1; } pr_debug(%s(): returned %p\n, __func__, page); -- 1.7.9.5 -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 05/10] DMA, CMA: support arbitrary bitmap granularity

On Thu, Jun 12, 2014 at 03:43:55PM +0900, Joonsoo Kim wrote: On Thu, Jun 12, 2014 at 03:06:10PM +0900, Minchan Kim wrote: On Thu, Jun 12, 2014 at 12:21:42PM +0900, Joonsoo Kim wrote: ppc kvm's cma region management requires arbitrary bitmap granularity, since they want to reserve very

Re: [PATCH v2 05/10] DMA, CMA: support arbitrary bitmap granularity

arbitrary bitmap granularity for following generalization. Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com Acked-by: Minchan Kim minc...@kernel.org Just a nit below. diff --git a/drivers/base/dma-contiguous.c b/drivers/base/dma-contiguous.c index bc4c171..9bc9340 100644 --- a/drivers/base/dma

Re: [PATCH v2 06/10] CMA: generalize CMA reserved area management functionality

renaming. Acked-by: Michal Nazarewicz min...@mina86.com Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com Acutally, I want to remove bool return of cma_release but it's not a out of scope in this patchset. Acked-by: Minchan Kim minc...@kernel.org diff --git a/drivers/base/Kconfig b/drivers

Re: [PATCH v2 08/10] mm, cma: clean-up cma allocation error path

On Thu, Jun 12, 2014 at 12:21:45PM +0900, Joonsoo Kim wrote: We can remove one call sites for clear_cma_bitmap() if we first call it before checking error number. Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com Acked-by: Minchan Kim minc...@kernel.org -- Kind regards, Minchan Kim

Re: [PATCH v2 09/10] mm, cma: move output param to the end of param list

-- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 10/10] mm, cma: use spinlock instead of mutex

...@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: a href=mailto:d...@kvack.org; em...@kvack.org /a -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v2 05/10] DMA, CMA: support arbitrary bitmap granularity

+ 1; } pr_debug(%s(): returned %p\n, __func__, page); -- 1.7.9.5 -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm-ppc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH v2 05/10] DMA, CMA: support arbitrary bitmap granularity

On Thu, Jun 12, 2014 at 03:43:55PM +0900, Joonsoo Kim wrote: On Thu, Jun 12, 2014 at 03:06:10PM +0900, Minchan Kim wrote: On Thu, Jun 12, 2014 at 12:21:42PM +0900, Joonsoo Kim wrote: ppc kvm's cma region management requires arbitrary bitmap granularity, since they want to reserve very

Re: [PATCH v2 05/10] DMA, CMA: support arbitrary bitmap granularity

arbitrary bitmap granularity for following generalization. Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com Acked-by: Minchan Kim minc...@kernel.org Just a nit below. diff --git a/drivers/base/dma-contiguous.c b/drivers/base/dma-contiguous.c index bc4c171..9bc9340 100644 --- a/drivers/base/dma

Re: [PATCH v2 06/10] CMA: generalize CMA reserved area management functionality

renaming. Acked-by: Michal Nazarewicz min...@mina86.com Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com Acutally, I want to remove bool return of cma_release but it's not a out of scope in this patchset. Acked-by: Minchan Kim minc...@kernel.org diff --git a/drivers/base/Kconfig b/drivers

Re: [PATCH v2 08/10] mm, cma: clean-up cma allocation error path

On Thu, Jun 12, 2014 at 12:21:45PM +0900, Joonsoo Kim wrote: We can remove one call sites for clear_cma_bitmap() if we first call it before checking error number. Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com Acked-by: Minchan Kim minc...@kernel.org -- Kind regards, Minchan Kim

Re: [PATCH v2 09/10] mm, cma: move output param to the end of param list

-- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm-ppc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 10/10] mm, cma: use spinlock instead of mutex

...@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: a href=mailto:d...@kvack.org; em...@kvack.org /a -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm-ppc in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH v2 01/10] DMA, CMA: clean-up log message

to reserve %ld MiB\n, + __func__, (unsigned long)size / SZ_1M); return ret; } -- 1.7.9.5 -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v2 02/10] DMA, CMA: fix possible memory leak

); + return -EINVAL; } static struct cma cma_areas[MAX_CMA_AREAS]; -- 1.7.9.5 -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH v2 03/10] DMA, CMA: separate core cma management codes from DMA APIs

, struct page *pages, + int count) +{ + struct cma *cma = dev_get_cma_area(dev); + + return __dma_release_from_contiguous(cma, pages, count); +} -- 1.7.9.5 -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm

Re: [PATCH v2 04/10] DMA, CMA: support alignment constraint on cma region

); if (ret) return ret; -- 1.7.9.5 -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 01/10] DMA, CMA: clean-up log message

to reserve %ld MiB\n, + __func__, (unsigned long)size / SZ_1M); return ret; } -- 1.7.9.5 -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm-ppc in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v2 02/10] DMA, CMA: fix possible memory leak

); + return -EINVAL; } static struct cma cma_areas[MAX_CMA_AREAS]; -- 1.7.9.5 -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm-ppc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH v2 03/10] DMA, CMA: separate core cma management codes from DMA APIs

, struct page *pages, + int count) +{ + struct cma *cma = dev_get_cma_area(dev); + + return __dma_release_from_contiguous(cma, pages, count); +} -- 1.7.9.5 -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm-ppc

Re: [PATCH v2 04/10] DMA, CMA: support alignment constraint on cma region

); if (ret) return ret; -- 1.7.9.5 -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm-ppc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mm: compaction: Correct the nr_strict_isolated check for CMA

Prisk li...@prisktech.co.nz Acked-by: Minchan Kim minc...@kernel.org -- Kind Regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/9] mm: compaction: Acquire the zone-lru_lock as late as possible

=mailto:d...@kvack.org; em...@kvack.org /a -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/9] mm: compaction: Abort compaction loop if lock is contended or run too long

...@fusionio.com Signed-off-by: Mel Gorman mgor...@suse.de Acked-by: Rik van Riel r...@redhat.com Acked-by: Minchan Kim minc...@kernel.org -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 6/9] mm: compaction: Acquire the zone-lock as late as possible

. In the event there are no free pages in the pageblock then the lock will not be acquired at all which reduces contention on zone-lock. Signed-off-by: Mel Gorman mgor...@suse.de Acked-by: Rik van Riel r...@redhat.com Acked-by: Minchan Kim minc...@kernel.org -- Kind regards, Minchan Kim

Re: [PATCH 6/9] mm: compaction: Acquire the zone-lock as late as possible

but that is a marginal corner-case. Signed-off-by: Mel Gorman mgor...@suse.de Acked-by: Minchan Kim minc...@kernel.org -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 7/9] Revert mm: have order 0 compaction start off where it left

...@suse.de Acked-by: Rik van Riel r...@redhat.com Acked-by: Minchan Kim minc...@kernel.org -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 5/9] mm: compaction: Acquire the zone-lru_lock as late as possible

On Tue, Sep 25, 2012 at 08:51:05AM +0100, Mel Gorman wrote: On Tue, Sep 25, 2012 at 04:05:17PM +0900, Minchan Kim wrote: Hi Mel, I have a question below. On Fri, Sep 21, 2012 at 11:46:19AM +0100, Mel Gorman wrote: Compactions migrate scanner acquires the zone-lru_lock when scanning

Re: [PATCH 5/9] mm: compaction: Acquire the zone-lru_lock as late as possible

On Tue, Sep 25, 2012 at 02:39:31PM -0700, Andrew Morton wrote: On Tue, 25 Sep 2012 17:13:27 +0900 Minchan Kim minc...@kernel.org wrote: I see. To me, your saying is better than current comment. I hope comment could be more explicit. diff --git a/mm/compaction.c b/mm/compaction.c

Re: [PATCH 8/9] mm: compaction: Cache if a pageblock was scanned and no pages were isolated

: a href=mailto:d...@kvack.org; em...@kvack.org /a -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

On Thu, Dec 22, 2011 at 10:45:06AM -0500, Vivek Goyal wrote: On Thu, Dec 22, 2011 at 10:05:38AM +0900, Minchan Kim wrote: [..] May be using deadline or noop in guest is better to benchmark against PCI-E based flash. Good suggestion. I tested it by deadline on guest side

Re: [PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

On Thu, Dec 22, 2011 at 12:57:40PM +, Stefan Hajnoczi wrote: On Wed, Dec 21, 2011 at 1:00 AM, Minchan Kim minc...@kernel.org wrote: This patch is follow-up of Christohp Hellwig's work [RFC: -make_request support for virtio-blk]. http://thread.gmane.org/gmane.linux.kernel/1199763

Re: [PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

Hi Sasha! On Wed, Dec 21, 2011 at 10:28:52AM +0200, Sasha Levin wrote: On Wed, 2011-12-21 at 10:00 +0900, Minchan Kim wrote: This patch is follow-up of Christohp Hellwig's work [RFC: -make_request support for virtio-blk]. http://thread.gmane.org/gmane.linux.kernel/1199763 Quote from

Re: [PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

Hi Vivek, On Wed, Dec 21, 2011 at 02:11:17PM -0500, Vivek Goyal wrote: On Wed, Dec 21, 2011 at 10:00:48AM +0900, Minchan Kim wrote: This patch is follow-up of Christohp Hellwig's work [RFC: -make_request support for virtio-blk]. http://thread.gmane.org/gmane.linux.kernel/1199763 Quote

[PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

This patch enhances ramdom I/O performance compared to request-based I/O path. It's still RFC so welcome to any comment and review. Christoph Hellwig (3): block: add bio_map_sg virtio: support unlocked queue kick virtio-blk: remove the unused list of pending requests Minchan Kim (3): virtio-blk

[PATCH 1/6] block: add bio_map_sg

From: Christoph Hellwig h...@lst.de Add a helper to map a bio to a scatterlist, modelled after blk_rq_map_sg. This helper is useful for any driver that wants to create a scatterlist from its -make_request method. Signed-off-by: Christoph Hellwig h...@lst.de Signed-off-by: Minchan Kim minc

[PATCH 3/6] virtio-blk: remove the unused list of pending requests

From: Christoph Hellwig h...@lst.de Signed-off-by: Christoph Hellwig h...@lst.de Signed-off-by: Minchan Kim minc...@redhat.com --- drivers/block/virtio_blk.c | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c

[PATCH 4/6] virtio-blk: implement -make_request

ioctl but it's just used for ioctl, not file system. Signed-off-by: Christoph Hellwig h...@lst.de Signed-off-by: Minchan Kim minc...@redhat.com --- drivers/block/virtio_blk.c | 303 1 files changed, 247 insertions(+), 56 deletions(-) diff --git

[PATCH 2/6] virtio: support unlocked queue kick

or corrections for the commit message are welcome. Signed-off-by: Christoph Hellwig h...@lst.de Signed-off-by: Minchan Kim minc...@redhat.com --- drivers/virtio/virtio_ring.c | 33 ++--- include/linux/virtio.h | 21 + 2 files changed, 47

[PATCH 5/6] virtio-blk: Support batch I/O for enhancing sequential IO

-contiguous I/O issue or pass 1ms, batch queue would be drained. Signed-off-by: Minchan Kim minc...@redhat.com --- drivers/block/virtio_blk.c | 366 +++- 1 files changed, 331 insertions(+), 35 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block

[PATCH 6/6] virtio-blk: Emulate Flush/FUA

This patch emulates flush/fua on virtio-blk and pass xfstest on ext4. But it needs more reviews. Signed-off-by: Minchan Kim minc...@redhat.com --- drivers/block/virtio_blk.c | 89 ++- 1 files changed, 86 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 0/6][RFC] virtio-blk: Change I/O path from request to BIO

Hi Rusty, On Wed, Dec 21, 2011 at 03:38:03PM +1030, Rusty Russell wrote: On Wed, 21 Dec 2011 10:00:48 +0900, Minchan Kim minc...@kernel.org wrote: This patch is follow-up of Christohp Hellwig's work [RFC: -make_request support for virtio-blk]. http://thread.gmane.org/gmane.linux.kernel

Re: [PATCH 2/5] virtio: support unlocked queue kick

be exported for using other modules. -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Fix refcounting in hugetlbfs quota handling

. -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] virtio_balloon: disable oom killer when fill balloon

it could make unnecessary oom kill. BTW, I can't understand why we need to handle virtio by special. Could you explain it in detail? :) -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH v2] virtio_balloon: disable oom killer when fill balloon

On Tue, Apr 26, 2011 at 6:39 PM, Dave Young hidave.darks...@gmail.com wrote: On Tue, Apr 26, 2011 at 5:28 PM, Minchan Kim minchan@gmail.com wrote: Please resend this with [2/2] to linux-mm. On Tue, Apr 26, 2011 at 5:59 PM, Dave Young hidave.darks...@gmail.com wrote: When memory pressure

Re: [PATCH 3/3] Provide control over unmapped pages (v4)

On Mon, Feb 14, 2011 at 2:33 AM, Balbir Singh bal...@linux.vnet.ibm.com wrote: * MinChan Kim minchan@gmail.com [2011-02-10 14:41:44]: I don't know why the part of message is deleted only when I send you. Maybe it's gmail bug. I hope mail sending is successful in this turn. :) On Thu

Re: [PATCH 3/3] Provide control over unmapped pages (v4)

Sorry for late response. On Fri, Jan 28, 2011 at 8:18 PM, Balbir Singh bal...@linux.vnet.ibm.com wrote: * MinChan Kim minchan@gmail.com [2011-01-28 16:24:19]: But the assumption for LRU order to change happens only if the page cannot be successfully freed, which means it is in some

Re: [PATCH 3/3] Provide control over unmapped pages (v4)

I don't know why the part of message is deleted only when I send you. Maybe it's gmail bug. I hope mail sending is successful in this turn. :) On Thu, Feb 10, 2011 at 2:33 PM, Minchan Kim minchan@gmail.com wrote: Sorry for late response. On Fri, Jan 28, 2011 at 8:18 PM, Balbir Singh bal

Re: [PATCH 3/3] Provide control over unmapped pages (v4)

On Fri, Jan 28, 2011 at 11:56 AM, Balbir Singh bal...@linux.vnet.ibm.com wrote: On Thu, Jan 27, 2011 at 4:42 AM, Minchan Kim minchan@gmail.com wrote: [snip] index 7b56473..2ac8549 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1660,6 +1660,9 @@ zonelist_scan

Re: [PATCH 3/3] Provide control over unmapped pages (v4)

On Fri, Jan 28, 2011 at 3:48 PM, Balbir Singh bal...@linux.vnet.ibm.com wrote: * MinChan Kim minchan@gmail.com [2011-01-28 14:44:50]: On Fri, Jan 28, 2011 at 11:56 AM, Balbir Singh bal...@linux.vnet.ibm.com wrote: On Thu, Jan 27, 2011 at 4:42 AM, Minchan Kim minchan@gmail.com wrote

Re: [PATCH 3/3] Provide control over unmapped pages (v4)

by reclaim_unmapped_pages. It can make confusing LRU order so working set can be evicted. zone_reclaim is used by only NUMA until now but you are opening it in the world. I think it would be a good feature in embedded system, too. I hope we care of working set eviction problem. -- Kind regards, Minchan Kim

Re: [PATCH 3/3] Provide control over unmapped pages (v2)

On Thu, Dec 23, 2010 at 5:33 PM, Balbir Singh bal...@linux.vnet.ibm.com wrote: * MinChan Kim minchan@gmail.com [2010-12-14 20:02:45]: +                       if (should_reclaim_unmapped_pages(zone)) +                               wakeup_kswapd(zone, order); I think we can put

Re: [PATCH 2/3] Refactor zone_reclaim (v2)

to reclaim only unmapped pages. -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] Provide control over unmapped pages (v2)

lru. It can enhance reclaim latency and is good to embedded people. -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] Refactor zone_reclaim (v2)

On Tue, Dec 14, 2010 at 8:45 PM, Balbir Singh bal...@linux.vnet.ibm.com wrote: * MinChan Kim minchan@gmail.com [2010-12-14 19:01:26]: Hi Balbir, On Fri, Dec 10, 2010 at 11:31 PM, Balbir Singh bal...@linux.vnet.ibm.com wrote: Move reusable functionality outside of zone_reclaim. Make

Re: [PATCH 3/3] Provide control over unmapped pages

cache pages are mapped at address space of application(ex, android uses java model so many pages are mapped by application's address space). It means it's hard to reclaim them without lagging. So I have a interest in this patch. -- Kind regards, Minchan Kim -- To unsubscribe from this list: send

Re: [PATCH 2/3] Refactor zone_reclaim

your logic, the function name would be just zone_reclaim_pages If you want to name it with zone_reclaim_unmapped_pages, it could be better with setting sc-may_unmap in this function. -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm in the body

Re: [PATCH 1/2] Add vzalloc shortcut

as well as data pages, it's not a big. In this case, Maintaining code simple is better than little bit performance overhead. Signed-off-by: Dave Young hidave.darks...@gmail.com Reviewed-by: Minchan Kim minchan@gmail.com Isn't it useful in nommu, either? ---  include/linux/vmalloc.h

Re: Page allocation failures in guest

and consider using PGP for end-to-end  encryption. -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html