Re: [PATCH 0/3] kvmtool: tiny init fox x86_64

2015-10-22 Thread Pekka Enberg
, but this is minor. I want to write my /virt/init in shell or perl and this change can help. I don't really know who should be cc'ed, I've picked some names from git-log guest/init.c. Will maintains the standalone kvmtool.git tree. The series looks good to me: Acked-by: Pekka Enberg <p

Re: stand-alone kvmtool

2015-03-01 Thread Pekka Enberg
On 2/26/15 1:02 PM, Alex Bennée wrote: If you can have it all it would be nice to preserve buildability all through your history for bisecting (and the moon on a stick please ;-) Is the dependency on the kernel sources something that has been stable over the projects history or something that's

Re: stand-alone kvmtool

2015-02-23 Thread Pekka Enberg
Hi, On 2/18/15 5:50 PM, Will Deacon wrote: Thanks for doing this. Since it looks unlikely that kvmtool will ever be merged back into the kernel tree, it makes sense to cut the dependency in my opinion. I am certainly OK with a standalone repository which preserves the history. Will, would

Re: [PATCH 2/5] kvmtool: ARM64: Fix compile error for aarch64

2014-08-28 Thread Pekka Enberg
On 08/07/2014 12:12 PM, Will Deacon wrote: Ok. Pekka, could you merge in 3.16 to the kvmtool master branch please? You'll need my patch below to resolve some ARM build fallout. Done. - Pekka -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [PATCH] KVM: x86: fix TSC matching

2014-08-26 Thread Pekka Enberg
On Sun, Aug 17, 2014 at 11:54 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 15/08/2014 18:54, Marcelo Tosatti ha scritto: Ping on integration. It's been in kvm/next for a while, and is now in Linus's tree: Does this make sense for -stable too? - Pekka -- To unsubscribe from this list:

Re: [PATCH v3 00/12] kvm tools: Misc patches (mips support)

2014-05-30 Thread Pekka Enberg
On 05/28/2014 11:08 PM, Andreas Herrmann wrote: Hi, This is v3 of my patch set to run lkvm on MIPS. It's rebased on v3.13-rc1-1436-g1fc83c5 of git://github.com/penberg/linux-kvm.git Applied, thanks! -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to

Re: [PATCH v2 00/12] kvm tools: Misc patches (mips support)

2014-05-20 Thread Pekka Enberg
On 05/20/2014 02:20 PM, James Hogan wrote: I don't know what Pekka's policy is for kvm tools, but to avoid confusion I'd like to make clear that this patchset depends on a KVM implementation (KVM_VM_TYPE==1 for VZ) which hasn't been accepted into the mainline kernel yet. Is that something that

Re: [PATCH v3 0/9] kvmtool: handle guests of a different endianness

2014-05-03 Thread Pekka Enberg
On 4/24/14 9:17 PM, Marc Zyngier wrote: This patch series adds some infrastructure to kvmtool to allow a BE guest to use virtio-mmio on a LE host, provided that the architecture actually supports such madness. Not all the backend have been converted, only those I actually cared about.

Re: [PATCH 0/2] kvm tools: fix vhost-net broken since fa7226f88012713a73d0cba4955444ea109e9458

2013-11-04 Thread Pekka Enberg
On 11/01/2013 04:50 AM, Ying-Shiuan Pan wrote: These patch series fix 2 vhost-net problems. There were 2 problems after commit fa7226f88012713a73d0cba4955444ea109e9458. (1) vhost-net requires tap_fd for VHOST_SET_BACKEND, but opening tap device was postponed to VIRTIO_CONFIG_S_DRIVER_OK. The

Re: lkvm: virtio-net-rx general protection error

2013-10-21 Thread Pekka Enberg
On 10/21/13 1:35 PM, Milan Kocian wrote: hi, sorry for writing it directly to you but I didn't find better recipient. Does exist some mailing-list about lkvm? I found the crash in virtio-net-rx thread (I can reproduce it every time by 'aptitude update' in VM): traps: virtio-net-rx[28933]

Re: lkvm issue: --network mode=user,trans=mmio doesn't work

2013-10-12 Thread Pekka Enberg
Hi Peter, (Adding bunch of CCs.) On 10/12/13 11:05 AM, Péter Szabó wrote: First, thank you very much for writing lkvm, it's awesome, and very easy to set up. If sending an e-mail to you is not the right way to report lkvm issues, please tell me how I should do it. Sure, you can report

Re: lkvm issue: --console virtio keyboard doesn't work

2013-10-12 Thread Pekka Enberg
On 10/12/13 11:09 AM, Péter Szabó wrote: I'm using afdf92030c7c43b0f9b32b7edbe07ac3b13780f1 from git://github.com/penberg/linux-kvm.git and Linux kernel 3.2.51: config-3.2.51 (42 KB) https://mega.co.nz/#!hgxB1TDJ!SdbX-jp_yr8E6EUJl7t7Tzrh1p4qKxkTHieoss8yu_Y bzImage-3.2.51 (2.0 MB)

Re: [PATCH 2/2] kvm tools: arm: add support for ARM Cortex-A7

2013-09-30 Thread Pekka Enberg
On Mon, Sep 30, 2013 at 12:38 PM, Will Deacon will.dea...@arm.com wrote: However, we should hold off applying this to kvmtool until KVM_ARM_TARGET_CORTEX_A7 is defined in the kernel sources which it is shipped with. Do you have an ETA on this change going into the mainline kernel? (in the

[ANNOUNCE] OSv, an new operating system for the cloud, v0.01

2013-09-16 Thread Pekka Enberg
Hello, We're proud to announce release 0.01 of OSv, a new operating system for running applications on virtual machines. OSv is free software, released under the BSD license, and you can find it in https://github.com/cloudius-systems/osv and http://www.osv.io. To build and run OSv under

Re: [PATCH] kvm tools: virtio-mmio: init_ioeventfd should use MMIO for ioeventfd__add_event()

2013-09-04 Thread Pekka Enberg
On 8/30/13 4:58 PM, Ying-Shiuan Pan wrote: From: Ying-Shiuan Pan yingshiuan@gmail.com This patch fixes a bug that vtirtio_mmio_init_ioeventfd() passed a wrong value when it invoked ioeventfd__add_event(). True value of 2nd parameter indicates the eventfd uses PIO bus which is used by

Re: [PATCH 0/3] kvm tools: remove periodic tick

2013-09-04 Thread Pekka Enberg
On 9/3/13 9:10 PM, Jonathan Austin wrote: This patch series removes kvm tool's periodic tick function in favour of a thread that blocks waiting for input. The paths used for handling input are the same as when using a periodic tick, but they're not called unless there is actually input to be

Re: [PATCH] kvm tools: virtio-mmio: init_ioeventfd should use MMIO for ioeventfd__add_event()

2013-09-04 Thread Pekka Enberg
On Wed, Sep 4, 2013 at 1:07 PM, Will Deacon will.dea...@arm.com wrote: Like this? It gets a bit confusing, because there is a KVM_IOEVENTFD_FLAG_* namespace as part of the kernel KVM API, but which doesn't have the flags we need (e.g. userspace polling). Looks good. I applied the fix so can

Re: [PATCH] kvm tools: ioeventfd: replace bool parameters to __add_event with flags

2013-09-04 Thread Pekka Enberg
On Wed, Sep 4, 2013 at 1:27 PM, Will Deacon will.dea...@arm.com wrote: A recent fix to virtio MMIO (72a7541ce305 [kvm tools: virtio-mmio: init_ioeventfd should use MMIO for ioeventfd__add_event()]) highlighted the confusing parameters expected by ioeventfd__add_event. As per Pekka's

Re: [PATCH v2 2/3] kvm tools: remove periodic tick in favour of a polling thread

2013-09-04 Thread Pekka Enberg
Hi Jonathan, On Wed, Sep 4, 2013 at 4:25 PM, Jonathan Austin jonathan.aus...@arm.com wrote: Currently the only use of the periodic timer tick in kvmtool is to handle reading from stdin. Though functional, this periodic tick can be problematic on slow (eg FPGA) platforms and can cause low

Re: [PATCH v2 2/3] kvm tools: remove periodic tick in favour of a polling thread

2013-09-04 Thread Pekka Enberg
On Wed, Sep 4, 2013 at 8:40 PM, Jonathan Austin jonathan.aus...@arm.com wrote: 'top' works on ARM with virtio console. I've just done some new testing and with the serial console emulation and I see the same as you're reporting. Previously with the 8250 emulation I'd booted to a prompt but

Re: [PATCH] kvm tools: powerpc: Fix init order for xics

2013-08-27 Thread Pekka Enberg
On Tue, Aug 20, 2013 at 6:28 AM, Michael Neuling mi...@neuling.org wrote: xics_init() assumes kvm-nrcpus is already setup. kvm-nrcpus is setup in kvm_cpu_init() Unfortunately xics_init() and kvm_cpu_init() both use base_init(). So depending on the order randomly determined by the compiler,

Re: [PATCH] kvm tools: powerpc: Fix init order for xics

2013-08-27 Thread Pekka Enberg
On Tue, Aug 20, 2013 at 6:28 AM, Michael Neuling mi...@neuling.org wrote: xics_init() assumes kvm-nrcpus is already setup. kvm-nrcpus is setup in kvm_cpu_init() Unfortunately xics_init() and kvm_cpu_init() both use base_init(). So depending on the order randomly determined by the compiler,

Re: [PATCH] kvm tools: powerpc: Implement system-reboot RTAS call

2013-08-13 Thread Pekka Enberg
On Tue, Aug 13, 2013 at 8:48 AM, Michael Ellerman mich...@ellerman.id.au wrote: On some powerpc systems, reboot is implemented by an RTAS call by the name of system-reboot. Currently we don't implement it in kvmtool, which means instead the guest prints an error and spins. This is

Re: [PATCH] kvm tools: Fix build of guest init with biarch powerpc compilers

2013-08-10 Thread Pekka Enberg
On Wed, Aug 7, 2013 at 11:46 AM, Michael Ellerman mich...@ellerman.id.au wrote: On powerpc we build kvmtool as a 64bit binary. We do that by setting -m64 in our CFLAGS. For most things we just call $(CC) and it passes that info onto the linker. However there is one place where we explicitly

Re: [PATCH] kvm tools: plug race between uip_init and virtio_net_rx_thread

2013-08-10 Thread Pekka Enberg
allocations, called from notify_status. This allows the network to be safely initialized. Cc: Sasha Levin sasha.le...@oracle.com Cc: Pekka Enberg penb...@kernel.org Cc: Will Deacon will.dea...@arm.com Signed-off-by: Marc Zyngier marc.zyng...@arm.com Applied, thanks a lot! -- To unsubscribe from

Re: [PATCH v2] kvm tools: fix boot of guests with more than 4gb of ram

2013-07-09 Thread Pekka Enberg
On 07/08/2013 01:58 PM, Will Deacon wrote: Hi guys, On Mon, Jul 08, 2013 at 09:12:26AM +0100, Pekka Enberg wrote: On Sun, Jul 7, 2013 at 7:00 PM, Sasha Levin sasha.le...@oracle.com wrote: Commit kvm tools: virtio: remove hardcoded assumptions about guest page size has introduced a bug

Re: [PATCH v2] kvm tools: fix boot of guests with more than 4gb of ram

2013-07-08 Thread Pekka Enberg
On Sun, Jul 7, 2013 at 7:00 PM, Sasha Levin sasha.le...@oracle.com wrote: Commit kvm tools: virtio: remove hardcoded assumptions about guest page size has introduced a bug that prevented guests with more than 4gb of ram from booting. The issue is that 'pfn' is a 32bit integer, so when

Re: [PATCH] kvm tools: fix boot of guests with more than 4gb of ram

2013-07-07 Thread Pekka Enberg
On Mon, Jun 24, 2013 at 1:06 PM, Michael Tokarev m...@tls.msk.ru wrote: 24.06.2013 05:23, Sasha Levin wrote: queue = p9dev-vqs[vq]; queue-pfn = pfn; - p = guest_flat_to_host(kvm, queue-pfn * page_size); + p =

Re: [PATCH] kvm tools: add status notification hook to virtio-mmio

2013-06-10 Thread Pekka Enberg
On Mon, Jun 10, 2013 at 5:22 PM, Will Deacon will.dea...@arm.com wrote: Can you pick this one up please Pekka? If it helps: Acked-by: Will Deacon will.dea...@arm.com CC'ing me helped even more! ;-) Applied, thanks guys! -- To unsubscribe from this list: send the line unsubscribe kvm in the

Re: [patch 2/2] tools: lkvm - Filter out cpu vendor string

2013-06-08 Thread Pekka Enberg
Applied, thanks a lot! -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 2/2] tools: lkvm - Filter out cpu vendor string

2013-06-07 Thread Pekka Enberg
On 06/07/2013 11:17 AM, Asias He wrote: Ping! Is there someone out there who has a AMD box they could test this on? I tested it on AMD box. Guest boots with this patch, guest does not boot without it. I am not seeing the msr warning in both cases. That's pretty interesting. Can you please

Re: [patch 2/2] tools: lkvm - Filter out cpu vendor string

2013-06-06 Thread Pekka Enberg
: 0xc0010048 | [1709265.425774] kvm: 25706: cpu8 unhandled rdmsr: 0xc0010048 thus provide own string and kernel will use generic cpu init. Reported-by: Ingo Molnar mi...@kernel.org CC: Pekka Enberg penb...@kernel.org CC: Sasha Levin sasha.le...@oracle.com CC: Asias He as...@redhat.com Signed-off

Re: kvm tools: why SDL window does not exit on poweroff?

2013-05-23 Thread Pekka Enberg
Hello, On 04/15/2013 10:11 AM, Lin Ming wrote: On Mon, Apr 15, 2013 at 2:48 PM, Pekka Enberg penb...@kernel.org wrote: Hello, Hi, On Mon, Apr 15, 2013 at 5:27 AM, Lin Ming min...@gmail.com wrote: Will BIOS support be added in kvmtool in the future? Yes, I expect that to happen

Re: [RFC PATCH 00/11] kvm tools: allow ioport emulation to be used on ARM

2013-05-14 Thread Pekka Enberg
On Fri, May 3, 2013 at 9:53 AM, Michael Ellerman mich...@ellerman.id.au wrote: On Wed, 2013-05-01 at 16:50 +0100, Will Deacon wrote: Hi guys, This RFC series does a number of things, but the main goal is to allow re-use of the emulation code under hw/ on architectures other than x86. It also

Re: [PATCH 1/8] kvm tools: pass virtio header size to uip_init

2013-05-14 Thread Pekka Enberg
I applied the series. Thanks a lot Sasha! -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH 04/11] kvm tools: console: unconditionally output to any console

2013-05-03 Thread Pekka Enberg
On Wed, May 1, 2013 at 6:50 PM, Will Deacon will.dea...@arm.com wrote: From: Marc Zyngier marc.zyng...@arm.com Kvmtool suppresses any output to a console that has not been elected as *the* console. While this makes sense on the input side (we want the input to be sent to one console driver

Re: [PATCH] kvm tools: virtio-net mergable rx buffers

2013-04-24 Thread Pekka Enberg
Hi, On 04/23/2013 12:35 PM, Eric Northup wrote: Do you care about guests with drivers that don't negotiate VIRTIO_NET_F_MRG_RXBUF? On Wed, Apr 24, 2013 at 5:51 AM, Sasha Levin sasha.le...@oracle.com wrote: We usually try to keep backward compatibility, but in this case mergable RX buffers

Re: [PATCH] kvm tools: remove arbitrary minimum RAM limitation

2013-04-24 Thread Pekka Enberg
On 04/23/2013 05:57 PM, Sasha Levin wrote: We don't really need 64MB of RAM to boot, it's a nice default if we don't have anything else - but it's not actually required for anything: sh-4.2# free -h total used free sharedbuffers cached Mem: 20M

Re: [PATCH] kvm tools: virtio-net mergable rx buffers

2013-04-23 Thread Pekka Enberg
On Tue, Apr 23, 2013 at 3:32 AM, Sasha Levin sasha.le...@oracle.com wrote: @@ -94,4 +95,6 @@ struct kvm; void *mmap_hugetlbfs(struct kvm *kvm, const char *htlbfs_path, u64 size); void *mmap_anon_or_hugetlbfs(struct kvm *kvm, const char *hugetlbfs_path, u64 size); +int

Re: kvm tools: why SDL window does not exit on poweroff?

2013-04-15 Thread Pekka Enberg
Hello, On Mon, Apr 15, 2013 at 5:27 AM, Lin Ming min...@gmail.com wrote: Will BIOS support be added in kvmtool in the future? Yes, I expect that to happen eventually. Various patchsets have been started by multiple people to support SeaBIOS but there hasn't been a focused effort to push them

Re: [PATCH] kvm tools: make virtio-net mq max queues configurable

2013-04-15 Thread Pekka Enberg
On 04/15/2013 12:19 PM, Will Deacon wrote: Hi Sasha, On Sun, Apr 14, 2013 at 01:20:44AM +0100, Sasha Levin wrote: This patch makes the maximum amount of vqs configurable. To use it pass a 'mq' option to network device configuration. For example: vm run -n mode=tap,mq=4 Will allow up

Re: [PATCH 0/5] Usual batch of random ARM fixes for kvmtool

2013-04-12 Thread Pekka Enberg
On 04/11/2013 12:36 PM, Will Deacon wrote: Without multi-queue, we can boot Debian Wheezy to a prompt in 38MB. With the new changes, that increases to 170MB! Any chance we can try and tackle this regression please? I keep getting bitten by the OOM killer :( On 04/11/2013 07:45 PM, Sasha Levin

Re: [PATCH] kvm tools: set done to true on SDL window close

2013-04-12 Thread Pekka Enberg
On 04/12/2013 09:49 AM, Lin Ming wrote: Currently, SDL doesn't exit on window close because it stuck in sdl__stop because done is not set to true. Fix it by setting done to true on window close. Signed-off-by: Lin Ming min...@gmail.com Applied, thanks! -- To unsubscribe from this list: send

Re: [PATCH 0/5] Usual batch of random ARM fixes for kvmtool

2013-04-12 Thread Pekka Enberg
On 04/11/2013 07:36 PM, Will Deacon wrote: Here's the latest round of ARM fixes and updates for kvmtool. Applied, thanks a lot Will! Pekka -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More

Re: kvm tools: why SDL window does not exit on poweroff?

2013-04-12 Thread Pekka Enberg
On Fri, Apr 12, 2013 at 10:42 AM, Lin Ming min...@gmail.com wrote: I run poweroff or halt in SDL window, but the window does not exit although guest is already halted. But qemu can exit properly. Is it because hlt instruction is not emulated? Or other reason? Any hint to fix it? IIRC,

Re: kvmtool : [PATCH] PowerPc : Fix compilation for ppc64

2013-04-10 Thread Pekka Enberg
On Tue, Apr 9, 2013 at 8:29 PM, Prerna Saxena pre...@linux.vnet.ibm.com wrote: 'lkvm' compilation on ppc64 fails with the following error : ...[snip].. LINK guest/init LINK lkvm /usr/bin/ld: powerpc:common architecture of input file `guest/guest_init.o' is incompatible with

Re: [PATCH 1/6] kvm tools: Return error status in lkvm list

2013-02-06 Thread Pekka Enberg
Applied all patches, thanks a lot Michael! -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] kvm tools: arm: fix GIC #defines to match latest kvm code

2013-02-06 Thread Pekka Enberg
On Wed, Feb 6, 2013 at 2:12 PM, Will Deacon will.dea...@arm.com wrote: During the review process for the KVM ARM patches, the GIC device registration was subjected to some minor renaming, so update kvm tool appropriately. Signed-off-by: Will Deacon will.dea...@arm.com Applied, thanks Will!

Re: [PATCH] kvm tools: Fix powerpc build after kvm__dump_mem() change

2013-02-04 Thread Pekka Enberg
On Mon, Feb 4, 2013 at 2:17 PM, Michael Ellerman mich...@ellerman.id.au wrote: Commit 21692d1 (Beautify debug output) broke the powerpc build because it changed the signature for kvm__dump_mem() but didn't update all callers. Signed-off-by: Michael Ellerman mich...@ellerman.id.au Applied,

Re: [PATCH] kvm tools: Fix powerpc build after kvm__dump_mem() change

2013-02-04 Thread Pekka Enberg
On Mon, Feb 4, 2013 at 3:37 PM, Will Deacon will.dea...@arm.com wrote: D'oh! I was about to post a patch to fix this (arm is also broken)... I've dropped the powerpc hunk from my patch (see below). Applied, thanks Will! -- To unsubscribe from this list: send the line unsubscribe kvm in the body

Re: [PATCH] kvm tools: Fix SDL and VNC by setting vidmode correctly

2013-01-26 Thread Pekka Enberg
Applied both patches. Thanks Asias! -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] kvm tools: remove redundant if condition

2013-01-22 Thread Pekka Enberg
On Sat, Jan 19, 2013 at 12:27 PM, Cong Ding ding...@gmail.com wrote: On Sat, Jan 19, 2013 at 10:58:33AM +0200, Pekka Enberg wrote: On Wed, Jan 16, 2013 at 6:52 PM, Cong Ding ding...@gmail.com wrote: After we check (state.kcount != 0), state.kcount has to be 0 in all the else branchs

Re: [PATCH v2] kvm tools: close opened file

2013-01-19 Thread Pekka Enberg
On Wed, Jan 16, 2013 at 6:51 PM, Cong Ding ding...@gmail.com wrote: The file should be closed before return. Signed-off-by: Cong Ding ding...@gmail.com Applied, thanks! -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v2] kvm tools: remove redundant if condition

2013-01-19 Thread Pekka Enberg
On Wed, Jan 16, 2013 at 6:52 PM, Cong Ding ding...@gmail.com wrote: After we check (state.kcount != 0), state.kcount has to be 0 in all the else branchs. Signed-off-by: Cong Ding ding...@gmail.com --- tools/kvm/hw/i8042.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH 0/4] ARM updates for kvmtool

2013-01-09 Thread Pekka Enberg
On Mon, Jan 7, 2013 at 8:14 PM, Will Deacon will.dea...@arm.com wrote: Hello kvm hackers, This patch series introduces some updates to the ARM (AArch32) kvm tools code: - virtio mmio fixes to deal with guest page sizes != 4k (in preparation for AArch64, which I will post

Re: [PATCH 0/2] Add support for ARMv8 CPUs to kvmtool

2013-01-09 Thread Pekka Enberg
Hi Will, On Mon, Jan 7, 2013 at 8:43 PM, Will Deacon will.dea...@arm.com wrote: Hello again, These two patches add support for ARMv8 processors running an AArch64 instance of kvm to kvmtool. Both AArch32 and AArch64 guests are supported and, in the case of the latter, the guest page size may

Re: [PATCH 0/2] Add support for ARMv8 CPUs to kvmtool

2013-01-09 Thread Pekka Enberg
On Wed, Jan 9, 2013 at 1:33 PM, Will Deacon will.dea...@arm.com wrote: I think we're getting our wires crossed a bit here, so I'll try to explain my madness: - Mainline ARM kernels cannot be booted by kvmtool yet, you currently have to use my virt/mach branch from

Re: [PATCH 1/3] kvm-tool: ARM: set interrupt priority mask in secondary boot path

2012-12-09 Thread Pekka Enberg
in order to receive the boot IPI. Just set the GICC_PMR register to the maximum value (0xff), and it just works. Cc: Pekka Enberg penb...@kernel.org Signed-off-by: Marc Zyngier marc.zyng...@arm.com [will: added #define for PMR offset] Signed-off-by: Will Deacon will.dea...@arm.com Applied

Re: [PATCH] kvm tools: powerpc: convert spapr pci to new device iterators

2012-11-30 Thread Pekka Enberg
On Wed, 28 Nov 2012, Matt Evans wrote: On 2012-11-27 13:00, Will Deacon wrote: Commit 8d35d32d0148 (kvm tools: add generic device registration mechanism) introduced a tree-based device lookup-by-bus mechanism as well as iterators to enumerate the devices on a particular bus. Whilst

Re: [PATCH] kvm-tool: fix zombie reaping in guest/init.c

2012-11-30 Thread Pekka Enberg
: Pekka Enberg penb...@kernel.org Signed-off-by: Marc Zyngier marc.zyng...@arm.com Applied, thanks Marc! -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3] kvm tools: add support for ARMv7 processors

2012-11-24 Thread Pekka Enberg
On Fri, Nov 23, 2012 at 4:50 PM, Marc Zyngier marc.zyng...@arm.com wrote: On 23/11/12 14:40, Will Deacon wrote: This patch adds initial support for ARMv7 processors (more specifically, Cortex-A15) to kvmtool. Everything is driven by FDT, including dynamic generation of virtio nodes for MMIO

Re: [PATCH v2 0/8] kvm tools: add support for ARMv7 processors

2012-11-23 Thread Pekka Enberg
On Thu, 22 Nov 2012, Will Deacon wrote: Hello, This is version two of the patches I originally posted here: http://www.spinics.net/lists/kvm/msg82447.html Changes since version one include: - MAX_MEMORY no longer needlessly page-aligned for ARM - Use xread instead of

Re: [RFC PATCH 05/16] kvm tools: don't bother including linux/compiler.h

2012-11-19 Thread Pekka Enberg
Hi Will, On Mon, 19 Nov 2012, Will Deacon wrote: I'm struggling to reproduce this with my tree. Can you confirm whether or not you have commit 29fc7c5a4f51 (rbtree: include linux/compiler.h for definition of __always_inline) in your *kernel* sources please? No, I don't. I can

Re: [RFC PATCH 05/16] kvm tools: don't bother including linux/compiler.h

2012-11-16 Thread Pekka Enberg
On Fri, 16 Nov 2012, Will Deacon wrote: I'm seeing the following breakage with this patch applied: [penberg@tux kvm]$ make CC hw/rtc.o CC ioport.o CC kvm-cpu.o CC kvm.o In file included from include/kvm/rbtree-interval.h:4:0, from

Re: [RFC PATCH 16/16] kvm tools: add support for ARMv7 processors

2012-11-13 Thread Pekka Enberg
On Tue, Nov 13, 2012 at 12:21 PM, Matt Evans matt.ev...@arm.com wrote: I *think* Will was going to make some small changes, if you've already merged it then a follow-up set perhaps? I only merged the non-ARM specific changes which looked good to me. But sure, please send an incremental patch

Re: [RFC PATCH 05/16] kvm tools: don't bother including linux/compiler.h

2012-11-12 Thread Pekka Enberg
On Mon, 12 Nov 2012, Will Deacon wrote: linux/compiler.h will never give us a definition for __compiler_offsetof because __KERNEL__ isn't defined, so just use the simple definition that we have already. This patch removes the redundant code. Signed-off-by: Will Deacon will.dea...@arm.com

Re: [RFC PATCH 00/16] kvm tools: add support for ARMv7 processors

2012-11-12 Thread Pekka Enberg
On Mon, 12 Nov 2012, Will Deacon wrote: This patch series adds support for ARMv7 processors (Cortex-A15) to kvm tool. The majority of the series consists of small changes in preparation for ARM support, which is added by the final patch. I can try to split this up further, but given that there

Re: [RFC PATCH 16/16] kvm tools: add support for ARMv7 processors

2012-11-12 Thread Pekka Enberg
On Mon, 12 Nov 2012, Will Deacon wrote: This patch adds initial support for ARMv7 processors (more specifically, Cortex-A15) to kvmtool. Everything is driven by FDT, including dynamic generation of virtio nodes for MMIO devices (PCI is not used due to lack of a suitable host-bridge). The

Re: [BUG] lkvm crash on crashkernel boot

2012-10-31 Thread Pekka Enberg
On Thu, 25 Oct 2012, Kirill A. Shutemov wrote: vec is 0x in virtio_pci__specific_io_out() on crash. Let's add proper bounds checking there. It doesn't not solves the issue with booting crashkernel, but fix lkvm crash. There's no sign-off for the patch. Kirill, care to update the patch

Re: [PATCH -next] kvm tools: remove duplicated include from builtin-setup.c

2012-10-26 Thread Pekka Enberg
On Fri, 26 Oct 2012, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Remove duplicated include. dpatch engine is used to auto generate this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn ---

Re: [PATCH 2/5] kvm tools: use the correct config vector interrupt

2012-10-26 Thread Pekka Enberg
On Thu, 25 Oct 2012, Sasha Levin wrote: On Thu, Oct 25, 2012 at 3:03 AM, Pekka Enberg penb...@kernel.org wrote: On Wed, 24 Oct 2012, William Dauchy wrote: when registering the config interrupt, the later is registered in vcpi-config_vector and not in vpci-vq_vector introduced

Re: [BUG] lkvm crash on crashkernel boot

2012-10-26 Thread Pekka Enberg
On Thu, 25 Oct 2012, Sasha Levin wrote: I think we're seeing that because we don't handle VIRTIO_MSI_NO_VECTOR properly. We need to deal with the ability to remove GSI friends as well. I've added it to my workqueue (unless someone deals with it first). Any reason I shouldn't apply

[PATCH] kvm tools: Fix reported RTC century and year

2012-10-25 Thread Pekka Enberg
Anvin h...@zytor.com Cc: Ron Minnich rminn...@gmail.com Cc: Asias He asias.he...@gmail.com Cc: Cyrill Gorcunov gorcu...@openvz.org Cc: Sasha Levin levinsasha...@gmail.com Signed-off-by: Pekka Enberg penb...@kernel.org --- tools/kvm/hw/rtc.c | 30 ++ 1 files changed

Re: [RFC 1/3] kvm tools: use mutex abstraction instead of pthread mutex

2012-10-25 Thread Pekka Enberg
On Wed, 24 Oct 2012, Sasha Levin wrote: We already have something to wrap pthread with mutex_[init,lock,unlock] calls. This patch creates a new struct mutex abstraction and moves everything to work with it. Signed-off-by: Sasha Levin sasha.le...@oracle.com I applied this patch from the RFC

Re: [PATCH 1/5] kvm tools: check ioctl return value for msi signal

2012-10-25 Thread Pekka Enberg
On Wed, 24 Oct 2012, William Dauchy wrote: Signed-off-by: William Dauchy will...@gandi.net --- tools/kvm/virtio/pci.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/kvm/virtio/pci.c b/tools/kvm/virtio/pci.c index b6ac571..ab1119a 100644 ---

Re: [PATCH 2/5] kvm tools: use the correct config vector interrupt

2012-10-25 Thread Pekka Enberg
On Wed, 24 Oct 2012, William Dauchy wrote: when registering the config interrupt, the later is registered in vcpi-config_vector and not in vpci-vq_vector introduced in: a841f15 kvm tools: Use the new KVM_SIGNAL_MSI ioctl to inject interrupts directly. Signed-off-by: William Dauchy

Re: [PATCH 4/5] kvm tools: initialize msi flags to zero even is not used yet

2012-10-25 Thread Pekka Enberg
On Wed, 24 Oct 2012, William Dauchy wrote: kvm explictly checks if msi flags is equal to zero before going further; just make sure it is correctly initialized. Signed-off-by: William Dauchy will...@gandi.net --- tools/kvm/virtio/pci.c |1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH 5/5] kvm tools: specify the amount to balloon is in MB

2012-10-25 Thread Pekka Enberg
Signed-off-by: William Dauchy will...@gandi.net --- tools/kvm/builtin-balloon.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/kvm/builtin-balloon.c b/tools/kvm/builtin-balloon.c index 5bd2291..d158ace 100644 --- a/tools/kvm/builtin-balloon.c +++

Re: [BUG] lkvm crash on crashkernel boot

2012-10-25 Thread Pekka Enberg
On Wed, Oct 24, 2012 at 6:27 PM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: Hi, I've tried to play with kexec using lkvm. Unfortunately, lkvm crashes when I try to switch to crashkernel. I use Linus tree + penberg/kvmtool/next + one x86 mm patch[1]. Kernel is defconfig +

Re: [PATCH] kvm tools: Fix SDL and VNC by adding default vidmode

2012-10-21 Thread Pekka Enberg
On Sun, 21 Oct 2012, Asias He wrote: In commit d73b168b3145f7bfe3f0e5d968653a1125b93a4e (kvm tools: ui improvements), the code to set a default vidmode was killed accidentally. This makes SDL and VNC not working unless '--vidmode' option is added, e.g lkvm run --sdl --vidmode 786.

Re: [PATCH] kvm tools: fix help output for run command

2012-10-16 Thread Pekka Enberg
On Fri, 12 Oct 2012, William Dauchy wrote: This dummy patch remove tabs in help output. Introduced in commit: ae9ec23 kvm tools: generate command line options dynamically Signed-off-by: William Dauchy wdau...@gmail.com Applied, thanks William! -- To unsubscribe from this list: send the line

Re: [PATCH 1/3] kvm tools: Fix powerpc build errors caused by recent changes

2012-10-05 Thread Pekka Enberg
Applied all three patches, thanks Michael! -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] kvm tools: Fix powerpc build errors caused by recent changes

2012-10-05 Thread Pekka Enberg
Applied all three patches, thanks Michael! -- To unsubscribe from this list: send the line unsubscribe kvm-ppc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] kvm tools: Export DISPLAY ENV as our default host ip address

2012-09-05 Thread Pekka Enberg
On 08/24/2012 02:29 PM, Asias He wrote: It is useful to run a X program in guest and display it on host. 1) Make host's x server listen to localhost:6000 host_shell$ socat -d -d TCP-LISTEN:6000,fork,bind=localhost \ UNIX-CONNECT:/tmp/.X11-unix/X0 2) Start the guest and run

Re: [PATCH 00/33] Cleanups and automatic init/exit calls

2012-09-05 Thread Pekka Enberg
On Wed, Sep 5, 2012 at 11:31 AM, Sasha Levin levinsasha...@gmail.com wrote: This patch series is mostly about cleanups: - Clean all the global variables we have to store configuration options. - Remove externed config options between objects. - Adding several exit routines to clean up on

Re: [PATCH 5/7] kvm tools: enable LTO

2012-08-30 Thread Pekka Enberg
On Thu, Aug 30, 2012 at 10:36 AM, Sasha Levin levinsasha...@gmail.com wrote: Build with -flto set, which should enable link-time-optimizations. I'm not sure if it provides a significant performance increase, but it's probably just worth it for catching issues which it may cause.

Re: [PATCH 5/7] kvm tools: enable LTO

2012-08-30 Thread Pekka Enberg
On Thu, Aug 30, 2012 at 11:22 AM, Cyrill Gorcunov gorcu...@openvz.org wrote: Maybe we could enable it via some make option? Say make LTO=1 or something? That is not going to help much in catching LTO issues early. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a

Re: [PATCH 1/7] kvm tools: add HOME env var to hostfs

2012-08-30 Thread Pekka Enberg
On Thu, Aug 30, 2012 at 12:44 PM, Sasha Levin levinsasha...@gmail.com wrote: On 08/30/2012 09:50 AM, Cyrill Gorcunov wrote: On Thu, Aug 30, 2012 at 09:36:37AM +0200, Sasha Levin wrote: +char *new_env[] = { TERM=linux, DISPLAY=192.168.33.1:0, +HOME=/virt/home,

Re: [PATCH 1/2] kvm tools: Respect guest tcp window size

2012-08-23 Thread Pekka Enberg
On Thu, Aug 23, 2012 at 4:26 AM, Asias He asias.he...@gmail.com wrote: Respect guest tcp window size and stop sending tcp segments to guest if guest's receive window is closed. This fixes the TCP hang I'm seeing where guest and host are transferring big chuck of data. Awesome! This problem

Re: [PATCH 1/2] kvm tools: Respect guest tcp window size

2012-08-23 Thread Pekka Enberg
On Thu, Aug 23, 2012 at 12:36 PM, Asias He asias.he...@gmail.com wrote: while (1) { + pos = payload; ret = read(sk-fd, payload, UIP_MAX_TCP_PAYLOAD); if (ret = 0 || ret UIP_MAX_TCP_PAYLOAD) goto out; -

Re: [PATCH V2] kvm tools: Add initial virtio-scsi support

2012-08-20 Thread Pekka Enberg
On Fri, Aug 17, 2012 at 1:04 PM, Pekka Enberg penb...@kernel.org wrote: Looks good to me. I'll sit on this for a little while if the virtio-scsi folks want to comment on the code. Applied, thanks Asias! -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message

Re: [PATCH V2] kvm tools: Add initial virtio-scsi support

2012-08-17 Thread Pekka Enberg
On Fri, Aug 17, 2012 at 12:26 PM, Asias He asias.he...@gmail.com wrote: This patch brings virito-scsi support to kvm tool. With the introduce of tcm_vhost (vhost-scsi) tcm_vhost: Initial merge for vhost level target fabric driver we can implement virito-scsi by simply having vhost-scsi

perf uncore lkvm woes

2012-08-16 Thread Pekka Enberg
Hello, [0.248962] Pid: 0, comm: swapper/0 Not tainted 3.6.0-rc1+ #24 [penberg@tux ~]$ cat perf-kvmtool-issue Hello, Has anyone seen this? It's kvmtool/next with 3.6.0-rc1. Looks like we are doing uncore_init() on virtualized CPU which breaks boot. Pekka [penberg@tux

Re: perf uncore lkvm woes

2012-08-16 Thread Pekka Enberg
On Thu, Aug 16, 2012 at 10:01:58AM +0300, Pekka Enberg wrote: Hello, [0.248962] Pid: 0, comm: swapper/0 Not tainted 3.6.0-rc1+ #24 [penberg@tux ~]$ cat perf-kvmtool-issue Hello, Has anyone seen this? It's kvmtool/next with 3.6.0-rc1. Looks like we are doing uncore_init

Re: perf uncore lkvm woes

2012-08-16 Thread Pekka Enberg
On 08/16/2012 03:19 PM, Peter Zijlstra wrote: On Thu, 2012-08-16 at 10:01 +0300, Pekka Enberg wrote: Has anyone seen this? It's kvmtool/next with 3.6.0-rc1. Looks like we are doing uncore_init() on virtualized CPU which breaks boot. I think you're the first.. I don't normally use kvm if I can

Re: perf uncore lkvm woes

2012-08-16 Thread Pekka Enberg
On Thu, Aug 16, 2012 at 12:06 PM, Cyrill Gorcunov gorcu...@openvz.org wrote: Most users just install a distro, they don't mess with kernel command lines. The command line option might be added implicitly in qemu/lkvm. That does not make sense for QEMU and we want less mandatory command line

Re: [PATCH] kvm tools: Fix segfault on lkvm run

2012-08-15 Thread Pekka Enberg
On Tue, Aug 14, 2012 at 11:47 AM, Paul Neumann paul1...@yahoo.de wrote: Looks good to me. Paul, can you tell how the segfault is triggered as well? Thanks. The segfault is triggered by just running lkvm run. On my system, it does not find any kernel, so kvm_cmd_run_init() returns EINVAL

Re: [PATCH] kvm tools: Add initial virtio-scsi support

2012-08-13 Thread Pekka Enberg
On Thu, Aug 9, 2012 at 3:51 AM, Asias He asias.he...@gmail.com wrote: This patch brings virito-scsi support to kvm tool. With the introduce of tcm_vhost (vhost-scsi) tcm_vhost: Initial merge for vhost level target fabric driver we can implement virito-scsi by simply having vhost-scsi to

Re: [PATCH 2/2] kvm tools: Check for unknown parameters in network option handling

2012-08-13 Thread Pekka Enberg
On Mon, Aug 13, 2012 at 6:31 AM, Michael Ellerman mich...@ellerman.id.au wrote: diff --git a/tools/kvm/builtin-run.c b/tools/kvm/builtin-run.c index a36bd00..9e5c1d4 100644 --- a/tools/kvm/builtin-run.c +++ b/tools/kvm/builtin-run.c @@ -257,7 +257,8 @@ static int set_net_param(struct

Re: [PATCH] kvm tools: Fix crash when /etc/resolv.conf doesn't exist

2012-08-13 Thread Pekka Enberg
I've applied all Michal's patches. Thanks guys! -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

  1   2   3   4   5   6   7   8   >