Re: [PATCH 02/20] MIPS: Clear [MSA]FPE CSR.Cause after notify_die()

2015-03-23 Thread Ralf Baechle
On Wed, Mar 11, 2015 at 02:44:38PM +, James Hogan wrote: Acked-by: Ralf Baechle r...@linux-mips.org Feel free to merge this through the KVM tree along with the remainder of the series. Ralf -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord

Re: mips: Accidental removal of paravirt_cpus_done?

2014-06-13 Thread Ralf Baechle
On Fri, Jun 13, 2014 at 12:02:30PM +0200, Geert Uytterhoeven wrote: It seems you accidentally assimilated an (unwanted?) kvm change in my patch: I accidentally must have done a git commit --amend with the wrong patch on top, sorry about that. The change itself was intensional. Ralf -- To

Re: [PATCH v2 09/13] MIPS: Add functions for hypervisor call

2014-06-03 Thread Ralf Baechle
On Wed, May 28, 2014 at 11:52:12PM +0200, Andreas Herrmann wrote: +/* + * Hypercalls for KVM. + * + * Hypercall number is passed in v0. + * Return value will be placed in v0. + * Up to 3 arguments are passed in a0, a1, and a2. + */ +static inline unsigned long kvm_hypercall0(unsigned long

Re: [PATCH v2 02/23] MIPS: Export local_flush_icache_range for KVM

2014-05-30 Thread Ralf Baechle
On Thu, May 29, 2014 at 10:16:24AM +0100, James Hogan wrote: Export the local_flush_icache_range function pointer for GPL modules so that it can be used by KVM for syncing the icache after binary translation of trapping instructions. Acked-by: Ralf Baechle r...@linux-mips.org Ralf

Re: [PATCH v2 14/23] MIPS: KVM: Override guest kernel timer frequency directly

2014-05-30 Thread Ralf Baechle
value will allow the normal timer frequency calculation to take place (based on the emulated RTC). Acked-by: Ralf Baechle r...@linux-mips.org Ralf -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 10/15] MIPS: Add code for new system 'paravirt'.

2014-05-23 Thread Ralf Baechle
On Fri, May 23, 2014 at 10:28:55PM +0200, Andreas Herrmann wrote: + wmb(); Wouldn't smp_wmb() be more accurate? ... use smp_wmb there ... A few years ago I reviewed the use of mb()/rmb()/wmb() as opposed to smp_mb()/smp_rmb()/smp_wmb() throughout the kernel. Every single use was a

Re: [PATCH 06/15] MIPS: Add minimal support for OCTEON3 to c-r4k.c

2014-05-22 Thread Ralf Baechle
On Wed, May 21, 2014 at 11:02:12PM +0200, Andreas Herrmann wrote: On Wed, May 21, 2014 at 02:40:41PM +0200, Ralf Baechle wrote: On Tue, May 20, 2014 at 04:47:07PM +0200, Andreas Herrmann wrote: +static inline void r4k_blast_dcache_page_dc128(unsigned long addr

Re: [PATCH 06/15] MIPS: Add minimal support for OCTEON3 to c-r4k.c

2014-05-21 Thread Ralf Baechle
On Tue, May 20, 2014 at 04:47:07PM +0200, Andreas Herrmann wrote: +static inline void r4k_blast_dcache_page_dc128(unsigned long addr) +{ + R4600_HIT_CACHEOP_WAR_IMPL; The R4600 has 32 byte cache lines that is this line will never be executed on an R4600 thus can be dropped. +

Re: [PATCH 05/15] MIPS: Don't build fast TLB refill handler with 32-bit kernels.

2014-05-21 Thread Ralf Baechle
On Wed, May 21, 2014 at 10:38:39AM +0100, James Hogan wrote: On 20/05/14 15:47, Andreas Herrmann wrote: From: David Daney david.da...@cavium.com The fast handler only supports 64-bit kernels. Signed-off-by: David Daney david.da...@cavium.com Signed-off-by: Andreas Herrmann

Re: [PATCH 11/15] MIPS: paravirt: Add pci controller for virtio

2014-05-21 Thread Ralf Baechle
On Tue, May 20, 2014 at 04:47:12PM +0200, Andreas Herrmann wrote: + +union pci_config_address { + struct { +#ifdef __LITTLE_ENDIAN + unsignedregister_number : 8;/* 7 .. 0 */ + unsigneddevfn_number: 8;/* 15 .. 8 */ +

Re: [PATCH 1/3] mips/kvm: Improve code formatting in arch/mips/kvm/kvm_locore.S

2013-08-05 Thread Ralf Baechle
-by: David Daney david.da...@cavium.com Acked-by: Ralf Baechle r...@linux-mips.org +/* Put the saved pointer to vcpu (s1) back into the DDATA_LO Register */ git am detects a whitespace error here (space before tab in indent). It's got spaces before and after the tab actually

Re: [PATCH 1/3] mips/kvm: Improve code formatting in arch/mips/kvm/kvm_locore.S

2013-08-05 Thread Ralf Baechle
On Mon, Aug 05, 2013 at 04:43:27PM +0300, Gleb Natapov wrote: Date: Mon, 5 Aug 2013 16:43:27 +0300 From: Gleb Natapov g...@redhat.com To: Ralf Baechle r...@linux-mips.org Cc: James Hogan james.ho...@imgtec.com, David Daney ddaney.c...@gmail.com, linux-m...@linux-mips.org, kvm

Re: [PATCH 00/31] KVM/MIPS: Implement hardware virtualization via the MIPS-VZ extensions.

2013-06-19 Thread Ralf Baechle
FYI, Since you intend to resubmit anyway I just dropped the entire series from patchwork. Ralf -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 19/31] mips/kvm: Add host definitions for MIPS VZ based host.

2013-06-16 Thread Ralf Baechle
Acked-by: Ralf Baechle r...@linux-mips.org Ralf -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 20/31] mips/kvm: Hook into TLB fault handlers.

2013-06-16 Thread Ralf Baechle
Acked-by: Ralf Baechle r...@linux-mips.org Ralf -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 21/31] mips/kvm: Allow set_except_vector() to be used from MIPSVZ code.

2013-06-16 Thread Ralf Baechle
On Fri, Jun 07, 2013 at 04:03:25PM -0700, David Daney wrote: From: David Daney david.da...@cavium.com We need to move it out of __init so we don't have section mismatch problems. Signed-off-by: David Daney david.da...@cavium.com --- arch/mips/include/asm/uasm.h | 2 +-

Re: [PATCH 22/31] mips/kvm: Split get_new_mmu_context into two parts.

2013-06-16 Thread Ralf Baechle
Acked-by: Ralf Baechle r...@linux-mips.org Ralf -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 23/31] mips/kvm: Hook into CP unusable exception handler.

2013-06-16 Thread Ralf Baechle
On Fri, Jun 07, 2013 at 04:03:27PM -0700, David Daney wrote: From: David Daney david.da...@cavium.com The MIPS VZ KVM code needs this to be able to manage the FPU. Signed-off-by: David Daney david.da...@cavium.com Looks good, Acked-by: Ralf Baechle r...@linux-mips.org. However I get cold

Re: [PATCH 24/31] mips/kvm: Add thread_struct fields used by MIPSVZ hosts.

2013-06-16 Thread Ralf Baechle
Acked-by: Ralf Baechle r...@linux-mips.org Ralf -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 25/31] mips/kvm: Add some asm-offsets constants used by MIPSVZ.

2013-06-16 Thread Ralf Baechle
Patch looks ok but why not combine this patch with the previous one? Ralf -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 26/31] mips/kvm: Split up Kconfig and Makefile definitions in preperation for MIPSVZ.

2013-06-16 Thread Ralf Baechle
The Trademark guys (and readability in general) sould probably be happier if MIPSTE was spelled as MIPS_TE and for that matter, MIPZVZ as MIPS_VZ? Other than that, Acked-by: Ralf Baechle r...@linux-mips.org Ralf -- To unsubscribe from this list: send the line unsubscribe kvm in the body

Re: [PATCH 31/31] mips/kvm: Allow for upto 8 KVM vcpus per vm.

2013-06-16 Thread Ralf Baechle
Acked-by: Ralf Baechle r...@linux-mips.org Ralf -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 27/31] mips/kvm: Gate the use of kvm_local_flush_tlb_all() by KVM_MIPSTE

2013-06-16 Thread Ralf Baechle
new asid cycle */ #else local_flush_tlb_all(); /* start new asid cycle */ Sanjay, it would seem this is actually a bug if KVM is built as a module and should be fixed for 3.10? Acked-by: Ralf Baechle r...@linux-mips.org Ralf -- To unsubscribe from this list: send the line

Re: [PATCH 30/31] mips/kvm: Enable MIPSVZ in Kconfig/Makefile

2013-06-16 Thread Ralf Baechle
Acked-by: Ralf Baechle r...@linux-mips.org Ralf -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 29/31] mips/kvm: Add MIPSVZ support.

2013-06-16 Thread Ralf Baechle
Acked-by: Ralf Baechle r...@linux-mips.org Ralf -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/31] KVM/MIPS: Implement hardware virtualization via the MIPS-VZ extensions.

2013-06-16 Thread Ralf Baechle
On Sun, Jun 09, 2013 at 04:23:51PM -0700, David Daney wrote: Come to think of it, Emulating SGI hardware might be an interesting case. There may be old IRIX systems and applications that could be running low on real hardware. Some of those systems take up a whole room and draw a lot of

Re: [PATCH 28/31] mips/kvm: Only use KVM_COALESCED_MMIO_PAGE_OFFSET with KVM_MIPSTE

2013-06-16 Thread Ralf Baechle
On Fri, Jun 07, 2013 at 04:03:32PM -0700, David Daney wrote: From: David Daney david.da...@cavium.com The forthcoming MIPSVZ code doesn't currently use this, so it must only be enabled for KVM_MIPSTE. Signed-off-by: David Daney david.da...@cavium.com ---

Re: [PATCH 15/31] mips/kvm: Exception handling to leave and reenter guest mode.

2013-06-15 Thread Ralf Baechle
the point where reimplementing is using uasm.c is looking like a good thing. But certainly not now. Acked-by: Ralf Baechle r...@linux-mips.org Ralf -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 16/31] mips/kvm: Add exception handler for MIPSVZ Guest exceptions.

2013-06-15 Thread Ralf Baechle
On Fri, Jun 07, 2013 at 04:03:20PM -0700, David Daney wrote: Acked-by: Ralf Baechle r...@linux-mips.org -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 18/31] mips/kvm: Add pt_regs slots for BadInstr and BadInstrP

2013-06-15 Thread Ralf Baechle
Acked-by: Ralf Baechle r...@linux-mips.org -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/31] KVM/MIPS: Implement hardware virtualization via the MIPS-VZ extensions.

2013-06-14 Thread Ralf Baechle
On Fri, Jun 07, 2013 at 04:03:04PM -0700, David Daney wrote: Subject: [PATCH 00/31] KVM/MIPS: Implement hardware virtualization via the MIPS-VZ extensions. From: David Daney david.da...@cavium.com These patches take a somewhat different approach to MIPS virtualization via the MIPS-VZ

Re: [PATCH 17/31] MIPS: Quit exposing Kconfig symbols in uapi headers.

2013-06-14 Thread Ralf Baechle
So this one can be dropped. Ralf -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 01/31] MIPS: Move allocate_kscratch to cpu-probe.c and make it public.

2013-06-14 Thread Ralf Baechle
stop your patch nor should we unless this turns out to be an actual problem add any kludges to support such cowboy style hacks. But I wanted to mention and document the issue; maybe this should be mentioned in the log message of the next version of this patch. Acked-by: Ralf Baechle r...@linux

Re: [PATCH 03/31] mips/kvm: Fix 32-bitisms in kvm_locore.S

2013-06-14 Thread Ralf Baechle
you insert an extra cleanup patch to properly re-indent the entire file into the series before this one? So with that sorted: Acked-by: Ralf Baechle r...@linux-mips.org Ralf -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org

Re: [PATCH 01/31] MIPS: Move allocate_kscratch to cpu-probe.c and make it public.

2013-06-14 Thread Ralf Baechle
On Fri, Jun 14, 2013 at 01:41:18PM +0200, Ralf Baechle wrote: Date: Fri, 14 Jun 2013 13:41:18 +0200 From: Ralf Baechle r...@linux-mips.org To: James Hogan james.ho...@imgtec.com Cc: linux-m...@linux-mips.org, kvm@vger.kernel.org, Sanjay Lal sanj...@kymasys.com, linux-ker...@vger.kernel.org

Re: [PATCH 04/31] mips/kvm: Add casts to avoid pointer width mismatch build failures.

2013-06-14 Thread Ralf Baechle
Cast are always a bit ugly, in particular the one double casts - but a necessary evil here. Acked-by: Ralf Baechle r...@linux-mips.org Ralf -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 05/31] mips/kvm: Use generic cache flushing functions.

2013-06-14 Thread Ralf Baechle
On Fri, Jun 07, 2013 at 04:03:09PM -0700, David Daney wrote: From: David Daney david.da...@cavium.com We don't know if we have the r4k specific functions available, so use universally available __flush_cache_all() instead. This takes longer as it flushes both i-cache and d-cache, but is

Re: [PATCH 06/31] mips/kvm: Rename kvm_vcpu_arch.pc to kvm_vcpu_arch.epc

2013-06-14 Thread Ralf Baechle
Acked-by: Ralf Baechle r...@linux-mips.org Ralf -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 07/31] mips/kvm: Rename VCPU_registername to KVM_VCPU_ARCH_registername

2013-06-14 Thread Ralf Baechle
Acked-by: Ralf Baechle r...@linux-mips.org Ralf -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 08/31] mips/kvm: Fix code formatting in arch/mips/kvm/kvm_locore.S

2013-06-14 Thread Ralf Baechle
Ah, here's you're taking care of my eariler complaint about the formatting of kvm_locore.S. I'd have done things in a different order to avoid the inconsistent formatting - even if that was only a temporary state. But anyway, Acked-by: Ralf Baechle r...@linux-mips.org Ralf -- To unsubscribe

Re: [PATCH 09/31] mips/kvm: Factor trap-and-emulate support into a pluggable implementation.

2013-06-14 Thread Ralf Baechle
Acked-by: Ralf Baechle r...@linux-mips.org Ralf -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 10/31] mips/kvm: Implement ioctls to get and set FPU registers.

2013-06-14 Thread Ralf Baechle
and fcr31. Acked-by: Ralf Baechle r...@linux-mips.org Ralf -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 11/31] MIPS: Rearrange branch.c so it can be used by kvm code.

2013-06-14 Thread Ralf Baechle
Acked-by: Ralf Baechle r...@linux-mips.org Ralf -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 12/31] MIPS: Add instruction format information for WAIT, MTC0, MFC0, et al.

2013-06-14 Thread Ralf Baechle
information for WAIT, MTC0, MFC0, et al. Looks good. Acked-by: Ralf Baechle r...@linux-mips.org I wonder if somebody could throw in microMIPS equivalent to this patch? Ralf -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 13/31] mips/kvm: Add accessors for MIPS VZ registers.

2013-06-14 Thread Ralf Baechle
Acked-by: Ralf Baechle r...@linux-mips.org Ralf -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 14/31] mips/kvm: Add thread_info flag to indicate operation in MIPS VZ Guest Mode.

2013-06-14 Thread Ralf Baechle
Acked-by: Ralf Baechle r...@linux-mips.org Ralf -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Commit f9afbd45b0d0 broke mips r4k.

2013-06-13 Thread Ralf Baechle
On Wed, Jun 12, 2013 at 09:35:16PM -0500, Rob Landley wrote: My aboriginal linux project builds tiny linux systems to run under qemu, producing as close to the same system as possible across a bunch of different architectures. The above change broke the mips r4k build I've been running under

Re: [PATCH 00/31] KVM/MIPS: Implement hardware virtualization via the MIPS-VZ extensions.

2013-06-10 Thread Ralf Baechle
On Mon, Jun 10, 2013 at 12:40:42AM +0100, Maciej W. Rozycki wrote: How different MIPS SMP systems are? o Old SGI heavy metal (several different system architectures). o Cavium OCTEON SMP SoCs. o Broadcom (several flavors) SoCs o Loongson o Old DEC hardware (DECsystem

Re: [PATCH -next] ia64, metag: Do not export min_low_pfn in arch-specific code

2013-05-22 Thread Ralf Baechle
On Sun, Apr 28, 2013 at 11:24:35AM +0100, James Hogan wrote: On 27 April 2013 19:20, Geert Uytterhoeven ge...@linux-m68k.org wrote: As of commit 787dcbe6984b3638e94f60d807dcb51bb8a07211 (MIPS: Export symbols used by KVM/MIPS module), min_low_pfn is already exported by the generic

Re: [PATCH] KVM/MIPS32: Export min_low_pfn.

2013-05-19 Thread Ralf Baechle
On Fri, May 17, 2013 at 02:42:48PM -0700, David Daney wrote: On 05/17/2013 02:06 PM, Sanjay Lal wrote: The KVM module uses the standard MIPS cache management routines, which use min_low_pfn. This creates and indirect dependency, requiring min_low_pfn to be exported. Signed-off-by: Sanjay

Re: [PATCH 3/3] KVM/MIPS32: Fix up KVM breakage caused by d532f3d26716a39dfd4b88d687bd344fbe77e390 which allows ASID mask and increment to be determined @ runtime.

2013-05-17 Thread Ralf Baechle
On Fri, May 17, 2013 at 02:25:12PM -0700, Sanjay Lal wrote: Date: Fri, 17 May 2013 14:25:12 -0700 From: Sanjay Lal sanj...@kymasys.com To: kvm@vger.kernel.org Cc: linux-m...@linux-mips.org, r...@linux-mips.org, g...@redhat.com, mtosa...@redhat.com, Sanjay Lal sanj...@kymasys.com Subject:

Re: [PATCH v2 15/18] MIPS: Pull in MIPS fix: fix endless loop when processing signals for kernel tasks.

2013-01-24 Thread Ralf Baechle
On Wed, Nov 21, 2012 at 06:34:13PM -0800, Sanjay Lal wrote: This bug is discussed in: http://lkml.indiana.edu/hypermail/linux/kernel/1205.2/00719.html Dropped, see c90e6fbb220d44988cb65af3707367c57cdb65a8 [MIPS: Fix endless loop when processing signals for kernel tasks]. Ralf -- To

Re: [PATCH v2 02/18] KVM/MIPS32: Arch specific KVM data structures.

2013-01-24 Thread Ralf Baechle
On Wed, Dec 26, 2012 at 03:14:45PM +0200, Gleb Natapov wrote: On Wed, Nov 21, 2012 at 06:34:00PM -0800, Sanjay Lal wrote: + +#ifndef __unused +#define __unused __attribute__((unused)) +#endif + There are __maybe_unused and __always_unused, no need to define your own. Also the symbol

Re: [PATCH v2 00/18] KVM for MIPS32 Processors

2013-01-24 Thread Ralf Baechle
On Wed, Nov 21, 2012 at 06:33:58PM -0800, Sanjay Lal wrote: I've queued the patch set. I've done a few stylistic changes such as getting rid of all use of ulong and u_long data types in favor of unsigned long. I also ran into the following modpost error ERROR: kvm_arch_vcpu_postcreate

Re: [PATCH 01/20] KVM/MIPS32: Infrastructure/build files.

2012-11-10 Thread Ralf Baechle
On Wed, Oct 31, 2012 at 11:17:22AM -0400, Sanjay Lal wrote: index 7dd65cf..d2cfe45 100644 --- a/arch/mips/Kbuild +++ b/arch/mips/Kbuild @@ -17,3 +17,7 @@ obj- := $(platform-) obj-y += kernel/ obj-y += mm/ obj-y += math-emu/ + +ifdef CONFIG_KVM +obj-y += kvm/ +endif Shorter: